godotengine
/
godot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Remove redefinition of `notification` method in `XRInterfaceExtension`

This commit is contained in:
Raul Santos 2022-09-11 12:34:07 +02:00
parent 315c64282b
commit 2108019484
No known key found for this signature in database
GPG Key ID: B532473AE3A803E4
4 changed files with 0 additions and 18 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
doc/classes/XRInterfaceExtension.xml
View File

@ -141,13 +141,6 @@
Returns [code]true[/code] if this interface has been initialized. Returns [code]true[/code] if this interface has been initialized.
</description> </description>
</method> </method>
<method name="_notification" qualifiers="virtual">
<return type="void" />
<param index="0" name="what" type="int" />
<description>
Informs the interface of an applicable system notification.
</description>
</method>
<method name="_post_draw_viewport" qualifiers="virtual"> <method name="_post_draw_viewport" qualifiers="virtual">
<return type="void" /> <return type="void" />
<param index="0" name="render_target" type="RID" /> <param index="0" name="render_target" type="RID" />

2
servers/xr/xr_interface.h
View File

@ -138,8 +138,6 @@ public:
virtual bool start_passthrough() { return false; } virtual bool start_passthrough() { return false; }
virtual void stop_passthrough() {} virtual void stop_passthrough() {}
virtual void notification(int p_what){};
XRInterface(); XRInterface();
~XRInterface(); ~XRInterface();

6
servers/xr/xr_interface_extension.cpp
View File

@ -58,8 +58,6 @@ void XRInterfaceExtension::_bind_methods() {
GDVIRTUAL_BIND(_post_draw_viewport, "render_target", "screen_rect"); GDVIRTUAL_BIND(_post_draw_viewport, "render_target", "screen_rect");
GDVIRTUAL_BIND(_end_frame); GDVIRTUAL_BIND(_end_frame);
GDVIRTUAL_BIND(_notification, "what");
/** input and output **/ /** input and output **/
GDVIRTUAL_BIND(_get_suggested_tracker_names); GDVIRTUAL_BIND(_get_suggested_tracker_names);
@ -309,10 +307,6 @@ void XRInterfaceExtension::end_frame() {
GDVIRTUAL_CALL(_end_frame); GDVIRTUAL_CALL(_end_frame);
} }
void XRInterfaceExtension::notification(int p_what) {
GDVIRTUAL_CALL(_notification, p_what);
}
RID XRInterfaceExtension::get_render_target_texture(RID p_render_target) { RID XRInterfaceExtension::get_render_target_texture(RID p_render_target) {
// In due time this will need to be enhance to return the correct INTERNAL RID for the chosen rendering engine. // In due time this will need to be enhance to return the correct INTERNAL RID for the chosen rendering engine.
// So once a GLES driver is implemented we'll return that and the implemented plugin needs to handle this correctly too. // So once a GLES driver is implemented we'll return that and the implemented plugin needs to handle this correctly too.

3
servers/xr/xr_interface_extension.h
View File

@ -123,7 +123,6 @@ public:
virtual bool pre_draw_viewport(RID p_render_target) override; virtual bool pre_draw_viewport(RID p_render_target) override;
virtual Vector<BlitToScreen> post_draw_viewport(RID p_render_target, const Rect2 &p_screen_rect) override; virtual Vector<BlitToScreen> post_draw_viewport(RID p_render_target, const Rect2 &p_screen_rect) override;
virtual void end_frame() override; virtual void end_frame() override;
virtual void notification(int p_what) override;
GDVIRTUAL0(_process); GDVIRTUAL0(_process);
GDVIRTUAL0(_pre_render); GDVIRTUAL0(_pre_render);
@ -131,8 +130,6 @@ public:
GDVIRTUAL2(_post_draw_viewport, RID, const Rect2 &); GDVIRTUAL2(_post_draw_viewport, RID, const Rect2 &);
GDVIRTUAL0(_end_frame); GDVIRTUAL0(_end_frame);
GDVIRTUAL1(_notification, int);
/* access to some internals we need */ /* access to some internals we need */
RID get_render_target_texture(RID p_render_target); RID get_render_target_texture(RID p_render_target);
// RID get_render_target_depth(RID p_render_target); // RID get_render_target_depth(RID p_render_target);