godotengine
/
godot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Merge pull request #48609 from akien-mga/3.x-fix-tileset-signal-error 

TileSet: Fix signal disconnect error in some situation
This commit is contained in:
Rémi Verschelde 2021-05-10 16:04:39 +02:00 committed by GitHub
parent 18277679a7 6e920d0c14
commit 71f8b910ff
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
editor/plugins/tile_set_editor_plugin.cpp
View File

@ -3602,12 +3602,16 @@ void TileSetEditorPlugin::make_visible(bool p_visible) {
if (p_visible) { if (p_visible) {
tileset_editor_button->show(); tileset_editor_button->show();
editor->make_bottom_panel_item_visible(tileset_editor); editor->make_bottom_panel_item_visible(tileset_editor);
if (!get_tree()->is_connected("idle_frame", tileset_editor, "_on_workspace_process")) {
get_tree()->connect("idle_frame", tileset_editor, "_on_workspace_process"); get_tree()->connect("idle_frame", tileset_editor, "_on_workspace_process");
}
} else { } else {
editor->hide_bottom_panel(); editor->hide_bottom_panel();
tileset_editor_button->hide(); tileset_editor_button->hide();
if (get_tree()->is_connected("idle_frame", tileset_editor, "_on_workspace_process")) {
get_tree()->disconnect("idle_frame", tileset_editor, "_on_workspace_process"); get_tree()->disconnect("idle_frame", tileset_editor, "_on_workspace_process");
} }
}
} }
Dictionary TileSetEditorPlugin::get_state() const { Dictionary TileSetEditorPlugin::get_state() const {