godotengine
/
godot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Mono: Fix crash on script load if the scripts domain isn't loaded

This commit is contained in:
Ignacio Etcheverry 2018-04-24 20:36:17 +02:00
parent 098c7ba4f9
commit 89e84185e8
1 changed files with 15 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
modules/mono/csharp_script.cpp
View File

@ -2288,7 +2288,9 @@ RES ResourceFormatLoaderCSharpScript::load(const String &p_path, const String &p
CRASH_COND(mono_domain_get() == NULL); CRASH_COND(mono_domain_get() == NULL);
#endif #endif
#else #endif
#ifdef TOOLS_ENABLED
if (Engine::get_singleton()->is_editor_hint() && mono_domain_get() == NULL) { if (Engine::get_singleton()->is_editor_hint() && mono_domain_get() == NULL) {
CRASH_COND(Thread::get_caller_id() == Thread::get_main_id()); CRASH_COND(Thread::get_caller_id() == Thread::get_main_id());
@ -2297,14 +2299,20 @@ RES ResourceFormatLoaderCSharpScript::load(const String &p_path, const String &p
// because this may be called by one of the editor's worker threads. // because this may be called by one of the editor's worker threads.
// Attach this thread temporarily to reload the script. // Attach this thread temporarily to reload the script.
MonoThread *mono_thread = mono_thread_attach(SCRIPTS_DOMAIN); if (SCRIPTS_DOMAIN) {
CRASH_COND(mono_thread == NULL); MonoThread *mono_thread = mono_thread_attach(SCRIPTS_DOMAIN);
script->reload(); CRASH_COND(mono_thread == NULL);
mono_thread_detach(mono_thread); script->reload();
mono_thread_detach(mono_thread);
}
} else // just reload it normally } else { // just reload it normally
#endif
script->reload();
#ifdef TOOLS_ENABLED
}
#endif #endif
script->reload();
if (r_error) if (r_error)
*r_error = OK; *r_error = OK;