godotengine/godot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Merge pull request #63238 from joaopedrosgs/patch-1

Browse Source 
Fix incorrect expression base in `AnimationNodeStateMachinePlayback::_check_advance_condition`
This commit is contained in:
Rémi Verschelde 2022-07-24 20:09:25 +02:00 committed by GitHub
commit b3df27526a
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
scene/animation/animation_node_state_machine.cpp
View File

@ -630,7 +630,7 @@ bool AnimationNodeStateMachinePlayback::_check_advance_condition(const Ref<Anima
Node *expression_base = tree_base->get_node_or_null(advance_expression_base_node_path); Node *expression_base = tree_base->get_node_or_null(advance_expression_base_node_path);
if (expression_base) { if (expression_base) {
Ref<Expression> exp = transition->expression; Ref<Expression> exp = transition->expression;
bool ret = exp->execute(Array(), tree_base, false, Engine::get_singleton()->is_editor_hint()); // Avoids allowing the user to crash the system with an expression by only allowing const calls. bool ret = exp->execute(Array(), expression_base, false, Engine::get_singleton()->is_editor_hint()); // Avoids allowing the user to crash the system with an expression by only allowing const calls.
if (!exp->has_execute_failed()) { if (!exp->has_execute_failed()) {
if (ret) { if (ret) {
return true; return true;