d6e17b8a0d
Fix FlowContainer scale from also scaling wrap point
...
When a FlowContainer was scaled, the point at which a line wraps would
also be scaled. This would cause a FlowContainer to have lines that did
not fit the container.
FlowContainer no longer factors its scale when resorting children.
Fixes #93439
2024-06-21 19:13:43 -04:00
0fefd6cc80
Fix GridContainer minimum size when there's a hidden parent
...
When calculating minimum size, GridContainer only looks at children that are
returned from `as_sortable_control()`. That defaults to only showing children
visible in the tree, so if the grid has a hidden parent the minimum size
becomes (0, 0).
After this change only the child itself needs to be visible, making
`GridContainer::get_minimum_size()` behave the same way as other controls.
Fixes #91722 .
2024-06-20 13:49:09 +03:00
fbb879debd
[Scene] Add `SceneStringNames::text/value_changed`
2024-06-19 09:44:38 +02:00
ca18a06ecb
[Scene] Add `SceneStringNames::confirmed`
2024-06-19 09:40:54 +02:00
d9e2fc74c7
[Scene] Add `SceneStringNames::item_selected`
2024-06-19 09:39:05 +02:00
39ab252ba1
Merge pull request #93140 from bruvzg/rtl_table_bg_sep
...
[RTL] Fix table h/v separation alignment.
2024-06-18 17:59:13 +02:00
fb3d489baa
Merge pull request #93137 from bruvzg/rtl_row_align
...
[RTL] Fix `align_to_row` for the last table row.
2024-06-18 17:59:10 +02:00
d519715d94
[Scene] Add `SceneStringNames::font(_size/_color)`
2024-06-18 17:24:27 +02:00
8ac0d81825
[RTL] Fix table h/v separation alignment.
2024-06-15 17:55:08 +03:00
23fbdacef8
[RTL] Fix `align_to_row` for the last table row.
2024-06-13 22:03:34 +03:00
35b4b5f779
[Button] Do not include internal margins into base button minimum size.
2024-06-13 14:18:44 +03:00
630d3eb35e
Don't error when undo stack is empty
2024-06-11 12:16:36 -04:00
034e579fa5
Merge pull request #92901 from kleonc/texture-progress-bar-fix-radial-mode-2-point-polygon-edge-case
...
Fix `TextureProgressBar` radial mode invalid polygon edge case
2024-06-11 16:59:31 +02:00
a0bbd398ee
Merge pull request #93008 from aaronp64/container_queue_sort
...
Fix `Container::pending_sort` tracking
2024-06-11 11:53:42 +02:00
972839d12a
Merge pull request #92968 from bruvzg/rtl_list_indent
...
[RTL] Fix list item prefix width not taken into account.
2024-06-11 11:22:52 +02:00
5a25637ca9
Fix Container::pending_sort tracking
...
When Container::queue_sort() is called, pending_sort is set to true to indicate when a call to _sort_children() is queued, to avoid queueing multiple calls. Container::_sort_children() sets pending_sort back to false when finished, but did not do this when the container was not inside the tree. This would allow cases where queue_sort() could be called just before removing from the tree, causing _sort_children() to never reset pending_sort, preventing any future queue_sort() calls from queueing again.
One case where this happened was with the "Saving Scene" progress bar in the editor - when saving for the first time (or the first time the progress bar popup otherwise appeared in the editor), _sort_children() would be called successfully. After the progress bar popup was hidden, then shown again on future saves, _sort_children() would not be called again, resulting in the progress bar not taking up as much space as it should.
This issue used to be avoided by setting pending_sort to false immediately on NOTIFICATION_ENTER_TREE - however, this would allow multiple calls to be queued at the same time when entering the tree (#92644 ). The multiple calls was fixed recently by removing this assignment, but this also made possible the case where pending_sort is never reset.
This change sets pending_sort back to false in _sort_children() whether or not it's in the tree. Since this is done in a deferred call, it should still avoid the previous issue of multiple calls being queued at once on entering the tree.
Fixes #92971
2024-06-10 20:17:47 -04:00
721a663aa3
[Button] Adds theme option to align button text and icon to either largest or current stylebox.
2024-06-10 18:40:52 +03:00
fff71db5b1
[RTL] Fix list item prefix width not taken into account.
2024-06-10 13:14:56 +03:00
b14b222e9d
Fix native file dialogs being shown on `set_visible(false)`
2024-06-09 17:54:18 +03:00
7f6951b1f6
Fix TextureProgressBar radial mode invalid polygon edge case
2024-06-08 13:51:32 +02:00
a6bb8b00d7
Merge pull request #92664 from KoBeWi/ultimate_final_solution_for_containers
...
Add visibilty mode to `as_sortable_control()`
2024-06-07 23:29:48 +02:00
2c01573fdf
Merge pull request #92645 from WhalesState/container-resort
...
Fix `NOTIFICATION_SORT_CHILDREN` is called twice on startup
2024-06-07 23:29:44 +02:00
1ee953030e
Merge pull request #92271 from kitbdev/fix-max-line-size
...
Fix TextEdit HScroll hiding after wrapping
2024-06-07 23:29:28 +02:00
c2d983553b
Merge pull request #91390 from kitbdev/add-selection-unhide-carets
...
Unhide carets in add selection for occurrence and fix error
2024-06-07 23:29:23 +02:00
7c2d65ff66
Merge pull request #92745 from bruvzg/rtl_list_fix
...
[RTL] Fix nested ordered lists inside unordered lists.
2024-06-04 10:10:34 +02:00
5e616cedd4
[RTL] Fix nested ordered lists inside unordered lists.
2024-06-04 08:08:16 +03:00
d45b896673
Fix IME activation in subviewports.
2024-06-04 00:03:02 +03:00
02e1e6d1ec
Add visibilty mode to as_sortable_control()
2024-06-03 20:01:31 +02:00
9b4cfcba5f
Merge pull request #92669 from Hilderin/fix-huge-tscn-icon-in-background-of-file-system-panel
...
Fix huge .tscn icon and icon in background of File System panel
2024-06-03 10:36:02 +02:00
81395cf9bd
Fix Huge .tscn Icon and icon in background of File System panel
2024-06-02 09:11:56 -04:00
62a58c5538
Fix `NOTIFICATION_SORT_CHILDREN` is called twice on startup
2024-06-01 15:49:43 +00:00
6ecccd6085
Fix RichTextLabel table overlapping with next line
...
When calculating table height, RichTextLabel::_shape_line would increase the height when it reached the end of a complete row, or the final cell of the table. RichTextLabel::_resize_line would only increase the height at the end of a complete row, causing the height to ignore the final row if not all cells were populated. This would cause the final row to overlap with the following line in the RichTextLabel if it was the last visible line in the RichTextLabel, as _resize_line is called when updating scrolling properties.
This change moves the common table size calculations to a separate function to reuse the code between _shape_line and _resize_line, keeping the final cell check that was used in _shape_line.
Fixes #92603
2024-05-31 16:21:17 -04:00
07e6d0c702
Merge pull request #92138 from YeldhamDev/scrollcontainer_fixes
...
Fix scrollbar issues in `ScrollContainer`
2024-05-31 14:16:10 +02:00
926afccbd8
[Scene] Add `SceneStringNames::panel`
2024-05-30 22:54:50 +02:00
755a0efbb6
[Scene] Add `SceneStringNames::id_pressed`
2024-05-30 22:54:04 +02:00
505da68b26
Merge pull request #92565 from bruvzg/rtl_clear_flags
...
[RTL] Clear default justification flags if custom are set.
2024-05-30 22:13:59 +02:00
3a52e0f5fd
[RTL] Clear default justification flags if custom are set and fix typo in the flag name.
2024-05-30 21:23:26 +03:00
af6b96c486
Fix minimap error when moving to the top
2024-05-30 12:06:02 -04:00
adbc4b086b
Merge pull request #92489 from kleonc/control-invalidate-global-transform-before-notifying-resize
...
Invalidate `Control` global transform before notifying about resize / rect change
2024-05-30 11:48:09 +02:00
4cd39c56fb
Merge pull request #92283 from KoBeWi/code_simpleton
...
Automatically use property count in PropertyListHelper
2024-05-30 11:47:58 +02:00
22b6f962d9
Invalidate Control global transform before notifying about resize / rect change
2024-05-30 10:10:24 +02:00
219af366a5
Merge pull request #92505 from bruvzg/te_ro_margins
...
[TextEdit] Use style margins for selection in read-only mode.
2024-05-29 11:20:14 +02:00
05442e81c0
Merge pull request #92500 from timothyqiu/stretch-shrink-range
...
Add range hint for `SubViewportContainer.stretch_shrink`
2024-05-29 11:20:11 +02:00
b60471f3c0
Merge pull request #92463 from Daylily-Zeleen/daylily-zeleen/fix_graph_edit_minimap_connection_line
...
[GraphEdit] Convert to minimap line after getting connection line.
2024-05-29 11:20:04 +02:00
9bb858c803
Merge pull request #92460 from bruvzg/adlg_cancel_conf
...
Fix duplicate AcceptDialog cancel/confirm events.
2024-05-29 11:20:01 +02:00
1d0a8ea828
[TextEdit] Use style margins for selection in read-only mode.
2024-05-29 10:07:32 +03:00
28a2fa496f
[GraphEdit] Convert to minimap line after getting connection line.
2024-05-29 12:58:51 +08:00
fd5118c781
Add range hint for SubViewportContainer.stretch_shrink
2024-05-29 09:03:15 +08:00
43cf4740b9
Merge pull request #92461 from bruvzg/rtl_meta_y
...
[RTL] Use real text/object height instead of line height for meta click/hover detection.
2024-05-28 16:13:26 +02:00
194b1c478d
Merge pull request #92342 from aaronp64/textedit_duplication
...
Remove duplicate if/else code in `TextEdit::_notification`
2024-05-28 15:49:19 +02:00
a10897ddc0
Merge pull request #92301 from robert-wallis/fix-code-edit-delimiter-crash
...
Fix crash during code editor folding and LSP
2024-05-28 15:49:09 +02:00
13a32e2753
Merge pull request #92296 from timothyqiu/complete-remove-override
...
Fix theme StyleBox override parameter completion
2024-05-28 15:49:05 +02:00
cfe80f9fec
Merge pull request #92222 from semensanyok/fix-TextureButton-click-mask-texture-size-ignored-if-missing-normal-texture
...
Fix TextureButton's click mask texture size ignored if missing normal texture
2024-05-28 15:48:58 +02:00
061ad36732
[RTL] Use real text/object height instead of line height for meta click/hover detection.
2024-05-28 11:46:56 +03:00
3e691e026b
Fix duplicate AcceptDialog cancel/confirm events.
2024-05-28 10:46:28 +03:00
948f09632e
Unhide carets in add selection for occurrence
2024-05-27 15:30:18 -04:00
66a8ee71aa
Fix TextEdit HScroll hiding after wrapping
2024-05-27 14:56:55 -04:00
05cc8e7aaf
Remove duplicate if/else code in TextEdit::_notification
2024-05-25 10:50:04 -04:00
63554c7765
Fix TextureButton's click mask texture size ignored if missing normal texture
2024-05-25 15:40:09 +02:00
b365a63403
Automatically use property count in PropertyListHelper
2024-05-25 10:51:37 +02:00
0e97e1bc62
Fix crash during code editor folding and LSP
2024-05-23 20:01:11 -07:00
8652e9914f
Fix theme StyleBox override parameter completion
...
Also added completion for remove_theme_*_override.
2024-05-24 08:12:53 +08:00
cb3ce85902
Fix `PopupMenu` focus issues after `Viewport::set_embedding_subwindows` is changed.
2024-05-22 11:17:43 +03:00
ea7860c614
Fix CheckBox and CheckButton not using max_icon_width
2024-05-20 10:40:21 +02:00
9353081338
Fix scrollbar issues in `ScrollContainer`
2024-05-19 22:20:43 -03:00
85463fd5eb
Merge pull request #92042 from bruvzg/fix_edit_popup
...
Fix Tree and FileSystemList edit popup double events and ESC behavior.
2024-05-17 13:00:38 +02:00
0d5e910a91
Merge pull request #92009 from bruvzg/btn_min_size
...
Improve button min. size calculation.
2024-05-17 11:14:08 +02:00
62353747e5
Merge pull request #91720 from kitbdev/fix-textedit-minimap
...
Fix TextEdit minimap tab drawing and click check
2024-05-17 11:13:52 +02:00
7d4d63b807
Fix Tree and FileSystemList edit popup double events and ESC behavior.
2024-05-17 10:03:52 +03:00
ea379e3b3a
Improve button min. size calculation.
2024-05-16 22:37:12 +03:00
6a067a4a80
[GraphEdit] Fix GraphNode's ports interactable through other GraphNodes
2024-05-15 19:55:43 +02:00
c0d2464d6b
Merge pull request #91939 from AThousandShips/pressed_sname
...
[Scene] Add `SceneStringNames::pressed`
2024-05-14 18:10:05 +02:00
380f63489f
Merge pull request #91728 from kitbdev/assimilate-split-container
...
Use `as_sortable_control()` in SplitContainer
2024-05-14 18:09:51 +02:00
ee79386f7b
[Scene] Add SceneStringNames::pressed
2024-05-14 15:51:28 +02:00
bdefe53992
Merge pull request #91909 from KoBeWi/have_fun_reviewing_this
...
Use Core/Scene stringnames consistently
2024-05-14 12:07:03 +02:00
2b3d913906
Merge pull request #91802 from Rindbee/round-icon-rect-when-drawing-the-button
...
Round the icon's drawing rect when drawing the button
2024-05-14 12:06:48 +02:00
413c11357d
Use Core/Scene stringnames consistently
2024-05-13 23:41:07 +02:00
dcd6db8680
Merge pull request #90534 from Geometror/vs-reroute-node
...
[VisualShader] Add reroute node and improve port drawing
2024-05-13 12:05:25 +02:00
62776842df
[VisualShader] Add reroute node and improve port drawing
2024-05-13 03:26:01 +02:00
a262d2d881
Add shorthand for using singleton string names
2024-05-11 18:53:08 +02:00
82fef614ce
Round the icon's drawing rect when drawing the button
...
Each component of the icon's drawing rect needs to be snapped to an
integer.
2024-05-11 00:15:36 +08:00
9c388ce5d3
Merge pull request #91760 from groud/fix_PropertyListHelper_not_handling_array_size
...
Fix `PropertyListHelper::_get_property` returning a valid value even if an index is outside the array valid indices
2024-05-10 10:48:42 +02:00
7705265477
Fix PropertyListHelper::_get_property returning a valid value even if an index is outside the array valid indices
...
Co-authored-by: Tomasz Chabora <kobewi4e@gmail.com>
2024-05-10 10:46:04 +02:00
1fd1adc285
Fix placement of ColorPicker in the editor
2024-05-09 15:16:33 +03:00
d8acd8caa6
Use `as_sortable_control()` in SplitContainer
2024-05-08 13:17:34 -04:00
a53c8e8d70
Fix TextEdit minimap tab drawing and click check
2024-05-08 11:43:44 -04:00
a9a1d0a162
Merge pull request #91619 from AThousandShips/find_improve
...
Replace `find` with `contains/has` where applicable
2024-05-08 14:35:44 +02:00
eb570463a2
Revert as_sortable_control() change in SplitContainer
2024-05-08 13:36:49 +02:00
a0dbdcc3ab
Replace `find` with `contains/has` where applicable
...
* Replaces `find(...) != -1` with `contains` for `String`
* Replaces `find(...) == -1` with `!contains` for `String`
* Replaces `find(...) != -1` with `has` for containers
* Replaces `find(...) == -1` with `!has` for containers
2024-05-08 12:37:42 +02:00
281fe39929
Merge pull request #91699 from KoBeWi/buff_tree_folding
...
Fold TreeItems when clicking to the left of fold icon
2024-05-08 12:31:39 +02:00
5c28814b39
Add as_sortable_control() to unify Container checks
2024-05-08 11:45:52 +02:00
9bc5a85b2b
Fold TreeItems when clicking to the left of fold icon
2024-05-08 11:30:26 +02:00
316c4d50d5
Merge pull request #91112 from RandomShaper/fix_double_confirm
...
Avoid double handling of rename in the file system dock
2024-05-07 16:49:34 +02:00
82b6f9d7a7
Fetch argument options from ThemeDB
2024-05-07 15:02:50 +02:00
eb2bd41fb8
Make handling of rename line-edit popups more robust
2024-05-07 14:29:35 +02:00
472273f07a
Merge pull request #91326 from aaronp64/line_edit_min_size
...
Update `LineEdit` to include `read_only` StyleBox in `get_minimum_size()`
2024-05-07 13:48:44 +02:00
e63252b421
Merge pull request #90705 from AThousandShips/foreach_list
...
Reduce and prevent unnecessary random-access to `List`
2024-05-07 09:04:44 +02:00
965bae735e
Merge pull request #72323 from Koyper/flow_container_center_wrap_options
...
Add FlowContainer wrap options for center alignment.
2024-05-07 09:04:34 +02:00
57cd00aee9
Avoid incorrect computing anchor of Control node when reset on save
2024-05-05 08:33:37 +09:00
955d5affa8
Reduce and prevent unnecessary random-access to `List`
...
Random-access access to `List` when iterating is `O(n^2)` (`O(n)` when
accessing a single element)
* Removed subscript operator, in favor of a more explicit `get`
* Added conversion from `Iterator` to `ConstIterator`
* Remade existing operations into other solutions when applicable
2024-05-04 16:08:55 +02:00
Javi Rodriguez
Anni Ryynänen
A Thousand Ships
Rémi Verschelde
bruvzg
kit
aaronp64
kleonc
kobewi
Hilderin
Mounir Tohami
Daylily-Zeleen
Haoyu Qiu
semensanyok
Robert Wallis
Riley Willows
Michael Alexsander
Hendrik Brucker
风青山
Gilles Roudière
Yuri Rubinsky
Pedro J. Estébanez
Silc Lizard (Tokage) Renew