1731010774
GDScript: Fix override signature check of script inheritance
...
Avoid treating the super class as a meta type for signature check, since
it is looking at the instance level for that.
2023-02-21 14:37:08 -03:00
d076c76551
GDScript: Fix setting native type with script inheritance
...
Sometimes the inheritance tree is compiled out of order and the base
don't have yet a native type set. This is now changed to not rely on the
base script but use the native type set in the datatype, which is
already resolved by the analyzer.
2023-02-21 14:09:10 -03:00
0866e6af2d
GDScript: Avoid validated division operation to test for zero
...
The validated operations for integer division and modulo do not check
for division by zero. This avoids validated operation in these cases to
make sure the check is performed and avoid crashing the engine.
2023-02-21 11:12:45 -03:00
91b93465d5
GDScript: Fix crash when autoload script can't be found
2023-02-21 10:45:24 -03:00
8eb837dc3d
Add test for const class references
2023-02-20 23:01:32 -05:00
c9e49c487d
GDScript: Limit recursion depth for completion functions
...
Avoid crashing if the completion gets stuck in infinite recursion while
trying to guess the expression type.
2023-02-20 14:55:13 -03:00
2057d7344e
Merge pull request #73590 from vnen/gdscript-global-scope-enums
...
Make global scope enums accessible as types in GDScript
2023-02-20 15:41:45 +01:00
ea2bc9795c
Merge pull request #73544 from mashumafi/fix-func-arg-null
...
Fix: Func with typed args error when arg is null
2023-02-20 15:41:40 +01:00
561d949739
Merge pull request #73489 from vonagam/type-check-node
...
GDScript: Rework type check
2023-02-20 15:41:36 +01:00
6bf63a3542
Merge pull request #73291 from vonagam/fix-unsafe-weak-binop
...
GDScript: Fix missing unsafety mark for binary op with weak variables
2023-02-20 15:41:32 +01:00
30d4d3fa5e
Fix: Func with typed args error when arg is null
2023-02-19 21:47:48 -05:00
75f16b8167
Make global scope enums accessible as types in GDScript
...
Add functions to CoreConstant so enums can be properly deduced. Also add
the enums in release builds to make consistent with ClassDB enums and
avoid differences in script compilation between debug and release.
2023-02-19 13:00:07 -03:00
78cd5d813b
Merge pull request #73501 from anvilfolk/oopsiedaisy
...
Fix inability to assign null regression
2023-02-18 04:38:47 +03:00
24344de4f5
Merge pull request #73448 from RandomShaper/fix_sticky_stack
...
Avoid GDScript bookkeeping from referencing objects longer than necessary
2023-02-17 23:22:20 +03:00
5e9400fa50
Avoid GDScript bookkeeping from referencing objects longer than necessary
2023-02-17 18:59:17 +01:00
8fe023ad93
GDScript: Rework type check
2023-02-17 19:57:18 +02:00
9eb4d1e4bf
Fix inability to assign null regression
...
Co-authored-by: Dmitry Maganov <vonagam@gmail.com>
2023-02-17 11:45:56 -05:00
6212da66e8
Merge pull request #72867 from vnen/gdscript-limit-call-depth
...
GDScript: Add limit to call depth
2023-02-17 17:00:46 +03:00
6e0dd6beca
Merge pull request #72925 from vonagam/fix-enum-typed-array-error
...
GDScript: Fix error about enum typed arrays
2023-02-17 16:47:50 +03:00
68807165f4
Merge pull request #73398 from anvilfolk/fix-getter
...
Fix unset getter return types resulting in strange behavior
2023-02-17 00:31:42 +01:00
a845553898
Merge pull request #73364 from anvilfolk/fix-freed
...
Fix crash by freed object assign to typed variable
2023-02-17 00:31:19 +01:00
c45970739e
Fix crash by freed object assign to typed variable
2023-02-16 15:17:46 -05:00
5972ba17a4
GDScript: Fix infer on read-only property
2023-02-16 15:50:17 +02:00
94dfac8da7
Add return type for GDScript getters
2023-02-15 17:54:38 -05:00
8d3e682f52
GDScript: Fix default value of exported enum variable
2023-02-14 18:07:50 +03:00
df6aae2eca
GDScript: Fix missing unsafety mark for binary op with weak variables
2023-02-14 17:01:21 +02:00
436bbfebe2
Tweak `@GlobalScope` & `GDScript`'s documentation
2023-02-14 13:26:18 +01:00
9cb2da89d6
GDScript: Fix usage of ints with typed array of floats
2023-02-13 22:06:38 +02:00
d405392847
Revert "Fixed the jumping to function definition using 'Ctrl+LMB'."
...
This reverts commit 7eb6367d5cFixes #73058 .
Fixes #73167 .
This caused regressions, we'll retry with fixes for 4.1.
2023-02-13 17:58:59 +01:00
be4d8a7b2e
Improve GDScript error for method call on null/previously freed instance
...
Fixes #53878 .
2023-02-12 21:52:05 +01:00
cb2e73d578
Merge pull request #73033 from akien-mga/gdscript-fix-gd4-renames-build
...
Clean up ProjectConverter3To4 architecture, move renames map to separate file
2023-02-11 22:05:38 +01:00
532381562e
Merge pull request #72654 from RandomShaper/ptrcall_ret_raw_obj
...
Avoid losing references to objects in the native-scripting boundary
2023-02-11 15:35:01 +01:00
e19e6b09b9
Clean up ProjectConverter3To4 architecture, move renames map to separate file
...
This allows properly limiting what features depend on the RegEx module
(doing the actual conversion) and what features only require the renames
data (GDScript suggestions).
Also better excludes the conversion command line options when actually
disabling deprecated code.
Fixes #73029 .
2023-02-10 14:35:22 +01:00
220898a69f
GDScript: Remove `treat_warnings_as_errors` project setting
2023-02-10 10:16:33 +03:00
dc7f08b556
Merge pull request #72971 from vnen/gdscript-multiline-comment
...
GDScript: Allow strings as multiline comments
2023-02-09 16:19:03 +01:00
6fca54a81b
Merge pull request #72975 from vnen/gdscript-no-ascii-spoof-check
...
GDScript: Be more lenient with identifiers
2023-02-09 16:12:09 +01:00
03ea77407c
GDScript: Be more lenient with identifiers
...
- Allow identifiers similar to keywords if they are in ASCII range.
- Allow constants to be treated as regular identifiers.
- Allow keywords that can be used as identifiers in expressions.
2023-02-09 11:19:05 -03:00
f95967c299
GDScript: Allow strings as multiline comments
...
Bring back the behavior in 3.x that was left out by oversight.
2023-02-09 10:16:00 -03:00
b12bf7ff02
Merge pull request #69550 from Rindbee/fix-script-editor-not-reload-via-lsp
...
Fix internal editor not updating when using external editor via LSP
2023-02-09 14:01:33 +01:00
cedc5fa823
GDScript: Fix error about enum typed arrays
2023-02-09 00:31:40 +02:00
e822182bb7
Fix null message in assert()
2023-02-08 20:19:24 +01:00
34f0a2ca46
GDScript: Add limit to call depth
...
The hard limit is set at 2048 depth which seems sensible between
legitimate recursive calls while still avoiding a crash because of a
stack overflow in most of the cases.
Note that it is still possible to reach the stack limit and get an
overflow before reaching a call depth. This is intended as a half-way
measure to stop crashing in most cases, since there's no reliable nor
portable way to check the amount of stack memory left.
2023-02-07 17:09:40 -03:00
bd267c911b
Merge pull request #72493 from dalexeev/gds-export-flags
...
GDScript: Improve validation and documentation of `@export_flags`
2023-02-07 19:38:21 +01:00
3f95b39cb3
Merge pull request #72789 from Vilcrow/fix-jump-to-definition
...
Fixed the jumping to function definition using 'Ctrl+LMB'.
2023-02-07 19:37:50 +01:00
c8e3d8b5d5
GDScript: Improve validation and documentation of `@export_flags`
2023-02-07 19:32:08 +03:00
826e54fa73
Some code simplifications
...
1. `number_width` isn't used later
2. `return_type` is used only once
3. AudioServer::get_singleton()->get_channel_count() always returns a channel_count of 1 or larger
4. negative `aa->backward` conditional
5. `current_canvas` == `find_world_2d()->get_canvas()`
6. identical if `render_shadows`
2023-02-07 14:30:16 +01:00
7eb6367d5c
Fixed the jumping to function definition using 'Ctrl+LMB'.
2023-02-07 05:29:48 +03:00
945207885b
Merge pull request #72546 from vonagam/fix-typed-array-can-reference
...
GDScript: Fix can_reference check for typed arrays
2023-02-06 23:32:47 +03:00
c0edea37ef
Merge pull request #72677 from dalexeev/gds-await-infer-type
...
GDScript: Fix `await` type inference
2023-02-06 23:32:28 +03:00
7b86a082be
Merge pull request #72804 from vnen/gdscript-no-onready-without-node
...
GDScript: Fix inheritance check of @onready for inner classes
2023-02-06 23:03:44 +03:00
685db28e29
GDScript: Fix `await` type inference
2023-02-06 23:02:14 +03:00
9d16250353
Merge pull request #70002 from poohcom1/fix/static-subscript-autocomplete
...
Fix code-completion suggesting non-static members for custom classes
2023-02-06 23:02:12 +03:00
de4369ca4b
Merge pull request #72708 from KoBeWi/PackedMultilineStringArray
...
Fix @export_multiline for PackedStringArray
2023-02-06 23:01:16 +03:00
8400308ab3
GDScript: Fix can_reference check for typed arrays
2023-02-06 22:00:16 +02:00
ed5ddab7e5
GDScript: Fix inheritance check of @onready for inner classes
2023-02-06 14:52:13 -03:00
2fdaf2919c
GDScript: Fix recently merged test not ignoring warnings
2023-02-06 18:19:34 +01:00
eee343210d
Merge pull request #72330 from MinusKube/unreachable_code_bug
...
Fix unreachable code warning for elif block
2023-02-06 17:49:37 +01:00
d201df1ffa
Merge pull request #72512 from vonagam/fix-ternary-type-source
...
GDScript: Fix type certainty for result of ternary operator
2023-02-06 19:41:27 +03:00
8a37fad281
Merge pull request #72794 from vnen/gdscript-no-onready-without-node
...
GDScript: Don't allow @onready without inheriting Node
2023-02-06 15:41:02 +01:00
3941af3d91
GDScript: Don't allow @onready without inheriting Node
2023-02-06 10:45:38 -03:00
31749de128
GDScript: Better handling of `@rpc` annotation and autocompletion
2023-02-05 21:21:37 +03:00
13f0158e49
Merge pull request #72608 from vnen/gdscript-warning-default-error
...
GDScript: Add warnings that are set to error by default (take 2)
2023-02-05 16:00:26 +03:00
2b71ede967
Fix @export_multiline for PackedStringArray
2023-02-04 17:06:58 +01:00
8753b07b05
Merge pull request #71860 from GeroVeni/master
...
Improve docs for rpc annotations
2023-02-04 18:43:15 +03:00
54f2226ce5
Improve docs for rpc annotations
2023-02-04 13:28:41 +00:00
0bcc7bb5c7
Avoid losing references to objects in the native-scripting boundary
2023-02-03 17:48:41 +01:00
604493eb6e
Merge pull request #65910 from KoBeWi/gdsus
...
Cleanup function state connections when destroying instance
2023-02-03 16:13:06 +01:00
a43ec333c4
Merge pull request #72398 from vnen/gdscript-setter-chain
...
GDScript: Improve usability of setter chains
2023-02-02 16:28:07 +01:00
273bf7210f
GDScript: Add warnings that are set to error by default
...
- Adds a list of default levels for all warning so they can be set
individually.
- Add warnings set by default to error for:
- Using `get_node()` without `@onready`.
- Using `@onready` together with `@export`.
- Inferring a static type with a Variant value.
- Overriding a native engine method.
- Adjust how annotations to ignore warnings are treated so they also
apply to method parameters.
- Clean up a bit how ignored warnings are set. There were two sets but
only one was actually being used.
- Set all warnings to the `WARN` level for tests, so they they can be
properly tested.
- Fix enum types in native methods signatures being set to `int`.
- Fix native enums being treated as Dictionary by mistake.
- Make name of native enum types use the class they are defined in, not
the direct super class of the script. This ensures they are always
equal even when coming from different sources.
- Fix error for signature mismatch that was only showing the first
default argument as having a default. Now it shows for all.
2023-02-02 12:07:25 -03:00
5fc7918594
GDScript: Improve usability of setter chains
...
- Consider PackedArrays non-shared since they are copied on C++/script
boundaries.
- Add error messages in the analyzer when assigning to read-only
properties.
- Add specific error message at runtime when assignment fails because
the property is read-only.
2023-02-02 10:20:35 -03:00
9b93bdb4e7
Fix crash in gdscript when autocompleting virtual function and signature does not match base.
2023-02-02 22:52:08 +10:00
824784f80b
Merge pull request #72557 from vonagam/fix-make-value-protection
...
GDScript: Fix getting reduced value of incomplete subscript for autocomplete
2023-02-02 09:49:37 +01:00
4311836be2
GDScript: Fix crash in export group annotations
2023-02-02 08:37:39 +03:00
7b04e3865a
GDScript: Fix getting reduced value of incomplete subscript
2023-02-02 02:15:26 +02:00
1a810ff45e
GDScript: Fix type certainty for result of ternary operator
2023-02-01 14:52:29 +02:00
061b046401
Merge pull request #72499 from vonagam/fix-typed-array-disassembly
...
GDScript: Fix disassembly of typed array assignment and construction
2023-02-01 11:03:25 +01:00
afe3b94ab2
Revert "GDScript: Add warnings that are set to error by default"
...
This reverts commit a166833bfaFixes #72501 .
2023-02-01 10:54:22 +01:00
56aedb256e
GDScript: Fix disassembly of typed array assignment and construction
2023-02-01 11:18:54 +02:00
e101305950
Merge pull request #72487 from vnen/gdscript-warning-default-error
...
GDScript: Add warnings that are set to error by default
2023-02-01 08:23:42 +01:00
9aeda3b282
Merge pull request #72490 from resistor/disasm
...
Fix disassembly of OPCODE_CONSTRUCT_TYPED_ARRAY.
2023-02-01 08:02:04 +01:00
ab2f8ab6ce
Merge pull request #72371 from dalexeev/remove-gds-str-duplicate
...
Remove `@GDScript.str` (duplicate of `@GlobalScope.str`)
2023-02-01 07:25:02 +01:00
835309c0a5
Fix disassembly of OPCODE_CONSTRUCT_TYPED_ARRAY.
...
Found while inspecting the bytecode for godot-benchmarks.
2023-01-31 21:52:51 -06:00
a166833bfa
GDScript: Add warnings that are set to error by default
...
- Adds a list of default levels for all warning so they can be set
individually.
- Add warnings set by default to error for:
- Using `get_node()` without `@onready`.
- Using `@onready` together with `@export`.
- Inferring a static type with a Variant value.
- Overriding a native engine method.
- Adjust how annotations to ignore warnings are treated so they also
apply to method parameters.
- Clean up a bit how ignored warnings are set. There were two sets but
only one was actually being used.
- Set all warnings to the `WARN` level for tests, so they they can be
properly tested.
- Fix enum types in native methods signatures being set to `int`.
- Fix native enums being treated as Dictionary by mistake.
- Make name of native enum types use the class they are defined in, not
the direct super class of the script. This ensures they are always
equal even when coming from different sources.
- Fix error for signature mismatch that was only showing the first
default argument as having a default. Now it shows for all.
2023-02-01 00:05:14 -03:00
925784df03
Merge pull request #72454 from dalexeev/gds-fix-icon-annotation
...
GDScript: Fix `@icon` annotation
2023-01-31 15:58:49 +01:00
6d9c9d30b9
Merge pull request #72206 from vnen/gdscript-allow-void-return-shorthand
...
GDScript: Allow void functions to return calls to other void functions
2023-01-31 15:55:35 +01:00
361f3f1721
Merge pull request #57520 from jordigcs/gd-rename-map
...
Add hint for identifiers renamed from 3.x to 4.0
2023-01-31 15:55:25 +01:00
83cb968965
GDScript: Fix `@icon` annotation
2023-01-31 17:43:54 +03:00
a47d4d57ca
GDScript: Allow void functions to return calls to other void functions
2023-01-31 11:37:30 -03:00
e768e02b78
Merge pull request #72444 from reduz/fix-global-class-parsing
...
Fix global script class parsing.
2023-01-31 13:20:00 +01:00
1bbe0a2b2f
Fix global script class parsing.
...
* Broke with #72226
* Restored previous version of the code, made it even more error tolerant.
* Added a warning to **not** change the code.
Fixes #72226 .
2023-01-31 12:43:25 +01:00
99a44f8469
Merge pull request #69248 from vonagam/fixing-typed-arrays
...
GDScript: Fix typed arrays
2023-01-31 11:04:21 +01:00
5909f9f075
GDScript: Fix issues with typed arrays
2023-01-31 11:54:41 +02:00
b6a8b8e8f7
Merge pull request #72212 from anvilfolk/gdtestnames
...
Add option to print filenames in GDScript unit testing
2023-01-31 10:53:28 +01:00
199e5dbb1e
Add option to print filenames in GDScript unit testing
2023-01-30 22:20:45 -05:00
dc7fb30485
Merge pull request #72400 from vnen/gdscript-match-release-consistency
...
GDScript: Fix match branches return check on release
2023-01-30 20:27:12 +01:00
65407dd42d
GDScript: Fix match branches return check on release
...
The check for existence of `return` only existed on debug builds for
match branches. This could lead on an invalid error after exporting. Now
this is checked on relase too, so it works the same as the editor.
2023-01-30 15:18:36 -03:00
011b3895db
GDScript: Fix vararg method calls with exact arguments
2023-01-30 19:38:07 +02:00
af57bdb193
Merge pull request #72305 from dalexeev/gfs-fix-export-enum
...
GDScript: Fix `@export_enum` works only with `int`
2023-01-30 14:47:12 +01:00
be4f36b87e
Remove `@GDScript.str` (duplicate of `@GlobalScope.str`)
2023-01-30 14:29:07 +03:00
d4b78c352f
GDScript: Fix `@export_enum` works only with `int`
2023-01-30 12:30:37 +03:00
George Marques
mashumafi
Rémi Verschelde
Yuri Sizov
Pedro J. Estébanez
Dmitrii Maganov
ocean (they/them)
Danil Alexeev
Micky
pkowal
Rémi Verschelde
kobewi
Markus Sauermann
S.V.I. Vilcrow
GeroVeni
Eric M
Owen Anderson
Juan Linietsky