The previous implementation assumed that the intersection entered or exited a
shape when it hit right on the common edge of 2 triangles. However, there is
also a case where it just "skirts" the other shape on the outside.
To fix this, we added code to check the intersection distance and if the
normals of the faces are pointed in the same direction as the intersection or
not (e.g. inner product > 0). This handles the case where the intersection
line hits the common edge of 2 triangles and skirts the other shape on the
outside.
Extended code to cover a third case.
Fixes#58637.
Co-authored-by: OldBelge <StevenGeens@users.noreply.github.com>
(cherry picked from commit eaa84bc682)
This is check is a bit too eager. The user should be able to handle the
return value even if it's a freed object.
(cherry picked from commit abbdf80643)
project settings.
We'll default to a sensible value in the case that a user has
somehow managed to modify the configuration file incorrectly.
Closes 69819
(cherry picked from commit 5a08091168)
* Project Manager ignores display mode settings.
* EditorFileDialog's default display mode and show hidden files settings
are not updated when corresponding editor settings change.
(cherry picked from commit 2ccc9e1456)
This helps to find such classes without digging
through the rest of the class reference.
Editor-only classes can still be found under
your normal "Node" and "Resource" types.
This also fixes a typo and a missed case from the recent platform docs PR.
(cherry picked from commit 3ae282b452)
Version 7.3.0 changes the build layout which causes updates to the generated shared libraries to not be picked up.
(cherry picked from commit 4507d3a38c)
The checkout might be too shallow so the before commit isn't available.
The logic was already written to take this into account (it then generates
an empty 'changed.txt' which falls back to testing everything), but the
error code would still force terminate the job.
Hopefully we can find a way to make the logic work for merge events too in
the future, but for now this is a quick fix.
(cherry picked from commit 9063e907a7)
- file_format, header_guards and clang-format benefit from this short list.
- dotnet-format, Python and JS checks don't, but they're only relevant for
PRs changing a specific set of files, so we skip them when those files
aren't modified.
The logic to get changed files only works reliably for:
- Pull request events
- Non-force pushed push events
So when force pushing a branch in your fork, or creating a new branch,
it will still scan all files as fallback.
Upgraded CI runner to Ubuntu 22.04 so we get clang-format 14 out of the box,
so we don't need to install a custom version (saves ~15 s). We also cache
the APT dependencies to speed up the build and avoid flaky Ubuntu/Microsoft
repos.
(cherry picked from commit 068f893072)
Justin Wash
K. S. Ernest (iFire) Lee
kobewi
Rémi Verschelde
George Marques
Pedro J. Estébanez
bitsawer
Devin
Rémi Verschelde
Yuri Sizov
VolTer
Winston
Ninni Pipping
Fredia Huya-Kouadio
Eoin O'Neill
Rindbee
Roman Vasilyev
sodaJar
Haoyu Qiu
Adam Scott
Samuele Panzeri
Fredia Huya-Kouadio
clayjohn
Hugo Locurcio
Paweł
MistMage
kleonc
bruvzg