Commit Graph

3647 Commits

Author SHA1 Message Date
Malcolm Nixon 5115b119f8 Fix memory corruption and assert failures in convex decomposition
This PR fixes how triangular faces are decomposed into vertices and indices. The pre-increment resulted in the indices table skipping entry 0 and potentially overrunning the end of the vertices vector.

(cherry picked from commit bf7cdc5229)
2024-01-23 20:22:01 +01:00
Hugo Locurcio 4cec48f1ea Fix typo in BaseMaterial3D conversion from 3.x SpatialMaterial
(cherry picked from commit 70959a9c04)
2024-01-23 20:22:00 +01:00
Rémi Verschelde 98cfa8bcf2 VideoPlayer: Fix reloading translation remapped stream
Fixes #43917.

(cherry picked from commit 7d0c561e02)
2024-01-23 20:22:00 +01:00
kobewi 326314eaa9 Provide more context when scene fails to load
(cherry picked from commit c6c872ba34)
2024-01-23 19:15:04 +01:00
bitsawer 28a44d7bbc Fix several Material texture parameter updates
(cherry picked from commit 1ec97a7b91)
2024-01-23 17:42:22 +01:00
stoofin 73b0984764 Fixed PlaneMesh tangents for 'Face X' orientation
(cherry picked from commit 6099d9f3d1)
2024-01-23 17:33:01 +01:00
A Thousand Ships f563f8bfa6 Fix invalid return from some more `_get/_set`
Invalidly returned `true` on the non-matched path

(cherry picked from commit 3ef6314980)
2024-01-23 16:54:03 +01:00
A Thousand Ships f311b0557c Fix invalid return from some `_get/_set`
Invalidly returned `true` on the non-matched path

(cherry picked from commit b04cf8486d)
2024-01-23 16:54:02 +01:00
bruvzg 8face42022 [SystemFont] Check name when selecting the best matching face from a collection.
(cherry picked from commit a5a0e48dbc)
2024-01-23 16:03:15 +01:00
Ninni Pipping c148398735 Fix incorrect virtual function in `VideoStream.set_paused`
(cherry picked from commit 2284689b0e)
2023-10-24 19:51:53 +02:00
bitsawer 08bc3570ae Fix ImporterMesh bone weight handling during lightmap unwrap
(cherry picked from commit 145503765a)
2023-10-24 17:05:24 +02:00
Lyuma 299413157a Avoid crash when generating LODs on meshes with non-finite vertices.
(cherry picked from commit acf76027bd)
2023-10-24 16:52:59 +02:00
Tom Coxon ba27e16275 Fix animation keyframes being skipped sometimes when being played backwards. #57271
(cherry picked from commit 1a52c0c543)
2023-10-24 16:52:59 +02:00
Aaron Franke 3518801deb Limit mesh complexity in LOD generation to prevent crashing
(cherry picked from commit f95f2d1149)
2023-10-24 16:52:59 +02:00
A Thousand Ships 74506ce901 Fix incorrect cast when animating `int`
Type was cast to `int` rather than `int64_t`
Also corrects `real_t` to `double`

(cherry picked from commit 035cf5e210)
2023-10-24 16:33:53 +02:00
Marcus Elg 035fece0e7 Fix GPUParticle2D offset stutter
(cherry picked from commit 936fd8db38)
2023-10-24 16:05:00 +02:00
Septian 35d622b029 Fix particle shader deterministic random values
(cherry picked from commit cb7400d67a)
2023-10-19 21:45:12 +02:00
detomon cf1674c423 Initialize MSDF parameters in BaseMaterial3D with default
(cherry picked from commit d275a7487d)
2023-10-19 21:17:46 +02:00
Rémi Verschelde aae20e5b10
Fix various typos with codespell
Also includes typo fixes from #79993, #80068, #80276, and #80303.

Co-authored-by: betalars <contact@betalars.de>
Co-authored-by: spaceyjase <429978+spaceyjase@users.noreply.github.com>
Co-authored-by: Swarkin <102416174+Swarkin@users.noreply.github.com>
Co-authored-by: Raul Santos <raulsntos@gmail.com>

(cherry picked from commit faaf27f284)
2023-10-03 20:45:35 +02:00
Hugo Locurcio a972686972 Clamp Volumetric Fog Length property to prevent rendering issues
A length of 0 units doesn't make sense anyway.

(cherry picked from commit 8041cff865)
2023-09-21 14:09:19 +02:00
Ryan Hitchman e7978fe277 Fix Curve3D baking up vectors for nontrivial curves.
The code was modified in 42aa539 to have a different basis vector, but
this line was missed and caused up vectors to invert sometimes.

Fixes #81879

(cherry picked from commit 734b9d2379)
2023-09-20 22:44:03 +02:00
bitsawer 3920b2db05 Fix empty shader resource loading
(cherry picked from commit 15eec2450a)
2023-09-20 22:44:03 +02:00
bitsawer a606b03fd7 Fix Shader and ShaderInclude resource loading
(cherry picked from commit 26e3443eef)
2023-09-20 22:44:03 +02:00
kleonc c6c5b5bf78 Fix Animation::subtract_variant for affine transforms
(cherry picked from commit 87935ca837)
2023-08-31 20:19:30 +02:00
Aaron Franke 6ecf741b7a Change property hint range for camera attributes exposure multiplier
(cherry picked from commit 59e7e8c795)
2023-08-31 19:48:17 +02:00
bitsawer 143963d122 Fix shader type detection
(cherry picked from commit 905c10bc54)
2023-08-31 19:48:16 +02:00
Septian a6b1c0edbb Fix `tween_property` on "Basis" to properly update its value
(cherry picked from commit eb7f87e9a8)
2023-07-17 12:05:43 +02:00
Chinmay Awale 4f4052581b add 3.x compatibility for animation loop mode
(cherry picked from commit 1686a7a1a2)
2023-07-10 18:09:58 +02:00
Rindbee 1c1d4f6264 Fix `PackedScene::get_last_modified_time()` always returns `0`
The variables operated by `PackedScene::set_last_modified_time()`
and `PackedScene::get_last_modified_time()` are different.

(cherry picked from commit 22edef14c3)
2023-07-10 18:09:58 +02:00
Hugo Locurcio e32330473a Remove uses of `vformat()` with no placeholders
This is identical to passing the string directly.

(cherry picked from commit dcc92c174e)
2023-07-10 17:46:07 +02:00
Ben Rog-Wilhelm 371b31c85f Fix: Incorrect property names in FontFile::_get_property_list().
(cherry picked from commit 7ee916a259)
2023-07-10 17:11:22 +02:00
Bastiaan Olij 89e64da028 Take eye offset into account for depth in StandardMaterial3D
(cherry picked from commit 581d081ded)
2023-07-10 17:11:22 +02:00
kobewi 1a9739f591 Fix crash with failed compatibility tiles 2023-06-28 15:11:10 +02:00
Rémi Verschelde cb73a6e9f9
Merge pull request #78490 from clayjohn/GLES3-particles-subemit
Add warnings and fallbacks for particles sub emitters when using the GL Compatibility rendering backend
2023-06-22 21:02:38 +02:00
clayjohn 8a5af8183a Add warnings and fallbacks for particles sub emitters when using the GL Compatibility rendering backend
Co-authored-by: Hugo Locurcio <hugo.locurcio@hugo.pro>
2023-06-21 12:56:52 -07:00
kobewi c1c5b0a435 Update indices after removing custom data layers 2023-06-21 03:12:53 +02:00
Gilles Roudière c54d407fa5 Fixes TileSet set as local to scene 2023-06-20 17:48:56 +02:00
Rémi Verschelde 73ac33342f
Merge pull request #78442 from smix8/navmesh_bake_geo_errors_4.x
Fix potential crashes in navmesh bake geometry functions
2023-06-20 09:22:03 +02:00
Rémi Verschelde ca3283b22b
Merge pull request #77278 from davthedev/stylebox-flat-polys-optimize
Remove useless polygons from StyleBoxFlat drawing
2023-06-20 09:20:27 +02:00
Rémi Verschelde 217a20a8a0
Merge pull request #78448 from akien-mga/black-23.3.0
CI: Update static checks to black 23.3.0
2023-06-20 00:05:39 +02:00
Rémi Verschelde 75ef6e486c
Merge pull request #77735 from AThousandShips/node_array_fix
Fix export of `Array[Node]`
2023-06-20 00:04:01 +02:00
Rémi Verschelde e4deaa2727
Merge pull request #76787 from RedworkDE/avoid-localvector-copy
Avoid making unnecessary copies of `LocalVector`
2023-06-20 00:01:55 +02:00
Rémi Verschelde c9c941e339
CI: Update static checks to black 23.3.0
And apply it to the codebase, removing empty lines at the start of blocks.
2023-06-19 23:33:02 +02:00
Ninni Pipping bbd4873eea Fix index in loading of `Array[Node]` 2023-06-19 23:19:38 +02:00
smix8 f3a6e04f8b Fix potential crashes in navmesh bake geometry functions
Fixes potential crashes in navmesh geometry functions.
2023-06-19 20:58:36 +02:00
Dominik 'dreamsComeTrue' Jasiński 6e6e296502
Set correct RW locks in AnimatedTexture 2023-06-19 15:21:52 +02:00
Rémi Verschelde 2d90f66ac1
Merge pull request #78323 from kleonc/tile-compat-transposed-transform-fix
Fix transform for transposed tiles in compatibility mode (from 3.x)
2023-06-16 16:52:51 +02:00
kleonc 735e7d67ca Fix transform for transposed tiles in compatibility mode (from 3.x) 2023-06-16 13:31:01 +02:00
Rémi Verschelde 7734146060
Merge pull request #78256 from Calinou/animatedtexture-fix-property-hint
Fix outdated usage of `or_lesser` in AnimatedTexture property hint
2023-06-15 10:50:53 +02:00
Rémi Verschelde 41b34e3e56
Merge pull request #78240 from KoBeWi/nothing_valid_here,_keep_scrolling
Safe-guard against missing node arrays
2023-06-15 10:50:45 +02:00