Commit Graph

1643 Commits

Author SHA1 Message Date
Yuri Sizov 10b70e2498 Rework the surface upgrade tool to inform users without blocking
This removes the immediate confirmation dialog and insteads prints the
message to the editor log (and it also appears as a toast). The immediate dialog
is a devil's plaything, and it cannot be used in this scenario (if it can be used
anywhere at all). The condition that triggers the SUT can happen during any
attempt by the rendering server to read a mesh. This means it will conflict
with a number of editor processes, like loading, importing, preview
generation, export, CLI mode, etc.

So while this is less on the nose as far as informing users goes, it's also
our best option to use the log and the toaster.
2023-11-22 19:03:14 +01:00
kobewi d84ba48d8f Avoid saving scene while already saving the scene 2023-11-20 21:57:21 +01:00
Yuri Sizov fdaee9ee89 Prevent the surface upgrade tool from running during export
Also add an explicit way to trigger the tool manually
at user's will.
2023-11-20 15:36:45 +01:00
Rémi Verschelde b049ac43ba
Merge pull request #84927 from bruvzg/macos_ext_frame_upd
[macOS] Process events before changing title style to update window frame.
2023-11-16 14:52:28 +01:00
Rémi Verschelde 6d47eff457
Merge pull request #83104 from jsjtxietian/fix-crash-when-reimport-animation-while-playing
Fix editor crash when re-importing GLTF while animation is playing
2023-11-15 13:15:54 +01:00
bruvzg c64c1053e9
[macOS] Process events before changing title style to update window frame. 2023-11-15 09:33:23 +02:00
jsjtxietian 3c10493d0b Fix Editor crash when re-importing GLTF while animation is playing 2023-11-15 11:13:42 +08:00
kobewi da55c06322 Save scene when saving built-in resource 2023-11-13 16:34:17 +01:00
Fredia Huya-Kouadio 136b7f9c52
Preserve the output from the gradle build command
Updates `EditorNode#execute_and_show_output(...)` to return the output of the executed command.
2023-11-12 12:07:04 +01:00
clayjohn 95fbb2ecb2 Scan the filesystem in the first frame when using headless mode 2023-11-07 10:46:56 +01:00
Rémi Verschelde 98baac7172
Merge pull request #84200 from clayjohn/surface-upgrade-tool-rework
Overhaul the SurfaceUpgradeTool
2023-11-01 22:32:09 +01:00
clayjohn be386e1876 Overhaul the SurfaceUpgradeTool
This defers the update to a fresh restart of the editor (to ensure we aren't mid way through loading scenes anymore.

It also ensures that the popup can't be used by multiple threads at once

Co-authored-by: Yuri Sizov <yuris@humnom.net>
2023-11-01 15:32:54 +01:00
Yuri Sizov 8c39a2d169 Disconnect `EditorNode` from file dialogs on destruction 2023-11-01 13:01:28 +01:00
kobewi a92ed50777 Make remote inspector groups not foldable 2023-10-31 17:29:53 +01:00
Rémi Verschelde 8f0b742a9a
Merge pull request #83576 from raulsntos/fix-80883
Enable new addon after hiding ProjectSettings
2023-10-30 17:47:23 +01:00
Rémi Verschelde a7c81f4275
Merge pull request #73981 from stmSi/fix-filter-files-shortcut-input-not-handling
Fix Filter Files shortcut input is not properly handled
2023-10-30 16:25:24 +01:00
Rémi Verschelde e2c79bcb95
Merge pull request #82471 from SaracenOne/recache_bone_attachment
Reimport bone attachment fixes
2023-10-30 10:18:00 +01:00
Rémi Verschelde fe64786a91
Merge pull request #83498 from SaracenOne/mesh_unwrap_rules
Mesh instance UV2 unwrapping improvements
2023-10-28 12:30:22 +02:00
Saracen e865bad06a Mesh instance UV2 unwrapping improvements:
Enforce foreign resource modification rules.
Add more helpful error handling for ArrayMesh unwrapping.
2023-10-28 03:04:15 +01:00
Saracen 4b671eec0e Reimport bone attachment fixes:
Assign bone_idx to GLTF importer to fix serialization.
Notifies Skeletons and BoneAttachments when reimporting.
Removes usage of NOTIFICATION_NODE_RECACHE_REQUESTED
2023-10-27 20:34:01 +01:00
Rémi Verschelde ba79e53dd0
Merge pull request #84048 from SaracenOne/extra_readonly_info
Add read-only info to resource embedded in other scenes.
2023-10-27 13:33:53 +02:00
Saracen ada1f66fc1 Add read-only info to resource embedded in other scenes. 2023-10-27 12:01:22 +01:00
Jordyfel 50b7387a3f Use Hashset for dependency list when moving 2023-10-25 21:05:53 +03:00
Rémi Verschelde f021d33940
Merge pull request #81167 from bitsawer/fix_sdfgi_editor_change
Reset SDFGI when changing editor scene tabs
2023-10-25 10:27:03 +02:00
Rémi Verschelde bc5d5978ea
Merge pull request #83695 from YuriSizov/core-lock-and-key
Improve threading in ClassDB and EditorHelp
2023-10-24 10:54:19 +02:00
Rémi Verschelde 50d17f6b8c
Merge pull request #83613 from clayjohn/surface_upgrade_tool
Add an editor tool to automatically upgrade and re-save meshes
2023-10-24 00:10:37 +02:00
clayjohn 318ef8461f Implementation of tool to automatically upgrade and re-save meshes 2023-10-23 22:39:48 +02:00
kit 701c8d8323 Fix tab dragging issues 2023-10-22 13:58:31 -04:00
Yuri Sizov 9b03fb36f9 Improve threading in ClassDB and EditorHelp 2023-10-20 22:14:04 +02:00
Yuri Sizov cd31407cb3 Clean up some Editor, OpenXR, VideoStream code
- EditorNode has excessive and pointless checks for Input singleton.
- EditorNode initialization order is a bit awkward.
- OpenXR binds a method that doesn't need that (for call deferred).
- VideoStream has a formatting error.
2023-10-20 17:54:39 +02:00
Rémi Verschelde 15955e5d9e
Merge pull request #83512 from zaevi/fix_remove_from_floating_dock
Editor: Fix `remove_control_from_dock` fails when dock is floating.
2023-10-20 15:08:40 +02:00
Raul Santos 7b34fa8dd2
Enable new addon after hiding ProjectSettings
- Enabling newly created addons can show a warning dialog, doing so before hiding the `ProjectSettingsEditor` dialog causes rendering glitches.
- Remove unused `PuginConfigDialog` in `EditorNode`. The one actually being used is an instance in `EditorPluginSettings`.
2023-10-18 20:20:46 +02:00
Yuri Sizov 582ed157b5 Fix StringName leaks in GDExtension, core, and editor themes 2023-10-18 17:36:20 +02:00
Rémi Verschelde e06d09228b
Merge pull request #83251 from Rindbee/fix-current_edited_scene-wrong-move
Fix saving wrong edited scene state when switching scene tabs
2023-10-18 00:01:24 +02:00
Zae acf0d395c8 Editor: Fix `remove_control_from_dock` fails when dock is floating. 2023-10-18 01:14:26 +08:00
风青山 225a5e225f Fix saving wrong edited scene state when switching scene tabs
When creating a new scene, the scene tab will actually switch to the newly created one.
Also worth noting that switching scene tabs saves state (by `save_edited_scene_state`).

When trying New Scene again, the previously empty scene tab will be removed.

So the correct logic is: switch the tab save state first, and then remove the previous
empty scene tab. To prevent `current_edited_scene` from being incorrect when saving state.
2023-10-17 22:52:44 +08:00
Rémi Verschelde 230bdda872
Merge pull request #82742 from kitbdev/empty-dock-layout
Fix loading floating dock layout
2023-10-13 11:43:35 +02:00
kobewi 41fa6c32b4 Disable update spinner when debug redraw is active 2023-10-11 13:21:29 +02:00
Saracen c0e872c05b Fix dependency menu not showing up if scene failed to load. 2023-10-09 03:15:46 +01:00
kobewi a6de7a8a3f Allow contextual plugins to persist temporarily 2023-10-06 15:58:50 +02:00
bruvzg af00c4a54a
[X11] Add support for using EGL/GLES instead of GLX. 2023-10-04 14:15:36 +03:00
kit 349da99476 fix load floating dock layout 2023-10-03 15:36:53 -04:00
Silc Lizard (Tokage) Renew 1b95827d3e Implement AnimationManager the base class of AnimationPlayer/Tree 2023-09-29 08:23:57 +09:00
Rémi Verschelde da91cf9367
Merge pull request #82347 from SaracenOne/dir_access_checks
Add error checks for DirAccess creation
2023-09-26 16:36:47 +02:00
David Snopek 2733a6f762 Implement reloading of GDExtensions 2023-09-25 22:10:17 -05:00
Saracen 3f4513d4de Add error checks for DirAccess creation. 2023-09-26 03:07:43 +01:00
Kevin Cardona c1146632b2 Add Ctrl/CMD+P as a shortcut to quick open files in addition to Shift+Alt+O 2023-09-16 15:32:37 -06:00
A Thousand Ships 75ee58fd04 [Editor] Replace `ERR_FAIL_COND` with `ERR_FAIL_NULL` where applicable 2023-09-15 20:15:39 +02:00
Yuri Sizov 8ecc0c4f47 Fix accessing editor theme items throughout the UI
This also exposes `EditorInterface::get_editor_theme`.
2023-09-15 14:51:01 +02:00
Danil Alexeev f8a0c487a8
Editor: Rearrange "Main Menu > Help" items 2023-09-07 16:17:28 +03:00