Commit Graph

3118 Commits

Author SHA1 Message Date
Hugo Locurcio
4623bbbbe3
Increase spacing slightly between ItemList and PopupMenu items 2018-10-05 17:37:39 +02:00
Jean-François Michaud
00616360a3 Fix #22588: missing preset save after removing a export preset. 2018-10-03 13:40:16 -04:00
Rémi Verschelde
dec20a987b Fix some warnings raised by MSVC 2017
Disabled signed/unsigned warnings like for GCC/Clang
(warning C4018: '>=': signed/unsigned mismatch).

Fixes the following MSVC 2017 warnings:
```
core\image.cpp(999): warning C4804: '>': unsafe use of type 'bool' in operation

core\io\compression.cpp(178): warning C4334: '<<': result of 32-bit shift implicitly converted to 64 bits (was 64-bit shift intended?)
editor\doc\doc_dump.cpp(226): warning C4334: '<<': result of 32-bit shift implicitly converted to 64 bits (was 64-bit shift intended?)
scene/resources/material.h(289): warning C4334: '<<': result of 32-bit shift implicitly converted to 64 bits (was 64-bit shift intended?)
scene/resources/material.h(298): warning C4334: '<<': result of 32-bit shift implicitly converted to 64 bits (was 64-bit shift intended?)

editor\editor_themes.cpp(379): warning C4805: '==': unsafe mix of type 'int' and type 'bool' in operation
```
2018-10-03 17:34:56 +02:00
Rémi Verschelde
c1cee80829
Merge pull request #22668 from groud/add_open_docs
Add a shortcut to the documentation in the scene tree RMB menu
2018-10-03 13:28:14 +02:00
Rémi Verschelde
93513ba818
Merge pull request #22598 from DualMatrix/animation_frame_next
Fixed animation editor not moving to next frame of sprites when editing.
2018-10-03 11:40:10 +02:00
groud
980aa276e3 Add a shortcut to the documentation in the scene tree RMB menu 2018-10-03 11:25:18 +02:00
Michael Alexsander Silva Dias
1316595c96 Remove "Doc Path" setting 2018-10-02 22:17:31 -03:00
merumelu
9f76b6a5a5 PluginConfigDialog: pass subfolder name instead of plugin name on creation
Also add `_exit_tree` to the script template
2018-10-02 22:15:13 +02:00
Rémi Verschelde
540db0a0e7
Merge pull request #22329 from DualMatrix/no_select
Made children of Containers not selectable.
2018-10-02 16:39:00 +02:00
Rémi Verschelde
0b73a9e403
Merge pull request #22618 from akien-mga/fix-warnings
Fix warnings on virtual methods [-Woverloaded-virtual] [-Wdelete-non-…
2018-10-02 14:32:06 +02:00
Rémi Verschelde
12d80e9d83
Merge pull request #22613 from lupoDharkael/del-manager
Project manager: remove projects with delete key
2018-10-02 13:49:24 +02:00
Rémi Verschelde
4e3db841af
Merge pull request #22617 from Chaosus/fix_path
Fix script path for warnings
2018-10-02 13:47:24 +02:00
Rémi Verschelde
c026e3957a Fix warnings on virtual methods [-Woverloaded-virtual] [-Wdelete-non-virtual-dtor]
Fixes the following Clang 7 warnings:
```
editor/editor_help.h:123:7: warning: 'EditorHelpIndex::popup' hides overloaded virtual function [-Woverloaded-virtual]
editor/editor_help.h:95:7: warning: 'EditorHelpSearch::popup' hides overloaded virtual function [-Woverloaded-virtual]
editor/editor_help.h:96:7: warning: 'EditorHelpSearch::popup' hides overloaded virtual function [-Woverloaded-virtual]
editor/plugins/curve_editor_plugin.h:141:15: warning: 'CurvePreviewGenerator::generate' hides overloaded virtual function [-Woverloaded-virtual]
editor/plugins/script_editor_plugin.h:70:7: warning: 'ScriptEditorQuickOpen::popup' hides overloaded virtual function [-Woverloaded-virtual]
editor/quick_open.h:69:7: warning: 'EditorQuickOpen::popup' hides overloaded virtual function [-Woverloaded-virtual]
main/tests/test_io.cpp:53:15: warning: 'TestIO::TestMainLoop::input_event' hides overloaded virtual function [-Woverloaded-virtual]
servers/audio/effects/audio_effect_record.h:69:15: warning: 'AudioEffectRecordInstance::process_silence' hides overloaded virtual function [-Woverloaded-virtual]

core/os/memory.h:119:2: warning: destructor called on non-final 'ContextGL_X11' that has virtual functions but non-virtual destructor [-Wdelete-non-virtual-dtor]
core/os/memory.h:119:2: warning: destructor called on non-final 'EditorScriptCodeCompletionCache' that has virtual functions but non-virtual destructor [-Wdelete-non-virtual-dtor]
core/os/memory.h:119:2: warning: destructor called on non-final 'Engine' that has virtual functions but non-virtual destructor [-Wdelete-non-virtual-dtor]
core/os/memory.h:119:2: warning: destructor called on non-final 'PhysicalBone::JointData' that has virtual functions but non-virtual destructor [-Wdelete-non-virtual-dtor]
core/os/memory.h:119:2: warning: destructor called on non-final 'VisualServerScene' that has virtual functions but non-virtual destructor [-Wdelete-non-virtual-dtor]
core/os/memory.h:119:2: warning: destructor called on non-final 'VisualServerViewport' that has virtual functions but non-virtual destructor [-Wdelete-non-virtual-dtor]
```
2018-10-02 13:40:17 +02:00
Chaosus
54d44f7076 Fix script path for warnings 2018-10-02 13:07:55 +03:00
lupoDharkael
006021236a Project manager: remove projects with delete key 2018-10-02 11:28:18 +02:00
Rémi Verschelde
106acb27f9
Merge pull request #22568 from dlasalle/#14959
Explicitly show viewport 0 in the SpatialEditorPlugin if the container is large enough.
2018-10-02 11:26:29 +02:00
Rémi Verschelde
dd3f6a04db
Merge pull request #21679 from pgruenbacher/spatial_editor_viewport_get_camera
added get_camera_method to spatial editor plugin viewport
2018-10-02 11:23:14 +02:00
Rémi Verschelde
876456754d
Merge pull request #21421 from YeldhamDev/mult_view_changes
Small improvements to the Spatial Editor's multiple viewport mode
2018-10-02 11:22:49 +02:00
Rémi Verschelde
648b21228e
Merge pull request #22009 from DualMatrix/warning
Added warning when disabling editable_instance
2018-10-02 09:50:40 +02:00
Rémi Verschelde
0349d6db23
Merge pull request #22220 from Naryosha/dialog
Fix find-in-files and go-to-line dialog (partially)
2018-10-02 09:41:21 +02:00
Rémi Verschelde
7aca38e218
Merge pull request #22354 from evandropoa/resources_list_icon_issue
Fix icon issue for the resource list popup #22320.
2018-10-02 09:30:21 +02:00
Rémi Verschelde
879e4d8312
Merge pull request #22364 from YeldhamDev/rect2_inspector_singleline
Make Rect2 EditorProperty obey the horizontal setting
2018-10-02 09:27:40 +02:00
Rémi Verschelde
53fbd93409
Merge pull request #22593 from akien-mga/fix-warnings
Fix various warnings raised by Clang 7
2018-10-02 00:01:31 +02:00
Rémi Verschelde
22c3995a04
Merge pull request #22576 from DualMatrix/multi_edit_exit
Fixed inspector not going back to single-node when deselecting an item.
2018-10-01 23:44:27 +02:00
Rémi Verschelde
413f078125
Merge pull request #22584 from DualMatrix/editor_path_no_update
Fixed name of deleted node not dissapearing from inspector dock.
2018-10-01 23:43:58 +02:00
Rémi Verschelde
b2bba4be44 Fix warnings about invalid logical not on left hand side [-Wlogical-not-parentheses]
Fixes the following Clang 7 warnings and bugs:
```
editor/plugins/curve_editor_plugin.cpp:208:69: warning: logical not is only applied to the left hand side of this comparison [-Wlogical-not-parentheses]
editor/plugins/curve_editor_plugin.cpp:214:43: warning: logical not is only applied to the left hand side of this comparison [-Wlogical-not-parentheses]
```

Changed according to @Zylann's suggestion on
https://github.com/godotengine/godot/pull/22593#discussion_r221699573
2018-10-01 23:21:46 +02:00
DualMatrix
127940bd55 Fixed animation editor not moving to next frame of sprites when editing.
Fixed animation editor not moving to next frame of sprites when editing.
2018-10-01 21:44:57 +02:00
Rémi Verschelde
9258d7b5d0 Fix warnings about uninitialized vars [-Wsometimes-uninitialized]
Fixes the following Clang 7 warnings:
```
drivers/gles3/rasterizer_scene_gles3.cpp:1260:10: warning: variable 'target' is used uninitialized whenever switch case is taken [-Wsometimes-uninitialized]
drivers/gles3/rasterizer_scene_gles3.cpp:1280:10: warning: variable 'target' is used uninitialized whenever switch case is taken [-Wsometimes-uninitialized]
drivers/gles3/rasterizer_scene_gles3.cpp:1281:10: warning: variable 'target' is used uninitialized whenever switch case is taken [-Wsometimes-uninitialized]
drivers/gles3/rasterizer_scene_gles3.cpp:1282:10: warning: variable 'target' is used uninitialized whenever switch case is taken [-Wsometimes-uninitialized]
drivers/gles3/rasterizer_scene_gles3.cpp:1286:5: warning: variable 'target' is used uninitialized whenever switch default is taken [-Wsometimes-uninitialized]
editor/editor_properties_array_dict.cpp:982:15: warning: variable 'change_index' is used uninitialized whenever 'if' condition is false [-Wsometimes-uninitialized]
editor/editor_properties.cpp:2655:6: warning: variable 'lt' is used uninitialized whenever switch default is taken [-Wsometimes-uninitialized]
editor/settings_config_dialog.cpp:367:11: warning: variable 'current_search_box' is used uninitialized whenever 'if' condition is false [-Wsometimes-uninitialized]
```
2018-10-01 17:33:08 +02:00
Rémi Verschelde
b1b625f4f5 Fix various Clang 7 warnings about unused stuff
Namely:
[-Wunneeded-internal-declaration]
[-Wunused-comparison]
[-Wunused-const-variable]
[-Wunused-function]
[-Wunused-private-fields]

Fixes the following Clang 7 warnings:
```
editor/plugins/script_editor_plugin.cpp:1417:20: warning: function '_find_node_with_script' is not needed and will not be emitted [-Wunneeded-internal-declaration]
editor/scene_tree_dock.cpp:1859:14: warning: function '_find_last_visible' is not needed and will not be emitted [-Wunneeded-internal-declaration]

modules/gdscript/gdscript_parser.cpp:7838:19: warning: equality comparison result unused [-Wunused-comparison]

scene/resources/mesh.cpp:549:35: warning: unused variable '_array_types' [-Wunused-const-variable]
scene/resources/mesh.cpp:563:18: warning: unused variable '_format_translate' [-Wunused-const-variable]

drivers/gles3/rasterizer_scene_gles3.cpp:54:28: warning: unused function 'store_transform2d' [-Wunused-function]

core/io/file_access_network.h:50:6: warning: private field 'ml' is not used [-Wunused-private-field]
core/io/file_access_zip.h:93:14: warning: private field 'archive' is not used [-Wunused-private-field]
core/io/resource_format_binary.h:122:6: warning: private field 'bin_meta_idx' is not used [-Wunused-private-field]
core/message_queue.h:47:9: warning: private field 'mutex' is not used [-Wunused-private-field]
main/tests/test_gui.cpp:63:11: warning: private field 'control' is not used [-Wunused-private-field]
modules/gdscript/gdscript_parser.h:558:7: warning: private field 'completion_static' is not used [-Wunused-private-field]
platform/x11/os_x11.h:148:11: warning: private field 'ip_unix' is not used [-Wunused-private-field]
platform/x11/os_x11.h:180:7: warning: private field 'net_wm_icon' is not used [-Wunused-private-field]
platform/x11/os_x11.h:189:6: warning: private field 'audio_driver_index' is not used [-Wunused-private-field]
platform/x11/os_x11.h:190:15: warning: private field 'capture_idle' is not used [-Wunused-private-field]
servers/physics/body_pair_sw.h:79:6: warning: private field 'cc' is not used [-Wunused-private-field]
servers/visual/visual_server_raster.h:62:7: warning: private field 'draw_extra_frame' is not used [-Wunused-private-field]
```
2018-10-01 17:32:12 +02:00
Rémi Verschelde
686f6ff279 Fix mismatched class/struct definition warnings [-Wmismatched-tags]
Fixes the following Clang 7 warnings:
```
core/object.cpp:44:1: warning: '_ObjectDebugLock' defined as a struct here but previously declared as a class [-Wmismatched-tags]
core/variant_call.cpp:43:1: warning: '_VariantCall' defined as a struct here but previously declared as a class [-Wmismatched-tags]
drivers/gles3/rasterizer_storage_gles3.h:765:2: warning: 'MultiMesh' defined as a struct here but previously declared as a class [-Wmismatched-tags]
editor/editor_node.h:794:1: warning: 'EditorProgress' defined as a struct here but previously declared as a class [-Wmismatched-tags]
modules/bullet/rigid_body_bullet.h:230:17: warning: class 'KinematicUtilities' was previously declared as a struct [-Wmismatched-tags]
modules/bullet/space_bullet.h:60:1: warning: class 'btSoftBodyWorldInfo' was previously declared as a struct [-Wmismatched-tags]
scene/resources/world_2d.cpp:40:1: warning: 'SpatialIndexer2D' defined as a struct here but previously declared as a class [-Wmismatched-tags]
scene/resources/world.cpp:39:1: warning: 'SpatialIndexer' defined as a struct here but previously declared as a class [-Wmismatched-tags]
servers/audio/reverb_sw.cpp:60:1: warning: 'ReverbParamsSW' defined as a struct here but previously declared as a class [-Wmismatched-tags]
thirdparty/bullet/BulletSoftBody/btSoftBody.h:43:1: warning: 'btSoftBodyWorldInfo' defined as a struct here but previously declared as a class [-Wmismatched-tags]
```
2018-10-01 17:02:47 +02:00
DualMatrix
ec463b036a Fixed inspector not going back to single-node when deselecting an item.
Fixed inspector not going back to single-node when deselecting an item.
2018-10-01 12:26:32 +02:00
DualMatrix
3ef241623e Fixed name of deleted node not dissapearing from inspector dock.
Fixed name of deleted node not dissapearing from inspector dock.
2018-10-01 12:15:22 +02:00
Rémi Verschelde
6bfb7944d9 SCons: Remove avoidable defines from main env's CPPPATH
Also finally move freetype to its own env and disable warnings for it.
Still needs some work to fix the awkward situation of the freetype and
svg modules used in scene/ and editor/ respectively.
2018-10-01 11:59:22 +02:00
Rémi Verschelde
c51caa3dbd Revert "Fix -new inspector- remote debug view not changing to current scene after exiting game - Fixes #20075"
This reverts commit 9c7e647124.

This commit caused a regression and is not a correct fix for the original issue.
Fixes #22573, reopens #20075.
2018-10-01 08:56:15 +02:00
Rémi Verschelde
3a036571f2
Merge pull request #22567 from Calinou/unselected-tabs-background
Add a subtle background and border to unselected tabs in the editor
2018-10-01 08:38:14 +02:00
Aaron Franke
cd349efb0e Minor nit-picky tweaks in spatial_editor_plugin.cpp
* Orthogonal cameras don't have an FOV that's "near zero". Or zero, or any number of degrees. It's not a measurement of degrees, it's just a fixed width. This comment is more accurate. Also, "terrible" is a better word than "awful" here.

* While I'm editing this file, the "String ortho" variable name could be more intuitive, so I've changed it to "view_mode".

Minor nit-picky changes, I know, but I found it so I may as well improve it.
2018-10-01 02:01:06 -04:00
Rémi Verschelde
80d6bb7193
Merge pull request #22521 from groud/add_favorites_file_list
Adds the display of the favorites into the file list
2018-09-30 22:59:46 +02:00
Rémi Verschelde
c23636fcdc
Merge pull request #22545 from DualMatrix/node_as_root
Fixed setting node as root deleting all non-children of that node.
2018-09-30 22:48:54 +02:00
Rémi Verschelde
c459fad43c
Merge pull request #22536 from DualMatrix/no_advance
Fixed animation_player not advancing to the next frame when inserting a value.
2018-09-30 22:16:26 +02:00
Rémi Verschelde
12ea8b9074
Merge pull request #22570 from lupoDharkael/todo-remove
Remove old TODO from editor_inspector.cpp
2018-09-30 22:10:54 +02:00
lupoDharkael
b39bcd8821 Remove old TODO from editor_inspector.cpp 2018-09-30 21:08:33 +02:00
Dominique LaSalle
df06087057 Explicitly show viewport 0 in the SpatialEditorPlugin if the container is large enough. 2018-09-30 10:09:31 -07:00
Hugo Locurcio
88755d28d7
Add a subtle background and border to unselected tabs in the editor 2018-09-30 19:01:32 +02:00
groud
0829fdafb0 Adds the display of the favorites into the file list 2018-09-30 15:32:57 +02:00
DualMatrix
6f96db4732 Fixed setting node as root deleting all non-children of that node.
Fixed setting node as root deleting all non-children of that node.
2018-09-30 00:04:18 +02:00
Rémi Verschelde
0378a9ba80
Merge pull request #22520 from akien-mga/fix-warnings
Fix warning about functions defined but not used [-Wunused-function]
2018-09-29 23:51:17 +02:00
Rémi Verschelde
dc6d95f4a1
Merge pull request #22524 from DualMatrix/error_spam_3_please_be_final
Fixed error spam when selecting root in remote tree
2018-09-29 22:44:13 +02:00
Rémi Verschelde
e1dc8e4e99
Merge pull request #22522 from DualMatrix/debugging_the_debugger_3
Fixed debugger showing wrong name for Objects.
2018-09-29 22:43:41 +02:00
Rémi Verschelde
62ecb44035 Fix warning about functions defined but not used [-Wunused-function]
Fixes the following GCC 5 warnings:
```
core/io/zip_io.h:128:26: warning: 'zlib_filefunc_def zipio_create_io_from_file(FileAccess**)' defined but not used [-Wunused-function]
core/script_debugger_remote.cpp:110:17: warning: 'ObjectID safe_get_instance_id(const Variant&)' defined but not used [-Wunused-function]
drivers/unix/socket_helpers.h:103:12: warning: 'int _socket_create(IP::Type&, int, int)' defined but not used [-Wunused-function]
drivers/unix/socket_helpers.h:45:15: warning: 'size_t _set_sockaddr(sockaddr_storage*, const IP_Address&, int, IP::Type)' defined but not used [-Wunused-function]
drivers/unix/socket_helpers.h:76:15: warning: 'size_t _set_listen_sockaddr(sockaddr_storage*, int, IP::Type, IP_Address)' defined but not used [-Wunused-function]
editor/editor_fonts.cpp:40:24: warning: 'Ref<BitmapFont> make_font(int, int, int, int, const int*, const Ref<Texture>&)' defined but not used [-Wunused-function]
editor/editor_themes.cpp:85:26: warning: 'Ref<StyleBoxFlat> change_border_color(Ref<StyleBoxFlat>, Color)' defined but not used [-Wunused-function]
editor/import/editor_import_collada.cpp:493:13: warning: 'void _generate_normals(const PoolVector<int>&, const PoolVector<Vector3>&, PoolVector<Vector3>&)' defined but not used [-Wunused-function]
editor/import/editor_import_collada.cpp:524:13: warning: 'void _generate_tangents_and_binormals(const PoolVector<int>&, const PoolVector<Vector3>&, const PoolVector<Vector3>&, const PoolVector<Vector3>&, PoolVector<float>&)' defined but not used [-Wunused-function]
editor/pvrtc_compress.cpp:118:13: warning: 'void _compress_etc(Image*)' defined but not used [-Wunused-function]
modules/etc/image_etc.cpp:89:13: warning: 'void _decompress_etc1(Image*)' defined but not used [-Wunused-function]
modules/etc/image_etc.cpp:93:13: warning: 'void _decompress_etc2(Image*)' defined but not used [-Wunused-function]
modules/gdscript/editor/gdscript_highlighter.cpp:46:13: warning: 'bool _is_whitespace(CharType)' defined but not used [-Wunused-function]
scene/2d/cpu_particles_2d.cpp:510:14: warning: 'float rand_from_seed_m1_p1(uint32_t&)' defined but not used [-Wunused-function]
scene/3d/cpu_particles.cpp:474:14: warning: 'float rand_from_seed_m1_p1(uint32_t&)' defined but not used [-Wunused-function]
scene/resources/default_theme/default_theme.cpp:123:20: warning: 'Ref<Shader> make_shader(const char*, const char*, const char*)' defined but not used [-Wunused-function]
scene/resources/default_theme/default_theme.cpp:130:24: warning: 'Ref<BitmapFont> make_font(int, int, int, int, const int*, const Ref<Texture>&)' defined but not used [-Wunused-function]
```

Had to split `core/io/zip_io.h` into header and .cpp file without 'static' keyword.

Not fixed yet (static definition in header used in some files but not all):
```
modules/websocket/lws_helper.h:111:13: warning: 'void _lws_make_protocols(void*, int (*)(lws*, lws_callback_reasons, void*, void*, size_t), PoolVector<String>, _LWSRef**)' defined but not used [-Wunused-function]
```

Also fixed a couple other warnings missed in previous commits.
2018-09-29 22:26:12 +02:00
DualMatrix
5f2f108908 Fixed animation_player not advancing to the next frame when inserting a value.
Fixed animation_player not advancing to the next frame when inserting a value.
2018-09-29 16:44:20 +02:00