Commit Graph

17139 Commits

Author SHA1 Message Date
DualMatrix 127940bd55 Fixed animation editor not moving to next frame of sprites when editing.
Fixed animation editor not moving to next frame of sprites when editing.
2018-10-01 21:44:57 +02:00
Rémi Verschelde 9258d7b5d0 Fix warnings about uninitialized vars [-Wsometimes-uninitialized]
Fixes the following Clang 7 warnings:
```
drivers/gles3/rasterizer_scene_gles3.cpp:1260:10: warning: variable 'target' is used uninitialized whenever switch case is taken [-Wsometimes-uninitialized]
drivers/gles3/rasterizer_scene_gles3.cpp:1280:10: warning: variable 'target' is used uninitialized whenever switch case is taken [-Wsometimes-uninitialized]
drivers/gles3/rasterizer_scene_gles3.cpp:1281:10: warning: variable 'target' is used uninitialized whenever switch case is taken [-Wsometimes-uninitialized]
drivers/gles3/rasterizer_scene_gles3.cpp:1282:10: warning: variable 'target' is used uninitialized whenever switch case is taken [-Wsometimes-uninitialized]
drivers/gles3/rasterizer_scene_gles3.cpp:1286:5: warning: variable 'target' is used uninitialized whenever switch default is taken [-Wsometimes-uninitialized]
editor/editor_properties_array_dict.cpp:982:15: warning: variable 'change_index' is used uninitialized whenever 'if' condition is false [-Wsometimes-uninitialized]
editor/editor_properties.cpp:2655:6: warning: variable 'lt' is used uninitialized whenever switch default is taken [-Wsometimes-uninitialized]
editor/settings_config_dialog.cpp:367:11: warning: variable 'current_search_box' is used uninitialized whenever 'if' condition is false [-Wsometimes-uninitialized]
```
2018-10-01 17:33:08 +02:00
Rémi Verschelde b1b625f4f5 Fix various Clang 7 warnings about unused stuff
Namely:
[-Wunneeded-internal-declaration]
[-Wunused-comparison]
[-Wunused-const-variable]
[-Wunused-function]
[-Wunused-private-fields]

Fixes the following Clang 7 warnings:
```
editor/plugins/script_editor_plugin.cpp:1417:20: warning: function '_find_node_with_script' is not needed and will not be emitted [-Wunneeded-internal-declaration]
editor/scene_tree_dock.cpp:1859:14: warning: function '_find_last_visible' is not needed and will not be emitted [-Wunneeded-internal-declaration]

modules/gdscript/gdscript_parser.cpp:7838:19: warning: equality comparison result unused [-Wunused-comparison]

scene/resources/mesh.cpp:549:35: warning: unused variable '_array_types' [-Wunused-const-variable]
scene/resources/mesh.cpp:563:18: warning: unused variable '_format_translate' [-Wunused-const-variable]

drivers/gles3/rasterizer_scene_gles3.cpp:54:28: warning: unused function 'store_transform2d' [-Wunused-function]

core/io/file_access_network.h:50:6: warning: private field 'ml' is not used [-Wunused-private-field]
core/io/file_access_zip.h:93:14: warning: private field 'archive' is not used [-Wunused-private-field]
core/io/resource_format_binary.h:122:6: warning: private field 'bin_meta_idx' is not used [-Wunused-private-field]
core/message_queue.h:47:9: warning: private field 'mutex' is not used [-Wunused-private-field]
main/tests/test_gui.cpp:63:11: warning: private field 'control' is not used [-Wunused-private-field]
modules/gdscript/gdscript_parser.h:558:7: warning: private field 'completion_static' is not used [-Wunused-private-field]
platform/x11/os_x11.h:148:11: warning: private field 'ip_unix' is not used [-Wunused-private-field]
platform/x11/os_x11.h:180:7: warning: private field 'net_wm_icon' is not used [-Wunused-private-field]
platform/x11/os_x11.h:189:6: warning: private field 'audio_driver_index' is not used [-Wunused-private-field]
platform/x11/os_x11.h:190:15: warning: private field 'capture_idle' is not used [-Wunused-private-field]
servers/physics/body_pair_sw.h:79:6: warning: private field 'cc' is not used [-Wunused-private-field]
servers/visual/visual_server_raster.h:62:7: warning: private field 'draw_extra_frame' is not used [-Wunused-private-field]
```
2018-10-01 17:32:12 +02:00
Rémi Verschelde 686f6ff279 Fix mismatched class/struct definition warnings [-Wmismatched-tags]
Fixes the following Clang 7 warnings:
```
core/object.cpp:44:1: warning: '_ObjectDebugLock' defined as a struct here but previously declared as a class [-Wmismatched-tags]
core/variant_call.cpp:43:1: warning: '_VariantCall' defined as a struct here but previously declared as a class [-Wmismatched-tags]
drivers/gles3/rasterizer_storage_gles3.h:765:2: warning: 'MultiMesh' defined as a struct here but previously declared as a class [-Wmismatched-tags]
editor/editor_node.h:794:1: warning: 'EditorProgress' defined as a struct here but previously declared as a class [-Wmismatched-tags]
modules/bullet/rigid_body_bullet.h:230:17: warning: class 'KinematicUtilities' was previously declared as a struct [-Wmismatched-tags]
modules/bullet/space_bullet.h:60:1: warning: class 'btSoftBodyWorldInfo' was previously declared as a struct [-Wmismatched-tags]
scene/resources/world_2d.cpp:40:1: warning: 'SpatialIndexer2D' defined as a struct here but previously declared as a class [-Wmismatched-tags]
scene/resources/world.cpp:39:1: warning: 'SpatialIndexer' defined as a struct here but previously declared as a class [-Wmismatched-tags]
servers/audio/reverb_sw.cpp:60:1: warning: 'ReverbParamsSW' defined as a struct here but previously declared as a class [-Wmismatched-tags]
thirdparty/bullet/BulletSoftBody/btSoftBody.h:43:1: warning: 'btSoftBodyWorldInfo' defined as a struct here but previously declared as a class [-Wmismatched-tags]
```
2018-10-01 17:02:47 +02:00
Rémi Verschelde 34dec26a50 Add support for '.[0-9]' numbers in Expression
Fixes #21874, supersedes #22065.
2018-10-01 16:06:21 +02:00
Rémi Verschelde c2abf1a4e9
Merge pull request #22582 from akien-mga/scons-clean-cpppath
SCons: Remove avoidable defines from main env's CPPPATH
2018-10-01 12:45:50 +02:00
DualMatrix ec463b036a Fixed inspector not going back to single-node when deselecting an item.
Fixed inspector not going back to single-node when deselecting an item.
2018-10-01 12:26:32 +02:00
DualMatrix 3ef241623e Fixed name of deleted node not dissapearing from inspector dock.
Fixed name of deleted node not dissapearing from inspector dock.
2018-10-01 12:15:22 +02:00
Rémi Verschelde 6bfb7944d9 SCons: Remove avoidable defines from main env's CPPPATH
Also finally move freetype to its own env and disable warnings for it.
Still needs some work to fix the awkward situation of the freetype and
svg modules used in scene/ and editor/ respectively.
2018-10-01 11:59:22 +02:00
Rémi Verschelde c51caa3dbd Revert "Fix -new inspector- remote debug view not changing to current scene after exiting game - Fixes #20075"
This reverts commit 9c7e647124.

This commit caused a regression and is not a correct fix for the original issue.
Fixes #22573, reopens #20075.
2018-10-01 08:56:15 +02:00
Rémi Verschelde 3a036571f2
Merge pull request #22567 from Calinou/unselected-tabs-background
Add a subtle background and border to unselected tabs in the editor
2018-10-01 08:38:14 +02:00
Rémi Verschelde b073d6c953
Merge pull request #22579 from aaronfranke/spatial-nitpicks
Minor nit-picky tweaks in spatial_editor_plugin.cpp
2018-10-01 08:33:11 +02:00
Rémi Verschelde 7ad1edcc41
Merge pull request #22572 from akien-mga/fix-warnings
Fix unnecessary parentheses warnings with GCC 8 [-Wparentheses]
2018-10-01 08:14:47 +02:00
Aaron Franke cd349efb0e Minor nit-picky tweaks in spatial_editor_plugin.cpp
* Orthogonal cameras don't have an FOV that's "near zero". Or zero, or any number of degrees. It's not a measurement of degrees, it's just a fixed width. This comment is more accurate. Also, "terrible" is a better word than "awful" here.

* While I'm editing this file, the "String ortho" variable name could be more intuitive, so I've changed it to "view_mode".

Minor nit-picky changes, I know, but I found it so I may as well improve it.
2018-10-01 02:01:06 -04:00
Juan Linietsky c24277a520 -Many GLES2 optimizations
-Android export fixes (use ETC if GLES2 backend in use)
-revert to thekla atlas because xatlas is not working well
2018-09-30 23:11:24 -03:00
Rémi Verschelde 80d6bb7193
Merge pull request #22521 from groud/add_favorites_file_list
Adds the display of the favorites into the file list
2018-09-30 22:59:46 +02:00
Rémi Verschelde b442bd06a4
Merge pull request #22566 from fire/visualscript_search_reset
After using the generic visual script search, reset the generic searc…
2018-09-30 22:51:49 +02:00
Rémi Verschelde 01e1c6e8b6
Merge pull request #22560 from lupoDharkael/clipboard
TextEdit: prevent the copy of an empty string
2018-09-30 22:49:45 +02:00
Rémi Verschelde c23636fcdc
Merge pull request #22545 from DualMatrix/node_as_root
Fixed setting node as root deleting all non-children of that node.
2018-09-30 22:48:54 +02:00
Rémi Verschelde b3c3fe29d1
Merge pull request #22543 from slapin/meshdatatool_fix
MeshDataTool memory corruption fix
2018-09-30 22:46:26 +02:00
tagcup 9f4e9fcb81 Optimized GGX G function for GLES2.
Also changed the mapping of anisotropy to match the common definition.
2018-09-30 16:33:50 -04:00
Rémi Verschelde 36e02a0fb5
Merge pull request #22537 from Zylann/fix_objectid_leak_thread
Fix dirty read of ObjectID counter when threads are involved
2018-09-30 22:28:41 +02:00
Rémi Verschelde 6d27d2d75e Fix unnecessary parentheses warnings with GCC 8 [-Wparentheses]
Fixes the following GCC 8 warnings:
```
core/object.h:321:32: warning: unnecessary parentheses in declaration of '_get_get' [-Wparentheses]
core/object.h:331:32: warning: unnecessary parentheses in declaration of '_get_set' [-Wparentheses]
core/object.h:341:32: warning: unnecessary parentheses in declaration of '_get_get_property_list' [-Wparentheses]
core/object.h:360:32: warning: unnecessary parentheses in declaration of '_get_notification' [-Wparentheses]
core/object.h:517:32: warning: unnecessary parentheses in declaration of '_get_get' [-Wparentheses]
core/object.h:520:32: warning: unnecessary parentheses in declaration of '_get_set' [-Wparentheses]
core/object.h:523:32: warning: unnecessary parentheses in declaration of '_get_get_property_list' [-Wparentheses]
core/object.h:526:32: warning: unnecessary parentheses in declaration of '_get_notification' [-Wparentheses]
```
2018-09-30 22:25:57 +02:00
Rémi Verschelde c459fad43c
Merge pull request #22536 from DualMatrix/no_advance
Fixed animation_player not advancing to the next frame when inserting a value.
2018-09-30 22:16:26 +02:00
Rémi Verschelde 4b015abfd4
Merge pull request #22571 from akien-mga/main-load-warnings
Main: Use ImageLoader directly instead of Image::load
2018-09-30 22:11:09 +02:00
Rémi Verschelde 12ea8b9074
Merge pull request #22570 from lupoDharkael/todo-remove
Remove old TODO from editor_inspector.cpp
2018-09-30 22:10:54 +02:00
Rémi Verschelde fc8b73a935 Main: Use ImageLoader directly instead of Image::load
Image::load is now issuing warnings (since ef50957) to prevent users
from using it to load images at runtime which would be included in
their exported game.

So we now use ImageLoader explicitly instead for the custom-handled
cases in Main.

Fixes #21072, supersedes #22321.
2018-09-30 21:31:16 +02:00
lupoDharkael b39bcd8821 Remove old TODO from editor_inspector.cpp 2018-09-30 21:08:33 +02:00
Dominique LaSalle df06087057 Explicitly show viewport 0 in the SpatialEditorPlugin if the container is large enough. 2018-09-30 10:09:31 -07:00
K. S. Ernest (iFire) Lee 8a7c3d1d6b After using the generic visual script search, reset the generic search mode variable to false. 2018-09-30 10:05:16 -07:00
Hugo Locurcio 88755d28d7
Add a subtle background and border to unselected tabs in the editor 2018-09-30 19:01:32 +02:00
Fabio Alessandrelli 204d39b297
Merge pull request #22563 from marcelofg55/osx_usec_fix
Fix OS X get_ticks_usec return value after #22424
2018-09-30 18:55:13 +02:00
Ferenc Arn e94f6aacee Restore the Fresnel term in the BRDF.
Was uncommented in 65fd37c, mostly likely by mistake since its important.

Also made a few corrections of specular -> specular_blob_intensity (gles2).
2018-09-30 12:17:48 -04:00
muiroc 9a5d867210 Uses skip_transform in gles2 canvas shader 2018-09-30 18:10:58 +02:00
Marcelo Fernandez d0a5ac577f Fix OS X get_ticks_usec return value after #22424 2018-09-30 13:06:46 -03:00
lupoDharkael f5f948210c TextEdit: prevent the copy of an empty string 2018-09-30 17:17:29 +02:00
Max Hilbrunner 3ee657e7a7
Merge pull request #22557 from mhilbrunner/docs-transfermodes
[DOCS] NetworkedMultiplayerPeer: TransferMode(s)
2018-09-30 16:46:33 +02:00
Max Hilbrunner 84b6394a4d
[DOCS] NetworkedMultiplayerPeer: TransferMode(s) 2018-09-30 16:45:48 +02:00
Rémi Verschelde d3f01a2281 Style: Run clang-format on recent shader changes 2018-09-30 16:31:46 +02:00
groud 0829fdafb0 Adds the display of the favorites into the file list 2018-09-30 15:32:57 +02:00
Juan Linietsky ce8294986d Some more GLES2 tuning.. 2018-09-29 23:47:24 -03:00
Juan Linietsky 3333166b07 Many more GLES2 fixes 2018-09-29 19:17:52 -03:00
DualMatrix 6f96db4732 Fixed setting node as root deleting all non-children of that node.
Fixed setting node as root deleting all non-children of that node.
2018-09-30 00:04:18 +02:00
Rémi Verschelde 0378a9ba80
Merge pull request #22520 from akien-mga/fix-warnings
Fix warning about functions defined but not used [-Wunused-function]
2018-09-29 23:51:17 +02:00
Sergey Lapin e50d56b4c6 MeshDataTool memory corruption fix
Fix for incorrect types used in MeshDataTool for bones and weights.

If your mesh contains these memory accesses get OOB and might crash
the application

Closes #21713
2018-09-30 00:23:08 +03:00
Rémi Verschelde 9768ce5763
Merge pull request #22424 from Faless/back_to_the_future
Use monotonic clock for get_ticks_usec
2018-09-29 22:55:14 +02:00
Rémi Verschelde 0eff2efe33
Merge pull request #22540 from Paulb23/fold_blank_lines_issue_15689
Fix code folding taking into account empty lines, issue 15689
2018-09-29 22:54:03 +02:00
Rémi Verschelde dc6d95f4a1
Merge pull request #22524 from DualMatrix/error_spam_3_please_be_final
Fixed error spam when selecting root in remote tree
2018-09-29 22:44:13 +02:00
Rémi Verschelde e1dc8e4e99
Merge pull request #22522 from DualMatrix/debugging_the_debugger_3
Fixed debugger showing wrong name for Objects.
2018-09-29 22:43:41 +02:00
Fabio Alessandrelli 8b2688786f Fix -Wunused-function in websocket module 2018-09-29 22:26:32 +02:00