Rémi Verschelde
c3a6dd2c11
Fix translation remapping check for imported resources
...
Fixes #81660 .
(cherry picked from commit 2729a78fd7
)
2024-01-23 19:15:02 +01:00
A Thousand Ships
36c7a47b11
Prevent `encode_variant` doing `memcpy` from `nullptr`
...
(cherry picked from commit 210461f2ed
)
2024-01-23 17:36:49 +01:00
Saracen
eb414422fe
Make notify_dependency_error only defer calls if called from secondary threads.
...
(cherry picked from commit 0b0a6109b6
)
2023-10-24 17:16:30 +02:00
David Nikdel
4d498e18ec
Remove nondeterminism in pck_packer
...
PCK files (like other build products) should be deterministic based on their inputs. Removed calls to Math::rand() that are being used to generate padding.
Looks like these were introduced as part of adding encryption support, but the padding being random does not have any cryptographic significance. This can be trivially inferred since file blocks that happen to be aligned don't get padding anyway.
If there's a desire to indroduce something that functions as a nonce it should probably be added explicitly and only if encryption is enabled.
remove Math::rand() calls in editor_export_platform.cpp
follow up to make consistent with pck_packer
(cherry picked from commit 067807c1cb
)
2023-10-24 16:33:53 +02:00
Rindbee
00d5da2f09
Clear the previously set state when configuring for a new scene root node
...
Saving a subscene causes the main scene to be re-instantiated. And the resource
instance in the main scene will be reused when the main scene is re-instantiated.
So for resources with `resource_local_to_scene` enabled, resetting state may be
necessary (at least for `ViewportTexture`).
(cherry picked from commit 4795c3cdfa
)
2023-10-19 21:49:00 +02:00
Rémi Verschelde
aae20e5b10
Fix various typos with codespell
...
Also includes typo fixes from #79993 , #80068 , #80276 , and #80303 .
Co-authored-by: betalars <contact@betalars.de>
Co-authored-by: spaceyjase <429978+spaceyjase@users.noreply.github.com>
Co-authored-by: Swarkin <102416174+Swarkin@users.noreply.github.com>
Co-authored-by: Raul Santos <raulsntos@gmail.com>
(cherry picked from commit faaf27f284
)
2023-10-03 20:45:35 +02:00
Rémi Verschelde
cdce948473
Fix GCC -Wmaybe-uninitialized warnings
...
(cherry picked from commit efdff9cbc2
)
2023-09-20 22:44:04 +02:00
Haoyu Qiu
a8bfdd8bea
Fix error when non-ASCII characters in resource pack path
...
(cherry picked from commit df5c68af99
)
2023-07-10 17:11:22 +02:00
Rémi Verschelde
da1e511f11
Linux: Allow unbundling brotli to use system library
...
(cherry picked from commit 153c4a4c4f
)
2023-07-10 17:11:22 +02:00
Rémi Verschelde
cdd2313ba2
Merge pull request #78977 from RandomShaper/workaround_tls_shutdown
...
Workaround resource loading crashes due to buggy TLS
2023-07-03 19:43:07 +02:00
Pedro J. Estébanez
41c0785636
Workaround resource loading crashes due to buggy TLS
2023-07-03 13:54:55 +02:00
Pedro J. Estébanez
30925fcfb0
Fix management of safe-for-nodes flag in ResourceLoader and WorkerThreadPool
2023-07-03 12:27:57 +02:00
Rémi Verschelde
fa971b7b5e
Merge pull request #77361 from jpcerrone/fix_pck_path_inconsistencies
...
Fix PCK file path inconsistencies
2023-06-20 00:02:22 +02:00
andybarcia
553f4f8dce
Improve error reporting when parsing CSV translation file
...
Fixes #46682 .
Also fix unit test suite to separate generic FileAccess CSV testing
from using CSV as translation. And add more CSV translation tests.
Co-authored-by: Rémi Verschelde <rverschelde@gmail.com>
2023-06-19 12:47:44 +02:00
kobewi
313c0c7f5d
Fix missing UID handling for binary formats
2023-06-16 13:40:10 +02:00
Danil Alexeev
eb391d3302
Display `BitField[Enum]` in docs to distinguish from `Enum`
2023-06-15 17:23:02 +03:00
Pedro J. Estébanez
2b001db76e
Let user scripts disable thread safety checks
2023-06-09 18:24:01 +02:00
Mack
1326b7e04f
Fix buffer over-read and memory leaks when using long filepaths in a zip archive and improved robustness of long filepaths and reading files.
2023-05-31 13:11:59 +00:00
Kory Postma
c8cac39446
Grayscale fix for Image::premultiply_alpha() and Image::convert(FORMAT_L8) while using REC.709, with added test case
2023-05-27 18:01:44 -05:00
Pedro J. Estébanez
e725b4b02b
Allow threads to mark themselves as safe for nodes
2023-05-24 00:22:58 +02:00
jpcerrone
0fb307720c
PCK file path improvements
...
Fixes godotengine#77317 (Inconsistent PCK file path behaviour).
Simplifies all PCK file paths so that paths with extra '/' symbols in them
still match to the same path.
Fixes various FileAccess methods that didn't work when using PCK paths that
contain extra '/' symbols.
2023-05-22 15:03:05 -03:00
Pedro J. Estébanez
c450260e3e
Fix message queue issues
...
- Missing flush in resource loading.
- Wrong checks about message queue instance.
2023-05-19 13:11:34 +02:00
Pedro J. Estébanez
a6e43f71b6
Avoid multiple possibilites of deadlock in resource loading
2023-05-17 01:52:39 +02:00
Fabio Alessandrelli
fb10f45efe
Merge pull request #75867 from tefusion/fix_http_client_unicode_request
...
Fix HTTPClient _request using wrong size
2023-05-14 16:05:39 +02:00
Rémi Verschelde
1c8b203f70
Merge pull request #77011 from Faless/tls/fix_crashes_when_unavailable
...
[TLS] Fix crashes trying to use TLS when not available.
2023-05-12 23:26:43 +02:00
Fabio Alessandrelli
eeac6f8c7f
[TLS] Fix crashes trying to use TLS when not available.
...
If no StreamPeerTLS implementation is available, HTTPClient and
WebSocketPeer will now correctly refuse to connect using TLS returning
ERR_UNAVAILABLE.
Similarly, ENetConnection will refuse to setup DTLS when PacketPeerDTLS
is not available.
2023-05-12 20:08:10 +02:00
Pedro J. Estébanez
45d0b38076
Enhance thread safety of loaders and importers
2023-05-12 17:44:48 +02:00
Pedro J. Estébanez
7537a0521f
Simplify ResourceLoader error callbacks
2023-05-12 17:44:48 +02:00
Pedro J. Estébanez
045401c64e
Use WorkerThreadPool for threaded resource loading
2023-05-10 18:53:41 +02:00
Pedro J. Estébanez
b6647a5808
Avoid sync issues in materials with scheduled shader updates
2023-05-10 18:53:41 +02:00
Pedro J. Estébanez
5a4613f551
Avoid sync issues in resources with deferred updates
2023-05-10 18:53:41 +02:00
Pedro J. Estébanez
8983b20ccd
Avoid interaction issues between resource loading threads
2023-05-10 18:53:41 +02:00
Rémi Verschelde
491a437df5
Merge pull request #76540 from reduz/redo-remote-filesystem
...
Redo how the remote filesystem works
2023-05-08 13:52:51 +02:00
Rémi Verschelde
e85f6871ba
Merge pull request #76561 from KoBeWi/most_obscure_class_that_has_ever_existed
...
Improve and document PackedDataContainer
2023-05-08 12:20:33 +02:00
Juan Linietsky
273a6eeb66
Redo how the remote filesystem works
...
Instead of reading files over the network, the new version uses a local file cache and only updates files when it changes.
The original remote filesystem was created 14 years ago, when ethernet was faster than hard drives or even flash. Also, mobile devices have a very small amount of storage.
Nowadays, this is no longer the case so the approach is changed to using a persistent cache in the target device.
Co-authored-by: m4gr3d
2023-05-08 11:57:54 +02:00
Clay John
610877e326
Merge pull request #72288 from MewPurPur/use-string-repeat
...
Use `String.repeat()` to optimize several String methods
2023-05-05 09:56:48 -07:00
Samuele Panzeri
59f04e16b8
Support long path in file access on windows
...
Changed windows file access file to check for path length and use the \\?\ long format when needed
2023-05-05 10:04:39 +02:00
VolTer
6b84e258d2
Use String.repeat() in more places
2023-05-01 02:27:46 +02:00
kobewi
c08e96ef0d
Improve and document PackedDataContainer
2023-04-29 00:29:40 +02:00
Rémi Verschelde
efb42c3101
Merge pull request #75447 from bruvzg/brotli_packedarray
...
Expose brotli decompression to the scripting API.
2023-04-25 16:16:56 +02:00
Danil Alexeev
36bedd341a
Fix misuses of error macros
2023-04-18 10:20:48 +03:00
Ninni Pipping
cf64e2fa47
Expose more compression formats in Image and fix compress check
...
Check for compressing ASTC checked if the function for BPTC was present
2023-04-13 09:39:03 +02:00
tefusion
1514376e46
Fix HTTPClient _request using wrong size
...
This only affects HttpClient in GDScript.
2023-04-10 11:45:41 +02:00
Bartłomiej T. Listwon
bff0c71e2e
Fix moving position indicator out of bounds in FileAccessMemory
2023-04-04 10:10:25 +02:00
Rémi Verschelde
cef3587427
Merge pull request #74120 from RandomShaper/res_loader_teardown
...
Clear resource load tasks at exit
2023-04-03 15:59:51 +02:00
bruvzg
0e4bd964cc
Expose brotli decompression to the scripting API.
2023-03-29 22:43:36 +03:00
bruvzg
09465f3fe6
Remove (or make verbose only) various debug prints.
2023-03-20 08:14:18 +02:00
Jakub Mateusz Marcowski
0a55a32085
Modify JSON.stringify so that it doesn't create unnecessary empty lines from empty arrays
2023-03-07 10:30:28 +01:00
Rémi Verschelde
e80ab423ef
Merge pull request #73793 from myaaaaaaaaa/init-race
...
Fix some race conditions that happen during initialization
2023-03-06 19:57:38 +01:00
myaaaaaaaaa
d337ed1c64
Fix data races in startup/teardown
2023-03-06 11:47:12 -05:00