Commit Graph

27058 Commits

Author SHA1 Message Date
volzhs 667a981d4d Update snap setting only with OK
restore previous values with cancel
2020-03-09 04:31:11 +09:00
Rémi Verschelde bd553d072b
Merge pull request #36821 from akien-mga/signals-property_changed-no-binds
Signals: Don't pass default binds to EditorProperty property_changed
2020-03-05 15:58:26 +01:00
Rémi Verschelde fdda39a506 Signals: Don't pass default binds to EditorProperty property_changed
This was done by mistake in #36758, but it's not necessary and actual
causes a bug.

`property_changed` is only emitted via `emit_changed()`, which already
has default values for `p_field` and `p_changing`.

Also reverted to using `String` for now to be on the safe side, even if
it's inconsistent with `emit_changed()`. I had only changed it
partially in #36758 so it was inconsistent. It probably does make sense
to port `EditorInspector` and related property editors to use
`StringName` where relevant, but that's for a dedicated PR.

Fixes #36799.
2020-03-05 15:35:44 +01:00
Rémi Verschelde 5ea8b1692a
Merge pull request #36795 from hungrymonkey/issue_36720
Change LINKFLAGS to FRAMEWORKS which is supported since Scons release 0.96.91
2020-03-05 15:21:26 +01:00
Rémi Verschelde 54a8bad8fe
Merge pull request #36700 from ThakeeNathees/scene-tab-bug-fix
Fix possible EditorFolding crash when switching scenes
2020-03-05 14:23:43 +01:00
Thakee Nathees 3275e8488b Fix EditorFolding crash when switching scenes 2020-03-05 18:19:58 +05:30
Rémi Verschelde da502f744e
Merge pull request #36813 from Faless/debugger/fix_crashes
Fix some bugs spotted by asan in editor debugger.
2020-03-05 12:51:23 +01:00
Fabio Alessandrelli e5ec499a92 Fix some bugs spotted by asan in editor debugger.
EditorDebuggerInspector is in tree, so it gets automatically deleted,
when clearing errors the debugger should not fake a process
notification.
2020-03-05 12:28:22 +01:00
Rémi Verschelde ee0f670807
Merge pull request #36772 from pyacier/warning-concavepolygonshape
Add a new configuration warning to CollisionShape
2020-03-05 12:01:59 +01:00
Rémi Verschelde e8b68c48ea
Merge pull request #36810 from akien-mga/configfile-better-errors
ConfigFile: Improve error messages
2020-03-05 11:47:12 +01:00
Pierre Caye ad227d9a85 Add a new configuration warning to CollisionShape
In the case where a ConcavePolygonShape is used as a shape for a RigidBody
in another mode than static, a configuration warning will appear in the
editor.
2020-03-05 11:18:45 +01:00
Rémi Verschelde f7c87ed3dd ConfigFile: Improve error messages and complete docs 2020-03-05 11:01:25 +01:00
Rémi Verschelde d16d554d6b
Merge pull request #36807 from akien-mga/dont-give-apples-to-the-monkeys
Mono: Fix detection of Apple platforms in build script
2020-03-05 10:25:15 +01:00
Rémi Verschelde 85ffc5ec97
Merge pull request #36746 from aaronfranke/plugin-icon-docs
Document EditorPlugin get_plugin_icon and get_plugin_name
2020-03-05 09:46:41 +01:00
Rémi Verschelde 6d269dbf56
Merge pull request #36800 from qarmin/added_some_gitignore_records
Added to .gitignore - Cppcheck folder and Gcov, Lcov code coverage
2020-03-05 09:15:05 +01:00
Rémi Verschelde 5b040ef2e8 Mono: Fix detection of Apple platforms in build script 2020-03-05 09:00:41 +01:00
Rémi Verschelde fbaa55a8db
Merge pull request #36798 from m4gr3d/android_codebase_misc_cleanup
Miscellaneous cleanup for the Android codebase
2020-03-05 08:55:56 +01:00
Rémi Verschelde cac3e2faad
Merge pull request #36788 from nekomatata/windows-permissive-flag
Remove '/permissive-' flag from Windows MSVC build
2020-03-05 08:12:00 +01:00
Rémi Verschelde 0c53f1f7db
Merge pull request #36743 from Calinou/tweak-giprobe-gizmo
Tweak the GIProbe gizmo to be more subtle
2020-03-04 22:44:44 +01:00
Rémi Verschelde 7c9e15238e
Merge pull request #36739 from Calinou/improve-giprobe-editor-label
Improve the GIProbe editor contextual label
2020-03-04 22:41:25 +01:00
Aaron Franke 68d73ecf60
Document EditorPlugin get_plugin_icon and get_plugin_name
The return value's type hint is now accurate.
2020-03-04 15:49:20 -05:00
fhuya b38283a6b7 Miscellaneous cleanup for the Android codebase:
- update gradle plugins versions
- add formatting rules for AndroidManifest and gradle build files
- cleanup java_godot_lib_jni

Note: logic was mostly moved around and no new logic/functionality was added.
2020-03-04 12:16:17 -08:00
Rémi Verschelde e89754fa1f
Merge pull request #36021 from YeldhamDev/intersects_touch_expose
Turn Rect2's 'intersects_touch()' into an extra argument of 'intersects()'
2020-03-04 20:32:20 +01:00
Rémi Verschelde 398f714dfc
Merge pull request #36792 from akien-mga/vulkan-better-debug-prints
Vulkan: Use Godot print macros matching MessageSeverity flag
2020-03-04 20:31:02 +01:00
Rémi Verschelde fadcb75e48
Merge pull request #36791 from akien-mga/scons-expand-cxx
SCons: Expand env variables to check compiler version
2020-03-04 20:30:17 +01:00
Rafał Mikrut 5b4d74edd4 Added to .gitignore - Cppcheck and code coverage 2020-03-04 20:24:38 +01:00
hungrymonkey c924e83a64 Change LINKFLAGS to FRAMEWORKS which is supported since
Scons release 0.96.91

Fixes the link errors below

clang: error: no such file or directory: 'Carbon'
clang: error: no such file or directory: 'AudioUnit'
clang: error: no such file or directory: 'CoreAudio'
clang: error: no such file or directory: 'CoreMIDI'
clang: error: no such file or directory: 'IOKit'
clang: error: no such file or directory: 'ForceFeedback'
clang: error: no such file or directory: 'CoreVideo'
clang: error: no such file or directory: 'AVFoundation'
clang: error: no such file or directory: 'CoreMedia'
clang: error: no such file or directory: 'Metal'
clang: error: no such file or directory: 'QuartzCore'

Tested on
System Version: macOS 10.15.3 (19D76)

SCons by Steven Knight et al.:
script: v3.1.2.bee7caf9defd6e108fc2998a2520ddb36a967691, 2019-12-17 02:07:09, by bdeegan on octodog
engine: v3.1.2.bee7caf9defd6e108fc2998a2520ddb36a967691, 2019-12-17 02:07:09, by bdeegan on octodog
engine path: ['/usr/local/Cellar/scons/3.1.2_1/libexec/scons-local/SCons']

Xcode 11.3.1
Build version 11C504

Apple clang version 11.0.0 (clang-1100.0.33.17)
Target: x86_64-apple-darwin19.3.0

Closes #36720
2020-03-04 08:36:28 -08:00
Rémi Verschelde 080b5df625
Merge pull request #36682 from nekomatata/android-compilation-fix
Compilation fixes on Android
2020-03-04 16:22:16 +01:00
Rémi Verschelde 3625b057af Vulkan: Use Godot print macros matching MessageSeverity flag
Otherwise any verbose/info/warning debug message from Vulkan would
raise an error, confusing users about the severity of the message.

Cf. #36185, #36790.
2020-03-04 15:02:49 +01:00
Rémi Verschelde df7ecfc4a7 SCons: Expand env variables to check compiler version
Scons' `Environment.subst()` does that, and was already used in the
other place where we query an env variable (`env["LINK"]` in x11 code).

Fixes `3.2` iOS build after cherry-pick of #36559 (previously it only
ran for GCC code, not iOS's Clang), and the same issue would likely
affect `master` if iOS builds were enabled right now.
2020-03-04 14:36:58 +01:00
Rémi Verschelde a0e33e17fb
Merge pull request #36733 from qarmin/static_analyzer_fixes
Fixes bugs found by Sonarcloud and Coverity
2020-03-04 13:41:38 +01:00
Michael Alexsander 8c8c48a7ad Turn Rect2's 'intersects_touch()' into an extra argument of 'intersects()' 2020-03-04 09:32:34 -03:00
PouleyKetchoupp e888dbbb8d Remove '/permissive-' flag from Windows MSVC build
This flag is causing compilation issues with headers from older versions
of Windows SDK (before 10.0.16299.0).
2020-03-04 13:20:53 +01:00
Rémi Verschelde f83f1d7c9b
Merge pull request #36069 from RandomShaper/imvu/improve_drives_ux
Improve UX of drive letters
2020-03-04 13:19:55 +01:00
Rémi Verschelde 2856740e6b
Merge pull request #36385 from kuruk-mm/some_static_asserts
Change when we can ERR_FAIL_COND and ERR_FAIL_CONV_V to static_assert
2020-03-04 13:18:48 +01:00
PouleyKetchoupp ed0655cdfb Compilation fixes on Android 2020-03-04 13:15:37 +01:00
Rémi Verschelde 98f88a4102
Merge pull request #36585 from disks86/master
Enhanced physical device selection
2020-03-04 13:00:52 +01:00
Rémi Verschelde 2eb8e3a40f
Merge pull request #36646 from pyacier/doc-concavepolygonshape
add a precision about the intended use of the ConcavePolygonShape
2020-03-04 12:55:20 +01:00
Rémi Verschelde c7ab0de23a
Merge pull request #36783 from ThakeeNathees/error_macros.h-typo-fix
Typo: in error_macros.h fixed
2020-03-04 12:54:13 +01:00
Rémi Verschelde a74895dfdb
Merge pull request #36596 from BastiaanOlij/add_get_tracker_id
Exposing get_tracker_id for ARVRPositionalTracker to GDScript
2020-03-04 12:34:11 +01:00
Rémi Verschelde c90ec71bcd
Merge pull request #36699 from dreamsComeTrue/fix-extension-file-dialog
Take correct part of extension with File Dialog
2020-03-04 10:36:20 +01:00
Rémi Verschelde 30ff00d6c8
Merge pull request #36657 from van800/rpl3
On Windows find Rider installed for CurrentUser
2020-03-04 10:27:03 +01:00
Bastiaan Olij f0b1edef8b Exposing get_tracker_id for ARVRPositionalTracker to GDScript 2020-03-04 10:22:26 +01:00
Rémi Verschelde 59290f98ef
Merge pull request #36042 from sumit0190/exportInfNan
Read and write exported infs/nans correctly (#35388)
2020-03-04 10:19:52 +01:00
Rémi Verschelde 7ece081662
Merge pull request #36750 from aaronfranke/excl-phys-body
Document that SpringArm exclusions only work with PhysicsBody objects
2020-03-04 10:14:06 +01:00
Rémi Verschelde c0f9b52aef
Merge pull request #36509 from dalexeev/doc_node_fps
Minor fix in Node class documentation
2020-03-04 10:11:09 +01:00
Mateo Dev .59 c933eb7acc Change when we can ERR_FAIL_COND and ERR_FAIL_CONV_V to static_assert 2020-03-04 04:44:47 -03:00
Rémi Verschelde aee36ec01b
Merge pull request #36774 from giarve/fix-double-click-change-folder-editor-file-dialog
Double click on a folder didn't open it (editor)
2020-03-04 08:25:15 +01:00
Rémi Verschelde f09fd9dc6e
Merge pull request #36777 from kuruk-mm/os_getsystemdir
os: execute parse the command output from utf8
2020-03-04 08:16:26 +01:00
Thakee Nathees 08fef074c2 error_macros.h typo fixed 2020-03-04 10:35:31 +05:30