binding_functions.size() and an instance's binding_data.size() can get out of sync. They sync up when an instance's bindings are requested. When binding functions are registered after creating an instance's bindings, the instance's bindings are out of sync until requested again. If they're never requested, they're never synced.
unregister_binding_functions indexes into binding_data, but only checks that its safe to index into binding_functions. When they're out of sync, indexing fails.
This revision checks that it's safe to index into binding_data.
(cherry picked from commit a4a0e64245)
Store general properties in ConfigFile too when modifying them.
Additionally set config_file property as internal as it's not editable
from inspector. It also does not appear to get saved in a meaningful way
(saved as Object(ConfigFile, ...))
(cherry picked from commit aecbb330f3)
- Only load the scripts metadata file when it's really needed. This way we avoid false errors, when there is no C# project, about missing scripts metadata file.
(cherry picked from commit 791e1294c3)
This might be especially usefull since godot script doesn't support ** or ^ as operators, so beginners might search for the exponential function, when what they really need is the pow function.
This is exactly what happened to me and since I couldn't find helpfull information in the documentation I had to look it up online, where I found the answer on a helpfull [reddit thread](https://www.reddit.com/r/godot/comments/3mvwz0/how_do_i_do_exponents_in_godot/).
@akien-mga told me how to reference methods here:
godotengine#30909
(cherry picked from commit a2c81a7455)
Some situations caused the parser node type to not being update when
trying to resolve the type, returning invalid data and breaking the
parsing when it shouldn't. This patch fix the behavior.
(cherry picked from commit 64d09b7de5)
This makes sure that the classes internally represented with an
underscore (_) prefix, such as singletons, are still properly checked
for inheritance in the ClassDB.
(cherry picked from commit 05465b9693)
When relaying messages in multiplayer mode.
Could cause a crash in case a malicious client sends a bogus packet and
for those cases where a peer has just disconnected and a message arrive
from another peer with the disconnected one as destination.
(cherry picked from commit 17be67b8c7)
The WebSocketMultiplayerPeer was relaying the same message two times,
both in _server_relay and _process_multiplayer (which was only supposed
to store the packet, given the server was one of the destination).
_process_multiplayer now only store the packet, and calls _server_relay
which will relay the message to other clients if needed.
(cherry picked from commit d1539db2c6)
It looks like the SCsub for cvtt was copied from squish and it left
the `if env['build_squish']:` line intact. This means that using
`scons builtin_squish=no modules/cvtt` would fail and overal builds
would also fail because they'd fail to find `ConvectionKernels.h`
(cherry picked from commit 0fbd00f656)
Color table should exist for images with bit count <= 8. Importing 16-bit
BMP images could also likely have a color table but they're not currently
supported in Godot.
(cherry picked from commit d5c5aabbf2)
Add some sanity checks according to bmp specification.
Read color table and index data within the same scope and
then simply extend the color palette.
This particular implementation has one limitation: not all 4/1 bit images
can be imported as it requires bit unpacking (size dimensions must be
a multiple of 8 for 1-bit and 2 (even) for 4-bit images).
(cherry picked from commit 6484da5721)
Always resize image to square of power2
Enable mipmaps only if original texture has it enabled
Fix#28534, #28541
(cherry picked from commit 4009d26022)
Adds the missing option of re-enabling the sleep feature in bullet physics once a body had the sleep feature disabled.
(cherry picked from commit 0877cf6419)
Adds `FALLTHROUGH` macro to specify when a fallthrough is intentional.
Can be replaced by `[[fallthrough]]` if/when we switch to C++17.
The warning is now enabled by default for GCC on `extra` warnings level
(part of GCC's `-Wextra`). It's not enabled in Clang's `-Wextra` yet,
but we could enable it manually once we switch to C++11. There's no
equivalent feature in MSVC for now.
Fixes#26135.
(cherry picked from commit fc370b3feb)
I have added a small code sample to show how to automate the process of port forwarding (and closing after you are done).
Thanks to @mhilbrunner for explaining how to achieve t0his (see #18780)
(cherry picked from commit 2a63853720)
RameshRavone
Jason
Frank Secilia
Fabio Alessandrelli
Bojidar Marinov
Ignacio Etcheverry
mashumafi
lupoDharkael
Rémi Verschelde
Kaligule
George Marques
Michael Alexsander Silva Dias
shaderbeast
Cameron Reikes
Marcel Admiraal
Xenoamor
Bastiaan Olij
Harley Laue
sheepandshepherd
ktksgit
Anish
Andrii Doroshenko (Xrayez)
Shinryuuji
Vasiliy Makarov
ShyRed
hbina085
qarmin
Aaron Franke
Remi Rampin
tree786