PR #18675 (commit 96301e9) revealed a problem with how iOS lifecycle
callbacks were handled by Godot. Before that PR it was possible to get
NOTIFICATION_WM_FOCUS_IN callback without getting the corresponding
NOTIFICATION_WM_FOCUS_OUT. That commit added a flag to ensure they are
always coupled, but now there is an issue when, for example, you open a
notification panel on iOS without moving the app to background.
It resulted in view.stopAnimation being called without the
corresponding startAnimation when the app moves to foreground again, so
it looked like the game hanged.
I changed focus out notification to be sent in applicationWillResignActive,
because it makes more sense than to do it in applicationDidEnterBackground,
because it is always called in pair with applicationDidBecomeActive, where
focus in is sent. applicationDidEnterBackground may not come under
circumstances that are now described as a comment in code.
(cherry picked from commit 08a924bcee)
When a phone call or an alarm triggers on iOS, the application receives
an "audio interruption" and it's up to the application to resume
playback when the interruption ends. I added handling for audio
interruptions same as if the game is focused out and then back in.
(cherry picked from commit 96301e934d)
It appears that some time ago users were supposed to be able to include the playback of sound effects in their animations by placing keys on the "playing" property. Back then the key frame editor took the value of the checkbox in the property_editor.
Somewhere / Sometime this behaviour changed and the key frame editor is now reading the actual value from the object instead of relying on the property editor.
This commit introduces a fake active field that is returned when reading the playing property in the editor. While the actual active flag is changed when playback is finished the fake one will stay the same thus allowing the user to take their time with setting the key in the animation editor.
(cherry picked from commit bc1522e268)
An error in unix file IO was causing crashes when getting the size of a file larger than max integer size
As ftell returns a long the fix is trivial
(cherry picked from commit 8a7840a304)
New contributor added to AUTHORS:
@mysticfall
Thanks to all contributors and donors for making Godot possible!
[ci skip]
(cherry picked from commit bd54ff78d9)
Now generating mouse events from touch is optional (on by default) and it's performed by `InputDefault` instead of having each OS abstraction doing it. (*)
The translation algorithm waits for a touch index to be pressed and tracks it translating its events to mouse events until it is raised, while ignoring other pointers.
Furthermore, to avoid an stuck "touch mouse", since not all platforms may report touches raised when the window is unfocused, it checks if touches are still down by the time it's focused again and if so it resets the state of the emulated mouse.
*: In the case of Windows, since it already provides touch-to-mouse translation by itself, "echo" mouse events are filtered out to have it working like the rest.
On X11 a little hack has been needed to avoid a case of a spurious mouse motion event that is generated during touch interaction.
Plus: Improve/fix tracking of current mouse position.
This hasn't made it into master yet but is important for mono support.
If this turns out to be the wrong call we'll revert and merge whatever
next version of this becomes available.
Add debug flag to the 'Export PCK/ZIP' option
Make 'Export PCK/ZIP' notify when the export process begins. This is necessary to receive the 'EditorExportPlugin::_export_begin' callback
(cherry picked from commit 68b35de2b6)
Added a one-liner to update the Create button disabled state when
selecting an item from the search results list.
Fixes#17265, long live the Realm!
(cherry picked from commit 68a4241131)
Previously this would not explicitly say the export failed.
Sure you might see another error somewhere,
but that's not very reliable/obvious.
(cherry picked from commit 4954982b95)
Ignacio Etcheverry
RaphaelHunter
Hein-Pieter van Braam
Geequlim
Pedro J. Estébanez
DmitryKrutskikh
Leon Krause
Guilherme Felipe
Yaakuro
Ruslan Mustakov
bruvzg
ShyRed
Rémi Verschelde
Gustav Lund
Chris Bradfield
Kelly Thomas
Mel Collins
RameshRavone
Your Name
Robin Hübner
Marcelo Fernandez
Max Hilbrunner
Ivan Vodopiviz
Bernhard Liebl
Bastiaan Olij
Peter Folkins
Wilson E. Alvarez
Pieter-Jan Briers
Fabio Alessandrelli