Commit Graph

34231 Commits

Author SHA1 Message Date
lawnjelly 5800615be7 Batching - fix uninitialized color read
Valgrind was showing a read from uninitialized memory. r_fill_state.curr_batch->color is unset (for performance reasons), so can contain random data.

This actually doesn't matter in practice, since logically this uninitialized state can only occur when change_batch is set, and the only side effect is that change_batch is set. Hence why no bugs occur in practice.

This PR prevents this read from uninitialized data. It is likely free in terms of performance after optimization, and keeps the Valgrind logs clearer, so why not.

(cherry picked from commit 23fedc0d1a)
2022-09-09 14:28:58 +02:00
Hugo Locurcio c6461d31d2 Improve documentation related to audio input permissions
(cherry picked from commit ac31fac9a5)
2022-09-05 15:47:43 +02:00
Rémi Verschelde c4179fb179 SCons: Enforce version 4.0+ when `compiledb=yes` is used
Fixes #65233.

(cherry picked from commit 6c5e085d13)
2022-09-05 15:47:29 +02:00
BenniKane 6d9904f1a9 doc: Clarifying NavigationAgent and NavigationAgent2D velocity_computed requires avoidance_enabled to be true to emit
(cherry picked from commit ed5b832a81)
2022-09-05 15:47:14 +02:00
Michael Alexsander a65247a405 Fix some corner cases in the `Menu/OptionButton` item auto-highlight
(cherry picked from commit 1e80b17a8d)
2022-09-05 15:46:06 +02:00
Michael Alexsander 4744a8a1a9 Make `Menu/OptionButton` item auto-highlight behave better
(cherry picked from commit 50506e19a6)
2022-09-05 15:45:54 +02:00
kobewi 5c9ced191b Mention that grab_focus is more reliable deferred
(cherry picked from commit 188d5593e1)
2022-09-05 15:44:04 +02:00
Haoyu Qiu 293c3844b3 Fix action name completion for `Input.get_{axis,vector}`
(cherry picked from commit e6dd71d227)
2022-09-01 11:09:02 +02:00
Rémi Verschelde a027a2efaa Mono: Show custom error explaining that UWP is not supported
Fixes #64490.

(cherry picked from commit ceef056146)
2022-09-01 11:08:18 +02:00
Fredia Huya-Kouadio e1e03297f1 Additional fixes to the Android `get_current_dir()` implementation.
(cherry picked from commit 9910d4681d)
2022-09-01 11:05:27 +02:00
Fredia Huya-Kouadio 8219a72574 Fix build failures for Android on Windows
The issue is caused by https://github.com/godotengine/godot/pull/64306 which makes use of a 3.7 feature while the current recommended python version is 3.5 for 3.x and 3.6 for master.

(cherry picked from commit 667f4ed742)
2022-09-01 10:35:56 +02:00
Pedro J. Estébanez 245bcb693e Add ability to extend the set of Git pre-commit hooks
(cherry picked from commit 8e2d0e1bb1)
2022-09-01 10:35:53 +02:00
Pedro J. Estébanez f3be5471c8 Make Git hooks work on worktrees on Windows
(cherry picked from commit 4bf03afe8b)
2022-09-01 10:35:50 +02:00
Rémi Verschelde a264b68f50
Merge pull request #65045 from akien-mga/3.5-cherrypicks 2022-08-30 14:11:26 +02:00
fabriceci 6029200662 Hack as a hot fix for Bullet's collision margin issue
(cherry picked from commit b3210c5cd6)
2022-08-30 11:48:24 +02:00
Pedro J. Estébanez 5296ab8cd6 Determine ProjectSettings' resource path early
(cherry picked from commit 89892e4f32)
2022-08-30 11:27:42 +02:00
bitsawer 75a3af4d3c Fix Windows list dir handle leak
(cherry picked from commit 40325006b6)
2022-08-30 11:21:31 +02:00
Michael Alexsander 08844b6143 Fix `ItemList` selection visual when the scrollbar visibility changes
(cherry picked from commit e298144a41)
2022-08-30 11:21:19 +02:00
Jordan Schidlowsky 6a6d595286 workaround for angle project issue 7245, safari, iOS
(cherry picked from commit 1ed1a3067b)
2022-08-30 11:20:16 +02:00
Yuri Sizov d92b207189 Backport fixes to documentation for paths, curves and navigation servers
(cherry picked from commit 39f46613bb)
2022-08-30 11:20:03 +02:00
Perrier Mathis b5e4a3c3e0 Fix output port type mismatch for some VisualScript nodes
(cherry picked from commit dcacecaed0)
2022-08-30 11:19:50 +02:00
Nathan Franke ab5f3fcbe0 3.x: ios: force app store icon to be opaque, use proper errors, fix memory leak
(cherry picked from commit da3aecff01)
2022-08-30 11:19:20 +02:00
Andy Maloney e85c5dba23 [doc 3.x] Clarify that AnimationNode virtual methods need to be implemented rather than called directly
Backport of #64344

Fixes #35272

(cherry picked from commit 4ee4c7954a)
2022-08-30 11:19:09 +02:00
Hugo Locurcio 2ac25fbcc7 Document run-time SceneTree debug property changes not working correctly
(cherry picked from commit 3396f45eef)
2022-08-30 11:18:58 +02:00
Cory Petkovsek 92eab47591 Fix free(RID) abuse by various classes
(cherry picked from commit f7f112ab1f)
2022-08-30 11:18:02 +02:00
Aaron Franke e3745de02d [3.x] Fix incorrect Camera3D size documentation
(cherry picked from commit cac69ea132)
2022-08-30 11:17:33 +02:00
Marcel Admiraal 93f4a12278 Fix axis mapped to DPad buttons not releasing opposite button
(cherry picked from commit cdd60416ed)
2022-08-30 11:17:03 +02:00
Pedro J. Estébanez 519bc3a1e8 Make audio thread control flags safe
(cherry picked from commit c92ceca5ce)
2022-08-30 11:16:44 +02:00
Marcel Admiraal a957b4fb8c Fix header guard in error_macros.h
(cherry picked from commit e2dac6ecd9)
2022-08-30 11:16:18 +02:00
Michael Alexsander 682428279a Expose `set/get_tab_button_icon()` to scripting
(cherry picked from commit 73470e1b16)
2022-08-30 11:16:01 +02:00
Haoyu Qiu 9f4bb53a87 Improve documentation for `get_animation()`
(cherry picked from commit fed2879463)
2022-08-30 11:15:24 +02:00
Atlinx d3a86d6829 Add missing parameters for signal in docs
(cherry picked from commit 0e3097c023)
(cherry picked from commit f624acef42)
2022-08-30 11:14:50 +02:00
smix8 1309633cdb Fix NavigationObstacle nodes not registering to default navigation map
Fix NavigationObstacle nodes not registering to default navigation map.

(cherry picked from commit 47b39ce4c2)
2022-08-30 11:14:32 +02:00
kleonc 480e7ffd4a `SceneTreeDock` Toggling unique name in owner for all selected nodes
(cherry picked from commit 6417b999ee)
2022-08-30 11:14:21 +02:00
bruvzg 9dcbf8a8a5 [3.x, macOS / iOS Export] Fix generation of duplicate locale property list files.
(cherry picked from commit 3a24839cb2)
2022-08-30 11:14:05 +02:00
Atlinx 9f6c64135c Remove HDR warning if on low end
(cherry picked from commit e3b3462187)
2022-08-30 11:13:54 +02:00
Michael Alexsander 5becfce603 Fix crash when pressing up on an empty `PopupMenu`
(cherry picked from commit f0d380c9fd)
2022-08-30 11:12:23 +02:00
Max Hilbrunner 555840914b Update UPnP documentation
Adds more details, especially about caveats, failure modes and pitfalls

(cherry picked from commit be41c09769)
2022-08-30 11:08:27 +02:00
Rémi Verschelde b5e368c92b Linux: Fix GNU ld detection for pck_embed linker script
(cherry picked from commit fce3602a1e)
2022-08-30 11:07:51 +02:00
Haoyu Qiu 5d30d77fd7 Fix missing URL text in the classref
(cherry picked from commit a90c348a86)
2022-08-30 11:07:29 +02:00
Micky 179a16a67c Improve documentation of CanvasItem's draw logic
(cherry picked from commit 953c78eaff)
2022-08-29 17:14:38 +02:00
kobewi 503fddc0fe Mention the stretching behavior of PopupPanel
(cherry picked from commit a2b088b1c1)
2022-08-29 17:14:20 +02:00
Pedro J. Estébanez cbe542f96a Fix jumbled error output when using Windows spawn fix
(cherry picked from commit 4a3cb14473)
2022-08-29 17:14:03 +02:00
Pedro J. Estébanez fc01ed9dbb Clean iOS platform config of long gone macro
(cherry picked from commit 8c2a577350)
2022-08-29 17:13:45 +02:00
Michael Alexsander 62c6fe77b6 Fix error when switching to another `GridMap` with an item with higher index selected
(cherry picked from commit fe16aecbac)
2022-08-29 17:13:24 +02:00
Dan Boorstein 9a037a0727 Add note about using AudioListener2D
There was no mention of the effect of AudioListener2D in this documentation, making it unclear if there was a relationship. The new text is copied and modified from the AudioStreamPlayer3D documentation.

Use 'an' as article before 'AudioListener3D'

(cherry picked from commit a7ebc6fb18)
2022-08-29 17:13:03 +02:00
Marlin Watts-Woods 98074e1861 Added to Sprite3D Documentation
(cherry picked from commit f8f665b03e)
2022-08-29 17:12:25 +02:00
Hugo Locurcio f93f583c42 Improve InstancePlaceholder documentation
(cherry picked from commit 5acf30b538)
2022-08-29 17:12:01 +02:00
Rémi Verschelde 07af8a971a nanosvg: Sync with upstream bd16c4e
(cherry picked from commit 052257e9b7)
2022-08-29 17:11:47 +02:00
Fredia Huya-Kouadio f96f8ddfc7 Fix issue with `get_current_dir()` returning the wrong path on Android
(cherry picked from commit b5e1096c61)
2022-08-29 17:11:32 +02:00