godotengine/godot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
59,716 Commits 15 Branches 59 Tags 2.2 GiB
9f615edb84
Commit Graph

1273 Commits

Author SHA1 Message Date
Rémi Verschelde
def12f7cc4
Remove forward compat parsing of PackedVector4Array in binary format 
The logic I implemented was lacking, and actually it's not useful as binary files saved by Godot 4.3
are not recognized due to the `ver_major > VERSION_MAJOR` check.

So even if the format version was unchanged, such files would still not be readable in 4.2.
 2024-05-07 14:22:51 +02:00
Rémi Verschelde
7aacb098f0
Add forward compat parsing of PackedVector4Array 
This new Variant type is being added in 4.3, and breaks compatibility with
earlier releases. By adding minimal parsing support (converting to plain Array)
we can at least open the scenes, and minimize the data loss when going back and
forth between minor versions.
 2024-05-03 00:20:12 +02:00
Yorick de Wid
e5ea748dcf
FIX: Return if TCP is in STATUS_CONNECTED 
If the `StreamPeerTCP` is polled and the TCP connection is `STATUS_CONNECTED` it should return after polling netsocket. Without `return` poll keeps calling `_sock->connect_to_host` and `connect()`.

(cherry picked from commit 61a2f5c534)
 2024-04-16 13:47:32 +02:00
Rémi Verschelde
63f45cd75d
Revert "Push p_original_path into load_paths_stack and sub_tasks instead of p_path." 
This reverts commit 5cc432e7a1.
 2024-04-09 13:07:15 +02:00
A Thousand Ships
2114489e23
[Core] Fix ResourceLoader.load cache with relative paths 
Paths were not simplified meaning that `res://foo.bar` was treated
differently from `./foo.bar` and similar

(cherry picked from commit 0274877def)
 2024-04-08 15:48:30 +02:00
Pylgos
6f339b07f0
Fix Resource::get_rid override not working in GDExtension 
(cherry picked from commit c2be2dfbde)
 2024-04-08 15:48:30 +02:00
Matthew Edwards
5cc432e7a1
Push p_original_path into load_paths_stack and sub_tasks instead of p_path. 
(cherry picked from commit 7565d1f3ab)
 2024-03-11 18:03:24 +01:00
ACB
f4106e5fb3
Fix FileAccessMemory off by one error in eof_reached 
(cherry picked from commit 2561f6fc52)
 2024-03-11 18:02:59 +01:00
nfrmtk
c00caa766e
add check for negative buffer_size inside start_(de)compression method. 
(cherry picked from commit da886006a0)
 2024-03-11 18:02:44 +01:00
scgm0
2042283d32
Explicitly initialize all of FileAccess::create_func[ACCESS_MAX] 
(cherry picked from commit 2dae53c316)
 2024-03-11 18:02:27 +01:00
Pedro J. Estébanez
a5aa6910bc
Avoid regressing in progress reporting in resource load 
(cherry picked from commit f5ca58d32f)
 2024-03-11 17:59:25 +01:00
jsjtxietian
a47a07d13b Fix FileAccessPack::get_buffer will update pos past the length of file 
(cherry picked from commit 68a6fe81ab)
 2024-01-25 18:32:36 +01:00
kobewi
c285b726bb Fix file disappearing when renaming dependencies 
(cherry picked from commit 397f0b31e4)
 2024-01-25 17:19:41 +01:00
rsburke4
0224a60b43 Added error to catch conversion on invalid image 
(cherry picked from commit dec2269bca)
 2024-01-24 15:56:50 +01:00
Yuri Sizov
4564a8513a
Correctly check scripts that must inherit EditorPlugin 
Also updates some error messages related to this kind of check
across the codebase.

(cherry picked from commit bc1949d797)
 2023-12-07 10:27:06 +01:00
Rémi Verschelde
2bcc2a3cd0
Merge pull request #84791 from akien-mga/fix-translation-remapping-check 
Fix translation remapping check for imported resources
 2023-11-12 23:00:08 +01:00
Rémi Verschelde
2729a78fd7
Fix translation remapping check for imported resources 
Fixes #81660.
 2023-11-12 13:17:12 +01:00
kobewi
a3627b6e37 Assign temporary path to preloaded resources 2023-11-10 00:43:30 +01:00
Aaron Franke
58076b9ccb
Implement glTF compat version system for files from older Godot versions 2023-11-03 12:07:25 -05:00
Thomas ten Cate
2263d94cc3 Add comment why off-by-one error is hard to fix 
See #83843

Co-authored-by: Rémi Verschelde <rverschelde@gmail.com>
 2023-11-01 11:14:13 +01:00
Rémi Verschelde
a3e4c4f41c
Merge pull request #84155 from AThousandShips/encode_fix 
Prevent `encode_variant` doing `memcpy` from `nullptr`
 2023-10-30 23:19:22 +01:00
K. S. Ernest (iFire) Lee
9877fa5058 Fix uninitialized variable in Image::fix_alpha_edges() 
`core\io\image.cpp:3776:33: error: 'closest_color[0]' may be used uninitialized [-Werror=maybe-uninitialized]`
 2023-10-29 22:59:03 -07:00
A Thousand Ships
210461f2ed Prevent encode_variant doing memcpy from nullptr 2023-10-29 18:06:21 +01:00
Haoyu Qiu
dc7e309f48 Fix heap-use-after-free when resource loaded with load_threaded_request is never fetched 
Co-authored-by: Pedro J. Estébanez <pedrojrulez@gmail.com>
 2023-10-23 16:21:17 +08:00
Rémi Verschelde
51f81e1c88
Merge pull request #82957 from bruvzg/fs_case_check 
Add method to check if filesystem is case sensitive.
 2023-10-13 12:55:35 +02:00
Thaddeus Crews
d8fdd419fa
Apply missing flag to vector4/projection 2023-10-12 11:18:45 -05:00
Paul Joannon
bf3f6e3b55
Error handling for FileAccess.get_file_as_* 
- Assign last error in said `FileAccess.get_file_as_bytes` and `FileAccess.get_file_as_string`
- Document error handling for said methods
 2023-10-11 18:52:16 +02:00
bruvzg
97bcd8a631 Add method to check if filesystem is case sensitive. 2023-10-09 11:00:15 +03:00
A Thousand Ships
f18aa00e85 Replace ERR_FAIL_COND with ERR_FAIL_NULL where applicable 2023-10-08 17:23:33 +02:00
Rémi Verschelde
d616c3ecd0
Merge pull request #82408 from hpvb/fix-import-crash 
Fix Image import crash
 2023-09-27 14:03:47 +02:00
Rémi Verschelde
19057c07bc
Merge pull request #67080 from Mickeon/resource-virtual-local-to-scene-setup 
Reimplement Resource.`_setup_local_to_scene` & deprecate signal
 2023-09-27 14:03:28 +02:00
Hein-Pieter van Braam
b5705958e6 Fix import crash 
I was trying to import a solid colored metal/roughness texture that
worked in Godot 4.1.1 but failed to load on master. I eventually tracked
it down to this: to_x and to_y can be 0, which then leads them to be -1
later, which then causes ofs to overflow.

Some of these cases were hidden because of the use of Vector so we were
just happily scribbling in ram elsewhere.

Switched to LocalVector as it made debugging a bit easier.
 2023-09-26 23:50:50 +02:00
Saracen
0b0a6109b6 Make notify_dependency_error only defer calls if called from secondary threads. 2023-09-26 03:36:11 +01:00
bitsawer
16c3a19d91 Expose and document Image.get_mipmap_count() 2023-09-19 14:34:59 +03:00
A Thousand Ships
893f889d74 [Core] Replace ERR_FAIL_COND with ERR_FAIL_NULL where applicable 2023-09-11 19:45:49 +02:00
Micky
79ce0c6e80 Reimplement Resource._local_to_scene_setup & remove workaround 
Reimplements the virtual method _setup_local_to_scene, lost in #51970

Also deprecates the redundant `setup_local_to_scene_requested` signal.
 2023-09-09 13:51:12 +02:00
Yuri Sizov
d8ff69d53c Extract ScriptInstance to simplify includes 
This allows to include script_instance.h directly in the
generated gdvirtual.gen.inc, and remove excessive includes
from the codebase.

This should also allow Resource to use GDVIRTUAL macros,
which wasn't possible previously due to a circular dependency.
 2023-09-06 22:54:38 +02:00
David Nikdel
067807c1cb Remove nondeterminism in pck_packer 
PCK files (like other build products) should be deterministic based on their inputs. Removed calls to Math::rand() that are being used to generate padding.

Looks like these were introduced as part of adding encryption support, but the padding being random does not have any cryptographic significance. This can be trivially inferred since file blocks that happen to be aligned don't get padding anyway.

If there's a desire to indroduce something that functions as a nonce it should probably be added explicitly and only if encryption is enabled.
remove Math::rand() calls in editor_export_platform.cpp

follow up to make consistent with pck_packer
 2023-09-03 18:14:30 -04:00
clayjohn
0045dc204c Revert "Implement loading DDS textures at run-time" 
This reverts commit 34ab1c8a36.
 2023-08-29 14:25:16 +02:00
acazuc
a00cf02241 Add support for KTX & KTX2 image format 
Add support glTF KHR_texture_basisu extension
 2023-08-19 10:27:29 +02:00
Rémi Verschelde
e73a4a382e
Merge pull request #79201 from Rindbee/fix-setup-state-not-cleared 
Clear the previously set state when configuring for a new scene root node
 2023-08-17 15:43:38 +02:00
Rémi Verschelde
efdff9cbc2
Fix GCC -Wmaybe-uninitialized warnings 2023-08-14 14:35:35 +02:00
bruvzg
8aa6f29b56
[FileAccess] Add methods to get/set "hidden" and "read-only" attributes on macOS/BSD and Windows. 2023-08-08 21:51:32 +03:00
Rindbee
4795c3cdfa Clear the previously set state when configuring for a new scene root node 
Saving a subscene causes the main scene to be re-instantiated. And the resource
instance in the main scene will be reused when the main scene is re-instantiated.
So for resources with `resource_local_to_scene` enabled, resetting state may be
necessary (at least for `ViewportTexture`).
 2023-08-08 23:49:53 +08:00
Rémi Verschelde
faaf27f284
Fix various typos with codespell 
Also includes typo fixes from #79993, #80068, #80276, and #80303.

Co-authored-by: betalars <contact@betalars.de>
Co-authored-by: spaceyjase <429978+spaceyjase@users.noreply.github.com>
Co-authored-by: Swarkin <102416174+Swarkin@users.noreply.github.com>
Co-authored-by: Raul Santos <raulsntos@gmail.com>
 2023-08-07 13:09:47 +02:00
Marcin Nowak
34ab1c8a36 Implement loading DDS textures at run-time 2023-07-31 21:31:26 +02:00
Yuri Sizov
0be587521e Merge pull request #79737 from Calinou/resourceloader-load-error-clarify-expected-type 
Mention expected resource type in ResourceLoader load error
 2023-07-31 21:01:28 +02:00
Ithamar R. Adema
f37c2b5be2 Fix ImageTextureLayered serialisation issues. 2023-07-23 13:54:04 +02:00
Hugo Locurcio
5bf64255b0
Mention expected resource type in ResourceLoader load error 
This helps troubleshoot issues due to incorrect import types.
 2023-07-21 04:45:34 +02:00
kobewi
de4a3fa151 Unify and streamline connecting to Resource changes 2023-07-17 19:35:57 +02:00