Mitch Curtis
ae4a382dd2
Improve error message in Node::remove_child()
2019-08-08 09:38:32 +02:00
qarmin
6cbaf7662f
Changed some code showed in LGTM and Coverage
2019-07-20 08:09:57 +02:00
Rémi Verschelde
111154a4a5
Merge pull request #30498 from bojidar-bg/30495-cannot-insert-key
...
Fix inability to insert keys via Insert Key context menu
2019-07-11 19:36:33 +02:00
Bojidar Marinov
8ecbb6a20d
Fix inability to insert keys via Insert Key context menu
...
Fixes #30495
2019-07-10 21:03:04 +03:00
qarmin
01cc7a996b
Use reference to constant in functions
2019-07-10 11:54:12 +02:00
Rémi Verschelde
6b30f284a0
Merge pull request #29980 from Dentrax/directed-by-qarmin
...
Fix some editor crashes
2019-07-01 14:59:29 +02:00
Furkan Türkal
7d8d337b2c
fix some crashes
2019-07-01 14:28:29 +03:00
Rémi Verschelde
eaaff9da31
Merge pull request #29941 from qarmin/redundant_code_and_others
...
Remove redundant code, possible NULL pointers and others
2019-06-27 01:05:18 +02:00
Rémi Verschelde
6e9272eea8
Node: Fix logic of has/get_node_and_resource and document it
...
Also document NodePath.
2019-06-26 15:46:32 +02:00
qarmin
4e5310cc60
Some code changed with Clang-Tidy
2019-06-26 15:08:25 +02:00
Rémi Verschelde
6d16f2f053
Fix error macro calls not ending with semicolon
...
It's not necessary, but the vast majority of calls of error macros
do have an ending semicolon, so it's best to be consistent.
Most WARN_DEPRECATED calls did *not* have a semicolon, but there's
no reason for them to be treated differently.
2019-06-11 14:49:34 +02:00
Rémi Verschelde
0823ae7ae4
Node::duplicate: Don't set name if original node is nameless
...
In practice this only happens when duplicating a node which is not in
the scene tree yet, as nameless nodes get assigned a generated name
when added to the scene tree.
Fixes #27319 .
2019-05-28 12:40:44 +02:00
PouleyKetchoupp
3f174c86d0
Fixed scene tree update after changing node name in tool script
2019-05-24 15:27:22 +02:00
Rémi Verschelde
9dc9434b1b
Merge pull request #24437 from mateusfccp/single_quotes_option
...
Add settings for single-quotes on completion
2019-04-30 14:58:33 +02:00
Rémi Verschelde
201cdd358a
Merge pull request #28140 from Daw11/orphan-nodes
...
Add a monitor for the orphan nodes
2019-04-22 11:55:15 +02:00
Hein-Pieter van Braam-Stewart
20b0046945
Object::script may not be a valid Ref<Script>
...
It appears that Object::script may be a valid ScriptInstance but not be
castable to Ref<Script>. There were only 5 places in the code that made
this assumption. This commit fixes that.
2019-04-20 02:13:28 +02:00
Daw11
04d0371648
Add a monitor for the orphan nodes
...
- Allow the user to keep track of the nodes that might leak
- Possible fix for #27103
2019-04-17 23:13:16 +02:00
Juan Linietsky
c1dcdf6109
No more metadata and dependency indices kept in resources saved.
...
-Node folding is now saved externally together with the properties
-External resources remember their ID when scenes are saved.
2019-04-11 14:36:58 -03:00
Rémi Verschelde
50ef456c78
Merge pull request #26803 from ptrojahn/emptynode
...
Make get_node return NULL for empty NodePaths
2019-04-05 16:55:42 +02:00
Juan Linietsky
a18989602b
Clean up notifications and merge Node and MainLoop ones for clarity, closes #27614
2019-04-04 10:34:41 -03:00
Paul Trojahn
97e8c88ce7
Make get_node return NULL for empty NodePaths
...
Fixes #25292
2019-03-08 21:31:36 +01:00
K. S. Ernest (iFire) Lee
b83c3827f3
Add check in folding to see if the nodepath exists to avoid message spam.
2019-01-30 20:19:44 -08:00
Rémi Verschelde
1ff170e67f
Redo serial name fixup from 799ed2b989
...
reduz wanted the original PR reverted due to issues, so this follow-up had to be too
(done in 8cb54182ad
). But he ended up adapting part of
the original PR in 27d7772381
without including this fix.
2019-01-11 23:02:57 +01:00
Juan Linietsky
27d7772381
Rewrote rename logic to be less buggy and more efficient, fixes #23803 and probably many recent bugs using GraphEdit
2019-01-10 18:58:16 -03:00
Rémi Verschelde
8cb54182ad
Revert "Node: make _generate_serial_child_name manipulate numbers as String"
...
This reverts commits 1025e3ecea
and 799ed2b989
.
2019-01-10 22:40:42 +01:00
volzhs
799ed2b989
Fix strip out spaces while generating serial number for node name
2019-01-08 22:37:45 +09:00
Rémi Verschelde
b16c309f82
Update copyright statements to 2019
...
Happy new year to the wonderful Godot community!
2019-01-01 12:58:10 +01:00
Mateus Felipe C. C. Pinto
ca1935d6f7
Add settings for single-quotes on completion
2018-12-18 12:48:36 -02:00
lupoDharkael
1025e3ecea
Node: make _generate_serial_child_name manipulate numbers as String
...
The conversion from an String to int can overflow int and int64
so it is safer to manipulate strings when we try to find the next
available name for a Node.
2018-11-21 14:18:34 +01:00
Juan Linietsky
2d6b994e47
Massive speed up on deleting nodes, fixes #18673
...
Also makes the editor exit faster
2018-11-18 11:48:21 -03:00
Juan Linietsky
c5656b7468
Merge pull request #23564 from endragor/fix-remove-child-ordering
...
Notify node's moved children after sibling removed
2018-11-14 20:30:41 +01:00
Juan Linietsky
f2e54057ae
-Moved EditorDefaultValue to ClassDB, made it core
...
-Removed one and zero hints for properties, replaced by default value
2018-11-08 11:30:59 -03:00
Ruslan Mustakov
3b02cd3e71
Notify node's moved children after sibling removed
...
Fixes #16213 .
2018-11-07 16:31:25 +07:00
Juan Linietsky
e647342140
Moved folding outside the resource files, now saved outside the project.
2018-10-29 16:37:09 -03:00
DualMatrix
6afedaa498
Fixed error when duplicating a scene which has connection
...
Fixed error when duplicating a scene which has connection
2018-10-11 01:30:12 +02:00
Rémi Verschelde
344a453bb8
Merge pull request #22681 from akien-mga/fix-warnings
...
Fix warnings on release builds and some MSVC warnings
2018-10-03 19:05:55 +02:00
Rémi Verschelde
95131e6f23
Fix warnings on release builds (not DEBUG_ENABLED)
...
Fixes the following Clang 5 warnings:
```
modules/bmp/image_loader_bmp.cpp:46:60: warning: comparison of unsigned expression < 0 is always false [-Wtautological-compare]
modules/bmp/image_loader_bmp.cpp:48:61: warning: comparison of unsigned expression < 0 is always false [-Wtautological-compare]
drivers/png/image_loader_png.cpp:231:20: warning: comparison of unsigned expression >= 0 is always true [-Wtautological-compare]
scene/gui/graph_edit.cpp:1045:8: warning: comparison of constant 0 with expression of type 'bool' is always false [-Wtautological-constant-out-of-range-compare]
core/class_db.cpp:812:13: warning: unused variable 'check' [-Wunused-variable]
core/io/file_access_pack.cpp:172:11: warning: unused variable 'ver_rev' [-Wunused-variable]
core/math/bsp_tree.cpp:195:13: warning: unused variable 'plane' [-Wunused-variable]
core/math/bsp_tree.cpp:168:6: warning: unused variable 'plane_count' [-Wunused-variable]
modules/gdscript/gdscript_function.cpp:685:10: warning: unused variable 'ok' [-Wunused-variable]
modules/gdscript/gdscript_function.cpp:706:10: warning: unused variable 'ok' [-Wunused-variable]
modules/gdscript/gdscript_function.cpp:755:19: warning: unused variable 'var_type' [-Wunused-variable]
modules/gdscript/gdscript_function.cpp:1306:12: warning: unused variable 'err' [-Wunused-variable]
modules/gdscript/gdscript_function.cpp:158:15: warning: unused function '_get_var_type' [-Wunused-function]
modules/gdscript/gdscript_parser.cpp:750:20: warning: unused variable 'lv' [-Wunused-variable]
modules/gdscript/gdscript_parser.cpp:59:15: warning: unused function '_find_function_name' [-Wunused-function]
scene/main/node.cpp:2489:13: warning: unused function '_Node_debug_sn' [-Wunused-function]
```
2018-10-03 17:34:55 +02:00
DualMatrix
cb9559350f
Fixed error when duplicating node from editor.
...
Fixed error when duplicating node from editor.
2018-10-03 14:59:16 +02:00
Max Hilbrunner
d878c828b5
Merge pull request #22115 from akerudesu/find-parent
...
Added find_parent method to node class
2018-09-22 17:15:38 +02:00
Unknown
0fdbf6b2ef
Added find_parent method to node class
2018-09-15 18:22:29 +02:00
DualMatrix
b0d9f7686c
Made duplicate_and_reown preserve groups
2018-09-14 18:13:41 +02:00
Rémi Verschelde
277b24dfb7
Make core/ includes absolute, remove subfolders from include path
...
This allows more consistency in the manner we include core headers,
where previously there would be a mix of absolute, relative and
include path-dependent includes.
2018-09-12 09:52:22 +02:00
Juan Linietsky
4b6846a59d
Ensure that tree_exited signal really happens after tree exited, fixes #19641
2018-09-07 15:31:53 -03:00
Rémi Verschelde
52466d57e9
Make some debug prints verbose-only, remove others
2018-08-24 14:59:01 +02:00
Rémi Verschelde
404ee1a56b
Style: Fix issues that went past CI
2018-08-21 21:28:06 +02:00
volzhs
4e9795aa99
Fix not to show configuration warning on every node has script
2018-08-15 21:35:06 +09:00
Juan Linietsky
ef5095720b
-Deprecate ImageTexture::load
...
-Add warning to Image::load when loading resources
-Add script binding for get_configuration_warning
2018-08-14 16:53:20 -03:00
Andrea Catania
c1860fe88b
Fixed process priority
2018-08-04 14:51:44 +02:00
Juan Linietsky
15db793ef2
Ensure process notification is received only if really enabled, fixes #7894
2018-07-29 21:20:41 -03:00
Juan Linietsky
172f652dc0
Merge pull request #19888 from AndreaCatania/pry
...
Implemented proceses priority
2018-07-23 07:21:38 -03:00