godotengine/godot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
55,746 Commits 15 Branches 59 Tags 2.2 GiB
b408b05d7d
Commit Graph

1837 Commits

Author SHA1 Message Date
Markus Sauermann
b408b05d7d Fix physics passive hovering for some cases 
When the parent `SubViewportContainer` ignores mouse with
`MOUSE_FILTER_IGNORE` and also when the mouse is over a `Control`-node,
then the `SubViewport` shouldn't create mouse-move-events for passive
hovering.
 2023-07-19 19:25:04 +02:00
Yuri Sizov
7ff2a93952 Merge pull request #72248 from RedwanFox/mainloop_init_order_fix 
Ensure that SceneTree is initialized and finalized at correct time
 2023-07-12 17:16:05 +02:00
Yuri Sizov
223370cb64 Merge pull request #78383 from Sauermann/fix-physics-object-init 
Fix Physics Picking captured Object initialization
 2023-07-12 17:15:45 +02:00
Yuri Sizov
5dff3c4484 Merge pull request #78538 from Sauermann/fix-code-simplifications 
Remove unnecessary value assignments throughout the codebase
 2023-07-12 15:09:26 +02:00
Yuri Sizov
631d51c46c Merge pull request #78476 from Sauermann/fix-embedded-safe-area 
Embedded Popups store their safe_rect in their embedder
 2023-07-12 15:09:20 +02:00
Rémi Verschelde
6cb1162aa0
Merge pull request #79000 from AThousandShips/owner_error 
Improve error message for `Node.set_owner`
 2023-07-11 11:29:30 +02:00
Rémi Verschelde
988abb2161
Merge pull request #79016 from bruvzg/fix_win_initial_ne_fs 
[Windows] Fix setting initial non-exclusive window mode.
 2023-07-08 18:21:04 +02:00
Rémi Verschelde
0df423756e
Merge pull request #78847 from Sauermann/fix-sibling-fail 
Fix `Node::add_sibling` parent check
 2023-07-08 18:20:14 +02:00
Rémi Verschelde
7961bc6193
Merge pull request #78078 from Sauermann/fix-drop-physics-mouse-over 
Ensure that `_drop_physics_mouseover` only happens when necessary
 2023-07-07 16:02:13 +02:00
bruvzg
db0109b237 [Windows] Fix setting initial non-exclusive window mode. 2023-07-04 13:09:26 +03:00
Ninni Pipping
0183340012 Improve error message for Node.set_owner 2023-07-04 08:51:12 +02:00
Markus Sauermann
b02dff6e1c Fix Node::add_sibling parent check 
Replace `data.blocked > 0` by `data.parent->data.blocked > 0` in order
to check if the parent is busy.
 2023-06-29 20:21:37 +02:00
Rémi Verschelde
16508ead86
Merge pull request #78745 from RandomShaper/fix_node_pr 
Fix node processing order
 2023-06-27 23:02:02 +02:00
Pedro J. Estébanez
70ca659143 Fix node internal/non-internal processing order 
Bonus:
Fix issues in group-processing related setters
 2023-06-27 19:19:55 +02:00
Rindbee
fb1bcac271 Fix that ViewportTexture cannot be setup again after failed setup 
`vp_pending` is a flag indicating to wait for `ViewportTexture::_setup_local_to_scene`
to be called. Once this method is called, no matter whether the setup will fail or not,
it needs to be reset to `false`.
 2023-06-27 06:45:30 +08:00
Pedro J. Estébanez
fc0e37bbe0 Fix change of precedence in fixup 2023-06-26 19:20:34 +02:00
Rémi Verschelde
6b91f57042
Fixup compilation warning after #78713 2023-06-26 17:55:08 +02:00
Pedro J. Estébanez
a39b683b12 Ensure default node groups' call queue are processed 2023-06-26 16:56:10 +02:00
Markus Sauermann
31fab43b8b Fix scene load crash related to _ready 
The iterator might get invalidated during `_ready`-user-code.
Prevent this by disallowing set_name during iterator-operations.
 2023-06-25 22:35:38 +02:00
Rémi Verschelde
afe65de110
Merge pull request #78591 from ajreckof/Fix-crash-when-removing-child-during-focus-exit- 
Fix crash when removing child during focus exit.
 2023-06-23 22:45:51 +02:00
ajreckof
f745299c36 Fix crash when removing child during focus exit. 2023-06-23 21:31:18 +02:00
Rémi Verschelde
68193bee9a
Revert "Fix that the focus-out notification got sent deferred" 
This reverts commit 8cdab04d7f.

Fixes #78589.
 2023-06-23 18:03:48 +02:00
Markus Sauermann
60c261ba2d Re-add mouse_focus-nullcheck 2023-06-22 21:58:19 +02:00
Rémi Verschelde
283580d0cc
Merge pull request #78566 from kleonc/repeated-sprite-selection-fix 
Fix click-selecting Sprites with repeated texture
 2023-06-22 18:32:01 +02:00
kleonc
edba45ec8b Fix click-selecting Sprites with repeated texture 2023-06-22 16:37:08 +02:00
jeana helver
5ec1b698d2
Fix missing enum value for Window.initial_position 
Reorder the properties in a possibly more intuitive order.

Co-authored-by: Rémi Verschelde <rverschelde@gmail.com>
 2023-06-21 22:39:43 +02:00
Markus Sauermann
890fdd56df Code simplifications 
CPPcheck found most of them.

no need to assign the variable twice:
- AnimationTrackEditTypeAudio
- SSEffects

variable is assigned in all if-else clauses:
- EditorHelp
- AndroidInputHandler
- MenuBar
- ShaderCompiler

same if clause:
- ItemList

clearing an empty bitfield has no effect:
- Viewport
 2023-06-21 22:37:26 +02:00
Nickolai Korshunov
83f065c0ef Ensure that SceneTree is initialized and finalized at correct time 
SceneTree should be fully initialized before any tree operation with any node and finalized only after all nodes exited tree.
 2023-06-20 23:47:02 +03:00
Markus Sauermann
a12627765f Embedded Popups store their safe_rect in their embedder 
Storing it in the DisplayServer didn't make sense in this case,
because the embedded window is unknown to the DisplayServer.
 2023-06-20 18:06:26 +02:00
Rémi Verschelde
159f1ec301
Merge pull request #78398 from Sauermann/fix-immediate-focus-out 
Fix that the focus-out notification got sent deferred
 2023-06-20 13:14:10 +02:00
Rémi Verschelde
cce100a840
Merge pull request #75459 from kleonc/node-fix-find-children 
Fix recursive `Node.find_children`
 2023-06-19 22:33:46 +02:00
Markus Sauermann
8cdab04d7f Fix that the focus-out notification got sent deferred 
Currently the window receives a focus-out notification, directly after
it popup, because currently the signal is sent deferred.
The original intention was that the previously focused window must
receive a focus-out notification.
This change makes the notification more precise by only sending the
focus-out to the previously focused window.
 2023-06-18 23:06:07 +02:00
Raul Santos
5373b67e2a
Respect returned bool from virtual process methods in SceneTree 
SceneTree overrides the virtual `process` and `physics_process` methods
that it inherits from MainLoop. These methods return a boolean that
determines if the main loop should end.
The SceneTree was ignoring the returned boolean, so scripts inheriting
from SceneTree that override these methods and return true didn't exit
the main loop. Now the boolean is checked.
 2023-06-18 20:45:58 +02:00
Markus Sauermann
5b2a5cd2e0 Fix Physics Picking captured Object initialization 
Initialize variables when a captured object is known.
 2023-06-18 00:45:49 +02:00
smix8
f1d8ddd9bd Remove SceneTree debug avoidance hint 
Removes SceneTree debug avoidance hint.
 2023-06-16 17:18:47 +02:00
Rémi Verschelde
2ebe692ccc
Merge pull request #78276 from smix8/remove_old_navdebug_materials_4.x 
Remove legacy navigation debug materials
 2023-06-16 10:20:20 +02:00
Rémi Verschelde
014b395ef3
Merge pull request #78262 from bruvzg/ds_window_focus 
[DisplayServer] Add method to check if native window is focused.
 2023-06-16 10:19:33 +02:00
bruvzg
28db3c7158 [DisplayServer] Add method to check if native window is focused. 2023-06-16 10:27:52 +03:00
smix8
1b506cd49c Remove legacy navigation debug materials 
Removes legacy navigation debug materials.
 2023-06-15 16:33:55 +02:00
Danil Alexeev
eb391d3302
Display BitField[Enum] in docs to distinguish from Enum 2023-06-15 17:23:02 +03:00
Rémi Verschelde
c3e5e4ed4b
Merge pull request #68599 from Rindbee/update-edited_scene_root-in-time 
Update the edit scene root in time after it is replaced
 2023-06-12 17:08:50 +02:00
Rindbee
eb74079dfb Update the edit scene root in time after it is replaced 
When changing the type of the edited scene root node, it may be necessary
to update edited scene root in time for the child nodes to work properly.
 2023-06-12 21:49:30 +08:00
Rémi Verschelde
9fca498647
Merge pull request #78110 from Sauermann/fix-nofocus-focus 
Fix Tooltip getting removed instantly in embedded Window
 2023-06-12 11:55:58 +02:00
Markus Sauermann
9d40f99290 Fix Tooltip getting removed instantly in embedded Window 
Tooltips are unfocusable Windows. This case was not handled correctly in
`Viewport::_sub_window_register`.
 2023-06-11 12:22:59 +02:00
Ninni Pipping
0c16082e1e Use get_node_or_null when null checks are present 
Avoids duplicate or unnecessary errors
 2023-06-10 13:22:56 +02:00
Markus Sauermann
37a96d3957 Fix that _drop_physics_mouseover only happens when necessary 
Previously the call was executed every time, because in the
`_drop_mouse_over();` a few lines above, `gui.mouse_over = nullptr;`
was set.
 2023-06-10 09:33:16 +02:00
Ninni Pipping
dcd2b883eb Use NULL instead of COND checks when appropriate 
Restricted to scene
 2023-06-10 08:56:30 +02:00
Rémi Verschelde
8acf6b41a4
Merge pull request #77209 from Rindbee/ViewportTexture-not-change-RID 
Don't change `RID` when changing `viewport_path` in `ViewportTexture`
 2023-06-09 15:10:39 +02:00
Rindbee
7532b2d259 Don't change RID when changing viewport_path in ViewportTexture 
When changing `viewport_path`, the `proxy`'s target is changed to a new placeholder.

Add a flag `vp_changed` to prevent calling `setup_local_to_scene` (mainly called by toggling `resource_local_to_scene`) when the target viewport has not changed.
 2023-06-09 19:50:26 +08:00
Rémi Verschelde
300748e52c
Merge pull request #78044 from RandomShaper/fix_node_prio_ignored 
Fix node idle process priority being ignored
 2023-06-09 13:45:15 +02:00