godotengine/godot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
27,675 Commits 15 Branches 59 Tags 2.2 GiB
e24b9f0520
Commit Graph

2532 Commits

Author SHA1 Message Date
Pedro J. Estébanez
07c4dc1b30 Avoid invocation to Object's copy constructor 
Needed for the next commit. That's the only place in all the Godot code base
where that's attempted and it's not needed because Objects are not meant to
be copied that way.
 2020-04-23 12:44:47 +02:00
asheraryam
93f7e8d8fc Add "node_unselected" signal for GraphEdit 2020-04-16 16:56:58 +03:00
Michael Alexsander
b4429c325a Fix incorrect TabContainer documentation for 'get_tab_control()' 
(cherry picked from commit 8f925b1970)
 2020-04-16 12:57:22 +02:00
Dominik 'dreamsComeTrue' Jasiński
5fdecebee1 Calculate strike-through position correctly 
Fixes: #37637
(cherry picked from commit 06a79f260c)
 2020-04-16 12:57:22 +02:00
theludovyc
58fcbc2b06 Remove unused ofs variable 
(cherry picked from commit 875c994109)
 2020-04-16 12:47:18 +02:00
Guilherme Felipe
ddde3819d6 Fix TextureRect::flip_* when used with atlas texture 
Fix #37526

(cherry picked from commit fb2d2dd5d0)
 2020-04-16 12:47:18 +02:00
PouleyKetchoupp
18c5ef5473 Add style for highlighted Slider grab area 
(cherry picked from commit 4c8173af0f)
 2020-04-16 12:47:17 +02:00
Leleat
8da00fbfc7 fixed PopupMenus letterjumping on any InputEvent 
(cherry picked from commit 8a5660f3d1)
 2020-04-16 11:58:14 +02:00
Zak Grumbles
5d9108c9c6 Fix OptionButton docs godotengine#36803 
* item_selected and item_focused docs incorrectly had 'id' as the parameter. Changed to
'index'.
* Fix parameter name in ADD_SIGNAL callin code.

(cherry picked from commit a8de034f78)
 2020-04-16 11:45:19 +02:00
Thakee Nathees
324213a6db fix project manager don't consume Enter key #17620 
(cherry picked from commit b98153886f)
 2020-04-16 11:44:44 +02:00
janglee
e1ca49b4b6 Corrected text selection in color picker 
Fixes #35603

(cherry picked from commit 77b70aa79d)
 2020-04-16 11:43:35 +02:00
qarmin
57952d562c Fixes leak with drives [3.2] 2020-04-12 14:05:47 +02:00
Eoin O'Neill
c18381119e Correction to RichTextLabel Tabulation 
Correct backtrack assignment to prevent excessive tabulation. Worth
noting that tabulation is treated differently in RichTextLabel because
of custom user-asignable tab variable which creates problems with
dynamic fonts specifically.

(cherry picked from commit 2000e110a9)
 2020-04-06 18:19:14 +02:00
Gil Arasa Verge
f144ec9e67 Clicking backgrd. dimming of editor popup stops input event propagation 
A click on the dimmed background of a popup in the editor should stop the input event from propagating to the background.

This solution reuses the system introduced in commit efc3ffb8, taking advantage of the hide() notifications from the modal where we will set the flag "pass_on_modal_close_click(false)" to stop event handling at the viewport input event handling.
The viewport first hides the modal and after marks the input as handled if the flag mentioned above is set.

Fixes #36341

(cherry picked from commit 35bc88ca34)
 2020-03-25 11:38:54 +01:00
nathanwfranke
b95a2306db Fix tab container too large when tabs are hidden 
(cherry picked from commit c0a84f747e)
 2020-03-25 11:38:54 +01:00
Rémi Verschelde
86ecefa1a2 Fix potential divisions by 0 reported by MSVC 
The `TextEdit` one was indeed a potential bug.
The `PCKPacker` one seems to be a false positive, it's already in a
`for` loop that depends on `files.size()`.

(cherry picked from commit ca4e4506db)
 2020-03-25 11:38:54 +01:00
Tomasz Chabora
c8318012a8 Make search in RichTextLabel case-insensitive 
(cherry picked from commit b3f83ac115)
 2020-03-25 11:38:53 +01:00
simpuid
223d0abd7e Remove update condition from LineEdit::update_placeholder_width 
Placeholder with length greater than `max_length` are allowed, so there is no reason for those update condition.
It fixes the odd alignment of placeholder when it's length is greater than `max_length`

(cherry picked from commit 43b2f75d64)
 2020-03-25 11:38:53 +01:00
Darren Kaste
53c8d8a5fb Use LineEdit secret character width everywhere 
(cherry picked from commit c7c47410aa)
 2020-03-25 11:38:53 +01:00
Darren Kaste
f657614760 Calculate LineEdit selection with secret character 
(cherry picked from commit 395a038c85)
 2020-03-25 11:38:53 +01:00
Dominik 'dreamsComeTrue' Jasiński
e590a33d45 Allow single quotes in comments 
Fixes: #36638
(cherry picked from commit ab6456d1bc)
 2020-03-25 09:45:08 +01:00
Rémi Verschelde
c01e840f03
Merge pull request #36639 from RandomShaper/imvu/improve_drives_ux_3.2 
Improve UX of drive letters (3.2)
 2020-03-17 16:27:33 +01:00
Pedro J. Estébanez
6105dfdac9 Improve UX of drive letters 
Namely, move the drive dropdown to just the left of the path text box and don't include the former
in the latter.

This improves the UX on Windows.

In the UNIX case, since its concept of drives is (ab)used to provide shortcuts to useful paths, its
dropdown is kept at the original location.
 2020-03-17 14:48:54 +01:00
Dominik 'dreamsComeTrue' Jasiński
f328ac36d6 Fix: auto brace complete for quoted strings 
Fixes #36002

(cherry picked from commit 6a404a88e4)
 2020-03-04 09:53:44 +01:00
Rémi Verschelde
2bae35353d Revert "Fix control node transform animation jitter with pivot offset" 
This reverts commit 15315f118c.

It caused a regression: #36087.
 2020-03-04 09:50:21 +01:00
Dominik 'dreamsComeTrue' Jasiński
eb22bcead7 RichTextLabel: proper handling of internal key events 
Fixes #36211

(cherry picked from commit ff030afc93)
 2020-02-19 10:09:28 +01:00
Michael Alexsander
18eba898f8 Fix hiding ColorPicker's presets not fully hiding its controls 
(cherry picked from commit 5f5ccfc361)
 2020-02-18 14:20:04 +01:00
Haoyu Qiu
be34e45233 Uses split cursor for SplitContainer 
(cherry picked from commit 206b9f2d23)
 2020-02-14 16:02:56 +01:00
Haoyu Qiu
0a3bf2b627 Fixes add group in Group Editor dialog 
Before this fix, new group can't be created if any existing group starts
with the new name.

(cherry picked from commit 421ea09195)
 2020-02-14 15:58:36 +01:00
Eoin O'Neill
0dedc0a1a3 Fix RichTextEffect visibility to Account for Skipped Characters. 
A picture is easier to describe this issue than words. Basically, rich
text effects allowed for character visibility changes. While doing so
would work properly, the rich text label would render the next `word` in
an offset accounting for the hidden characters (leaving a huge space.)

This patch fixes this issue by keeping track of the amount of
`backtrack` necessary per line.

(cherry picked from commit b3fd4884d7)
 2020-02-14 15:57:47 +01:00
sumit0190
58a940e5aa Update cached_width of the line_edit element when setting it to be secret 
(cherry picked from commit 2e08578985)
 2020-02-14 15:56:48 +01:00
Georg Wacker
15315f118c Fix control node transform animation jitter with pivot offset 
The workaround for moving the pivot is not needed anymore, in fact it causes all transforms applied to control nodes to jitter while animating (if a pivot offset is set).

This can be observed via AnimationPlayer and Tween.

The fix is to remove the obsolete workaround that causes this bug.

Fixes #28804

(cherry picked from commit dfb7d46a2a)
 2020-02-06 13:02:07 +01:00
Haoyu Qiu
808a0bac33 Fixes OptionButton min size 
(cherry picked from commit ddc397d9ff)
 2020-02-06 13:02:07 +01:00
Rémi Verschelde
11d28b2d10 Revert "make Label consider spaces for visible_characters" 
This reverts commit 695980a0f2.

Fixes #35668.
 2020-01-28 19:37:04 +01:00
Haoyu Qiu
71b1a1c7d9 Updates minimum size on VideoPlayer::set_stream 2020-01-26 10:24:56 +08:00
Rémi Verschelde
c2e07db071
Merge pull request #35438 from MadEqua/virtual-keyboard-line-edit 
Android virtual keyboard respecting LineEdit max length.
 2020-01-23 08:20:24 +01:00
Bruno Lourenço
a3bcdbeb78 Android virtual keyboard respecting LineEdit max length. 2020-01-23 01:52:49 +00:00
Ricardo Buring
40542b0b0f Fix Control::_window_find_focus_neighbor 
Due to a typo, the size of a candidate neighbor was confused with the
size of the control itself.

Fixes #34936.
 2020-01-19 23:38:50 +01:00
Rémi Verschelde
dd3779c12e
Merge pull request #35183 from YeldhamDev/scrollbar_regression 
Fix scrollbar regression on large scales
 2020-01-16 07:56:05 +01:00
Michael Alexsander
76e03f9b4d Fix scrollbar regression on large scales 2020-01-16 00:59:46 -03:00
Haoyu Qiu
574918f344 Updates ScrollContainer min size when toggle scrollbars 2020-01-16 09:42:31 +08:00
Haoyu Qiu
26e3b4a58a Updates LineEdit's min size when necessary 
These properties will affect the minimum size of LineEdit:

* The right icon (`set_right_icon`)
* The clear button (`set_editable` and `set_clear_button_enabled`)
* The text, when "expand to text length" is enabled (`set_text`)
 2020-01-15 10:15:32 +08:00
Michael Alexsander
db8c4c2a22 Fix regression on scrollbar raising in ScrollContainer 2020-01-14 19:55:12 -03:00
Michael Alexsander
34bf81fa7c Cleanup unnecessary code from before the scrollbar overlapping fixes 2020-01-14 18:19:12 -03:00
Rémi Verschelde
57986208f3
Merge pull request #35130 from qarmin/crash_item_bad_index 
Don't allow to use too big index in ItemList
 2020-01-14 21:03:25 +01:00
Rafał Mikrut
724f5f3178 Don't allow to use too big index in ItemList 2020-01-14 20:17:48 +01:00
Rémi Verschelde
63112b5090
Merge pull request #35106 from YeldhamDev/scrollbar_overlap_fixes 
Fix more instances of overlapping scrollbars
 2020-01-14 08:12:20 +01:00
Michael Alexsander
712cd8a97e Fix more instances of overlapping scrollbars 2020-01-13 22:49:17 -03:00
Haoyu Qiu
66a54582ee Updates min size on CenterContainer::set_use_top_left 2020-01-14 08:35:21 +08:00
Rémi Verschelde
04a1ae90df
Merge pull request #35080 from malbach/scrollbars_overlap 
Fix #33309 Overlapping Scrollbars in ScrollContainer
 2020-01-13 16:10:12 +01:00
malbach
bc8ce836e3 Fix overlapping scrollbars in ScrollContainer (#33309) 2020-01-13 14:37:55 +01:00
Rémi Verschelde
100f50b7df Control/Light2D: Preventing setting 0 as scale as for Node2D 
Triggers errors in `Transform2D::affine_invert()`.

Fixes #26510.
Fixes https://github.com/godotengine/godot/issues/24997#issuecomment-457951639.
 2020-01-13 12:20:15 +01:00
Rémi Verschelde
478ab8b45b
Merge pull request #34960 from johannesgunnar/spin_box-apply-method 
Spinbox apply input method
 2020-01-12 14:16:14 +01:00
Paulb23
22c15083af Fix empty LineEdit crash on ctrl+backspace 2020-01-11 17:57:36 +00:00
Jóhannes Gunnar Þorsteinsson
083637a901 Add apply method to SpinBox 2020-01-11 10:47:51 +00:00
Tomasz Chabora
60cd3df337 Add signal for LineEdit overflow event 2020-01-10 21:07:00 +01:00
Rémi Verschelde
59a2fed1e6
Merge pull request #34938 from OverloadedOrama/fix-basebutton-button-press 
Fixes BaseButton not triggering the pressed signal on "Button Press"…
 2020-01-10 10:35:11 +01:00
Haoyu Qiu
fbd937bd30 Update minimum size on Label::set_autowrap 
If `clip_text` is true, the minimum height is one line if `autowrap` is
true , or one pixel otherwise.
 2020-01-10 17:08:27 +08:00
Gilles Roudière
b5251eb00f Don't compile editor-only function when tools=no 2020-01-09 22:15:48 +01:00
OverloadedOrama
bf4a0242ff Fixes BaseButton not triggering the "pressed" signal on "Button Press" Action Mode 
This should fix #34935
 2020-01-09 02:17:53 +02:00
Haoyu Qiu
4293f76cf1 Emits meta_hover_ended when mouse exit RichTextLabel 2020-01-08 21:01:08 +08:00
Rémi Verschelde
1de54bb388
Merge pull request #34874 from wingedadventurer/bugfix-label-visible-characters 
Make Label node consider spaces for visible_characters property
 2020-01-08 08:18:59 +01:00
Rémi Verschelde
033fb72c03
Merge pull request #34871 from lentsius-bark/textEdit-vertical-horizontal-scroll-expose 
expose scroll_vertical and scroll_horizontal in TextEdit
 2020-01-08 08:18:12 +01:00
Rémi Verschelde
90c487ebf3
Merge pull request #34900 from timothyqiu/rtl-cell-wrap 
Fixes RichTextLabel click issue when cell text wraps
 2020-01-08 07:08:02 +01:00
Michael Alexsander
8b5992f665 Make possible to edit the GraphEdit's selection rect colors 2020-01-07 23:20:48 -03:00
Haoyu Qiu
d17a4efc43 Fixes RichTextLabel click issue when cell text wraps 2020-01-08 09:08:03 +08:00
Kanabenki
d79f0e7d40 Check if cursor is inside meta when getting cursor shape 2020-01-07 15:46:11 +01:00
Krystof Klestil
c475f11018 expose scroll_vertical and scroll_horizontal in TextEdit + documentation 2020-01-07 15:16:07 +01:00
wingedadventurer
695980a0f2 make Label consider spaces for visible_characters 2020-01-06 23:29:00 +01:00
volzhs
e5a0018621 Calculate label size more accurately 2020-01-07 04:21:02 +09:00
volzhs
3f0c7b89ec Fix calculating label size 2020-01-06 01:06:26 +09:00
Haoyu Qiu
78e9ca58af Makes more strings translatable 2020-01-04 13:46:38 +08:00
Rémi Verschelde
6f279ed6eb
Merge pull request #34781 from fossegutten/button-flash 
Fixes button flashing when releasing mousebutton outside
 2020-01-03 16:23:57 +01:00
fossegutten
b728d3bd18 Fixes button flashing when releasing mousebutton outside 2020-01-03 14:55:27 +01:00
Haoyu Qiu
229b398146 Better horizontal scroll for Tree 
* Adds pan gesture support for horizontal scroll.
* Scrolls horizontally when needed to ensure cursor visiblility.
 2020-01-03 20:16:32 +08:00
Haoyu Qiu
e539b187a5 Clears button mask before activating menu item 2020-01-03 09:35:00 +08:00
Rémi Verschelde
1788b22b11
Merge pull request #34737 from timothyqiu/tree-item-offset 
Fixes Tree item offset when root is hidden
 2020-01-02 08:17:29 +01:00
Rémi Verschelde
ca38190363
Merge pull request #34735 from YeldhamDev/texturerect_code_format 
Minor code formatting in TextureRect file
 2020-01-02 08:01:55 +01:00
Haoyu Qiu
0ee93257e8 Fixes Tree item offset when root is hidden 
Before this fix, one vseparation is counted for a hidden root item.
 2020-01-02 09:20:43 +08:00
Michael Alexsander
7b86688ddf Minor code formatting in TextureRect file 2020-01-01 21:56:12 -03:00
Haoyu Qiu
a77e869b87 Ensures cursor visible for Tree with title 2020-01-01 22:47:42 +08:00
Rémi Verschelde
f7715b58bd
Merge pull request #34724 from timothyqiu/tree-right 
Fixes behavior of right arrow key in Tree
 2020-01-01 12:13:28 +01:00
Rémi Verschelde
5b173c4bf1
Merge pull request #34654 from Calinou/colorpicker-move-preview-under-picker 
Move the ColorPicker preview under the picker area
 2020-01-01 11:38:04 +01:00
Rémi Verschelde
a7f49ac9a1 Update copyright statements to 2020 
Happy new year to the wonderful Godot community!

We're starting a new decade with a well-established, non-profit, free
and open source game engine, and tons of further improvements in the
pipeline from hundreds of contributors.

Godot will keep getting better, and we're looking forward to all the
games that the community will keep developing and releasing with it.
 2020-01-01 11:16:22 +01:00
Haoyu Qiu
838d9519bc Fixes behavior of right arrow key in Tree 2020-01-01 17:57:40 +08:00
Rémi Verschelde
406dac1917
Merge pull request #34633 from qarmin/lineedit_signal 
Don't try to connect "text_entered" signal to nodes other than LineEdit
 2019-12-31 12:54:48 +01:00
Rémi Verschelde
1bed049ed5
Merge pull request #34612 from timothyqiu/item-list 
Improves ItemList documentation
 2019-12-31 12:45:40 +01:00
Haoyu Qiu
7a752215ba Improves ItemList 
* Adds range hint for integer properties
* Adds missing descriptions in documentation
* Updates some method descriptions to match the actual behavior
* Fixes second param name of `set_item_icon_transposed` from `rect` to `transposed`
 2019-12-31 08:44:55 +08:00
Tomasz Chabora
54f70b6b50 Fix argument type in set_follow_focus() 2019-12-30 23:42:39 +01:00
Rémi Verschelde
97ebde45d5
Merge pull request #34572 from KoBeWi/I_give_up 
Make new ScrollContainer focus behavior optional
 2019-12-30 19:00:57 +01:00
Rémi Verschelde
7b412eb839
Merge pull request #34653 from YeldhamDev/optionbutton_margin_auto 
Make OptionButton itself take into account the arrow margin instead of relying on the theme
 2019-12-30 18:00:37 +01:00
Tomasz Chabora
cc72885107 Make new ScrollContainer focus behavior optional 2019-12-30 16:40:02 +01:00
Rémi Verschelde
edf2ed5e50
Merge pull request #34582 from timothyqiu/forward-decl 
Cleans up headers included in editor_node.h
 2019-12-30 16:28:47 +01:00
Rémi Verschelde
5b687b4c93
Merge pull request #34563 from Paulb23/23751_extra_line_indent 
Fixed selection indent taking an additional line
 2019-12-30 16:20:37 +01:00
Hugo Locurcio
bbd5e39165
Move the ColorPicker preview under the picker area 
This moves it to be closer to the sliders, which in turn makes it easier
for the user to preview the color.

This also makes it clearer that the Pick button can only pick colors
in the editor window, not outside.
 2019-12-28 18:23:28 +01:00
Michael Alexsander
c4cd2c44c8 Make OptionButton itself take into account the arrow margin instead of relying on the theme 2019-12-28 12:03:04 -03:00
Rafał Mikrut
0a1d3e4437 Don't try to connect "text_entered" signal to nodes other than LineEdit 2019-12-27 12:08:49 +01:00
Haoyu Qiu
078c0d75f2 Cleans up headers included in editor_node.h 2019-12-24 21:46:05 +08:00
Paulb23
0049f43fc8 Fixed selection indent taking an additional line 2019-12-23 13:16:57 +00:00
Jonas Bernemann
2f35cf4946 Fix issue with disconnecting events when font changes 2019-12-23 14:08:34 +01:00