Commit Graph

21510 Commits

Author SHA1 Message Date
lawnjelly e36e9fdb1c Fixes crash with rigged meshes on some OpenGLES2 devices
Non-tools OpenGLES2 devices that use the USE_SKELETON_SOFTWARE path (i.e. do not support float texture) depend on surface->data being set containing the bone IDs and weights (rasterizer_scene_gles2.cpp, line 1456, RasterizerSceneGLES2::_setup_geometry). However currently if TOOLS_ENABLED is not defined, surface->data is not stored in main memory in rasterizer_storage_gles2.cpp. This causes a crash in rasterizer_scene_gles2.cpp when a rigged object comes into view.

This fix addresses the specific case of skinned objects when USE_SKELETON_SOFTWARE is active, and stores a copy of the bone data, as is done when TOOLS_ENABLED is defined. This fixes the crash by allowing the same mechanism as on desktop, without adding the memory overhead of storing all vertex data where not required.

Fixes #28298
2019-06-18 09:42:07 +01:00
Rémi Verschelde 8c11f883d9
Merge pull request #29129 from kis3lori/remove-save-theme-for-default
Created a fallback from the "Save Theme" button to "Save Theme As" when a default theme is in use.
2019-06-13 12:10:05 +02:00
Kis Levente Lorand 0823d78374 Created a fallback from the "Save Theme" button to "Save Theme As" when a default theme is in use. 2019-06-13 11:26:08 +03:00
Rémi Verschelde 41a62f3ac3
Merge pull request #29737 from YeldhamDev/connections_dialog_minor_cleanup
Minor cleanup in connections dialog file
2019-06-13 10:17:42 +02:00
Rémi Verschelde 5ec99dc62f
Merge pull request #29644 from YeldhamDev/editor_file_recent_reselect
Make possible to reselect an item in the "Recent" list in the EditorFileDialog
2019-06-13 10:11:16 +02:00
Rémi Verschelde d888c50fa3
Merge pull request #29638 from YeldhamDev/editor_file_hidden_toggle
Add button for toggling hidden files in EditorFileDialog
2019-06-13 10:09:19 +02:00
Rémi Verschelde 006df1f2bc
Merge pull request #29636 from Calinou/project-manager-dim-window-quitting
Dim the project manager window while it's quitting
2019-06-13 10:07:58 +02:00
Rémi Verschelde 6effe33bba
Merge pull request #29635 from YeldhamDev/editor_file_favorite_fix
Apply a better fix for the EditorFileDialog crash on favorite
2019-06-13 10:03:52 +02:00
Rémi Verschelde ae6e562bd8
Merge pull request #29628 from qarmin/fix_invalid_write_mesh
Fix write outside array in mesh_add_surface
2019-06-13 10:01:20 +02:00
Michael Alexsander Silva Dias fdd461ddd0 Minor cleanup in connections dialog file 2019-06-13 02:47:12 -03:00
Rémi Verschelde a745934761
Merge pull request #29731 from akien-mga/scene-is-off-limits
Cleanup some unecessary editor/ includes in scene/
2019-06-12 23:44:24 +02:00
Rémi Verschelde bbbc04b2fe
Merge pull request #29711 from zaksnet/windows-export-improvemnts
Added hint for windows export options
2019-06-12 23:44:11 +02:00
Rémi Verschelde 32ae64a371
Merge pull request #29708 from sparkart/master
Added script name tooltip for Open Script Icon
2019-06-12 23:10:38 +02:00
Rémi Verschelde b44488d823
Merge pull request #29702 from KoBeWi/fix_random_crash
Validate parameters of randi_range()
2019-06-12 23:07:39 +02:00
Rémi Verschelde 1a9a2c879a
Merge pull request #29645 from YeldhamDev/create_dialog_reselect
Allow reselecting items in the "Favorites" and "Recent" lists in the create dialog
2019-06-12 22:58:09 +02:00
Rémi Verschelde 1c35973b83
Merge pull request #29592 from Lisapple/patch-3
Fixing returned alpha component for inverted method
2019-06-12 22:57:10 +02:00
Rémi Verschelde 51ed803a11
Merge pull request #29658 from clayjohn/docs_mesh
Filled out docs for various mesh types
2019-06-12 22:52:54 +02:00
Rémi Verschelde 84d969a42a Cleanup some unecessary editor/ includes in scene/
Part of #29730, handles false positives.
2019-06-12 22:48:43 +02:00
Rémi Verschelde 2dc3347ce9
Merge pull request #29717 from akien-mga/button-shortcut-pressed
BaseButton: Make shortcuts call virtual methods
2019-06-12 22:46:12 +02:00
Rémi Verschelde d1a88cb895
Merge pull request #29716 from YeldhamDev/create_node_error_spam
Fix error spam in create dialog when searching for nodes with some disabled
2019-06-12 22:45:47 +02:00
Rémi Verschelde 3b53db750a
Merge pull request #22863 from Paulb23/reload_shader_external_change_issue_19852
Reload text shaders when externally edited, issue 19852
2019-06-12 22:44:55 +02:00
Tomasz Chabora d89478975f Validate parameters of randi_range() 2019-06-12 19:46:07 +02:00
clayjohn ef45f5ce75 filled out docs for various mesh types 2019-06-12 09:49:47 -07:00
Emmanuel Barroga e15c5489a8 Added script name tooltip for Open Script Icon
Resolves issue: 29541
2019-06-12 08:10:00 -07:00
Rémi Verschelde 2cedf7173a BaseButton: Make shortcuts call virtual methods
When buttons are not in Toggle Mode, shortcuts used to only trigger the
`pressed` signal, without calling the `_pressed` virtual method,
contrarily to what happens when you click the button.

For Toggle Mode buttons, it did call the `_toggled` virtual method
together with emitting the `toggled` signal *twice*.

This commit harmonizes it all and makes shortcuts behave the same as
mouse clicks or `ui_accept`, for both toggle and non-toggle modes.

Fixes #29604.
2019-06-12 16:35:49 +02:00
Rémi Verschelde f410e7a8a9
Merge pull request #29616 from Calinou/humanize-size-clearer-rounding
Make humanized size rounding clearer by padding decimals with zeroes
2019-06-12 16:25:10 +02:00
Michael Alexsander Silva Dias c22dcca866 Fix error spam in create dialog when searching for nodes with some disabled 2019-06-12 10:43:42 -03:00
Rémi Verschelde 4073da7ddd
Merge pull request #29605 from Lisapple/patch-4
Adding details about `Image.lock()` function
2019-06-12 15:33:27 +02:00
Rémi Verschelde 73960e585b
Merge pull request #27193 from toasteater/fix/pcg-randf
Improved uniformity of RandomPCG::randf.
2019-06-12 15:21:58 +02:00
Rémi Verschelde 704f2c5d85
Merge pull request #29615 from Calinou/fix-editor-monitor-large-sizes
Fix display of large sizes in the editor monitors
2019-06-12 15:21:37 +02:00
Rémi Verschelde 082f398481
Merge pull request #28735 from aqnuep/dss_loader_fixes
Fixes to the DDS loader
2019-06-12 14:36:26 +02:00
Rémi Verschelde 4db4b7a605
Merge pull request #29583 from Toshiwoz/master
Fix Vector3 slerp method by normalizing cross product
2019-06-12 14:34:28 +02:00
Rémi Verschelde c8db517993
Merge pull request #29316 from Chaosus/shader_const
Added constant support to shaders
2019-06-12 14:26:45 +02:00
Rémi Verschelde df25679235
Merge pull request #29601 from NilsIrl/hiding_enabled
Treat hiding_enabled as bool throughout
2019-06-12 14:23:27 +02:00
Zak 3168c25bad Added hint for windows export options 2019-06-12 14:42:35 +03:00
Rémi Verschelde 1e5a02f006
Merge pull request #29599 from Calinou/assetlib-project-icon-loading
Display a "loading" placeholder while icons are loading in the assetlib
2019-06-12 13:36:06 +02:00
Rémi Verschelde 97fb28df0d
Merge pull request #29595 from YeldhamDev/bus_editor_enhancements
Enhancements for the audio bus editor
2019-06-12 13:34:30 +02:00
Rémi Verschelde 902212d8d4
Merge pull request #29646 from tree786/patch-2
'get_skidinfo()' misleading description
2019-06-12 13:30:52 +02:00
Rémi Verschelde 434a1fddf3
Merge pull request #29648 from jbuck3/tree-tooltips
Fix Tree button tooltips
2019-06-12 13:29:36 +02:00
Rémi Verschelde 5522d7c2b0
Merge pull request #29664 from akien-mga/external-editor-default-flags
Always pass script path to external editor
2019-06-12 13:24:57 +02:00
Rémi Verschelde f65b0c6d89
Merge pull request #29679 from akien-mga/windows-res-desc
Remove "Editor" from Windows PE file description
2019-06-12 13:24:30 +02:00
Rémi Verschelde 59a0d90f3a
Merge pull request #29695 from jbuck3/fix-script-create-dialog
Fix script create dialog
2019-06-12 13:24:02 +02:00
Rémi Verschelde a2a5273a07
Merge pull request #29703 from YeldhamDev/method_signal_warning_base
Check base scripts for signal receiving methods before warning about them missing
2019-06-12 13:11:17 +02:00
Rémi Verschelde c010714732
Merge pull request #29710 from Calinou/assetlib-remove-unimplemented
Remove some references to unimplemented features in the assetlib
2019-06-12 12:55:16 +02:00
Rémi Verschelde 5688cb40b2
Merge pull request #29589 from kbajno/master
Add in missing 'FLAG_DRAW_NEXT_FRAME_IF_VISIBLE' to Flag enun
2019-06-12 12:52:47 +02:00
Rémi Verschelde f47f905248
Merge pull request #29517 from KoBeWi/pan_shop
Allow to change 2D pan hotkey
2019-06-12 12:51:22 +02:00
Rémi Verschelde ec98db048f
Merge pull request #29481 from bruvzg/macos_fix_dvorak_qwerty_cmd_hotkeys
Fixes hotkeys on "Dvorak - QWERTY ⌘" keyboard layout.
2019-06-12 12:50:55 +02:00
Rémi Verschelde 94fbaf71a6
Merge pull request #29474 from YeldhamDev/pick_subtile_fix
Fix subtile picking in TileMap editor
2019-06-12 12:50:31 +02:00
Rémi Verschelde 0e6cac8ab8
Merge pull request #29465 from bruvzg/per_pixel_transp_impr
Removes redundant "splash" setting, improves per pixel transparency documentation.
2019-06-12 12:50:17 +02:00
Rémi Verschelde 971b5160c6
Merge pull request #29306 from qarmin/small_code_fixes
Small fixes to unrechable code, possibly overflows, using NULL pointers
2019-06-12 12:49:21 +02:00