godotengine/godot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
259ed1d400
godot/editor/plugins
History
Pedro J. Estébanez 259ed1d400 Improve popup menus usability 
It seems that popups were intended to "grab" the mouse click that triggered them, but their intent was being lost. This commit does the necessary changes to let it happen and updates items that were trying to get advantage of it, because the semantics of `Control::grab_click_focus()` have changed a bit. Namely, it must be called **before** showing the modal.

This allows to popup a menu and activate an item in it in a single click-point-release cycle, instead of having to click once to open the menu and once more to pick an item.

This ability is extended even to context menus activated with the RMB (or any other mouse button, for that matter). The editor benefits from this in the context menu of the tree dock, which has been patched to opt-in for this feature.

This improves UX a bit by saving unnecessary clicks.

From now on, `PopupMenu` always grabs the click and also invalidates the first button release unless the mouse has moved (that's what `set_invalidate_click_until_motion()` was doing and now it's removed), so there is no longer the need of doing both things at every point a pop-up menu is shown.
2018-04-07 01:06:02 +02:00
..
abstract_polygon_2d_editor.cpp Add missing copyright headers and fix formatting 2018-01-05 01:22:23 +01:00
abstract_polygon_2d_editor.h Add missing copyright headers and fix formatting 2018-01-05 01:22:23 +01:00
animation_player_editor_plugin.cpp AnimationPlayer: fix scrubbing after play backwards 2018-03-09 19:41:14 +01:00
animation_player_editor_plugin.h Add missing copyright headers and fix formatting 2018-01-05 01:22:23 +01:00
animation_tree_editor_plugin.cpp Add missing copyright headers and fix formatting 2018-01-05 01:22:23 +01:00
animation_tree_editor_plugin.h Add missing copyright headers and fix formatting 2018-01-05 01:22:23 +01:00
asset_library_editor_plugin.cpp Merge pull request #17013 from Noshyaar/theme 2018-03-13 13:48:37 +01:00
asset_library_editor_plugin.h Update icons when theme changed 2018-02-25 23:04:16 +07:00
baked_lightmap_editor_plugin.cpp -Remove color operator clamping, which is unnecesary. Fixes #15184, fixes #14686. 2018-01-12 00:08:32 -03:00
baked_lightmap_editor_plugin.h Add missing copyright headers and fix formatting 2018-01-05 01:22:23 +01:00
camera_editor_plugin.cpp Add missing copyright headers and fix formatting 2018-01-05 01:22:23 +01:00
camera_editor_plugin.h Add missing copyright headers and fix formatting 2018-01-05 01:22:23 +01:00
canvas_item_editor_plugin.cpp Improve popup menus usability 2018-04-07 01:06:02 +02:00
canvas_item_editor_plugin.h Fixes scrollbars in Canvas Item Editor 2018-03-17 12:18:33 +01:00
collision_polygon_2d_editor_plugin.cpp Add missing copyright headers and fix formatting 2018-01-05 01:22:23 +01:00
collision_polygon_2d_editor_plugin.h Add missing copyright headers and fix formatting 2018-01-05 01:22:23 +01:00
collision_polygon_editor_plugin.cpp Fix typos with codespell 2018-02-21 19:46:06 +01:00
collision_polygon_editor_plugin.h Add missing copyright headers and fix formatting 2018-01-05 01:22:23 +01:00
collision_shape_2d_editor_plugin.cpp Add missing copyright headers and fix formatting 2018-01-05 01:22:23 +01:00
collision_shape_2d_editor_plugin.h Add missing copyright headers and fix formatting 2018-01-05 01:22:23 +01:00
cube_grid_theme_editor_plugin.cpp Changes the keep_margin parameter to true by default, so that people are not suprised that set_anchor changes the margins values 2018-01-15 10:37:13 +01:00
cube_grid_theme_editor_plugin.h Add missing copyright headers and fix formatting 2018-01-05 01:22:23 +01:00
curve_editor_plugin.cpp Fix typos in code and docs with codespell 2018-01-18 22:01:42 +01:00
curve_editor_plugin.h Update copyright statements to 2018 2018-01-01 14:40:47 +01:00
editor_preview_plugins.cpp Fix round preview getting square on "run scene" (issue 16734) 2018-02-28 20:23:40 +01:00
editor_preview_plugins.h Fix round preview getting square on "run scene" (issue 16734) 2018-02-28 20:23:40 +01:00
gi_probe_editor_plugin.cpp -Remove color operator clamping, which is unnecesary. Fixes #15184, fixes #14686. 2018-01-12 00:08:32 -03:00
gi_probe_editor_plugin.h Add missing copyright headers and fix formatting 2018-01-05 01:22:23 +01:00
gradient_editor_plugin.cpp Add missing copyright headers and fix formatting 2018-01-05 01:22:23 +01:00
gradient_editor_plugin.h Add missing copyright headers and fix formatting 2018-01-05 01:22:23 +01:00
item_list_editor_plugin.cpp Update icons when theme changed 2018-02-25 23:04:16 +07:00
item_list_editor_plugin.h Add missing copyright headers and fix formatting 2018-01-05 01:22:23 +01:00
light_occluder_2d_editor_plugin.cpp Add missing copyright headers and fix formatting 2018-01-05 01:22:23 +01:00
light_occluder_2d_editor_plugin.h Add missing copyright headers and fix formatting 2018-01-05 01:22:23 +01:00
line_2d_editor_plugin.cpp Add missing copyright headers and fix formatting 2018-01-05 01:22:23 +01:00
line_2d_editor_plugin.h Add missing copyright headers and fix formatting 2018-01-05 01:22:23 +01:00
material_editor_plugin.cpp Update copyright statements to 2018 2018-01-01 14:40:47 +01:00
material_editor_plugin.h Add missing copyright headers and fix formatting 2018-01-05 01:22:23 +01:00
mesh_editor_plugin.cpp Add missing copyright headers and fix formatting 2018-01-05 01:22:23 +01:00
mesh_editor_plugin.h Add missing copyright headers and fix formatting 2018-01-05 01:22:23 +01:00
mesh_instance_editor_plugin.cpp Add missing copyright headers and fix formatting 2018-01-05 01:22:23 +01:00
mesh_instance_editor_plugin.h Add missing copyright headers and fix formatting 2018-01-05 01:22:23 +01:00
multimesh_editor_plugin.cpp Add missing copyright headers and fix formatting 2018-01-05 01:22:23 +01:00
multimesh_editor_plugin.h Add missing copyright headers and fix formatting 2018-01-05 01:22:23 +01:00
navigation_mesh_editor_plugin.cpp Add missing copyright headers and fix formatting 2018-01-05 01:22:23 +01:00
navigation_mesh_editor_plugin.h Add missing copyright headers and fix formatting 2018-01-05 01:22:23 +01:00
navigation_mesh_generator.cpp Fix typos in code and docs with codespell 2018-01-18 22:01:42 +01:00
navigation_mesh_generator.h Fix typos in code and docs with codespell 2018-01-18 22:01:42 +01:00
navigation_polygon_editor_plugin.cpp Add missing copyright headers and fix formatting 2018-01-05 01:22:23 +01:00
navigation_polygon_editor_plugin.h Add missing copyright headers and fix formatting 2018-01-05 01:22:23 +01:00
particles_2d_editor_plugin.cpp Add missing copyright headers and fix formatting 2018-01-05 01:22:23 +01:00
particles_2d_editor_plugin.h Add missing copyright headers and fix formatting 2018-01-05 01:22:23 +01:00
particles_editor_plugin.cpp Update copyright statements to 2018 2018-01-01 14:40:47 +01:00
particles_editor_plugin.h Add missing copyright headers and fix formatting 2018-01-05 01:22:23 +01:00
path_2d_editor_plugin.cpp Add missing copyright headers and fix formatting 2018-01-05 01:22:23 +01:00
path_2d_editor_plugin.h Add missing copyright headers and fix formatting 2018-01-05 01:22:23 +01:00
path_editor_plugin.cpp Add missing copyright headers and fix formatting 2018-01-05 01:22:23 +01:00
path_editor_plugin.h Add missing copyright headers and fix formatting 2018-01-05 01:22:23 +01:00
polygon_2d_editor_plugin.cpp Add a split editor to polygon 2D UV editor, moving an inch closer to adding support for in the future 2018-02-25 12:07:13 -03:00
polygon_2d_editor_plugin.h Add a split editor to polygon 2D UV editor, moving an inch closer to adding support for in the future 2018-02-25 12:07:13 -03:00
resource_preloader_editor_plugin.cpp Display path to preloaded res + button to open it 2018-01-15 07:49:29 +01:00
resource_preloader_editor_plugin.h Display path to preloaded res + button to open it 2018-01-15 07:49:29 +01:00
script_editor_plugin.cpp ScriptEditor: Use EditorSettings instead of hardcoded values in constructor. 2018-03-01 21:45:24 +01:00
script_editor_plugin.h Merge pull request #16455 from volzhs/close-docs 2018-02-20 09:40:29 +01:00
script_text_editor.cpp ScriptTextEditor: fix capitalize offset 2018-03-12 01:37:41 +07:00
script_text_editor.h Add special coloring to members, to make shadowing more obvious. 2018-01-12 11:01:09 -03:00
SCsub Refactoring: rename tools/editor/ to editor/ 2017-03-05 14:21:25 +01:00
shader_editor_plugin.cpp Add missing copyright headers and fix formatting 2018-01-05 01:22:23 +01:00
shader_editor_plugin.h Add missing copyright headers and fix formatting 2018-01-05 01:22:23 +01:00
shader_graph_editor_plugin.cpp Improve popup menus usability 2018-04-07 01:06:02 +02:00
shader_graph_editor_plugin.h Add missing copyright headers and fix formatting 2018-01-05 01:22:23 +01:00
skeleton_2d_editor_plugin.cpp 2D Skeletons WORK IN PROGRESS 2018-02-21 17:24:00 -03:00
skeleton_2d_editor_plugin.h 2D Skeletons WORK IN PROGRESS 2018-02-21 17:24:00 -03:00
spatial_editor_plugin.cpp Improve popup menus usability 2018-04-07 01:06:02 +02:00
spatial_editor_plugin.h Enable snapping when control key pressed 2018-02-21 17:36:25 +03:00
sprite_editor_plugin.cpp Was missing clearing computed UVs, sorry, realized late. 2018-02-21 09:40:01 -03:00
sprite_editor_plugin.h Add base support for 2D meshes in Godot, including Sprite -> Mesh2D conversion. 2018-02-21 09:39:09 -03:00
sprite_frames_editor_plugin.cpp Clean up some bad words from code comments 2018-02-17 16:00:39 +03:00
sprite_frames_editor_plugin.h Add missing copyright headers and fix formatting 2018-01-05 01:22:23 +01:00
style_box_editor_plugin.cpp Add missing copyright headers and fix formatting 2018-01-05 01:22:23 +01:00
style_box_editor_plugin.h Add missing copyright headers and fix formatting 2018-01-05 01:22:23 +01:00
texture_editor_plugin.cpp Fix gradient texture preview 2018-02-03 12:10:44 +03:00
texture_editor_plugin.h Add missing copyright headers and fix formatting 2018-01-05 01:22:23 +01:00
texture_region_editor_plugin.cpp Merge pull request #17013 from Noshyaar/theme 2018-03-13 13:48:37 +01:00
texture_region_editor_plugin.h Tileset Editor Improvement 2018-02-20 22:33:59 +07:00
theme_editor_plugin.cpp Refactor version macros and fix related bugs 2018-02-23 20:15:29 +01:00
theme_editor_plugin.h Add missing copyright headers and fix formatting 2018-01-05 01:22:23 +01:00
tile_map_editor_plugin.cpp Merge pull request #16971 from Noshyaar/tilemap 2018-03-13 13:57:58 +01:00
tile_map_editor_plugin.h TileMap: add fix_invalid_tiles 2018-02-24 19:34:41 +07:00
tile_set_editor_plugin.cpp Merge pull request #17013 from Noshyaar/theme 2018-03-13 13:48:37 +01:00
tile_set_editor_plugin.h TileSetEditorPlgn: use EditorHandle icon as handle 2018-03-02 23:15:32 +07:00