Davide De Rosa
c7cb00f679
Move ProfileKey to separate file
2018-11-06 11:16:34 +01:00
Davide De Rosa
389746180b
Move PlaceholderConnectionProfile to separate file
2018-11-06 11:16:30 +01:00
Davide De Rosa
0c389d8d8e
Make caught errors warnings instead
2018-11-06 11:03:15 +01:00
Davide De Rosa
299c4088ad
Improve ConnectionProfile description format
...
Refines 137e87a
2018-11-06 11:02:44 +01:00
Davide De Rosa
aa6af8acb3
Update TunnelKit to fix IPv4 endianness
...
Hopefully once and for all!
2018-11-05 20:48:51 +01:00
Davide De Rosa
66cfab678b
Fix wrong team ID
...
Even if essentially unused.
2018-11-05 15:44:49 +01:00
Davide De Rosa
fb8e7f9950
Update SwiftGen comments
2018-11-05 14:12:30 +01:00
Davide De Rosa
5b016df7f3
Drop optional, lastModified is non-optional
2018-11-04 18:32:08 +01:00
Davide De Rosa
ceeda8c314
Fix default trust policy
2018-11-04 16:49:46 +01:00
Davide De Rosa
137e87ad69
Add description for generic ConnectionProfile
2018-11-04 15:56:05 +01:00
Davide De Rosa
e7d2dde972
Add/remove profile to/from filesystem immediately
...
Save unnecessary serialization of unaffected profiles.
2018-11-04 15:06:53 +01:00
Davide De Rosa
bc0568cc38
Do not re-save profiles on (de)activate
...
Only service JSON is affected.
2018-11-04 14:55:25 +01:00
Davide De Rosa
9bda7f9576
Reword policy text
2018-11-04 12:14:23 +01:00
Davide De Rosa
2dafe9f1f2
Invert caption/logic about trusted network policy
...
Looks more intuitive (default ON).
2018-11-04 12:02:02 +01:00
Davide De Rosa
cfad536048
Attach .ovpn rather than .txt
...
Less convenient to quick look, yet more convenient for testing
import.
2018-11-04 11:57:44 +01:00
Davide De Rosa
f2b5c05d58
Test and fix behavior with compression options
...
Changes in #20 were insufficient.
2018-11-04 11:57:37 +01:00
Davide De Rosa
c1065751b6
Add method to parse configuration from [String]
...
With an optional original URL. Helps testing. Take the chance to
also disambiguate method overloads.
2018-11-04 11:45:19 +01:00
Davide De Rosa
9e7c4960e5
Update GitHub URL in license preamble
2018-11-04 10:53:16 +01:00
Davide De Rosa
1ab26dd8a2
Update GitHub repository constants
2018-11-04 10:53:16 +01:00
Davide De Rosa
ef03b2b94d
Leave serialization up to delegate
...
Ends up calling saveProfiles() multiple times otherwise.
2018-11-04 10:49:40 +01:00
Davide De Rosa
8e445e90b3
Move profile reactions to delegate
...
- Activation
- Removal
2018-11-04 10:49:40 +01:00
Davide De Rosa
f75fbfb4bb
Remove keychain password with profile removal
2018-11-02 15:52:36 +01:00
Davide De Rosa
b051f8118f
Add "Edit" item to rename host profile
...
Disabled in network profiles. Reuse same title style/constraints
and message strings in host wizard.
For consistency, rename activate() to activateProfile(). And it's
not even an IBAction.
2018-11-02 15:52:36 +01:00
Davide De Rosa
56c0a1a15e
Add profile renaming logic
...
- Suspend delegation of internal add/remove.
- Review several try/throws.
2018-11-02 15:52:36 +01:00
Davide De Rosa
aa2b6bafaf
Add method to rename immutable profile
2018-11-02 15:52:34 +01:00
Davide De Rosa
3f1e98f8ac
Delegate profile management from ConnectionService
...
Makes much more sense than dumb wizard notifications. Organizer is
already a ConnectionServiceDelegate.
2018-11-02 15:20:37 +01:00
Davide De Rosa
a0ff420f54
Add dot as legal char in profile title
...
Fixes #22
2018-11-02 14:06:04 +01:00
Davide De Rosa
d756948872
Fix endianness of pool addresses
...
Rushed in 64cbb9b
but still broken.
2018-11-02 13:59:35 +01:00
Davide De Rosa
4870e2233d
Fix regexes to warn about compression
...
By not including the potential argument in the pattern:
- comp-lzo *always* raises a warning
- compress *never* raises a warning
2018-11-02 00:04:28 +01:00
Davide De Rosa
af870e2a84
Fix migrateJSON declarations and exposure
...
Unit tests could not compile.
2018-11-01 23:55:59 +01:00
Davide De Rosa
25c2308c63
Reject encrypted certificate key
...
Do at least a poor-man check on the PEM header.
Fixes #15
2018-11-01 14:31:24 +01:00
Davide De Rosa
0ab2244c36
Revert "Move variable declaration to proper scope"
...
This reverts commit 49b86c2888
.
...because it was VERY WRONG.
2018-11-01 14:29:03 +01:00
Davide De Rosa
52394296be
Drop pre-release migration logic
2018-11-01 13:42:20 +01:00
Davide De Rosa
64cbb9b4b2
Use versioned TunnelKit
...
Also fixes issues with IPv4/UInt32 endianness.
2018-11-01 13:41:27 +01:00
Davide De Rosa
a4f46d0d7b
Reword imported hosts title
2018-11-01 13:40:15 +01:00
Davide De Rosa
964a4d701b
Make serviceURL an external static var
2018-11-01 13:40:15 +01:00
Davide De Rosa
36995e089b
Locate profiles via relative URLs
...
Avoid absolute URLs, profiles directory is always relative to
documents. Assume profiles to be based in the documents root
unless directory is != nil.
Given that, starting from iOS 8, the documents location can change
from time to time, could this fix #19 ?
2018-11-01 13:39:55 +01:00
Davide De Rosa
2197c96bd9
Move serialization URLs to ConnectionService
...
Keep ProfileKey a bare struct.
2018-11-01 13:32:53 +01:00
Davide De Rosa
6cb85a952d
Find source links in the home page
2018-10-30 20:46:41 +01:00
Davide De Rosa
88124f5588
Replace source section with web section
2018-10-30 20:44:58 +01:00
Davide De Rosa
0706d552be
Drop redundant disconnection alert on Wi-Fi add
...
Doesn't trust by default, so it won't disconnect.
See 474105d
2018-10-30 00:30:30 +01:00
Davide De Rosa
2564f2446d
Show disclaimer from website
2018-10-29 21:25:22 +01:00
Davide De Rosa
fe85677e68
Add privacy policy
2018-10-29 21:25:08 +01:00
Davide De Rosa
482b51cb52
Move non-affiliation to main version screen
2018-10-29 21:25:08 +01:00
Davide De Rosa
17ebaccbad
Add title to version screen
2018-10-29 21:25:08 +01:00
Davide De Rosa
fec2f02df5
Move Credits inside Version
2018-10-29 21:25:06 +01:00
Davide De Rosa
cced9b018f
Fix provider name ordering
...
Define intrinsecally with Comparable.
2018-10-29 17:48:17 +01:00
Davide De Rosa
0d49d1abc8
Upgrade SwiftGen
2018-10-28 14:50:12 +01:00
Davide De Rosa
474105d671
Add current Wi-Fi without auto-trusting
2018-10-28 14:50:09 +01:00
Davide De Rosa
ebe8c5836b
Only retain first parsing warning
2018-10-28 14:41:41 +01:00
Davide De Rosa
49b86c2888
Move variable declaration to proper scope
2018-10-28 14:41:41 +01:00
Davide De Rosa
326c5b823d
Observe wizard creation via notifications
...
Flow is too scattered to safely maintain delegation.
2018-10-27 20:11:26 +02:00
Davide De Rosa
fa59b8b5f9
Fix handling of extra whitespaces in .ovpn
...
Fixes #17
2018-10-27 19:49:35 +02:00
Davide De Rosa
b7dc72a5e9
Sort hosts ignoring case
2018-10-27 16:56:41 +02:00
Davide De Rosa
8d2ce2e7ae
Handle potentially unsupported as a warning alert
...
Configuration is imported anyway, so alert must be asynchronous.
2018-10-27 14:57:37 +02:00
Davide De Rosa
0b7ab7bca6
Intercept potentially unsupported options
...
As warnings.
2018-10-27 14:51:51 +02:00
Davide De Rosa
cda53bc4f1
Clean up Inbox on migration
2018-10-27 13:35:21 +02:00
Davide De Rosa
dcecc84bda
Remove .ovpn of deleted profile
2018-10-27 13:35:21 +02:00
Davide De Rosa
0e7c0b6388
List imported .ovpn if any, fall back to alert
...
Use .formSheet presentation (iPad).
2018-10-27 12:43:26 +02:00
Davide De Rosa
25523b5f61
Add stubs for imported hosts
2018-10-27 12:43:26 +02:00
Davide De Rosa
9e933d68c5
Improve unsupported options filter
2018-10-27 12:33:30 +02:00
Davide De Rosa
8c1e6d00ca
Parse .ovpn file outside of wizard context
2018-10-27 12:33:17 +02:00
Davide De Rosa
422c4da09c
Move ParsedFile out of WizardHostVC
2018-10-27 12:08:44 +02:00
Davide De Rosa
0d14349bca
Move filename charset to extensions
2018-10-27 12:08:44 +02:00
Davide De Rosa
4bcb1fe2ad
Convert some warnings to errors
2018-10-27 12:08:44 +02:00
Davide De Rosa
804585f13d
Fix/improve some poor filename parsing
2018-10-27 10:52:26 +02:00
Davide De Rosa
e00129c8a5
Adjust issue alert to new .ovpn attachment
2018-10-27 09:43:57 +02:00
Davide De Rosa
4b075bcc95
Improve alerts on configuration import error
...
Issue reporting is currently disabled because un unparsed .ovpn
may contain sensitive data.
2018-10-27 09:43:57 +02:00
Davide De Rosa
73e09fefb1
Retain unhandled mtu/mssfix lines in stripped
2018-10-27 09:43:57 +02:00
Davide De Rosa
c7639daf0d
Strip configuration file before attaching
...
Of sensitive or private data.
2018-10-27 09:42:41 +02:00
Davide De Rosa
a69c7c5733
Attach .ovpn as plain text
...
Can easily inspect via email.
2018-10-27 09:42:41 +02:00
Davide De Rosa
dfde9c51e3
Fine-grain report attachments
...
- Debug log
- .ovpn profile (if any)
2018-10-27 09:42:41 +02:00
Davide De Rosa
821393af70
Refactor configurations in service extension
...
Reuse same directories of ConnectionService for storing
configuration files.
2018-10-27 09:42:41 +02:00
Davide De Rosa
4388dfe6ae
Lower log level
2018-10-27 09:42:41 +02:00
Davide De Rosa
76f2597424
Update TunnelKit and remove unused code
...
ConnectionProfileHolder
2018-10-26 19:05:25 +02:00
Davide De Rosa
52ec2bebd5
Restrict charset for host profile title
...
It's used now as a filename. Remember to also normalize pre-filled
title from imported filename by replacing illegal characters.
2018-10-26 18:57:07 +02:00
Davide De Rosa
b5347e04b2
Move Context to ConnectionProfile
...
Fix an id conflict in credentials.
2018-10-26 18:57:07 +02:00
Davide De Rosa
18c7de140e
Overwrite an existing profile configuration
2018-10-26 18:57:07 +02:00
Davide De Rosa
78abb8c764
Refactor service to use external profile JSONs
...
- Store only profile key/metadata into service.
- Map profiles by (context, id), context being either provider
or host.
- Initialize cache with a placeholder profile, lazily load full
profile (e.g. after opening profile).
- Only serialize non-placeholder profiles (opened once).
- Do not load full profiles for organizer listing
WARNING: always load active profile as non-placeholder.
2018-10-26 18:30:37 +02:00
Davide De Rosa
2d2884fdea
Export profiles to separate JSONs
...
Use id as contextual filename.
2018-10-26 18:03:28 +02:00
Davide De Rosa
2aae3499de
Move host configurations to "Hosts" subdirectory
...
Without "host." prefix, now unnecessary.
2018-10-26 18:03:28 +02:00
Davide De Rosa
8e1b67d151
Infer profile id uniqueness by context
...
Drop "(provider|host)." prefix, reuse as title.
2018-10-26 17:37:52 +02:00
Davide De Rosa
8f29f79168
Fix exceptions thrown on already migrated JSON
...
Also remove deprecated tunnel configuration keys.
2018-10-26 15:31:02 +02:00
Davide De Rosa
52cf733948
Only make host editable if original cfg available
2018-10-25 22:57:42 +02:00
Davide De Rosa
9726158030
Drop deprecated configuration values
...
- debugLogKey
- lastErrorKey
2018-10-25 22:45:50 +02:00
Davide De Rosa
12e0a55f7a
Bind migrations to build numbers
2018-10-25 22:45:50 +02:00
Davide De Rosa
082ffa3cb1
Attach build number to service JSON
...
Update before serializing.
2018-10-25 22:45:50 +02:00
Davide De Rosa
c73c2e3826
Rename tunnelConfiguration to baseConfiguration
...
It's much less confusing. Migrate too.
2018-10-25 22:45:50 +02:00
Davide De Rosa
09685e6994
Activate service migration
2018-10-25 22:45:50 +02:00
Davide De Rosa
d087acd512
Migrate host configurations
2018-10-25 22:45:50 +02:00
Davide De Rosa
542a3e3721
Upgrade TunnelKit with configuration refactoring
2018-10-25 22:45:44 +02:00
Davide De Rosa
f1f09dde2f
Rename support request to join community
2018-10-24 21:57:27 +02:00
Davide De Rosa
ef9032e440
Update TunnelKit
...
- Improve logging performance and privacy.
- Fix server-side renegotiation issues.
2018-10-24 21:23:13 +02:00
Davide De Rosa
205f8a9c0e
Refine regex for unsupported blocks
...
Was rejecting entries with shared prefix (e.g. "key" -> "keysize").
2018-10-24 10:24:45 +02:00
Davide De Rosa
f691a4f204
Raise exception on proxy in .ovpn
2018-10-24 00:24:23 +02:00
Davide De Rosa
ebbba3a713
Update TunnelKit to handle new error codes
2018-10-23 23:51:50 +02:00
Davide De Rosa
d026004db3
Raise exception on external file in .ovpn
...
- ca
- cert
- key
- tls-auth
- tls-crypt
2018-10-23 19:07:09 +02:00
Davide De Rosa
d781d9c8e0
Add share section with generic activity
...
To invite a friend.
2018-10-23 12:59:06 +02:00
Davide De Rosa
81c7236500
Localize Twitter intent
2018-10-23 12:59:06 +02:00
Davide De Rosa
39c053bd54
Add tweet cell to About
2018-10-23 12:59:06 +02:00
Davide De Rosa
4bd339d456
Remove "Report issue" from About
...
Will bind report to current profile.
2018-10-23 12:59:06 +02:00
Davide De Rosa
0f374fa8c9
Rename "Submit debug log" to "Report issue"
2018-10-23 12:59:06 +02:00
Davide De Rosa
edc513f6cc
Drop password confirmation field
2018-10-23 12:57:41 +02:00
Davide De Rosa
be17f57a5e
Add reset cell to revert to original configuration
...
When a backing .ovpn is available.
2018-10-23 12:57:11 +02:00
Davide De Rosa
346a9490ec
Save .ovpn internally associated to host profile
2018-10-23 12:57:11 +02:00
Davide De Rosa
9292919816
Update VPN status after profile reinstall
...
Should now cover all scenarios.
2018-10-23 12:54:40 +02:00
Davide De Rosa
976e47af64
Clear VPN error status before restart
2018-10-22 21:49:43 +02:00
Davide De Rosa
e8f2aaaf08
Show tunnel failure reason in VPN status
2018-10-22 21:49:43 +02:00
Davide De Rosa
3dd7f9e779
Update VPN section footer accordingly
2018-10-21 10:19:42 +02:00
Davide De Rosa
be6abdcf2a
Move file-to-lines to String extension
2018-10-21 09:36:50 +02:00
Davide De Rosa
8219519a22
Fix credentials requirement in VPN configuration
...
Refines #4
2018-10-19 17:51:25 +02:00
Davide De Rosa
0954de3322
Support TLS wrapping via TunnelKit
...
tls-auth and tls-crypt.
2018-10-19 17:25:39 +02:00
Davide De Rosa
ae2bd3d876
Replace some profile exceptions with preconditions
...
Misconfigured profiles must fall back to a consistent state, this
is a programming error.
- provider.pool: fall back to default pool (should always be there)
- provider.preset: why would one remove a preset?
- host.endpointProtocols: .ovpn with no remotes shouldn't get this far
2018-10-19 01:29:44 +02:00
Davide De Rosa
5e0590184b
Require credentials for providers only
...
Not always the case, but PIA certainly requires them. Will make it
an infrastructure option later. Only require credentials as a
configuration check, everything else has defaults.
2018-10-19 01:29:44 +02:00
Davide De Rosa
23e27535c6
Split support requests
...
- Generic support on Reddit
- Debug log via email
2018-10-18 16:40:58 +02:00
Davide De Rosa
46a8f72039
Bump API endpoint version
2018-10-18 14:07:32 +02:00
Davide De Rosa
8d1acda11a
Reject API response requiring more recent build
2018-10-18 14:02:35 +02:00
Davide De Rosa
567ddd9b12
Find out version/build statically
...
Assume bundle and info dictionary are never nil.
2018-10-18 14:02:35 +02:00
Davide De Rosa
c1be49a164
Add PIA patches support
2018-10-18 13:38:00 +02:00
Davide De Rosa
4774c2705f
Raise exception on unrecognized option values
...
Do not fall back when an unhandled value is found in:
- cipher
- auth
- proto
Falling back to a default value here would break the data
connection most of the time.
2018-10-18 10:25:15 +02:00
Davide De Rosa
b93000819b
Reuse Credits VC to add a Disclaimer
2018-10-18 10:19:08 +02:00
Davide De Rosa
62d1c2d882
Add promoting alert for subreddit
2018-10-18 10:04:23 +02:00
Davide De Rosa
b6d430f106
Add link to Reddit
2018-10-18 09:37:18 +02:00
Davide De Rosa
e31e4a31df
Reword issue report
2018-10-18 09:37:18 +02:00
Davide De Rosa
ccd5e2d03e
Append exception desc to parsing error alert
2018-10-18 09:32:18 +02:00
Davide De Rosa
b62f7669f2
Match cfg lines from the beginning
...
E.g. cipher was matching tls-cipher.
2018-10-17 23:59:30 +02:00
Davide De Rosa
f3df03de9b
Disclose organizer profiles
...
Use text instead of checkmark to mark active profile. Allows
restoring disclosure indicator.
2018-10-17 23:58:49 +02:00
Davide De Rosa
d1b0b59748
Treat unsupported option errors specifically
...
Show a more informative alert if the provided .ovpn file contains
an unsupported option.
2018-10-16 18:03:13 +02:00
Davide De Rosa
1602972c8e
Replace self-hosted API with static GitHub Pages
2018-10-11 21:30:53 +02:00
Davide De Rosa
76da7426cf
Add missing credits
2018-10-11 09:47:40 +02:00
Davide De Rosa
b9ec01945d
Initial commit
2018-10-11 09:13:19 +02:00