Commit Graph

1072 Commits

Author SHA1 Message Date
Davide De Rosa ddce671c62 Move theme extensions to non-reusable 2022-05-18 11:33:29 +02:00
Davide De Rosa b1d77cccbc Attempt beta release 2022-05-18 11:18:57 +02:00
Davide De Rosa 4455f66d10 Detect TestFlight on macOS
Move function to Utils.
2022-05-18 11:16:31 +02:00
Davide De Rosa 160338e62a Add credits in Mac about 2022-05-17 19:57:19 +02:00
Davide De Rosa 4c2a471b9f Attempt beta release 2022-05-17 19:34:13 +02:00
Davide De Rosa 4edecf123b Fix missing accent color in CI
Finally? Basically Xcode build settings were referring to new
color name "AccentColor", while color set in repository was
still "accentColor".

Went unnoticed because Mac filesystem is case-insensitive, which
is why Git never committed the name change in the first place.
2022-05-17 19:34:00 +02:00
Davide De Rosa 6c798c8b19 Bump build 2022-05-17 16:43:14 +02:00
Davide De Rosa 7196aeab0d Trust Ethernet on Mac 2022-05-16 11:19:33 +02:00
Davide De Rosa f5e01f9768 Wrap/refine a few OS conditionals 2022-05-16 11:19:18 +02:00
Davide De Rosa 16d618df0e Show info menu in ProfileView on iPad/Mac
Use .navigationBarTrailing to avoid artifact on Catalyst (item
relocates when first clicked).

Rename menu files too.
2022-05-16 11:18:58 +02:00
Davide De Rosa 6fddbb8bfc Decouple menus from OrganizerView
Could move .sheet() from parent View to Menu, but no luck with
.fileImporter()
2022-05-16 11:18:58 +02:00
Davide De Rosa d89130bc3a Reorganize profile menu into computed properties 2022-05-16 11:18:58 +02:00
Davide De Rosa e87ad06c5d Drop old observables from profiles list
List was being reloaded e.g. on ProductManager receipt updates,
but profile in-app eligibility is not a thing anymore.
2022-05-16 10:59:12 +02:00
Davide De Rosa 137bacb542 Add contextual profile delete
Without confirmation alert though.
2022-05-15 22:24:36 +02:00
Davide De Rosa 35ec73570e Use NEHotspotNetwork to fetch current SSID
Old method did not work on Catalyst.
2022-05-15 22:24:36 +02:00
Davide De Rosa 743facca6b Improve Catalyst appearance
- Revert to more "stable" iPad idiom

- Set accent color the proper way

- Use .tint when available

- Unify navigation style by idiom

- Retain navigation bars in sidebar/detail

- Lighten sidebar appearance

- Fix Menu style (dropdown -> button)

- Use native Picker (dropdown)

- Use switch toggles rather than checkboxes

- Replace .actionSheet with .alert

- Increase minimum row height

CAVEAT: on Mac with iPad idiom, having a Section in .sidebar
produces artifacts. Header keeps changing height for no reason.
Retain Section on iPad multitasking only to not break navigation.
2022-05-15 22:24:36 +02:00
Davide De Rosa eaaa1fe260 Move device checks to Theme
Drop unused code along the way.
2022-05-15 22:24:36 +02:00
Davide De Rosa d558edf665 Assume test build if appType == .beta 2022-05-15 21:03:32 +02:00
Davide De Rosa 6c87e0a15b Use gray for profile subtitle 2022-05-15 21:03:32 +02:00
Davide De Rosa 683a8e7d82 Attempt beta release 2022-05-05 11:07:49 +02:00
Davide De Rosa 9984c56084 Drop unnecessary async from migration code
Providers are not fetched at migration time, they only are after
opening a profile (marked non-ready until then).

Still retain Task for migration to be executed asynchronously.
2022-05-05 11:04:12 +02:00
Davide De Rosa 15a4cc8f75 Change some icons in extra menu
- Main icon

- Review icon
2022-05-05 09:58:53 +02:00
Davide De Rosa b7cccbdd0a Reorg images 2022-05-05 09:51:26 +02:00
Davide De Rosa cca2dca047 Export providers database in beta 2022-05-05 09:46:12 +02:00
Davide De Rosa abb23e8234 Fix missing animation loading non-ready profile
When there is no initial active profile.
2022-05-05 08:57:02 +02:00
Davide De Rosa 092233b546 Attempt beta release 2022-05-04 23:16:01 +02:00
Davide De Rosa bafac12be4 Retain in beta profiles created in production
Drop filter, ability to create profiles in the first place implies
eligibility.
2022-05-04 23:15:12 +02:00
Davide De Rosa c2676cbdf6 Attempt beta release 2022-05-04 19:03:22 +02:00
Davide De Rosa 40a3c67b1c Observe updates AFTER setting active profile
App disconnects VPN on launch otherwise, because active
profile is still nil. Where was the regression introduced?

Also .dropFirst() to skip initial values, but keep in mind that
if VPN is connected and active profile was not properly persisted,
the app will show the VPN as disabled.
2022-05-04 10:34:28 +02:00
Davide De Rosa 9e9cd018eb Revert "Enable "DNS Settings" capability"
This reverts commit 75650b1f0a.
2022-05-04 09:01:27 +02:00
Davide De Rosa 92caf67876 Replace dimming with different icon 2022-05-03 19:24:46 +02:00
Davide De Rosa 4cb18965c9 Set duplicate as current inside ProfileManager
When setting duplicate as current, batch save original profile and
duplicate in a single call via profilesToSave. This is to avoid a
double call to willUpdateProfiles() when saving Core Data context.

In order to set current profile to one that has not been persisted
yet (the duplicate), we need to resort to a pendingProfiles map
where to look the duplicate up when setting currentProfileId.

Either way, iOS 14 cannot handle updating a "hot" change in a
presented NavigationLink. Changing currentProfileId binding while
in ProfileView messes up navigation completely (multiple push and
pop events). Avoid.
2022-05-03 18:35:19 +02:00
Davide De Rosa 943bce5515 Bind navigation to ProfileManager directly
- Do the profile loading inside the model

- Allow setting current profile to a transient profile

- Check .placeholder before saving current profile

XXX: avoid loading active profile on iPad portrait.
2022-05-03 18:35:17 +02:00
Davide De Rosa 7036ca5f41 Fix handling of non-ready profiles
- Omit title while isLoading, to not show former profile name

- Animate on isLoading
2022-05-03 15:54:19 +02:00
Davide De Rosa b9248cbb89 Animate profile removal
Fade into WelcomeView.
2022-05-03 15:44:47 +02:00
Davide De Rosa ca49d8bfc6 Increase vertical padding in profile rows 2022-05-03 15:43:55 +02:00
Davide De Rosa 8230666ab2 Only use wrapping Section to fix iPad multitasking 2022-05-03 15:43:15 +02:00
Davide De Rosa 3c0e511e84 Split again OrganizerView and ProfilesList
On iOS 14, Organizer scrolls abruptly on profile selection. It
looks like this was introduced by merging ProfilesList into
OrganizerView.

Try to revert merge to split observation responsibilities.

Drop unused AppManager in +Scene along the way.
2022-05-03 14:40:41 +02:00
Davide De Rosa 93abaf538b Simplify redundant parts of ProfileManager
- Drop overthought activeHeader

- Drop willUpdateCurrentProfile, use observable

- Drop willUpdateActiveId, observe value publisher
2022-05-03 14:36:55 +02:00
Davide De Rosa e0e3e03781 Fix missing image on iOS 14 2022-05-03 12:46:55 +02:00
Davide De Rosa d3bd41b251 Do not blink circle while connected 2022-05-02 10:56:40 +02:00
Davide De Rosa cc681dfeab Refine profile icons and animate if connected
Assume 3 different profile states:

- Active and connected
- Active
- Inactive
2022-05-02 10:48:12 +02:00
Davide De Rosa 576eb1512a Fix slow active profile selection on launch
Regression due to missing .stack navigation style basically.

Restore .onAppear() on NavigationLink.
2022-05-02 09:53:18 +02:00
Davide De Rosa 75650b1f0a Enable "DNS Settings" capability
Maybe fixes #182
2022-05-02 00:04:56 +02:00
Davide De Rosa 63c2ab6bbf Fix missing server permissions for WireGuard
Prevented working on Catalyst.
2022-05-02 00:03:55 +02:00
Davide De Rosa 87f2ebfd9e Attempt beta release 2022-05-01 20:44:17 +02:00
Davide De Rosa acbc1980f9 Ignore non-existing active profile 2022-05-01 20:40:20 +02:00
Davide De Rosa 472b5e4b41 Fix active profile flickering on first launch
Move .onAppear() handler to main view.
2022-05-01 20:16:05 +02:00
Davide De Rosa 3571c7db35 Reduce vertical padding in profile rows 2022-05-01 20:06:03 +02:00
Davide De Rosa 14dd920ef1 Drop unused animate on appear delay 2022-05-01 19:52:33 +02:00
Davide De Rosa 48d499569b Use block versions of Section header/footer 2022-05-01 19:48:24 +02:00
Davide De Rosa d8b19b952a Add missing translations 2022-05-01 19:34:43 +02:00
Davide De Rosa 171c1e1dd4 Omit wrapping Section on Mac 2022-05-01 19:30:56 +02:00
Davide De Rosa cfc0d4f572 Restore active profile on top
Flashing on activation was caused by VPNManager.disable() in
ProfileView+VPN, because by setting lastError to nil it would
notify a change to ProfileRow (via VPNStateView) during the
profile row activation animation. That caused the flicker.

Instead, disable VPN first, then start the animation.

Anyway, avoid clearing a nil lastError.
2022-05-01 19:19:43 +02:00
Davide De Rosa edc7cdf045 Merge List into OrganizerView
- Restore wrapping Section as it seems to fix multitasking

- Hide profiles section if empty
2022-05-01 19:19:31 +02:00
Davide De Rosa 8003b4a92d Observe currentProfile in ProfileView
ProfileView is not interested in changes in other profiles
notified by ProfileManager. Set isLoading inside
ObservableObject for observable to be self-contained.

Loses observation of profile deletion, but dismiss on removal is
actually handled by OrganizerView, not ProfileView.

Also drop unused presentationMode.
2022-05-01 19:14:34 +02:00
Davide De Rosa 9af67e12ce Drop profiles Section wrapper 2022-04-29 19:51:18 +02:00
Davide De Rosa 0047d095fb Adjust navigation style to all devices
- Mac
    - Drop all styles
    - Tweak hide title bar
    - Hide navigation bar

- Restore single section for all profiles
    - Allows using NavigationLink safely
    - Indirectly fixes multitasking
    - Retains selection on profile activation
    - Clean up presentActiveProfile

- Leave active profile in its position
    - Fixes Mac flashing row selection on profile activation

- Unify profile row appearance
    - Use fixed .headline font
    - Add subtitles to inactive profiles
    - Use padding rather than fixed row height

CAVEATS:

- Do not preselect active profile on iPad launch, as doing so
seems to present two ProfileView on top of each other, one from
MainView and one from the NavigationLink.

- Do not touch .listStyle() of master view, as it seems to break
navigation esp. in iPad multitasking.
2022-04-29 19:29:47 +02:00
Davide De Rosa 4d13d8bf6b Do not observe AppManager, just use for migrations 2022-04-29 18:58:07 +02:00
Davide De Rosa fc784ffeb1 Import new translations
3 phrases still missing.
2022-04-28 22:47:07 +02:00
Davide De Rosa 2c2e794b00 Revert async loadCurrentProfile()
Make action sync, but internally async (makeProfileReady). If not
doing so, UI on launch will not be able to show active profile
immediately. WelcomeView would appear for a moment.

Observe isReloadingCurrentProfile.

See 2b1efb8fec
2022-04-28 19:00:36 +02:00
Davide De Rosa 1ef2b8c7a7 Set activeProfileId immediately
Otherwise on app launch, active profile is rendered in 2 steps.
2022-04-28 17:56:28 +02:00
Davide De Rosa 03cb05da7e Do not disable providers while updating index 2022-04-27 23:08:46 +02:00
Davide De Rosa 2aa4008a08 Animate profile removal
Could only notice difference on iPad.
2022-04-27 18:32:44 +02:00
Davide De Rosa d4484f3307 Simplify layout of in-app products 2022-04-27 18:32:44 +02:00
Davide De Rosa 2b1efb8fec Make load*Profile() async
- Handle Task in consumers

- Drop makeReady, always make loaded profile ready

- Rename misleading loadProfile() to profileEx()
2022-04-27 17:13:03 +02:00
Davide De Rosa 02b2e3194e Add duplicate to profile menu
Contextually switch current profile to duplicate.
2022-04-27 16:59:33 +02:00
Davide De Rosa 496abc6c89 Move Siri on top of menu 2022-04-27 16:54:07 +02:00
Davide De Rosa 49a1f1b55c Address VPN toggle losing sync with internal state
- Update TunnelKit

- Receive TunnelKit notifications on main queue

- Bind VPN toggle to VPNManager directly (implicit animations)

- Update state on VPN didFail

- Set isEnabled = false after uninstalling VPN (not notified)
2022-04-27 15:53:31 +02:00
Davide De Rosa e77d78526b Use non-filled icons 2022-04-27 13:40:58 +02:00
Davide De Rosa cd854f8ebf Group profile actions into menus
- Organizer
    - Duplicate

- Profile
    - Rename
    - Siri
    - Uninstall (+ confirmation)
    - Delete (+ confirmation)
2022-04-27 09:53:42 +02:00
Davide De Rosa 1c047b9ce2 Retain profile name (disabled) after importing
Works around a crash in iPadOS 14 portrait when removing section
containing first responder (profile name TextField). It happened
when submitting profile name via keyboard rather than "Save".
2022-04-26 22:56:41 +02:00
Davide De Rosa 4a0245d757 Rename AddHostView to .NameView
In preparation of future additions to flow.
2022-04-26 22:44:34 +02:00
Davide De Rosa 03fdab4833 Duplicate profile from context menu 2022-04-26 22:39:47 +02:00
Davide De Rosa 1ea380312a Update providers index on add provider appearance 2022-04-26 22:15:39 +02:00
Davide De Rosa 6bff878952 Fix repeating "Default" servers in some providers
Disambiguate by apiId.
2022-04-26 22:12:22 +02:00
Davide De Rosa 4b8cff1bb3 Disable padding around LongContentView
It should actually be an inset. Do it later.
2022-04-26 21:39:21 +02:00
Davide De Rosa 99e48119f7 Encapsulate calculation of former products
Use an interface (BuildProducts) that makes understandable and
easily extensibile how some in-app products are inferred by build
number.
2022-04-26 20:55:18 +02:00
Davide De Rosa f4714dec58 Fix VPN toggle enabling despite errors 2022-04-26 19:02:12 +02:00
Davide De Rosa 4973a19fda Drop unused method 2022-04-26 10:59:48 +02:00
Davide De Rosa 1ff19b331f Move VPNToggle to standalone view 2022-04-26 10:40:46 +02:00
Davide De Rosa ccde6a30cf Fix issues with VPN toggle
- Move rate limit to UI only

- Keep caption constant to "Enabled"
2022-04-25 23:12:45 +02:00
Davide De Rosa 58cf401883 Share prefix for validating theme methods 2022-04-25 22:44:24 +02:00
Davide De Rosa 5c0e053e7d Review requirements of DNS over TLS (DoT)
- Make DNS servers optional in TunnelKit

- Allow IP address as DoT server name
2022-04-25 22:40:09 +02:00
Davide De Rosa efb9760d6b Redo VPN toggle properly
- Use local @State for appearance

- On binding set, control VPNManager
2022-04-25 16:36:07 +02:00
Davide De Rosa 6434008ebd Make destructive buttons standalone
- Uninstall VPN

- Remove profile (add to ProfileView)

Create DestructiveButton with iOS 15 .role when available.
2022-04-25 16:34:22 +02:00
Davide De Rosa ac1239daa8 Add headers to active/inactive profile sections
Hide inactive section if empty.
2022-04-25 16:34:13 +02:00
Davide De Rosa 339183c156 Fix phrase wording 2022-04-25 16:30:03 +02:00
Davide De Rosa 29629c5147 Use lighter font for non-active profiles 2022-04-25 15:35:21 +02:00
Davide De Rosa 84790080be Disable autocorrection on profile name 2022-04-25 15:28:55 +02:00
Davide De Rosa deac70359f Reorganize and fix platform-specific fastlane data
Reuse all iOS metadata in macOS, except the app icon.
2022-04-25 11:21:19 +02:00
Davide De Rosa 886d0271ea Restore 'Add' button in NetworkSettings
Makes it clear that added fields must be submitted in order to
be saved.
2022-04-23 15:47:02 +02:00
Davide De Rosa 0b1e465143 Share animation type in theme 2022-04-23 12:11:01 +02:00
Davide De Rosa 7eb2b3bd0e Drop button accent on Organizer rows 2022-04-23 11:48:43 +02:00
Davide De Rosa 6aee88e69a Refactor theme styles
- Hide colors behind styles

- Add "Style" suffix
2022-04-23 11:48:43 +02:00
Davide De Rosa dc66f514d9 Restore presentation conditions of active profile
On iPad it's already loaded in MainView().
2022-04-23 10:25:31 +02:00
Davide De Rosa c507c739bd Move WelcomeView to its own view 2022-04-23 10:25:31 +02:00
Davide De Rosa ad1539023e Split VPN status and data count 2022-04-23 10:25:31 +02:00
Davide De Rosa 1083941eeb Increase font size in Organizer 2022-04-23 10:25:31 +02:00
Davide De Rosa 4037b983cb Move active profile on top to its own section 2022-04-23 10:25:31 +02:00
Davide De Rosa b37ff03e4b Refactor hidden navlinks and send behind in ZStack 2022-04-23 10:25:31 +02:00
Davide De Rosa 2432f0d97a Rewrite ProfileView as a view of currentProfile
Do not load profile in View, instead:

- Load active profile on app launch

- Load selected profile on organizer selection
2022-04-23 10:25:31 +02:00
Davide De Rosa 8838e9d130 Strip a few unnecessary publishers
- Drop unused AppManager from OrganizerView

- Do not notify ProfileManager subscribers on activeProfileId

Saved active profile is already notified by:

- Core Data
- AppManager
2022-04-23 10:25:31 +02:00
Davide De Rosa d8e47cb7c0 Refactor strings and add new ones
- Move Localizable.strings above to share *.lproj folders

- Reorg menus into contextual/system

- Shorten titles of contextual menus

- Update sharing message with WireGuard

- Drop AlternativeTo

7 phrases left to translate into 9 languages.
2022-04-22 13:12:42 +02:00
Davide De Rosa 322bdf2993 Serialize active profile immediately
Otherwise:

- Switch from former active profile A to B
- Connect to now active profile B
- Kill app
- Reopen app
- App shows connected to profile A

Because active profile was not saved immediately on switch.

Unnecessary now to also save it on background persist().
2022-04-22 10:05:28 +02:00
Davide De Rosa 7095791428 Extend styles for VPN status description 2022-04-22 09:57:13 +02:00
Davide De Rosa 867b415b6b Fix double add menu in Organizer
Seems to happen when launching with active profile.

Use explicit position.
2022-04-22 09:52:10 +02:00
Davide De Rosa c9dfed676e Move VPN status below active profile
Rather than on the side. Similar to old subtitle table view cell.

Restore data count as well (when available).
2022-04-22 09:52:10 +02:00
Davide De Rosa 46050e0141 Refactor ProfileView a little bit
- Make welcome a computed property

- Reuse first header for consistency when loading

- Convert isDeleted to better isExisting (inverted)
2022-04-21 19:11:22 +02:00
Davide De Rosa fd7c232ecc Unroll ProfileView toolbar items
Also leave them visible when disabled.
2022-04-21 19:03:14 +02:00
Davide De Rosa 992178bcd6 Move toolbar content inline
For consistency, can search with "toolbar {".
2022-04-21 16:24:08 +02:00
Davide De Rosa 23d184ae08 Restore pre-scrolling in provider location
Artifacts are caused by translucent navigation bar, also in other
views. Will fix later.
2022-04-21 16:03:40 +02:00
Davide De Rosa e71b22c7c8 Simplify AddProfileView with implicit animations
- Animate on ViewModel in profile name views

- Animate on providers in provider selection view
2022-04-21 15:24:16 +02:00
Davide De Rosa 36cd9cfd96 Revert "Explicitly hide navigation bar in WelcomeView"
This reverts commit aefbfaa588.
2022-04-21 14:59:56 +02:00
Davide De Rosa ab7e6359ae Fix profile name reset to initial on error 2022-04-21 14:59:49 +02:00
Davide De Rosa ed16617288 Fix iOS 14 not preselecting created profile
When starting from empty profiles.
2022-04-21 14:59:17 +02:00
Davide De Rosa 759b740d62 Simplify ProfilesList with implicit animations
By A LOT.
2022-04-21 14:59:17 +02:00
Davide De Rosa 0a77be6ac5 Animate shortcuts reloading as well 2022-04-21 14:59:17 +02:00
Davide De Rosa d1c98006d3 Replace ReloadingContent with implicit animations
Infinite loop on init(), but horrible practice in general.

- DonateView
- PaywallView+Purchase

Also show a ProgressView while rows are loading.

DO NOT animate on .products value because animation won't work
if products are empty and stay empty after refresh. Instead,
observe .isRefreshingProducts.

Lastly, to avoid annoying animation when products are actually
available, do not refresh products if non-empty. They certainly
do not change during the application lifecycle.
2022-04-21 11:22:07 +02:00
Davide De Rosa 96b199425f Add ProgressView as overlay when possible
Instead of replacing view entirely (GenericCreditsView).

Make replacement explicit in DebugLogView.

Basically drop View extension.
2022-04-21 11:19:04 +02:00
Davide De Rosa aefbfaa588 Explicitly hide navigation bar in WelcomeView
May remain stale and empty on profile removal.
2022-04-20 11:50:23 +02:00
Davide De Rosa e7803fb894 Reuse logic to set Organizer headers
Refine headers sync on profile removal.
2022-04-20 11:50:10 +02:00
Davide De Rosa fff391702d Use 'Save' in profile renaming
Drop 'Done' label (unused).
2022-04-20 11:50:10 +02:00
Davide De Rosa dbc007b184 Restore .navigation for SettingsMenu 2022-04-19 23:20:04 +02:00
Davide De Rosa 1cfe6167e0 Use .cancellationAction placement for close button 2022-04-19 23:11:04 +02:00
Davide De Rosa 5b2ccaa110 Reposition Organizer toolbar 2022-04-19 23:02:19 +02:00
Davide De Rosa 3c2480d3b7 Rewrite ProfilesList without ReloadingContent
Make sure to update localHeaders contextually with
removeProfiles() to avoid a second update in onChange(). The
equality check in onChange() guards against setting localHeaders
twice.

Not doing so may break animation in swipe-to-delete due to the
overlapping animations (it certainly does break on iOS 14).
2022-04-19 22:47:06 +02:00
Davide De Rosa 17a383bc9c Redo ReloadingContent with @ObservedObject
Proper way to listen to changes in elements is observing their
parent.
2022-04-19 21:22:13 +02:00
Davide De Rosa 923ea923ab Fix active profile not preselected on launch
Function called multiple times sets isFirstLaunch to true even if
not active profile.
2022-04-19 21:19:43 +02:00
Davide De Rosa 18e9f7cbb5 Clear profile selection if current profile removed
Do it before ForEach rearranges NavigationLink elements, because
it may trigger undesired navigation to a deleted profile.

Restore related assertion.
2022-04-19 21:19:43 +02:00
Davide De Rosa 7128352a9c Fix settings menu not shown on iOS 14
Change to .navigation placement.
2022-04-19 21:19:43 +02:00
Davide De Rosa d7ada78845 Use "standard" file extension for WireGuard
Official app expects .conf and .zip
2022-04-19 16:56:39 +02:00
Davide De Rosa 3f9ff50d0e Optimize Catalyst for Mac
- Fix missing PlugIns in Catalyst build

Hence the VPN failure, there was a "iOS" filter on embed.

- Fix complaint about file access permission

Seems to need R/W when importing VPN configuration files.
2022-04-19 16:48:42 +02:00
Davide De Rosa 063f0621c1 Unify metadata
- Fix fastlane env variables

- Use single CHANGELOG.md in project root

- Retain old 1.x changelogs
2022-04-19 16:17:13 +02:00
Davide De Rosa bf65f76401 Merge project into iOS + macOS
Share views with both platforms initially. Will split specific
views step by step.
2022-04-19 16:14:23 +02:00
Davide De Rosa adbc086061 Adjust eligibility conditionals to Catalyst
- Replace os(iOS) with targetEnvironment(macCatalyst)

- Reuse same beta condition on Catalyst (must test to confirm)
2022-04-19 15:56:41 +02:00
Davide De Rosa f1aa192c9c Make App/Core iOS/Catalyst only
- Drop macOS target from Package.swift

- Drop @available attributes
    - UI idiom
    - Intents API
    - Swipe actions in ProviderLocationView

- Review os(iOS)
    - DebugLog, append idiom to tell Mac from iPad

- Drop redundant canImport
2022-04-19 15:56:41 +02:00
Davide De Rosa 2af28c158d Merge 'Views' folder 2022-04-19 10:12:52 +02:00
Davide De Rosa 20ec8d472f Add close button to modals
Swipe down only works on iOS portrait and iPadOS.
2022-04-19 10:10:08 +02:00
Davide De Rosa 991a283de9 Drop black title from VersionView
Clashes with dark background.
2022-04-19 09:52:23 +02:00
Davide De Rosa 12c6f40416 Remove ScrollViewReader preventing favorites reload
Content inside ScrollViewReader does not seem to be reload on
favorites toggle, for reasons I will review later. No big deal as
scrolling was already disabled.
2022-04-19 09:16:04 +02:00
Davide De Rosa ab0a2c8cb4 Reuse provider availability idea from 5d85699 2022-04-19 09:03:41 +02:00
Davide De Rosa 480738d126 Make shortcuts contextual in ProfileView
- Add toolbar item

- Target current profile

- Only list relevant shortcuts to profile
2022-04-19 08:41:07 +02:00
Davide De Rosa b1882dcf80 Preselect profile on NavigationLink appearance
More accurate than ForEach and maybe the only right place.
2022-04-19 08:39:34 +02:00
Davide De Rosa 5d85699ce4 Delete profile from Organizer
Swipe to delete. Address a couple things on iPad though:

1. Also check provider availability before showing view

fatalError hit on iPad when navigating from a ready provider
profile to a non-ready one. Similar to when navigating between
different VPN protocols.

2. Suppress assertion on deleted profile

Deleting current profile via swipe seems to re-render a new
NavigationLink with the deleted profile, which results in
loading a deleted profile and hitting the assertion. Not sure if
this is a programming error or a glitch in ForEach.
2022-04-19 08:38:10 +02:00
Davide De Rosa 18161ed1f1 Group Organizer modals into toolbar menus
- Drop status / navigation bars colors

- Restore large title on iPad

- Overlay organizer with "No profiles" when empty

- Uninstall VPN from ProfileView
2022-04-19 08:38:10 +02:00
Davide De Rosa 6533a6beae Disable pre-scrolling in location
May reveal artifacts in translucent navigation bar.
2022-04-18 19:51:50 +02:00
Davide De Rosa 017182fe81 Rewrite ReloadingSection to be semantic only
Use Group instead of Section. Also fix elements not loading if
initially empty.
2022-04-18 19:51:28 +02:00
Davide De Rosa f5c87d43c2 Better observe updates explicitly after init 2022-04-18 19:51:07 +02:00
Davide De Rosa 0db3e36bf4 Make network settings consistent
- Group DNS "Enabled" and protocol into configuration

- Make DNS servers / search domains optional

- Make proxy bypass domains optional

Also refine a comment about future on-demand.
2022-04-14 07:43:44 +02:00
Davide De Rosa 2565b9f3d0 Lock network settings for builds >= 3000 2022-04-13 21:25:24 +02:00
Davide De Rosa 320513dd38 Dismiss paywall predictably with Binding<Bool> 2022-04-13 21:24:38 +02:00
Davide De Rosa e7a5d82056 Restore purchases without refreshing receipt first
Any reason why I was doing that?

Also drop old ProductManager notification.
2022-04-13 21:24:09 +02:00
Davide De Rosa 0849fe6cc7 Attempt beta release 2022-04-13 19:49:58 +02:00
Davide De Rosa ad38ca5942 Skip bypass domains for proxy configured with PAC 2022-04-13 19:45:27 +02:00
Davide De Rosa 5874ce4b9d Attempt beta release 2022-04-13 19:40:18 +02:00
Davide De Rosa addbc181fd Make proxy configuration a 3-state
- Manual: server, port
- PAC: set PAC URL
- Disabled

BEWARE: breaking change in Profile.
2022-04-13 19:38:36 +02:00
Davide De Rosa 9055fec394 Fix on-demand rules dropped completely
Must only ignore custom rules if ineligible.
2022-04-13 19:12:16 +02:00
Davide De Rosa 8026caa5ef Attempt beta release 2022-04-13 11:20:21 +02:00
Davide De Rosa 4a047ece58 Fix OpenVPN endpoint view not handling UDP4/TCP4 2022-04-13 11:10:33 +02:00
Davide De Rosa c7f7dd89a1 Attempt beta release
Update script.
2022-04-13 10:16:43 +02:00
Davide De Rosa 56fcee98b4 Handle long fields in OpenVPN configuration
- Use long content for IP settings

- Copy on tap DNS/proxy settings
2022-04-13 10:13:25 +02:00
Davide De Rosa 1532e8808b [ci skip] Address CI and ASC validation issues
- Skip tests until fixed wg-go issue

- Add golang step

- Set "Apple Development" at project level

- Set Catalyst platform for gym

- Drop TARGET env variable clashing with WireGuardKit

- Disable SwiftGen script phase

- Fix TunnelKit segfault on archive

- Xcode 13.2.1 compatibility
    Fix some issues with @MainActor
    Use #available instead of #unavailable

- Raise timeout from 10 to 15 minutes

- Update beta description

- Tunnel bundle ids cannot have periods

- CFBundleDisplayName required in tunnels
2022-04-13 10:00:29 +02:00
Davide De Rosa 926d73fc8a Refine CHANGELOG with issues references 2022-04-12 18:33:27 +02:00
Davide De Rosa 4aba5f46aa Rewrite app in SwiftUI 2022-04-12 15:12:45 +02:00
Davide De Rosa 2c9be6334a [ci skip] Set release date 2022-02-15 09:09:28 +01:00
Davide De Rosa 8f16bf376d Attempt beta release
Fix naive compile issue.
2022-02-04 14:18:01 +01:00
Davide De Rosa e38a2598e2 Attempt beta release 2022-02-04 13:11:01 +01:00
Davide De Rosa 0daed83a14 Update copyright 2022-02-04 12:44:30 +01:00
Davide De Rosa 3c2966c836 Attempt beta release 2022-02-04 12:27:28 +01:00
Davide De Rosa 31361bf0d8 Attempt beta release 2022-02-04 12:19:18 +01:00
Davide De Rosa 2ab709401f Trim whitespaces in text fields 2022-02-04 12:18:44 +01:00
Davide De Rosa 72044a5e41 Fix globbing in "Run Script" phases
See 549cd17dbd
2022-01-07 21:55:56 +01:00
Davide De Rosa 4c673338b7 Attempt beta release 2022-01-07 19:00:33 +01:00
Davide De Rosa d55fb5dc0f Attempt beta release 2022-01-04 09:26:55 +01:00
Davide De Rosa 9ecb90b8f9 Handle --keepalive option 2022-01-04 09:25:13 +01:00
Davide De Rosa ff9dc3f340 Remove URL from CHANGELOG 2021-12-17 14:47:45 +01:00
Davide De Rosa 05a460d55f Attempt beta release 2021-12-08 16:11:38 +01:00
Davide De Rosa 4f9bbac178 Attempt beta release 2021-12-04 11:53:51 +01:00
Davide De Rosa 97c6a6f356 Attempt beta release 2021-12-03 15:35:44 +01:00
Davide De Rosa 2a5c231d3d
Polish release workflow (#207)
* Do run tests in beta

- Test and build app in same lane
- Run tests with swift directly
- Set timeout on build only
- Set GYM_OUTPUT_DIRECTORY inline
- Fix bad build number, broken in db075eb
- Ignore updates to CHANGELOG for testing
- Drop unnecessary exports
- Drop unnecessary test env
- Drop unused PLATFORM .env.* variable

* Work around gym issues in CI

- Set custom build paths for proper clean-up
- Disable xcpretty (seems to hang job)

* Add descriptive names to workflow

- Rename beta to release
- Add job names

* Optimize release workflow

- Use a matrix for multiplatform build
- Only preinstall platform-specific certificates
- Output app version/build early for job reuse
- Do not depend app review on public beta release
- Pull latest commits before pushing/tagging

In release, ci/* scripts require Ruby. Make version an argument
of the commit-release.sh script to fix dependency.

* Import secret to notify external testers or not

* [ci skip] Add CHANGELOG preface in local scripts

* [ci skip] Update links to release via CI
2021-12-03 15:31:19 +01:00
Davide De Rosa 82aaa0b386 Attempt beta release 2021-11-30 16:40:28 +01:00
Davide De Rosa 6d541284a5 Attempt beta release 2021-11-30 12:49:46 +01:00
Davide De Rosa 6d74f06e97 Reload hierarchy on "Refresh infrastructure"
Date was not refreshed either.
2021-11-30 10:51:06 +01:00
Davide De Rosa 9df4630254 Bump version 2021-11-30 10:04:05 +01:00
Davide De Rosa 5580dd6901 [ci skip] Set release date 2021-11-30 10:00:07 +01:00
Davide De Rosa 51821660d2 Commit build number with beta
Pick base build number from env, not project. Can now drop
fetch-depth 0 from workflow, no needs for commits count.
2021-11-29 19:06:59 +01:00
Davide De Rosa b00a7a8ade Set beta release 2021-11-27 12:43:19 +01:00
Davide De Rosa f1009075ab Fix compile error on IntentDispatcher 2021-11-27 12:39:35 +01:00
Davide De Rosa cb3c2401c7 Fix newer infrastructure discarded over bundle 2021-11-27 12:39:35 +01:00
Davide De Rosa b5ca84f54e Set beta release 2021-11-25 13:55:40 +01:00
Davide De Rosa d045406bdb Set beta release 2021-11-25 12:27:27 +01:00
Davide De Rosa d07809a135 Add details on "TLS failed" issue 2021-11-25 12:26:53 +01:00
Davide De Rosa 104c856e45 Fix PEM caching PR in TunnelKit 2021-11-25 12:23:28 +01:00
Davide De Rosa fc4401571b Set beta release 2021-11-24 17:05:20 +01:00
Davide De Rosa 46fef91f5c Revert to TunnelKit with OpenSSL
- Remove extra "Frameworks" in .appex
- Restore TLS security level 0
- Disable Bitcode for OpenSSL to link properly
2021-11-24 17:03:41 +01:00
Davide De Rosa f0020dfba6 Bump version 2021-11-19 17:31:29 +01:00
Davide De Rosa fd529752ee Revert iOS target to 12
TunnelKit only requires 12.
2021-11-18 13:10:44 +01:00
Davide De Rosa f9ab445759 Set beta release 2021-11-18 12:22:02 +01:00
Davide De Rosa 1f0b16f42f Bump version 2021-11-18 12:21:36 +01:00
Davide De Rosa 9338f59f18 Revert PEM caching in TunnelKit 2021-11-18 12:15:21 +01:00
Davide De Rosa 2f1f61e414 Drop removed providers 2021-11-16 13:38:48 +01:00
Davide De Rosa 0754a0f199 Set release date 2021-11-16 12:55:17 +01:00
Davide De Rosa c8f351934c Set beta release 2021-11-14 19:42:14 +01:00
Davide De Rosa b3de7f3a73 Bump build 2021-11-14 19:41:07 +01:00
Davide De Rosa 0b65ed4385 Set beta release 2021-11-12 10:31:13 +01:00
Davide De Rosa 3ccdfc7626 Bump build 2021-11-12 10:30:25 +01:00
Davide De Rosa 1eeb356874 Restrict macOS features in beta
- Providers
- Trusted networks

Skip macOS deployment to TestFlight until beta check is fixed.
2021-11-12 10:22:40 +01:00
Davide De Rosa d45f5bd541 Update CHANGELOG 2021-11-11 15:45:13 +01:00
Davide De Rosa 8833c4dbab Update TunnelKit with BoringSSL
- Optimize package granularity and imports
- Adjust targets to smaller TunnelKit components
- Raise iOS target to 13
- Drop support for TLS security level
2021-11-11 15:45:09 +01:00
Davide De Rosa 7ecbd48e18 Do some project cleanup
- Update bundle
- Merge old CFG_* variables
- Drop useless Metal build settings
- Fix package warning about case
2021-11-11 15:06:43 +01:00
Davide De Rosa 0c448e7f91 Replace status icon with color-agnostic shapes
Fixes #199
2021-11-06 11:18:55 +01:00
Davide De Rosa ae1aa1a268 Reorganize project with SwiftPM
- Drop CocoaPods completely
- Make PassepartoutCore a Swift package
- Enable Bitcode to fix OpenSSL linkage (iOS)
- Update CI scripts without CocoaPods
2021-11-06 11:18:55 +01:00
Davide De Rosa 79c603dffd Drop GitHub Sponsors and reorganize items 2021-10-19 09:46:19 +02:00
Davide De Rosa 06ea7b1886 Set beta release 2021-10-18 12:39:27 +02:00
Davide De Rosa 28b74008ea iOS 15: Restore proper navigation bar appearance 2021-10-17 19:31:13 +02:00
Davide De Rosa 10fd69579b Drop status bar icon color
Loss of information about "Connected"/"Connecting" state, but
this is the only way for the icon to automatically adjust to
desktop background, be it in light or dark mode. Relying on
colors kind of defeats the macOS HIG.

Might consider a different shape for the "Connecting" state.
2021-10-17 13:51:24 +02:00
Davide De Rosa 0ef8dff171 Fix search path for imported host files 2021-10-17 13:15:04 +02:00
Davide De Rosa de2b689436 Drop unused variable 2021-10-17 13:11:20 +02:00
Davide De Rosa ae23114a8f Set beta release 2021-10-16 14:31:48 +02:00
Davide De Rosa 7287fb33c8 Allow Oeck provider without purchase 2021-10-14 19:12:48 +02:00
Davide De Rosa cb87b377bd Set beta release 2021-10-11 20:36:32 +02:00
Davide De Rosa afe5caa064 Set beta release 2021-10-11 19:34:48 +02:00
Davide De Rosa d0f9bd5a4b Set beta release 2021-10-08 10:34:31 +02:00
Davide De Rosa 4928840309 Set beta release 2021-10-08 09:27:56 +02:00
Davide De Rosa f6af9a3fb8 Bump build number 2021-10-05 20:48:26 +02:00
Davide De Rosa a2303c9375 Set beta release 2021-10-05 08:01:35 +02:00
Davide De Rosa 40ab30365a Bump build 2021-10-05 08:01:13 +02:00
Davide De Rosa de829b094e Set beta release 2021-10-04 23:21:05 +02:00
Davide De Rosa 57507255cb Fix macOS categories 2021-10-04 23:08:11 +02:00
Davide De Rosa ca1adb424a Bump base build number 2021-10-01 19:42:45 +02:00
Davide De Rosa b0fff93c89 Update bundle/pods 2021-09-27 18:11:58 +02:00
Davide De Rosa d1a1b555f8 Rename to LocalProduct to avoid StoreKit clash
Started happening with Xcode 13.
2021-09-27 18:01:42 +02:00
Davide De Rosa dd7f144bb3 Move VPN.shared from TunnelKit to Core
Start moving legacy out of inner library.
2021-09-20 20:07:30 +02:00
Davide De Rosa f9e9df0e3b Fix unsorted areas in macOS menu 2021-09-03 12:07:27 +02:00
Davide De Rosa 5cf593ed2b Move strings generation to Core
Also fix missing account guidance on iOS.
2021-08-09 10:06:09 +02:00
Davide De Rosa 39288311e9 Set release date 2021-08-09 09:59:08 +02:00
Davide De Rosa eb1d6f1a60 Set beta release 2021-08-07 23:36:24 +02:00
Davide De Rosa c8a04bb08b Fix CHANGELOG 2021-08-07 23:34:41 +02:00
Davide De Rosa ede43b351f Add in-app donations (Mac) 2021-08-07 23:08:58 +02:00
Davide De Rosa 3e438b2695 Add some Mac tooltips
- Refresh infrastructure
- Favorite/Unfavorite
2021-08-07 14:04:17 +02:00
Davide De Rosa 0ebddc6a68 Drop unused app strings and redo SwiftGen
Prefix is now just L10n without strings filename.
2021-08-07 14:00:35 +02:00
Davide De Rosa c985ed4256 Merge all strings with keys reordered 2021-08-07 13:59:56 +02:00
Davide De Rosa dab7d50610 Distinguish platform-specific strings 2021-08-07 13:59:56 +02:00
Davide De Rosa 23c497968f Merge macOS strings into Core 2021-08-07 13:59:56 +02:00
Davide De Rosa cda9bdcc3f Merge iOS strings into Core 2021-08-07 13:59:51 +02:00
Davide De Rosa 366ff3ebf1 Update SwiftGen files 2021-08-07 12:10:07 +02:00
Davide De Rosa 5b35297a6d Add missing translations 2021-08-07 12:08:36 +02:00
Davide De Rosa f1b20feb68 Set beta release 2021-07-31 15:52:59 +02:00
Davide De Rosa 682bd02f69 Add Oeck logos 2021-07-31 14:57:49 +02:00
Davide De Rosa 31cd5be376 Reuse generic guidance strings
Tell by credentials purpose (web or specific).
2021-07-30 17:58:27 +02:00
Davide De Rosa 52b3d31299 Fix bogus country codes in ProtonVPN 2021-07-30 17:53:51 +02:00
Davide De Rosa f0aa0d0249 Fix endpoints not reloaded on preset change 2021-07-30 17:27:24 +02:00
Davide De Rosa 7142b556f2 Preselect Endpoint tab in customization 2021-07-30 10:52:32 +02:00
Davide De Rosa 77846de9e7 Add Oeck provider 2021-07-30 01:44:01 +02:00
Davide De Rosa 3604ef3dd3 Add favorite locations on macOS 2021-07-29 18:11:43 +02:00
Davide De Rosa 9cec70247a Add toggle button to display favorite state 2021-07-29 16:55:33 +02:00
Davide De Rosa 18da02e5a1 Update SwiftGen 2021-07-29 16:55:33 +02:00
Davide De Rosa 4f95561d0d Reorder XOR field 2021-07-23 18:08:45 +02:00
Davide De Rosa 2ce371c537 Set beta release 2021-07-23 18:04:46 +02:00
Davide De Rosa 1c445a69ff Update CHANGELOG 2021-07-23 18:04:17 +02:00
Davide De Rosa 165555bcad Display XOR mask in configuration screens 2021-07-23 17:35:19 +02:00
Davide De Rosa 43bd72f21f Add SurfShark guidance URL 2021-07-22 11:17:28 +02:00
Davide De Rosa 79c51061fb Fix typo in de 2021-07-21 22:54:10 +02:00
Davide De Rosa 3ab25e49a2 Bump version 2021-07-21 17:38:16 +02:00
Davide De Rosa 834a64fa0f Bump CHANGELOG
Skip broken 1.15.3 (iOS).
2021-07-21 17:37:26 +02:00
Davide De Rosa 22718e5b08 Bump version 2021-07-20 14:01:23 +02:00
Davide De Rosa c0abab5334 Set release date 2021-07-20 10:07:44 +02:00
Davide De Rosa df1acb76db Set beta release 2021-07-20 00:27:34 +02:00
Davide De Rosa 83b6adbf86 Fix crash on in-app purchase
Concurrency issue. Purchase is however credited after app relaunch.
2021-07-20 00:27:18 +02:00
Davide De Rosa 3dd78e22b7 Set beta release 2021-07-16 21:34:30 +02:00
Davide De Rosa 3b5e16b2a1 Add support for --compress stub-v2
Via TunnelKit.
2021-07-16 21:34:30 +02:00
Davide De Rosa 33722b673e Remove legacy purchase footer 2021-06-28 09:17:21 +02:00
Davide De Rosa 3ba1af9540 Set beta release 2021-06-26 11:45:29 +02:00
Davide De Rosa 8736a22763 Add SurfShark provider
Push force manual API.
2021-06-26 10:40:19 +02:00
Davide De Rosa 516f1847c8 Bump version back to minor 2021-06-26 10:06:30 +02:00
Davide De Rosa 7203eea0a2 Comment old code 2021-06-26 09:56:55 +02:00
Davide De Rosa c1f169b239 Upgrade Xcode project and TunnelKit 2021-06-26 09:55:00 +02:00
Davide De Rosa a7bccde045 Download new providers dynamically
Broken on macOS.
2021-06-07 10:05:30 +02:00
Davide De Rosa 08ac926a85 Work around potential crash in debug log 2021-04-28 12:03:29 +02:00
Davide De Rosa 350a2121f4 Bump version 2021-04-17 19:22:02 +02:00
Davide De Rosa 76b799c0aa Set release date 2021-04-17 19:17:55 +02:00
Davide De Rosa d406fdcac0 Set beta release 2021-04-16 16:29:55 +02:00
Davide De Rosa 6487d10cb9 Add missing translations 2021-04-16 16:29:20 +02:00
Davide De Rosa fe084bf42e Ensure prev/next row lies beyond visible 2021-04-14 16:11:10 +02:00
Davide De Rosa 47ff09af11 Downgrade version to patch 2021-04-13 23:22:01 +02:00
Davide De Rosa 35a149435e Share guidance metadata in Core 2021-04-10 23:29:58 +02:00
Davide De Rosa 494f0d0322 Add account guidance message/URL 2021-04-10 15:49:51 +02:00
Davide De Rosa 0d64f15605 Drop Twitch link 2021-04-10 15:15:44 +02:00
Davide De Rosa 25c3732e22 Update CHANGELOG 2021-04-10 15:12:55 +02:00
Davide De Rosa 9150762d76 Resize table to fit debug log 2021-04-10 15:12:55 +02:00
Davide De Rosa 83e3138ddc Make preferences non-modal 2021-04-10 15:07:29 +02:00
Davide De Rosa 830b8d8a60 Add button to copy debug log selection 2021-04-10 14:56:32 +02:00
Davide De Rosa 6e0a46a24c Enable previous/next search in debug log 2021-04-10 09:43:35 +02:00
Davide De Rosa 762e0d2c05 Make debug log a table view 2021-04-10 09:25:11 +02:00
Davide De Rosa 7a61de9ae1 Prevent multiple sheet presentations
https://stackoverflow.com/questions/31754888/presentedviewcontrollers-memory-leak

XXX: weird though.
2021-04-10 09:25:11 +02:00
Davide De Rosa ecc4c6f87e Update VPN toggle if disabling while "Inactive"
Due to trusted network.
2021-04-09 10:07:18 +02:00
Davide De Rosa 7b546ed930 Change icon geometry for Big Sur 2021-03-31 23:11:15 +02:00
Davide De Rosa 57baeff530 Prevent editing of trusted network SSID
Currently possible yet ineffective. Easier than allowing renaming.
2021-03-31 11:20:48 +02:00
Davide De Rosa d2e81f0ff8 Bump version 2021-02-15 18:44:47 +01:00