5dfaec5c29
Fix global position for `InputEventMouse` in `viewport::push_input`
...
Global position doesn't get adjusted within `InputEventMouse::xformed_by()`.
(cherry picked from commit 8de39911c8
2024-03-11 15:01:23 +01:00
9c68648d72
Ensure binds are duplicated with `Node` signals
...
(cherry picked from commit 9cf13cedfd
2024-01-23 17:42:36 +01:00
27d47246b5
Fix ShaderGlobalsOverride property handling
...
(cherry picked from commit 71e32364ee
2023-10-24 19:50:22 +02:00
2d82ab735c
Fix can not set process priority of node if not any process is processing
...
(cherry picked from commit e36117f557
2023-10-24 18:17:01 +02:00
00d5da2f09
Clear the previously set state when configuring for a new scene root node
...
Saving a subscene causes the main scene to be re-instantiated. And the resource
instance in the main scene will be reused when the main scene is re-instantiated.
So for resources with `resource_local_to_scene` enabled, resetting state may be
necessary (at least for `ViewportTexture`).
(cherry picked from commit 4795c3cdfa
2023-10-19 21:49:00 +02:00
aae20e5b10
Fix various typos with codespell
...
Also includes typo fixes from #79993 , #80068 , #80276 , and #80303 .
Co-authored-by: betalars <contact@betalars.de>
Co-authored-by: spaceyjase <429978+spaceyjase@users.noreply.github.com>
Co-authored-by: Swarkin <102416174+Swarkin@users.noreply.github.com>
Co-authored-by: Raul Santos <raulsntos@gmail.com>
(cherry picked from commit faaf27f284
2023-10-03 20:45:35 +02:00
96b8861c9d
Fix crash when hiding subwindow during popup of new subwindow
...
(cherry picked from commit e2cea458a3
2023-09-20 22:44:04 +02:00
f54cbe6b76
Prevent crash when accessing `Node` Multiplayer from thread
...
(cherry picked from commit 7bd3a3a5e5
2023-09-20 22:44:03 +02:00
bf15d20e56
Enable transparent background for GUI tooltips
...
(cherry picked from commit c66dfd2cfe
2023-09-20 22:44:03 +02:00
dbae37cc50
Fix global transform validity for `Node2D` and `Control`
...
Set global transform to invalid when changing transform
(cherry picked from commit 152572ac38
2023-09-20 22:44:03 +02:00
1e2bfdc9bb
Improve error message for `Node.set_owner`
...
(cherry picked from commit 0183340012
2023-07-11 12:21:27 +02:00
42b8ae50d2
Fix `Node::add_sibling` parent check
...
Replace `data.blocked > 0` by `data.parent->data.blocked > 0` in order
to check if the parent is busy.
(cherry picked from commit b02dff6e1c
2023-07-10 17:46:09 +02:00
fa45bb63c6
[Windows] Fix setting initial non-exclusive window mode.
...
(cherry picked from commit db0109b237
2023-07-10 17:46:08 +02:00
4e84660b50
Fix that `_drop_physics_mouseover` only happens when necessary
...
Previously the call was executed every time, because in the
`_drop_mouse_over();` a few lines above, `gui.mouse_over = nullptr;`
was set.
(cherry picked from commit 37a96d3957
2023-07-10 17:26:14 +02:00
16508ead86
Merge pull request #78745 from RandomShaper/fix_node_pr
...
Fix node processing order
2023-06-27 23:02:02 +02:00
70ca659143
Fix node internal/non-internal processing order
...
Bonus:
Fix issues in group-processing related setters
2023-06-27 19:19:55 +02:00
fb1bcac271
Fix that `ViewportTexture` cannot be setup again after failed setup
...
`vp_pending` is a flag indicating to wait for `ViewportTexture::_setup_local_to_scene`
to be called. Once this method is called, no matter whether the setup will fail or not,
it needs to be reset to `false`.
2023-06-27 06:45:30 +08:00
fc0e37bbe0
Fix change of precedence in fixup
2023-06-26 19:20:34 +02:00
6b91f57042
Fixup compilation warning after #78713
2023-06-26 17:55:08 +02:00
a39b683b12
Ensure default node groups' call queue are processed
2023-06-26 16:56:10 +02:00
31fab43b8b
Fix scene load crash related to `_ready`
...
The iterator might get invalidated during `_ready`-user-code.
Prevent this by disallowing set_name during iterator-operations.
2023-06-25 22:35:38 +02:00
afe65de110
Merge pull request #78591 from ajreckof/Fix-crash-when-removing-child-during-focus-exit-
...
Fix crash when removing child during focus exit.
2023-06-23 22:45:51 +02:00
f745299c36
Fix crash when removing child during focus exit.
2023-06-23 21:31:18 +02:00
68193bee9a
Revert "Fix that the focus-out notification got sent deferred"
...
This reverts commit 8cdab04d7fFixes #78589 .
2023-06-23 18:03:48 +02:00
60c261ba2d
Re-add `mouse_focus`-nullcheck
2023-06-22 21:58:19 +02:00
283580d0cc
Merge pull request #78566 from kleonc/repeated-sprite-selection-fix
...
Fix click-selecting Sprites with repeated texture
2023-06-22 18:32:01 +02:00
edba45ec8b
Fix click-selecting Sprites with repeated texture
2023-06-22 16:37:08 +02:00
5ec1b698d2
Fix missing enum value for `Window.initial_position`
...
Reorder the properties in a possibly more intuitive order.
Co-authored-by: Rémi Verschelde <rverschelde@gmail.com>
2023-06-21 22:39:43 +02:00
159f1ec301
Merge pull request #78398 from Sauermann/fix-immediate-focus-out
...
Fix that the focus-out notification got sent deferred
2023-06-20 13:14:10 +02:00
cce100a840
Merge pull request #75459 from kleonc/node-fix-find-children
...
Fix recursive `Node.find_children`
2023-06-19 22:33:46 +02:00
8cdab04d7f
Fix that the focus-out notification got sent deferred
...
Currently the window receives a focus-out notification, directly after
it popup, because currently the signal is sent deferred.
The original intention was that the previously focused window must
receive a focus-out notification.
This change makes the notification more precise by only sending the
focus-out to the previously focused window.
2023-06-18 23:06:07 +02:00
5373b67e2a
Respect returned bool from virtual process methods in SceneTree
...
SceneTree overrides the virtual `process` and `physics_process` methods
that it inherits from MainLoop. These methods return a boolean that
determines if the main loop should end.
The SceneTree was ignoring the returned boolean, so scripts inheriting
from SceneTree that override these methods and return true didn't exit
the main loop. Now the boolean is checked.
2023-06-18 20:45:58 +02:00
f1d8ddd9bd
Remove SceneTree debug avoidance hint
...
Removes SceneTree debug avoidance hint.
2023-06-16 17:18:47 +02:00
2ebe692ccc
Merge pull request #78276 from smix8/remove_old_navdebug_materials_4.x
...
Remove legacy navigation debug materials
2023-06-16 10:20:20 +02:00
014b395ef3
Merge pull request #78262 from bruvzg/ds_window_focus
...
[DisplayServer] Add method to check if native window is focused.
2023-06-16 10:19:33 +02:00
28db3c7158
[DisplayServer] Add method to check if native window is focused.
2023-06-16 10:27:52 +03:00
1b506cd49c
Remove legacy navigation debug materials
...
Removes legacy navigation debug materials.
2023-06-15 16:33:55 +02:00
eb391d3302
Display `BitField[Enum]` in docs to distinguish from `Enum`
2023-06-15 17:23:02 +03:00
c3e5e4ed4b
Merge pull request #68599 from Rindbee/update-edited_scene_root-in-time
...
Update the edit scene root in time after it is replaced
2023-06-12 17:08:50 +02:00
eb74079dfb
Update the edit scene root in time after it is replaced
...
When changing the type of the edited scene root node, it may be necessary
to update edited scene root in time for the child nodes to work properly.
2023-06-12 21:49:30 +08:00
9fca498647
Merge pull request #78110 from Sauermann/fix-nofocus-focus
...
Fix Tooltip getting removed instantly in embedded Window
2023-06-12 11:55:58 +02:00
9d40f99290
Fix Tooltip getting removed instantly in embedded Window
...
Tooltips are unfocusable Windows. This case was not handled correctly in
`Viewport::_sub_window_register`.
2023-06-11 12:22:59 +02:00
0c16082e1e
Use `get_node_or_null` when null checks are present
...
Avoids duplicate or unnecessary errors
2023-06-10 13:22:56 +02:00
dcd2b883eb
Use NULL instead of COND checks when appropriate
...
Restricted to scene
2023-06-10 08:56:30 +02:00
8acf6b41a4
Merge pull request #77209 from Rindbee/ViewportTexture-not-change-RID
...
Don't change `RID` when changing `viewport_path` in `ViewportTexture`
2023-06-09 15:10:39 +02:00
7532b2d259
Don't change `RID` when changing `viewport_path` in `ViewportTexture`
...
When changing `viewport_path`, the `proxy`'s target is changed to a new placeholder.
Add a flag `vp_changed` to prevent calling `setup_local_to_scene` (mainly called by toggling `resource_local_to_scene`) when the target viewport has not changed.
2023-06-09 19:50:26 +08:00
300748e52c
Merge pull request #78044 from RandomShaper/fix_node_prio_ignored
...
Fix node idle process priority being ignored
2023-06-09 13:45:15 +02:00
2a8e83ccad
Merge pull request #78017 from Sauermann/fix-physics-passive-hovering
...
Fix passive mouse hovering for physics
2023-06-09 13:44:05 +02:00
8bbc713ebf
Fix node idle process priority being ignored
2023-06-09 13:05:07 +02:00
543fdc1490
Fix passive mouse hovering for physics
...
Currently mouse hovering doesn't update the state, when collision objects
or the camera move.
This PR fixes this problem by taking the mouse position from the viewport
and not from a nonexistent previous event.
Since previous events could potentially be a long time ago, their
modifier-key state might be outdated. This PR fetches the current
status of modifier-keys from `Input`.
These changes allow the removal of some class-variables and making
additional simplifications.
2023-06-09 12:51:10 +02:00
Markus Sauermann
A Thousand Ships
bitsawer
jsjtxietian
Rindbee
Rémi Verschelde
HolonProduction
Ninni Pipping
kleonc
bruvzg
Rémi Verschelde
Pedro J. Estébanez
ajreckof
jeana helver
Raul Santos
smix8
Danil Alexeev