Commit Graph

572 Commits

Author SHA1 Message Date
Rémi Verschelde 554c0af5d4
Merge pull request #90186 from Maran23/error-when-rename-move
Fix errors when renaming/moving/deleting global scripts
2024-04-06 13:06:32 +02:00
Marius Hanl dda06a8209 Fix errors when renaming/moving/deleting global scripts
When renaming or moving global scripts, the following errors can appear:
- Attempt to open script 'xxx' resulted in error 'File not found'.
- Failed loading resource: xxx. Make sure resources have been imported by opening the project in the editor at least once.
- Parser Error: Class 'xxx' hides a global script class.

When deleting scripts, errors appear when opening the 'Create Node Dialog' as the script cache still contains the removed global scripts. The following errors can appear:
- Attempt to open script 'xxx' resulted in error 'File not found'.
- Failed loading resource: xxx. Make sure resources have been imported by opening the project in the editor at least once.
editor/create_dialog.cpp:241 - Condition "scr.is_null()" is true.

All this errors can be fixed by correctly handling the cases. They involves removing the old path and adding the new one (if not deleted) to the ScriptServer. This is somewhat similar if the file is moved or deleted outside Godot and detected by the file watcher, but more specialized for this particular usecase, since we know the old and the new path / correctly know what the user just did.
2024-04-05 18:52:15 +02:00
AlexOtsuka 0ccc34d351 Fix FileSystemDock behavior when dropping an item in the current folder 2024-04-04 20:19:29 +02:00
Rémi Verschelde 05372773e1
Merge pull request #89599 from timothyqiu/vegetate
Fix unexpected auto translation of editor `Tree` content
2024-03-23 21:15:39 -07:00
Rémi Verschelde 993ce36933
Merge pull request #89658 from AThousandShips/dock_terminal
[Editor] Add `Open in Terminal` to the file system empty click
2024-03-24 01:20:43 +01:00
Rémi Verschelde dd668530e6
Merge pull request #89642 from permelin/fix-favorite-icon
Resource file not found error when loading Favorite icon
2024-03-24 01:20:16 +01:00
Rémi Verschelde 7761c04265
Merge pull request #89546 from YeldhamDev/bad_fsdock,_bad!
Fix FileSystem dock auto translating files
2024-03-24 01:17:41 +01:00
Rémi Verschelde ae8d43b0bb
Merge pull request #88003 from kitbdev/dock-manager-fixes
Refactor and fix issues in Editor Dock Manager
2024-03-24 01:13:26 +01:00
Haoyu Qiu 7984043768 Add necessary flags when opening directory with xfce4-terminal 2024-03-23 20:41:44 +08:00
A Thousand Ships 2cbf469912
Fix sorting of files/dirs in dialogs
Sorts leading `_` before other characters except `.`.
2024-03-20 13:45:47 +01:00
A Thousand Ships fa60e2ddb0
[Editor] Add `Open in Terminal` to the file system empty click
Was missing from clicking in the empty file list
2024-03-19 12:05:05 +01:00
Per Melin ae6410b622 Resource file not found error when loading Favorite icon 2024-03-18 21:39:26 +01:00
Haoyu Qiu 8cd1ebbd6d Fix unexpected auto translation of Tree content 2024-03-18 09:31:00 +08:00
kit 0c9c84f7a6 Refactor and fix issues in Editor Dock Manager
Extract Dock Context Menu.
2024-03-16 13:51:31 -04:00
Michael Alexsander b926e51998
Fix FileSystem dock auto translating files 2024-03-15 23:58:45 -03:00
Rémi Verschelde 5cf38f8f99
Merge pull request #77932 from KoBeWi/custom_resources_to_kill_performance_again_probably
Fix custom resource icons in FileSystem
2024-03-14 22:34:17 +01:00
bruvzg fee14eb5e8
[Import] Add "skip file" import option to skip (and exclude from export) importable formats, auto set it for the images used by bitmap font. 2024-03-12 21:34:40 +02:00
kobewi a62ccf3f1a Fix custom resource icons in FileSystem 2024-03-08 22:31:15 +01:00
Hugo Locurcio 4f8d7cae26
Add Ctrl + L / Cmd + Shift + G shortcut to focus path bar in FileDialog
This also tweaks EditorFileDialog to use the same shortcut,
while making it select the path text after focusing
(like in most file managers).

Ctrl + L / Cmd + Shift + G can also now be used to focus on the
property name in the project settings editor, as well in the
Input Map, Autoload, Shader Globals and Global Groups tabs.
2024-03-05 00:02:09 +01:00
Muller-Castro 1638c1b28f Add const lvalue ref to editor/* container parameters 2024-02-26 15:28:15 -03:00
Haoyu Qiu 9c63a5222d Don't translate filenames in FileSystem dock 2024-02-24 01:00:01 +08:00
kobewi aeec3c1309 Add methods to add submenus without using names 2024-02-22 15:13:53 +01:00
Rémi Verschelde 9e9dcdbba4
Merge pull request #86378 from RobProductions/update-hover-styling
Add hover highlight to main editor buttons
2024-02-20 19:34:40 +01:00
Rémi Verschelde 6037500219
Merge pull request #69032 from KoBeWi/check_every_changed_setting_in_every_group_everywhere()
Use `check_changed_settings_in_group()` everywhere
2024-02-20 19:34:30 +01:00
kobewi bb461986ba Add separate program case for Godot Resources 2024-02-19 22:46:25 +01:00
kobewi a031911c82 Use check_changed_settings_in_group() everywhere 2024-02-19 21:34:45 +01:00
Rémi Verschelde 1bd8fc53fb
Merge pull request #88191 from YeldhamDev/filesys_options_icon_hl
Use highlighted version of the tab icon in the bottom file system dock
2024-02-17 00:23:11 +01:00
Matt Enad 5b5de0e167 Add hover highlight to main editor buttons
Updates styling of the editor run bar, plugin, bottom panel, icon buttons, and main menu buttons for accessibility.
2024-02-16 14:49:44 -05:00
Martin Capitanio 8e8f8e92fb FileSystem dock: Fix open a terminal
The previous implementation of opening a terminal
in the FileSystem dock was causing errors due to the use
of a bash builtin command that does not work outside the shell.

This resulted in the following error messages:

	ERROR: Could not create child process: command
		at: execute (drivers/unix/os_unix.cpp:553)
	ERROR: Could not create child process: command
		at: execute (drivers/unix/os_unix.cpp:553)
	...

To resolve this issue,
+ the command is now executed inside a bash shell,
+ if the `terminal_emulator_flags` editor option is empty,
  the working directory for gnome-terminal and urxvt is now properly set.
2024-02-14 14:29:03 +01:00
Rémi Verschelde 907db8eebc
Merge pull request #87563 from jsjtxietian/fix-filesystem-infinite
Fix editor will freeze when modifying filesystem filter path in Split Mode
2024-02-14 14:08:08 +01:00
Michael Alexsander cc52d7a281
Use highlighted version of the tab icon in the bottom file system dock 2024-02-11 00:09:59 -03:00
kobewi 4ad74a5663 Some editor code cleanup 2024-01-30 21:33:31 +01:00
Juan Linietsky 000367893a Ability to move FileSystem dock to bottom
* Allows moving the filesystem dock to the bottom
* Added ability to drag resources across bottom docks
2024-01-29 15:15:38 +01:00
jsjtxietian 650b9d62e4 Fix editor will freeze when modifying filesystem filter path in Split Mode 2024-01-29 11:04:06 +08:00
Rémi Verschelde 33f3511241
Merge pull request #87293 from YuriSizov/editor-theme-a-rehashed-follow-up
Improve editor theme generation after the refactor
2024-01-18 16:34:50 +01:00
Yuri Sizov d92d8a49aa Merge pull request #86064 from jsjtxietian/fix-sort-by-type
Fix "Class name cannot be empty" error when sorting no import files sort by type
2024-01-17 18:52:35 +01:00
Yuri Sizov 45eedba1fa Improve editor theme generation after the refactor 2024-01-17 15:16:53 +01:00
Yuri Sizov 95b27fe8c7 Reorganize code related to editor theming
This change introduces a new EditorThemeManager class
to abstract theme generatio and its subroutines.

Logic related to EditorTheme, EditorColorMap, and editor
icons has been extracted into their respective files with
includes cleaned up.

All related files have been moved to a separate folder to
better scope them in the project. This includes relevant
generated files as well.
2024-01-16 11:57:45 +01:00
Rémi Verschelde 039379d272
Merge pull request #84193 from kitbdev/dock-manager-extract
Extract `EditorDockManager` from `EditorNode`
2024-01-16 10:35:11 +01:00
kit 2323f040e9 Extract editor dock manager 2024-01-15 15:15:42 -05:00
Rémi Verschelde 85a918d5a2
Merge pull request #87121 from jsjtxietian/fix-thumbnail-disappear
Fix thumbnail disappears if FileSystemDock is floated
2024-01-15 13:30:40 +01:00
jsjtxietian 57751b1917 Fix thumbnail disappears if FileSystemDock is floated 2024-01-13 01:15:37 +08:00
jsjtxietian 5b57db2637 Fix "Class name cannot be empty" error when sorting no import files by type 2024-01-10 10:39:21 +08:00
kobewi 0e8f90f4c8 Update deferred calls to use Callables 2024-01-09 16:11:47 +01:00
Aaron Franke 9753a35c76
Move 3D scene import classes to their own folder 2024-01-04 11:02:49 -06:00
Rémi Verschelde 6c390b620d
Merge pull request #84445 from Rubonnek/add-const-references-clang-tidy
Add const references detected by clang-tidy
2024-01-04 14:25:33 +01:00
Rémi Verschelde 00cc23f906
Merge pull request #86486 from timothyqiu/move-copy-dialog
Improve `EditorDirDialog`
2024-01-03 15:47:52 +01:00
Vedat Gunel f35f1a1849 Store horizontal and vertical split offsets separately in FileSystem dock 2023-12-25 18:11:18 +03:00
Haoyu Qiu a42ead59da Improve EditorDirDialog
* Automatically selects the newly created directory
* Automatically selects "res://" when nothing is selected
* Fixes an error when overwrite/replace dialog appears
* Changes "copy checkbox + action button" to "copy button + move button"
* Double clicking a directory (un)collapses it instead of copy/move
* Uses DirectoryCreateDialog for "Create Folder"
2023-12-25 19:14:04 +08:00
Yuri Sizov 13d34d6a2b Merge pull request #85923 from Calinou/editor-filesystem-dock-add-open-in-terminal
Add a editor FileSystem dock action to open a terminal in selected folder
2023-12-22 17:19:53 +01:00
Hugo Locurcio 0e97acff84
Add a editor FileSystem dock action to open a terminal in selected folder
This is useful to enter some commands without having to open a separate
terminal and `cd` to the project folder.
2023-12-19 15:04:02 +01:00
Wilson E. Alvarez a3cb1b096f
Add const references detected by clang-tidy 2023-12-16 13:36:44 -05:00
kobewi 0ae1241304 Properly select the newly duplicated file 2023-12-14 19:49:11 +01:00
Yuri Sizov 8f33b4e83a Merge pull request #84882 from Invertex/select-instance-asset
Add "Show In FileSystem" to the Scene hierarchy right-click
2023-12-14 17:38:30 +01:00
Yuri Sizov 6faa5c6dc4 Merge pull request #84837 from synalice/issue-83366-colored-folders
Fix folder color not showing up in file dialogs
2023-12-14 17:38:24 +01:00
Invertex 59787683a9 Added "Show In FileSystem" right-click option to Scene hierarchy nodes.
-Implemented shared function for focusing FileSystem tab and highlighting the node path.
-Created right-click option that shows up in the Scene-Hierarchy on Nodes that have a file-system source path.
-Created custom icon for this right-click option
-Implemented the shared function and icon for other places that already had this features (Open Node tab, Inspector Resource)

Co-authored-by: MewPurPur <mew.pur.pur@gmail.com>
2023-12-13 07:43:39 -08:00
Aaron Franke 52f1b86ebc
Fix referring to ResourceImporterScene static importers via instances 2023-12-11 20:01:39 -06:00
Nikita Krasnov 0d6300d269 Fix folder color not showing up in file dialogs 2023-11-14 17:17:10 +03:00
Jordyfel 76c7190d21 Fix errors on file rename or move in the Filesystem Dock 2023-11-10 14:09:21 +02:00
Yuri Sizov 330d22e99a Merge pull request #84217 from SaracenOne/fix_filesystem_rename_crash
Fix file rename crash after toggling split mode.
2023-11-03 12:52:20 +01:00
Saracen 7fea0cef4c Fix file rename crash after toggling split mode. 2023-11-02 21:29:01 +00:00
Saracen c640018b88 Fix crash on rename collision in thumbnail grid 2023-10-30 22:52:12 +00:00
Rémi Verschelde 8919d1c2b5
Merge pull request #82806 from Vilcrow/fix-ensure-selected-visible
Fix checking the visibility condition of selected file in the Godot editor's dock
2023-10-27 11:35:40 +02:00
Rémi Verschelde 80e5484a82
Merge pull request #83941 from Jordyfel/hashset-not-vector
Use Hashset for dependency list when moving
2023-10-26 16:01:21 +02:00
Rémi Verschelde 34b1c0e40b
Merge pull request #83487 from KoBeWi/crash_that_does_not_exist
Prevent crash when creating custom file tooltip
2023-10-26 15:59:19 +02:00
S.V.I. Vilcrow 1ec2272e0b Fix checking the visibility condition of selected file in the Godot editor's dock. 2023-10-25 23:13:18 +03:00
Jordyfel 50b7387a3f Use Hashset for dependency list when moving 2023-10-25 21:05:53 +03:00
Jordyfel 85144f0cd1 Fix potential crash on failed move. 2023-10-25 14:52:34 +03:00
Haoyu Qiu 2413952a4c Fix "as" capitalization in editor strings 2023-10-23 16:10:05 +08:00
风青山 90768f1f7f Fix unexpected behaviors of using Duplicate To on folders
Fix folder not being copied when empty.
Fix Keep Both would generate wrong paths when copying folders.
2023-10-22 06:22:38 +08:00
Rémi Verschelde 060816c3a4
Merge pull request #82858 from KoBeWi/read_between_the_comments
Provide translation strings for folder colors
2023-10-18 00:01:00 +02:00
kobewi ef4c214703 Prevent crash when creating custom file tooltip 2023-10-17 11:39:15 +02:00
Rémi Verschelde 51f81e1c88
Merge pull request #82957 from bruvzg/fs_case_check
Add method to check if filesystem is case sensitive.
2023-10-13 12:55:35 +02:00
Vedat Gunel ecb9ecee54 Fix several issues with renaming in FileSystem dock 2023-10-09 23:18:27 +03:00
bruvzg 97bcd8a631 Add method to check if filesystem is case sensitive. 2023-10-09 11:00:15 +03:00
kobewi 47adf88ed0 Provide translation strings for folder colors 2023-10-05 17:21:48 +02:00
Rémi Verschelde ff9b3dc730
Merge pull request #80241 from gamedevishard/filesystem_dock_hsplit
Horizontal split view for Filesystem Dock
2023-10-03 17:11:53 +02:00
coumcashier 58af0688d3 rename: don't update current path when file list has focus
FileSystemDock: Don't update current path and path edit when the file list has focus.
So that when renaming from the file list, we don't cd into the renamed folder automatically.
2023-10-02 09:33:11 +11:00
风青山 1cb1d7f41d Fix folder moving in FileSystemDock
Include files in the folder that will be moved/renamed when looking up the file owner.

Rename the function/variable names to make more sense in FileSystemDock
2023-09-29 20:32:16 +08:00
Rémi Verschelde da91cf9367
Merge pull request #82347 from SaracenOne/dir_access_checks
Add error checks for DirAccess creation
2023-09-26 16:36:47 +02:00
Saracen 3f4513d4de Add error checks for DirAccess creation. 2023-09-26 03:07:43 +01:00
Devel Oper 81311594b5 Horizontal split view for Filesystem Dock 2023-09-22 11:34:33 +02:00
Dawid Marzec 14f6f97f9c Don't move not selected cursor item dragging files 2023-09-21 13:55:06 +02:00
ajreckof 6afadbaa9f Replace Ctrl in editor shortcuts with Cmd or Ctrl depending on platform 2023-09-19 10:29:07 +02:00
Rémi Verschelde 01d9162a98
Merge pull request #81813 from MewPurPur/fix-paint-icon
Fix grayed out paint icons
2023-09-18 10:38:28 +02:00
MewPurPur c094631ba0 Fix grayed out paint icons 2023-09-17 19:23:28 +03:00
A Thousand Ships 75ee58fd04 [Editor] Replace `ERR_FAIL_COND` with `ERR_FAIL_NULL` where applicable 2023-09-15 20:15:39 +02:00
Jordyfel 6245367e6d Fix dependency handling on move or rename. 2023-09-15 16:46:26 +03:00
Rémi Verschelde e83fc9c03a
Merge pull request #80503 from OXTyler/80379
Fixes Scene corruption when child scene is renamed in another directory
2023-09-12 12:00:49 +02:00
Rémi Verschelde 6c1241dcf6
Merge pull request #81380 from AThousandShips/folder_color_add
Update folder colors when moving or renaming
2023-09-08 23:15:17 +02:00
Rémi Verschelde 119f379a3d
Merge pull request #81075 from SekoiaTree/prevent-leading-dot
Prevent creating any type of file with a leading dot
2023-09-08 09:10:59 +02:00
sekoia bbeb2f98f5 Prevent creating any type of file with a leading dot
Co-authored-by: A Thousand Ships <96648715+AThousandShips@users.noreply.github.com>
Co-authored-by: gotnospirit <gotnospirit@gmail.com>
2023-09-07 22:13:02 +02:00
A Thousand Ships 0f026193b2 Update folder colors when moving or renaming 2023-09-07 17:46:27 +02:00
Rémi Verschelde 8de6405288
UWP: Remove platform port, needs to be redone from scratch for 4.x
The UWP platform port was never ported to the Godot 4.0+ API,
and it's now accumulating bitrot as it doesn't compile, and thus
we no longer propagate platform changes in it.

So we finally remove to acknowledge this state. There's still some
interest in reviving the UWP port eventually, especially as support
for Direct3D 12 will soon be merged, but when that happens it will
be easiest to redo it from scratch.
2023-09-07 15:01:59 +02:00
A Thousand Ships 1589efb350 Remove leftover debug print in `FileSystemDock` 2023-09-07 11:19:18 +02:00
Yuri Sizov 008dc63fe6 Merge pull request #81344 from AThousandShips/folder_color_fix
Fix saving editor folder colors
2023-09-06 14:49:34 +02:00
A Thousand Ships 1083ce4466 Fix saving editor folder colors
Also clears setting if none are assigned
2023-09-05 16:57:15 +02:00
kobewi 6de34fde27 Add EditorStringNames singleton 2023-09-03 19:58:18 +02:00
the-sink 95b0f28255 Add custom color support to project folders 2023-08-29 12:13:53 -07:00
Rémi Verschelde 0655a7d7d3
Merge pull request #80517 from YuriSizov/tsa-randomly-picked-you-for-mandatory-inspection-i-think-not
Avoid unnecessary inspector updates when loading or switching scenes
2023-08-28 12:05:06 +02:00