bb1d75f55e
glTexImage2D: Fix confusion between format and internal format
...
The `format` parameter is similar to `internalFormat` but takes different
values, and especially only `GL_DEPTH_COMPONENT` for depth, without size
specifier.
Cf. https://www.khronos.org/registry/OpenGL-Refpages/es3.0/html/glTexImage2D.xhtml
Fixes a regression from #33278 and another occurrence.
2019-11-23 19:38:31 +01:00
334d41d7cc
Fix Specular Blinn function
2019-11-22 22:03:26 -08:00
203fb1b348
Fix GL error by properly using float uniform
2019-11-21 07:44:09 -08:00
4d6737ec73
Fix bugs introduced by IBL fixes
2019-11-20 22:54:44 -08:00
083d088de3
Merge pull request #33583 from qarmin/fix_overflows_unitialized
...
Fix some overflows and unitialized variables
2019-11-20 21:31:12 +01:00
99d8626f4a
Fix some overflows and unitialized variables
2019-11-20 16:22:16 +01:00
3be6e76f22
Merge pull request #33668 from clayjohn/Fix_environment_mapping_issues
...
Fix issues with environment mapping
2019-11-20 08:45:53 +01:00
cd40154890
Fix issues with environment mapping
2019-11-19 22:30:48 -08:00
7a0228fbba
Merge pull request #33720 from BastiaanOlij/fix_gles2_rgb8
...
Need to use GL_RGB8 and GL_RGBA8 as the internal format for GLES2
2019-11-19 11:12:03 +01:00
15cd81dc69
Need to use GL_RGB8 and GL_RGBA8 as the internal format for GLES2
2019-11-19 20:57:18 +11:00
6536105af2
Merge pull request #33527 from clayjohn/GLES2-bufferdata_optimization
...
Improve glBufferSubData usage where safe
2019-11-19 09:36:30 +01:00
14b06fc207
Fix negative light flickering
2019-11-17 22:18:54 -08:00
1253a33423
Improve glBufferSubData usage where safe
2019-11-11 16:38:41 -08:00
6b1628f9fc
Merge pull request #33517 from madmiraal/fix-_MSG-macros
...
Send *_MSG macros' explanations directly to the _err_print_error().
2019-11-11 13:27:51 +01:00
4b8feff594
Merge pull request #33518 from BastiaanOlij/msaa_ext_modes
...
Add MSAA mode for Quest
2019-11-11 11:46:50 +01:00
4e2343160c
Add special external MSAA modes for GLES2 Rift S/Quest and OpenXR optimisation
2019-11-11 21:02:06 +11:00
d18b2e599d
Remove all uses of ERR_EXPLAIN macros.
2019-11-11 10:24:04 +01:00
90b6062ebb
Handle missing file properly when checking for case mismatch
...
This was causing false alarms to be randomly reported on Windows for files that didn't exist.
2019-11-10 09:51:09 +01:00
add5eaca43
Make MSAA work with external texture
2019-11-08 23:27:48 +11:00
f7cba26a52
Revert "fix #33188 MSAA depth buffer not used for external texture"
...
This reverts commit 418b035dda
2019-11-08 22:47:36 +11:00
a3ac7a94f0
Merge pull request #33291 from NeoSpark314/fix_#33188
...
fix #33188 MSAA depth buffer not used for external texture
2019-11-08 09:53:22 +01:00
47389c3a16
Partial revert of #32657 , undoing line shifting by 0.5
...
As discussed in #32657 , this can't be done here as lines can be used
with a canvas scale, and this breaks them.
A suggestion is to do the pixel shifting at matrix level instead.
Fixes #33393 .
Fixes #33421 .
2019-11-07 15:43:04 +01:00
418b035dda
fix #33188 MSAA depth buffer not used for external texture
...
When rendering to an external texture and MSAA was active (as happened
in the Oculus Mobile ARVR plugin) no MSAA was rendered as the correct
depth buffer and multisample texture target was not used.
This also fixes https://github.com/GodotVR/godot_oculus_mobile/issues/54
2019-11-04 20:14:52 +01:00
c1b0800784
Merge pull request #33278 from clayjohn/GLES2-depth-format
...
Fix depth format on Android in GLES2
2019-11-03 07:56:38 +01:00
bc32779542
Fix depth format on Android in GLES2
2019-11-02 21:58:30 -07:00
d89f24b6c9
Merge pull request #33259 from Chaosus/remove_gles2_switch_op
...
Removed switch operator from GLES2 shader back-end
2019-11-02 19:28:18 +01:00
6b7f8558d9
Removed switch operator from GLES2 shader back-end
2019-11-02 12:43:32 +03:00
9ddb3265e1
Fix some crashes, overflows and using variables without values
2019-11-01 16:16:31 +01:00
033ae8a543
When framebuffer allocation fails for MSAA in GLES2 revert to normal without ERR_FAIL
2019-10-30 07:45:09 -07:00
63c5cd7eb8
Merge pull request #33104 from qarmin/fix_some_crashes
...
Fix some crashes and using null pointers
2019-10-28 08:37:59 +01:00
826ffc26c9
Merge pull request #33097 from clayjohn/GLES2-HTML-sampler_limit
...
Fixed using compressed textures and add work around for firefox webgl mesa sampler limit
2019-10-28 08:19:37 +01:00
e53e1c566a
Fix some crashes and using null pointers
2019-10-28 08:07:29 +01:00
7b3d098b2b
Fixed using compressed textures and add work around for firefox webgl mesa sampler limit
2019-10-27 23:53:52 -07:00
51db564811
use proper texture in Android MSAA
2019-10-27 16:50:15 -07:00
ad685960da
Merge pull request #32617 from Faless/fix/fopen_close_exec
...
Disable file descriptor sharing with subprocs.
2019-10-26 23:11:41 +02:00
3eb8bd08ec
Merge pull request #32657 from ptrojahn/lines
...
Fix draw_rect
2019-10-26 23:09:24 +02:00
3556876c08
Merge pull request #33093 from clayjohn/GLES2-HTML-shadows
...
Fix shadow mapping with RGBA textures on html
2019-10-26 22:07:46 +02:00
6ec7686a0c
Fix shadow mapping with RGBA textures on html
2019-10-26 10:17:22 -07:00
dba22e9788
Merge pull request #33059 from akien-mga/webgl2-resize-non-po2
...
WebGL 2.0: Force decompressing non power-of-2 textures with repeat/mipmap
2019-10-26 18:05:37 +02:00
d780570faf
Use WSAConnect instead of connect on Windows.
...
The misterious windows networking stack...
Using connect instead of WSAConnect causes socket error 10022 under
certain conditions.
See: https://github.com/godotengine/webrtc-native/ (issue 6)
Having to guess, code path for connect is different then WSAConnect with
NULL extra parameters.
The only reference about weird error with this code mentions something
called "Windows Filtering Platform" but windows internals are, as
always, obscure.
This might be something to try and report to Microsoft if anyone has the
time to spare with the likely outcome of being ignored.
2019-10-25 18:13:51 +02:00
69003457b3
WebGL 2.0: Force decompressing non power-of-2 textures with repeat/mipmap
...
While OpenGL ES 3.0 and WebGL 2.0 both support non power-of-2 (NPOT)
textures in their specification, the situation seems to be less clear
about *compressed* NPOT textures using repeat or mipmap flags.
At least Chrome on Linux doesn't seem to support this combination,
and a variety of mobile hardware have similar limitations.
As a workaround, we force decompressing such textures when running on
WebGL 2.0, at the cost of loading time and memory usage.
Fixes #33058 .
2019-10-25 13:01:10 +02:00
7b64340eb0
Fix compilation warnings in macOS build, enable `warnings=extra werror=yes` for macOS CI.
2019-10-24 20:37:56 +03:00
071bf81750
only render depth with alpha prepass on prepass
2019-10-11 22:34:10 -07:00
bdaedb601c
Fix draw_rect
...
OpenGL uses the diamond exit rule to rasterize lines. If we don't shift
the points down and to the right by 0.5, the line can sometimes miss a
pixel when it shouldn't. The final fragment of a line isn't drawn. By
drawing the lines clockwise, we can avoid a missing pixel in the rectangle.
See section 3.4.1 in the OpenGL 1.5 specification.
Fixes #32279
2019-10-11 10:26:53 +02:00
a39aeade5b
Merge pull request #32170 from puthre/ninepatch-fix
...
GLES2 & GLES3 Fixes ninepatch margins for high resolution textures.
2019-10-09 08:33:56 +02:00
02d75f99b9
Merge pull request #32616 from Faless/net/fix_close_exec
...
Disable socket descriptor sharing with subprocs.
2019-10-08 07:32:11 +02:00
e43155b44f
Merge pull request #32454 from jeronimo-schreyer/disable_unix_socket
...
Optional Unix Socket disable for devices that do not support it
2019-10-08 06:40:17 +02:00
100d05cbec
GLES3 Fixes for ninepatch margins when patch size is smaller than the patch texture resolution
...
Scaled ninepatch margins in screen space to be relative of the ninepatch size when the patch size is smaller than the patch texture resolution.
2019-10-07 13:19:27 +01:00
ad9a5ee6f1
Disable file descriptor sharing with subprocs.
...
On Unix systems, file descriptors are usually shared among child
processes.
This means, that if we spawn a subprocess (or we fork) like we do in
the editor any open file descriptor will leak to the new process.
This PR sets the close-on-exec flag when opening a file, which causes
the file descriptor to not be shared with the child process.
2019-10-07 11:57:44 +02:00
9c91b2051a
Disable socket descriptor sharing with subprocs.
...
On Unix systems, sockets are like file descriptors, and file descriptors
are usually shared among child processes.
This means, that if we spawn a subprocess (or we fork) like we do in the
editor, open file descriptors will leak to the new process.
This causes issue with sockets as they might remain open and bound
(listening) when the original process closes.
2019-10-07 11:53:01 +02:00
234289de2b
Merge pull request #32613 from clayjohn/GLES2-canvas-bg-mode
...
Add canvas background mode to GLES2
2019-10-07 08:57:44 +02:00
77939c6e2e
add canvas background mode to GLES2
2019-10-06 23:26:11 -07:00
cea1f13176
fix current issues with post-processing
2019-10-06 12:07:31 -07:00
0deccd4a65
Merge pull request #32510 from clayjohn/GLES2-fix-black-editor-and-crash
...
Remove glViewport call as it wasnt needed and caused crash GLES2
2019-10-03 08:16:19 +02:00
ce336e7e72
Merge pull request #32505 from clayjohn/GLES2-fix-probe-crash
...
Fix reflection probe crash in GLES2 with post-processing
2019-10-03 07:55:08 +02:00
a152816c52
remove glViewport call as it wasnt needed and caused crash
2019-10-02 20:21:41 -07:00
07fd9719bf
Fix reflection probe crash in GLES2 with post-processing
2019-10-02 14:35:10 -07:00
642a258d54
Merge pull request #32492 from akien-mga/fix-ip-uwp
...
IP: Fix build error on UWP
2019-10-02 21:03:59 +02:00
3f32ac11cc
IP: Fix build error on UWP
...
Fixes this error:
```
drivers\unix\ip_unix.cpp(155): error C2593: 'operator =' is ambiguous
.\core/ustring.h(177): note: could be 'void String::operator =(const CharType *)'
.\core/ustring.h(176): note: or 'void String::operator =(const char *)'
drivers\unix\ip_unix.cpp(155): note: while trying to match the argument list '(String, int)'
```
2019-10-02 13:38:02 +02:00
1472fca951
Removed unnecessary shader error log messages
2019-10-02 12:37:22 +03:00
afaa68628a
updated defaults and documentation for GLES2 glow
2019-10-01 07:55:04 -07:00
add91724e6
Fix casting to uint64_t when returning unix system time
2019-10-01 11:44:26 +02:00
fe068b61ad
Optional Unix Socket disable for devices that do not support it
2019-09-30 21:15:50 -03:00
82f63633d1
Implement DOF blur, Glow, and BCS in GLES2
2019-09-30 08:04:31 -07:00
b4c927b514
Added an exit code to the blocking mode of OS::execute
...
Updated documentation accordingly.
Fixes #31881 .
2019-09-26 08:12:07 +02:00
dec10dd776
Merge pull request #32051 from qarmin/some_error_explanation
...
Added some obvious errors explanations
2019-09-25 11:51:54 +02:00
17732fe698
Added some obvious errors explanations
2019-09-25 10:28:50 +02:00
823c3def72
Fix copyright headers and style issues
2019-09-24 11:52:06 +02:00
f1146c261d
Merge pull request #31751 from clayjohn/GLES3-Viewport-crash-canvas
...
Throw error when canvas background is used without sample buffer
2019-09-23 15:35:31 +02:00
159470df08
Merge pull request #32275 from godotengine/skin_support
...
Added skin support and simplified APIs to override bone position + glTF 2.0 import fixes
2019-09-23 15:02:15 +02:00
393a0152ea
Merge pull request #32055 from qarmin/some_code_fixes
...
Changed some code found by Clang Tidy and Coverity
2019-09-23 10:00:31 +02:00
7174677fc8
Merge pull request #32259 from NeoSpark314/fix_stereo_cubemap_gles2
...
fix gles2 broken panorama sky on oculus quest
2019-09-22 21:18:06 +02:00
94b0240767
fix gles2 broken panorama sky on oculus quest
...
This fixes an issue that was fixed for gles3 in #31419 but not applied
to gles2. The fix consists of using a constant scale for cube_normal of -1.0
instead of -1000000. It results in broken panorama rendering on the
oculus quest (see https://github.com/GodotVR/godot_oculus_mobile/issues/29 )
2019-09-22 18:53:38 +02:00
50be65bf43
Changed some code found by Clang Tidy and Coverity
2019-09-22 18:45:08 +02:00
f5365aa0e1
Fix GLES2 skinning where VERTEX_TEXTURE not supported
...
Although the backup USE_SKELETON_SOFTWARE skinning path is currently used when float texture is not supported, the default skinning path still fails when float texture is supported but GL_MAX_VERTEX_TEXTURE_IMAGE_UNITS is 0, i.e. the device cannot read from texture during vertex shader. This PR adds the logic to activate the SKELETON_SOFTWARE path if either of these cases occur, preventing crashes on devices which have this combination of features.
2019-09-22 15:38:20 +01:00
e23cb2c715
Merge pull request #32004 from raphael10241024/fix_shader_uniform
...
Fix gles3 shader uniform vec3 error
2019-09-19 20:09:04 +02:00
28265fb526
Merge pull request #31202 from azagaya/light-data
...
Create shadow_vec for altering shadow computation
2019-09-19 20:03:04 +02:00
d81ddaf33e
Added skin support and simplified APIs to override bone position.
2019-09-18 19:46:32 -03:00
6ee84f53a9
GLES2 Fixes for ninepatch margins when patch size is smaller than the patch texture resolution..
...
Scaled ninepatch margins in screen space to be relative of the ninepatch size when the patch size is smaller than the patch texture resolution.
2019-09-17 09:51:54 +01:00
e65d2184b9
throw error when user tries to use Canvas background without sample buffer
2019-09-15 21:07:07 -07:00
1333ea2a2d
Implement shader array support for varyings
2019-09-14 18:23:25 +03:00
b835868067
Create shadow_vec for altering shadow computation
...
In 2.1 and 3.0, light_vec could be modified for altering shadow_computations.
But it broke shadows when rotating light. shadow_vec would do the same, but without breaking
shadows in rotated lights if not used.
Add inverse light transformation to shadow vec, so it's not affected when rotating lights;
Added usage define for shadow vec.
For shadow vec working properly when rotating a light, it's needed to multiply it by light_matrix normalized. Added usage define in order to don't do that if shadow_vec not used.
2019-09-06 13:55:49 -03:00
b8bb5e90ea
fix gles3 shader uniform vec3 error, close #30930
2019-09-06 14:06:20 +08:00
2beea262be
Merge pull request #31571 from NeoSpark314/tonemapping_none_option
...
Don't clamp color to [0, 1] in Linear tonemapping
2019-09-02 18:41:53 +02:00
cd99157e2e
Provide error messages when PNG save fails
2019-09-01 14:16:17 +03:00
aa3ef8893b
Removed clamping of the Linear tonemapping when KEEP_3D_LINEAR
...
Changed the behaviour of the Linear tonemapping operator to not clamp to [0, 1] range
in the case when KEEP_3D_LINEAR is defined. This allows to render values > 1.0 in
floating point texture targets (via Viewport) for further processing or saving high
dynamic range data into files. This only works when no color conversion is active.
2019-08-29 18:14:19 +02:00
ebbf63a87c
Merge pull request #31746 from clayjohn/skip-vertex-transform-gles2
...
Fix skip_vertex_transform bug in GLES2 CPUParticles
2019-08-29 08:37:12 +02:00
97f66900bb
Fix skip_vertex_transform bug in GLES2 CPUParticles
2019-08-28 11:57:33 -07:00
816ddd7817
Merge pull request #31556 from Chaosus/gles2_inverse
...
Implemented inverse shader function to GLES2
2019-08-26 13:52:03 +02:00
982becfa39
Fix hint range step for integer in shaders
2019-08-25 15:11:04 +03:00
4dda253ee0
Implements switch to shaders
2019-08-23 14:43:09 +03:00
4dcee2035a
Implemented inverse shader function to GLES2
2019-08-22 08:22:49 +03:00
e797ae4704
FileAccessWindows: Add errno include for MinGW
...
Apparently MSVC is happy with ENOENT without it, but MinGW seems to
require it.
Follow-up to #31499 .
2019-08-21 10:52:57 +02:00
7b37321ae3
Merge pull request #31499 from nekomatata/fix-new-project-metadata
...
Setting project metadata doesn't fail when project_metadata.cfg doesn't exist
2019-08-21 08:54:32 +02:00
b49226e085
Support for file not found in ConfigFile::Load and handle a few specific cases
...
EditorSettings::set_project_metadata: creates project_metadata.cfg if it doesn't exist
EditorPlugin::get_config: removed (not used)
Fixes #31444
2019-08-21 08:32:55 +02:00
f21371d7f4
Merge pull request #31419 from NeoSpark314/fix_oculusquest_panorama
...
changed the constant scale of cube_normal to -1.0 instead of -1000000…
2019-08-20 13:39:26 +02:00
cce148b024
Merge pull request #31473 from Chaosus/shader_bug
...
Fix ternary operator shader compiler expression
2019-08-19 10:15:22 +02:00
9abf5578ee
Fix ternary operator shader compiler expression
2019-08-19 08:40:54 +03:00
99de3906ba
check if skeleton texture is already allocated before reallocating
2019-08-18 22:02:57 -07:00
8fb80788df
changed the constant scale of cube_normal to -1.0 instead of -1000000.0; this fixes a rendering issue on oculus quest and does not change the computation as the vector is normalized afterwards.
...
Adapted the comment above the code to reflect the change made as it already mentioned that z could be set to 1.
2019-08-17 14:01:55 +02:00
Rémi Verschelde
clayjohn
Rafał Mikrut
Bastiaan Olij
Marcel Admiraal
PouleyKetchoupp
Holger Dammertz
Yuri Roubinsky
Fabio Alessandrelli
bruvzg
Paul Trojahn
Valentin Zagura
Kanabenki
Jairo
Ruslan Mullayanov
lawnjelly
Juan Linietsky
azagaya
RaphaelHunter
Andrii Doroshenko (Xrayez)