godotengine/godot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
59,712 Commits 15 Branches 59 Tags 2.2 GiB
a731774813
Commit Graph

6682 Commits

Author SHA1 Message Date
Pedro J. Estébanez
a731774813 WorkerThreadPool: Avoid most runtime allocations 
Just a little optimization.

**NOTE:**
With `RID_Owner` we could replace each pair of `PagedAllocator` and
`HashMap`-of-ids-to-pointers. However, that would force us to expose
`RID` as the task/group id, instead of `int`, which would break the
API. Too bad. Let's wait until Godot 5.0.
 2024-01-08 12:46:31 +01:00
Pedro J. Estébanez
ae418f9469 WorkerThreadPool: Avoid deadlocks when CommandQueueMT is involved 
This commit lets CommandQueueMT play nicely with the WorkerThreadPool to avoid
non-progressable situations caused by an interdependence between both. While a
command queue is being flushed, it allows the WTP to release its lock while tasks
are being awaited so they can make progress in case they need in turn to post
to the command queue.
 2024-01-08 12:45:43 +01:00
Pedro J. Estébanez
9444d297ed WorkerThreadPool: Overhaul scheduling and synchronization 
This commits rewrites the sync logic in a way that the
`use_system_threads_for_low_priority_tasks` setting, which was added due to
the lack of a cross-platform wait-for-multiple-objects functionality, can be
removed (it's as if it was effectively hardcoded to `false`).

With the new implementation, we have the best of both worlds: threads don't
have to poll, plus no bespoke threads are used.

In addition, regarding deadlock prevention, since not every possible case of
wait-deadlock could be avoided, this commits removes the current best-effort
avoidance mechanisms and keeps only a simple, pessimistic way of detection.

It turns out that the only current user of deadlock prevention, ResourceLoader,
works fine with it and so every possible situation in resource loading is now
properly handled, with no possibilities of deadlocking. There's a comment in
the code with further details.

Lastly, a potential for load tasks never being awaited/disposed is cleared.
 2024-01-08 12:45:42 +01:00
Yuri Sizov
3a8524dd92
Merge pull request #83452 from RandomShaper/rd_common 
Split `RenderingDevice` into API-agnostic and `RenderingDeviceDriver` parts
 2023-12-20 20:09:18 +01:00
Pedro J. Estébanez
12a519bae2 Split RenderingDevice into API-agnostic and RenderingDeviceDriver parts 
Credit and thanks to @bruzvg for multiple build fixes, update of 3rd-party items and MinGW support.

Co-authored-by: bruvzg <7645683+bruvzg@users.noreply.github.com>
 2023-12-20 19:18:08 +01:00
Yuri Sizov
d2da961f33 Merge pull request #86324 from aaronfranke/really-packed 
Add PackedRealArray as an alias for Vector<real_t>
 2023-12-20 15:08:10 +01:00
Yuri Sizov
6296333bad Merge pull request #60965 from DarkMessiah/global-groups-implementation 
Implement project-wide node groups
 2023-12-20 15:07:20 +01:00
Pedro J. Estébanez
0567c5df9f Make PagedAllocator more compatible (esp., with HashMap) 2023-12-20 12:05:27 +01:00
Yuri Sizov
6fc92e1d05 Merge pull request #84611 from AThousandShips/encode_invalid 
Prevent encoding/decoding objects that cannot be instantiated
 2023-12-19 20:32:42 +01:00
msreis
f1cc14d525 Fix missing time for some script functions in profiler 
Fixes the issue by adding a mechanism by which the functions that were
previously disappearing can be profiled too. This is optional with
an editor setting, since collecting more information naturally slows the engine
further while profiling.

Fixes #23715, #40251, #29049
 2023-12-19 19:42:21 +01:00
Stanislav Labzyuk
958699a0c4 Implement project-wide node groups 2023-12-19 18:07:19 +01:00
Yuri Sizov
d8a65b3f46 Merge pull request #85464 from KoBeWi/only_say_verbose_when_not_verbose 
Improve message about resources in use at exit
 2023-12-19 13:01:59 +01:00
Yuri Sizov
02d4579fa2 Merge pull request #85000 from bruvzg/ed_ui_direction 
[Editor] Add option to override editor UI layout direction.
 2023-12-19 13:01:35 +01:00
A Thousand Ships
c1b8b87736 Prevent encoding/decoding objects that cannot be instantiated 2023-12-18 22:06:08 +01:00
Aaron Franke
3f469ee485
Add PackedRealArray as an alias for Vector<real_t> 2023-12-18 11:37:43 -06:00
Yuri Sizov
639f452098 Merge pull request #86059 from alesliehughes/dynamic_bvh_memmove 
Improve DynamicBVH code to make it clearer how the stack/heap works
 2023-12-18 18:18:13 +01:00
Yuri Sizov
a9a50938c0 Merge pull request #85991 from jsjtxietian/fix-bad-pos-state 
Fix `FileAccessPack::get_buffer` updating position past the length of file
 2023-12-18 18:18:01 +01:00
Yuri Sizov
80c3ed6845 Merge pull request #80487 from theraot/expose_set_global_name 
Expose `Script.get_global_name()`
 2023-12-18 18:17:30 +01:00
Alfonso J. Ramos
e7e35e8366 Expose Script.get_global_name() 2023-12-18 15:13:09 +01:00
Aaron Franke
d48d3ea4eb
Rename VariantZeroAssigner to VariantDefaultInitializer 
And the method zero() is now init()
 2023-12-17 14:00:30 -06:00
Yuri Sizov
df9be54b2f Merge pull request #86177 from KoBeWi/depren_never_forgets 
Fix file disappearing when renaming dependencies
 2023-12-16 17:50:05 +01:00
Yuri Sizov
d02b368fd6 Merge pull request #78095 from aaronfranke/dict-get-or-set-default 
Add a `get_or_add` method to Dictionary
 2023-12-16 17:49:10 +01:00
Yuri Sizov
ca19d34bde Merge pull request #73896 from vnen/object-null-boolean-consistency 
Make freed object different than null in comparison operators
 2023-12-16 17:49:05 +01:00
Pedro J. Estébanez
1a1c06dfeb RBMap: Add explicit copy operators to iterators 
Absence thereof is deprecated and breaks builds on most compilers.

Bonus: Fix parameter naming style throughout.
 2023-12-15 13:14:59 +01:00
Pedro J. Estébanez
fec76d0c22 BitField: allow chained set_flag(), make constructors constexpr 2023-12-15 13:14:59 +01:00
kobewi
397f0b31e4 Fix file disappearing when renaming dependencies 2023-12-14 22:28:48 +01:00
Wilson E. Alvarez
80fb8db31f
Remove unnecessary assignments 
Co-authored-by: A Thousand Ships <96648715+AThousandShips@users.noreply.github.com>
 2023-12-13 11:06:26 -05:00
Rémi Verschelde
45b97ca4e1
Merge pull request #86087 from rburing/fix_gdextension_operator_doc_dump 
Fix operator documentation in GDExtension API dump with docs
 2023-12-13 10:34:00 +01:00
Rémi Verschelde
d3414d80bf
Merge pull request #86081 from KoTeYkA23/bindings-for-emulated-input-events 
Add bindings for setting and getting emulation mouse from touch and touch from mouse in input
 2023-12-13 10:33:36 +01:00
CaTaTo
075a54bbcf Add bindings for setting and getting emulation mouse from touch and touch from mouse in input 2023-12-13 08:07:36 +03:00
Alistair Leslie-Hughes
46531964d0 Improve DynamicBVH code to make it clearer how the stack/heap works. 
Inspired by a Coverity issue about possible memcpy usage and overlapping memory.
 2023-12-13 09:03:19 +11:00
Rémi Verschelde
41365c6c8b
Merge pull request #70315 from RandomShaper/d3d12_mesa 
Direct3D 12 Rendering Driver (Mesa NIR approach)
 2023-12-12 21:58:57 +01:00
Pedro J. Estébanez
2f47c57385 Add Direct3D 12 RenderingDevice implementation 2023-12-12 19:10:04 +01:00
Ricardo Buring
82afe58aca Fix operator documentation in GDExtension API dump with docs 
The type of the right operand is now taken into account.
 2023-12-12 18:55:31 +01:00
Rémi Verschelde
ea15b4ad44
Merge pull request #85159 from KoBeWi/404_strikes_back 
Don't abort loading when `ext_resource` is missing
 2023-12-12 00:18:58 +01:00
Rémi Verschelde
b952b007b1
Merge pull request #84782 from rsburke4/image-fix 
Prevent crash on conversion of invalid data in `Image`
 2023-12-12 00:17:42 +01:00
rsburke4
dec2269bca Added error to catch conversion on invalid image 2023-12-10 15:06:22 -05:00
jsjtxietian
68a6fe81ab Fix FileAccessPack::get_buffer will update pos past the length of file 2023-12-10 16:21:16 +08:00
Yuri Sizov
07677f0f51 Merge pull request #85885 from YuriSizov/bench-pressing 
Improve engine startup/shutdown benchmarks
 2023-12-08 17:12:26 +01:00
Yuri Sizov
f16057522e Merge pull request #85770 from Repiteo/make-virtuals-refactor-and-fix 
Refactor and fix `make_virtuals.py`
 2023-12-08 16:58:44 +01:00
Yuri Sizov
f56765ea47 Merge pull request #84943 from groud/rework_input 
Rework Input action pressed state to support multiple controllers
 2023-12-08 16:58:14 +01:00
Yuri Sizov
b3c20bcf1e Merge pull request #83229 from aaronfranke/basis-is-ortho 
Fix Basis `is_orthogonal` and `is_rotation` methods, add `is_orthonormal`
 2023-12-08 16:58:03 +01:00
Yuri Sizov
2e94be2ea4 Merge pull request #84167 from SaracenOne/cache_mode_replace_fixes 
Fix behavior of ResourceFormatLoader `CACHE_MODE_REPLACE`
 2023-12-08 15:23:13 +01:00
Yuri Sizov
fc3f40f37d Improve engine startup/shutdown benchmarks 
- Add contexts to give a better sense of benchmarked areas.
- Add missing benchmarks and adjust some begin/end points.
- Clean up names.
- Improve Android's internal benchmarks in a similar manner.

Co-authored-by: Fredia Huya-Kouadio <fhuya@meta.com>
 2023-12-08 12:53:04 +01:00
Aaron Franke
7ee273723d
Fix Basis is_orthogonal and is_rotation methods, add is_orthonormal 2023-12-06 13:12:05 -06:00
Aaron Franke
437586bf31
Add a get_or_add method to Dictionary 2023-12-06 11:43:58 -06:00
Rémi Verschelde
d847b6c3b7
Merge pull request #85787 from bruvzg/locale_upd 
Do not reload resources and send notification if locale is not changed.
 2023-12-06 12:36:27 +01:00
Thaddeus Crews
c9a4086da6
Fix EncodeT assignment in make_virtuals.py 
• Adding EncodeT type casting allows generated code to support enum classes.
 2023-12-05 10:37:04 -06:00
Thaddeus Crews
ceb6dadf4e
Refactor make_virtuals.py 
Output reformatted to be comparable to clang-formatted code, without compromising readability
 2023-12-05 10:37:03 -06:00
bruvzg
829349d2ca
Do not reload resources and send notification if locale is not changed. 2023-12-05 16:17:22 +02:00