Commit Graph

2184 Commits

Author SHA1 Message Date
Rémi Verschelde 4c74f50d1a
Merge pull request #30351 from bojidar-bg/30288-override-global-theme
Keep track of default theme and project custom default theme seperatelly
2019-07-25 14:54:27 +02:00
Rémi Verschelde 43238bb59a DirAccess: Drop compat get_next(bool *is_dir) which was hidden
Fixes this warning:
```
./core/os/dir_access.h:74:17: warning: 'virtual String DirAccess::get_next(bool*)' was hidden [-Woverloaded-virtual]
```

Part of #30790.
2019-07-25 11:09:57 +02:00
Rémi Verschelde d844e30614 Inspector: Make default float step configurable
Also allow lifting the decimal step formatting with a hint range step
of 0. A new `range_step_decimals()` is added for this to avoid breaking
compatibility on the general purpose `step_decimals()` (which still
returns 0 for an input step of 0).

Supersedes #25470.
Partial fix for #18251.
2019-07-23 17:31:38 +02:00
Rémi Verschelde d15cf7b672
Merge pull request #30576 from qarmin/lgtm_coverage
Changed some code reported by LGTM and Coverity
2019-07-20 12:00:13 +02:00
qarmin 6cbaf7662f Changed some code showed in LGTM and Coverage 2019-07-20 08:09:57 +02:00
Michael Alexsander Silva Dias d91346f720 Fix incorrect caret position when clicking a 'LineEdit' with a non-left alignment 2019-07-15 19:32:41 -03:00
Emmanuel Barroga 381faf83c3 Fix GraphNode immediately losing focus
Closes: #30243

GraphNode immediately loses focus, and gives focus to its parent.

This fix changes implementation so that it does not transfer focus to its parent after receiving focus. Instead, it will transfer focus when the "close button" is pressed.
2019-07-13 17:25:20 -07:00
Rémi Verschelde 34d7484039
Merge pull request #30455 from qarmin/const_reference
Pass by reference to const
2019-07-10 15:43:15 +02:00
qarmin 01cc7a996b Use reference to constant in functions 2019-07-10 11:54:12 +02:00
Shiqing 94d542042e Fix incorrect X position of line length guideline 2019-07-10 17:29:43 +08:00
Rémi Verschelde 9580c2b13e TreeItem: Rename new button disable method to set_button_disabled
Follow-up to #30408.

Also sync classref with current source.
2019-07-09 09:17:42 +02:00
Rémi Verschelde 2633efd55b
Merge pull request #28190 from griant/test
fix improper uncommenting behavior in TextEditor
2019-07-09 08:56:27 +02:00
Rémi Verschelde 24c462b974
Merge pull request #30443 from Calinou/improve-node-configuration-warnings
Improve the node configuration warning display
2019-07-09 08:31:20 +02:00
Hugo Locurcio ff7184c5cb
Improve the node configuration warning display
- Refer to properties explicitly when possible
- When multiple warnings are returned, always separate them by one
  blank line to make them easier to distinguish
- Improve grammar and formatting
2019-07-09 00:18:00 +02:00
Hugo Locurcio 28d3a6051c
Use base `Color()` constructors instead of `Color::html()`
This results in slightly smaller binaries (-17 KB for an editor binary)
as no strings need to be allocated.
2019-07-08 21:17:10 +02:00
Rémi Verschelde 3bfffcc568
Merge pull request #30408 from Meriipu/tree_buttondisable
TreeItem: Added a setter for the disabled-property of buttons
2019-07-08 08:35:04 +02:00
Rémi Verschelde af80182016
Merge pull request #30407 from qarmin/small_fixess
Fixes minor issues found by static analyzer
2019-07-08 08:16:50 +02:00
qarmin 9a77d748c0 Fixes minor issues found by static analyzer 2019-07-07 23:08:51 +02:00
Meriipu fe9ec58028 TreeItem: Added a setter for the disabled-property of buttons 2019-07-07 16:18:36 +02:00
Rémi Verschelde da1d5d89fd
Merge pull request #30371 from creikey/fix-30366
Give up finding item if started at beginning
2019-07-06 20:33:08 +02:00
Bojidar Marinov e222615e97
Fix editor remaining dimmed after certain actions
Fixes #30368
2019-07-06 17:37:40 +03:00
Cameron Reikes 597e6e1bd9 Give up finding item if started at beginning
When the current item is -1, then the loop will infinitely repeat,
constantly setting i to zero and never exiting.
2019-07-05 22:14:49 -07:00
geequlim 4afb31cd52 Fix light area position in the selected completion 2019-07-06 12:15:32 +08:00
Bojidar Marinov 17901da1a8
Keep track of default theme and project custom default theme seperatelly
Fixes #30288
2019-07-05 23:32:52 +03:00
Geequlim 10cfd87414 Show icons for code completion options 2019-07-05 09:25:50 +08:00
Rémi Verschelde b0ce9401ff
Merge pull request #30126 from qarmin/remove_unnecessary_code
Remove unnecessary code and add some error explanations
2019-07-01 14:32:04 +02:00
Rémi Verschelde 867f38a626
Merge pull request #29572 from qarmin/fix_text_edit_select
Fix TextEdit Select crash
2019-07-01 13:49:06 +02:00
qarmin 3c154eb93b Remove unnecessary code and add some error explanations 2019-07-01 12:59:42 +02:00
Rémi Verschelde b62d315a7f
Merge pull request #30146 from Chaosus/editor_file_dlg_ex
Auto-change file extension in EditorFileDialog when filter changes
2019-07-01 09:24:37 +02:00
Rémi Verschelde 3758981bd4
Merge pull request #30161 from Calinou/add-tooltip-mouse-filter-warning
Add a configuration warning when using Ignore mouse filter with tooltip
2019-07-01 08:47:22 +02:00
Hugo Locurcio a2f8297480
Draw the script editor's line length guideline below characters
This prevents characters from looking strange if they cross the
line length guideline.
2019-06-30 23:47:01 +02:00
Hugo Locurcio a0cc62f000
Add a configuration warning when using Ignore mouse filter with tooltip
This closes #30144.
2019-06-30 19:58:40 +02:00
Rémi Verschelde 82604195b4
Merge pull request #30062 from zaksnet/fix-referencerect-node
Adds ReferenceRect an option to be visible inside the game
2019-06-30 13:41:45 +02:00
Rémi Verschelde 9a999876c3
Merge pull request #30168 from Calinou/label-font-shadow-use-outline
Draw the outline as part of the Label font shadow
2019-06-29 18:43:47 +02:00
Hugo Locurcio fa0e66a88f
Draw the outline as part of the Label font shadow
This closes #30165.
2019-06-28 23:21:55 +02:00
Chaosus eeabb132ec Auto-change file extension in EditorFileDialog when filter changes 2019-06-28 18:35:24 +03:00
Chaosus eb6e260918 Fix some bugs inside ColorPicker 2019-06-28 17:25:00 +03:00
Zak d29b1b7917 Fix ReferenceRect node
ReferenceRect node by default was only displaying in the editor and not when the game is running.
2019-06-28 12:42:42 +03:00
Rémi Verschelde f35fd681ac
Merge pull request #30114 from Chaosus/vs_context_menu
Shows menu when dragging connection on empty space in visual shader
2019-06-27 15:14:54 +02:00
Chaosus 0aec3c3113 Shows menu when dragging connection on empty space in visual shader graph 2019-06-27 10:48:18 +03:00
Rémi Verschelde eaaff9da31
Merge pull request #29941 from qarmin/redundant_code_and_others
Remove redundant code, possible NULL pointers and others
2019-06-27 01:05:18 +02:00
qarmin 4e5310cc60 Some code changed with Clang-Tidy 2019-06-26 15:08:25 +02:00
Rémi Verschelde 18b62d5019
Merge pull request #30053 from guilhermefelipecgs/fix_popup_centered
Fix Popup::popup_centered not centralizing at the first call
2019-06-25 17:46:57 +02:00
Guilherme Felipe 54653565a4 Fix Popup::popup_centered not centering at the first call 2019-06-25 12:04:29 -03:00
Rémi Verschelde 93a67dba37
Merge pull request #30002 from GlaceGwyneth/master
Give LineEdit/TextEdit a custom color for font while uneditable
2019-06-25 13:05:27 +02:00
Rémi Verschelde b966ee49b2
Merge pull request #29979 from flomar/master
Line edit placeholders now react properly to translation changes.
2019-06-25 08:59:31 +02:00
Gwyneth Lowe 45f78d786a Give TextEdit a custom color for font when read only is set
Previously there was some transparency hard coded into TextEdit when in read only mode.
This change adds a custom color for adjusting the font in read only mode.
It also applies when syntax highlighting is on.
2019-06-24 20:00:05 -05:00
Gwyneth Lowe f07e5ac153 Give LineEdit a custom font color when un-editable
By default the LineEdit's text when editable is unchecked had some transparency hardcoded.
This change adds a custom color to LineEdit for adjusting the font when editable is off.
Addresses issue 29814
2019-06-24 20:00:05 -05:00
Florian Marchal 0f2b25f83e Line edit placeholders now react properly to translation changes. 2019-06-24 23:22:20 +02:00
Rémi Verschelde 6fbd045845
Merge pull request #29913 from eligt/fix-editor-help
Ensure indentation works properly in rich text
2019-06-24 22:59:59 +02:00
Rémi Verschelde efa4264633
Merge pull request #30009 from Anutrix/tree-icons-height-fix
Fixed script and visibility icons's highlight height in tree
2019-06-24 18:55:44 +02:00
Gwyneth Lowe 7142064110 Correct typo that broke custom selected font color
Change several font_selected_color to font_color_selected; the actual name of the override
2019-06-24 04:55:29 -05:00
unknown c58b7ab094 Fixed script and visibility icons's highlight height in tree 2019-06-23 22:26:24 +05:30
Dawid Wdowiak 0f14489ecb Center script line when double clicked on error in debugger 2019-06-23 15:58:07 +02:00
qarmin c77ff48a85 Fix some editor crashes 2019-06-21 11:34:32 +02:00
Rémi Verschelde 5c66771e3e
Merge pull request #29283 from qarmin/fix_some_always_same_values
Remove always true/false values
2019-06-20 21:10:10 +02:00
qarmin 532a7ba06a Fix TextEdit Select 2019-06-20 17:13:16 +02:00
qarmin 072e40368e Fix always true/false values 2019-06-20 16:59:48 +02:00
Elia Sarti 81065d53df Fix for #29810
Ensure indentation works properly in rich text
Fix formatting
2019-06-20 11:42:25 +01:00
Rémi Verschelde 300d4dfd54
Merge pull request #25573 from nekomatata/button-shortcut-fix
Fixed shortcut events in BaseButton (now acts the same as ui_accept action)
2019-06-20 12:06:31 +02:00
PouleyKetchoupp 1e6fa5d1a5 Fixed shortcut events in BaseButton (now acts the same as ui_accept action) 2019-06-20 09:13:23 +02:00
Rémi Verschelde 5a29be31b3
Merge pull request #27188 from samH-FIT/MacroUpdate
Made use of semicolons after GDCLASS more consistent, added semicolons where I found them missing.
2019-06-19 22:59:49 +02:00
Rémi Verschelde 02ed4b392c
Merge pull request #29902 from KoBeWi/dem_setters
Fix set_pick_color error
2019-06-19 20:43:15 +02:00
JohnJLight 38d3bfe971 Made use of semicolons more consitent, fixed formatting 2019-06-19 15:24:31 +02:00
Tomasz Chabora 9bdf110840 Fix set_pick_color error 2019-06-19 14:52:54 +02:00
Rémi Verschelde d7af08aa95
Merge pull request #27389 from YeldhamDev/acceptdiag_label_wrap
Add option to enable autowrapping for label inside 'AcceptDialog'
2019-06-19 14:46:32 +02:00
Rémi Verschelde bb0aeb4874
Merge pull request #28659 from KoBeWi/rainbow_mode
Add HSV mode to color picker
2019-06-19 12:41:51 +02:00
Rémi Verschelde d61d1af64d
Merge pull request #29489 from groud/fixes_nan
Fixes NaN errors with anchors mode
2019-06-18 09:53:25 +02:00
Rémi Verschelde 3b3ba7d179
Merge pull request #29847 from yurchor/master
Fix minor typos
2019-06-17 17:28:55 +02:00
Rémi Verschelde 1d93b4abef
Merge pull request #29633 from jbuck3/optionbutton-selection
Connect OptionButton selection to menu's "index_pressed" signal
2019-06-17 16:56:16 +02:00
Yuri Chornoivan 340c2c0584 Fix minor typos 2019-06-17 15:11:49 +03:00
Rémi Verschelde 2935caa13f
Merge pull request #29838 from KoBeWi/4real
Fix selection undo... for real
2019-06-17 11:07:26 +02:00
Tomasz Chabora e5cfb9d6b2 Fix selection undo... for real 2019-06-17 03:54:28 +02:00
Michael Alexsander Silva Dias 98d0c99652 Fix Range's "changed" signal emitting with a value even if binded to emit none 2019-06-16 12:00:49 -03:00
Rémi Verschelde 0a3c21d999
Merge pull request #29785 from eligt/fix-richtext-alignment
Fix RichTextLabel alignment tags not working properly
2019-06-15 10:34:22 +02:00
Rémi Verschelde e999929024
Merge pull request #29787 from Paulb23/fix_negative_cursor_column
Fix TextEdit cursor.column having a negative value
2019-06-15 00:29:07 +02:00
Paulb23 1d55207fd2 Fix TextEdit cursor.column having a negative value 2019-06-14 21:48:16 +01:00
Elia Sarti c4e5ee1fd2 Fix RichTextLabel alignment tags not working properly
Also fixes #6982
Fix error and formatting
2019-06-14 21:38:33 +01:00
Rémi Verschelde 8e04aecb19
Merge pull request #29647 from YeldhamDev/file_dialog_hidden_toggle
Add toggle for hidden file visibility in FileDialog
2019-06-14 22:29:49 +02:00
Rémi Verschelde a745934761
Merge pull request #29731 from akien-mga/scene-is-off-limits
Cleanup some unecessary editor/ includes in scene/
2019-06-12 23:44:24 +02:00
Rémi Verschelde 84d969a42a Cleanup some unecessary editor/ includes in scene/
Part of #29730, handles false positives.
2019-06-12 22:48:43 +02:00
Rémi Verschelde 2cedf7173a BaseButton: Make shortcuts call virtual methods
When buttons are not in Toggle Mode, shortcuts used to only trigger the
`pressed` signal, without calling the `_pressed` virtual method,
contrarily to what happens when you click the button.

For Toggle Mode buttons, it did call the `_toggled` virtual method
together with emitting the `toggled` signal *twice*.

This commit harmonizes it all and makes shortcuts behave the same as
mouse clicks or `ui_accept`, for both toggle and non-toggle modes.

Fixes #29604.
2019-06-12 16:35:49 +02:00
Rémi Verschelde df25679235
Merge pull request #29601 from NilsIrl/hiding_enabled
Treat hiding_enabled as bool throughout
2019-06-12 14:23:27 +02:00
Rémi Verschelde 434a1fddf3
Merge pull request #29648 from jbuck3/tree-tooltips
Fix Tree button tooltips
2019-06-12 13:29:36 +02:00
Rémi Verschelde 971b5160c6
Merge pull request #29306 from qarmin/small_code_fixes
Small fixes to unrechable code, possibly overflows, using NULL pointers
2019-06-12 12:49:21 +02:00
Rémi Verschelde 4043c8a8c9
Merge pull request #29678 from akien-mga/err-macros-semicolon
Fix error macro calls not ending with semicolon
2019-06-11 19:01:26 +02:00
Rémi Verschelde 15425b450f
Merge pull request #29573 from qarmin/fix_rich_text_process_line
Fix RichLabelText::_process_line crash
2019-06-11 16:00:03 +02:00
Rémi Verschelde 6d16f2f053 Fix error macro calls not ending with semicolon
It's not necessary, but the vast majority of calls of error macros
do have an ending semicolon, so it's best to be consistent.
Most WARN_DEPRECATED calls did *not* have a semicolon, but there's
no reason for them to be treated differently.
2019-06-11 14:49:34 +02:00
Rémi Verschelde d8877d2df5
Merge pull request #29539 from qarmin/fix_crash_with_get_keywords_color
Fix crash with get_keywords_color
2019-06-11 14:19:18 +02:00
bruvzg 63d8dc0920
Fix third and fourth level (AltGr / ⌥ modifier) keys input in LineEdit. 2019-06-11 08:10:07 +03:00
James Buck 215fed1fb3 Fix Tree button tooltips
Fixes #22777
2019-06-09 22:33:47 -05:00
Michael Alexsander Silva Dias be6d48fcad Add toggle for hidden file visibility in FileDialog 2019-06-10 00:20:24 -03:00
James Buck 17e1be6478 Connect OptionButton selection to menu's "index_pressed" signal
Simplifies code and fixes bug where only the first item with a given
ID could be selected.
2019-06-09 14:44:36 -05:00
Nils ANDRÉ-CHANG e4f90337f2 Treat hiding_enabled as bool throughout 2019-06-08 12:37:57 +01:00
qarmin 685451967c Fix RichLabelText::_process_line crash 2019-06-07 12:36:11 +02:00
qarmin 8d993f6357 Fix crash with get_keywords_color 2019-06-06 12:59:29 +02:00
Rémi Verschelde 46c56cad0c
Merge pull request #29469 from bojidar-bg/29446-graphnode-seperation
Fix GraphNode not adding separation after the first node
2019-06-04 22:37:55 +02:00
Gilles Roudière df0a69bbac Fixes NaN errors with anchors mode 2019-06-04 21:58:21 +02:00
Bojidar Marinov 8a1a067b91
Fix GraphNode not adding seperation after the first node
Fixes #29446
2019-06-04 16:05:23 +03:00
Tomasz Chabora 2f75471f24 Fix crash when searching Tree with no selection 2019-06-04 01:50:50 +02:00