4dda62f591
Fix spelling & grammar in comments, docs, and messages
2020-07-21 15:17:23 -04:00
166103c759
Android: Keyboard modifier and arrow key support
2020-07-21 22:13:24 +03:00
103b46733a
Merge pull request #40533 from zaevi/fix_clipboard_crlf
...
fix crlf for clipboard
2020-07-21 16:06:43 +02:00
f6b6d51052
Merge pull request #40562 from nekomatata/osxcross-vulkan-layer
...
Fix Vulkan layer creation when compiling with OSXCross
2020-07-21 12:57:52 +02:00
08b0fd4330
Set minimum osx version to 10.12 for OSXCross compilation
...
Fixes this compilation error:
In file included from thirdparty/vulkan/vk_mem_alloc.cpp:7:
thirdparty/vulkan/vk_mem_alloc.h:3691:18: error: 'shared_mutex' is unavailable: introduced in macOS 10.12
std::shared_mutex m_Mutex;
^
/home/[user]/sources/osxcross/target/bin/../SDK/MacOSX10.14.sdk/usr/include/c++/v1/shared_mutex:178:58: note: 'shared_mutex' has been explicitly marked unavailable here
class _LIBCPP_TYPE_VIS _LIBCPP_AVAILABILITY_SHARED_MUTEX shared_mutex
2020-07-21 12:37:56 +02:00
ce34b77c4a
Fix MoltenVK layer creation when compiling with OSXCross
2020-07-21 12:37:20 +02:00
b7aa474680
Merge pull request #40422 from amanj120/forward_port_bundle_pr_resources
...
Create strings.xml files in the Gradle project to handle localization
2020-07-20 22:26:44 +02:00
0107550cf1
fix crlf for clipboard
2020-07-20 23:07:20 +08:00
d7aaec8ffe
Disable virtual keyboard focus adjustment on Android
...
Fixes #37190
The default adjustment setting was causing the view to pan down in order
to adjust the focus on the text content.
We don't need any focus adjustment since we're using a fixed size window
for our application.
Documentation:
https://developer.android.com/reference/android/view/WindowManager.LayoutParams#SOFT_INPUT_ADJUST_NOTHING
2020-07-20 12:04:02 +02:00
5ff6f7a86b
Create strings.xml files in the gradle project to handle localization
2020-07-15 13:02:59 -04:00
c8523038cc
Merge pull request #40268 from DanielZTing/master
...
Fix cancel/OK button order on macOS
2020-07-15 09:21:04 +02:00
4dc94e93bb
Android: fix display server always alerting no Vulkan support
2020-07-14 19:37:36 +03:00
850bbabe56
[macOS] Fix window size on macOS Big Sur (title bar height is no longer same as menu height), use top-left corner as resize origin instead of bottom-left.
2020-07-14 15:09:46 +03:00
28e8347d6c
Merge pull request #40354 from bruvzg/add_vulkan_init_message
...
Display error popup instead of crashing if Vulkan init failed.
2020-07-14 09:03:25 +02:00
9986439352
Commit other files changed by file_format.sh
2020-07-13 14:14:11 -04:00
996910b627
Add error messages if Vulkan init failed, prevent Vulkan context freeing uninitialized device and instance.
2020-07-13 19:24:21 +03:00
9605fc54c7
Fix cancel/OK button order on macOS
...
The macOS platform convention regarding button order is cancel on left,
OK on right.
2020-07-10 15:10:11 -05:00
26fcf2b04c
Add override keywords.
2020-07-10 13:56:54 +01:00
dc856481ff
Merge pull request #40244 from amanj120/forward_port_bundle_pr_permissions
...
Refactor permissions and command line flags into separate methods
2020-07-10 13:19:37 +02:00
f67b65864f
Merge pull request #40167 from amanj120/forward_port_bundle_pr_saving_files
...
Utility methods for writing files to gradle project directory
2020-07-10 11:02:03 +02:00
f579057748
Refactor permissions and command line flags into separate methods
2020-07-09 16:34:08 -04:00
78e003951a
Utility methods for writing files to Gradle project.
2020-07-09 13:57:15 -04:00
bcc3c72d9c
[macOS] Fix transient windows.
2020-07-09 14:22:56 +03:00
d629b17291
Merge pull request #40215 from naithar/feature/ios-storyboard-usage-master
...
[4.0] [iOS] Option to use storyboards for launch screens
2020-07-09 08:36:01 +02:00
96e204bb0d
iOS Export: Storyboard custom values
2020-07-07 02:00:08 +03:00
d4c541c25a
iOS Export: add option to use storyboard for launch screen
2020-07-07 01:46:26 +03:00
7b64f2df50
iOS Export: use relative path for res:// files
2020-07-06 00:56:29 +03:00
c2a0bfa95b
Merge pull request #40111 from DanielZTing/master
...
Fix opening URLS with special characters in macOS
2020-07-05 00:51:13 +02:00
8ccb1cec91
Merge pull request #40084 from bruvzg/macos_seamless_scaling
...
[macOS] Implement seamless display scaling.
2020-07-04 10:51:09 +02:00
9828fcc01a
Merge pull request #40105 from Logharaa/master
...
Stop looping as soon as the first window that has focus is found
2020-07-04 09:57:14 +02:00
df968d577a
[macOS] Implement seamless display scaling.
2020-07-04 10:36:33 +03:00
b8e6ff9a7f
Fix opening URLS with special characters in macOS
...
The Online Tutorials section of InputMap in the editor's built-in
documentation viewer contains this link:
docs.godotengine.org/en/latest/tutorials/inputs/inputevent.html#inputmap
The macOS implementation for opening a link percent-encodes it before
sending it to the browser, resulting in a 404. This is to fix #13422
where filenames with special characters could not be opened in Finder.
However, this breaks URLS so I added a check to see if the resource
scheme is file:// and if so, only then is it escaped. This allows other
schemes like `http`, `ftp`, and `mailto` to be used.
2020-07-03 23:00:48 -05:00
6c76639c40
Break loop when the first focused window is found
2020-07-04 01:57:16 +02:00
73fddc623b
Merge pull request #39888 from nekomatata/windows-create-window-error
...
Fix errors when creating windows on Windows
2020-07-04 01:41:43 +02:00
c020eea184
Merge pull request #40092 from hinlopen/remove-find-last
...
Remove String::find_last (same as rfind)
2020-07-04 01:38:01 +02:00
14263d3d0d
Improve the situation of DND on X11
2020-07-03 12:09:22 -03:00
929b98d24b
Remove String::find_last (same as rfind)
2020-07-03 15:26:22 +02:00
aa564739dd
Merge pull request #40074 from reduz/fix-fullscreen
...
Fix fullscreen flag on Windows, closes #37588
2020-07-03 09:23:44 +02:00
64aa25b2e5
Merge pull request #40050 from naithar/feature/ios-gdnative-master-2
...
[4.0] Add support of iOS's dynamic libraries to GDNative
2020-07-03 07:48:13 +02:00
b14be5f271
Fix fullscreen flag on Windows, closes #37588
2020-07-02 22:09:17 -03:00
a9e341cff3
[macOS] Implement confined mouse mode.
2020-07-02 17:34:58 +03:00
864224a5c1
iOS Export: Updated Info.plist. Framework embedding. Fixes for search paths
2020-07-02 12:56:11 +03:00
eef732342b
iOS Export: turn .dylib into .framework on export
2020-07-02 12:56:05 +03:00
3fb5faaceb
Merge pull request #40018 from Faless/js/more_improvements_4.0
...
HTML5 fixes, refactor, audio fallback, fixed FPS.
2020-07-02 07:22:43 +02:00
0b7bc83fe3
Add a focus out timeout for X11 to less events of this type are received
2020-07-01 16:14:46 -03:00
7a5e10b8a9
Use dummy driver when JS AudioContext is unavailable.
2020-07-01 17:16:13 +02:00
1a637b07b1
Limit FPS in JS by skipping iterations.
2020-07-01 17:16:13 +02:00
07d4513886
[JS] Check canvas size each loop, force redraw.
...
Fix compatibility issues, achieve smoother resizing.
2020-07-01 17:16:13 +02:00
a1c4c1d318
More static methods in DisplayServerJavaScript.
...
Were static functions in cpp file, polluting global namespace.
2020-07-01 17:16:03 +02:00
5c9ee93f3e
Merge pull request #39788 from bruvzg/macos_apple_silicon
...
[macOS] Add support for the Apple Silicon (ARM64) build target.
2020-07-01 16:45:23 +02:00
9000e59650
Merge pull request #40016 from akien-mga/environment-code-cleanup
...
Environment: Refactor code for readability + more
2020-07-01 16:28:48 +02:00
372136fe75
Environment: Refactor code for readability + more
...
- Makes all boolean setters/getters consistent.
- Fixes bug where `glow_hdr_bleed_scale` was not used.
- Split CameraEffects to their own source file.
- Reorder all Environment method and properties declarations,
definitions and bindings to be consistent with each other
and with the order of property bindings.
- Bind missing enum values added with SDFGI.
- Remove unused SDFGI enhance_ssr boolean.
- Sync doc changes after SDFGI merge and other misc changes.
2020-07-01 14:44:45 +02:00
239942cfef
Ensure embedded mode works again
...
Also implemented application in/out notifications in X11.
2020-07-01 09:27:43 -03:00
fd92270b0a
Refactor canvas ID and locale handling.
2020-07-01 13:10:05 +02:00
5b1cc2d1fc
Fix FS error on JS startup due to existing folder.
2020-07-01 13:10:05 +02:00
a07578592b
[macOS] Add application become/resign active notifications.
2020-06-30 17:59:30 +03:00
438c380458
Add a separate application focus/in notification out from Window focus notification.
2020-06-30 10:40:06 -03:00
accae11fe3
[macOS export] Set correct external file attributes (Unix mode), and creation time.
2020-06-30 10:16:02 +03:00
524f061c01
X11: Ensure XGetWindowProperty data gets freed
...
And cleanup includes a bit.
2020-06-29 13:32:21 +02:00
00299f15b4
[macOS] Add support for the Apple Silicon (ARM64) build target.
2020-06-29 12:33:51 +03:00
2d53b8173e
Fix the logic to enable focus awareness
2020-06-27 16:43:08 -07:00
1043576ff3
Fix errors when creating windows on Windows
...
Detecting the case where WM_SIZE is received during the window creation.
There's no need to call window_resize on the Vulkan context.
Also creating a WindowData entry early enough to avoid storing a
separate WindowData wrongly associated to INVALID_WINDOW_ID.
Fixes #39199
2020-06-27 18:26:34 +02:00
175d43738a
Enable the ability to use Godot as a subview within an Android app
2020-06-25 19:52:40 -07:00
8f5005b3eb
Merge pull request #39779 from naithar/feature/ios-modules-master
...
Enable iOS modules and fix missing symbols errors (4.0)
2020-06-24 22:49:39 +02:00
4c0b077faa
Updated purchase receipt suitable for sending to apple verification server
...
(cherry picked from commit bd71925726
2020-06-24 17:15:56 +02:00
488879f52b
Export: Fix iOS enabling push notifications capability
2020-06-23 12:48:44 +03:00
090b9fec20
SCons: Enable modules for iOS
2020-06-23 12:48:44 +03:00
206cbd960b
Follow up cleanup for the godotpayment project module
2020-06-22 12:53:25 -07:00
d808697760
Merge pull request #39751 from bruvzg/mingw_build_fix
...
Fix MinGW build (use uninitialized `ofs` variable introduced in 39701).
2020-06-22 13:07:14 +02:00
439c97e0ff
Fix use uninitialized `ofs` variable introduced in 39701.
2020-06-22 13:13:22 +03:00
fc1d1c3557
[Windows] Prevent overwriting old cursor handle on multiple mouse_mode changes, ensure mouse_mode is set before `cursor_set_shape` is called to restore cursor.
2020-06-22 13:05:18 +03:00
6869d5d190
Merge pull request #39745 from timoschwarzer/remove-godot-payment-plugin-4
...
Remove GodotPayment android plugin
2020-06-22 12:01:27 +02:00
7a250b579f
macOS, prevent multiple CGDisplayHideCursor calls unpaired with CGDisplayShowCursor.
2020-06-22 11:38:43 +03:00
83a966f0d8
Remove GodotPayment android plugin
...
This is now available in a separate repository
at https://github.com/godotengine/godot-google-play-billing
2020-06-22 09:21:05 +02:00
efcc508ee5
Move Haiku platform port to external repository
...
The Haiku port now resides at:
https://github.com/godotengine/godot-haiku-platform
While we're happy to support as many Free and Open Source platforms as we can,
we need to put the main focus on the platforms that we can reasonably maintain,
and for Haiku we have been lacking maintainers ever since the port was first
merged in 2015.
The Haiku code has not been compiling and much less working at least since the
release of Godot 3.0, and while some attempts have been made at fixing things,
it's still not functional today in the `3.2` branch (and much less in `master`,
understandably).
Having it in an external repository should hopefully enable Haiku contributors
to fix issues in their own time, and possibly tag versions compatible with
past Godot releases once they are ready.
2020-06-20 17:59:41 +02:00
ea30d12204
Merge pull request #39701 from BastiaanOlij/fix_joystick_sliders
...
Fix missing slider joystick handling on Windows
2020-06-20 11:54:39 +02:00
79b77f8357
Merge pull request #39700 from nekomatata/osx-export-zip-fix
...
Set proper file type attribute for OSX zip export
2020-06-20 11:09:56 +02:00
aa01b327d6
Fix missing slider joystick handling on Windows
2020-06-20 19:03:15 +10:00
4501771fd8
Set proper file type attribute for OSX zip export
...
The missing file type in file attributes was causing the file to lose
executable permissions when unzipped with some softwares.
2020-06-20 10:04:18 +02:00
35414f1dec
Merge pull request #39053 from timoschwarzer/static-assert-variant-arg-max
...
Add static_assert checks where code assumes VARIANT_ARG_MAX == 5
2020-06-19 23:51:22 +02:00
3e07080942
Merge pull request #39427 from hcmlax/shortcut_issue_39351
...
fixed issue where shortcut doesn't work if alt is pressed before shift
2020-06-19 23:47:49 +02:00
08ef0aab16
Export: Rename 'Windows Universal' to 'UWP'
...
It's otherwise too easy to be confused between 'Windows Desktop' (Win32)
and 'Windows Universal' (UWP).
2020-06-19 16:31:28 +02:00
fdb89a3f9a
Rename "Identifier" to "Bundle Identifier" in macOS/iOS export presets
...
"Bundle Identifier" is more well-understood among macOS and iOS
developers and is less ambiguous.
This is a slight breaking change as export presets will need to be
updated to account for this change.
See https://github.com/godotengine/godot-docs/pull/3295 .
2020-06-19 09:59:38 +02:00
d191a8b9f8
adding check for syskeydown on control and alt
2020-06-18 14:36:22 -07:00
fa01e666d2
Merge pull request #39542 from Ev1lbl0w/feature/kill-pid
...
Allow Godot to kill its own PID
2020-06-16 20:49:00 +02:00
60ba9914f3
Merge pull request #39579 from m4gr3d/provide_activity_to_godot_plugin_constructor_master
...
Clean up the GodotPlugin public API
2020-06-16 20:45:34 +02:00
6daf9b78af
Clean up the `GodotPlugin` public API.
2020-06-16 09:25:09 -07:00
4b5b60de85
Merge pull request #39189 from touilleMan/issue-38925
...
Unify OS.get_system_time_* and OS.get_unix_time
2020-06-15 23:57:16 +02:00
d3c10e8dd6
Merge pull request #39457 from bruvzg/kbd_layouts
...
Add keyboard layout enumeration / set / get functions.
2020-06-15 11:10:34 +02:00
2db9c13798
Merge pull request #39436 from bruvzg/macos_export_notarization
...
[macOS export] Add notarization support.
2020-06-15 11:04:47 +02:00
6fa2a5ac14
Merge pull request #39537 from Faless/js/fs_sync_iteration
...
Immediately run first iteration after JS FS sync.
2020-06-14 22:57:32 +02:00
5c75cb0133
Immediately run first iteration after JS FS sync.
...
Which is now run inside an animation frame.
This avoid a 1 frame black screen when setting up the canvas.
2020-06-14 16:04:45 +02:00
92352b1c23
Add keyboard layout enumeration / set / get functions (macOS, Windows, Linux/X11), remove latin variant function.
2020-06-13 11:02:00 +03:00
068054002d
Simplify some code in platform/uwp/export
2020-06-11 17:19:45 -04:00
c4dd866a15
Merge pull request #38958 from lawnjelly/time_overflow_4
...
Fix overflow condition with QueryPerformanceCounter
2020-06-11 09:38:44 +02:00
f5c856ea40
macOS export, add notarization support and id / signing / notarization config check.
2020-06-10 15:58:30 +03:00
f54eda121d
Merge pull request #39304 from m4gr3d/enable_focus_awareness
...
Add support for focus awareness
2020-06-05 12:42:21 +02:00
2bf1f8e4b3
Add support for focus awareness
2020-06-04 15:49:55 -07:00
0a35b97b62
Swtich HTML5 key detection from keyCode to code.
...
The value of this, does not include the layout.
The code has extra logic to map the unicode value to our keylist,
supporting ASCII and Latin-1.
Also add support for `physical_keycode` in HTML5 platform.
2020-06-04 21:15:05 +02:00
21263a65a9
Check if the specified Android release keystore exists
2020-06-04 13:37:14 +02:00
c47a6f6325
Merge pull request #39060 from madmiraal/fix-38869
...
Update Windows GUID to SDL uid conversion.
2020-06-04 11:40:57 +02:00
be22a1f9bc
Fix inconsistent error messages with Android custom export templates
2020-06-01 23:13:31 +02:00
c6de3872f9
Remove OS.get_system_time_secs/get_system_time_msecs and change OS.get_unix_time return type to double
2020-05-31 14:19:31 +02:00
d04cbbd76b
Update OSX GUID to SDL uid conversion.
...
Co-authored-by: John Wakley <johncwakley@users.noreply.github.com>
2020-05-30 17:38:39 +01:00
bc49d34123
Add dinput nullptr checks.
2020-05-30 13:59:30 +01:00
97a529b1d8
Do not probe joypads if DirectInput cannot be initialized.
2020-05-29 12:07:07 +01:00
c227733bd8
Add missing consumePurchase plugin method for GodotPayment
2020-05-28 22:48:48 +09:00
fe09b4d2b3
Tweak the DirectInput initialization failure message
...
This closes #36662 .
2020-05-28 09:45:17 +02:00
c948d25b6e
Validate that `Use Custom Build` is enabled when `Plugins` are selected
...
Remove `GodotPayment` from the default build template
2020-05-27 12:07:53 -07:00
7b7b872d94
Merge pull request #39080 from m4gr3d/fix_emit_signal
...
Use compile-time constant for the size of the signal parameters
2020-05-27 13:05:32 +02:00
63286ebba4
Use compile-time constant for the size of the signal parameters
2020-05-27 03:40:26 -07:00
75100e5644
Provide the ability for clients of the Godot library to add their own command line arguments
2020-05-27 02:13:52 -07:00
ef1a305e50
Ignore invalid tablet driver name, when non are available.
2020-05-26 21:03:45 +03:00
24ad4894cc
Merge pull request #39050 from timoschwarzer/google-play-billing-4.0
...
(4.0) Re-implement GodotPayment Android plugin using the Google Play Billing library
2020-05-26 15:34:06 +02:00
a833db80d9
Update Windows GUID to SDL uid conversion.
2020-05-26 12:46:42 +01:00
4b00bf8e83
Re-implement GodotPayment Android plugin using the Google Play Billing library
2020-05-25 22:24:17 +02:00
242b715144
Merge pull request #38996 from mbrlabs/android-plugin-fix
...
Perform a clean Gradle build if android plugins changed
2020-05-25 22:18:41 +02:00
072646f5dd
Merge pull request #39047 from m4gr3d/fix_emit_signal
...
Fix parameters passing when emitting signal
2020-05-25 22:13:49 +02:00
05b32fc01d
Add static_assert checks where code assumes VARIANT_ARG_MAX == 5
2020-05-25 21:55:03 +02:00
bf76d2afcf
Stop ignoring hidden files and directories in the `assets` directory
2020-05-25 12:03:35 -07:00
e7e736c03b
Fix parameters passing when emitting signal
...
The issue was caused because we were using variables local to the `for` loop block.
2020-05-25 11:50:36 -07:00
abd66c1bb0
Perform a clean Gradle build if android plugins changed
...
Fixes #38986
2020-05-25 19:18:02 +02:00
57bdb4cc35
Fix JS audioContext parameters.
...
Were not passed along correctly.
`latencyHint` is supposed to be in seconds, not milliseconds.
2020-05-25 15:33:19 +02:00
3ecdc27f49
Merge pull request #39004 from nekomatata/android-reset-surface
...
Proper surface reset when resuming app on Android
2020-05-24 22:31:03 +02:00
926d6c1082
Merge pull request #39007 from nekomatata/android-object-id-long
...
Use long instead of int for object id in Android java wrapper
2020-05-24 22:30:00 +02:00
b987677cc0
Proper surface reset when resuming app on Android
...
Just re-creating the window instead of restarting the app entirely.
2020-05-24 20:42:21 +02:00
39f59786fa
Use long instead of int for object id in Android java wrapper
...
Using int for 64-bit values might cause issues with objects not found
in ObjectDB when the id is truncated.
2020-05-24 13:26:18 +02:00
3be9c74d8b
Merge pull request #38951 from bruvzg/win_ink_block_mm_4
...
Block WM_MOUSEMOVE during Windows Ink pen handling.
2020-05-22 14:34:20 +02:00
db9fa88160
Fix overflow condition with QueryPerformanceCounter
...
The previous code for OS_Windows::get_ticks_usec() multiplied the tick count by 1000000 before dividing by ticks_per_second. The ticks is counted in a 64 bit integer and is susceptible to overflow when a machine has been running for a long period of time (days) with a high frequency timer.
This PR separates the overall calculation into one for seconds and one for the remainder, removing the possibility of overflow due to the multiplier.
2020-05-22 12:46:35 +01:00
b08b027a9a
Block WM_MOUSEMOVE during Windows Ink pen handling.
2020-05-22 10:44:47 +03:00
cf20c0343f
Fix segmentation fault when using context_vulkan after memdelete context_vulkan
2020-05-21 20:38:58 +02:00
1d573969c0
Merge pull request #38874 from bruvzg/tab_drv_sel_40
...
[Windows] Add tablet driver selection.
2020-05-20 13:58:20 +02:00
aec07538f4
Merge pull request #38309 from SkyLucilfer/AndroidLineEdit
...
Fix Android LineEdit editing bugs
2020-05-20 11:45:59 +02:00
d0b5174b6a
[Windows] Add tablet driver selection.
2020-05-20 09:37:32 +03:00
cac399a829
[Windows] Add quotes only to the command line arguments with special characters.
2020-05-19 16:34:15 +03:00
ca3192d18a
Style: Fix unnecessary semicolons that confused clang-format
2020-05-19 11:24:58 +02:00
74b5d6839a
Merge pull request #33447 from bruvzg/macos_zip_sign
...
macOS add signing of DMG and ZIPed export
2020-05-19 10:30:26 +02:00
6e2988f26a
Update the permission string for the Oculus hand tracking to match the latest api update
2020-05-18 15:28:18 -07:00
9844cd45e3
Merge pull request #38820 from ericrybick/master
...
Fix certain characters being recognized as special keys on Windows when using the us international layout
2020-05-18 16:33:18 +02:00
e460456e60
Fix certain characters being recognized as special keys in Windows when using the us international layout
2020-05-18 14:47:54 +02:00
90c7102b51
Move mix_rate, ouput_latency to AudioDriverManager
...
Each driver used to define the (same) project settings values
`audio/mix_rate` and `audio/output_latency`, but the setting names are
not driver specific.
Overriding is still possible via platform tags.
2020-05-18 13:02:06 +02:00
245c179bd3
AudioDriverJavaScript now compute buffer size.
...
Based on mix rate and expected latency.
2020-05-18 13:02:06 +02:00
14e6696c8e
Implementation of the Godot Android Plugin configuration file
2020-05-17 11:11:26 -07:00
cc473b948f
Fix Android LineEdit editing bugs
2020-05-16 17:55:27 +02:00
434bf0572c
Fix input event being dispatched multiple times on Windows
2020-05-16 16:17:50 +02:00
08e80ccd99
Fix popup positions on multiple screens (with same scaling only).
2020-05-16 14:11:43 +03:00
d999071edf
Merge pull request #37924 from thebestnom/migrate-to-androidX
...
Android: Migrate deprecated support library to AndroidX
2020-05-16 09:03:17 +02:00
4bec713b8c
macOS signing improvements: allow signed app exporting as ZIP, sign DMG after exporting.
2020-05-15 09:38:59 +03:00
0ee0fa42e6
Style: Enforce braces around if blocks and loops
...
Using clang-tidy's `readability-braces-around-statements`.
https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 21:57:34 +02:00
07bc4e2f96
Style: Enforce separation line between function definitions
...
I couldn't find a tool that enforces it, so I went the manual route:
```
find -name "thirdparty" -prune \
-o -name "*.cpp" -o -name "*.h" -o -name "*.m" -o -name "*.mm" \
-o -name "*.glsl" > files
perl -0777 -pi -e 's/\n}\n([^#])/\n}\n\n\1/g' $(cat files)
misc/scripts/fix_style.sh -c
```
This adds a newline after all `}` on the first column, unless they
are followed by `#` (typically `#endif`). This leads to having lots
of places with two lines between function/class definitions, but
clang-format then fixes it as we enforce max one line of separation.
This doesn't fix potential occurrences of function definitions which
are indented (e.g. for a helper class defined in a .cpp), but it's
better than nothing. Also can't be made to run easily on CI/hooks so
we'll have to be careful with new code.
Part of #33027 .
2020-05-14 16:54:55 +02:00
Andy Maloney
thebestnom
Rémi Verschelde
PouleyKetchoupp
Zae
Aman Jain
bruvzg
Aaron Franke
Daniel Ting
Marcel Admiraal
Aman Jain
Sergey Minakov
Gaël
Juan Linietsky
Stijn Hinlopen
Fabio Alessandrelli
Fredia Huya-Kouadio
Poq Xert
Timo Schwarzer
Bastiaan Olij
Hugo Locurcio
unknown
Marcus Brummer
Emmanuel Leblond
volzhs
lawnjelly
GuidoRevers
Eric Rybicki
SkyJJ
HaSa1002