godotengine
/
godot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
godot/editor/plugins/asset_library_editor_plugin...

1583 lines
52 KiB
C++
Raw Normal View History

Update asset library editor plugin - new functionality and fixes
2016-06-07 18:29:15 +00:00
/*************************************************************************/
/* asset_library_editor_plugin.cpp */
/*************************************************************************/
/* This file is part of: */
/* GODOT ENGINE */
Use HTTPS URL for Godot's website in the headers
2017-08-27 12:16:55 +00:00
/* https://godotengine.org */
Update asset library editor plugin - new functionality and fixes
2016-06-07 18:29:15 +00:00
/*************************************************************************/
Update copyright statements to 2022 Happy new year to the wonderful Godot community!
2022-01-03 20:27:34 +00:00
/* Copyright (c) 2007-2022 Juan Linietsky, Ariel Manzur. */
/* Copyright (c) 2014-2022 Godot Engine contributors (cf. AUTHORS.md). */
Update asset library editor plugin - new functionality and fixes
2016-06-07 18:29:15 +00:00
/* */
/* Permission is hereby granted, free of charge, to any person obtaining */
/* a copy of this software and associated documentation files (the */
/* "Software"), to deal in the Software without restriction, including */
/* without limitation the rights to use, copy, modify, merge, publish, */
/* distribute, sublicense, and/or sell copies of the Software, and to */
/* permit persons to whom the Software is furnished to do so, subject to */
/* the following conditions: */
/* */
/* The above copyright notice and this permission notice shall be */
/* included in all copies or substantial portions of the Software. */
/* */
/* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, */
/* EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF */
/* MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.*/
/* IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY */
/* CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, */
/* TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE */
/* SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE. */
/*************************************************************************/
Add missing copyright headers and fix formatting Using `misc/scripts/fix_headers.py` on all Godot files. Some missing header guards were added, and the header inclusion order was fixed in the Bullet module.
2018-01-04 23:50:27 +00:00
Update asset library editor plugin - new functionality and fixes
2016-06-07 18:29:15 +00:00
#include "asset_library_editor_plugin.h"
Style: Cleanups, added headers, renamed files Made sure files in core/ and tools/ have a proper Godot license header when written by us. Also renamed aabb.{cpp,h} and object_type_db.{cpp,h} to rect3.{cpp,h} and class_db.{cpp,h} respectively. Also added a proper header to core/io/base64.{c,h} after clarifying the licensing with the original author (public domain).
2017-01-16 07:04:19 +00:00
Rename InputFilter back to Input It changed name as part of the DisplayServer and input refactoring in #37317, with the rationale that input no longer goes through the main loop, so the previous Input singleton now only does filtering. But the gains in consistency are quite limited in the renaming, and it breaks compatibility for all scripts and tutorials that access the Input singleton via the scripting language. A temporary option was suggested to keep the scripting singleton named `Input` even if its type is `InputFilter`, but that adds inconsistency and breaks C#. Fixes godotengine/godot-proposals#639. Fixes #37319. Fixes #37690.
2020-04-28 13:19:37 +00:00
#include "core/input/input.h"
Refactor version macros and fix related bugs The previous logic with VERSION_MKSTRING was a bit unwieldy, so there were several places hardcoding their own variant of the version string, potentially with bugs (e.g. forgetting the patch number when defined). The new logic defines: - VERSION_BRANCH, the main 'major.minor' version (e.g. 3.1) - VERSION_NUMBER, which can be 'major.minor' or 'major.minor.patch', depending on whether the latter is defined (e.g. 3.1.4) - VERSION_FULL_CONFIG, which contains the version status (e.g. stable) and the module-specific suffix (e.g. mono) - VERSION_FULL_BUILD, same as above but with build/reference name (e.g. official, custom_build, mageia, etc.) Note: Slight change here, as the previous format had the build name *before* the module-specific suffix; now it's after - VERSION_FULL_NAME, same as before, so VERSION_FULL_BUILD prefixed with "Godot v" for readability Bugs fixed thanks to that: - Export templates version matching now properly takes VERSION_PATCH into account by relying on VERSION_FULL_CONFIG. - ClassDB hash no longer takes the build name into account, but limits itself to VERSION_FULL_CONFIG (build name is cosmetic, not relevant for the API hash). - Docs XML no longer hardcode the VERSION_STATUS, this was annoying. - Small cleanup in Windows .rc file thanks to new macros.
2018-02-23 18:48:49 +00:00
#include "core/io/json.h"
Make Ctrl+F focus the editor asset library's search field
2019-11-21 23:39:39 +00:00
#include "core/os/keyboard.h"
Refactor version macros and fix related bugs The previous logic with VERSION_MKSTRING was a bit unwieldy, so there were several places hardcoding their own variant of the version string, potentially with bugs (e.g. forgetting the patch number when defined). The new logic defines: - VERSION_BRANCH, the main 'major.minor' version (e.g. 3.1) - VERSION_NUMBER, which can be 'major.minor' or 'major.minor.patch', depending on whether the latter is defined (e.g. 3.1.4) - VERSION_FULL_CONFIG, which contains the version status (e.g. stable) and the module-specific suffix (e.g. mono) - VERSION_FULL_BUILD, same as above but with build/reference name (e.g. official, custom_build, mageia, etc.) Note: Slight change here, as the previous format had the build name *before* the module-specific suffix; now it's after - VERSION_FULL_NAME, same as before, so VERSION_FULL_BUILD prefixed with "Godot v" for readability Bugs fixed thanks to that: - Export templates version matching now properly takes VERSION_PATCH into account by relying on VERSION_FULL_CONFIG. - ClassDB hash no longer takes the build name into account, but limits itself to VERSION_FULL_CONFIG (build name is cosmetic, not relevant for the API hash). - Docs XML no longer hardcode the VERSION_STATUS, this was annoying. - Small cleanup in Windows .rc file thanks to new macros.
2018-02-23 18:48:49 +00:00
#include "core/version.h"
Improve compilation speed (forward declarations/includes cleanup)
2022-02-12 01:46:22 +00:00
#include "editor/editor_file_dialog.h"
Remove dependency on the editor directory being in the build's include path. - Add or remove the necessary subdirectorires to the includes to remove dependency on the editor directory being in the build's include path. - Ensure includes in modified files conform to style guideline. - Remove editor from the build include path.
2019-10-09 14:11:04 +00:00
#include "editor/editor_node.h"
Editor: Cleanup some includes dependencies Removes some unnecessary includes from `editor_node.h`, and instead add those where they're used. Removes unnecessary `editor_node.h` includes in various editor classes. Renames `dynamicfont` to `dynamic_font` in a couple files. Misc cleanup while jumping through that rabbit hole.
2022-02-14 13:00:03 +00:00
#include "editor/editor_paths.h"
Cleans up headers included in editor_node.h
2019-12-24 07:17:23 +00:00
#include "editor/editor_scale.h"
Remove dependency on the editor directory being in the build's include path. - Add or remove the necessary subdirectorires to the includes to remove dependency on the editor directory being in the build's include path. - Ensure includes in modified files conform to style guideline. - Remove editor from the build include path.
2019-10-09 14:11:04 +00:00
#include "editor/editor_settings.h"
Cleans up headers included in editor_node.h
2019-12-24 07:17:23 +00:00
#include "editor/project_settings_editor.h"
Enable asset store for godot 3.0
2017-11-09 10:55:30 +00:00
Add proxy support for the editor * Adds proxy support for `HTTPRequest`. * Adds `network/http_proxy/{host,port}` editor settings. * Labeled as "HTTP Proxy" and it will be used for both HTTP and HTTPS requests. This is the same convention as seen in Android Studio's proxy settings. * Makes Asset Library and Export Template Manager use proxy according to the editor settings.
2021-12-09 03:34:32 +00:00
static inline void setup_http_request(HTTPRequest *request) {
request->set_use_threads(EDITOR_DEF("asset_library/use_threads", true));
const String proxy_host = EDITOR_DEF("network/http_proxy/host", "");
const int proxy_port = EDITOR_DEF("network/http_proxy/port", -1);
request->set_http_proxy(proxy_host, proxy_port);
request->set_https_proxy(proxy_host, proxy_port);
}
Remove some references to unimplemented features in the assetlib This removes rating icons and the associated sorting option as this feature wasn't implemented (and is unlikely to be in the near future). This also renames "Cost" to "License", as the "cost" field refers to SPDX license names on the Godot Asset Library.
2019-06-12 10:24:08 +00:00
void EditorAssetLibraryItem::configure(const String &p_title, int p_asset_id, const String &p_category, int p_category_id, const String &p_author, int p_author_id, const String &p_cost) {
-Work on addon editor plugin (disabled by default) -New HTTPRequest node, to make HTTP requests simpler.
2016-03-04 14:09:45 +00:00
title->set_text(p_title);
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
asset_id = p_asset_id;
-Work on addon editor plugin (disabled by default) -New HTTPRequest node, to make HTTP requests simpler.
2016-03-04 14:09:45 +00:00
category->set_text(p_category);
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
category_id = p_category_id;
-Work on addon editor plugin (disabled by default) -New HTTPRequest node, to make HTTP requests simpler.
2016-03-04 14:09:45 +00:00
author->set_text(p_author);
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
author_id = p_author_id;
-Work on addon editor plugin (disabled by default) -New HTTPRequest node, to make HTTP requests simpler.
2016-03-04 14:09:45 +00:00
price->set_text(p_cost);
}
Texture refactor -Texture renamed to Texture2D -TextureLayered as base now inherits 2Darray, cubemap and cubemap array -Removed all references to flags in textures (they will go in the shader) -Texture3D gone for now (will come back later done properly) -Create base rasterizer for RenderDevice, RasterizerRD
2019-06-11 18:43:37 +00:00
void EditorAssetLibraryItem::set_image(int p_type, int p_index, const Ref<Texture2D> &p_image) {
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
ERR_FAIL_COND(p_type != EditorAssetLibrary::IMAGE_QUEUE_ICON);
ERR_FAIL_COND(p_index != 0);
-Work on addon editor plugin (disabled by default) -New HTTPRequest node, to make HTTP requests simpler.
2016-03-04 14:09:45 +00:00
icon->set_normal_texture(p_image);
}
void EditorAssetLibraryItem::_notification(int p_what) {
Update if == NOTIFICATION_* to switch statements to match coding style
2022-02-16 02:44:22 +00:00
switch (p_what) {
case NOTIFICATION_ENTER_TREE: {
icon->set_normal_texture(get_theme_icon(SNAME("ProjectIconLoading"), SNAME("EditorIcons")));
category->add_theme_color_override("font_color", Color(0.5, 0.5, 0.5));
author->add_theme_color_override("font_color", Color(0.5, 0.5, 0.5));
price->add_theme_color_override("font_color", Color(0.5, 0.5, 0.5));
} break;
-Work on addon editor plugin (disabled by default) -New HTTPRequest node, to make HTTP requests simpler.
2016-03-04 14:09:45 +00:00
}
}
void EditorAssetLibraryItem::_asset_clicked() {
Optimize StringName usage * Added a new macro SNAME() that constructs and caches a local stringname. * Subsequent usages use the cached version. * Since these use a global static variable, a second refcounter of static usages need to be kept for cleanup time. * Replaced all theme usages by this new macro. * Replace all signal emission usages by this new macro. * Replace all call_deferred usages by this new macro. This is part of ongoing work to optimize GUI and the editor.
2021-07-17 21:22:52 +00:00
emit_signal(SNAME("asset_selected"), asset_id);
-Work on addon editor plugin (disabled by default) -New HTTPRequest node, to make HTTP requests simpler.
2016-03-04 14:09:45 +00:00
}
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
void EditorAssetLibraryItem::_category_clicked() {
Optimize StringName usage * Added a new macro SNAME() that constructs and caches a local stringname. * Subsequent usages use the cached version. * Since these use a global static variable, a second refcounter of static usages need to be kept for cleanup time. * Replaced all theme usages by this new macro. * Replace all signal emission usages by this new macro. * Replace all call_deferred usages by this new macro. This is part of ongoing work to optimize GUI and the editor.
2021-07-17 21:22:52 +00:00
emit_signal(SNAME("category_selected"), category_id);
-Work on addon editor plugin (disabled by default) -New HTTPRequest node, to make HTTP requests simpler.
2016-03-04 14:09:45 +00:00
}
Style: Enforce separation line between function definitions I couldn't find a tool that enforces it, so I went the manual route: ``` find -name "thirdparty" -prune \ -o -name "*.cpp" -o -name "*.h" -o -name "*.m" -o -name "*.mm" \ -o -name "*.glsl" > files perl -0777 -pi -e 's/\n}\n([^#])/\n}\n\n\1/g' $(cat files) misc/scripts/fix_style.sh -c ``` This adds a newline after all `}` on the first column, unless they are followed by `#` (typically `#endif`). This leads to having lots of places with two lines between function/class definitions, but clang-format then fixes it as we enforce max one line of separation. This doesn't fix potential occurrences of function definitions which are indented (e.g. for a helper class defined in a .cpp), but it's better than nothing. Also can't be made to run easily on CI/hooks so we'll have to be careful with new code. Part of #33027.
2020-05-14 12:29:06 +00:00
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
void EditorAssetLibraryItem::_author_clicked() {
Optimize StringName usage * Added a new macro SNAME() that constructs and caches a local stringname. * Subsequent usages use the cached version. * Since these use a global static variable, a second refcounter of static usages need to be kept for cleanup time. * Replaced all theme usages by this new macro. * Replace all signal emission usages by this new macro. * Replace all call_deferred usages by this new macro. This is part of ongoing work to optimize GUI and the editor.
2021-07-17 21:22:52 +00:00
emit_signal(SNAME("author_selected"), author_id);
-Work on addon editor plugin (disabled by default) -New HTTPRequest node, to make HTTP requests simpler.
2016-03-04 14:09:45 +00:00
}
void EditorAssetLibraryItem::_bind_methods() {
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
ClassDB::bind_method("set_image", &EditorAssetLibraryItem::set_image);
ADD_SIGNAL(MethodInfo("asset_selected"));
ADD_SIGNAL(MethodInfo("category_selected"));
ADD_SIGNAL(MethodInfo("author_selected"));
-Work on addon editor plugin (disabled by default) -New HTTPRequest node, to make HTTP requests simpler.
2016-03-04 14:09:45 +00:00
}
EditorAssetLibraryItem::EditorAssetLibraryItem() {
Ref<StyleBoxEmpty> border;
Rename `instance()`->`instantiate()` when it's a verb
2021-06-17 22:03:09 +00:00
border.instantiate();
Rename Control margin to offset
2020-12-22 16:24:29 +00:00
border->set_default_margin(SIDE_LEFT, 5 * EDSCALE);
border->set_default_margin(SIDE_RIGHT, 5 * EDSCALE);
border->set_default_margin(SIDE_BOTTOM, 5 * EDSCALE);
border->set_default_margin(SIDE_TOP, 5 * EDSCALE);
Revert "Add missing SNAME macro optimization to all theme methods call" This reverts commit a988fad9a092053434545c32afae91ccbdfbe792. As discussed in #57725 and clarified in #57788, `SNAME` is not meant to be used everywhere but only in critical code paths. For theme methods specifically, it was by design that only getters use `SNAME` and not setters.
2022-02-08 09:14:58 +00:00
add_theme_style_override("panel", border);
-Work on addon editor plugin (disabled by default) -New HTTPRequest node, to make HTTP requests simpler.
2016-03-04 14:09:45 +00:00
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
HBoxContainer *hb = memnew(HBoxContainer);
AssetLib minor fixes and enhancements
2019-08-28 04:27:26 +00:00
// Add some spacing to visually separate the icon from the asset details.
Revert "Add missing SNAME macro optimization to all theme methods call" This reverts commit a988fad9a092053434545c32afae91ccbdfbe792. As discussed in #57725 and clarified in #57788, `SNAME` is not meant to be used everywhere but only in critical code paths. For theme methods specifically, it was by design that only getters use `SNAME` and not setters.
2022-02-08 09:14:58 +00:00
hb->add_theme_constant_override("separation", 15 * EDSCALE);
-Work on addon editor plugin (disabled by default) -New HTTPRequest node, to make HTTP requests simpler.
2016-03-04 14:09:45 +00:00
add_child(hb);
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
icon = memnew(TextureButton);
Add spacing between the icon and details in the assetlib list This also scales margin and separation values on hiDPI displays.
2019-06-11 23:13:07 +00:00
icon->set_custom_minimum_size(Size2(64, 64) * EDSCALE);
-Work on addon editor plugin (disabled by default) -New HTTPRequest node, to make HTTP requests simpler.
2016-03-04 14:09:45 +00:00
icon->set_default_cursor_shape(CURSOR_POINTING_HAND);
Signals: Port connect calls to use callable_mp Remove now unnecessary bindings of signal callbacks in the public API. There might be some false positives that need rebinding if they were meant to be public. No regular expressions were harmed in the making of this commit. (Nah, just kidding.)
2020-02-21 17:28:45 +00:00
icon->connect("pressed", callable_mp(this, &EditorAssetLibraryItem::_asset_clicked));
-Work on addon editor plugin (disabled by default) -New HTTPRequest node, to make HTTP requests simpler.
2016-03-04 14:09:45 +00:00
hb->add_child(icon);
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
VBoxContainer *vb = memnew(VBoxContainer);
-Work on addon editor plugin (disabled by default) -New HTTPRequest node, to make HTTP requests simpler.
2016-03-04 14:09:45 +00:00
hb->add_child(vb);
Working multiple window support, including editor
2020-03-06 17:00:16 +00:00
vb->set_h_size_flags(Control::SIZE_EXPAND_FILL);
-Work on addon editor plugin (disabled by default) -New HTTPRequest node, to make HTTP requests simpler.
2016-03-04 14:09:45 +00:00
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
title = memnew(LinkButton);
-Work on addon editor plugin (disabled by default) -New HTTPRequest node, to make HTTP requests simpler.
2016-03-04 14:09:45 +00:00
title->set_underline_mode(LinkButton::UNDERLINE_MODE_ON_HOVER);
Signals: Port connect calls to use callable_mp Remove now unnecessary bindings of signal callbacks in the public API. There might be some false positives that need rebinding if they were meant to be public. No regular expressions were harmed in the making of this commit. (Nah, just kidding.)
2020-02-21 17:28:45 +00:00
title->connect("pressed", callable_mp(this, &EditorAssetLibraryItem::_asset_clicked));
-Work on addon editor plugin (disabled by default) -New HTTPRequest node, to make HTTP requests simpler.
2016-03-04 14:09:45 +00:00
vb->add_child(title);
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
category = memnew(LinkButton);
-Work on addon editor plugin (disabled by default) -New HTTPRequest node, to make HTTP requests simpler.
2016-03-04 14:09:45 +00:00
category->set_underline_mode(LinkButton::UNDERLINE_MODE_ON_HOVER);
Signals: Port connect calls to use callable_mp Remove now unnecessary bindings of signal callbacks in the public API. There might be some false positives that need rebinding if they were meant to be public. No regular expressions were harmed in the making of this commit. (Nah, just kidding.)
2020-02-21 17:28:45 +00:00
category->connect("pressed", callable_mp(this, &EditorAssetLibraryItem::_category_clicked));
-Work on addon editor plugin (disabled by default) -New HTTPRequest node, to make HTTP requests simpler.
2016-03-04 14:09:45 +00:00
vb->add_child(category);
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
author = memnew(LinkButton);
-Work on addon editor plugin (disabled by default) -New HTTPRequest node, to make HTTP requests simpler.
2016-03-04 14:09:45 +00:00
author->set_underline_mode(LinkButton::UNDERLINE_MODE_ON_HOVER);
Signals: Port connect calls to use callable_mp Remove now unnecessary bindings of signal callbacks in the public API. There might be some false positives that need rebinding if they were meant to be public. No regular expressions were harmed in the making of this commit. (Nah, just kidding.)
2020-02-21 17:28:45 +00:00
author->connect("pressed", callable_mp(this, &EditorAssetLibraryItem::_author_clicked));
-Work on addon editor plugin (disabled by default) -New HTTPRequest node, to make HTTP requests simpler.
2016-03-04 14:09:45 +00:00
vb->add_child(author);
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
price = memnew(Label);
-Work on addon editor plugin (disabled by default) -New HTTPRequest node, to make HTTP requests simpler.
2016-03-04 14:09:45 +00:00
vb->add_child(price);
Add spacing between the icon and details in the assetlib list This also scales margin and separation values on hiDPI displays.
2019-06-11 23:13:07 +00:00
set_custom_minimum_size(Size2(250, 100) * EDSCALE);
Working multiple window support, including editor
2020-03-06 17:00:16 +00:00
set_h_size_flags(Control::SIZE_EXPAND_FILL);
-Work on addon editor plugin (disabled by default) -New HTTPRequest node, to make HTTP requests simpler.
2016-03-04 14:09:45 +00:00
}
//////////////////////////////////////////////////////////////////////////////
Texture refactor -Texture renamed to Texture2D -TextureLayered as base now inherits 2Darray, cubemap and cubemap array -Removed all references to flags in textures (they will go in the shader) -Texture3D gone for now (will come back later done properly) -Create base rasterizer for RenderDevice, RasterizerRD
2019-06-11 18:43:37 +00:00
void EditorAssetLibraryItemDescription::set_image(int p_type, int p_index, const Ref<Texture2D> &p_image) {
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
switch (p_type) {
Added asset library on project manager for templates
2016-06-08 12:25:47 +00:00
case EditorAssetLibrary::IMAGE_QUEUE_ICON: {
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
item->call("set_image", p_type, p_index, p_image);
icon = p_image;
-Work on addon editor plugin (disabled by default) -New HTTPRequest node, to make HTTP requests simpler.
2016-03-04 14:09:45 +00:00
} break;
Added asset library on project manager for templates
2016-06-08 12:25:47 +00:00
case EditorAssetLibrary::IMAGE_QUEUE_THUMBNAIL: {
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
for (int i = 0; i < preview_images.size(); i++) {
if (preview_images[i].id == p_index) {
Thumbnail overlay for videos in AssetLib
2018-05-11 17:28:17 +00:00
if (preview_images[i].is_video) {
Optimize StringName usage * Added a new macro SNAME() that constructs and caches a local stringname. * Subsequent usages use the cached version. * Since these use a global static variable, a second refcounter of static usages need to be kept for cleanup time. * Replaced all theme usages by this new macro. * Replace all signal emission usages by this new macro. * Replace all call_deferred usages by this new macro. This is part of ongoing work to optimize GUI and the editor.
2021-07-17 21:22:52 +00:00
Ref<Image> overlay = previews->get_theme_icon(SNAME("PlayOverlay"), SNAME("EditorIcons"))->get_image();
Rename Texture.get_data() to get_image()
2021-03-28 11:32:17 +00:00
Ref<Image> thumbnail = p_image->get_image();
Fix pixelized previews, but also instances of breaking ImageTexture cache. Closes #25378.
2019-01-27 16:39:16 +00:00
thumbnail = thumbnail->duplicate();
Fix asset library video play overlay not being centered on the thumbnail
2020-01-21 07:04:32 +00:00
Point2 overlay_pos = Point2((thumbnail->get_width() - overlay->get_width()) / 2, (thumbnail->get_height() - overlay->get_height()) / 2);
Thumbnail overlay for videos in AssetLib
2018-05-11 17:28:17 +00:00
AssetLib: convert video thumbnails to RGBA Image::blend_rect only works with images that have the same format.
2019-03-05 20:02:56 +00:00
// Overlay and thumbnail need the same format for `blend_rect` to work.
thumbnail->convert(Image::FORMAT_RGBA8);
PoolVector is gone, replaced by Vector Typed `PoolTypeArray` types are now renamed `PackedTypeArray` and are sugar for `Vector<Type>`.
2020-02-17 21:06:54 +00:00
Thumbnail overlay for videos in AssetLib
2018-05-11 17:28:17 +00:00
thumbnail->blend_rect(overlay, overlay->get_used_rect(), overlay_pos);
Ref<ImageTexture> tex;
Rename `instance()`->`instantiate()` when it's a verb
2021-06-17 22:03:09 +00:00
tex.instantiate();
Thumbnail overlay for videos in AssetLib
2018-05-11 17:28:17 +00:00
tex->create_from_image(thumbnail);
preview_images[i].button->set_icon(tex);
Improve preview and screenshot display in the asset library Images are now resized with Lanczos interpolation for higher quality. Video thumbnails now display a "pointing hand" cursor when hovered as they will open in an external browser.
2019-07-18 17:48:47 +00:00
// Make it clearer that clicking it will open an external link
Working multiple window support, including editor
2020-03-06 17:00:16 +00:00
preview_images[i].button->set_default_cursor_shape(Control::CURSOR_POINTING_HAND);
Thumbnail overlay for videos in AssetLib
2018-05-11 17:28:17 +00:00
} else {
preview_images[i].button->set_icon(p_image);
}
Update asset library editor plugin - new functionality and fixes
2016-06-07 18:29:15 +00:00
break;
-Work on addon editor plugin (disabled by default) -New HTTPRequest node, to make HTTP requests simpler.
2016-03-04 14:09:45 +00:00
}
}
} break;
Added asset library on project manager for templates
2016-06-08 12:25:47 +00:00
case EditorAssetLibrary::IMAGE_QUEUE_SCREENSHOT: {
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
for (int i = 0; i < preview_images.size(); i++) {
if (preview_images[i].id == p_index) {
Reduce unnecessary COW on Vector by make writing explicit This commit makes operator[] on Vector const and adds a write proxy to it. From now on writes to Vectors need to happen through the .write proxy. So for instance: Vector<int> vec; vec.push_back(10); std::cout << vec[0] << std::endl; vec.write[0] = 20; Failing to use the .write proxy will cause a compilation error. In addition COWable datatypes can now embed a CowData pointer to their data. This means that String, CharString, and VMap no longer use or derive from Vector. _ALWAYS_INLINE_ and _FORCE_INLINE_ are now equivalent for debug and non-debug builds. This is a lot faster for Vector in the editor and while running tests. The reason why this difference used to exist is because force-inlined methods used to give a bad debugging experience. After extensive testing with modern compilers this is no longer the case.
2018-07-25 01:11:03 +00:00
preview_images.write[i].image = p_image;
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
if (preview_images[i].button->is_pressed()) {
Update asset library editor plugin - new functionality and fixes
2016-06-07 18:29:15 +00:00
_preview_click(p_index);
}
break;
-Work on addon editor plugin (disabled by default) -New HTTPRequest node, to make HTTP requests simpler.
2016-03-04 14:09:45 +00:00
}
}
} break;
}
}
Minor cleanup of the AssetLib's asset dialog
2019-08-29 05:37:44 +00:00
fixed loading old theme styleboxes
2017-08-04 19:41:31 +00:00
void EditorAssetLibraryItemDescription::_notification(int p_what) {
switch (p_what) {
Fix theming update in several editor classes
2022-01-16 07:59:02 +00:00
case NOTIFICATION_ENTER_TREE:
case NOTIFICATION_THEME_CHANGED: {
Revert "Add missing SNAME macro optimization to all theme methods call" This reverts commit a988fad9a092053434545c32afae91ccbdfbe792. As discussed in #57725 and clarified in #57788, `SNAME` is not meant to be used everywhere but only in critical code paths. For theme methods specifically, it was by design that only getters use `SNAME` and not setters.
2022-02-08 09:14:58 +00:00
previews_bg->add_theme_style_override("panel", previews->get_theme_stylebox(SNAME("normal"), SNAME("TextEdit")));
fixed loading old theme styleboxes
2017-08-04 19:41:31 +00:00
} break;
}
}
Minor cleanup of the AssetLib's asset dialog
2019-08-29 05:37:44 +00:00
Added asset library on project manager for templates
2016-06-08 12:25:47 +00:00
void EditorAssetLibraryItemDescription::_bind_methods() {
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
ClassDB::bind_method(D_METHOD("set_image"), &EditorAssetLibraryItemDescription::set_image);
-Made editor support SSL certs by default (embedded them) -Made asset sharing support https -Many fixes to HTTPRequest -Added an asset installer dialog -Visual cleanups to asset sharing tab -Fixed some issues in ScrollContainer, hope it does not break things -Asset sharing tab is not visible (hidden on purpose) for now.
2016-03-12 13:44:12 +00:00
}
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
void EditorAssetLibraryItemDescription::_link_click(const String &p_url) {
-Made editor support SSL certs by default (embedded them) -Made asset sharing support https -Many fixes to HTTPRequest -Added an asset installer dialog -Visual cleanups to asset sharing tab -Fixed some issues in ScrollContainer, hope it does not break things -Asset sharing tab is not visible (hidden on purpose) for now.
2016-03-12 13:44:12 +00:00
ERR_FAIL_COND(!p_url.begins_with("http"));
OS::get_singleton()->shell_open(p_url);
-Work on addon editor plugin (disabled by default) -New HTTPRequest node, to make HTTP requests simpler.
2016-03-04 14:09:45 +00:00
}
Added asset library on project manager for templates
2016-06-08 12:25:47 +00:00
void EditorAssetLibraryItemDescription::_preview_click(int p_id) {
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
for (int i = 0; i < preview_images.size(); i++) {
if (preview_images[i].id == p_id) {
Update asset library editor plugin - new functionality and fixes
2016-06-07 18:29:15 +00:00
preview_images[i].button->set_pressed(true);
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
if (!preview_images[i].is_video) {
if (preview_images[i].image.is_valid()) {
Update asset library editor plugin - new functionality and fixes
2016-06-07 18:29:15 +00:00
preview->set_texture(preview_images[i].image);
Working multiple window support, including editor
2020-03-06 17:00:16 +00:00
child_controls_changed();
Update asset library editor plugin - new functionality and fixes
2016-06-07 18:29:15 +00:00
}
} else {
_link_click(preview_images[i].video_link);
}
} else {
preview_images[i].button->set_pressed(false);
}
}
}
Remove some references to unimplemented features in the assetlib This removes rating icons and the associated sorting option as this feature wasn't implemented (and is unlikely to be in the near future). This also renames "Cost" to "License", as the "cost" field refers to SPDX license names on the Godot Asset Library.
2019-06-12 10:24:08 +00:00
void EditorAssetLibraryItemDescription::configure(const String &p_title, int p_asset_id, const String &p_category, int p_category_id, const String &p_author, int p_author_id, const String &p_cost, int p_version, const String &p_version_string, const String &p_description, const String &p_download_url, const String &p_browse_url, const String &p_sha256_hash) {
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
asset_id = p_asset_id;
title = p_title;
download_url = p_download_url;
sha256 = p_sha256_hash;
Remove some references to unimplemented features in the assetlib This removes rating icons and the associated sorting option as this feature wasn't implemented (and is unlikely to be in the near future). This also renames "Cost" to "License", as the "cost" field refers to SPDX license names on the Godot Asset Library.
2019-06-12 10:24:08 +00:00
item->configure(p_title, p_asset_id, p_category, p_category_id, p_author, p_author_id, p_cost);
-Made editor support SSL certs by default (embedded them) -Made asset sharing support https -Many fixes to HTTPRequest -Added an asset installer dialog -Visual cleanups to asset sharing tab -Fixed some issues in ScrollContainer, hope it does not break things -Asset sharing tab is not visible (hidden on purpose) for now.
2016-03-12 13:44:12 +00:00
description->clear();
i18n: Add more assetlib strings to translate Fixes #8463.
2017-04-20 12:42:35 +00:00
description->add_text(TTR("Version:") + " " + p_version_string + "\n");
description->add_text(TTR("Contents:") + " ");
-Made editor support SSL certs by default (embedded them) -Made asset sharing support https -Many fixes to HTTPRequest -Added an asset installer dialog -Visual cleanups to asset sharing tab -Fixed some issues in ScrollContainer, hope it does not break things -Asset sharing tab is not visible (hidden on purpose) for now.
2016-03-12 13:44:12 +00:00
description->push_meta(p_browse_url);
i18n: Add more assetlib strings to translate Fixes #8463.
2017-04-20 12:42:35 +00:00
description->add_text(TTR("View Files"));
-Made editor support SSL certs by default (embedded them) -Made asset sharing support https -Many fixes to HTTPRequest -Added an asset installer dialog -Visual cleanups to asset sharing tab -Fixed some issues in ScrollContainer, hope it does not break things -Asset sharing tab is not visible (hidden on purpose) for now.
2016-03-12 13:44:12 +00:00
description->pop();
i18n: Add more assetlib strings to translate Fixes #8463.
2017-04-20 12:42:35 +00:00
description->add_text("\n" + TTR("Description:") + "\n\n");
Remove bbcode_text from RichTextLabel Also renames: - append_bbcode -> append_text - get_bbcode -> get_text - set_bbcode -> set_text - get_text -> get_parsed_text Property text is: set_text get_text
2020-05-29 14:25:12 +00:00
description->append_text(p_description);
Allow selection in asset description Many assets include links in the description. This change enables selection for the links, and other information such as version numbers, to be copied/pasted.
2021-12-11 19:43:05 +00:00
description->set_selection_enabled(true);
-Work on addon editor plugin (disabled by default) -New HTTPRequest node, to make HTTP requests simpler.
2016-03-04 14:09:45 +00:00
set_title(p_title);
}
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
void EditorAssetLibraryItemDescription::add_preview(int p_id, bool p_video, const String &p_url) {
-Work on addon editor plugin (disabled by default) -New HTTPRequest node, to make HTTP requests simpler.
2016-03-04 14:09:45 +00:00
Preview preview;
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
preview.id = p_id;
preview.video_link = p_url;
preview.is_video = p_video;
preview.button = memnew(Button);
Optimize StringName usage * Added a new macro SNAME() that constructs and caches a local stringname. * Subsequent usages use the cached version. * Since these use a global static variable, a second refcounter of static usages need to be kept for cleanup time. * Replaced all theme usages by this new macro. * Replace all signal emission usages by this new macro. * Replace all call_deferred usages by this new macro. This is part of ongoing work to optimize GUI and the editor.
2021-07-17 21:22:52 +00:00
preview.button->set_icon(previews->get_theme_icon(SNAME("ThumbnailWait"), SNAME("EditorIcons")));
-Work on addon editor plugin (disabled by default) -New HTTPRequest node, to make HTTP requests simpler.
2016-03-04 14:09:45 +00:00
preview.button->set_toggle_mode(true);
Signals: Port connect calls to use callable_mp Remove now unnecessary bindings of signal callbacks in the public API. There might be some false positives that need rebinding if they were meant to be public. No regular expressions were harmed in the making of this commit. (Nah, just kidding.)
2020-02-21 17:28:45 +00:00
preview.button->connect("pressed", callable_mp(this, &EditorAssetLibraryItemDescription::_preview_click), varray(p_id));
-Work on addon editor plugin (disabled by default) -New HTTPRequest node, to make HTTP requests simpler.
2016-03-04 14:09:45 +00:00
preview_hb->add_child(preview.button);
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
if (!p_video) {
Optimize StringName usage * Added a new macro SNAME() that constructs and caches a local stringname. * Subsequent usages use the cached version. * Since these use a global static variable, a second refcounter of static usages need to be kept for cleanup time. * Replaced all theme usages by this new macro. * Replace all signal emission usages by this new macro. * Replace all call_deferred usages by this new macro. This is part of ongoing work to optimize GUI and the editor.
2021-07-17 21:22:52 +00:00
preview.image = previews->get_theme_icon(SNAME("ThumbnailWait"), SNAME("EditorIcons"));
Update asset library editor plugin - new functionality and fixes
2016-06-07 18:29:15 +00:00
}
Automatically select the first image of the assets page
2019-08-15 11:43:00 +00:00
preview_images.push_back(preview);
if (preview_images.size() == 1 && !p_video) {
Update asset library editor plugin - new functionality and fixes
2016-06-07 18:29:15 +00:00
_preview_click(p_id);
}
-Work on addon editor plugin (disabled by default) -New HTTPRequest node, to make HTTP requests simpler.
2016-03-04 14:09:45 +00:00
}
Added asset library on project manager for templates
2016-06-08 12:25:47 +00:00
EditorAssetLibraryItemDescription::EditorAssetLibraryItemDescription() {
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
HBoxContainer *hbox = memnew(HBoxContainer);
AssetLib minor fixes and enhancements
2019-08-28 04:27:26 +00:00
add_child(hbox);
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
VBoxContainer *desc_vbox = memnew(VBoxContainer);
-Work on addon editor plugin (disabled by default) -New HTTPRequest node, to make HTTP requests simpler.
2016-03-04 14:09:45 +00:00
hbox->add_child(desc_vbox);
Revert "Add missing SNAME macro optimization to all theme methods call" This reverts commit a988fad9a092053434545c32afae91ccbdfbe792. As discussed in #57725 and clarified in #57788, `SNAME` is not meant to be used everywhere but only in critical code paths. For theme methods specifically, it was by design that only getters use `SNAME` and not setters.
2022-02-08 09:14:58 +00:00
hbox->add_theme_constant_override("separation", 15 * EDSCALE);
-Work on addon editor plugin (disabled by default) -New HTTPRequest node, to make HTTP requests simpler.
2016-03-04 14:09:45 +00:00
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
item = memnew(EditorAssetLibraryItem);
-Work on addon editor plugin (disabled by default) -New HTTPRequest node, to make HTTP requests simpler.
2016-03-04 14:09:45 +00:00
desc_vbox->add_child(item);
Minor cleanup of the AssetLib's asset dialog
2019-08-29 05:37:44 +00:00
desc_vbox->set_custom_minimum_size(Size2(440 * EDSCALE, 0));
-Work on addon editor plugin (disabled by default) -New HTTPRequest node, to make HTTP requests simpler.
2016-03-04 14:09:45 +00:00
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
description = memnew(RichTextLabel);
Minor cleanup of the AssetLib's asset dialog
2019-08-29 05:37:44 +00:00
desc_vbox->add_child(description);
Working multiple window support, including editor
2020-03-06 17:00:16 +00:00
description->set_v_size_flags(Control::SIZE_EXPAND_FILL);
Signals: Port connect calls to use callable_mp Remove now unnecessary bindings of signal callbacks in the public API. There might be some false positives that need rebinding if they were meant to be public. No regular expressions were harmed in the making of this commit. (Nah, just kidding.)
2020-02-21 17:28:45 +00:00
description->connect("meta_clicked", callable_mp(this, &EditorAssetLibraryItemDescription::_link_click));
Revert "Add missing SNAME macro optimization to all theme methods call" This reverts commit a988fad9a092053434545c32afae91ccbdfbe792. As discussed in #57725 and clarified in #57788, `SNAME` is not meant to be used everywhere but only in critical code paths. For theme methods specifically, it was by design that only getters use `SNAME` and not setters.
2022-02-08 09:14:58 +00:00
description->add_theme_constant_override("line_separation", Math::round(5 * EDSCALE));
-Work on addon editor plugin (disabled by default) -New HTTPRequest node, to make HTTP requests simpler.
2016-03-04 14:09:45 +00:00
Separated description from the preview content and centered the playbutton for video thumbnails in the Asset Library Editor
2019-04-23 19:53:15 +00:00
VBoxContainer *previews_vbox = memnew(VBoxContainer);
hbox->add_child(previews_vbox);
Revert "Add missing SNAME macro optimization to all theme methods call" This reverts commit a988fad9a092053434545c32afae91ccbdfbe792. As discussed in #57725 and clarified in #57788, `SNAME` is not meant to be used everywhere but only in critical code paths. For theme methods specifically, it was by design that only getters use `SNAME` and not setters.
2022-02-08 09:14:58 +00:00
previews_vbox->add_theme_constant_override("separation", 15 * EDSCALE);
Working multiple window support, including editor
2020-03-06 17:00:16 +00:00
previews_vbox->set_v_size_flags(Control::SIZE_EXPAND_FILL);
Separated description from the preview content and centered the playbutton for video thumbnails in the Asset Library Editor
2019-04-23 19:53:15 +00:00
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
preview = memnew(TextureRect);
Separated description from the preview content and centered the playbutton for video thumbnails in the Asset Library Editor
2019-04-23 19:53:15 +00:00
previews_vbox->add_child(preview);
Rename TextureRect.expand to ignore_texture_size
2021-11-30 00:21:45 +00:00
preview->set_ignore_texture_size(true);
AssetLib minor fixes and enhancements
2019-08-28 04:27:26 +00:00
preview->set_stretch_mode(TextureRect::STRETCH_KEEP_ASPECT_CENTERED);
preview->set_custom_minimum_size(Size2(640 * EDSCALE, 345 * EDSCALE));
-Work on addon editor plugin (disabled by default) -New HTTPRequest node, to make HTTP requests simpler.
2016-03-04 14:09:45 +00:00
fixed loading old theme styleboxes
2017-08-04 19:41:31 +00:00
previews_bg = memnew(PanelContainer);
Separated description from the preview content and centered the playbutton for video thumbnails in the Asset Library Editor
2019-04-23 19:53:15 +00:00
previews_vbox->add_child(previews_bg);
previews_bg->set_custom_minimum_size(Size2(640 * EDSCALE, 101 * EDSCALE));
-Work on addon editor plugin (disabled by default) -New HTTPRequest node, to make HTTP requests simpler.
2016-03-04 14:09:45 +00:00
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
previews = memnew(ScrollContainer);
-Work on addon editor plugin (disabled by default) -New HTTPRequest node, to make HTTP requests simpler.
2016-03-04 14:09:45 +00:00
previews_bg->add_child(previews);
ScrollContainer's scrollbar visibility is now enum
2021-12-07 16:15:18 +00:00
previews->set_vertical_scroll_mode(ScrollContainer::SCROLL_MODE_DISABLED);
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
preview_hb = memnew(HBoxContainer);
Working multiple window support, including editor
2020-03-06 17:00:16 +00:00
preview_hb->set_v_size_flags(Control::SIZE_EXPAND_FILL);
-Work on addon editor plugin (disabled by default) -New HTTPRequest node, to make HTTP requests simpler.
2016-03-04 14:09:45 +00:00
previews->add_child(preview_hb);
Rename AcceptDialog get_ok() to get_ok_button() Also renames: - AcceptDialog add_cancel() to add_cancel_button() - ConfirmationDiaglog get_cancel() to get_cancel_button()
2020-12-14 18:37:30 +00:00
get_ok_button()->set_text(TTR("Download"));
get_cancel_button()->set_text(TTR("Close"));
-Work on addon editor plugin (disabled by default) -New HTTPRequest node, to make HTTP requests simpler.
2016-03-04 14:09:45 +00:00
}
Style: Enforce separation line between function definitions I couldn't find a tool that enforces it, so I went the manual route: ``` find -name "thirdparty" -prune \ -o -name "*.cpp" -o -name "*.h" -o -name "*.m" -o -name "*.mm" \ -o -name "*.glsl" > files perl -0777 -pi -e 's/\n}\n([^#])/\n}\n\n\1/g' $(cat files) misc/scripts/fix_style.sh -c ``` This adds a newline after all `}` on the first column, unless they are followed by `#` (typically `#endif`). This leads to having lots of places with two lines between function/class definitions, but clang-format then fixes it as we enforce max one line of separation. This doesn't fix potential occurrences of function definitions which are indented (e.g. for a helper class defined in a .cpp), but it's better than nothing. Also can't be made to run easily on CI/hooks so we'll have to be careful with new code. Part of #33027.
2020-05-14 12:29:06 +00:00
-Made editor support SSL certs by default (embedded them) -Made asset sharing support https -Many fixes to HTTPRequest -Added an asset installer dialog -Visual cleanups to asset sharing tab -Fixed some issues in ScrollContainer, hope it does not break things -Asset sharing tab is not visible (hidden on purpose) for now.
2016-03-12 13:44:12 +00:00
///////////////////////////////////////////////////////////////////////////////////
PoolVector is gone, replaced by Vector Typed `PoolTypeArray` types are now renamed `PackedTypeArray` and are sugar for `Vector<Type>`.
2020-02-17 21:06:54 +00:00
void EditorAssetLibraryItemDownload::_http_download_completed(int p_status, int p_code, const PackedStringArray &headers, const PackedByteArray &p_data) {
-Made editor support SSL certs by default (embedded them) -Made asset sharing support https -Many fixes to HTTPRequest -Added an asset installer dialog -Visual cleanups to asset sharing tab -Fixed some issues in ScrollContainer, hope it does not break things -Asset sharing tab is not visible (hidden on purpose) for now.
2016-03-12 13:44:12 +00:00
String error_text;
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
switch (p_status) {
Handle all download errors in the asset library Addresses part of #31115
2019-08-08 07:06:26 +00:00
case HTTPRequest::RESULT_CHUNKED_BODY_SIZE_MISMATCH:
-Made editor support SSL certs by default (embedded them) -Made asset sharing support https -Many fixes to HTTPRequest -Added an asset installer dialog -Visual cleanups to asset sharing tab -Fixed some issues in ScrollContainer, hope it does not break things -Asset sharing tab is not visible (hidden on purpose) for now.
2016-03-12 13:44:12 +00:00
case HTTPRequest::RESULT_CONNECTION_ERROR:
Handle all download errors in the asset library Addresses part of #31115
2019-08-08 07:06:26 +00:00
case HTTPRequest::RESULT_BODY_SIZE_LIMIT_EXCEEDED: {
i18n: Add more assetlib strings to translate Fixes #8463.
2017-04-20 12:42:35 +00:00
error_text = TTR("Connection error, please try again.");
status->set_text(TTR("Can't connect."));
-Made editor support SSL certs by default (embedded them) -Made asset sharing support https -Many fixes to HTTPRequest -Added an asset installer dialog -Visual cleanups to asset sharing tab -Fixed some issues in ScrollContainer, hope it does not break things -Asset sharing tab is not visible (hidden on purpose) for now.
2016-03-12 13:44:12 +00:00
} break;
Handle all download errors in the asset library Addresses part of #31115
2019-08-08 07:06:26 +00:00
case HTTPRequest::RESULT_CANT_CONNECT:
case HTTPRequest::RESULT_SSL_HANDSHAKE_ERROR: {
i18n: Add more assetlib strings to translate Fixes #8463.
2017-04-20 12:42:35 +00:00
error_text = TTR("Can't connect to host:") + " " + host;
status->set_text(TTR("Can't connect."));
-Made editor support SSL certs by default (embedded them) -Made asset sharing support https -Many fixes to HTTPRequest -Added an asset installer dialog -Visual cleanups to asset sharing tab -Fixed some issues in ScrollContainer, hope it does not break things -Asset sharing tab is not visible (hidden on purpose) for now.
2016-03-12 13:44:12 +00:00
} break;
case HTTPRequest::RESULT_NO_RESPONSE: {
i18n: Add more assetlib strings to translate Fixes #8463.
2017-04-20 12:42:35 +00:00
error_text = TTR("No response from host:") + " " + host;
status->set_text(TTR("No response."));
-Made editor support SSL certs by default (embedded them) -Made asset sharing support https -Many fixes to HTTPRequest -Added an asset installer dialog -Visual cleanups to asset sharing tab -Fixed some issues in ScrollContainer, hope it does not break things -Asset sharing tab is not visible (hidden on purpose) for now.
2016-03-12 13:44:12 +00:00
} break;
Handle all download errors in the asset library Addresses part of #31115
2019-08-08 07:06:26 +00:00
case HTTPRequest::RESULT_CANT_RESOLVE: {
error_text = TTR("Can't resolve hostname:") + " " + host;
status->set_text(TTR("Can't resolve."));
} break;
-Made editor support SSL certs by default (embedded them) -Made asset sharing support https -Many fixes to HTTPRequest -Added an asset installer dialog -Visual cleanups to asset sharing tab -Fixed some issues in ScrollContainer, hope it does not break things -Asset sharing tab is not visible (hidden on purpose) for now.
2016-03-12 13:44:12 +00:00
case HTTPRequest::RESULT_REQUEST_FAILED: {
i18n: Add more assetlib strings to translate Fixes #8463.
2017-04-20 12:42:35 +00:00
error_text = TTR("Request failed, return code:") + " " + itos(p_code);
Export: Remove temp files from cache after export So far we left most temporary files lying around, so this attempts to fix that. I added a helper method to DirAccess to factor out the boilerplate of creating a DirAccess, checking if the file exists, remove it or print an error on failure.
2019-08-09 11:45:30 +00:00
status->set_text(TTR("Request failed."));
-Made editor support SSL certs by default (embedded them) -Made asset sharing support https -Many fixes to HTTPRequest -Added an asset installer dialog -Visual cleanups to asset sharing tab -Fixed some issues in ScrollContainer, hope it does not break things -Asset sharing tab is not visible (hidden on purpose) for now.
2016-03-12 13:44:12 +00:00
} break;
Handle all download errors in the asset library Addresses part of #31115
2019-08-08 07:06:26 +00:00
case HTTPRequest::RESULT_DOWNLOAD_FILE_CANT_OPEN:
case HTTPRequest::RESULT_DOWNLOAD_FILE_WRITE_ERROR: {
Export: Remove temp files from cache after export So far we left most temporary files lying around, so this attempts to fix that. I added a helper method to DirAccess to factor out the boilerplate of creating a DirAccess, checking if the file exists, remove it or print an error on failure.
2019-08-09 11:45:30 +00:00
error_text = TTR("Cannot save response to:") + " " + download->get_download_file();
Handle all download errors in the asset library Addresses part of #31115
2019-08-08 07:06:26 +00:00
status->set_text(TTR("Write error."));
} break;
-Made editor support SSL certs by default (embedded them) -Made asset sharing support https -Many fixes to HTTPRequest -Added an asset installer dialog -Visual cleanups to asset sharing tab -Fixed some issues in ScrollContainer, hope it does not break things -Asset sharing tab is not visible (hidden on purpose) for now.
2016-03-12 13:44:12 +00:00
case HTTPRequest::RESULT_REDIRECT_LIMIT_REACHED: {
i18n: Add more assetlib strings to translate Fixes #8463.
2017-04-20 12:42:35 +00:00
error_text = TTR("Request failed, too many redirects");
Export: Remove temp files from cache after export So far we left most temporary files lying around, so this attempts to fix that. I added a helper method to DirAccess to factor out the boilerplate of creating a DirAccess, checking if the file exists, remove it or print an error on failure.
2019-08-09 11:45:30 +00:00
status->set_text(TTR("Redirect loop."));
-Made editor support SSL certs by default (embedded them) -Made asset sharing support https -Many fixes to HTTPRequest -Added an asset installer dialog -Visual cleanups to asset sharing tab -Fixed some issues in ScrollContainer, hope it does not break things -Asset sharing tab is not visible (hidden on purpose) for now.
2016-03-12 13:44:12 +00:00
} break;
Handle all download errors in the asset library Addresses part of #31115
2019-08-08 07:06:26 +00:00
case HTTPRequest::RESULT_TIMEOUT: {
error_text = TTR("Request failed, timeout");
status->set_text(TTR("Timeout."));
} break;
-Made editor support SSL certs by default (embedded them) -Made asset sharing support https -Many fixes to HTTPRequest -Added an asset installer dialog -Visual cleanups to asset sharing tab -Fixed some issues in ScrollContainer, hope it does not break things -Asset sharing tab is not visible (hidden on purpose) for now.
2016-03-12 13:44:12 +00:00
default: {
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
if (p_code != 200) {
i18n: Add more assetlib strings to translate Fixes #8463.
2017-04-20 12:42:35 +00:00
error_text = TTR("Request failed, return code:") + " " + itos(p_code);
status->set_text(TTR("Failed:") + " " + itos(p_code));
Replace String comparisons with "", String() to is_empty() Also: - Adds two stress tests to test_string.h - Changes to .empty() on std::strings
2021-12-09 09:42:46 +00:00
} else if (!sha256.is_empty()) {
Check hashes when downloading assets
2016-06-21 12:38:29 +00:00
String download_sha256 = FileAccess::get_sha256(download->get_download_file());
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
if (sha256 != download_sha256) {
i18n: Add more assetlib strings to translate Fixes #8463.
2017-04-20 12:42:35 +00:00
error_text = TTR("Bad download hash, assuming file has been tampered with.") + "\n";
error_text += TTR("Expected:") + " " + sha256 + "\n" + TTR("Got:") + " " + download_sha256;
Only display the assetlib Retry button if the download failed
2021-02-17 01:00:22 +00:00
status->set_text(TTR("Failed SHA-256 hash check"));
Check hashes when downloading assets
2016-06-21 12:38:29 +00:00
}
-Made editor support SSL certs by default (embedded them) -Made asset sharing support https -Many fixes to HTTPRequest -Added an asset installer dialog -Visual cleanups to asset sharing tab -Fixed some issues in ScrollContainer, hope it does not break things -Asset sharing tab is not visible (hidden on purpose) for now.
2016-03-12 13:44:12 +00:00
}
} break;
}
Replace String comparisons with "", String() to is_empty() Also: - Adds two stress tests to test_string.h - Changes to .empty() on std::strings
2021-12-09 09:42:46 +00:00
if (!error_text.is_empty()) {
i18n: Add more assetlib strings to translate Fixes #8463.
2017-04-20 12:42:35 +00:00
download_error->set_text(TTR("Asset Download Error:") + "\n" + error_text);
Working multiple window support, including editor
2020-03-06 17:00:16 +00:00
download_error->popup_centered();
Only display the assetlib Retry button if the download failed
2021-02-17 01:00:22 +00:00
// Let the user retry the download.
Make assets in progress open the next step instead of erring
2022-01-19 01:37:38 +00:00
retry_button->show();
-Made editor support SSL certs by default (embedded them) -Made asset sharing support https -Many fixes to HTTPRequest -Added an asset installer dialog -Visual cleanups to asset sharing tab -Fixed some issues in ScrollContainer, hope it does not break things -Asset sharing tab is not visible (hidden on purpose) for now.
2016-03-12 13:44:12 +00:00
return;
}
Make assets in progress open the next step instead of erring
2022-01-19 01:37:38 +00:00
install_button->set_disabled(false);
Fix Asset Library UX when an asset is being downloaded
2022-01-19 16:16:17 +00:00
status->set_text(TTR("Ready to install!"));
AssetLib minor fixes and enhancements
2019-08-28 04:27:26 +00:00
// Make the progress bar invisible but don't reflow other Controls around it.
Improve the asset library download UX The progress bar is now correctly set to 0% while initiating the download and is hidden once the download is completed.
2018-08-06 12:31:22 +00:00
progress->set_modulate(Color(0, 0, 0, 0));
-Made editor support SSL certs by default (embedded them) -Made asset sharing support https -Many fixes to HTTPRequest -Added an asset installer dialog -Visual cleanups to asset sharing tab -Fixed some issues in ScrollContainer, hope it does not break things -Asset sharing tab is not visible (hidden on purpose) for now.
2016-03-12 13:44:12 +00:00
set_process(false);
Automatically display the installer after downloading an asset - To make things easier to follow, display the asset name in confirmation dialogs. - Display the number of conflicting files in the asset extraction dialog. This reduces the number of clicks required to install an asset.
2021-04-06 15:37:55 +00:00
// Automatically prompt for installation once the download is completed.
Make assets in progress open the next step instead of erring
2022-01-19 01:37:38 +00:00
install();
-Made editor support SSL certs by default (embedded them) -Made asset sharing support https -Many fixes to HTTPRequest -Added an asset installer dialog -Visual cleanups to asset sharing tab -Fixed some issues in ScrollContainer, hope it does not break things -Asset sharing tab is not visible (hidden on purpose) for now.
2016-03-12 13:44:12 +00:00
}
Texture refactor -Texture renamed to Texture2D -TextureLayered as base now inherits 2Darray, cubemap and cubemap array -Removed all references to flags in textures (they will go in the shader) -Texture3D gone for now (will come back later done properly) -Create base rasterizer for RenderDevice, RasterizerRD
2019-06-11 18:43:37 +00:00
void EditorAssetLibraryItemDownload::configure(const String &p_title, int p_asset_id, const Ref<Texture2D> &p_preview, const String &p_download_url, const String &p_sha256_hash) {
-Made editor support SSL certs by default (embedded them) -Made asset sharing support https -Many fixes to HTTPRequest -Added an asset installer dialog -Visual cleanups to asset sharing tab -Fixed some issues in ScrollContainer, hope it does not break things -Asset sharing tab is not visible (hidden on purpose) for now.
2016-03-12 13:44:12 +00:00
title->set_text(p_title);
icon->set_texture(p_preview);
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
asset_id = p_asset_id;
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
if (!p_preview.is_valid()) {
Optimize StringName usage * Added a new macro SNAME() that constructs and caches a local stringname. * Subsequent usages use the cached version. * Since these use a global static variable, a second refcounter of static usages need to be kept for cleanup time. * Replaced all theme usages by this new macro. * Replace all signal emission usages by this new macro. * Replace all call_deferred usages by this new macro. This is part of ongoing work to optimize GUI and the editor.
2021-07-17 21:22:52 +00:00
icon->set_texture(get_theme_icon(SNAME("FileBrokenBigThumb"), SNAME("EditorIcons")));
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
}
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
host = p_download_url;
sha256 = p_sha256_hash;
Update asset library editor plugin - new functionality and fixes
2016-06-07 18:29:15 +00:00
_make_request();
-Made editor support SSL certs by default (embedded them) -Made asset sharing support https -Many fixes to HTTPRequest -Added an asset installer dialog -Visual cleanups to asset sharing tab -Fixed some issues in ScrollContainer, hope it does not break things -Asset sharing tab is not visible (hidden on purpose) for now.
2016-03-12 13:44:12 +00:00
}
Added asset library on project manager for templates
2016-06-08 12:25:47 +00:00
void EditorAssetLibraryItemDownload::_notification(int p_what) {
Minor improvements to the AssetLib
2019-07-17 05:26:53 +00:00
switch (p_what) {
Fix theming update in several editor classes
2022-01-16 07:59:02 +00:00
case NOTIFICATION_ENTER_TREE:
case NOTIFICATION_THEME_CHANGED: {
Revert "Add missing SNAME macro optimization to all theme methods call" This reverts commit a988fad9a092053434545c32afae91ccbdfbe792. As discussed in #57725 and clarified in #57788, `SNAME` is not meant to be used everywhere but only in critical code paths. For theme methods specifically, it was by design that only getters use `SNAME` and not setters.
2022-02-08 09:14:58 +00:00
panel->add_theme_style_override("panel", get_theme_stylebox(SNAME("panel"), SNAME("AssetLib")));
status->add_theme_color_override("font_color", get_theme_color(SNAME("status_color"), SNAME("AssetLib")));
Make assets in progress open the next step instead of erring
2022-01-19 01:37:38 +00:00
dismiss_button->set_normal_texture(get_theme_icon(SNAME("dismiss"), SNAME("AssetLib")));
Minor improvements to the AssetLib
2019-07-17 05:26:53 +00:00
} break;
Update if == NOTIFICATION_* to switch statements to match coding style
2022-02-16 02:44:22 +00:00
Minor improvements to the AssetLib
2019-07-17 05:26:53 +00:00
case NOTIFICATION_PROCESS: {
// Make the progress bar visible again when retrying the download.
progress->set_modulate(Color(1, 1, 1, 1));
shows progress (bytes) on download even if getting chunked content
2016-07-24 17:37:26 +00:00
Minor improvements to the AssetLib
2019-07-17 05:26:53 +00:00
if (download->get_downloaded_bytes() > 0) {
progress->set_max(download->get_body_size());
progress->set_value(download->get_downloaded_bytes());
Fix occasional crash when downloading assets from the Asset Library This is caused by GitHub not publishing a Content-Length header in all cases (it only does so if the file was requested recently), which in turn made `String.humanize_size()` try to humanize a size of -1 byte (as returned by HTTPRequest when no Content-Length is contained in the response). This crashed the editor due to a division by zero. This closes #21200.
2018-08-20 18:21:56 +00:00
}
shows progress (bytes) on download even if getting chunked content
2016-07-24 17:37:26 +00:00
Minor improvements to the AssetLib
2019-07-17 05:26:53 +00:00
int cstatus = download->get_http_client_status();
if (cstatus == HTTPClient::STATUS_BODY) {
if (download->get_body_size() > 0) {
status->set_text(vformat(
TTR("Downloading (%s / %s)..."),
String::humanize_size(download->get_downloaded_bytes()),
String::humanize_size(download->get_body_size())));
} else {
// Total file size is unknown, so it cannot be displayed.
AssetLibrary when the download size is unknown: hidden progress bar added in the description the downloaded bytes Fixes #35267
2020-01-18 11:51:20 +00:00
progress->set_modulate(Color(0, 0, 0, 0));
status->set_text(vformat(
TTR("Downloading...") + " (%s)",
String::humanize_size(download->get_downloaded_bytes())));
Minor improvements to the AssetLib
2019-07-17 05:26:53 +00:00
}
}
-Made editor support SSL certs by default (embedded them) -Made asset sharing support https -Many fixes to HTTPRequest -Added an asset installer dialog -Visual cleanups to asset sharing tab -Fixed some issues in ScrollContainer, hope it does not break things -Asset sharing tab is not visible (hidden on purpose) for now.
2016-03-12 13:44:12 +00:00
Minor improvements to the AssetLib
2019-07-17 05:26:53 +00:00
if (cstatus != prev_status) {
switch (cstatus) {
case HTTPClient::STATUS_RESOLVING: {
status->set_text(TTR("Resolving..."));
progress->set_max(1);
progress->set_value(0);
} break;
case HTTPClient::STATUS_CONNECTING: {
status->set_text(TTR("Connecting..."));
progress->set_max(1);
progress->set_value(0);
} break;
case HTTPClient::STATUS_REQUESTING: {
status->set_text(TTR("Requesting..."));
progress->set_max(1);
progress->set_value(0);
} break;
default: {
}
Style: Apply new changes from clang-format 8.0 It seems to stay compatible with formatting done by clang-format 6.0 and 7.0, so contributors can keep using those versions for now (they will not undo those changes).
2019-04-09 15:08:36 +00:00
}
Minor improvements to the AssetLib
2019-07-17 05:26:53 +00:00
prev_status = cstatus;
-Made editor support SSL certs by default (embedded them) -Made asset sharing support https -Many fixes to HTTPRequest -Added an asset installer dialog -Visual cleanups to asset sharing tab -Fixed some issues in ScrollContainer, hope it does not break things -Asset sharing tab is not visible (hidden on purpose) for now.
2016-03-12 13:44:12 +00:00
}
Minor improvements to the AssetLib
2019-07-17 05:26:53 +00:00
} break;
-Made editor support SSL certs by default (embedded them) -Made asset sharing support https -Many fixes to HTTPRequest -Added an asset installer dialog -Visual cleanups to asset sharing tab -Fixed some issues in ScrollContainer, hope it does not break things -Asset sharing tab is not visible (hidden on purpose) for now.
2016-03-12 13:44:12 +00:00
}
}
Style: Enforce separation line between function definitions I couldn't find a tool that enforces it, so I went the manual route: ``` find -name "thirdparty" -prune \ -o -name "*.cpp" -o -name "*.h" -o -name "*.m" -o -name "*.mm" \ -o -name "*.glsl" > files perl -0777 -pi -e 's/\n}\n([^#])/\n}\n\n\1/g' $(cat files) misc/scripts/fix_style.sh -c ``` This adds a newline after all `}` on the first column, unless they are followed by `#` (typically `#endif`). This leads to having lots of places with two lines between function/class definitions, but clang-format then fixes it as we enforce max one line of separation. This doesn't fix potential occurrences of function definitions which are indented (e.g. for a helper class defined in a .cpp), but it's better than nothing. Also can't be made to run easily on CI/hooks so we'll have to be careful with new code. Part of #33027.
2020-05-14 12:29:06 +00:00
Added asset library on project manager for templates
2016-06-08 12:25:47 +00:00
void EditorAssetLibraryItemDownload::_close() {
Export: Remove temp files from cache after export So far we left most temporary files lying around, so this attempts to fix that. I added a helper method to DirAccess to factor out the boilerplate of creating a DirAccess, checking if the file exists, remove it or print an error on failure.
2019-08-09 11:45:30 +00:00
// Clean up downloaded file.
DirAccess::remove_file_or_error(download->get_download_file());
-Made editor support SSL certs by default (embedded them) -Made asset sharing support https -Many fixes to HTTPRequest -Added an asset installer dialog -Visual cleanups to asset sharing tab -Fixed some issues in ScrollContainer, hope it does not break things -Asset sharing tab is not visible (hidden on purpose) for now.
2016-03-12 13:44:12 +00:00
queue_delete();
}
Fix Asset Library UX when an asset is being downloaded
2022-01-19 16:16:17 +00:00
bool EditorAssetLibraryItemDownload::can_install() const {
return !install_button->is_disabled();
}
Make assets in progress open the next step instead of erring
2022-01-19 01:37:38 +00:00
void EditorAssetLibraryItemDownload::install() {
-Made editor support SSL certs by default (embedded them) -Made asset sharing support https -Many fixes to HTTPRequest -Added an asset installer dialog -Visual cleanups to asset sharing tab -Fixed some issues in ScrollContainer, hope it does not break things -Asset sharing tab is not visible (hidden on purpose) for now.
2016-03-12 13:44:12 +00:00
String file = download->get_download_file();
Downloaded templates from project manager can now be installed.
2016-07-12 00:34:02 +00:00
if (external_install) {
Optimize StringName usage * Added a new macro SNAME() that constructs and caches a local stringname. * Subsequent usages use the cached version. * Since these use a global static variable, a second refcounter of static usages need to be kept for cleanup time. * Replaced all theme usages by this new macro. * Replace all signal emission usages by this new macro. * Replace all call_deferred usages by this new macro. This is part of ongoing work to optimize GUI and the editor.
2021-07-17 21:22:52 +00:00
emit_signal(SNAME("install_asset"), file, title->get_text());
Downloaded templates from project manager can now be installed.
2016-07-12 00:34:02 +00:00
return;
}
Automatically display the installer after downloading an asset - To make things easier to follow, display the asset name in confirmation dialogs. - Display the number of conflicting files in the asset extraction dialog. This reduces the number of clicks required to install an asset.
2021-04-06 15:37:55 +00:00
asset_installer->set_asset_name(title->get_text());
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
asset_installer->open(file, 1);
-Made editor support SSL certs by default (embedded them) -Made asset sharing support https -Many fixes to HTTPRequest -Added an asset installer dialog -Visual cleanups to asset sharing tab -Fixed some issues in ScrollContainer, hope it does not break things -Asset sharing tab is not visible (hidden on purpose) for now.
2016-03-12 13:44:12 +00:00
}
Added asset library on project manager for templates
2016-06-08 12:25:47 +00:00
void EditorAssetLibraryItemDownload::_make_request() {
Only display the assetlib Retry button if the download failed
2021-02-17 01:00:22 +00:00
// Hide the Retry button if we've just pressed it.
Make assets in progress open the next step instead of erring
2022-01-19 01:37:38 +00:00
retry_button->hide();
Only display the assetlib Retry button if the download failed
2021-02-17 01:00:22 +00:00
Update asset library editor plugin - new functionality and fixes
2016-06-07 18:29:15 +00:00
download->cancel_request();
Implement shader caching * Shader compilation is now cached. Subsequent loads take less than a millisecond. * Improved game, editor and project manager startup time. * Editor uses .godot/shader_cache to store shaders. * Game uses user://shader_cache * Project manager uses $config_dir/shader_cache * Options to tweak shader caching in project settings. * Editor path configuration moved from EditorSettings to new class, EditorPaths, so it can be available early on (before shaders are compiled). * Reworked ShaderCompilerRD to ensure deterministic shader code creation (else shader may change and cache will be invalidated). * Added shader compression with SMOLV: https://github.com/aras-p/smol-v
2021-05-25 00:25:11 +00:00
download->set_download_file(EditorPaths::get_singleton()->get_cache_dir().plus_file("tmp_asset_" + itos(asset_id)) + ".zip");
Add thread support to HTTPRequest, changed assetlib to use it.
2016-07-24 19:09:43 +00:00
Update asset library editor plugin - new functionality and fixes
2016-06-07 18:29:15 +00:00
Error err = download->request(host);
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
if (err != OK) {
i18n: Add more assetlib strings to translate Fixes #8463.
2017-04-20 12:42:35 +00:00
status->set_text(TTR("Error making request"));
Update asset library editor plugin - new functionality and fixes
2016-06-07 18:29:15 +00:00
} else {
set_process(true);
}
}
Added asset library on project manager for templates
2016-06-08 12:25:47 +00:00
void EditorAssetLibraryItemDownload::_bind_methods() {
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
ADD_SIGNAL(MethodInfo("install_asset", PropertyInfo(Variant::STRING, "zip_path"), PropertyInfo(Variant::STRING, "name")));
-Made editor support SSL certs by default (embedded them) -Made asset sharing support https -Many fixes to HTTPRequest -Added an asset installer dialog -Visual cleanups to asset sharing tab -Fixed some issues in ScrollContainer, hope it does not break things -Asset sharing tab is not visible (hidden on purpose) for now.
2016-03-12 13:44:12 +00:00
}
Added asset library on project manager for templates
2016-06-08 12:25:47 +00:00
EditorAssetLibraryItemDownload::EditorAssetLibraryItemDownload() {
Fix assetlib crash
2022-01-16 16:40:14 +00:00
panel = memnew(PanelContainer);
add_child(panel);
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
HBoxContainer *hb = memnew(HBoxContainer);
Fix assetlib crash
2022-01-16 16:40:14 +00:00
panel->add_child(hb);
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
icon = memnew(TextureRect);
Make assets in progress open the next step instead of erring
2022-01-19 01:37:38 +00:00
icon->set_stretch_mode(TextureRect::STRETCH_KEEP_ASPECT_CENTERED);
icon->set_v_size_flags(0);
-Made editor support SSL certs by default (embedded them) -Made asset sharing support https -Many fixes to HTTPRequest -Added an asset installer dialog -Visual cleanups to asset sharing tab -Fixed some issues in ScrollContainer, hope it does not break things -Asset sharing tab is not visible (hidden on purpose) for now.
2016-03-12 13:44:12 +00:00
hb->add_child(icon);
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
VBoxContainer *vb = memnew(VBoxContainer);
-Made editor support SSL certs by default (embedded them) -Made asset sharing support https -Many fixes to HTTPRequest -Added an asset installer dialog -Visual cleanups to asset sharing tab -Fixed some issues in ScrollContainer, hope it does not break things -Asset sharing tab is not visible (hidden on purpose) for now.
2016-03-12 13:44:12 +00:00
hb->add_child(vb);
Working multiple window support, including editor
2020-03-06 17:00:16 +00:00
vb->set_h_size_flags(Control::SIZE_EXPAND_FILL);
-Made editor support SSL certs by default (embedded them) -Made asset sharing support https -Many fixes to HTTPRequest -Added an asset installer dialog -Visual cleanups to asset sharing tab -Fixed some issues in ScrollContainer, hope it does not break things -Asset sharing tab is not visible (hidden on purpose) for now.
2016-03-12 13:44:12 +00:00
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
HBoxContainer *title_hb = memnew(HBoxContainer);
-Made editor support SSL certs by default (embedded them) -Made asset sharing support https -Many fixes to HTTPRequest -Added an asset installer dialog -Visual cleanups to asset sharing tab -Fixed some issues in ScrollContainer, hope it does not break things -Asset sharing tab is not visible (hidden on purpose) for now.
2016-03-12 13:44:12 +00:00
vb->add_child(title_hb);
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
title = memnew(Label);
-Made editor support SSL certs by default (embedded them) -Made asset sharing support https -Many fixes to HTTPRequest -Added an asset installer dialog -Visual cleanups to asset sharing tab -Fixed some issues in ScrollContainer, hope it does not break things -Asset sharing tab is not visible (hidden on purpose) for now.
2016-03-12 13:44:12 +00:00
title_hb->add_child(title);
Working multiple window support, including editor
2020-03-06 17:00:16 +00:00
title->set_h_size_flags(Control::SIZE_EXPAND_FILL);
-Made editor support SSL certs by default (embedded them) -Made asset sharing support https -Many fixes to HTTPRequest -Added an asset installer dialog -Visual cleanups to asset sharing tab -Fixed some issues in ScrollContainer, hope it does not break things -Asset sharing tab is not visible (hidden on purpose) for now.
2016-03-12 13:44:12 +00:00
Make assets in progress open the next step instead of erring
2022-01-19 01:37:38 +00:00
dismiss_button = memnew(TextureButton);
dismiss_button->connect("pressed", callable_mp(this, &EditorAssetLibraryItemDownload::_close));
title_hb->add_child(dismiss_button);
-Made editor support SSL certs by default (embedded them) -Made asset sharing support https -Many fixes to HTTPRequest -Added an asset installer dialog -Visual cleanups to asset sharing tab -Fixed some issues in ScrollContainer, hope it does not break things -Asset sharing tab is not visible (hidden on purpose) for now.
2016-03-12 13:44:12 +00:00
title->set_clip_text(true);
vb->add_spacer();
i18n: Add more assetlib strings to translate Fixes #8463.
2017-04-20 12:42:35 +00:00
status = memnew(Label(TTR("Idle")));
-Made editor support SSL certs by default (embedded them) -Made asset sharing support https -Many fixes to HTTPRequest -Added an asset installer dialog -Visual cleanups to asset sharing tab -Fixed some issues in ScrollContainer, hope it does not break things -Asset sharing tab is not visible (hidden on purpose) for now.
2016-03-12 13:44:12 +00:00
vb->add_child(status);
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
progress = memnew(ProgressBar);
-Made editor support SSL certs by default (embedded them) -Made asset sharing support https -Many fixes to HTTPRequest -Added an asset installer dialog -Visual cleanups to asset sharing tab -Fixed some issues in ScrollContainer, hope it does not break things -Asset sharing tab is not visible (hidden on purpose) for now.
2016-03-12 13:44:12 +00:00
vb->add_child(progress);
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
HBoxContainer *hb2 = memnew(HBoxContainer);
-Made editor support SSL certs by default (embedded them) -Made asset sharing support https -Many fixes to HTTPRequest -Added an asset installer dialog -Visual cleanups to asset sharing tab -Fixed some issues in ScrollContainer, hope it does not break things -Asset sharing tab is not visible (hidden on purpose) for now.
2016-03-12 13:44:12 +00:00
vb->add_child(hb2);
hb2->add_spacer();
Make assets in progress open the next step instead of erring
2022-01-19 01:37:38 +00:00
install_button = memnew(Button);
install_button->set_text(TTR("Install..."));
install_button->set_disabled(true);
install_button->connect("pressed", callable_mp(this, &EditorAssetLibraryItemDownload::install));
-Made editor support SSL certs by default (embedded them) -Made asset sharing support https -Many fixes to HTTPRequest -Added an asset installer dialog -Visual cleanups to asset sharing tab -Fixed some issues in ScrollContainer, hope it does not break things -Asset sharing tab is not visible (hidden on purpose) for now.
2016-03-12 13:44:12 +00:00
Make assets in progress open the next step instead of erring
2022-01-19 01:37:38 +00:00
retry_button = memnew(Button);
retry_button->set_text(TTR("Retry"));
retry_button->connect("pressed", callable_mp(this, &EditorAssetLibraryItemDownload::_make_request));
Only display the assetlib Retry button if the download failed
2021-02-17 01:00:22 +00:00
// Only show the Retry button in case of a failure.
Make assets in progress open the next step instead of erring
2022-01-19 01:37:38 +00:00
retry_button->hide();
Update asset library editor plugin - new functionality and fixes
2016-06-07 18:29:15 +00:00
Make assets in progress open the next step instead of erring
2022-01-19 01:37:38 +00:00
hb2->add_child(retry_button);
hb2->add_child(install_button);
Add spacing between the icon and details in the assetlib list This also scales margin and separation values on hiDPI displays.
2019-06-11 23:13:07 +00:00
set_custom_minimum_size(Size2(310, 0) * EDSCALE);
-Made editor support SSL certs by default (embedded them) -Made asset sharing support https -Many fixes to HTTPRequest -Added an asset installer dialog -Visual cleanups to asset sharing tab -Fixed some issues in ScrollContainer, hope it does not break things -Asset sharing tab is not visible (hidden on purpose) for now.
2016-03-12 13:44:12 +00:00
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
download = memnew(HTTPRequest);
Fix assetlib crash
2022-01-16 16:40:14 +00:00
panel->add_child(download);
Signals: Port connect calls to use callable_mp Remove now unnecessary bindings of signal callbacks in the public API. There might be some false positives that need rebinding if they were meant to be public. No regular expressions were harmed in the making of this commit. (Nah, just kidding.)
2020-02-21 17:28:45 +00:00
download->connect("request_completed", callable_mp(this, &EditorAssetLibraryItemDownload::_http_download_completed));
Add proxy support for the editor * Adds proxy support for `HTTPRequest`. * Adds `network/http_proxy/{host,port}` editor settings. * Labeled as "HTTP Proxy" and it will be used for both HTTP and HTTPS requests. This is the same convention as seen in Android Studio's proxy settings. * Makes Asset Library and Export Template Manager use proxy according to the editor settings.
2021-12-09 03:34:32 +00:00
setup_http_request(download);
-Made editor support SSL certs by default (embedded them) -Made asset sharing support https -Many fixes to HTTPRequest -Added an asset installer dialog -Visual cleanups to asset sharing tab -Fixed some issues in ScrollContainer, hope it does not break things -Asset sharing tab is not visible (hidden on purpose) for now.
2016-03-12 13:44:12 +00:00
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
download_error = memnew(AcceptDialog);
Fix assetlib crash
2022-01-16 16:40:14 +00:00
panel->add_child(download_error);
i18n: Add more assetlib strings to translate Fixes #8463.
2017-04-20 12:42:35 +00:00
download_error->set_title(TTR("Download Error"));
-Made editor support SSL certs by default (embedded them) -Made asset sharing support https -Many fixes to HTTPRequest -Added an asset installer dialog -Visual cleanups to asset sharing tab -Fixed some issues in ScrollContainer, hope it does not break things -Asset sharing tab is not visible (hidden on purpose) for now.
2016-03-12 13:44:12 +00:00
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
asset_installer = memnew(EditorAssetInstaller);
Fix assetlib crash
2022-01-16 16:40:14 +00:00
panel->add_child(asset_installer);
Signals: Port connect calls to use callable_mp Remove now unnecessary bindings of signal callbacks in the public API. There might be some false positives that need rebinding if they were meant to be public. No regular expressions were harmed in the making of this commit. (Nah, just kidding.)
2020-02-21 17:28:45 +00:00
asset_installer->connect("confirmed", callable_mp(this, &EditorAssetLibraryItemDownload::_close));
-Made editor support SSL certs by default (embedded them) -Made asset sharing support https -Many fixes to HTTPRequest -Added an asset installer dialog -Visual cleanups to asset sharing tab -Fixed some issues in ScrollContainer, hope it does not break things -Asset sharing tab is not visible (hidden on purpose) for now.
2016-03-12 13:44:12 +00:00
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
prev_status = -1;
-Made editor support SSL certs by default (embedded them) -Made asset sharing support https -Many fixes to HTTPRequest -Added an asset installer dialog -Visual cleanups to asset sharing tab -Fixed some issues in ScrollContainer, hope it does not break things -Asset sharing tab is not visible (hidden on purpose) for now.
2016-03-12 13:44:12 +00:00
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
external_install = false;
-Made editor support SSL certs by default (embedded them) -Made asset sharing support https -Many fixes to HTTPRequest -Added an asset installer dialog -Visual cleanups to asset sharing tab -Fixed some issues in ScrollContainer, hope it does not break things -Asset sharing tab is not visible (hidden on purpose) for now.
2016-03-12 13:44:12 +00:00
}
-Work on addon editor plugin (disabled by default) -New HTTPRequest node, to make HTTP requests simpler.
2016-03-04 14:09:45 +00:00
////////////////////////////////////////////////////////////////////////////////
Added asset library on project manager for templates
2016-06-08 12:25:47 +00:00
void EditorAssetLibrary::_notification(int p_what) {
fixed loading old theme styleboxes
2017-08-04 19:41:31 +00:00
switch (p_what) {
case NOTIFICATION_READY: {
Fix theming update in several editor classes
2022-01-16 07:59:02 +00:00
error_label->raise();
} break;
Update if == NOTIFICATION_* to switch statements to match coding style
2022-02-16 02:44:22 +00:00
Fix theming update in several editor classes
2022-01-16 07:59:02 +00:00
case NOTIFICATION_ENTER_TREE:
case NOTIFICATION_THEME_CHANGED: {
Optimize StringName usage * Added a new macro SNAME() that constructs and caches a local stringname. * Subsequent usages use the cached version. * Since these use a global static variable, a second refcounter of static usages need to be kept for cleanup time. * Replaced all theme usages by this new macro. * Replace all signal emission usages by this new macro. * Replace all call_deferred usages by this new macro. This is part of ongoing work to optimize GUI and the editor.
2021-07-17 21:22:52 +00:00
error_tr->set_texture(get_theme_icon(SNAME("Error"), SNAME("EditorIcons")));
filter->set_right_icon(get_theme_icon(SNAME("Search"), SNAME("EditorIcons")));
Revert "Add missing SNAME macro optimization to all theme methods call" This reverts commit a988fad9a092053434545c32afae91ccbdfbe792. As discussed in #57725 and clarified in #57788, `SNAME` is not meant to be used everywhere but only in critical code paths. For theme methods specifically, it was by design that only getters use `SNAME` and not setters.
2022-02-08 09:14:58 +00:00
library_scroll_bg->add_theme_style_override("panel", get_theme_stylebox(SNAME("bg"), SNAME("Tree")));
downloads_scroll->add_theme_style_override("bg", get_theme_stylebox(SNAME("bg"), SNAME("Tree")));
error_label->add_theme_color_override("color", get_theme_color(SNAME("error_color"), SNAME("Editor")));
fixed loading old theme styleboxes
2017-08-04 19:41:31 +00:00
} break;
Update if == NOTIFICATION_* to switch statements to match coding style
2022-02-16 02:44:22 +00:00
fixed loading old theme styleboxes
2017-08-04 19:41:31 +00:00
case NOTIFICATION_VISIBILITY_CHANGED: {
Automatically focus the Search field when displaying asset library - Focus the project search box when switching from the Templates tab back to the Projects tab in the project manager. - Add a context-specific placeholder for the asset library search box. - Rename "Search" project filter box placeholder to the more descriptive "Filter projects". When performing a search on an existing selection, "Filter" is more accurate than "Search".
2021-04-04 20:47:44 +00:00
if (is_visible()) {
// Focus the search box automatically when switching to the Templates tab (in the Project Manager)
// or switching to the AssetLib tab (in the editor).
// The Project Manager's project filter box is automatically focused in the project manager code.
filter->grab_focus();
if (initial_loading) {
_repository_changed(0); // Update when shown for the first time.
}
fixed loading old theme styleboxes
2017-08-04 19:41:31 +00:00
}
} break;
Update if == NOTIFICATION_* to switch statements to match coding style
2022-02-16 02:44:22 +00:00
fixed loading old theme styleboxes
2017-08-04 19:41:31 +00:00
case NOTIFICATION_PROCESS: {
HTTPClient::Status s = request->get_http_client_status();
Improve loading UX in the asset library The asset library will now fade when loading pages instead of displaying a progress bar, which is a more common design pattern when browsing an online resource's pages. A "Loading..." text will be displayed before the first page loads.
2019-08-24 01:04:59 +00:00
const bool loading = s != HTTPClient::STATUS_DISCONNECTED;
-more progress to asset sharing client, but still disabled by default
2016-03-05 15:24:12 +00:00
Improve loading UX in the asset library The asset library will now fade when loading pages instead of displaying a progress bar, which is a more common design pattern when browsing an online resource's pages. A "Loading..." text will be displayed before the first page loads.
2019-08-24 01:04:59 +00:00
if (loading) {
library_scroll->set_modulate(Color(1, 1, 1, 0.5));
} else {
library_scroll->set_modulate(Color(1, 1, 1, 1));
fixed loading old theme styleboxes
2017-08-04 19:41:31 +00:00
}
Improve loading UX in the asset library The asset library will now fade when loading pages instead of displaying a progress bar, which is a more common design pattern when browsing an online resource's pages. A "Loading..." text will be displayed before the first page loads.
2019-08-24 01:04:59 +00:00
const bool no_downloads = downloads_hb->get_child_count() == 0;
fixed loading old theme styleboxes
2017-08-04 19:41:31 +00:00
if (no_downloads == downloads_scroll->is_visible()) {
downloads_scroll->set_visible(!no_downloads);
}
} break;
Update if == NOTIFICATION_* to switch statements to match coding style
2022-02-16 02:44:22 +00:00
Fix Asset Library URL not updating after been changed in editor settings The changes made in this commit refresh the URL OptionButton when editor settings are modified. No need to restart any more for the changes to appear in the Asset Library. Fix #46977
2021-03-13 21:55:59 +00:00
case EditorSettings::NOTIFICATION_EDITOR_SETTINGS_CHANGED: {
_update_repository_options();
Update AssetLib network settings when Editor Settings change
2022-01-21 07:42:05 +00:00
setup_http_request(request);
Fix Asset Library URL not updating after been changed in editor settings The changes made in this commit refresh the URL OptionButton when editor settings are modified. No need to restart any more for the changes to appear in the Asset Library. Fix #46977
2021-03-13 21:55:59 +00:00
} break;
}
}
void EditorAssetLibrary::_update_repository_options() {
Dictionary default_urls;
Clarify the purpose of the default asset library URLs in the editor `localhost` was removed as it won't work out of the box. It can be added by the user if they're working on the asset library itself. This won't affect existing installations due to how the editor settings are stored, but existing installations will keep working fine.
2021-07-23 10:53:19 +00:00
default_urls["godotengine.org (Official)"] = "https://godotengine.org/asset-library/api";
Fix Asset Library URL not updating after been changed in editor settings The changes made in this commit refresh the URL OptionButton when editor settings are modified. No need to restart any more for the changes to appear in the Asset Library. Fix #46977
2021-03-13 21:55:59 +00:00
Dictionary available_urls = _EDITOR_DEF("asset_library/available_urls", default_urls, true);
repository->clear();
Array keys = available_urls.keys();
Use C++ iterators for Lists in many situations
2021-07-16 03:45:57 +00:00
for (int i = 0; i < keys.size(); i++) {
Fix Asset Library URL not updating after been changed in editor settings The changes made in this commit refresh the URL OptionButton when editor settings are modified. No need to restart any more for the changes to appear in the Asset Library. Fix #46977
2021-03-13 21:55:59 +00:00
String key = keys[i];
repository->add_item(key);
repository->set_item_metadata(i, available_urls[key]);
-Work on addon editor plugin (disabled by default) -New HTTPRequest node, to make HTTP requests simpler.
2016-03-04 14:09:45 +00:00
}
}
Entirely removes BIND_VMETHOD in favor of GDVIRTUAL * `_gui_input`, `_input`, `_unhandled_input` and `_unhandled_key_input` are now regular C++ virutal functions. * Everything else converted to GDVIRTUAL * BIND_VMETHOD is gone, always use the new syntax from now on. Creating `_gui_input` method and using the binder to register events will no longer work, simply override the virtual function now.
2021-08-22 15:37:22 +00:00
void EditorAssetLibrary::unhandled_key_input(const Ref<InputEvent> &p_event) {
Fix crashes in *_input functions
2021-04-05 06:52:21 +00:00
ERR_FAIL_COND(p_event.is_null());
Make Ctrl+F focus the editor asset library's search field
2019-11-21 23:39:39 +00:00
const Ref<InputEventKey> key = p_event;
if (key.is_valid() && key->is_pressed()) {
Use "enum class" for input enums
2021-08-13 21:31:57 +00:00
if (key->get_keycode_with_modifiers() == (KeyModifierMask::CMD | Key::F) && is_visible_in_tree()) {
Make Ctrl+F focus the editor asset library's search field
2019-11-21 23:39:39 +00:00
filter->grab_focus();
filter->select_all();
accept_event();
}
}
}
Added asset library on project manager for templates
2016-06-08 12:25:47 +00:00
void EditorAssetLibrary::_install_asset() {
-Made editor support SSL certs by default (embedded them) -Made asset sharing support https -Many fixes to HTTPRequest -Added an asset installer dialog -Visual cleanups to asset sharing tab -Fixed some issues in ScrollContainer, hope it does not break things -Asset sharing tab is not visible (hidden on purpose) for now.
2016-03-12 13:44:12 +00:00
ERR_FAIL_COND(!description);
Make assets in progress open the next step instead of erring
2022-01-19 01:37:38 +00:00
EditorAssetLibraryItemDownload *d = _get_asset_in_progress(description->get_asset_id());
if (d) {
d->install();
return;
-Made editor support SSL certs by default (embedded them) -Made asset sharing support https -Many fixes to HTTPRequest -Added an asset installer dialog -Visual cleanups to asset sharing tab -Fixed some issues in ScrollContainer, hope it does not break things -Asset sharing tab is not visible (hidden on purpose) for now.
2016-03-12 13:44:12 +00:00
}
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
EditorAssetLibraryItemDownload *download = memnew(EditorAssetLibraryItemDownload);
-Made editor support SSL certs by default (embedded them) -Made asset sharing support https -Many fixes to HTTPRequest -Added an asset installer dialog -Visual cleanups to asset sharing tab -Fixed some issues in ScrollContainer, hope it does not break things -Asset sharing tab is not visible (hidden on purpose) for now.
2016-03-12 13:44:12 +00:00
downloads_hb->add_child(download);
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
download->configure(description->get_title(), description->get_asset_id(), description->get_preview_icon(), description->get_download_url(), description->get_sha256());
-Made editor support SSL certs by default (embedded them) -Made asset sharing support https -Many fixes to HTTPRequest -Added an asset installer dialog -Visual cleanups to asset sharing tab -Fixed some issues in ScrollContainer, hope it does not break things -Asset sharing tab is not visible (hidden on purpose) for now.
2016-03-12 13:44:12 +00:00
Downloaded templates from project manager can now be installed.
2016-07-12 00:34:02 +00:00
if (templates_only) {
download->set_external_install(true);
Signals: Port connect calls to use callable_mp Remove now unnecessary bindings of signal callbacks in the public API. There might be some false positives that need rebinding if they were meant to be public. No regular expressions were harmed in the making of this commit. (Nah, just kidding.)
2020-02-21 17:28:45 +00:00
download->connect("install_asset", callable_mp(this, &EditorAssetLibrary::_install_external_asset));
Downloaded templates from project manager can now be installed.
2016-07-12 00:34:02 +00:00
}
-Made editor support SSL certs by default (embedded them) -Made asset sharing support https -Many fixes to HTTPRequest -Added an asset installer dialog -Visual cleanups to asset sharing tab -Fixed some issues in ScrollContainer, hope it does not break things -Asset sharing tab is not visible (hidden on purpose) for now.
2016-03-12 13:44:12 +00:00
}
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
const char *EditorAssetLibrary::sort_key[SORT_MAX] = {
Improve sorting options in the asset library The reverse sorting options are now integrated in the list of sorting options, making the "Reverse" button unnecessary. This pattern tends to be easier to discover by users. The "Downloads" sorting option was also removed as it's not implemented in the backend.
2019-08-24 02:53:14 +00:00
"updated",
"updated",
-Work on addon editor plugin (disabled by default) -New HTTPRequest node, to make HTTP requests simpler.
2016-03-04 14:09:45 +00:00
"name",
Improve sorting options in the asset library The reverse sorting options are now integrated in the list of sorting options, making the "Reverse" button unnecessary. This pattern tends to be easier to discover by users. The "Downloads" sorting option was also removed as it's not implemented in the backend.
2019-08-24 02:53:14 +00:00
"name",
"cost",
-Work on addon editor plugin (disabled by default) -New HTTPRequest node, to make HTTP requests simpler.
2016-03-04 14:09:45 +00:00
"cost",
};
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
const char *EditorAssetLibrary::sort_text[SORT_MAX] = {
Make more editor strings translatable
2019-12-13 08:07:45 +00:00
TTRC("Recently Updated"),
TTRC("Least Recently Updated"),
TTRC("Name (A-Z)"),
TTRC("Name (Z-A)"),
TTRC("License (A-Z)"), // "cost" stores the SPDX license name in the Godot Asset Library.
TTRC("License (Z-A)"), // "cost" stores the SPDX license name in the Godot Asset Library.
-Work on addon editor plugin (disabled by default) -New HTTPRequest node, to make HTTP requests simpler.
2016-03-04 14:09:45 +00:00
};
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
const char *EditorAssetLibrary::support_key[SUPPORT_MAX] = {
Add support levels to search
2016-06-21 13:29:49 +00:00
"official",
"community",
Improve sorting options in the asset library The reverse sorting options are now integrated in the list of sorting options, making the "Reverse" button unnecessary. This pattern tends to be easier to discover by users. The "Downloads" sorting option was also removed as it's not implemented in the backend.
2019-08-24 02:53:14 +00:00
"testing",
Add support levels to search
2016-06-21 13:29:49 +00:00
};
Added asset library on project manager for templates
2016-06-08 12:25:47 +00:00
void EditorAssetLibrary::_select_author(int p_id) {
AssetLib minor fixes and enhancements
2019-08-28 04:27:26 +00:00
// Open author window.
-Work on addon editor plugin (disabled by default) -New HTTPRequest node, to make HTTP requests simpler.
2016-03-04 14:09:45 +00:00
}
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
void EditorAssetLibrary::_select_category(int p_id) {
for (int i = 0; i < categories->get_item_count(); i++) {
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
if (i == 0) {
-Work on addon editor plugin (disabled by default) -New HTTPRequest node, to make HTTP requests simpler.
2016-03-04 14:09:45 +00:00
continue;
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
}
-Work on addon editor plugin (disabled by default) -New HTTPRequest node, to make HTTP requests simpler.
2016-03-04 14:09:45 +00:00
int id = categories->get_item_metadata(i);
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
if (id == p_id) {
-Work on addon editor plugin (disabled by default) -New HTTPRequest node, to make HTTP requests simpler.
2016-03-04 14:09:45 +00:00
categories->select(i);
_search();
break;
}
}
}
Style: Enforce separation line between function definitions I couldn't find a tool that enforces it, so I went the manual route: ``` find -name "thirdparty" -prune \ -o -name "*.cpp" -o -name "*.h" -o -name "*.m" -o -name "*.mm" \ -o -name "*.glsl" > files perl -0777 -pi -e 's/\n}\n([^#])/\n}\n\n\1/g' $(cat files) misc/scripts/fix_style.sh -c ``` This adds a newline after all `}` on the first column, unless they are followed by `#` (typically `#endif`). This leads to having lots of places with two lines between function/class definitions, but clang-format then fixes it as we enforce max one line of separation. This doesn't fix potential occurrences of function definitions which are indented (e.g. for a helper class defined in a .cpp), but it's better than nothing. Also can't be made to run easily on CI/hooks so we'll have to be careful with new code. Part of #33027.
2020-05-14 12:29:06 +00:00
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
void EditorAssetLibrary::_select_asset(int p_id) {
_api_request("asset/" + itos(p_id), REQUESTING_ASSET);
-Work on addon editor plugin (disabled by default) -New HTTPRequest node, to make HTTP requests simpler.
2016-03-04 14:09:45 +00:00
}
PoolVector is gone, replaced by Vector Typed `PoolTypeArray` types are now renamed `PackedTypeArray` and are sugar for `Vector<Type>`.
2020-02-17 21:06:54 +00:00
void EditorAssetLibrary::_image_update(bool use_cache, bool final, const PackedByteArray &p_data, int p_queue_id) {
Update asset library editor plugin - new functionality and fixes
2016-06-07 18:29:15 +00:00
Object *obj = ObjectDB::get_instance(image_queue[p_queue_id].target);
if (obj) {
bool image_set = false;
PoolVector is gone, replaced by Vector Typed `PoolTypeArray` types are now renamed `PackedTypeArray` and are sugar for `Vector<Type>`.
2020-02-17 21:06:54 +00:00
PackedByteArray image_data = p_data;
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
if (use_cache) {
Implement shader caching * Shader compilation is now cached. Subsequent loads take less than a millisecond. * Improved game, editor and project manager startup time. * Editor uses .godot/shader_cache to store shaders. * Game uses user://shader_cache * Project manager uses $config_dir/shader_cache * Options to tweak shader caching in project settings. * Editor path configuration moved from EditorSettings to new class, EditorPaths, so it can be available early on (before shaders are compiled). * Reworked ShaderCompilerRD to ensure deterministic shader code creation (else shader may change and cache will be invalidated). * Added shader compression with SMOLV: https://github.com/aras-p/smol-v
2021-05-25 00:25:11 +00:00
String cache_filename_base = EditorPaths::get_singleton()->get_cache_dir().plus_file("assetimage_" + image_queue[p_queue_id].image_url.md5_text());
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
FileAccess *file = FileAccess::open(cache_filename_base + ".data", FileAccess::READ);
if (file) {
PoolVector is gone, replaced by Vector Typed `PoolTypeArray` types are now renamed `PackedTypeArray` and are sugar for `Vector<Type>`.
2020-02-17 21:06:54 +00:00
PackedByteArray cached_data;
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
int len = file->get_32();
Update asset library editor plugin - new functionality and fixes
2016-06-07 18:29:15 +00:00
cached_data.resize(len);
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
PoolVector is gone, replaced by Vector Typed `PoolTypeArray` types are now renamed `PackedTypeArray` and are sugar for `Vector<Type>`.
2020-02-17 21:06:54 +00:00
uint8_t *w = cached_data.ptrw();
file->get_buffer(w, len);
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
Update asset library editor plugin - new functionality and fixes
2016-06-07 18:29:15 +00:00
image_data = cached_data;
file->close();
Fix memory leak after closing files
2019-06-05 07:34:16 +00:00
memdelete(file);
Update asset library editor plugin - new functionality and fixes
2016-06-07 18:29:15 +00:00
}
}
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
int len = image_data.size();
PoolVector is gone, replaced by Vector Typed `PoolTypeArray` types are now renamed `PackedTypeArray` and are sugar for `Vector<Type>`.
2020-02-17 21:06:54 +00:00
const uint8_t *r = image_data.ptr();
Fix AssetLib image loading
2018-05-14 23:11:46 +00:00
Ref<Image> image = Ref<Image>(memnew(Image));
uint8_t png_signature[8] = { 137, 80, 78, 71, 13, 10, 26, 10 };
uint8_t jpg_signature[3] = { 255, 216, 255 };
PoolVector is gone, replaced by Vector Typed `PoolTypeArray` types are now renamed `PackedTypeArray` and are sugar for `Vector<Type>`.
2020-02-17 21:06:54 +00:00
if (r) {
Fixes AssetLib crash when JPG module is disabled JPG module is optional, so check it's existence before using.
2020-01-15 10:29:27 +00:00
if ((memcmp(&r[0], &png_signature[0], 8) == 0) && Image::_png_mem_loader_func) {
PoolVector is gone, replaced by Vector Typed `PoolTypeArray` types are now renamed `PackedTypeArray` and are sugar for `Vector<Type>`.
2020-02-17 21:06:54 +00:00
image->copy_internals_from(Image::_png_mem_loader_func(r, len));
Fixes AssetLib crash when JPG module is disabled JPG module is optional, so check it's existence before using.
2020-01-15 10:29:27 +00:00
} else if ((memcmp(&r[0], &jpg_signature[0], 3) == 0) && Image::_jpg_mem_loader_func) {
PoolVector is gone, replaced by Vector Typed `PoolTypeArray` types are now renamed `PackedTypeArray` and are sugar for `Vector<Type>`.
2020-02-17 21:06:54 +00:00
image->copy_internals_from(Image::_jpg_mem_loader_func(r, len));
Fix AssetLib image loading
2018-05-14 23:11:46 +00:00
}
}
Removal of Image from Variant, converted to a Resource.
2017-05-17 10:36:47 +00:00
Rename empty() to is_empty()
2020-12-15 12:04:21 +00:00
if (!image->is_empty()) {
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
switch (image_queue[p_queue_id].image_type) {
Few fixes for asset store browser
2017-11-18 11:20:26 +00:00
case IMAGE_QUEUE_ICON:
Use Lanczos filtering for variable-sized images such as project icons This results in better-looking icons with less artifacts induced by downscaling.
2019-08-13 20:08:23 +00:00
image->resize(64 * EDSCALE, 64 * EDSCALE, Image::INTERPOLATE_LANCZOS);
Few fixes for asset store browser
2017-11-18 11:20:26 +00:00
break;
case IMAGE_QUEUE_THUMBNAIL: {
float max_height = 85 * EDSCALE;
float scale_ratio = max_height / (image->get_height() * EDSCALE);
if (scale_ratio < 1) {
Improve preview and screenshot display in the asset library Images are now resized with Lanczos interpolation for higher quality. Video thumbnails now display a "pointing hand" cursor when hovered as they will open in an external browser.
2019-07-18 17:48:47 +00:00
image->resize(image->get_width() * EDSCALE * scale_ratio, image->get_height() * EDSCALE * scale_ratio, Image::INTERPOLATE_LANCZOS);
Few fixes for asset store browser
2017-11-18 11:20:26 +00:00
}
} break;
case IMAGE_QUEUE_SCREENSHOT: {
float max_height = 397 * EDSCALE;
float scale_ratio = max_height / (image->get_height() * EDSCALE);
if (scale_ratio < 1) {
Improve preview and screenshot display in the asset library Images are now resized with Lanczos interpolation for higher quality. Video thumbnails now display a "pointing hand" cursor when hovered as they will open in an external browser.
2019-07-18 17:48:47 +00:00
image->resize(image->get_width() * EDSCALE * scale_ratio, image->get_height() * EDSCALE * scale_ratio, Image::INTERPOLATE_LANCZOS);
Few fixes for asset store browser
2017-11-18 11:20:26 +00:00
}
} break;
Update asset library editor plugin - new functionality and fixes
2016-06-07 18:29:15 +00:00
}
Ref<ImageTexture> tex;
Rename `instance()`->`instantiate()` when it's a verb
2021-06-17 22:03:09 +00:00
tex.instantiate();
Update asset library editor plugin - new functionality and fixes
2016-06-07 18:29:15 +00:00
tex->create_from_image(image);
-Work on addon editor plugin (disabled by default) -New HTTPRequest node, to make HTTP requests simpler.
2016-03-04 14:09:45 +00:00
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
obj->call("set_image", image_queue[p_queue_id].image_type, image_queue[p_queue_id].image_index, tex);
Update asset library editor plugin - new functionality and fixes
2016-06-07 18:29:15 +00:00
image_set = true;
}
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
if (!image_set && final) {
Optimize StringName usage * Added a new macro SNAME() that constructs and caches a local stringname. * Subsequent usages use the cached version. * Since these use a global static variable, a second refcounter of static usages need to be kept for cleanup time. * Replaced all theme usages by this new macro. * Replace all signal emission usages by this new macro. * Replace all call_deferred usages by this new macro. This is part of ongoing work to optimize GUI and the editor.
2021-07-17 21:22:52 +00:00
obj->call("set_image", image_queue[p_queue_id].image_type, image_queue[p_queue_id].image_index, get_theme_icon(SNAME("FileBrokenBigThumb"), SNAME("EditorIcons")));
Update asset library editor plugin - new functionality and fixes
2016-06-07 18:29:15 +00:00
}
}
}
-Work on addon editor plugin (disabled by default) -New HTTPRequest node, to make HTTP requests simpler.
2016-03-04 14:09:45 +00:00
PoolVector is gone, replaced by Vector Typed `PoolTypeArray` types are now renamed `PackedTypeArray` and are sugar for `Vector<Type>`.
2020-02-17 21:06:54 +00:00
void EditorAssetLibrary::_image_request_completed(int p_status, int p_code, const PackedStringArray &headers, const PackedByteArray &p_data, int p_queue_id) {
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
ERR_FAIL_COND(!image_queue.has(p_queue_id));
-Work on addon editor plugin (disabled by default) -New HTTPRequest node, to make HTTP requests simpler.
2016-03-04 14:09:45 +00:00
Fix AssetLib image loading
2018-05-14 23:11:46 +00:00
if (p_status == HTTPRequest::RESULT_SUCCESS && p_code < HTTPClient::RESPONSE_BAD_REQUEST) {
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
if (p_code != HTTPClient::RESPONSE_NOT_MODIFIED) {
for (int i = 0; i < headers.size(); i++) {
if (headers[i].findn("ETag:") == 0) { // Save etag
Implement shader caching * Shader compilation is now cached. Subsequent loads take less than a millisecond. * Improved game, editor and project manager startup time. * Editor uses .godot/shader_cache to store shaders. * Game uses user://shader_cache * Project manager uses $config_dir/shader_cache * Options to tweak shader caching in project settings. * Editor path configuration moved from EditorSettings to new class, EditorPaths, so it can be available early on (before shaders are compiled). * Reworked ShaderCompilerRD to ensure deterministic shader code creation (else shader may change and cache will be invalidated). * Added shader compression with SMOLV: https://github.com/aras-p/smol-v
2021-05-25 00:25:11 +00:00
String cache_filename_base = EditorPaths::get_singleton()->get_cache_dir().plus_file("assetimage_" + image_queue[p_queue_id].image_url.md5_text());
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
String new_etag = headers[i].substr(headers[i].find(":") + 1, headers[i].length()).strip_edges();
FileAccess *file;
file = FileAccess::open(cache_filename_base + ".etag", FileAccess::WRITE);
if (file) {
Update asset library editor plugin - new functionality and fixes
2016-06-07 18:29:15 +00:00
file->store_line(new_etag);
file->close();
Fix memory leak after closing files
2019-06-05 07:34:16 +00:00
memdelete(file);
Update asset library editor plugin - new functionality and fixes
2016-06-07 18:29:15 +00:00
}
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
int len = p_data.size();
PoolVector is gone, replaced by Vector Typed `PoolTypeArray` types are now renamed `PackedTypeArray` and are sugar for `Vector<Type>`.
2020-02-17 21:06:54 +00:00
const uint8_t *r = p_data.ptr();
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
file = FileAccess::open(cache_filename_base + ".data", FileAccess::WRITE);
if (file) {
Update asset library editor plugin - new functionality and fixes
2016-06-07 18:29:15 +00:00
file->store_32(len);
PoolVector is gone, replaced by Vector Typed `PoolTypeArray` types are now renamed `PackedTypeArray` and are sugar for `Vector<Type>`.
2020-02-17 21:06:54 +00:00
file->store_buffer(r, len);
Update asset library editor plugin - new functionality and fixes
2016-06-07 18:29:15 +00:00
file->close();
Fix memory leak after closing files
2019-06-05 07:34:16 +00:00
memdelete(file);
Update asset library editor plugin - new functionality and fixes
2016-06-07 18:29:15 +00:00
}
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
Update asset library editor plugin - new functionality and fixes
2016-06-07 18:29:15 +00:00
break;
}
-Work on addon editor plugin (disabled by default) -New HTTPRequest node, to make HTTP requests simpler.
2016-03-04 14:09:45 +00:00
}
}
Update asset library editor plugin - new functionality and fixes
2016-06-07 18:29:15 +00:00
_image_update(p_code == HTTPClient::RESPONSE_NOT_MODIFIED, true, p_data, p_queue_id);
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
-Work on addon editor plugin (disabled by default) -New HTTPRequest node, to make HTTP requests simpler.
2016-03-04 14:09:45 +00:00
} else {
Remove duplicate WARN_PRINT macro.
2019-11-07 08:44:15 +00:00
WARN_PRINT("Error getting image file from URL: " + image_queue[p_queue_id].image_url);
Update asset library editor plugin - new functionality and fixes
2016-06-07 18:29:15 +00:00
Object *obj = ObjectDB::get_instance(image_queue[p_queue_id].target);
if (obj) {
Optimize StringName usage * Added a new macro SNAME() that constructs and caches a local stringname. * Subsequent usages use the cached version. * Since these use a global static variable, a second refcounter of static usages need to be kept for cleanup time. * Replaced all theme usages by this new macro. * Replace all signal emission usages by this new macro. * Replace all call_deferred usages by this new macro. This is part of ongoing work to optimize GUI and the editor.
2021-07-17 21:22:52 +00:00
obj->call("set_image", image_queue[p_queue_id].image_type, image_queue[p_queue_id].image_index, get_theme_icon(SNAME("FileBrokenBigThumb"), SNAME("EditorIcons")));
Update asset library editor plugin - new functionality and fixes
2016-06-07 18:29:15 +00:00
}
-Work on addon editor plugin (disabled by default) -New HTTPRequest node, to make HTTP requests simpler.
2016-03-04 14:09:45 +00:00
}
Style: Fix statements ending with ';;'
2017-01-14 17:03:38 +00:00
image_queue[p_queue_id].request->queue_delete();
-Work on addon editor plugin (disabled by default) -New HTTPRequest node, to make HTTP requests simpler.
2016-03-04 14:09:45 +00:00
image_queue.erase(p_queue_id);
_update_image_queue();
}
Added asset library on project manager for templates
2016-06-08 12:25:47 +00:00
void EditorAssetLibrary::_update_image_queue() {
Improve image loading performance in the asset library This closes #31614.
2019-08-27 17:41:49 +00:00
const int max_images = 6;
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
int current_images = 0;
-Work on addon editor plugin (disabled by default) -New HTTPRequest node, to make HTTP requests simpler.
2016-03-04 14:09:45 +00:00
List<int> to_delete;
Use range iterators for `Map`
2021-08-09 20:13:42 +00:00
for (KeyValue<int, ImageQueue> &E : image_queue) {
if (!E.value.active && current_images < max_images) {
String cache_filename_base = EditorPaths::get_singleton()->get_cache_dir().plus_file("assetimage_" + E.value.image_url.md5_text());
Update asset library editor plugin - new functionality and fixes
2016-06-07 18:29:15 +00:00
Vector<String> headers;
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
if (FileAccess::exists(cache_filename_base + ".etag") && FileAccess::exists(cache_filename_base + ".data")) {
FileAccess *file = FileAccess::open(cache_filename_base + ".etag", FileAccess::READ);
Update asset library editor plugin - new functionality and fixes
2016-06-07 18:29:15 +00:00
if (file) {
headers.push_back("If-None-Match: " + file->get_line());
file->close();
Fix memory leak after closing files
2019-06-05 07:34:16 +00:00
memdelete(file);
Update asset library editor plugin - new functionality and fixes
2016-06-07 18:29:15 +00:00
}
-Work on addon editor plugin (disabled by default) -New HTTPRequest node, to make HTTP requests simpler.
2016-03-04 14:09:45 +00:00
}
Use range iterators for `Map`
2021-08-09 20:13:42 +00:00
Error err = E.value.request->request(E.value.image_url, headers);
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
if (err != OK) {
Use range iterators for `Map`
2021-08-09 20:13:42 +00:00
to_delete.push_back(E.key);
-Work on addon editor plugin (disabled by default) -New HTTPRequest node, to make HTTP requests simpler.
2016-03-04 14:09:45 +00:00
} else {
Use range iterators for `Map`
2021-08-09 20:13:42 +00:00
E.value.active = true;
-Work on addon editor plugin (disabled by default) -New HTTPRequest node, to make HTTP requests simpler.
2016-03-04 14:09:45 +00:00
}
current_images++;
Use range iterators for `Map`
2021-08-09 20:13:42 +00:00
} else if (E.value.active) {
-Work on addon editor plugin (disabled by default) -New HTTPRequest node, to make HTTP requests simpler.
2016-03-04 14:09:45 +00:00
current_images++;
}
}
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
while (to_delete.size()) {
-Work on addon editor plugin (disabled by default) -New HTTPRequest node, to make HTTP requests simpler.
2016-03-04 14:09:45 +00:00
image_queue[to_delete.front()->get()].request->queue_delete();
image_queue.erase(to_delete.front()->get());
to_delete.pop_front();
}
}
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
void EditorAssetLibrary::_request_image(ObjectID p_for, String p_image_url, ImageType p_type, int p_image_index) {
-Work on addon editor plugin (disabled by default) -New HTTPRequest node, to make HTTP requests simpler.
2016-03-04 14:09:45 +00:00
ImageQueue iq;
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
iq.image_url = p_image_url;
iq.image_index = p_image_index;
iq.image_type = p_type;
iq.request = memnew(HTTPRequest);
Add proxy support for the editor * Adds proxy support for `HTTPRequest`. * Adds `network/http_proxy/{host,port}` editor settings. * Labeled as "HTTP Proxy" and it will be used for both HTTP and HTTPS requests. This is the same convention as seen in Android Studio's proxy settings. * Makes Asset Library and Export Template Manager use proxy according to the editor settings.
2021-12-09 03:34:32 +00:00
setup_http_request(iq.request);
-Work on addon editor plugin (disabled by default) -New HTTPRequest node, to make HTTP requests simpler.
2016-03-04 14:09:45 +00:00
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
iq.target = p_for;
iq.queue_id = ++last_queue_id;
iq.active = false;
-Work on addon editor plugin (disabled by default) -New HTTPRequest node, to make HTTP requests simpler.
2016-03-04 14:09:45 +00:00
Signals: Port connect calls to use callable_mp Remove now unnecessary bindings of signal callbacks in the public API. There might be some false positives that need rebinding if they were meant to be public. No regular expressions were harmed in the making of this commit. (Nah, just kidding.)
2020-02-21 17:28:45 +00:00
iq.request->connect("request_completed", callable_mp(this, &EditorAssetLibrary::_image_request_completed), varray(iq.queue_id));
-Work on addon editor plugin (disabled by default) -New HTTPRequest node, to make HTTP requests simpler.
2016-03-04 14:09:45 +00:00
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
image_queue[iq.queue_id] = iq;
-Work on addon editor plugin (disabled by default) -New HTTPRequest node, to make HTTP requests simpler.
2016-03-04 14:09:45 +00:00
add_child(iq.request);
PoolVector is gone, replaced by Vector Typed `PoolTypeArray` types are now renamed `PackedTypeArray` and are sugar for `Vector<Type>`.
2020-02-17 21:06:54 +00:00
_image_update(true, false, PackedByteArray(), iq.queue_id);
-Work on addon editor plugin (disabled by default) -New HTTPRequest node, to make HTTP requests simpler.
2016-03-04 14:09:45 +00:00
_update_image_queue();
}
Added asset library on project manager for templates
2016-06-08 12:25:47 +00:00
void EditorAssetLibrary::_repository_changed(int p_repository_id) {
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
host = repository->get_item_metadata(p_repository_id);
if (templates_only) {
Fix project manager category list, small enchancements as well
2016-06-21 14:10:02 +00:00
_api_request("configure", REQUESTING_CONFIG, "?type=project");
} else {
_api_request("configure", REQUESTING_CONFIG);
}
Update asset library editor plugin - new functionality and fixes
2016-06-07 18:29:15 +00:00
}
-Work on addon editor plugin (disabled by default) -New HTTPRequest node, to make HTTP requests simpler.
2016-03-04 14:09:45 +00:00
Add support levels to search
2016-06-21 13:29:49 +00:00
void EditorAssetLibrary::_support_toggled(int p_support) {
support->get_popup()->set_item_checked(p_support, !support->get_popup()->is_item_checked(p_support));
Fix project manager category list, small enchancements as well
2016-06-21 14:10:02 +00:00
_search();
}
void EditorAssetLibrary::_rerun_search(int p_ignore) {
_search();
Add support levels to search
2016-06-21 13:29:49 +00:00
}
Added asset library on project manager for templates
2016-06-08 12:25:47 +00:00
void EditorAssetLibrary::_search(int p_page) {
-Work on addon editor plugin (disabled by default) -New HTTPRequest node, to make HTTP requests simpler.
2016-03-04 14:09:45 +00:00
String args;
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
if (templates_only) {
Fix project manager category list, small enchancements as well
2016-06-21 14:10:02 +00:00
args += "?type=project&";
} else {
args += "?";
}
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
args += String() + "sort=" + sort_key[sort->get_selected()];
Fix project manager category list, small enchancements as well
2016-06-21 14:10:02 +00:00
Refactor version macros and fix related bugs The previous logic with VERSION_MKSTRING was a bit unwieldy, so there were several places hardcoding their own variant of the version string, potentially with bugs (e.g. forgetting the patch number when defined). The new logic defines: - VERSION_BRANCH, the main 'major.minor' version (e.g. 3.1) - VERSION_NUMBER, which can be 'major.minor' or 'major.minor.patch', depending on whether the latter is defined (e.g. 3.1.4) - VERSION_FULL_CONFIG, which contains the version status (e.g. stable) and the module-specific suffix (e.g. mono) - VERSION_FULL_BUILD, same as above but with build/reference name (e.g. official, custom_build, mageia, etc.) Note: Slight change here, as the previous format had the build name *before* the module-specific suffix; now it's after - VERSION_FULL_NAME, same as before, so VERSION_FULL_BUILD prefixed with "Godot v" for readability Bugs fixed thanks to that: - Export templates version matching now properly takes VERSION_PATCH into account by relying on VERSION_FULL_CONFIG. - ClassDB hash no longer takes the build name into account, but limits itself to VERSION_FULL_CONFIG (build name is cosmetic, not relevant for the API hash). - Docs XML no longer hardcode the VERSION_STATUS, this was annoying. - Small cleanup in Windows .rc file thanks to new macros.
2018-02-23 18:48:49 +00:00
// We use the "branch" version, i.e. major.minor, as patch releases should be compatible
args += "&godot_version=" + String(VERSION_BRANCH);
Enable asset store for godot 3.0
2017-11-09 10:55:30 +00:00
Add support levels to search
2016-06-21 13:29:49 +00:00
String support_list;
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
for (int i = 0; i < SUPPORT_MAX; i++) {
if (support->get_popup()->is_item_checked(i)) {
Add support levels to search
2016-06-21 13:29:49 +00:00
support_list += String(support_key[i]) + "+";
}
}
Replace String comparisons with "", String() to is_empty() Also: - Adds two stress tests to test_string.h - Changes to .empty() on std::strings
2021-12-09 09:42:46 +00:00
if (!support_list.is_empty()) {
Add support levels to search
2016-06-21 13:29:49 +00:00
args += "&support=" + support_list.substr(0, support_list.length() - 1);
}
-Work on addon editor plugin (disabled by default) -New HTTPRequest node, to make HTTP requests simpler.
2016-03-04 14:09:45 +00:00
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
if (categories->get_selected() > 0) {
args += "&category=" + itos(categories->get_item_metadata(categories->get_selected()));
-Work on addon editor plugin (disabled by default) -New HTTPRequest node, to make HTTP requests simpler.
2016-03-04 14:09:45 +00:00
}
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
Improve sorting options in the asset library The reverse sorting options are now integrated in the list of sorting options, making the "Reverse" button unnecessary. This pattern tends to be easier to discover by users. The "Downloads" sorting option was also removed as it's not implemented in the backend.
2019-08-24 02:53:14 +00:00
// Sorting options with an odd index are always the reverse of the previous one
if (sort->get_selected() % 2 == 1) {
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
args += "&reverse=true";
Update asset library editor plugin - new functionality and fixes
2016-06-07 18:29:15 +00:00
}
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
Replace String comparisons with "", String() to is_empty() Also: - Adds two stress tests to test_string.h - Changes to .empty() on std::strings
2021-12-09 09:42:46 +00:00
if (!filter->get_text().is_empty()) {
Unify URI encoding/decoding and add to C# http_escape and percent_encode have been unified into uri_encode, and http_unescape and percent_decode have been unified into uri_decode.
2020-11-30 03:43:38 +00:00
args += "&filter=" + filter->get_text().uri_encode();
-Work on addon editor plugin (disabled by default) -New HTTPRequest node, to make HTTP requests simpler.
2016-03-04 14:09:45 +00:00
}
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
if (p_page > 0) {
args += "&page=" + itos(p_page);
-Work on addon editor plugin (disabled by default) -New HTTPRequest node, to make HTTP requests simpler.
2016-03-04 14:09:45 +00:00
}
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
_api_request("asset", REQUESTING_SEARCH, args);
-Work on addon editor plugin (disabled by default) -New HTTPRequest node, to make HTTP requests simpler.
2016-03-04 14:09:45 +00:00
}
Automatically start searching in the asset library when entering text Entering text will now start searching automatically after 0.25 seconds have passed (debounce delay). This removes the need for a separate Search button.
2020-09-29 10:43:38 +00:00
void EditorAssetLibrary::_search_text_changed(const String &p_text) {
filter_debounce_timer->start();
}
void EditorAssetLibrary::_filter_debounce_timer_timeout() {
Project Manager: Fix Templates search signal connection. Fixes #13921
2017-12-09 21:56:38 +00:00
_search();
}
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
HBoxContainer *EditorAssetLibrary::_make_pages(int p_page, int p_page_count, int p_page_len, int p_total_items, int p_current_items) {
HBoxContainer *hbc = memnew(HBoxContainer);
-Work on addon editor plugin (disabled by default) -New HTTPRequest node, to make HTTP requests simpler.
2016-03-04 14:09:45 +00:00
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
if (p_page_count < 2) {
Hide header and footer in AssetLib when not necessary Reduces visual clutter by hiding pages navigator header and footer in AssetLib if no results are found or when results fit on one page one page. Fix for issue #23036
2018-10-15 17:26:57 +00:00
return hbc;
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
}
Hide header and footer in AssetLib when not necessary Reduces visual clutter by hiding pages navigator header and footer in AssetLib if no results are found or when results fit on one page one page. Fix for issue #23036
2018-10-15 17:26:57 +00:00
-Work on addon editor plugin (disabled by default) -New HTTPRequest node, to make HTTP requests simpler.
2016-03-04 14:09:45 +00:00
//do the mario
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
int from = p_page - 5;
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
if (from < 0) {
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
from = 0;
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
}
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
int to = from + 10;
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
if (to > p_page_count) {
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
to = p_page_count;
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
}
-Work on addon editor plugin (disabled by default) -New HTTPRequest node, to make HTTP requests simpler.
2016-03-04 14:09:45 +00:00
hbc->add_spacer();
Revert "Add missing SNAME macro optimization to all theme methods call" This reverts commit a988fad9a092053434545c32afae91ccbdfbe792. As discussed in #57725 and clarified in #57788, `SNAME` is not meant to be used everywhere but only in critical code paths. For theme methods specifically, it was by design that only getters use `SNAME` and not setters.
2022-02-08 09:14:58 +00:00
hbc->add_theme_constant_override("separation", 5 * EDSCALE);
-Work on addon editor plugin (disabled by default) -New HTTPRequest node, to make HTTP requests simpler.
2016-03-04 14:09:45 +00:00
AssetLib pagination modifications
2018-05-15 15:17:52 +00:00
Button *first = memnew(Button);
first->set_text(TTR("First"));
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
if (p_page != 0) {
Signals: Port connect calls to use callable_mp Remove now unnecessary bindings of signal callbacks in the public API. There might be some false positives that need rebinding if they were meant to be public. No regular expressions were harmed in the making of this commit. (Nah, just kidding.)
2020-02-21 17:28:45 +00:00
first->connect("pressed", callable_mp(this, &EditorAssetLibrary::_search), varray(0));
AssetLib pagination modifications
2018-05-15 15:17:52 +00:00
} else {
first->set_disabled(true);
first->set_focus_mode(Control::FOCUS_NONE);
Update asset library editor plugin - new functionality and fixes
2016-06-07 18:29:15 +00:00
}
AssetLib pagination modifications
2018-05-15 15:17:52 +00:00
hbc->add_child(first);
-Work on addon editor plugin (disabled by default) -New HTTPRequest node, to make HTTP requests simpler.
2016-03-04 14:09:45 +00:00
AssetLib pagination modifications
2018-05-15 15:17:52 +00:00
Button *prev = memnew(Button);
prev->set_text(TTR("Previous"));
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
if (p_page > 0) {
Signals: Port connect calls to use callable_mp Remove now unnecessary bindings of signal callbacks in the public API. There might be some false positives that need rebinding if they were meant to be public. No regular expressions were harmed in the making of this commit. (Nah, just kidding.)
2020-02-21 17:28:45 +00:00
prev->connect("pressed", callable_mp(this, &EditorAssetLibrary::_search), varray(p_page - 1));
AssetLib pagination modifications
2018-05-15 15:17:52 +00:00
} else {
prev->set_disabled(true);
prev->set_focus_mode(Control::FOCUS_NONE);
-Work on addon editor plugin (disabled by default) -New HTTPRequest node, to make HTTP requests simpler.
2016-03-04 14:09:45 +00:00
}
AssetLib pagination modifications
2018-05-15 15:17:52 +00:00
hbc->add_child(prev);
hbc->add_child(memnew(VSeparator));
-Work on addon editor plugin (disabled by default) -New HTTPRequest node, to make HTTP requests simpler.
2016-03-04 14:09:45 +00:00
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
for (int i = from; i < to; i++) {
if (i == p_page) {
AssetLib pagination modifications
2018-05-15 15:17:52 +00:00
Button *current = memnew(Button);
Make the pagination buttons wider in the asset library browser This makes the page number buttons easier to click.
2021-03-07 19:10:53 +00:00
// Keep the extended padding for the currently active page (see below).
current->set_text(vformat(" %d ", i + 1));
AssetLib pagination modifications
2018-05-15 15:17:52 +00:00
current->set_disabled(true);
current->set_focus_mode(Control::FOCUS_NONE);
-Work on addon editor plugin (disabled by default) -New HTTPRequest node, to make HTTP requests simpler.
2016-03-04 14:09:45 +00:00
hbc->add_child(current);
} else {
AssetLib pagination modifications
2018-05-15 15:17:52 +00:00
Button *current = memnew(Button);
Make the pagination buttons wider in the asset library browser This makes the page number buttons easier to click.
2021-03-07 19:10:53 +00:00
// Add padding to make page number buttons easier to click.
current->set_text(vformat(" %d ", i + 1));
Signals: Port connect calls to use callable_mp Remove now unnecessary bindings of signal callbacks in the public API. There might be some false positives that need rebinding if they were meant to be public. No regular expressions were harmed in the making of this commit. (Nah, just kidding.)
2020-02-21 17:28:45 +00:00
current->connect("pressed", callable_mp(this, &EditorAssetLibrary::_search), varray(i));
-Work on addon editor plugin (disabled by default) -New HTTPRequest node, to make HTTP requests simpler.
2016-03-04 14:09:45 +00:00
hbc->add_child(current);
}
}
AssetLib pagination modifications
2018-05-15 15:17:52 +00:00
Button *next = memnew(Button);
next->set_text(TTR("Next"));
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
if (p_page < p_page_count - 1) {
Signals: Port connect calls to use callable_mp Remove now unnecessary bindings of signal callbacks in the public API. There might be some false positives that need rebinding if they were meant to be public. No regular expressions were harmed in the making of this commit. (Nah, just kidding.)
2020-02-21 17:28:45 +00:00
next->connect("pressed", callable_mp(this, &EditorAssetLibrary::_search), varray(p_page + 1));
AssetLib pagination modifications
2018-05-15 15:17:52 +00:00
} else {
next->set_disabled(true);
next->set_focus_mode(Control::FOCUS_NONE);
-Work on addon editor plugin (disabled by default) -New HTTPRequest node, to make HTTP requests simpler.
2016-03-04 14:09:45 +00:00
}
AssetLib pagination modifications
2018-05-15 15:17:52 +00:00
hbc->add_child(memnew(VSeparator));
hbc->add_child(next);
Update asset library editor plugin - new functionality and fixes
2016-06-07 18:29:15 +00:00
AssetLib pagination modifications
2018-05-15 15:17:52 +00:00
Button *last = memnew(Button);
last->set_text(TTR("Last"));
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
if (p_page != p_page_count - 1) {
Signals: Port connect calls to use callable_mp Remove now unnecessary bindings of signal callbacks in the public API. There might be some false positives that need rebinding if they were meant to be public. No regular expressions were harmed in the making of this commit. (Nah, just kidding.)
2020-02-21 17:28:45 +00:00
last->connect("pressed", callable_mp(this, &EditorAssetLibrary::_search), varray(p_page_count - 1));
AssetLib pagination modifications
2018-05-15 15:17:52 +00:00
} else {
last->set_disabled(true);
last->set_focus_mode(Control::FOCUS_NONE);
Update asset library editor plugin - new functionality and fixes
2016-06-07 18:29:15 +00:00
}
AssetLib pagination modifications
2018-05-15 15:17:52 +00:00
hbc->add_child(last);
-Work on addon editor plugin (disabled by default) -New HTTPRequest node, to make HTTP requests simpler.
2016-03-04 14:09:45 +00:00
hbc->add_spacer();
return hbc;
}
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
void EditorAssetLibrary::_api_request(const String &p_request, RequestType p_request_type, const String &p_arguments) {
if (requesting != REQUESTING_NONE) {
-Work on addon editor plugin (disabled by default) -New HTTPRequest node, to make HTTP requests simpler.
2016-03-04 14:09:45 +00:00
request->cancel_request();
}
Add thread support to HTTPRequest, changed assetlib to use it.
2016-07-24 19:09:43 +00:00
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
requesting = p_request_type;
-Work on addon editor plugin (disabled by default) -New HTTPRequest node, to make HTTP requests simpler.
2016-03-04 14:09:45 +00:00
-more progress to asset sharing client, but still disabled by default
2016-03-05 15:24:12 +00:00
error_hb->hide();
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
request->request(host + "/" + p_request + p_arguments);
-Work on addon editor plugin (disabled by default) -New HTTPRequest node, to make HTTP requests simpler.
2016-03-04 14:09:45 +00:00
}
PoolVector is gone, replaced by Vector Typed `PoolTypeArray` types are now renamed `PackedTypeArray` and are sugar for `Vector<Type>`.
2020-02-17 21:06:54 +00:00
void EditorAssetLibrary::_http_request_completed(int p_status, int p_code, const PackedStringArray &headers, const PackedByteArray &p_data) {
-Work on addon editor plugin (disabled by default) -New HTTPRequest node, to make HTTP requests simpler.
2016-03-04 14:09:45 +00:00
String str;
{
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
int datalen = p_data.size();
PoolVector is gone, replaced by Vector Typed `PoolTypeArray` types are now renamed `PackedTypeArray` and are sugar for `Vector<Type>`.
2020-02-17 21:06:54 +00:00
const uint8_t *r = p_data.ptr();
str.parse_utf8((const char *)r, datalen);
-Work on addon editor plugin (disabled by default) -New HTTPRequest node, to make HTTP requests simpler.
2016-03-04 14:09:45 +00:00
}
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
bool error_abort = true;
-more progress to asset sharing client, but still disabled by default
2016-03-05 15:24:12 +00:00
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
switch (p_status) {
-more progress to asset sharing client, but still disabled by default
2016-03-05 15:24:12 +00:00
case HTTPRequest::RESULT_CANT_RESOLVE: {
i18n: Add more assetlib strings to translate Fixes #8463.
2017-04-20 12:42:35 +00:00
error_label->set_text(TTR("Can't resolve hostname:") + " " + host);
-more progress to asset sharing client, but still disabled by default
2016-03-05 15:24:12 +00:00
} break;
case HTTPRequest::RESULT_BODY_SIZE_LIMIT_EXCEEDED:
case HTTPRequest::RESULT_CONNECTION_ERROR:
case HTTPRequest::RESULT_CHUNKED_BODY_SIZE_MISMATCH: {
i18n: Add more assetlib strings to translate Fixes #8463.
2017-04-20 12:42:35 +00:00
error_label->set_text(TTR("Connection error, please try again."));
-more progress to asset sharing client, but still disabled by default
2016-03-05 15:24:12 +00:00
} break;
case HTTPRequest::RESULT_SSL_HANDSHAKE_ERROR:
case HTTPRequest::RESULT_CANT_CONNECT: {
i18n: Add more assetlib strings to translate Fixes #8463.
2017-04-20 12:42:35 +00:00
error_label->set_text(TTR("Can't connect to host:") + " " + host);
-more progress to asset sharing client, but still disabled by default
2016-03-05 15:24:12 +00:00
} break;
case HTTPRequest::RESULT_NO_RESPONSE: {
i18n: Add more assetlib strings to translate Fixes #8463.
2017-04-20 12:42:35 +00:00
error_label->set_text(TTR("No response from host:") + " " + host);
-more progress to asset sharing client, but still disabled by default
2016-03-05 15:24:12 +00:00
} break;
case HTTPRequest::RESULT_REQUEST_FAILED: {
i18n: Add more assetlib strings to translate Fixes #8463.
2017-04-20 12:42:35 +00:00
error_label->set_text(TTR("Request failed, return code:") + " " + itos(p_code));
-more progress to asset sharing client, but still disabled by default
2016-03-05 15:24:12 +00:00
} break;
case HTTPRequest::RESULT_REDIRECT_LIMIT_REACHED: {
i18n: Add more assetlib strings to translate Fixes #8463.
2017-04-20 12:42:35 +00:00
error_label->set_text(TTR("Request failed, too many redirects"));
-more progress to asset sharing client, but still disabled by default
2016-03-05 15:24:12 +00:00
} break;
default: {
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
if (p_code != 200) {
i18n: Add more assetlib strings to translate Fixes #8463.
2017-04-20 12:42:35 +00:00
error_label->set_text(TTR("Request failed, return code:") + " " + itos(p_code));
-more progress to asset sharing client, but still disabled by default
2016-03-05 15:24:12 +00:00
} else {
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
error_abort = false;
-more progress to asset sharing client, but still disabled by default
2016-03-05 15:24:12 +00:00
}
} break;
}
if (error_abort) {
error_hb->show();
return;
}
-Work on addon editor plugin (disabled by default) -New HTTPRequest node, to make HTTP requests simpler.
2016-03-04 14:09:45 +00:00
Dictionary d;
Moved JSON functions to built-in to_json, parse_json, validate_json
2017-01-09 01:40:00 +00:00
{
Consolidate JSON, JSONParseResults and JSONParser into JSON Renames JSON.parse_string() to parse() Renames JSON.decode_data() to stringify()
2020-12-29 18:12:33 +00:00
JSON json;
json.parse(str);
d = json.get_data();
Moved JSON functions to built-in to_json, parse_json, validate_json
2017-01-09 01:40:00 +00:00
}
Update asset library editor plugin - new functionality and fixes
2016-06-07 18:29:15 +00:00
RequestType requested = requesting;
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
requesting = REQUESTING_NONE;
Update asset library editor plugin - new functionality and fixes
2016-06-07 18:29:15 +00:00
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
switch (requested) {
Update asset library editor plugin - new functionality and fixes
2016-06-07 18:29:15 +00:00
case REQUESTING_CONFIG: {
categories->clear();
i18n: Add more assetlib strings to translate Fixes #8463.
2017-04-20 12:42:35 +00:00
categories->add_item(TTR("All"));
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
categories->set_item_metadata(0, 0);
Update asset library editor plugin - new functionality and fixes
2016-06-07 18:29:15 +00:00
if (d.has("categories")) {
Array clist = d["categories"];
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
for (int i = 0; i < clist.size(); i++) {
Update asset library editor plugin - new functionality and fixes
2016-06-07 18:29:15 +00:00
Dictionary cat = clist[i];
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
if (!cat.has("name") || !cat.has("id")) {
Update asset library editor plugin - new functionality and fixes
2016-06-07 18:29:15 +00:00
continue;
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
}
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
String name = cat["name"];
int id = cat["id"];
Update asset library editor plugin - new functionality and fixes
2016-06-07 18:29:15 +00:00
categories->add_item(name);
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
categories->set_item_metadata(categories->get_item_count() - 1, id);
Update asset library editor plugin - new functionality and fixes
2016-06-07 18:29:15 +00:00
category_map[cat["id"]] = name;
}
-Work on addon editor plugin (disabled by default) -New HTTPRequest node, to make HTTP requests simpler.
2016-03-04 14:09:45 +00:00
}
Update asset library editor plugin - new functionality and fixes
2016-06-07 18:29:15 +00:00
_search();
} break;
case REQUESTING_SEARCH: {
Refresh the asset library only once on startup This avoids unnecessary calls to the API when switching between tabs in the editor or project manager.
2019-09-02 17:42:58 +00:00
initial_loading = false;
Display a message if no results are found in the asset library This closes https://github.com/godotengine/godot-proposals/issues/184.
2019-10-25 23:07:02 +00:00
// The loading text only needs to be displayed before the first page is loaded.
// Therefore, we don't need to show it again.
Improve loading UX in the asset library The asset library will now fade when loading pages instead of displaying a progress bar, which is a more common design pattern when browsing an online resource's pages. A "Loading..." text will be displayed before the first page loads.
2019-08-24 01:04:59 +00:00
library_loading->hide();
Display a message if no results are found in the asset library This closes https://github.com/godotengine/godot-proposals/issues/184.
2019-10-25 23:07:02 +00:00
library_error->hide();
Update asset library editor plugin - new functionality and fixes
2016-06-07 18:29:15 +00:00
if (asset_items) {
memdelete(asset_items);
}
-Work on addon editor plugin (disabled by default) -New HTTPRequest node, to make HTTP requests simpler.
2016-03-04 14:09:45 +00:00
Update asset library editor plugin - new functionality and fixes
2016-06-07 18:29:15 +00:00
if (asset_top_page) {
memdelete(asset_top_page);
}
-Work on addon editor plugin (disabled by default) -New HTTPRequest node, to make HTTP requests simpler.
2016-03-04 14:09:45 +00:00
Update asset library editor plugin - new functionality and fixes
2016-06-07 18:29:15 +00:00
if (asset_bottom_page) {
memdelete(asset_bottom_page);
}
-Work on addon editor plugin (disabled by default) -New HTTPRequest node, to make HTTP requests simpler.
2016-03-04 14:09:45 +00:00
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
int page = 0;
int pages = 1;
int page_len = 10;
int total_items = 1;
Update asset library editor plugin - new functionality and fixes
2016-06-07 18:29:15 +00:00
Array result;
-Work on addon editor plugin (disabled by default) -New HTTPRequest node, to make HTTP requests simpler.
2016-03-04 14:09:45 +00:00
Update asset library editor plugin - new functionality and fixes
2016-06-07 18:29:15 +00:00
if (d.has("page")) {
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
page = d["page"];
Update asset library editor plugin - new functionality and fixes
2016-06-07 18:29:15 +00:00
}
if (d.has("pages")) {
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
pages = d["pages"];
Update asset library editor plugin - new functionality and fixes
2016-06-07 18:29:15 +00:00
}
if (d.has("page_length")) {
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
page_len = d["page_length"];
Update asset library editor plugin - new functionality and fixes
2016-06-07 18:29:15 +00:00
}
if (d.has("total")) {
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
total_items = d["total"];
Update asset library editor plugin - new functionality and fixes
2016-06-07 18:29:15 +00:00
}
if (d.has("result")) {
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
result = d["result"];
Update asset library editor plugin - new functionality and fixes
2016-06-07 18:29:15 +00:00
}
-Work on addon editor plugin (disabled by default) -New HTTPRequest node, to make HTTP requests simpler.
2016-03-04 14:09:45 +00:00
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
asset_top_page = _make_pages(page, pages, page_len, total_items, result.size());
Update asset library editor plugin - new functionality and fixes
2016-06-07 18:29:15 +00:00
library_vb->add_child(asset_top_page);
-Work on addon editor plugin (disabled by default) -New HTTPRequest node, to make HTTP requests simpler.
2016-03-04 14:09:45 +00:00
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
asset_items = memnew(GridContainer);
Update asset library editor plugin - new functionality and fixes
2016-06-07 18:29:15 +00:00
asset_items->set_columns(2);
Revert "Add missing SNAME macro optimization to all theme methods call" This reverts commit a988fad9a092053434545c32afae91ccbdfbe792. As discussed in #57725 and clarified in #57788, `SNAME` is not meant to be used everywhere but only in critical code paths. For theme methods specifically, it was by design that only getters use `SNAME` and not setters.
2022-02-08 09:14:58 +00:00
asset_items->add_theme_constant_override("hseparation", 10 * EDSCALE);
asset_items->add_theme_constant_override("vseparation", 10 * EDSCALE);
-Work on addon editor plugin (disabled by default) -New HTTPRequest node, to make HTTP requests simpler.
2016-03-04 14:09:45 +00:00
Update asset library editor plugin - new functionality and fixes
2016-06-07 18:29:15 +00:00
library_vb->add_child(asset_items);
-Work on addon editor plugin (disabled by default) -New HTTPRequest node, to make HTTP requests simpler.
2016-03-04 14:09:45 +00:00
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
asset_bottom_page = _make_pages(page, pages, page_len, total_items, result.size());
Update asset library editor plugin - new functionality and fixes
2016-06-07 18:29:15 +00:00
library_vb->add_child(asset_bottom_page);
-Work on addon editor plugin (disabled by default) -New HTTPRequest node, to make HTTP requests simpler.
2016-03-04 14:09:45 +00:00
Rename empty() to is_empty()
2020-12-15 12:04:21 +00:00
if (result.is_empty()) {
Replace String comparisons with "", String() to is_empty() Also: - Adds two stress tests to test_string.h - Changes to .empty() on std::strings
2021-12-09 09:42:46 +00:00
if (!filter->get_text().is_empty()) {
Mention version compatibility when there are no results in the assetlib This closes #36469.
2020-02-23 19:55:55 +00:00
library_error->set_text(
vformat(TTR("No results for \"%s\"."), filter->get_text()));
} else {
// No results, even though the user didn't search for anything specific.
// This is typically because the version number changed recently
// and no assets compatible with the new version have been published yet.
library_error->set_text(
vformat(TTR("No results compatible with %s %s."), String(VERSION_SHORT_NAME).capitalize(), String(VERSION_BRANCH)));
}
Display a message if no results are found in the asset library This closes https://github.com/godotengine/godot-proposals/issues/184.
2019-10-25 23:07:02 +00:00
library_error->show();
}
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
for (int i = 0; i < result.size(); i++) {
Update asset library editor plugin - new functionality and fixes
2016-06-07 18:29:15 +00:00
Dictionary r = result[i];
-Work on addon editor plugin (disabled by default) -New HTTPRequest node, to make HTTP requests simpler.
2016-03-04 14:09:45 +00:00
Update asset library editor plugin - new functionality and fixes
2016-06-07 18:29:15 +00:00
ERR_CONTINUE(!r.has("title"));
ERR_CONTINUE(!r.has("asset_id"));
ERR_CONTINUE(!r.has("author"));
ERR_CONTINUE(!r.has("author_id"));
ERR_CONTINUE(!r.has("category_id"));
ERR_FAIL_COND(!category_map.has(r["category_id"]));
ERR_CONTINUE(!r.has("cost"));
-Made editor support SSL certs by default (embedded them) -Made asset sharing support https -Many fixes to HTTPRequest -Added an asset installer dialog -Visual cleanups to asset sharing tab -Fixed some issues in ScrollContainer, hope it does not break things -Asset sharing tab is not visible (hidden on purpose) for now.
2016-03-12 13:44:12 +00:00
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
EditorAssetLibraryItem *item = memnew(EditorAssetLibraryItem);
Update asset library editor plugin - new functionality and fixes
2016-06-07 18:29:15 +00:00
asset_items->add_child(item);
Remove some references to unimplemented features in the assetlib This removes rating icons and the associated sorting option as this feature wasn't implemented (and is unlikely to be in the near future). This also renames "Cost" to "License", as the "cost" field refers to SPDX license names on the Godot Asset Library.
2019-06-12 10:24:08 +00:00
item->configure(r["title"], r["asset_id"], category_map[r["category_id"]], r["category_id"], r["author"], r["author_id"], r["cost"]);
Signals: Port connect calls to use callable_mp Remove now unnecessary bindings of signal callbacks in the public API. There might be some false positives that need rebinding if they were meant to be public. No regular expressions were harmed in the making of this commit. (Nah, just kidding.)
2020-02-21 17:28:45 +00:00
item->connect("asset_selected", callable_mp(this, &EditorAssetLibrary::_select_asset));
item->connect("author_selected", callable_mp(this, &EditorAssetLibrary::_select_author));
item->connect("category_selected", callable_mp(this, &EditorAssetLibrary::_select_category));
-Work on addon editor plugin (disabled by default) -New HTTPRequest node, to make HTTP requests simpler.
2016-03-04 14:09:45 +00:00
Replace String comparisons with "", String() to is_empty() Also: - Adds two stress tests to test_string.h - Changes to .empty() on std::strings
2021-12-09 09:42:46 +00:00
if (r.has("icon_url") && !r["icon_url"].operator String().is_empty()) {
Makes all Godot API's methods Lower Case
2017-08-07 10:17:31 +00:00
_request_image(item->get_instance_id(), r["icon_url"], IMAGE_QUEUE_ICON, 0);
Update asset library editor plugin - new functionality and fixes
2016-06-07 18:29:15 +00:00
}
}
Asset Library: Scroll up the ScrollContainer after page load
2020-12-09 14:24:26 +00:00
Rename empty() to is_empty()
2020-12-15 12:04:21 +00:00
if (!result.is_empty()) {
Asset Library: Scroll up the ScrollContainer after page load
2020-12-09 14:24:26 +00:00
library_scroll->set_v_scroll(0);
}
Update asset library editor plugin - new functionality and fixes
2016-06-07 18:29:15 +00:00
} break;
case REQUESTING_ASSET: {
Dictionary r = d;
ERR_FAIL_COND(!r.has("title"));
ERR_FAIL_COND(!r.has("asset_id"));
ERR_FAIL_COND(!r.has("author"));
ERR_FAIL_COND(!r.has("author_id"));
ERR_FAIL_COND(!r.has("version"));
ERR_FAIL_COND(!r.has("version_string"));
ERR_FAIL_COND(!r.has("category_id"));
ERR_FAIL_COND(!category_map.has(r["category_id"]));
ERR_FAIL_COND(!r.has("cost"));
ERR_FAIL_COND(!r.has("description"));
ERR_FAIL_COND(!r.has("download_url"));
Check hashes when downloading assets
2016-06-21 12:38:29 +00:00
ERR_FAIL_COND(!r.has("download_hash"));
Update asset library editor plugin - new functionality and fixes
2016-06-07 18:29:15 +00:00
ERR_FAIL_COND(!r.has("browse_url"));
if (description) {
memdelete(description);
}
-Work on addon editor plugin (disabled by default) -New HTTPRequest node, to make HTTP requests simpler.
2016-03-04 14:09:45 +00:00
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
description = memnew(EditorAssetLibraryItemDescription);
Update asset library editor plugin - new functionality and fixes
2016-06-07 18:29:15 +00:00
add_child(description);
Working multiple window support, including editor
2020-03-06 17:00:16 +00:00
description->popup_centered();
Signals: Port connect calls to use callable_mp Remove now unnecessary bindings of signal callbacks in the public API. There might be some false positives that need rebinding if they were meant to be public. No regular expressions were harmed in the making of this commit. (Nah, just kidding.)
2020-02-21 17:28:45 +00:00
description->connect("confirmed", callable_mp(this, &EditorAssetLibrary::_install_asset));
-Work on addon editor plugin (disabled by default) -New HTTPRequest node, to make HTTP requests simpler.
2016-03-04 14:09:45 +00:00
Remove some references to unimplemented features in the assetlib This removes rating icons and the associated sorting option as this feature wasn't implemented (and is unlikely to be in the near future). This also renames "Cost" to "License", as the "cost" field refers to SPDX license names on the Godot Asset Library.
2019-06-12 10:24:08 +00:00
description->configure(r["title"], r["asset_id"], category_map[r["category_id"]], r["category_id"], r["author"], r["author_id"], r["cost"], r["version"], r["version_string"], r["description"], r["download_url"], r["browse_url"], r["download_hash"]);
-Work on addon editor plugin (disabled by default) -New HTTPRequest node, to make HTTP requests simpler.
2016-03-04 14:09:45 +00:00
Make assets in progress open the next step instead of erring
2022-01-19 01:37:38 +00:00
EditorAssetLibraryItemDownload *download_item = _get_asset_in_progress(description->get_asset_id());
if (download_item) {
Fix Asset Library UX when an asset is being downloaded
2022-01-19 16:16:17 +00:00
if (download_item->can_install()) {
description->get_ok_button()->set_text(TTR("Install"));
description->get_ok_button()->set_disabled(false);
} else {
description->get_ok_button()->set_text(TTR("Downloading..."));
description->get_ok_button()->set_disabled(true);
}
Make assets in progress open the next step instead of erring
2022-01-19 01:37:38 +00:00
} else {
description->get_ok_button()->set_text(TTR("Download"));
Fix Asset Library UX when an asset is being downloaded
2022-01-19 16:16:17 +00:00
description->get_ok_button()->set_disabled(false);
Make assets in progress open the next step instead of erring
2022-01-19 01:37:38 +00:00
}
Replace String comparisons with "", String() to is_empty() Also: - Adds two stress tests to test_string.h - Changes to .empty() on std::strings
2021-12-09 09:42:46 +00:00
if (r.has("icon_url") && !r["icon_url"].operator String().is_empty()) {
Makes all Godot API's methods Lower Case
2017-08-07 10:17:31 +00:00
_request_image(description->get_instance_id(), r["icon_url"], IMAGE_QUEUE_ICON, 0);
Update asset library editor plugin - new functionality and fixes
2016-06-07 18:29:15 +00:00
}
-Work on addon editor plugin (disabled by default) -New HTTPRequest node, to make HTTP requests simpler.
2016-03-04 14:09:45 +00:00
Update asset library editor plugin - new functionality and fixes
2016-06-07 18:29:15 +00:00
if (d.has("previews")) {
Array previews = d["previews"];
-Work on addon editor plugin (disabled by default) -New HTTPRequest node, to make HTTP requests simpler.
2016-03-04 14:09:45 +00:00
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
for (int i = 0; i < previews.size(); i++) {
Dictionary p = previews[i];
-Work on addon editor plugin (disabled by default) -New HTTPRequest node, to make HTTP requests simpler.
2016-03-04 14:09:45 +00:00
Update asset library editor plugin - new functionality and fixes
2016-06-07 18:29:15 +00:00
ERR_CONTINUE(!p.has("type"));
ERR_CONTINUE(!p.has("link"));
-Work on addon editor plugin (disabled by default) -New HTTPRequest node, to make HTTP requests simpler.
2016-03-04 14:09:45 +00:00
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
bool is_video = p.has("type") && String(p["type"]) == "video";
Update asset library editor plugin - new functionality and fixes
2016-06-07 18:29:15 +00:00
String video_url;
if (is_video && p.has("link")) {
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
video_url = p["link"];
Update asset library editor plugin - new functionality and fixes
2016-06-07 18:29:15 +00:00
}
-Work on addon editor plugin (disabled by default) -New HTTPRequest node, to make HTTP requests simpler.
2016-03-04 14:09:45 +00:00
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
description->add_preview(i, is_video, video_url);
-Work on addon editor plugin (disabled by default) -New HTTPRequest node, to make HTTP requests simpler.
2016-03-04 14:09:45 +00:00
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
if (p.has("thumbnail")) {
Makes all Godot API's methods Lower Case
2017-08-07 10:17:31 +00:00
_request_image(description->get_instance_id(), p["thumbnail"], IMAGE_QUEUE_THUMBNAIL, i);
Update asset library editor plugin - new functionality and fixes
2016-06-07 18:29:15 +00:00
}
Improve preview and screenshot display in the asset library Images are now resized with Lanczos interpolation for higher quality. Video thumbnails now display a "pointing hand" cursor when hovered as they will open in an external browser.
2019-07-18 17:48:47 +00:00
if (!is_video) {
Makes all Godot API's methods Lower Case
2017-08-07 10:17:31 +00:00
_request_image(description->get_instance_id(), p["link"], IMAGE_QUEUE_SCREENSHOT, i);
Update asset library editor plugin - new functionality and fixes
2016-06-07 18:29:15 +00:00
}
-Work on addon editor plugin (disabled by default) -New HTTPRequest node, to make HTTP requests simpler.
2016-03-04 14:09:45 +00:00
}
}
Update asset library editor plugin - new functionality and fixes
2016-06-07 18:29:15 +00:00
} break;
Style: clang-format: Disable AllowShortCaseLabelsOnASingleLine Part of #33027.
2020-05-10 11:00:47 +00:00
default:
break;
-Work on addon editor plugin (disabled by default) -New HTTPRequest node, to make HTTP requests simpler.
2016-03-04 14:09:45 +00:00
}
}
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
void EditorAssetLibrary::_asset_file_selected(const String &p_file) {
-Made editor support SSL certs by default (embedded them) -Made asset sharing support https -Many fixes to HTTPRequest -Added an asset installer dialog -Visual cleanups to asset sharing tab -Fixed some issues in ScrollContainer, hope it does not break things -Asset sharing tab is not visible (hidden on purpose) for now.
2016-03-12 13:44:12 +00:00
if (asset_installer) {
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
memdelete(asset_installer);
Replace NULL with nullptr
2020-04-01 23:20:12 +00:00
asset_installer = nullptr;
-Made editor support SSL certs by default (embedded them) -Made asset sharing support https -Many fixes to HTTPRequest -Added an asset installer dialog -Visual cleanups to asset sharing tab -Fixed some issues in ScrollContainer, hope it does not break things -Asset sharing tab is not visible (hidden on purpose) for now.
2016-03-12 13:44:12 +00:00
}
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
asset_installer = memnew(EditorAssetInstaller);
Automatically display the installer after downloading an asset - To make things easier to follow, display the asset name in confirmation dialogs. - Display the number of conflicting files in the asset extraction dialog. This reduces the number of clicks required to install an asset.
2021-04-06 15:37:55 +00:00
asset_installer->set_asset_name(p_file.get_basename());
-Made editor support SSL certs by default (embedded them) -Made asset sharing support https -Many fixes to HTTPRequest -Added an asset installer dialog -Visual cleanups to asset sharing tab -Fixed some issues in ScrollContainer, hope it does not break things -Asset sharing tab is not visible (hidden on purpose) for now.
2016-03-12 13:44:12 +00:00
add_child(asset_installer);
asset_installer->open(p_file);
}
Added asset library on project manager for templates
2016-06-08 12:25:47 +00:00
void EditorAssetLibrary::_asset_open() {
Resize dialogs (FileDialog, EditorFileDialog, Reparent, SceneTreeDialog and resource depency dialogs).
2020-07-11 16:45:19 +00:00
asset_open->popup_file_dialog();
-Made editor support SSL certs by default (embedded them) -Made asset sharing support https -Many fixes to HTTPRequest -Added an asset installer dialog -Visual cleanups to asset sharing tab -Fixed some issues in ScrollContainer, hope it does not break things -Asset sharing tab is not visible (hidden on purpose) for now.
2016-03-12 13:44:12 +00:00
}
Added asset library on project manager for templates
2016-06-08 12:25:47 +00:00
void EditorAssetLibrary::_manage_plugins() {
-Renamed GlobalConfig to ProjectSettings, makes more sense. -Added system for feature overrides, it's pretty cool :)
2017-07-19 20:00:46 +00:00
ProjectSettingsEditor::get_singleton()->popup_project_settings();
ProjectSettingsEditor::get_singleton()->set_plugins_page();
-Made editor support SSL certs by default (embedded them) -Made asset sharing support https -Many fixes to HTTPRequest -Added an asset installer dialog -Visual cleanups to asset sharing tab -Fixed some issues in ScrollContainer, hope it does not break things -Asset sharing tab is not visible (hidden on purpose) for now.
2016-03-12 13:44:12 +00:00
}
Make assets in progress open the next step instead of erring
2022-01-19 01:37:38 +00:00
EditorAssetLibraryItemDownload *EditorAssetLibrary::_get_asset_in_progress(int p_asset_id) const {
for (int i = 0; i < downloads_hb->get_child_count(); i++) {
EditorAssetLibraryItemDownload *d = Object::cast_to<EditorAssetLibraryItemDownload>(downloads_hb->get_child(i));
if (d && d->get_asset_id() == p_asset_id) {
return d;
}
}
return nullptr;
}
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
void EditorAssetLibrary::_install_external_asset(String p_zip_path, String p_title) {
Optimize StringName usage * Added a new macro SNAME() that constructs and caches a local stringname. * Subsequent usages use the cached version. * Since these use a global static variable, a second refcounter of static usages need to be kept for cleanup time. * Replaced all theme usages by this new macro. * Replace all signal emission usages by this new macro. * Replace all call_deferred usages by this new macro. This is part of ongoing work to optimize GUI and the editor.
2021-07-17 21:22:52 +00:00
emit_signal(SNAME("install_asset"), p_zip_path, p_title);
Downloaded templates from project manager can now be installed.
2016-07-12 00:34:02 +00:00
}
Ask users to explore official projects when none is loaded.
2017-11-26 18:31:08 +00:00
void EditorAssetLibrary::disable_community_support() {
support->get_popup()->set_item_checked(SUPPORT_COMMUNITY, false);
}
Added asset library on project manager for templates
2016-06-08 12:25:47 +00:00
void EditorAssetLibrary::_bind_methods() {
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
ADD_SIGNAL(MethodInfo("install_asset", PropertyInfo(Variant::STRING, "zip_path"), PropertyInfo(Variant::STRING, "name")));
-Work on addon editor plugin (disabled by default) -New HTTPRequest node, to make HTTP requests simpler.
2016-03-04 14:09:45 +00:00
}
Added asset library on project manager for templates
2016-06-08 12:25:47 +00:00
EditorAssetLibrary::EditorAssetLibrary(bool p_templates_only) {
Fix uninitialized value
2019-02-16 15:01:20 +00:00
requesting = REQUESTING_NONE;
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
templates_only = p_templates_only;
Refresh the asset library only once on startup This avoids unnecessary calls to the API when switching between tabs in the editor or project manager.
2019-09-02 17:42:58 +00:00
initial_loading = true;
-wip on addon editor -fixes instantiable subclasses not working, as reported in #3871
2016-02-29 12:56:36 +00:00
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
VBoxContainer *library_main = memnew(VBoxContainer);
-Work on addon editor plugin (disabled by default) -New HTTPRequest node, to make HTTP requests simpler.
2016-03-04 14:09:45 +00:00
-Made editor support SSL certs by default (embedded them) -Made asset sharing support https -Many fixes to HTTPRequest -Added an asset installer dialog -Visual cleanups to asset sharing tab -Fixed some issues in ScrollContainer, hope it does not break things -Asset sharing tab is not visible (hidden on purpose) for now.
2016-03-12 13:44:12 +00:00
add_child(library_main);
-Work on addon editor plugin (disabled by default) -New HTTPRequest node, to make HTTP requests simpler.
2016-03-04 14:09:45 +00:00
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
HBoxContainer *search_hb = memnew(HBoxContainer);
-wip on addon editor -fixes instantiable subclasses not working, as reported in #3871
2016-02-29 12:56:36 +00:00
-Work on addon editor plugin (disabled by default) -New HTTPRequest node, to make HTTP requests simpler.
2016-03-04 14:09:45 +00:00
library_main->add_child(search_hb);
Revert "Add missing SNAME macro optimization to all theme methods call" This reverts commit a988fad9a092053434545c32afae91ccbdfbe792. As discussed in #57725 and clarified in #57788, `SNAME` is not meant to be used everywhere but only in critical code paths. For theme methods specifically, it was by design that only getters use `SNAME` and not setters.
2022-02-08 09:14:58 +00:00
library_main->add_theme_constant_override("separation", 10 * EDSCALE);
-wip on addon editor -fixes instantiable subclasses not working, as reported in #3871
2016-02-29 12:56:36 +00:00
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
filter = memnew(LineEdit);
Automatically focus the Search field when displaying asset library - Focus the project search box when switching from the Templates tab back to the Projects tab in the project manager. - Add a context-specific placeholder for the asset library search box. - Rename "Search" project filter box placeholder to the more descriptive "Filter projects". When performing a search on an existing selection, "Filter" is more accurate than "Search".
2021-04-04 20:47:44 +00:00
if (templates_only) {
filter->set_placeholder(TTR("Search templates, projects, and demos"));
} else {
filter->set_placeholder(TTR("Search assets (excluding templates, projects, and demos)"));
}
Fix theming update in several editor classes
2022-01-16 07:59:02 +00:00
filter->set_clear_button_enabled(true);
-wip on addon editor -fixes instantiable subclasses not working, as reported in #3871
2016-02-29 12:56:36 +00:00
search_hb->add_child(filter);
Working multiple window support, including editor
2020-03-06 17:00:16 +00:00
filter->set_h_size_flags(Control::SIZE_EXPAND_FILL);
Automatically start searching in the asset library when entering text Entering text will now start searching automatically after 0.25 seconds have passed (debounce delay). This removes the need for a separate Search button.
2020-09-29 10:43:38 +00:00
filter->connect("text_changed", callable_mp(this, &EditorAssetLibrary::_search_text_changed));
// Perform a search automatically if the user hasn't entered any text for a certain duration.
// This way, the user doesn't need to press Enter to initiate their search.
filter_debounce_timer = memnew(Timer);
filter_debounce_timer->set_one_shot(true);
filter_debounce_timer->set_wait_time(0.25);
filter_debounce_timer->connect("timeout", callable_mp(this, &EditorAssetLibrary::_filter_debounce_timer_timeout));
search_hb->add_child(filter_debounce_timer);
-Made editor support SSL certs by default (embedded them) -Made asset sharing support https -Many fixes to HTTPRequest -Added an asset installer dialog -Visual cleanups to asset sharing tab -Fixed some issues in ScrollContainer, hope it does not break things -Asset sharing tab is not visible (hidden on purpose) for now.
2016-03-12 13:44:12 +00:00
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
if (!p_templates_only) {
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
search_hb->add_child(memnew(VSeparator));
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
}
-Made editor support SSL certs by default (embedded them) -Made asset sharing support https -Many fixes to HTTPRequest -Added an asset installer dialog -Visual cleanups to asset sharing tab -Fixed some issues in ScrollContainer, hope it does not break things -Asset sharing tab is not visible (hidden on purpose) for now.
2016-03-12 13:44:12 +00:00
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
Button *open_asset = memnew(Button);
AssetLib minor fixes and enhancements
2019-08-28 04:27:26 +00:00
open_asset->set_text(TTR("Import..."));
-Made editor support SSL certs by default (embedded them) -Made asset sharing support https -Many fixes to HTTPRequest -Added an asset installer dialog -Visual cleanups to asset sharing tab -Fixed some issues in ScrollContainer, hope it does not break things -Asset sharing tab is not visible (hidden on purpose) for now.
2016-03-12 13:44:12 +00:00
search_hb->add_child(open_asset);
Signals: Port connect calls to use callable_mp Remove now unnecessary bindings of signal callbacks in the public API. There might be some false positives that need rebinding if they were meant to be public. No regular expressions were harmed in the making of this commit. (Nah, just kidding.)
2020-02-21 17:28:45 +00:00
open_asset->connect("pressed", callable_mp(this, &EditorAssetLibrary::_asset_open));
-Made editor support SSL certs by default (embedded them) -Made asset sharing support https -Many fixes to HTTPRequest -Added an asset installer dialog -Visual cleanups to asset sharing tab -Fixed some issues in ScrollContainer, hope it does not break things -Asset sharing tab is not visible (hidden on purpose) for now.
2016-03-12 13:44:12 +00:00
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
Button *plugins = memnew(Button);
AssetLib minor fixes and enhancements
2019-08-28 04:27:26 +00:00
plugins->set_text(TTR("Plugins..."));
-Made editor support SSL certs by default (embedded them) -Made asset sharing support https -Many fixes to HTTPRequest -Added an asset installer dialog -Visual cleanups to asset sharing tab -Fixed some issues in ScrollContainer, hope it does not break things -Asset sharing tab is not visible (hidden on purpose) for now.
2016-03-12 13:44:12 +00:00
search_hb->add_child(plugins);
Signals: Port connect calls to use callable_mp Remove now unnecessary bindings of signal callbacks in the public API. There might be some false positives that need rebinding if they were meant to be public. No regular expressions were harmed in the making of this commit. (Nah, just kidding.)
2020-02-21 17:28:45 +00:00
plugins->connect("pressed", callable_mp(this, &EditorAssetLibrary::_manage_plugins));
-Made editor support SSL certs by default (embedded them) -Made asset sharing support https -Many fixes to HTTPRequest -Added an asset installer dialog -Visual cleanups to asset sharing tab -Fixed some issues in ScrollContainer, hope it does not break things -Asset sharing tab is not visible (hidden on purpose) for now.
2016-03-12 13:44:12 +00:00
Added asset library on project manager for templates
2016-06-08 12:25:47 +00:00
if (p_templates_only) {
open_asset->hide();
plugins->hide();
}
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
HBoxContainer *search_hb2 = memnew(HBoxContainer);
-Work on addon editor plugin (disabled by default) -New HTTPRequest node, to make HTTP requests simpler.
2016-03-04 14:09:45 +00:00
library_main->add_child(search_hb2);
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
search_hb2->add_child(memnew(Label(TTR("Sort:") + " ")));
sort = memnew(OptionButton);
for (int i = 0; i < SORT_MAX; i++) {
Make more editor strings translatable
2019-12-13 08:07:45 +00:00
sort->add_item(TTRGET(sort_text[i]));
-Work on addon editor plugin (disabled by default) -New HTTPRequest node, to make HTTP requests simpler.
2016-03-04 14:09:45 +00:00
}
-wip on addon editor -fixes instantiable subclasses not working, as reported in #3871
2016-02-29 12:56:36 +00:00
-Work on addon editor plugin (disabled by default) -New HTTPRequest node, to make HTTP requests simpler.
2016-03-04 14:09:45 +00:00
search_hb2->add_child(sort);
Working multiple window support, including editor
2020-03-06 17:00:16 +00:00
sort->set_h_size_flags(Control::SIZE_EXPAND_FILL);
Signals: Port connect calls to use callable_mp Remove now unnecessary bindings of signal callbacks in the public API. There might be some false positives that need rebinding if they were meant to be public. No regular expressions were harmed in the making of this commit. (Nah, just kidding.)
2020-02-21 17:28:45 +00:00
sort->connect("item_selected", callable_mp(this, &EditorAssetLibrary::_rerun_search));
-Work on addon editor plugin (disabled by default) -New HTTPRequest node, to make HTTP requests simpler.
2016-03-04 14:09:45 +00:00
search_hb2->add_child(memnew(VSeparator));
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
search_hb2->add_child(memnew(Label(TTR("Category:") + " ")));
categories = memnew(OptionButton);
i18n: Proofreading of all strings Done to ensure that no important identifiers are translatable, to fix compound strings using the new vformat() function, and some general English proofreading here and there.
2016-05-18 22:08:12 +00:00
categories->add_item(TTR("All"));
-Work on addon editor plugin (disabled by default) -New HTTPRequest node, to make HTTP requests simpler.
2016-03-04 14:09:45 +00:00
search_hb2->add_child(categories);
Working multiple window support, including editor
2020-03-06 17:00:16 +00:00
categories->set_h_size_flags(Control::SIZE_EXPAND_FILL);
Signals: Port connect calls to use callable_mp Remove now unnecessary bindings of signal callbacks in the public API. There might be some false positives that need rebinding if they were meant to be public. No regular expressions were harmed in the making of this commit. (Nah, just kidding.)
2020-02-21 17:28:45 +00:00
categories->connect("item_selected", callable_mp(this, &EditorAssetLibrary::_rerun_search));
-wip on addon editor -fixes instantiable subclasses not working, as reported in #3871
2016-02-29 12:56:36 +00:00
-Work on addon editor plugin (disabled by default) -New HTTPRequest node, to make HTTP requests simpler.
2016-03-04 14:09:45 +00:00
search_hb2->add_child(memnew(VSeparator));
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
search_hb2->add_child(memnew(Label(TTR("Site:") + " ")));
repository = memnew(OptionButton);
-Work on addon editor plugin (disabled by default) -New HTTPRequest node, to make HTTP requests simpler.
2016-03-04 14:09:45 +00:00
Fix Asset Library URL not updating after been changed in editor settings The changes made in this commit refresh the URL OptionButton when editor settings are modified. No need to restart any more for the changes to appear in the Asset Library. Fix #46977
2021-03-13 21:55:59 +00:00
_update_repository_options();
Enable asset store for godot 3.0
2017-11-09 10:55:30 +00:00
Signals: Port connect calls to use callable_mp Remove now unnecessary bindings of signal callbacks in the public API. There might be some false positives that need rebinding if they were meant to be public. No regular expressions were harmed in the making of this commit. (Nah, just kidding.)
2020-02-21 17:28:45 +00:00
repository->connect("item_selected", callable_mp(this, &EditorAssetLibrary::_repository_changed));
Update asset library editor plugin - new functionality and fixes
2016-06-07 18:29:15 +00:00
-Work on addon editor plugin (disabled by default) -New HTTPRequest node, to make HTTP requests simpler.
2016-03-04 14:09:45 +00:00
search_hb2->add_child(repository);
Working multiple window support, including editor
2020-03-06 17:00:16 +00:00
repository->set_h_size_flags(Control::SIZE_EXPAND_FILL);
-Work on addon editor plugin (disabled by default) -New HTTPRequest node, to make HTTP requests simpler.
2016-03-04 14:09:45 +00:00
Fixed some options in assetlib
2016-06-08 13:17:16 +00:00
search_hb2->add_child(memnew(VSeparator));
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
support = memnew(MenuButton);
Fixed some options in assetlib
2016-06-08 13:17:16 +00:00
search_hb2->add_child(support);
AssetLib minor fixes and enhancements
2019-08-28 04:27:26 +00:00
support->set_text(TTR("Support"));
mod: pop-up usability enhancement for support button Now after choosing support level pop-up doesn't hide after each click
2021-03-07 19:51:40 +00:00
support->get_popup()->set_hide_on_checkable_item_selection(false);
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
support->get_popup()->add_check_item(TTR("Official"), SUPPORT_OFFICIAL);
support->get_popup()->add_check_item(TTR("Community"), SUPPORT_COMMUNITY);
support->get_popup()->add_check_item(TTR("Testing"), SUPPORT_TESTING);
support->get_popup()->set_item_checked(SUPPORT_OFFICIAL, true);
support->get_popup()->set_item_checked(SUPPORT_COMMUNITY, true);
Signals: Port connect calls to use callable_mp Remove now unnecessary bindings of signal callbacks in the public API. There might be some false positives that need rebinding if they were meant to be public. No regular expressions were harmed in the making of this commit. (Nah, just kidding.)
2020-02-21 17:28:45 +00:00
support->get_popup()->connect("id_pressed", callable_mp(this, &EditorAssetLibrary::_support_toggled));
Fixed some options in assetlib
2016-06-08 13:17:16 +00:00
-Work on addon editor plugin (disabled by default) -New HTTPRequest node, to make HTTP requests simpler.
2016-03-04 14:09:45 +00:00
/////////
fixed loading old theme styleboxes
2017-08-04 19:41:31 +00:00
library_scroll_bg = memnew(PanelContainer);
-Work on addon editor plugin (disabled by default) -New HTTPRequest node, to make HTTP requests simpler.
2016-03-04 14:09:45 +00:00
library_main->add_child(library_scroll_bg);
Working multiple window support, including editor
2020-03-06 17:00:16 +00:00
library_scroll_bg->set_v_size_flags(Control::SIZE_EXPAND_FILL);
-Work on addon editor plugin (disabled by default) -New HTTPRequest node, to make HTTP requests simpler.
2016-03-04 14:09:45 +00:00
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
library_scroll = memnew(ScrollContainer);
ScrollContainer's scrollbar visibility is now enum
2021-12-07 16:15:18 +00:00
library_scroll->set_horizontal_scroll_mode(ScrollContainer::SCROLL_MODE_DISABLED);
-Work on addon editor plugin (disabled by default) -New HTTPRequest node, to make HTTP requests simpler.
2016-03-04 14:09:45 +00:00
library_scroll_bg->add_child(library_scroll);
Ref<StyleBoxEmpty> border2;
Rename `instance()`->`instantiate()` when it's a verb
2021-06-17 22:03:09 +00:00
border2.instantiate();
Rename Control margin to offset
2020-12-22 16:24:29 +00:00
border2->set_default_margin(SIDE_LEFT, 15 * EDSCALE);
border2->set_default_margin(SIDE_RIGHT, 35 * EDSCALE);
border2->set_default_margin(SIDE_BOTTOM, 15 * EDSCALE);
border2->set_default_margin(SIDE_TOP, 15 * EDSCALE);
-Work on addon editor plugin (disabled by default) -New HTTPRequest node, to make HTTP requests simpler.
2016-03-04 14:09:45 +00:00
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
PanelContainer *library_vb_border = memnew(PanelContainer);
-Work on addon editor plugin (disabled by default) -New HTTPRequest node, to make HTTP requests simpler.
2016-03-04 14:09:45 +00:00
library_scroll->add_child(library_vb_border);
Revert "Add missing SNAME macro optimization to all theme methods call" This reverts commit a988fad9a092053434545c32afae91ccbdfbe792. As discussed in #57725 and clarified in #57788, `SNAME` is not meant to be used everywhere but only in critical code paths. For theme methods specifically, it was by design that only getters use `SNAME` and not setters.
2022-02-08 09:14:58 +00:00
library_vb_border->add_theme_style_override("panel", border2);
Working multiple window support, including editor
2020-03-06 17:00:16 +00:00
library_vb_border->set_h_size_flags(Control::SIZE_EXPAND_FILL);
-Work on addon editor plugin (disabled by default) -New HTTPRequest node, to make HTTP requests simpler.
2016-03-04 14:09:45 +00:00
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
library_vb = memnew(VBoxContainer);
Working multiple window support, including editor
2020-03-06 17:00:16 +00:00
library_vb->set_h_size_flags(Control::SIZE_EXPAND_FILL);
-Work on addon editor plugin (disabled by default) -New HTTPRequest node, to make HTTP requests simpler.
2016-03-04 14:09:45 +00:00
library_vb_border->add_child(library_vb);
Improve loading UX in the asset library The asset library will now fade when loading pages instead of displaying a progress bar, which is a more common design pattern when browsing an online resource's pages. A "Loading..." text will be displayed before the first page loads.
2019-08-24 01:04:59 +00:00
library_loading = memnew(Label(TTR("Loading...")));
align to horizontal_alignment, valign to vertical_alignment, related
2021-11-25 02:58:47 +00:00
library_loading->set_horizontal_alignment(HORIZONTAL_ALIGNMENT_CENTER);
Improve loading UX in the asset library The asset library will now fade when loading pages instead of displaying a progress bar, which is a more common design pattern when browsing an online resource's pages. A "Loading..." text will be displayed before the first page loads.
2019-08-24 01:04:59 +00:00
library_vb->add_child(library_loading);
Display a message if no results are found in the asset library This closes https://github.com/godotengine/godot-proposals/issues/184.
2019-10-25 23:07:02 +00:00
library_error = memnew(Label);
align to horizontal_alignment, valign to vertical_alignment, related
2021-11-25 02:58:47 +00:00
library_error->set_horizontal_alignment(HORIZONTAL_ALIGNMENT_CENTER);
Display a message if no results are found in the asset library This closes https://github.com/godotengine/godot-proposals/issues/184.
2019-10-25 23:07:02 +00:00
library_error->hide();
library_vb->add_child(library_error);
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
asset_top_page = memnew(HBoxContainer);
-Work on addon editor plugin (disabled by default) -New HTTPRequest node, to make HTTP requests simpler.
2016-03-04 14:09:45 +00:00
library_vb->add_child(asset_top_page);
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
asset_items = memnew(GridContainer);
-Work on addon editor plugin (disabled by default) -New HTTPRequest node, to make HTTP requests simpler.
2016-03-04 14:09:45 +00:00
asset_items->set_columns(2);
Revert "Add missing SNAME macro optimization to all theme methods call" This reverts commit a988fad9a092053434545c32afae91ccbdfbe792. As discussed in #57725 and clarified in #57788, `SNAME` is not meant to be used everywhere but only in critical code paths. For theme methods specifically, it was by design that only getters use `SNAME` and not setters.
2022-02-08 09:14:58 +00:00
asset_items->add_theme_constant_override("hseparation", 10 * EDSCALE);
asset_items->add_theme_constant_override("vseparation", 10 * EDSCALE);
-Work on addon editor plugin (disabled by default) -New HTTPRequest node, to make HTTP requests simpler.
2016-03-04 14:09:45 +00:00
library_vb->add_child(asset_items);
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
asset_bottom_page = memnew(HBoxContainer);
-Work on addon editor plugin (disabled by default) -New HTTPRequest node, to make HTTP requests simpler.
2016-03-04 14:09:45 +00:00
library_vb->add_child(asset_bottom_page);
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
request = memnew(HTTPRequest);
-Work on addon editor plugin (disabled by default) -New HTTPRequest node, to make HTTP requests simpler.
2016-03-04 14:09:45 +00:00
add_child(request);
Add proxy support for the editor * Adds proxy support for `HTTPRequest`. * Adds `network/http_proxy/{host,port}` editor settings. * Labeled as "HTTP Proxy" and it will be used for both HTTP and HTTPS requests. This is the same convention as seen in Android Studio's proxy settings. * Makes Asset Library and Export Template Manager use proxy according to the editor settings.
2021-12-09 03:34:32 +00:00
setup_http_request(request);
Signals: Port connect calls to use callable_mp Remove now unnecessary bindings of signal callbacks in the public API. There might be some false positives that need rebinding if they were meant to be public. No regular expressions were harmed in the making of this commit. (Nah, just kidding.)
2020-02-21 17:28:45 +00:00
request->connect("request_completed", callable_mp(this, &EditorAssetLibrary::_http_request_completed));
-wip on addon editor -fixes instantiable subclasses not working, as reported in #3871
2016-02-29 12:56:36 +00:00
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
last_queue_id = 0;
-wip on addon editor -fixes instantiable subclasses not working, as reported in #3871
2016-02-29 12:56:36 +00:00
Revert "Add missing SNAME macro optimization to all theme methods call" This reverts commit a988fad9a092053434545c32afae91ccbdfbe792. As discussed in #57725 and clarified in #57788, `SNAME` is not meant to be used everywhere but only in critical code paths. For theme methods specifically, it was by design that only getters use `SNAME` and not setters.
2022-02-08 09:14:58 +00:00
library_vb->add_theme_constant_override("separation", 20 * EDSCALE);
-wip on addon editor -fixes instantiable subclasses not working, as reported in #3871
2016-02-29 12:56:36 +00:00
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
error_hb = memnew(HBoxContainer);
-more progress to asset sharing client, but still disabled by default
2016-03-05 15:24:12 +00:00
library_main->add_child(error_hb);
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
error_label = memnew(Label);
-more progress to asset sharing client, but still disabled by default
2016-03-05 15:24:12 +00:00
error_hb->add_child(error_label);
Update icons when theme changed
2018-02-25 16:04:16 +00:00
error_tr = memnew(TextureRect);
Center error icon vertically in AssetLib
2019-12-16 01:24:02 +00:00
error_tr->set_v_size_flags(Control::SIZE_SHRINK_CENTER);
Update icons when theme changed
2018-02-25 16:04:16 +00:00
error_hb->add_child(error_tr);
-more progress to asset sharing client, but still disabled by default
2016-03-05 15:24:12 +00:00
Replace NULL with nullptr
2020-04-01 23:20:12 +00:00
description = nullptr;
-wip on addon editor -fixes instantiable subclasses not working, as reported in #3871
2016-02-29 12:56:36 +00:00
-more progress to asset sharing client, but still disabled by default
2016-03-05 15:24:12 +00:00
set_process(true);
Implement new shortcuts system. unhandled_key_input changed to unhandled_button_input. Controls can set a 'shortcut_context' which they can then use to determine if their shortcuts should be triggered or not, based on if the viewport's focused GUI control is a child of their 'shortcut context'.
2020-09-17 01:40:00 +00:00
set_process_unhandled_key_input(true); // Global shortcuts since there is no main element to be focused.
-Made editor support SSL certs by default (embedded them) -Made asset sharing support https -Many fixes to HTTPRequest -Added an asset installer dialog -Visual cleanups to asset sharing tab -Fixed some issues in ScrollContainer, hope it does not break things -Asset sharing tab is not visible (hidden on purpose) for now.
2016-03-12 13:44:12 +00:00
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
downloads_scroll = memnew(ScrollContainer);
ScrollContainer's scrollbar visibility is now enum
2021-12-07 16:15:18 +00:00
downloads_scroll->set_vertical_scroll_mode(ScrollContainer::SCROLL_MODE_DISABLED);
-Made editor support SSL certs by default (embedded them) -Made asset sharing support https -Many fixes to HTTPRequest -Added an asset installer dialog -Visual cleanups to asset sharing tab -Fixed some issues in ScrollContainer, hope it does not break things -Asset sharing tab is not visible (hidden on purpose) for now.
2016-03-12 13:44:12 +00:00
library_main->add_child(downloads_scroll);
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
downloads_hb = memnew(HBoxContainer);
-Made editor support SSL certs by default (embedded them) -Made asset sharing support https -Many fixes to HTTPRequest -Added an asset installer dialog -Visual cleanups to asset sharing tab -Fixed some issues in ScrollContainer, hope it does not break things -Asset sharing tab is not visible (hidden on purpose) for now.
2016-03-12 13:44:12 +00:00
downloads_scroll->add_child(downloads_hb);
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
asset_open = memnew(EditorFileDialog);
-Made editor support SSL certs by default (embedded them) -Made asset sharing support https -Many fixes to HTTPRequest -Added an asset installer dialog -Visual cleanups to asset sharing tab -Fixed some issues in ScrollContainer, hope it does not break things -Asset sharing tab is not visible (hidden on purpose) for now.
2016-03-12 13:44:12 +00:00
asset_open->set_access(EditorFileDialog::ACCESS_FILESYSTEM);
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
asset_open->add_filter("*.zip ; " + TTR("Assets ZIP File"));
Working multiple window support, including editor
2020-03-06 17:00:16 +00:00
asset_open->set_file_mode(EditorFileDialog::FILE_MODE_OPEN_FILE);
-Made editor support SSL certs by default (embedded them) -Made asset sharing support https -Many fixes to HTTPRequest -Added an asset installer dialog -Visual cleanups to asset sharing tab -Fixed some issues in ScrollContainer, hope it does not break things -Asset sharing tab is not visible (hidden on purpose) for now.
2016-03-12 13:44:12 +00:00
add_child(asset_open);
Signals: Port connect calls to use callable_mp Remove now unnecessary bindings of signal callbacks in the public API. There might be some false positives that need rebinding if they were meant to be public. No regular expressions were harmed in the making of this commit. (Nah, just kidding.)
2020-02-21 17:28:45 +00:00
asset_open->connect("file_selected", callable_mp(this, &EditorAssetLibrary::_asset_file_selected));
-Made editor support SSL certs by default (embedded them) -Made asset sharing support https -Many fixes to HTTPRequest -Added an asset installer dialog -Visual cleanups to asset sharing tab -Fixed some issues in ScrollContainer, hope it does not break things -Asset sharing tab is not visible (hidden on purpose) for now.
2016-03-12 13:44:12 +00:00
Replace NULL with nullptr
2020-04-01 23:20:12 +00:00
asset_installer = nullptr;
-wip on addon editor -fixes instantiable subclasses not working, as reported in #3871
2016-02-29 12:56:36 +00:00
}
///////
Update asset library editor plugin - new functionality and fixes
2016-06-07 18:29:15 +00:00
void AssetLibraryEditorPlugin::make_visible(bool p_visible) {
-wip on addon editor -fixes instantiable subclasses not working, as reported in #3871
2016-02-29 12:56:36 +00:00
if (p_visible) {
addon_library->show();
} else {
addon_library->hide();
}
}
Remove most EditorNode constructor parameters and fields
2022-01-27 09:36:51 +00:00
AssetLibraryEditorPlugin::AssetLibraryEditorPlugin() {
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
addon_library = memnew(EditorAssetLibrary);
-wip on addon editor -fixes instantiable subclasses not working, as reported in #3871
2016-02-29 12:56:36 +00:00
addon_library->set_v_size_flags(Control::SIZE_EXPAND_FILL);
Remove most EditorNode constructor parameters and fields
2022-01-27 09:36:51 +00:00
EditorNode::get_singleton()->get_main_control()->add_child(addon_library);
Rename Control margin to offset
2020-12-22 16:24:29 +00:00
addon_library->set_anchors_and_offsets_preset(Control::PRESET_WIDE);
-wip on addon editor -fixes instantiable subclasses not working, as reported in #3871
2016-02-29 12:56:36 +00:00
addon_library->hide();
}
Update asset library editor plugin - new functionality and fixes
2016-06-07 18:29:15 +00:00
AssetLibraryEditorPlugin::~AssetLibraryEditorPlugin() {
-wip on addon editor -fixes instantiable subclasses not working, as reported in #3871
2016-02-29 12:56:36 +00:00
}