Rémi Verschelde
39cece382d
Merge pull request #68170 from alfredbaudisch/clear-selection-shortcut
...
Unified shortcut to clear carets and selections from TextEdit
2022-11-02 18:54:19 +01:00
Rémi Verschelde
7488b4724e
Merge pull request #67788 from 98teg/flow-container-alignment
...
Add alignment options to flow container
2022-11-02 18:52:53 +01:00
Alfred Reinold Baudisch
a862583d05
Unified shortcut to clear carets and selections
...
Refactors`ui_text_remove_secondary_carets` from https://github.com/godotengine/godot/pull/68089 as `ui_text_clear_carets_and_selection`, with extra behaviour:
- If there's only one active caret active with a selection, clears the selection.
- In case there's more than one caret active, removes the secondary carets and clears selections.
With this change, `TextEdit` then imitates the behaviour of VSCode for clearing carets and selections.
2022-11-02 18:23:24 +01:00
Rémi Verschelde
06c8e406e4
Merge pull request #63335 from Spartan322/button-shortcut-feedback
...
Make `BaseButton` Shortcut feedback togglable
2022-11-02 17:14:00 +01:00
kobewi
84d6549c75
Change hue icons to horizontal GradientTexture2D
2022-11-02 15:34:15 +01:00
kobewi
f5981ff19d
Add a separate hue gradient for OKHSL mode
2022-11-02 14:44:41 +01:00
Rémi Verschelde
eddaab17ea
Merge pull request #63562 from Rindbee/better-scroll-conditions
...
Use more reasonable scrollable conditions in `ScrollContainer`
2022-11-02 14:21:21 +01:00
Rémi Verschelde
87cdc2ea60
Merge pull request #67994 from YeldhamDev/how_suggestive
...
Stop centering clicked suggestions in the autocomplete popup
2022-11-02 14:15:32 +01:00
kobewi
4aa1efb0fe
Add set_value_no_signal() to Range
2022-10-31 23:59:01 +01:00
Alfred Reinold Baudisch
fcff978763
Shortcut and Bind to Remove Secondary Carets
...
Adds the bind `ui_text_remove_secondary_carets` to TextEdit, with ESC as the default shortcut.
When the bind is performed, if the TextEdit has multiple carets, `remove_secondary_carets` is called and secondary carets are removed.
This is useful when multiple selects are performed with `add_select_for_next_occurrence` #67644 or when multiple multiple carets are manually added, then it's possible to go back to a single caret with a shortcut.
Closes #67991
2022-10-31 17:44:47 +01:00
Rémi Verschelde
5947f22be9
Merge pull request #67578 from KoBeWi/GEDITOR
...
Unify usage of GLOBAL/EDITOR_GET
2022-10-31 13:15:58 +01:00
Rémi Verschelde
be126d42d4
Merge pull request #67588 from KoBeWi/if(!GDVIRTUAL_CALL)don't
...
Simplify GDVIRTUAL_CALL calls
2022-10-31 11:55:56 +01:00
Rémi Verschelde
33c7c8020a
Merge pull request #67489 from timothyqiu/auto-select-all
...
Allow selecting SpinBox & LineEdit text when focus enters
2022-10-31 11:55:06 +01:00
Rémi Verschelde
b6cbea5e58
Merge pull request #63590 from golfinq/fbg-padding
...
Add padding options in theme for fg/bgcolor tags in RichTextLabel
2022-10-31 11:14:55 +01:00
Rémi Verschelde
8b1a42cd47
Merge pull request #67888 from KoBeWi/overridead
...
Remove `override_selected_font_color` property
2022-10-31 10:59:07 +01:00
Rémi Verschelde
420eb1aa34
Merge pull request #67445 from Zylann/rename_queue_delete
...
Rename queue_delete => queue_free
2022-10-31 10:51:18 +01:00
Rémi Verschelde
d831ba1d6f
Merge pull request #67534 from KoBeWi/more_OK_in_OKHSL
...
Improve ColorPicker sliders in OKHSL mode
2022-10-31 10:37:27 +01:00
Rémi Verschelde
68623c75b3
Merge pull request #67496 from Paulb23/text-edit-crashes
...
Fix TextEdit action and CodeEdit completion crash
2022-10-31 10:32:41 +01:00
Rémi Verschelde
273410ba5a
Merge pull request #67139 from PucklaMotzer09/insert_caret_at_carets
...
Add Caret Insert Below and Above shortcuts to TextEdit
2022-10-31 10:32:07 +01:00
Rémi Verschelde
996f7e5142
Merge pull request #66352 from arkology/progressbar_atlastexture_radial
...
Support AtlasTexture in radial modes of TextureProgressBar
2022-10-31 10:31:07 +01:00
Haoyu Qiu
3aed3edc06
Allow selecting SpinBox & LineEdit text when focus enters
2022-10-29 09:58:42 +08:00
Michael Alexsander
4b6e6c6758
Stop centering clicked suggestions in the autocomplete popup
2022-10-28 20:22:28 -03:00
Clay John
0486810697
Merge pull request #67644 from alfredbaudisch/add-selection-next-occurrence
...
Add Selection and Caret for Next Occurrence of Selection
2022-10-27 17:21:49 -07:00
Michael Alexsander
fb8588e68e
Fix problems with `tab_changed` signal when removing multiple tabs at once
2022-10-27 03:16:01 -03:00
kobewi
c7eb814ede
Remove override_selected_font_color property
2022-10-26 12:59:18 +02:00
Marc Gilleron
7543a5e014
Rename queue_delete => queue_free
...
# Conflicts:
# editor/plugins/tiles/tiles_editor_plugin.cpp
2022-10-24 22:07:02 +01:00
Clay John
4134f2a464
Merge pull request #67566 from Sauermann/fix-code-simplifications
...
Code simplifications
2022-10-23 17:02:04 -07:00
Teggy
2b08675f37
Add alignment options to flow container
2022-10-23 13:40:17 +02:00
Alfred Reinold Baudisch
7d15ecc3af
Add Selection and Caret for Next Occurrence of Selection
...
Adds the bind `add_selection_for_next_occurrence` to TextEdit, with CTRL+D as the default shortcut.
When the bind is performed, ff a selection is currently active with the last caret in text fields, searches for the next occurrence of the selection, adds a caret and selects the next occurrence.
If no selection is currently active with the last caret in text fields, selects the word currently under the caret.
The action can be performed sequentially for all occurrences of the selection of the last caret and for all existing carets. The viewport is adjusted to the latest newly added caret.
The bind and the behaviour is similar to VS Code's "Add Selection to Next Find Match" and JetBrains' "Add Selection for Next Occurrence". It takes advantage of the multi-caret API.
The default shortcut for `select_word_under_caret` has been changed to ALT+G, in order to give priority to CTRL+D for `add_selection_for_next_occurrence` to better align with popular IDEs and editors.
2022-10-21 08:26:53 +02:00
Rindbee
075e79bf04
Improve validation when setting `max`/`min`/`page` in `Range`
...
The incoming value is validated first and then compared.
Previously, when the ScrollContainer was scrolled, the ScrollBar of
the other axis of the ScrollContainer would emit the changed signal.
This commit avoids that.
2022-10-20 14:04:09 +08:00
George L. Albany
d846dd6e91
Make `BaseButton` Shortcut feedback togglable
2022-10-20 02:02:12 -04:00
Max Hilbrunner
d148613bb1
Merge pull request #66279 from aaronfranke/control-min-size
...
Revert `custom_minimum_size` type back to `Vector2` instead of `Vector2i`
2022-10-19 22:40:52 +02:00
kobewi
d06a8320e5
Simplify GDVIRTUAL_CALL calls
2022-10-19 00:05:48 +02:00
kobewi
b42c1f82fc
Improve ColorPicker sliders in OKHSL mode
2022-10-18 23:59:55 +02:00
kobewi
e48c5daddf
Unify usage of GLOBAL/EDITOR_GET
2022-10-18 19:01:48 +02:00
Markus Sauermann
b8031bb7d6
Code simplifications
...
1. Viewport::get_visible_rect().position is always zero.
So Control::get_window_rect is identical to Control::get_global_rect.
Remove Control::get_window_rect since it is not used in the source code.
2. sqrt(a * a) = abs(a) for doubles
3. Simplify affine_inverse combination
4. Simplify calculation in shaders
2022-10-18 12:47:40 +02:00
PucklaMotzer09
e5354cacd0
Add Caret Insert Below and Above shortcuts to TextEdit
2022-10-18 10:38:53 +02:00
Rindbee
42073fc2bb
Use more reasonable scrollable conditions in `ScrollContainer`
...
The visibility of the `ScrollBar` was used as a condition for judging whether it should scroll.
**Visible** and **scrollable** are currently not the same in some cases (`SCROLL_MODE_SHOW_NEVER`).
This makes `SCROLL_MODE_SHOW_NEVER` not working properly.
This patch will make `SCROLL_MODE_SHOW_NEVER` available, so that the external `SrollBar` can
share the internal `ScrollBar`'s data, we can achieve the purpose of replacing the internal
`ScrollBar` with a custom external one.
2022-10-18 16:32:39 +08:00
arkology
825f5671f1
Support AtlasTexture in radial modes of TextureProgressBar
2022-10-17 20:44:25 +03:00
Paulb23
4bfb1d953c
Fix undo redo not adjusting TextEdit viewport to caret
2022-10-16 19:30:03 +01:00
Paulb23
b5dc8e24be
Fix crash in code completion when using an invalid / null font
2022-10-16 16:47:27 +01:00
Paulb23
76005e5ff7
Forcibly end current TextEdit action on undo redo
2022-10-16 16:28:22 +01:00
bruvzg
4b1937c73f
Abort LineEdit shaping if no font is set to avoid unnecessary error messages.
2022-10-14 12:57:42 +03:00
Rémi Verschelde
f32f5b70d8
Merge pull request #67348 from Mickeon/salvage-a-dear-comment
...
Comment not to remove `data` structs in some Nodes
2022-10-13 18:40:58 +02:00
Micky
de9e08da76
Comment not to remove `data` structs in some Nodes
2022-10-13 15:52:35 +02:00
Rémi Verschelde
2ffb609658
Merge pull request #66337 from EricEzaM/sprite-frames
...
Ensure control built-in shortcuts are matched exactly & add shortcuts for SpriteFrames editor
2022-10-13 15:24:39 +02:00
Rémi Verschelde
17db8be33c
Merge pull request #66357 from EricEzaM/shortcut-context-on-node
...
Move Shortcut Context to control and fix `shortcut_input` with `shortcut_context`
2022-10-13 15:24:30 +02:00
Eric M
a3ed9e6f2c
Move Shortcut Context to Control and ensure that `shortcut_input` adheres to contexts. Also ensure that controls with no context are only triggered AFTER nodes which do have a context.
2022-10-13 21:07:19 +10:00
MladoniSzabi
3550354fd3
fixed holding alt while zooming zooms in by 2 increments.
2022-10-13 11:38:25 +01:00
Rémi Verschelde
fad0327503
Merge pull request #66953 from Sauermann/fix-top-level-connect-error
...
Fix Control node not disconnecting from signal
2022-10-13 09:04:25 +02:00
Rémi Verschelde
15b68f7601
Merge pull request #67232 from bruvzg/popup_edit
...
Improve Popup / Window behavior in the edited scene tree.
2022-10-12 14:45:14 +02:00
Paulb23
f3eb543e67
Fix select word under caret using caret col instead of line
2022-10-11 20:32:06 +01:00
kobewi
a3661ad079
Remove editor dependencies from ColorPicker
2022-10-11 16:09:27 +02:00
Rémi Verschelde
f21053d189
Merge pull request #67201 from progsource/richtextlabel-icon-spritesheet
...
Add Spritesheet support to RichTextLabel BBCode
2022-10-11 13:58:54 +02:00
Petra Baranski
546e017613
Add Spritesheet support to RichTextLabel BBCode
...
BBCode: [img region=0,0,16,16]res://icon.svg[/img]
2022-10-11 13:04:15 +02:00
bruvzg
2e1fcbe14b
Prevent `Popup`s it the edited scene tree from closing on focus loss. Hide irrelevant `Popup` flags from the editor inspector.
2022-10-11 08:55:00 +03:00
Rémi Verschelde
8017827144
SCons: Re-enable treating `#warning` as error with `werror`
...
Replace all TODO uses of `#warning` by proper TODO comments, and will open
matching bug reports to keep track of them.
We don't have a great track record fixing TODOs, but I'd wager we're even
worse for fixing these "TODO #warning" so we should prohibit this usage.
2022-10-10 16:12:26 +02:00
Rémi Verschelde
ddb97a0b35
Merge pull request #67117 from Jummit/tree-button-color
...
Expose TreeItem::set_button_color
2022-10-10 13:52:57 +02:00
Rémi Verschelde
4be5660223
Merge pull request #67145 from Paulb23/tab_textedit
...
Fix inserting tabs in TextEdit
2022-10-10 13:52:42 +02:00
Rémi Verschelde
104af08e9d
Merge pull request #65805 from MewPurPur/improve-breakpoint-hovering
...
Improve bookmark and breakpoint indicators
2022-10-10 10:03:26 +02:00
VolTer
d6e60f45a1
Improved breakpoints hover indicator
2022-10-10 04:36:45 +02:00
Haoyu Qiu
eac9adf7a1
Don't allow removing TextEdit's main caret
2022-10-10 08:30:23 +08:00
Paulb23
7333aa68f4
Handle tab in TextEdit
2022-10-09 17:46:40 +01:00
Jummit
a6c1cfae99
Allow drag-clicking before symbol lookup
...
This makes it easier for touch and tablet users to do symbol lookups in
the code editor.
2022-10-09 18:42:54 +02:00
Rémi Verschelde
6f6482e82b
Merge pull request #67083 from RedMser/label-font-warning
...
Add warning for missing characters in label font
2022-10-09 18:29:06 +02:00
Rémi Verschelde
49be2d2cf8
Merge pull request #66524 from microaeris/aeris/text-edit-get-scroll-bar
...
Getters for TextEdit scroll bars
2022-10-09 18:27:30 +02:00
Rindbee
3f20108703
Improve caret drawing conditions for `LineEdit`
...
Now, `caret_can_draw` will be validated when a condition that affects
the drawability of the `LineEdit`'s caret changes; `draw_caret` will
be toggled when the caret's visibility is toggled due to blink, and
`draw_caret` will be `false` when `caret_blink_enabled` is disabled.
Fix toggling `caret_blink_enabled` could cause caret to no longer be
displayed.
Fix opening the context menu causing caret to no longer appear.
2022-10-09 22:14:40 +08:00
Jummit
1e28675560
Expose TreeItem::set_button_color
2022-10-09 10:37:55 +02:00
Haoyu Qiu
2a921cc9f8
Fix Label text length mismatch after localization
2022-10-08 23:07:19 +08:00
RedMser
9579d49820
Add warning for missing characters in label font
2022-10-08 17:02:25 +02:00
microaeris
215fe852b8
Getters for TextEdit scrollbars
2022-10-07 23:16:04 -07:00
bruvzg
0103af1ddd
Fix MSVC warnings, rename shadowed variables, fix uninitialized values, change warnings=all to use /W4.
2022-10-07 11:32:33 +03:00
Rémi Verschelde
5b7f62af55
Merge pull request #62910 from Vitika9/gsoc-colorpicker-ux
...
ColorPicker UX
2022-10-07 09:49:29 +02:00
bruvzg
a750ca7ec1
Add split caret direction markers. Fix block/overtype caret size.
2022-10-07 08:45:52 +03:00
Rémi Verschelde
d414872bfe
Merge pull request #66961 from Rindbee/fix-set_custom_color
...
Fix wrong condition used in `set_custom_color`
2022-10-06 08:56:52 +02:00
Rémi Verschelde
f5903215d0
Merge pull request #61902 from Paulb23/multi-caret
...
Add Multi-caret support to TextEdit
2022-10-06 08:56:34 +02:00
Rindbee
f359abbe01
Fix wrong condition used in `set_custom_color`
2022-10-06 12:09:02 +08:00
Markus Sauermann
c0f0f26615
Fix Control not disconnecting signal
...
If a Control has not parent CanvasItem and is set as top_level, then it does not disconnect from the "size_changed" signal when it leaves the Canvas.
This patch corrects this.
2022-10-05 23:35:44 +02:00
Paulb23
e9180241e8
Add multi caret support to CodeEdit
2022-10-05 17:19:26 +01:00
Paulb23
4a9d4e3dad
Add mutliple Caret support to TextEdit
2022-10-05 17:19:26 +01:00
Rémi Verschelde
132a0e3242
Merge pull request #66770 from EricEzaM/search-by-event
...
Add searching by event in Editor Settings shortcuts and Project Settings input map.
2022-10-05 08:34:45 +02:00
Rémi Verschelde
02e9e2d3c0
Merge pull request #66559 from zaevi/fix_ScrollContainer_touch_scroll
...
Fix ScrollContainer touch-scrolling not working.
2022-10-04 10:30:31 +02:00
Paulb23
7dd3857f7e
Move selecion into caret
2022-10-03 14:09:27 +01:00
EricEzaM
272c297931
Improve MenuButton and OptionButton
...
* MenuButton + OptionButton: Add method `show_popup()` which performs required popup setup before showing (prefer use of this over `get_popup()->popup()`, otherwise GH #66308 occurs)
* MenuButton: Ensure that the menu can be opened with a shortcut, if one is set for the button. (GH #66403 ). Ensure that popupmenu item shortcuts are checked first before the MenuButton shortcut.
2022-10-03 20:07:39 +10:00
EricEzaM
cb6d7fd059
Add searching by event for Editor Settings shortcuts and Project Settings input map.
...
* Focus into the LineEdit, then perform input to search the list of events by the events assigned.
* New specialised editor-only control for this: EventListenerLineEdit. Line edit is a good candidate for such a control because you can focus it, override it's input handling, and show the event all in one control.
Update InputEventConfigurationDialog to use event listener line edit rather than the separate tabs.
* Cleaner look - no need for tabs.
* Simpler code.
2022-10-03 19:56:34 +10:00
Rémi Verschelde
e3464c8fc8
Merge pull request #58995 from Sauermann/fix-mouse-cursor-change-2
...
Update mouse cursor shape after changes
2022-09-28 20:50:05 +02:00
Rémi Verschelde
a9591f3039
Merge pull request #66543 from akien-mga/msvc-warning-c4702
...
Fix MSVC warning C4702: unreachable code
2022-09-28 20:47:30 +02:00
Zae
186ca020b3
Fix ScrollContainer touch-scrolling not working.
2022-09-29 01:47:03 +08:00
Rémi Verschelde
7ab01450cf
Fix MSVC warning C4702: unreachable code
...
Part of #66537 .
2022-09-28 16:46:48 +02:00
Rémi Verschelde
0e53dd642c
Fix MSVC warning C4706: assignment within conditional expression
...
Part of #66537 .
2022-09-28 16:05:07 +02:00
Rémi Verschelde
7562932eb2
Merge pull request #66160 from dpalais/double_time
...
Use double instead of real_t type for time-related parameters and variables
2022-09-27 10:04:10 +02:00
Rémi Verschelde
92371880bd
Merge pull request #66445 from EricEzaM/GH-66442-shortcut-change-popupmenu-update
...
Ensure popup menu redraws items when shortcuts update.
2022-09-27 09:53:52 +02:00
Dave Palais
0c46068af0
Change time parameters and variables to double type
...
Addresses #65313
2022-09-26 13:52:54 -05:00
Eric M
af438ae742
Ensure popup menu redraws items when shortcuts update.
2022-09-26 23:21:32 +10:00
bruvzg
970592274d
[RTL] Fix font variations / OpenType features of theme default font not updated when default font is changed.
2022-09-26 13:04:40 +03:00
Rémi Verschelde
1b31241445
Merge pull request #65540 from MewPurPur/easier-bookmarks
...
Implement Shift+LMB as a Way to Toggle Bookmarks
2022-09-26 08:20:40 +02:00
Rémi Verschelde
56c7305f70
Merge pull request #66288 from bruvzg/te_fix_color
...
[TextEdit] Use error/selection font color for the current glyph only, instead of updating cached font color.
2022-09-25 11:04:14 +02:00
Micky
544727ac1e
Fix ColorPicker always emitting color_changed on html submit
...
The color change was always emitted when the the modal was closed, even if it was exactly the same as before.
2022-09-24 18:15:06 +02:00
Eric M
2eda77c682
Ensure all checks of `is_action` in the editor which are for 'shortcut' use, check the action exactly.
2022-09-24 18:01:02 +10:00
bruvzg
3278917c7a
[TextEdit] Use error/selection font color for the current glyph only, instead of updating cached font color.
2022-09-23 11:25:39 +03:00
Rémi Verschelde
1928492b41
Merge pull request #65158 from nongvantinh/fixed-infinite-loop
...
Fixes engine runs into an infinite loop when searching using FindBar
2022-09-23 09:45:34 +02:00
Aaron Franke
c3970f8fe5
Revert custom_minimum_size type back to Vector2 instead of Vector2i
2022-09-22 19:09:12 -05:00
Rémi Verschelde
9f2748f63c
Merge pull request #66213 from KoBeWi/not_right_but_works™
...
Remove duplicate code in ItemList
2022-09-21 18:55:12 +02:00
kobewi
4a0e03cea5
Remove duplicate code in ItemList
2022-09-21 15:37:01 +02:00
Ninni Pipping
df9eaf5f47
Tree recursive folding
2022-09-21 13:28:29 +02:00
Rémi Verschelde
11602cbcfd
Merge pull request #66126 from RedMser/shortcut-context-inspector
...
Fix editing `shortcut_context` in inspector
2022-09-21 11:04:44 +02:00
Rémi Verschelde
bcf754d735
Merge pull request #66068 from bruvzg/rtl_fx_connected
...
[RTL] Add option to apply built-in effects to the individual connected glyphs.
2022-09-19 22:05:47 +02:00
Rémi Verschelde
209a837f79
Merge pull request #66112 from Zylann/get_configuration_warnings_psa
...
Change return type of `get_configuration_warnings` to `PackedStringArray`
2022-09-19 22:03:44 +02:00
RedMser
a12c71fff1
Fix #66062 : editing shortcut_context in inspector
2022-09-19 19:13:52 +02:00
Marc Gilleron
aed3822a93
Change return type of `get_configuration_warnings` to `PackedStringArray`
2022-09-19 16:43:15 +01:00
bruvzg
46af7cbfdd
[RTL] Add option to apply built-in effects to the individual connected glyphs.
2022-09-19 18:10:32 +03:00
Markus Sauermann
52da6f1a44
Update mouse cursor shape after changes
...
This fixes some cases where the mouse cursor shape did not change automatically, but instead required a MouseMove to update.
2022-09-18 17:15:38 +02:00
Rindbee
65f97c671c
Make the inner TabBar in a TabContainer behave as if it were in a Container
2022-09-18 20:55:13 +08:00
Rémi Verschelde
6e8638683e
Merge pull request #66012 from Rindbee/fix-TabContainer-minimum_size
...
Fix minimum size calculation for `TabContainer`
2022-09-18 10:48:08 +02:00
Rindbee
464c374372
Fix minimum size calculation for TabContainer
2022-09-18 06:59:48 +08:00
bruvzg
2a0b4244b7
Fix RichTextLabel not updating on theme/theme override change until text is updated.
2022-09-16 22:24:11 +03:00
Hendrik Brucker
299585fcde
Add configuration warning to GraphEdit regarding future refactoring
2022-09-14 18:09:21 +02:00
bruvzg
2aa226f5e1
RTL Improvements
...
Do not apply negative line separation to the last line.
Ensure all methods immediately update cache in a single thread mode.
Fix bbcode_enabled change not being applied until text is changed.
Fix crash if line height is zero or less.
2022-09-13 11:40:20 +03:00
Yuri Sizov
29c8504dd9
Improve parameter naming and documentation in GraphEdit and GraphNode
...
Co-authored-by: Maganty Rushyendra <mrushyendra@yahoo.com.sg>
2022-09-09 17:50:44 +03:00
VolTer
c8cb93d022
Shift+LMB to Toggle Bookmarks
2022-09-08 22:23:14 +02:00
Michael Alexsander
c4c9e41073
Make `Vector2i` values paired with `EDSCALE` be just `Vector2`
2022-09-08 14:46:32 -03:00
Rémi Verschelde
69233093d7
Merge pull request #65241 from bruvzg/no_keymap_ambiguity
...
Fix key mapping changes when moving from macOS to other platform.
2022-09-08 09:24:24 +02:00
Rémi Verschelde
7936b3cc4c
Merge pull request #60108 from KoBeWi/arise_to_top
...
Rename raise() to move_to_front()
2022-09-08 09:23:31 +02:00
bruvzg
ac1f2b378f
[RTL] Stop threaded RTL auto-redrawing as soon as text processing is finished, instead of waiting for first redraw.
2022-09-07 22:24:30 +02:00
bruvzg
6f4d233062
Fix key mapping changes when moving from macOS to other platform
...
Removes separate `Command` key (use `Meta` instead).
Adds an event flag to automatically remap `Command` <-> `Control` (cannot be set alongside `Control` or `Meta`).
2022-09-07 18:45:35 +02:00
Rémi Verschelde
81de16890e
Merge pull request #65375 from ItsNL/fix-accep-dialog-its_inside_tree-false
...
Condition "!is_inside_tree()" is true" when AcceptDialog was visible from the editor.
2022-09-07 17:53:46 +02:00
Rémi Verschelde
54942038ac
Merge pull request #65389 from Rindbee/fix-file-list-in-FileDialog-not-updating
...
Fix file list in FileDialog not updating on first run
2022-09-07 17:53:09 +02:00
Rémi Verschelde
48705b1f03
Merge pull request #65355 from groud/split_container_min_grab_thickness
...
Allow SplitContainer to have a grab area larger than its visual grabber
2022-09-07 17:51:52 +02:00
=
2de52c74ae
Fix "grab_focus: Condition "!is_inside_tree()" is true" when AcceptDialog was visible from the editor.
2022-09-07 17:04:26 +02:00
Rindbee
88b72c3de4
Fix file list in FileDialog not updating on first run
2022-09-07 21:36:21 +08:00
Gilles Roudière
4cbcb5acda
Allow SplitContainer to have a grab area larger than its visual grabber
2022-09-07 12:33:02 +02:00
Micky
08c2aab169
Rename ProgressBar.`percent_visible` to `show_percentage`
...
`percent_visible` -> `show_percentage`
`set_percent_visible` -> `set_show_percentage`
`is_percent_visible` -> `is_percentage_shown`
2022-09-07 11:58:30 +02:00
Rémi Verschelde
2841bc358c
Merge pull request #65446 from YuriSizov/dialogs-make-styleboxes-matter
...
Make `AcceptDialog` and derivatives utilize `StyleBox` fully
2022-09-07 09:09:15 +02:00
Rémi Verschelde
80dacac90c
Merge pull request #65437 from YuriSizov/theme-gui-renames
...
Improve naming of theme properties throughout GUI code
2022-09-07 08:58:00 +02:00
Rémi Verschelde
5c5079b398
Merge pull request #65197 from Mickeon/rename-connect-one-shot
...
Rename CONNECT_ONESHOT to CONNECT_ONE_SHOT
2022-09-07 08:51:10 +02:00
Rémi Verschelde
3515382390
Merge pull request #64361 from Mickeon/rename-caret-blink
...
Rename every instance of `caret_blink_speed` to `caret_blink_interval`
2022-09-07 08:51:02 +02:00
Yuri Sizov
5eaf82b4f0
Make AcceptDialog and derivatives utilize StyleBox fully
2022-09-07 01:42:11 +03:00
kobewi
b218727599
Rename raise() to move_to_front()
2022-09-06 22:13:06 +02:00
Yuri Sizov
39ef611a7d
Fix theming code in Panel, SplitContainer, RichTextLabel
2022-09-06 22:53:19 +03:00
Yuri Sizov
43f03e2ce6
Improve naming of theme properties throughout GUI code
...
Rename ItemList's bg -> panel
Rename ItemList's bg_focus -> focus
Rename ProgressBar's bg -> background
Rename ProgressBar's fg -> fill
Rename Tree's bg -> panel
Rename Tree's bg_focus -> focus
Rename ScrollContainer's bg -> panel
Rename FileDialog's *_icon_modulate -> *_icon_color
Rename FileDialog's files_disabled -> file_disabled_color
Rename CheckButton's on/off -> checked/unchecked
Rename check_v_adjust -> check_v_offset
2022-09-06 22:53:17 +03:00
Micky
dd26ecdd31
Rename CONNECT_ONESHOT TO CONNECT_ONE_SHOT
...
For consistency. Every other exposed `one_shot` is spaced out like this.
2022-09-06 19:00:33 +02:00
Micky
6dbd283ae5
Rename every instance of `caret_blink_speed` to `caret_blink_interval`
...
It's been changed in EditorSettings, LineEdit, TextEdit.
Affects setters and getters, and passed parameters, too.
2022-09-06 18:37:17 +02:00
Vitika9
1dce43d417
ColorPicker UX improvements
...
- Tabs and MenuButton for mode selection and enabling/disabling colorized sliders
- MenuButton for shape selection with new icon for each shape
- Drag and drop functionality for presets to arrange order
- A chronological list of recently selected presets which are global for the editor
- Presets are now highlighted as being active or inactive
- Thicker sliders for easy targeting
- `grabber_offset` theme constant for Slider
- Uncolorized sliders
2022-09-06 21:42:20 +05:30
Rémi Verschelde
49d18f0725
Merge pull request #65423 from YeldhamDev/i_want_to_ride_my_bycicle
...
Rename `PopupMenu`'s `set/get_current_index()` to `set/get_focused_item()`
2022-09-06 17:00:58 +02:00
Rémi Verschelde
5062aafc2d
Merge pull request #64417 from aaronfranke/has-space
...
Replace AABB/Rect2/Rect2i has_no_* methods with has_* methods
2022-09-06 17:00:44 +02:00
Michael Alexsander
9507e91c07
Rename `PopupMenu`'s `set/get_current_index()` to `set/get_focused_item()`
2022-09-06 10:51:14 -03:00
Micky
b6daad8d4b
Rename `range_lerp` to `remap`
2022-09-06 07:19:20 +02:00
Rémi Verschelde
b5c053321c
Merge pull request #64840 from maximkulkin/graph-edit-node-selection
...
Add GraphNode 'selected' and 'deselected' signals, simplify GraphEdit
2022-09-05 08:36:10 +02:00
Maxim Kulkin
9a35ede23f
Add GraphNode 'selected' and 'deselected' signals, simplify GraphEdit
2022-09-05 02:32:06 -04:00
Rémi Verschelde
1499840f75
Merge pull request #65028 from groud/fix_split_container
...
Improve SplitContainer behavior, keeping asked split position whenever possible
2022-09-05 08:30:11 +02:00
Aaron Franke
995b9f94e8
Replace Rect2(i) has_no_area with has_area
2022-09-04 23:03:36 -05:00
Rémi Verschelde
597bc949a4
Merge pull request #65250 from YuriSizov/theme-owner-rises
2022-09-02 23:20:49 +02:00
Rémi Verschelde
77ca96fd73
Merge pull request #59589 from Calinou/rename-or-lesser-range-property-hint
2022-09-02 23:13:20 +02:00
Yuri Sizov
8b128081e8
Un-defer the initial theme changed notification
...
Co-authored-by: Rindbee <idleman@yeah.net>
2022-09-02 23:44:23 +03:00
Yuri Sizov
ddc55ef746
Add ThemeOwner type for managing theme propagation and lookup
2022-09-02 23:44:23 +03:00
Rémi Verschelde
33b4153764
Merge pull request #64917 from Tim-Fronsee/fix/add-gutter-total-width
2022-09-02 20:52:11 +02:00
Gilles Roudière
2ddda13339
Improve SplitContainer behavior, keeping asked split whenever possible
2022-09-02 20:48:50 +02:00
Hugo Locurcio
f7292dbeb3
Rename `or_lesser` range property hint to `or_less`
...
"less" should be used for quantity, rather than "lesser".
Existing scripts that use `or_lesser` in `_get_property_list()`
will need to be updated to account for this change.
2022-09-02 19:08:20 +02:00
Rémi Verschelde
fe2cf6e406
Merge pull request #65210 from YuriSizov/control-customizable-cache-p3
2022-09-02 13:51:52 +02:00
Rémi Verschelde
c82bbc38a5
Merge pull request #64952 from Chaosus/vs_rename_uniform_to_param
2022-09-02 13:49:53 +02:00
Yuri Sizov
fc7cef8dec
Fix theme propagation in various parts of the editor
2022-09-02 13:18:31 +03:00
Rémi Verschelde
5a136ee490
Merge pull request #64724 from KoBeWi/HVBoxContainer
2022-09-02 08:44:42 +02:00
Jonathan Nicholl
15d057c521
Add `is_zero_approx` methods to `Vector2`, `3`, and `4`
2022-09-02 00:29:50 -04:00
Rémi Verschelde
7e3afc3d09
Merge pull request #65213 from Mickeon/fix-label-visible-ratio
2022-09-01 23:49:28 +02:00
Rémi Verschelde
5263fd5343
Merge pull request #64198 from Geometror/add-bitmap-tests
2022-09-01 23:46:38 +02:00
kobewi
73929bef73
Rework oriented containers
2022-09-01 22:13:46 +02:00
Micky
511134f55f
Fix Label & RichTextLabel's visible_ratio not working
2022-09-01 19:22:12 +02:00
Rémi Verschelde
8c7be63588
Merge pull request #65192 from YuriSizov/control-customizable-cache-p2
2022-09-01 19:09:33 +02:00
Rémi Verschelde
dcd74563b6
Merge pull request #65156 from YuriSizov/control-customizable-cache-p1
2022-09-01 19:08:02 +02:00
Hendrik Brucker
ea0472fecf
Refactor BitMap and add tests
...
Co-authored-by: Resul Çelik <resul_celik@hotmail.com>
2022-09-01 18:39:17 +02:00
Rémi Verschelde
027415312e
Merge pull request #65132 from bruvzg/global_menu_shortcuts_context
2022-09-01 17:02:04 +02:00
Yuri Sizov
3b1aa240dc
Add a lifecycle method for manual theme item caching to Control
2022-09-01 16:35:36 +03:00
Yuri Sizov
15fd025f90
Add dumb and manual theme caching systems to Window
2022-09-01 16:05:02 +03:00
Yuri Rubinsky
8191b3c110
Rename `uniform` to `parameter` across the engine
2022-09-01 11:42:57 +03:00
Rémi Verschelde
0a34994720
Merge pull request #65117 from YeldhamDev/menubar_key_fix
...
Fix switching `MenuBar`'s menus with the keys while mouse hovering
2022-09-01 08:46:01 +02:00
Rémi Verschelde
d22f2612f9
Merge pull request #65162 from YuriSizov/editor-gradients-united
...
Unite `GradientEdit` and `GradientEditor` as editor-only widget
2022-09-01 08:30:16 +02:00
bruvzg
b85a4c5d79
[macOS] Handle accelerator and click events of the global menu items separately.
2022-09-01 08:13:56 +03:00
bruvzg
7aad14a4b6
[TextServer] Add support for trimming edge spaces on line break.
2022-09-01 08:11:55 +03:00
Yuri Sizov
93078ea551
Unite GradientEdit and GradientEditor as editor-only widget
2022-08-31 23:45:04 +03:00
Nong Van Tinh
97c0b0c74a
Fixes #64962 that cause program run into infinite loop
2022-09-01 01:26:08 +07:00
Tim Fronsee
e5c183b01e
Fix TextEdit::gutters_width (total gutter width) when adding & removing a gutter by calling TextEdit::_update_gutter_width in TextEdit::add_gutter & TextEdit::remove_gutter
...
Update TextEdit gutters subcase, gutter add and remove to ensure gutter total width is correct
Fix test_code_edit symbol lookup test case to include padding (+2)
2022-08-31 10:01:40 +09:00
Michael Alexsander
9e0de4e2cb
Fix switching `MenuBar`'s menus with the keys while mouse hovering
2022-08-30 20:18:35 -03:00
Rémi Verschelde
e27b61d291
Merge pull request #65042 from YuriSizov/editor-docks-tabbar-bg
2022-08-30 18:53:54 +02:00
Rémi Verschelde
ae349d8227
Merge pull request #64377 from Mickeon/rename-canvas-redraw
...
Rename `CanvasItem.update()` to `queue_redraw()`
2022-08-30 14:47:41 +02:00
Rémi Verschelde
ebe4f8d3a4
Merge pull request #65039 from Mickeon/rename-treeitem-tooltip
2022-08-30 14:05:08 +02:00
Micky
97f8c9b97c
Rename TreeItem's `set_tooltip` to `set_tooltip_text`
...
`set_tooltip` -> `set_tooltip_text`
`get_tooltip` -> `get_tooltip_text`
For consistency:
`get_button_tooltip` -> `get_button_tooltip_text`
And the `tooltip` parameter in `add_button` was renamed to `tooltip_text`
2022-08-30 11:16:23 +02:00
Aaron Franke
10a56981dc
Rename String `plus_file` to `path_join`
2022-08-29 19:38:13 -05:00
Yuri Sizov
8b196be855
Add background to TabContainer's tabbar and editor docks
2022-08-29 23:43:32 +03:00
Micky
e31bb5ffeb
Rename `CanvasItem.update()` to `queue_redraw()`
...
Affects a lot of classes. Very thoroughly checked signal connections and deferred calls to this method, add_do_method/add_undo_method calls, and so on.
Also renames the internal `_update_callback()` to `_redraw_callback()` for consistency.
Just a few comments have also been changed to say "redraw".
In CPUParticles2D, there was a private variable with the same name. It has been renamed to `do_redraw`.
2022-08-29 14:59:47 +02:00
Rémi Verschelde
e60086f98b
Merge pull request #64119 from YuriSizov/theme-init-database
2022-08-29 14:02:21 +02:00
Rémi Verschelde
fd6453c45e
Revert "Remove NOTIFICATION_ENTER_TREE when paired with NOTIFICATION_THEME_CHANGED"
...
This reverts commit 4b817a565c
.
Fixes #64988 .
Fixes #64997 .
This caused several regressions (#64988 , #64997 ,
https://github.com/godotengine/godot/issues/64997#issuecomment-1229970605 )
which point at a flaw in the current logic:
- `Control::NOTIFICATION_ENTER_TREE` triggers a *deferred* notification with
`NOTIFCATION_THEME_CHANGED` as introduced in #62845 .
- Some classes use their `THEME_CHANGED` to cache theme items in
member variables (e.g. `style_normal`, etc.), and use those member
variables in `ENTER_TREE`, `READY`, `DRAW`, etc. Since the `THEME_CHANGE`
notification is now deferred, they end up accessing invalid state and this
can lead to not applying theme properly (e.g. for EditorHelp) or crashing
(e.g. for EditorLog or CodeEdit).
So we need to go back to the drawing board and see if `THEME_CHANGED` can be
called earlier so that the previous logic still works?
Or can we refactor all engine code to make sure that:
- `ENTER_TREE` and similar do not depend on theme properties cached in member
variables.
- Or `THEME_CHANGE` does trigger a general UI update to make sure that any
bad theme handling in `ENTER_TREE` and co. gets fixed when `THEME_CHANGE`
does arrive for the first time. But that means having a temporary invalid
(and possibly still crashing) state, and doing some computations twice
which might be heavy (e.g. `EditorHelp::_update_doc()`).
2022-08-29 11:11:29 +02:00
Rémi Verschelde
223e083d36
Merge pull request #64964 from MewPurPur/reorganize-label-properties
...
Reorganize Label and RichTextLabel properties
2022-08-29 09:52:04 +02:00
Rémi Verschelde
f647292df5
Merge pull request #64960 from YeldhamDev/more_hl_stuff
2022-08-29 08:05:33 +02:00
Rémi Verschelde
34f45d7b28
Merge pull request #64967 from YeldhamDev/pm_up_fix
2022-08-29 07:56:03 +02:00
Rémi Verschelde
93cf259834
Merge pull request #64972 from YeldhamDev/you_too_menubar
2022-08-29 07:55:46 +02:00
Rémi Verschelde
f7f8af232c
Merge pull request #64885 from Mickeon/rename-tooltip-hint
...
Rename `hint_tooltip` to `tooltip_text` & setter getter
2022-08-28 17:43:01 +02:00
VolTer
832950d1f2
Reorganized Label and RichTextLabel properties
2022-08-28 10:26:04 +02:00
Michael Alexsander
44c64b912f
Add item auto-highlighting to `MenuBar`
2022-08-28 01:49:22 -03:00
Michael Alexsander
221344b9e2
Fix some corner cases in the `Menu/OptionButton` item auto-highlight
2022-08-28 01:15:03 -03:00
Michael Alexsander
06df59887b
Fix crash when pressing up on an empty `PopupMenu`
2022-08-27 18:13:27 -03:00