Commit Graph

1506 Commits

Author SHA1 Message Date
Gary Oberbrunner 561e57df13 Fix infinite loop in GridContainer layout
I had a grid container and tried to set rect.min_height larger in the
editor; that caused an infinite loop in GridContainer::_notification
at line 118. The reason is max_index was being set to the *height* of
the row, not the *index* of the row. So later when it tried to erase
that row and try again, there was nothing to erase.
I applied the same fix to the width code.
2018-03-10 14:38:35 -05:00
Gilles Roudiere 44cb8eb3a2 Fixes infinite loop in GridContainer 2018-03-10 14:01:20 +01:00
Alexander Holland e36dd4282b auto-completion edge jump
arrow up/down jumps to end/start on edges
2018-03-09 17:31:07 +01:00
Leon Krause 38623e07ac Prevent division by zero in GridContainer 2018-03-07 17:36:28 +01:00
robfram 95f186b621 Fix bad autocomplete of partially written node paths when using syntactic sugar notation ($)
If you had a tree like Node2D->Sprite->Camera2D and you write a
code like $Node2D/Spr and chose the autocompletion sugested
Node2D/Sprite, the resulting string was $Node2D/Node2D/Sprite
instead $Node2D/Sprite. If you chose Node2D/Sprite/Camera2D, then
you ended with $Node2D/Node2D/Sprite/Camera2D.

Fix #15813.
2018-03-06 19:25:14 +01:00
bncastle ceb079fa35 Fix BaseButton not always calling _pressed()
Fix "ui_accept" action in BaseButton.cpp not calling _pressed() func in
GDScript
2018-03-05 20:37:10 -05:00
Bernhard Liebl 0e1e95c41f Fix more regressions in RichTextLabel from PR 15711 2018-03-02 19:19:46 +01:00
poke1024 89f607604e Fix regression through fa98637aca 2018-03-01 18:03:53 +01:00
Hein-Pieter van Braam d702d7b335 Fix various valgrind reported uninitialized variable uses 2018-02-28 21:55:13 +01:00
Rémi Verschelde 6093660bfb
Merge pull request #16656 from JFonS/fix_gradient_crash
Fix weird editor crash when switching from editing one gradient to another keeps 'grabbing' variable to true
2018-02-27 11:38:19 +01:00
Fabio Alessandrelli 920d2bfdfa Add two new default actions ui_end, ui_home
Used by Slider and Scrollbar
2018-02-23 13:01:28 +01:00
Fabio Alessandrelli ff122a7e1f Add item_focused signal to OptionButton
And id_focused to Popupmenu.
2018-02-23 13:01:28 +01:00
Fabio Alessandrelli 59c23c1369 Scrollbar now uses UI actions instead of keys 2018-02-23 13:01:28 +01:00
Fabio Alessandrelli e15fe296bd Line edit up/down focus pass through
When line edit receive a up/down and the cursor is at beginning/end it
will not set the input as handled
2018-02-23 13:01:28 +01:00
Fabio Alessandrelli e3eb686906 Tree now uses UI actions instead of keys 2018-02-23 12:58:35 +01:00
Fabio Alessandrelli 4a71483a65 Popupmenu now uses UI actions instead of keys 2018-02-23 12:58:16 +01:00
luz.paz 612ab4bbc6 Fix typos with codespell
Found via `codespell -q 3 --skip="./thirdparty,./editor/translations" -I ../godot-word-whitelist.txt`
Whitelist consists of:
```
ang
doubleclick
lod
nd
que
te
unselect
```
2018-02-21 19:46:06 +01:00
Max 6a48f952ca Fixed disappearing text on filedialog buttons 2018-02-21 16:04:51 +02:00
Michael Alexsander Silva Dias db80d56388 Fixed "Open" button being enabled when nothing is selected in a FileDialog while in "Open folder" mode. 2018-02-20 12:19:06 -03:00
Rémi Verschelde 55f00d9655
Merge pull request #16455 from volzhs/close-docs
Keep to show current script when closing all docs
2018-02-20 09:40:29 +01:00
volzhs df84290a7e Keep to show current script when closing all docs
also fix error when removing multiple tabs from TabContainer at same frame.
like closing multiple docs at once.

Fix #16403
2018-02-20 14:39:52 +09:00
Rémi Verschelde 6ee4298ee3
Merge pull request #16652 from aragar/FixQuotationInString
Fix quotation in string
2018-02-19 22:12:53 +01:00
Rémi Verschelde d5daaa72fa
Merge pull request #15306 from poke1024/item-list-draw-speed
Boost drawing speed of ItemLists with many items
2018-02-19 21:53:59 +01:00
Alexander Alekseev 66c39b1426 Fixes OptionButton selection index being reset to zero at instanciation
Bug: engine tries to set selected item before items were added during save scene/run project, because of wrong properties order.
Fixes #10213.
2018-02-19 20:25:34 +01:00
Rémi Verschelde b93d6a001b
Merge pull request #16566 from groud/gui_input_rework
2D Editor GUI input rework
2018-02-19 20:05:35 +01:00
isaacremnant cc902cf9ab Force controls to save rect_clip_content since they do not all default to false. 2018-02-18 22:24:05 -05:00
Artem Varaksa d35e486228 Clean up some bad words from code comments 2018-02-17 16:00:39 +03:00
Gilles Roudiere 8dad41e395 2D editor GUI input rework. Changes are:
- The input handling is done into several distinct functions, and the
  code is more consistent.
- The actions' history is more precise ("Edited CanvasItem"
  is now "Rotated CanvasItem","Moved CanvasItem",etc...)
- Fixed a little bug about input key events not forwarded correctly to plugins
- IK is followed by default when you move a bone node, the alt-key allow
  you to move it normally
2018-02-16 10:14:52 +01:00
JFonS f68594a525 Fix weird editor crash when switching from editing one gradient to another keeps 'grabbing' variable to true 2018-02-14 16:48:13 +01:00
Rémi Verschelde 2551db44e1
Merge pull request #15618 from ianb96/fold_comment
TextEdit folding over unindented comments
2018-02-14 16:36:42 +01:00
Rémi Verschelde f1ee573ebe
Merge pull request #15711 from poke1024/fix-rtl-descent
Fixes wrong vertical font layout in RichTextLabel
2018-02-14 16:28:16 +01:00
Rémi Verschelde e777751958
Merge pull request #15855 from mrcdk/texture_button_mask_fixes
The TextureButton's bitmask takes into account the stretch mode selected
2018-02-14 16:16:10 +01:00
Rémi Verschelde 1f17881d5d
Merge pull request #15903 from groud/fix_minsize
Fixes GridContainer and SplitContainer wrong layouting
2018-02-14 16:04:06 +01:00
Michael Alexsander Silva Dias 4dbf6ac1b8 Added "allow_reselect" property to ItemList and enabled it for the method/help lists. 2018-02-14 03:38:07 -02:00
Rémi Verschelde 8944773934
Merge pull request #16422 from synasius/fixed-line-edit-text-changed-signal
Fixed #15082: line edit emits two "text_changed" signals when pasting while text is selected
2018-02-13 22:14:25 +01:00
Rado'sPC\aRaGaR f38e819fc1 Fix quotation in string
fix for #16404
2018-02-12 23:01:36 +02:00
isaacremnant 4ef11eb3ed Implements #16546 by adding GROW_DIRECTION_BOTH which allows a control to grow from its center. 2018-02-12 01:39:18 -05:00
Ovnuniarchos fe1ca3c6e6 SpinBoxes calculate correctly their width before first redraw. 2018-02-05 22:42:30 +01:00
Federico Frenguelli 9cd3ed4ace Fixed #15082: line edit emits two "text_changed" signals when pasting while text is selected 2018-02-05 16:22:34 +01:00
binbitten 331cfc1d18 Fix wrong property type for fixed icon size in ItemList 2018-02-03 10:02:27 +01:00
Rémi Verschelde 9247f2de37
Merge pull request #16249 from binbitten/fix-highlight-ofs
Fix TextEdit current line highlight horizontal offset
2018-02-01 15:25:02 +01:00
binbitten ba8c5bff69 Fix TextEdit current line highlight horizontal offset 2018-01-31 19:04:50 +01:00
George Marques b80bc73a17
Expose a few GraphEdit methods to script languages 2018-01-30 22:09:41 -02:00
Hein-Pieter van Braam 713f190a30 Allow focus on disabled buttons
This behavior better matches other gui toolkits. A selected disabled
button still can't be interacted with but it can now be selected. This
seems to be what QT and GTK do also.

This fixes #16131
2018-01-28 18:49:22 +01:00
Gilles Roudiere 30e1e42175 Fixes a bas resizing with SplitContainer 2018-01-20 21:03:20 +01:00
Gilles Roudiere d1f32708b7 Fixes a Gridcontainer wrong children fitting with expanded+non-zero minisize 2018-01-19 00:56:30 +01:00
MrCdK 9927b70efb The TextureButton's bitmask takes into account the stretch mode selected
When the stretch is tile the mask gets applied to each tile.
2018-01-19 00:01:23 +01:00
Rémi Verschelde 9f479f096c Fix typos in code and docs with codespell
Using v1.11.0 from https://github.com/lucasdemarchi/codespell
2018-01-18 22:01:42 +01:00
Ian 1b837125ce TextEdit fix get_mouse after many folds 2018-01-18 12:18:06 -05:00
Rémi Verschelde 6c46787749 doc: Replace some more "val" with "value" + sync 2018-01-17 10:43:23 +01:00
Gilles Roudiere b06c6602c8 Changes the keep_margin parameter to true by default, so that people are not suprised that set_anchor changes the margins values 2018-01-15 10:37:13 +01:00
Fabio Alessandrelli 765051e104 ViewportContainer passes input down to children viewports 2018-01-15 00:36:57 +01:00
Bernhard Liebl 77b1320fb4 Fixes wrong vertical font layout in RichTextLabel 2018-01-14 19:29:04 +01:00
Rémi Verschelde a1a67e6e84
Merge pull request #15708 from Paulb23/current_line_clipping_issue_15427
Fixed current line highlighting with horizontal clipping, issue 15427
2018-01-14 17:22:09 +01:00
Paulb23 386c57cfad Fixed current line highligting with horizontal clipping, issue 15427 2018-01-14 16:06:27 +00:00
Rémi Verschelde 892568abee
Merge pull request #15670 from poke1024/fix15588
Fixes hangs with Tree in multi selection mode (issue 15588)
2018-01-13 17:45:03 +01:00
Bernhard Liebl 363980519c Fixes hangs with Tree in multi selection mode (issue 15588) 2018-01-13 17:34:12 +01:00
Rémi Verschelde 69452fbc37
Merge pull request #15657 from paulloz/fix-textedit-undo-redo-selection
TextEdit: Fix selection issue with undo/redo
2018-01-13 17:05:46 +01:00
Paul Joannon 8ae0624c80 Deselect on undo/redo in TextEdit 2018-01-13 11:46:53 +01:00
Ruslan Mustakov 0b632be4a9 Fix get_parent_range to return 0 when there is no parent
Fixes #15635
2018-01-13 16:48:07 +07:00
letheed 524ee14054 Small fix for Control bindings 2018-01-13 09:40:42 +01:00
Juan Linietsky 419705db6e Add special coloring to members, to make shadowing more obvious. 2018-01-12 11:01:09 -03:00
Juan Linietsky a26e6c8215 Renamed tree_exited to tree_exiting. tree_exited is now used for actual out of tree notification.
Updated doc accordingly.
2018-01-12 08:29:24 -03:00
Ian d327f75392 TextEdit folding over unindented comments 2018-01-12 00:25:04 -05:00
Bojidar Marinov 9b8e8b2220
Bind many more properties to scripts
Notable potentially breaking changes:
- PROPERTY_USAGE_NOEDITOR is now PROPERTY_USAGE_STORAGE | PROPERTY_USAGE_NETWORK, without PROPERTY_USAGE_INTERNAL
- Some properties were renamed, and sometimes even shadowed by new ones
- New getter methods (some virtual) were added
2018-01-12 00:58:14 +02:00
Gilles Roudiere 00473e0897 Fixes nodes being resized or moved when changing an anchor 2018-01-11 23:39:49 +01:00
poke1024 c1db81b9ed Fixes empty line selection when scrolling 2018-01-11 06:51:20 +01:00
Rémi Verschelde 4b6bef6524 Fix signal arguments shadowing member variables
Fixes #10212.
2018-01-09 16:51:19 +01:00
Bernhard Liebl 3af5dfbbf3 Fix whole word search missing occurences 2018-01-08 22:50:33 +01:00
Marcelo Fernandez 6fc1801b6a Fix Video Player issue with audio mix_rate when different than 44100 2018-01-07 12:57:48 -03:00
Bernhard Liebl 249521670d Corrects wrong scrolling for short popups broken in 15405 2018-01-07 02:19:11 +01:00
Ian b3ad2538d0 fix center viewport out of size error, #15411 2018-01-06 18:06:09 -05:00
Rémi Verschelde b6989d0b51
Merge pull request #15412 from poke1024/fix-tree-get-rect-crash
Fix crash when calling tree API before NOTIFICATION_ENTER_TREE
2018-01-06 19:56:29 +01:00
Rémi Verschelde b77c6d43a8
Merge pull request #15405 from poke1024/fix-popup-scroll
Allow popup menu scrolling without mouse wheel
2018-01-06 19:55:36 +01:00
Bernhard Liebl 4cbe726cf5 Fix crash when calling tree API before NOTIFICATION_ENTER_TREE 2018-01-06 19:48:54 +01:00
Bernhard Liebl 3f9a7da857 Allow popup menu scrolling without mouse wheel 2018-01-06 16:21:27 +01:00
volzhs 13af5e8878 Remove button from button_group when free 2018-01-06 06:06:22 +09:00
Fabio Alessandrelli a63a82d5e5 Fix theme inheritance 2018-01-05 18:30:40 +01:00
Bernhard Liebl 85ecd79012 Boost drawing speed of ItemLists with many items 2018-01-05 17:40:53 +01:00
Rémi Verschelde e4213e66b2 Add missing copyright headers and fix formatting
Using `misc/scripts/fix_headers.py` on all Godot files.
Some missing header guards were added, and the header inclusion order
was fixed in the Bullet module.
2018-01-05 01:22:23 +01:00
Rémi Verschelde 92e114edfd
Merge pull request #15335 from volzhs/popup-menu
Fix PopupMenu to show & detect properly hover area
2018-01-04 19:54:19 +01:00
Rémi Verschelde 32bb236f24
Merge pull request #15334 from poke1024/textedit-mousepos
Fix TextEdit::_get_mouse_pos rounding errors
2018-01-04 19:53:43 +01:00
volzhs f2d531bd43 Fix PopupMenu to show & detect properly hover area
Fix #15275
2018-01-05 02:37:46 +09:00
Bernhard Liebl cc64679a20 Fix TextEdit::_get_mouse_pos rounding errors 2018-01-04 18:30:15 +01:00
Rémi Verschelde 94bda27659
Merge pull request #15317 from poke1024/fix-rtl-underline
RichTextLabel: don't draw underline character-wise
2018-01-04 13:30:00 +01:00
Bernhard Liebl e74e2763bd RichTextLabel: don't draw underline on single characters 2018-01-04 12:10:29 +01:00
Rémi Verschelde 465d66be67
Merge pull request #15314 from poke1024/tree-rlines
Tree: only draw visible relationship lines
2018-01-04 10:33:55 +01:00
Bernhard Liebl e9aa6f2943 Tree: only draw visible relationship lines 2018-01-04 10:03:46 +01:00
Rémi Verschelde 59ce175767
Merge pull request #15312 from poke1024/fix-rtl-table-wrap
Fixes word wrapping in tables in RichTextLabel
2018-01-04 09:07:31 +01:00
Bernhard Liebl c6c016e95a Fix word wrapping in tables in RichTextLabel 2018-01-04 08:22:41 +01:00
firefly2442 f066991aa7 found via cppcheck:
remove code that will never run
make definition and declaration names for parameters match
change floats that were being set to bool values
remove pointer that is never used
2018-01-03 21:23:48 -07:00
Rémi Verschelde 023c04689e
Merge pull request #15308 from ianb96/horizontal_scrolling
TextEdit horizontal scrolling with shift
2018-01-04 01:35:38 +01:00
Rémi Verschelde d65ac7378c Fix crash in OS::execute on FreeBSD
As spotted by @robfram, closes #15288.
Also reviewed other uses of `if (String.find(.*))` for potential similar mistakes, found a wrong (and useless) one in ScriptEditorDialog.
2018-01-04 01:20:20 +01:00
Rémi Verschelde f9f6f250e6
Merge pull request #15191 from Jerome67000/z_renaming
renames "z" Node2D property to "z_index"
2018-01-04 00:41:45 +01:00
Ian ae6b7c0b41 TextEdit horizontal scrolling with shift 2018-01-03 17:21:54 -05:00
Jerome67000 42ae3525a3 #15078 renamed "z" -> "z_index" property in Node2D 2018-01-03 13:02:26 +01:00
Rémi Verschelde e3c744f9f1
Merge pull request #15127 from poke1024/smooth-scroll-play
Remove some lagginess from TextEdit's smooth scrolling
2018-01-03 11:34:42 +01:00
Rémi Verschelde fd5f193da5
Merge pull request #15103 from poke1024/lineedit-key-up-down
Support KEY_UP and KEY_DOWN in LineEdit
2018-01-03 11:32:31 +01:00
Rémi Verschelde 592b0fc068
Merge pull request #15063 from poke1024/textedit-select-last-line
Fix key down on last line in TextEdit
2018-01-03 10:30:51 +01:00
Rémi Verschelde 6cd33f17f7
Merge pull request #14792 from Krakean/enh-1
A few small Debugger->Errors tab enhancements:
2018-01-03 10:26:55 +01:00