Commit Graph

5572 Commits

Author SHA1 Message Date
Rémi Verschelde 7d71b4be37
Merge pull request #94422 from m4gr3d/fix_input_locking_issue
Fix input lock issue when drag scrolling on a `Tree` element on touchscreen devices
2024-07-18 15:38:17 +02:00
A Thousand Ships 832695eb2c
[Tests] Fix various unit tests on minimal builds 2024-07-18 15:17:28 +02:00
Fredia Huya-Kouadio 70d450d086 Fix issue causing input lock when drag scrolling a `Tree` element on touchscreen devices
Prior to this fix, scrolling via mouse drag on touchscreen devices, and
drag&drop operation on a `TreeItem` element would conflict with each other
preventing the drag scroll from being released when the mouse button is
released.

The issue is addressed by disabling drag&drop when drag scrolling is ongoing.
2024-07-18 04:09:54 -07:00
Rémi Verschelde fa2266716e
Merge pull request #94363 from bruvzg/fix_code_completion_scroll
[macOS] Fix code completion list scrolling with trackpad.
2024-07-17 15:45:10 +02:00
Rémi Verschelde 5da03541a1
Merge pull request #93749 from alvinhochun/gui-snap-to-pixel-round-halfway-to-positive
Change GUI controls pixel snap to round halfway towards positive infinity (`floor(x + 0.5)`)
2024-07-17 15:44:43 +02:00
A Thousand Ships d4cf294b35
Fix potential null access in `TextEdit` 2024-07-17 13:35:22 +02:00
Rémi Verschelde 78120c66cc
Merge pull request #94085 from anniryynanen/min-size-hidden-parent
Fix container minimum size with hidden parent
2024-07-17 11:43:07 +02:00
kit f8df6b1c70 Fix ScriptEditor scrolling horizontally on reopen 2024-07-16 11:19:58 -04:00
bruvzg dc98e432e5
[macOS] Fix code completion list scrolling with trackpad. 2024-07-15 08:12:19 +03:00
Anni Ryynänen a9c91f4eef
Fix container minimum size with hidden parent 2024-07-12 16:21:05 +03:00
Rémi Verschelde 013ee6a458
Merge pull request #94003 from KernRat/scroll-fix
Fix RichTextLabel + `ui_down` scrolling too far
2024-07-11 00:27:10 +02:00
Yuri Rubinsky af5fc8354b Fix a bunch of orphan StringName errors at ProjectSettings/Editor exit 2024-07-09 19:38:52 +03:00
Rémi Verschelde 17e7253ea8
Merge pull request #93721 from semensanyok/fix-RichTextLabel-fade-start-index
Fix RichTextLabel fade set `start_index` to command offset
2024-07-09 16:47:10 +02:00
bruvzg eddc9cea11
[NativeMenu] Do not auto toggle check/multi-state items. Add `is_native_menu` method. 2024-07-08 11:20:28 +03:00
KernRat 3f4222bad4
Fixed RichTextLabel + ui_down scrolling too far 2024-07-06 16:58:33 +02:00
Hendrik Brucker 104c77cd86 Fix connections not updated after GraphNode slot update 2024-07-06 14:33:34 +02:00
Rémi Verschelde b97110cd30
Merge pull request #93908 from Geometror/ge-resized-fix
Fix `Control` nodes emitting unnecessary `resized` signals
2024-07-05 16:38:10 +02:00
Rémi Verschelde 1704af01b1
Merge pull request #93959 from kitbdev/fix-drop-on-selection
Fix dropping on selection in script editor
2024-07-05 15:07:44 +02:00
kit fc16465d17 Fix dropping on selection in script editor 2024-07-04 19:42:38 -04:00
Hendrik Brucker 1c47fd7089 Fix Control nodes emitting unnecessary resized signals 2024-07-05 01:41:21 +02:00
Rémi Verschelde 5c84398c15
Merge pull request #93903 from Geometror/vs-fix-frame-edscale
Fix some VisualShader features for high DPI displays/custom UI scales
2024-07-04 23:27:03 +02:00
Hendrik Brucker b871794591 Fix `GraphFrame` autoshrink with high DPI displays/custom UI scales 2024-07-04 19:08:06 +02:00
bruvzg 41df3caad3
[Button] Use align_to_largest_stylebox for min. size calculation. 2024-07-04 09:40:55 +03:00
kleonc 88b29539f7 Fix AtlasTexture::draw_rect flipping for non-zero margin 2024-07-01 21:22:25 +02:00
Ainsley Su 819c392ca3
Notify item_rect_changed before resized. 2024-07-01 11:54:07 +08:00
Alvin Wong cc45c2cdd3 Change GUI controls pixel snap to round halfway to +ve infinity 2024-06-30 00:33:37 +08:00
Mark DiBarry 6b17d51425 Add alternative pixel rounding 2024-06-29 10:33:39 -04:00
semensanyok 5dffb9b5e6 fix RichTextLabel fade set start_index to command offset 2024-06-28 23:15:21 +02:00
Rémi Verschelde a647789c5b
Merge pull request #93656 from vgezer/fixmissingsep
Add missing punctuation to the default TextEdit word separators
2024-06-28 11:35:11 +02:00
Volkan Gezer 76b2e5b2c8 add missing punctuation to the default list 2024-06-27 17:51:21 +02:00
kit a7da814c6b CodeEdit Fix move lines up/down viewport and selection issues 2024-06-25 15:31:20 -04:00
Rémi Verschelde b63df071bd
Merge pull request #92514 from /addWordSeparators 2024-06-25 09:19:35 +02:00
Volkan Gezer e60678f193 enable custom separators to treat different characters as words 2024-06-24 20:43:13 +02:00
Rémi Verschelde bf20231140
Merge pull request #93179 from TheSofox/tree-nav-crash
Fix engine crashing when using Down Arrow selection on Tree with no selection
2024-06-24 11:14:06 +02:00
Sofox d86e02580c Fix engine crashing when using Down Arrow selection on Tree with no selection 2024-06-22 18:40:21 +01:00
Rémi Verschelde 04bf7d4cad
Merge pull request #93467 from anniryynanen/progress-circle-atlas
Fix atlas texture positioning in circular TextureProgressBar
2024-06-22 16:22:30 +02:00
Anni Ryynänen 2c5befde43
Fix atlas texture positioning in circular TextureProgressBar
In 4.2 TextureProgressBar needed to position its atlas texture, but in 4.3
`draw_polygon()` handles it.
2024-06-22 16:07:26 +03:00
Javi Rodriguez d6e17b8a0d Fix FlowContainer scale from also scaling wrap point
When a FlowContainer was scaled, the point at which a line wraps would
also be scaled. This would cause a FlowContainer to have lines that did
not fit the container.

FlowContainer no longer factors its scale when resorting children.

Fixes #93439
2024-06-21 19:13:43 -04:00
Anni Ryynänen 0fefd6cc80
Fix GridContainer minimum size when there's a hidden parent
When calculating minimum size, GridContainer only looks at children that are
returned from `as_sortable_control()`. That defaults to only showing children
visible in the tree, so if the grid has a hidden parent the minimum size
becomes (0, 0).

After this change only the child itself needs to be visible, making
`GridContainer::get_minimum_size()` behave the same way as other controls.

Fixes #91722.
2024-06-20 13:49:09 +03:00
kit a3b944c41d Clarify Mouse Filter Pass in the Inspector 2024-06-19 14:43:06 -04:00
A Thousand Ships fbb879debd
[Scene] Add `SceneStringNames::text/value_changed` 2024-06-19 09:44:38 +02:00
A Thousand Ships ca18a06ecb
[Scene] Add `SceneStringNames::confirmed` 2024-06-19 09:40:54 +02:00
A Thousand Ships d9e2fc74c7
[Scene] Add `SceneStringNames::item_selected` 2024-06-19 09:39:05 +02:00
Rémi Verschelde 39ab252ba1
Merge pull request #93140 from bruvzg/rtl_table_bg_sep
[RTL] Fix table h/v separation alignment.
2024-06-18 17:59:13 +02:00
Rémi Verschelde fb3d489baa
Merge pull request #93137 from bruvzg/rtl_row_align
[RTL] Fix `align_to_row` for the last table row.
2024-06-18 17:59:10 +02:00
A Thousand Ships d519715d94
[Scene] Add `SceneStringNames::font(_size/_color)` 2024-06-18 17:24:27 +02:00
bruvzg 8ac0d81825
[RTL] Fix table h/v separation alignment. 2024-06-15 17:55:08 +03:00
bruvzg 23fbdacef8
[RTL] Fix `align_to_row` for the last table row. 2024-06-13 22:03:34 +03:00
bruvzg 35b4b5f779
[Button] Do not include internal margins into base button minimum size. 2024-06-13 14:18:44 +03:00
kit 630d3eb35e Don't error when undo stack is empty 2024-06-11 12:16:36 -04:00
Rémi Verschelde 034e579fa5
Merge pull request #92901 from kleonc/texture-progress-bar-fix-radial-mode-2-point-polygon-edge-case
Fix `TextureProgressBar` radial mode invalid polygon edge case
2024-06-11 16:59:31 +02:00
Rémi Verschelde a0bbd398ee
Merge pull request #93008 from aaronp64/container_queue_sort
Fix `Container::pending_sort` tracking
2024-06-11 11:53:42 +02:00
Rémi Verschelde 972839d12a
Merge pull request #92968 from bruvzg/rtl_list_indent
[RTL] Fix list item prefix width not taken into account.
2024-06-11 11:22:52 +02:00
aaronp64 5a25637ca9 Fix Container::pending_sort tracking
When Container::queue_sort() is called, pending_sort is set to true to indicate when a call to _sort_children() is queued, to avoid queueing multiple calls. Container::_sort_children() sets pending_sort back to false when finished, but did not do this when the container was not inside the tree.  This would allow cases where queue_sort() could be called just before removing from the tree, causing _sort_children() to never reset pending_sort, preventing any future queue_sort() calls from queueing again.

One case where this happened was with the "Saving Scene" progress bar in the editor - when saving for the first time (or the first time the progress bar popup otherwise appeared in the editor), _sort_children() would be called successfully.  After the progress bar popup was hidden, then shown again on future saves, _sort_children() would not be called again, resulting in the progress bar not taking up as much space as it should.

This issue used to be avoided by setting pending_sort to false immediately on NOTIFICATION_ENTER_TREE - however, this would allow multiple calls to be queued at the same time when entering the tree (#92644).  The multiple calls was fixed recently by removing this assignment, but this also made possible the case where pending_sort is never reset.

This change sets pending_sort back to false in _sort_children() whether or not it's in the tree.  Since this is done in a deferred call, it should still avoid the previous issue of multiple calls being queued at once on entering the tree.

Fixes #92971
2024-06-10 20:17:47 -04:00
bruvzg 721a663aa3
[Button] Adds theme option to align button text and icon to either largest or current stylebox. 2024-06-10 18:40:52 +03:00
bruvzg fff71db5b1
[RTL] Fix list item prefix width not taken into account. 2024-06-10 13:14:56 +03:00
Anni Ryynänen b14b222e9d
Fix native file dialogs being shown on `set_visible(false)` 2024-06-09 17:54:18 +03:00
kleonc 7f6951b1f6 Fix TextureProgressBar radial mode invalid polygon edge case 2024-06-08 13:51:32 +02:00
Rémi Verschelde a6bb8b00d7
Merge pull request #92664 from KoBeWi/ultimate_final_solution_for_containers
Add visibilty mode to `as_sortable_control()`
2024-06-07 23:29:48 +02:00
Rémi Verschelde 2c01573fdf
Merge pull request #92645 from WhalesState/container-resort
Fix `NOTIFICATION_SORT_CHILDREN` is called twice on startup
2024-06-07 23:29:44 +02:00
Rémi Verschelde 1ee953030e
Merge pull request #92271 from kitbdev/fix-max-line-size
Fix TextEdit HScroll hiding after wrapping
2024-06-07 23:29:28 +02:00
Rémi Verschelde c2d983553b
Merge pull request #91390 from kitbdev/add-selection-unhide-carets
Unhide carets in add selection for occurrence and fix error
2024-06-07 23:29:23 +02:00
kleonc 8228d647a9 Fix MenuBar popup placement assuming it's in viewport default canvas 2024-06-06 16:46:13 +02:00
Rémi Verschelde 7c2d65ff66
Merge pull request #92745 from bruvzg/rtl_list_fix
[RTL] Fix nested ordered lists inside unordered lists.
2024-06-04 10:10:34 +02:00
bruvzg 5e616cedd4
[RTL] Fix nested ordered lists inside unordered lists. 2024-06-04 08:08:16 +03:00
bruvzg d45b896673
Fix IME activation in subviewports. 2024-06-04 00:03:02 +03:00
kobewi 02e1e6d1ec Add visibilty mode to as_sortable_control() 2024-06-03 20:01:31 +02:00
Rémi Verschelde 9b4cfcba5f
Merge pull request #92669 from Hilderin/fix-huge-tscn-icon-in-background-of-file-system-panel
Fix huge .tscn icon and icon in background of File System panel
2024-06-03 10:36:02 +02:00
Hilderin 81395cf9bd Fix Huge .tscn Icon and icon in background of File System panel 2024-06-02 09:11:56 -04:00
Mounir Tohami 62a58c5538 Fix `NOTIFICATION_SORT_CHILDREN` is called twice on startup 2024-06-01 15:49:43 +00:00
aaronp64 6ecccd6085 Fix RichTextLabel table overlapping with next line
When calculating table height, RichTextLabel::_shape_line would increase the height when it reached the end of a complete row, or the final cell of the table.  RichTextLabel::_resize_line would only increase the height at the end of a complete row, causing the height to ignore the final row if not all cells were populated.  This would cause the final row to overlap with the following line in the RichTextLabel if it was the last visible line in the RichTextLabel, as _resize_line is called when updating scrolling properties.

This change moves the common table size calculations to a separate function to reuse the code between _shape_line and _resize_line, keeping the final cell check that was used in _shape_line.

Fixes #92603
2024-05-31 16:21:17 -04:00
Rémi Verschelde 07e6d0c702
Merge pull request #92138 from YeldhamDev/scrollcontainer_fixes
Fix scrollbar issues in `ScrollContainer`
2024-05-31 14:16:10 +02:00
A Thousand Ships 926afccbd8
[Scene] Add `SceneStringNames::panel` 2024-05-30 22:54:50 +02:00
A Thousand Ships 755a0efbb6
[Scene] Add `SceneStringNames::id_pressed` 2024-05-30 22:54:04 +02:00
Rémi Verschelde 505da68b26
Merge pull request #92565 from bruvzg/rtl_clear_flags
[RTL] Clear default justification flags if custom are set.
2024-05-30 22:13:59 +02:00
bruvzg 3a52e0f5fd
[RTL] Clear default justification flags if custom are set and fix typo in the flag name. 2024-05-30 21:23:26 +03:00
kit af6b96c486 Fix minimap error when moving to the top 2024-05-30 12:06:02 -04:00
Rémi Verschelde adbc4b086b
Merge pull request #92489 from kleonc/control-invalidate-global-transform-before-notifying-resize
Invalidate `Control` global transform before notifying about resize / rect change
2024-05-30 11:48:09 +02:00
Rémi Verschelde 4cd39c56fb
Merge pull request #92283 from KoBeWi/code_simpleton
Automatically use property count in PropertyListHelper
2024-05-30 11:47:58 +02:00
kleonc 22b6f962d9 Invalidate Control global transform before notifying about resize / rect change 2024-05-30 10:10:24 +02:00
Rémi Verschelde 219af366a5
Merge pull request #92505 from bruvzg/te_ro_margins
[TextEdit] Use style margins for selection in read-only mode.
2024-05-29 11:20:14 +02:00
Rémi Verschelde 05442e81c0
Merge pull request #92500 from timothyqiu/stretch-shrink-range
Add range hint for `SubViewportContainer.stretch_shrink`
2024-05-29 11:20:11 +02:00
Rémi Verschelde b60471f3c0
Merge pull request #92463 from Daylily-Zeleen/daylily-zeleen/fix_graph_edit_minimap_connection_line
[GraphEdit] Convert to minimap line after getting connection line.
2024-05-29 11:20:04 +02:00
Rémi Verschelde 9bb858c803
Merge pull request #92460 from bruvzg/adlg_cancel_conf
Fix duplicate AcceptDialog cancel/confirm events.
2024-05-29 11:20:01 +02:00
bruvzg 1d0a8ea828
[TextEdit] Use style margins for selection in read-only mode. 2024-05-29 10:07:32 +03:00
Daylily-Zeleen 28a2fa496f [GraphEdit] Convert to minimap line after getting connection line. 2024-05-29 12:58:51 +08:00
Haoyu Qiu fd5118c781 Add range hint for SubViewportContainer.stretch_shrink 2024-05-29 09:03:15 +08:00
Rémi Verschelde 43cf4740b9
Merge pull request #92461 from bruvzg/rtl_meta_y
[RTL] Use real text/object height instead of line height for meta click/hover detection.
2024-05-28 16:13:26 +02:00
Rémi Verschelde 194b1c478d
Merge pull request #92342 from aaronp64/textedit_duplication
Remove duplicate if/else code in `TextEdit::_notification`
2024-05-28 15:49:19 +02:00
Rémi Verschelde a10897ddc0
Merge pull request #92301 from robert-wallis/fix-code-edit-delimiter-crash
Fix crash during code editor folding and LSP
2024-05-28 15:49:09 +02:00
Rémi Verschelde 13a32e2753
Merge pull request #92296 from timothyqiu/complete-remove-override
Fix theme StyleBox override parameter completion
2024-05-28 15:49:05 +02:00
Rémi Verschelde cfe80f9fec
Merge pull request #92222 from semensanyok/fix-TextureButton-click-mask-texture-size-ignored-if-missing-normal-texture
Fix TextureButton's click mask texture size ignored if missing normal texture
2024-05-28 15:48:58 +02:00
bruvzg 061ad36732
[RTL] Use real text/object height instead of line height for meta click/hover detection. 2024-05-28 11:46:56 +03:00
bruvzg 3e691e026b
Fix duplicate AcceptDialog cancel/confirm events. 2024-05-28 10:46:28 +03:00
MrPersonDev 2860b99077 Fix backspace always unfolding previous line 2024-05-27 13:30:19 -07:00
kit 948f09632e Unhide carets in add selection for occurrence 2024-05-27 15:30:18 -04:00
kit 66a8ee71aa Fix TextEdit HScroll hiding after wrapping 2024-05-27 14:56:55 -04:00
aaronp64 05cc8e7aaf Remove duplicate if/else code in TextEdit::_notification 2024-05-25 10:50:04 -04:00
semensanyok 63554c7765 Fix TextureButton's click mask texture size ignored if missing normal texture 2024-05-25 15:40:09 +02:00
kobewi b365a63403 Automatically use property count in PropertyListHelper 2024-05-25 10:51:37 +02:00