31fab43b8b
Fix scene load crash related to `_ready`
...
The iterator might get invalidated during `_ready`-user-code.
Prevent this by disallowing set_name during iterator-operations.
2023-06-25 22:35:38 +02:00
afe65de110
Merge pull request #78591 from ajreckof/Fix-crash-when-removing-child-during-focus-exit-
...
Fix crash when removing child during focus exit.
2023-06-23 22:45:51 +02:00
f745299c36
Fix crash when removing child during focus exit.
2023-06-23 21:31:18 +02:00
68193bee9a
Revert "Fix that the focus-out notification got sent deferred"
...
This reverts commit 8cdab04d7fFixes #78589 .
2023-06-23 18:03:48 +02:00
60c261ba2d
Re-add `mouse_focus`-nullcheck
2023-06-22 21:58:19 +02:00
283580d0cc
Merge pull request #78566 from kleonc/repeated-sprite-selection-fix
...
Fix click-selecting Sprites with repeated texture
2023-06-22 18:32:01 +02:00
edba45ec8b
Fix click-selecting Sprites with repeated texture
2023-06-22 16:37:08 +02:00
5ec1b698d2
Fix missing enum value for `Window.initial_position`
...
Reorder the properties in a possibly more intuitive order.
Co-authored-by: Rémi Verschelde <rverschelde@gmail.com>
2023-06-21 22:39:43 +02:00
890fdd56df
Code simplifications
...
CPPcheck found most of them.
no need to assign the variable twice:
- AnimationTrackEditTypeAudio
- SSEffects
variable is assigned in all if-else clauses:
- EditorHelp
- AndroidInputHandler
- MenuBar
- ShaderCompiler
same if clause:
- ItemList
clearing an empty bitfield has no effect:
- Viewport
2023-06-21 22:37:26 +02:00
83f065c0ef
Ensure that SceneTree is initialized and finalized at correct time
...
SceneTree should be fully initialized before any tree operation with any node and finalized only after all nodes exited tree.
2023-06-20 23:47:02 +03:00
a12627765f
Embedded Popups store their safe_rect in their embedder
...
Storing it in the DisplayServer didn't make sense in this case,
because the embedded window is unknown to the DisplayServer.
2023-06-20 18:06:26 +02:00
159f1ec301
Merge pull request #78398 from Sauermann/fix-immediate-focus-out
...
Fix that the focus-out notification got sent deferred
2023-06-20 13:14:10 +02:00
cce100a840
Merge pull request #75459 from kleonc/node-fix-find-children
...
Fix recursive `Node.find_children`
2023-06-19 22:33:46 +02:00
8cdab04d7f
Fix that the focus-out notification got sent deferred
...
Currently the window receives a focus-out notification, directly after
it popup, because currently the signal is sent deferred.
The original intention was that the previously focused window must
receive a focus-out notification.
This change makes the notification more precise by only sending the
focus-out to the previously focused window.
2023-06-18 23:06:07 +02:00
5373b67e2a
Respect returned bool from virtual process methods in SceneTree
...
SceneTree overrides the virtual `process` and `physics_process` methods
that it inherits from MainLoop. These methods return a boolean that
determines if the main loop should end.
The SceneTree was ignoring the returned boolean, so scripts inheriting
from SceneTree that override these methods and return true didn't exit
the main loop. Now the boolean is checked.
2023-06-18 20:45:58 +02:00
5b2a5cd2e0
Fix Physics Picking captured Object initialization
...
Initialize variables when a captured object is known.
2023-06-18 00:45:49 +02:00
f1d8ddd9bd
Remove SceneTree debug avoidance hint
...
Removes SceneTree debug avoidance hint.
2023-06-16 17:18:47 +02:00
2ebe692ccc
Merge pull request #78276 from smix8/remove_old_navdebug_materials_4.x
...
Remove legacy navigation debug materials
2023-06-16 10:20:20 +02:00
014b395ef3
Merge pull request #78262 from bruvzg/ds_window_focus
...
[DisplayServer] Add method to check if native window is focused.
2023-06-16 10:19:33 +02:00
28db3c7158
[DisplayServer] Add method to check if native window is focused.
2023-06-16 10:27:52 +03:00
1b506cd49c
Remove legacy navigation debug materials
...
Removes legacy navigation debug materials.
2023-06-15 16:33:55 +02:00
eb391d3302
Display `BitField[Enum]` in docs to distinguish from `Enum`
2023-06-15 17:23:02 +03:00
c3e5e4ed4b
Merge pull request #68599 from Rindbee/update-edited_scene_root-in-time
...
Update the edit scene root in time after it is replaced
2023-06-12 17:08:50 +02:00
eb74079dfb
Update the edit scene root in time after it is replaced
...
When changing the type of the edited scene root node, it may be necessary
to update edited scene root in time for the child nodes to work properly.
2023-06-12 21:49:30 +08:00
9fca498647
Merge pull request #78110 from Sauermann/fix-nofocus-focus
...
Fix Tooltip getting removed instantly in embedded Window
2023-06-12 11:55:58 +02:00
9d40f99290
Fix Tooltip getting removed instantly in embedded Window
...
Tooltips are unfocusable Windows. This case was not handled correctly in
`Viewport::_sub_window_register`.
2023-06-11 12:22:59 +02:00
0c16082e1e
Use `get_node_or_null` when null checks are present
...
Avoids duplicate or unnecessary errors
2023-06-10 13:22:56 +02:00
37a96d3957
Fix that `_drop_physics_mouseover` only happens when necessary
...
Previously the call was executed every time, because in the
`_drop_mouse_over();` a few lines above, `gui.mouse_over = nullptr;`
was set.
2023-06-10 09:33:16 +02:00
dcd2b883eb
Use NULL instead of COND checks when appropriate
...
Restricted to scene
2023-06-10 08:56:30 +02:00
8acf6b41a4
Merge pull request #77209 from Rindbee/ViewportTexture-not-change-RID
...
Don't change `RID` when changing `viewport_path` in `ViewportTexture`
2023-06-09 15:10:39 +02:00
7532b2d259
Don't change `RID` when changing `viewport_path` in `ViewportTexture`
...
When changing `viewport_path`, the `proxy`'s target is changed to a new placeholder.
Add a flag `vp_changed` to prevent calling `setup_local_to_scene` (mainly called by toggling `resource_local_to_scene`) when the target viewport has not changed.
2023-06-09 19:50:26 +08:00
300748e52c
Merge pull request #78044 from RandomShaper/fix_node_prio_ignored
...
Fix node idle process priority being ignored
2023-06-09 13:45:15 +02:00
2a8e83ccad
Merge pull request #78017 from Sauermann/fix-physics-passive-hovering
...
Fix passive mouse hovering for physics
2023-06-09 13:44:05 +02:00
8bbc713ebf
Fix node idle process priority being ignored
2023-06-09 13:05:07 +02:00
543fdc1490
Fix passive mouse hovering for physics
...
Currently mouse hovering doesn't update the state, when collision objects
or the camera move.
This PR fixes this problem by taking the mouse position from the viewport
and not from a nonexistent previous event.
Since previous events could potentially be a long time ago, their
modifier-key state might be outdated. This PR fetches the current
status of modifier-keys from `Input`.
These changes allow the removal of some class-variables and making
additional simplifications.
2023-06-09 12:51:10 +02:00
0cee1e0d4f
Merge pull request #77923 from Sauermann/fix-mouse-position-with-screen-transform
...
Fix mouse position with screen transform
2023-06-09 12:15:56 +02:00
37fc598ee1
Merge pull request #77899 from bruvzg/emb_center
...
Use initial position property for embedded windows to center on parent window.
2023-06-09 12:15:07 +02:00
d1fa284e65
Fix mouse position with screen transform
...
When a Viewport is not directly attached to the screen, the
function `Viewport::get_mouse_position` can't rely on
`get_screen_transform`, because that function is ambiguous in
these situations.
In these cases it is necessary to use the mouse position from
the most recent mouse IputEvent.
2023-06-09 11:29:43 +02:00
fd2f33942b
Merge pull request #78019 from Sauermann/fix-remove-child-inconsistency
...
Fix parent inconsistency in `Node::remove_child`
2023-06-09 11:06:49 +02:00
b083c1dbf5
Merge pull request #78005 from Sauermann/fix-some-simplifications
...
Some code simplifications
2023-06-09 11:06:26 +02:00
166643df32
Merge pull request #74937 from bitsawer/fix_uniform_storage
...
Fix shader uniform storage conversions and crash
2023-06-09 11:04:16 +02:00
7561e176e8
Fix parent inconsistency in `Node::remove_child`
...
`NOTIFICATION_CHILD_ORDER_CHANGED` could be triggered, while there
was an inconsistent state:
- parent node no longer had child listed as child
- child node still had parent node listed as parent
Bring these two in sync, before emitting the notification.
2023-06-08 22:51:07 +02:00
302a10e809
Fix `CanvasItem::draw_string_outline` parameter order
...
Switch `p_font_size` with `p_size` in header, because in all
other locations, `p_font_size` comes before `p_size`.
2023-06-08 18:15:38 +02:00
3a19d81691
Merge pull request #77842 from Sauermann/fix-unfocusable-subwindow
...
Fix input handling for unfocusable embedded windows
2023-06-08 17:38:33 +02:00
5ddab1f363
Some code simplifications
...
AnimationNodeBlendSpace2DEditor:
- `!tree` is always false, because it is checked a few lines above
CurveEdit:
- grabbing != GRAB_NONE is redundant
GradientTexture2DEdit:
- grabbed != HANDLE_FROM is redundant
- grabbed != HANDLE_TO is redundant
Viewport:
- index is not used afterwards
- In these cases `gui.mouse_focus` is always valid. Move check to a DEV_ASSERT
- simplify `stopped` calculation
2023-06-08 16:15:22 +02:00
42e4c41e77
Merge pull request #77888 from Calinou/node-improve-thread-guard-errors
...
Display the node path in Node thread guard errors
2023-06-08 09:10:18 +02:00
bd468cdec7
Display the node path or name in Node thread guard errors
...
This makes it easier to diagnose which node is the source of the issue.
2023-06-07 16:06:53 +02:00
27b402bf73
Merge pull request #77902 from dalexeev/doc-unify-deprecations
...
Documentation: Unify deprecations
2023-06-07 16:06:50 +02:00
b433020aa6
Documentation: Unify deprecations
2023-06-07 16:34:03 +03:00
807431c49a
Cancel tooltip when mouse leaves viewport
2023-06-07 00:56:36 +02:00
f00f4a0209
Fix input handling of unfocusable embedded Windows
...
InputEvents get in some cases sent to the wrong Window.
fix `Viewport::_sub_windows_forward_input`- console error spam
2023-06-06 17:51:19 +02:00
2e728e02cc
Merge pull request #77763 from RedworkDE/warning-dialog-crash
...
Prevent crashes when removing Viewport from scene tree in event handler
2023-06-06 12:19:25 +02:00
e5b312a1e8
Use initial position property for embedded windows to center on parent window.
2023-06-06 09:29:13 +03:00
85c908654c
Merge pull request #77867 from Sauermann/revert-move-child-update
...
Don't update mouse cursor state on child order changed
2023-06-05 13:43:11 +02:00
15ee292664
Don't update mouse cursor state on child order changed
...
Partially Revert "Create a virtual mouse move event after moving child nodes"
This reverts parts of commit ce10ca6979
2023-06-05 10:28:55 +02:00
c4db212870
Prevent crashes when removing Viewport from scene tree in event handler
2023-06-03 23:37:31 +02:00
8b42297d7c
Make `Viewport::gui_get_focus_owner` const
2023-06-02 12:36:10 -05:00
2e273f0e35
Merge pull request #77724 from RandomShaper/remove_red_th_cond
...
Remove redundant check from thread guards
2023-06-01 15:52:16 +02:00
8c288918a0
Remove redundant check from thread guards
2023-06-01 11:08:14 +02:00
6d490ce8de
Deprecate push_unhandled_input
...
The functionality of `push_unhandled_input` has changed so that it no
longer propagates input events to SubViewports.
This makes it less predictable and it should be deprecated in favor of
`push_input` which provides the same functionality and more.
Also this deprecation simplifies the Viewport-API by reducing the methods
for pushing input events, so that users don't need to worry about when
to use which function in order to insert input events.
2023-05-31 19:07:04 +02:00
6dd5ccdedd
Merge pull request #66625 from Sauermann/fix-move-child-update
...
Create a virtual mouse move event after moving child nodes in tree
2023-05-30 15:57:21 +02:00
3a895eafc0
Merge pull request #77595 from Sauermann/fix-double-inputevent
...
Fix InputEvent being used twice
2023-05-30 15:25:36 +02:00
ce10ca6979
Create a virtual mouse move event after moving child nodes
...
This updates mouse cursor and mouse-over-states without the need
for additional mouse movements.
2023-05-29 22:46:19 +02:00
ee7b26403b
Merge pull request #77433 from YuriSizov/editor-reparented-popups-fix
...
Fix auto-reparenting logic in the `ProgressDialog`
2023-05-29 17:30:46 +02:00
4c5c7cbb58
Fix auto-reparenting logic in the `ProgressDialog`
...
* Make sure `Popup` signals are disconnected when unparented.
* Remove a fail condition from `Window::is_embedded` when
not in tree.
2023-05-29 17:02:16 +02:00
23c375d6b4
Fix shader uniform storage conversions and crash
2023-05-29 15:17:13 +03:00
a9bf3de08e
Fix InputEvent being used twice
...
A single mouse click can cause multiple actions, which contradicts
the paradigm that a single Input Event should cause only a single
action.
The solution consists of two parts:
1. Physics Picking as the last step during viewport input event
handling, currently doesn't set the event as handled. This PR sets
the event as handled in the case of physics picking.
2. After an InputEvent is processed by a SubVieportContainer, it is
sent to its parent, even if it set as handled within the SubViewport.
This PR adds an additional test to check if the event is handled
before propagating the event to the parent Control.
2023-05-29 02:39:09 +02:00
af04d3fb2c
Fix error when attempting to move a embedded window with a negative title height
2023-05-28 16:46:16 -03:00
adbdf9a86e
Merge pull request #77234 from RandomShaper/fix_rtl_mt
...
Allow threads to mark themselves as safe for nodes
2023-05-24 08:42:59 +02:00
e725b4b02b
Allow threads to mark themselves as safe for nodes
2023-05-24 00:22:58 +02:00
012541763d
Merge pull request #77288 from puchik/expose_get_window_id
...
Expose get_window_id() from Window class
2023-05-23 19:14:24 +02:00
ab935aaac6
Merge pull request #77312 from ajreckof/fix_window_unselectable_for_ViewportTexture_NodePath
...
Fix `Window` derived nodes being unselectable for `ViewportTexture` `NodePath`
2023-05-22 17:02:20 +02:00
250d8d00b5
Fix compile issue in not very conformant compilers
2023-05-22 13:33:40 +02:00
ace7620e55
fix `Window`derived nodes being unselectable for `ViewportTexture` `NodePath`
2023-05-21 16:28:41 +02:00
49890a99c1
Expose get_window_id() from Window class
...
Window classes often need a Window ID for operations. This will help with performing operations on cached Windows.
2023-05-20 14:48:24 -07:00
50cf3d6966
Optimize threading-sensitive node data for single-threaded processing
2023-05-17 02:04:41 +02:00
44cc0d2ec2
Let calls through thread guards in resource loading contexts
2023-05-17 01:43:28 +02:00
755c61b57a
Merge pull request #77064 from brno32/push-input-null-check
...
Check for null event in Viewport::push_input
2023-05-16 11:04:08 +02:00
12b7a56202
Merge pull request #76713 from KoBeWi/TODO_is_now
...
Fix 2D audio in multiple viewports
2023-05-16 11:00:45 +02:00
508a5bf16e
Merge pull request #76025 from YuriSizov/editor-reparentable-windows
...
Expose dialog parent-and-popup logic to the API
2023-05-16 10:49:09 +02:00
59c19a7172
Merge pull request #75250 from bruvzg/lbl_rtl_jst_flags
...
Expose TextServer justification flags to Label, Label3D, TextMesh and RTL. Add flags to control last/single line justification.
2023-05-16 10:48:45 +02:00
8cfa19a078
Merge pull request #77000 from reduz/make-more-base-nodes-thread-safe
...
Make more base nodes thread safe
2023-05-16 00:31:56 +02:00
a5a1c3a03c
check for null event in Viewport::push_input
2023-05-15 20:16:15 +02:00
17f492fb82
Expose dialog parent-and-popup logic to the API
2023-05-15 19:49:28 +02:00
9163d8c336
Expose TextServer justification flags to Label, Label3D, TextMesh and RTL. Add flags to control last/single line justification.
2023-05-15 19:23:54 +03:00
0a9f72d5a8
Make more base nodes thread safe
...
Ongoing work to make more of the base nodes thread safe.
2023-05-15 16:54:10 +02:00
1eb250e17d
Avoid crash when adjusting a node tree that is not in the tree
...
When node tree `A` is not in the tree, `remove_child(B)` will not
automatically clean up the owners of `B` and `B`'s child nodes.
This is convenient for implementing operations like `replace_by()`,
but may have hidden dangers when manipulating the rest of the tree
`A`.
This commit makes it safe to manipulate the rest of `A` after freeing
`B`.
2023-05-11 08:57:39 +08:00
5271186f2f
Merge pull request #75901 from reduz/refactor-node-processing
...
Refactor Node Processing to allow Scene Multithreading
2023-05-10 12:46:44 +02:00
31fc7a8525
Merge pull request #62378 from trollodel/gsoc_2022_multiwindow
...
Add multi window code and shader editors (GSOC'22 Project)
2023-05-10 12:46:19 +02:00
3b8c828159
Merge pull request #69988 from smix8/navigation_rvo_rework_4.x
...
Rework Navigation Avoidance
2023-05-10 10:19:12 +02:00
8e608e9467
Merge pull request #64388 from Rindbee/improve-ViewportTexture
...
Improve the UX of ViewportTexture in the editor
2023-05-10 10:18:43 +02:00
b4d6b47c17
Add multi window code and shader editors
2023-05-10 09:14:21 +02:00
a6ac305f96
Rework Navigation Avoidance
...
Rework Navigation Avoidance.
2023-05-10 05:01:58 +02:00
af58f1e854
Improve the UX of ViewportTexture in the editor
...
The associated `ViewportTexture`s will update the `viewport_path`
in time when the `Viewport`'s nodepath is changed (caused by renaming
the node names or moving in the SceneTree dock).
If the target `Viewport` is changed by resetting the `viewport_path`,
the `ViewportTexture`s will be re-setup and emit `changed` signal in
time.
2023-05-10 09:13:43 +08:00
98c655ec8d
Refactor Node Processing
...
* Node processing works on the concept of process groups.
* A node group can be inherited, run on main thread, or a sub-thread.
* Groups can be ordered.
* Process priority is now present for physics.
This is the first steps towards implementing https://github.com/godotengine/godot-proposals/issues/6424 .
No threading or thread guards exist yet in most of the scene code other than Node. That will have to be added later.
2023-05-09 19:17:51 +02:00
72323a57d0
Merge pull request #57894 from Sauermann/fix-subviewport-1
...
Fix unrestricted mouse-event propagation to SubViewports for Physics-Picking
2023-05-09 10:43:49 +02:00
15f9ac9458
Merge pull request #75751 from KoBeWi/eradicate_ViewportTexture_errors_entirely_and_surely
...
Prevent errors when using ViewportTexture
2023-05-08 16:40:10 +02:00
bbe05b60c8
Merge pull request #57179 from spacechase0/notify-world2d-changed-master
...
Propagate previously unused NOTIFICATION_WORLD_2D_CHANGED, make CanvasItem/CollisionObject2D use it
2023-05-08 16:40:00 +02:00
1b9802fa8c
Prevent errors when using ViewportTexture
2023-05-08 15:56:16 +02:00
8118d0d2f5
Add more uses of appropriate cursors when resizing/moving some UI nodes
2023-05-07 11:14:57 -03:00
Markus Sauermann
Rémi Verschelde
ajreckof
Rémi Verschelde
kleonc
jeana helver
Nickolai Korshunov
Raul Santos
smix8
bruvzg
Danil Alexeev
Rindbee
Ninni Pipping
Pedro J. Estébanez
Hugo Locurcio
kobewi
Yuri Sizov
RedworkDE
Aaron Franke
Yuri Sizov
bitsawer
Michael Alexsander
Arman Elgudzhyan
Alex Drozd
Juan Linietsky
trollodel