godotengine/godot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
aa2215e681
godot/editor
History
Rémi Verschelde aa2215e681
Main: Fixup bogus fallback to project manager with more bolognese 
WARNING: Hacks everywhere!

The logic in `main.cpp` is due a full rewrite as it's extremely hacky,
splitting argument parsing over several functions, with a mess of global state
and assumptions about what combinations of arguments or lack thereof should
mean in terms of what we want to read: game, editor, project manager, or
command line tools such as `--doctool`, `--export` or `--script`.

Until this is fully rewritten, this patch hacks things some more to ensure
that we don't fall back to the project manager in cases where it's not
warranted, and especially not *too late*, as it can mean that we haven't
properly initialized stuff like `EditorPaths` needed by the PM (which in turn
impacts what kind of path will be used for logs and the shader cache, etc...
the rabbit hole goes deep).

Fixes #41435.
Fixes #49392.
Fixes #49658.
Fixes https://github.com/godotengine/godot/issues/38202#issuecomment-773158477.
2021-06-16 19:11:08 +02:00
..
debugger Rename Reference to RefCounted 2021-06-11 18:48:42 +02:00
fileserver Rename File::get_len() get_length() 2021-05-25 11:54:28 +01:00
icons Adding some more missing renames for Transform3D and Quaternion 2021-06-15 16:01:50 +02:00
import Merge pull request #49458 from JFonS/fix_unwrap_xform 2021-06-14 18:32:33 +02:00
plugins Don't use the abbrevation "Sep." in UI text 2021-06-16 19:40:12 +08:00
translations i18n: Sync translations with Weblate 2021-06-16 13:48:32 +02:00
action_map_editor.cpp Consistently prefix bound virtual methods with _ 2021-06-12 00:55:52 +02:00
action_map_editor.h Rename "Control" key to "Ctrl" and add "_pressed" suffix to all InputEventWithModifiers properties/methods 2021-05-07 14:00:50 -06:00
animation_bezier_editor.cpp Rename "Control" key to "Ctrl" and add "_pressed" suffix to all InputEventWithModifiers properties/methods 2021-05-07 14:00:50 -06:00
animation_bezier_editor.h Update copyright statements to 2021 2021-01-01 20:19:21 +01:00
animation_track_editor_plugins.cpp Rename "Control" key to "Ctrl" and add "_pressed" suffix to all InputEventWithModifiers properties/methods 2021-05-07 14:00:50 -06:00
animation_track_editor_plugins.h Update copyright statements to 2021 2021-01-01 20:19:21 +01:00
animation_track_editor.cpp Fix build after merge of #48598 2021-06-15 18:37:12 +02:00
animation_track_editor.h Merge pull request #48598 from Calinou/animation-track-editor-improve-scrolling 2021-06-15 18:27:06 +02:00
array_property_edit.cpp Removed _change_notify 2021-02-10 19:31:24 -03:00
array_property_edit.h Rename Reference to RefCounted 2021-06-11 18:48:42 +02:00
audio_stream_preview.cpp Modernize atomics 2021-02-18 17:12:46 +01:00
audio_stream_preview.h Rename Reference to RefCounted 2021-06-11 18:48:42 +02:00
code_editor.cpp Move FindReplaceBar out of CodeTextEditor 2021-06-08 23:23:07 +02:00
code_editor.h Move FindReplaceBar out of CodeTextEditor 2021-06-08 23:23:07 +02:00
connections_dialog.cpp Adding some more missing renames for Transform3D and Quaternion 2021-06-15 16:01:50 +02:00
connections_dialog.h Update copyright statements to 2021 2021-01-01 20:19:21 +01:00
create_dialog.cpp Consistently prefix bound virtual methods with _ 2021-06-12 00:55:52 +02:00
create_dialog.h Fix cases of resources destroyed too early 2021-01-06 23:40:50 +01:00
dependency_editor.cpp Core: Move DirAccess and FileAccess to core/io 2021-06-11 14:52:39 +02:00
dependency_editor.h Update copyright statements to 2021 2021-01-01 20:19:21 +01:00
dictionary_property_edit.cpp Removed _change_notify 2021-02-10 19:31:24 -03:00
dictionary_property_edit.h Rename Reference to RefCounted 2021-06-11 18:48:42 +02:00
doc_tools.cpp Core: Move DirAccess and FileAccess to core/io 2021-06-11 14:52:39 +02:00
doc_tools.h Update copyright statements to 2021 2021-01-01 20:19:21 +01:00
editor_about.cpp Separate version hash from version number in editor and project manager 2021-06-08 17:30:37 +03:00
editor_about.h Make it possible to copy the Godot version identifier by clicking it 2021-04-28 17:35:57 +02:00
editor_asset_installer.cpp Core: Move DirAccess and FileAccess to core/io 2021-06-11 14:52:39 +02:00
editor_asset_installer.h Update copyright statements to 2021 2021-01-01 20:19:21 +01:00
editor_atlas_packer.cpp Update copyright statements to 2021 2021-01-01 20:19:21 +01:00
editor_atlas_packer.h Update copyright statements to 2021 2021-01-01 20:19:21 +01:00
editor_audio_buses.cpp Consistently prefix bound virtual methods with _ 2021-06-12 00:55:52 +02:00
editor_audio_buses.h Improve the audio bus editor appearance 2021-05-27 10:00:49 +02:00
editor_autoload_settings.cpp Merge pull request #48619 from Calinou/editor-autoload-rename-singleton 2021-06-15 18:25:38 +02:00
editor_autoload_settings.h Update copyright statements to 2021 2021-01-01 20:19:21 +01:00
editor_builders.py Use a DynamicFont for the default project theme 2021-05-17 15:19:13 +02:00
editor_data.cpp Rename Reference to RefCounted 2021-06-11 18:48:42 +02:00
editor_data.h Fix typos with codespell 2021-05-20 12:38:56 +02:00
editor_dir_dialog.cpp Update copyright statements to 2021 2021-01-01 20:19:21 +01:00
editor_dir_dialog.h Core: Move DirAccess and FileAccess to core/io 2021-06-11 14:52:39 +02:00
editor_export.cpp Merge pull request #49511 from akien-mga/core-diraccess-fileaccess-io 2021-06-11 16:51:10 +02:00
editor_export.h Rename Reference to RefCounted 2021-06-11 18:48:42 +02:00
editor_feature_profile.cpp Core: Move DirAccess and FileAccess to core/io 2021-06-11 14:52:39 +02:00
editor_feature_profile.h Rename Reference to RefCounted 2021-06-11 18:48:42 +02:00
editor_file_dialog.cpp Remove trailing slash from recent dir if needed 2021-06-14 17:51:57 +02:00
editor_file_dialog.h Core: Move DirAccess and FileAccess to core/io 2021-06-11 14:52:39 +02:00
editor_file_system.cpp Refactor editor paths validation in EditorPaths and EditorSettings 2021-06-14 19:56:20 +02:00
editor_file_system.h Core: Move DirAccess and FileAccess to core/io 2021-06-11 14:52:39 +02:00
editor_folding.cpp Core: Move DirAccess and FileAccess to core/io 2021-06-11 14:52:39 +02:00
editor_folding.h Update copyright statements to 2021 2021-01-01 20:19:21 +01:00
editor_fonts.cpp Core: Move DirAccess and FileAccess to core/io 2021-06-11 14:52:39 +02:00
editor_fonts.h Update copyright statements to 2021 2021-01-01 20:19:21 +01:00
editor_help_search.cpp Change behavior of String.right 2021-05-20 23:07:57 +02:00
editor_help_search.h Rename Reference to RefCounted 2021-06-11 18:48:42 +02:00
editor_help.cpp Merge pull request #47791 from Chaosus/fix_doc_theme 2021-05-24 12:21:55 +02:00
editor_help.h Update copyright statements to 2021 2021-01-01 20:19:21 +01:00
editor_inspector.cpp Consistently prefix bound virtual methods with _ 2021-06-12 00:55:52 +02:00
editor_inspector.h Rename Reference to RefCounted 2021-06-11 18:48:42 +02:00
editor_layouts_dialog.cpp Update copyright statements to 2021 2021-01-01 20:19:21 +01:00
editor_layouts_dialog.h Update copyright statements to 2021 2021-01-01 20:19:21 +01:00
editor_log.cpp Fixed implementation of RTL remove_line(), which fixed issues in EditorLog. 2021-05-26 15:08:13 +10:00
editor_log.h Made Editor Log buttons save their state, per project. 2021-05-06 00:48:19 +10:00
editor_native_shader_source_visualizer.cpp Added ability to visualize native shaders 2021-01-06 09:40:09 -03:00
editor_native_shader_source_visualizer.h Added ability to visualize native shaders 2021-01-06 09:40:09 -03:00
editor_node.cpp Merge pull request #48597 from Calinou/editor-scale-auto-portrait 2021-06-15 18:27:48 +02:00
editor_node.h Merge pull request #49108 from LightningAA/reload-current-project-4.0 2021-06-15 15:40:52 +02:00
editor_path.cpp Make several actions in the Inspector dock more obvious 2021-06-04 02:05:27 +03:00
editor_path.h Make several actions in the Inspector dock more obvious 2021-06-04 02:05:27 +03:00
editor_paths.cpp Main: Fixup bogus fallback to project manager with more bolognese 2021-06-16 19:11:08 +02:00
editor_paths.h Refactor editor paths validation in EditorPaths and EditorSettings 2021-06-14 19:56:20 +02:00
editor_plugin_settings.cpp Core: Move DirAccess and FileAccess to core/io 2021-06-11 14:52:39 +02:00
editor_plugin_settings.h Detect plugins recursively 2021-01-19 18:09:30 +02:00
editor_plugin.cpp Validate parameters when adding plugins 2021-06-13 17:25:39 +08:00
editor_plugin.h Rename Transform to Transform3D in core 2021-06-03 07:30:01 -04:00
editor_properties_array_dict.cpp Consistently prefix bound virtual methods with _ 2021-06-12 00:55:52 +02:00
editor_properties_array_dict.h Rename Reference to RefCounted 2021-06-11 18:48:42 +02:00
editor_properties.cpp Merge pull request #49083 from foxydevloper/make-easing-line-smooth 2021-06-15 15:44:39 +02:00
editor_properties.h Rename Quat to Quaternion 2021-06-04 18:14:32 +01:00
editor_resource_picker.cpp Fix some virtual methods 2021-06-13 02:02:39 +02:00
editor_resource_picker.h Make EditorFileDialog only created on demand in EditorResourcePicker 2021-05-25 18:38:19 +03:00
editor_resource_preview.cpp Consistently prefix bound virtual methods with _ 2021-06-12 00:55:52 +02:00
editor_resource_preview.h Rename Reference to RefCounted 2021-06-11 18:48:42 +02:00
editor_run_native.cpp Rename Texture.get_data() to get_image() 2021-03-28 13:00:46 +01:00
editor_run_native.h Update copyright statements to 2021 2021-01-01 20:19:21 +01:00
editor_run_script.cpp Update copyright statements to 2021 2021-01-01 20:19:21 +01:00
editor_run_script.h Rename Reference to RefCounted 2021-06-11 18:48:42 +02:00
editor_run.cpp Implement the %command% placeholder in the Main Run Args setting 2021-05-07 00:05:02 +02:00
editor_run.h Update copyright statements to 2021 2021-01-01 20:19:21 +01:00
editor_scale.cpp Update copyright statements to 2021 2021-01-01 20:19:21 +01:00
editor_scale.h Update copyright statements to 2021 2021-01-01 20:19:21 +01:00
editor_sectioned_inspector.cpp Use bold fonts in editor 2021-06-02 12:47:57 -03:00
editor_sectioned_inspector.h Reorganize Project Settings 2021-02-18 11:23:34 -03:00
editor_settings.cpp Merge pull request #48597 from Calinou/editor-scale-auto-portrait 2021-06-15 18:27:48 +02:00
editor_settings.h Refactor editor paths validation in EditorPaths and EditorSettings 2021-06-14 19:56:20 +02:00
editor_spin_slider.cpp Mouse ptr reappears at drag start position 2021-05-23 10:48:26 +05:30
editor_spin_slider.h Update copyright statements to 2021 2021-01-01 20:19:21 +01:00
editor_themes.cpp Overhaul the theme editor and improve user experience 2021-06-14 21:46:30 +03:00
editor_themes.h Fix project icon size in Project Manager 2021-03-20 17:32:38 +08:00
editor_translation_parser.cpp Consistently prefix bound virtual methods with _ 2021-06-12 00:55:52 +02:00
editor_translation_parser.h Rename Reference to RefCounted 2021-06-11 18:48:42 +02:00
editor_vcs_interface.cpp Update copyright statements to 2021 2021-01-01 20:19:21 +01:00
editor_vcs_interface.h Update copyright statements to 2021 2021-01-01 20:19:21 +01:00
editor_zoom_widget.cpp Rework the TileSet resource and TileMap nodes: 2021-05-07 18:06:17 +02:00
editor_zoom_widget.h Rework the TileSet resource and TileMap nodes: 2021-05-07 18:06:17 +02:00
export_template_manager.cpp Core: Move DirAccess and FileAccess to core/io 2021-06-11 14:52:39 +02:00
export_template_manager.h Improve the UI/UX of the Export Template Manager dialog 2021-06-03 22:15:15 +03:00
filesystem_dock.cpp Merge pull request #48746 from KoBeWi/bane_of_all_virtual_compatibility 2021-06-12 23:00:40 +02:00
filesystem_dock.h Core: Move DirAccess and FileAccess to core/io 2021-06-11 14:52:39 +02:00
find_in_files.cpp Core: Move DirAccess and FileAccess to core/io 2021-06-11 14:52:39 +02:00
find_in_files.h Update copyright statements to 2021 2021-01-01 20:19:21 +01:00
groups_editor.cpp Improve TreeItem API and allow to move nodes 2021-05-17 22:06:46 +02:00
groups_editor.h Update copyright statements to 2021 2021-01-01 20:19:21 +01:00
import_defaults_editor.cpp Fix heap-use-after-free in Import Defaults Editor 2021-02-25 11:50:10 -03:00
import_defaults_editor.h Fix heap-use-after-free in Import Defaults Editor 2021-02-25 11:50:10 -03:00
import_dock.cpp Check section existance before getting keys 2021-03-26 10:05:25 +08:00
import_dock.h Improved 3D Scene Importer 2021-03-22 12:16:40 -03:00
inspector_dock.cpp Make several actions in the Inspector dock more obvious 2021-06-04 02:05:27 +03:00
inspector_dock.h Make several actions in the Inspector dock more obvious 2021-06-04 02:05:27 +03:00
localization_editor.cpp ICU: Update to version 69.1, improve ICU data export process. 2021-04-22 16:56:53 +03:00
localization_editor.h ICU: Update to version 69.1, improve ICU data export process. 2021-04-22 16:56:53 +03:00
multi_node_edit.cpp Update copyright statements to 2021 2021-01-01 20:19:21 +01:00
multi_node_edit.h Rename Reference to RefCounted 2021-06-11 18:48:42 +02:00
node_3d_editor_gizmos.cpp Consistently prefix bound virtual methods with _ 2021-06-12 00:55:52 +02:00
node_3d_editor_gizmos.h Rename GI Classes 2021-06-05 09:28:56 -03:00
node_dock.cpp Update copyright statements to 2021 2021-01-01 20:19:21 +01:00
node_dock.h Update copyright statements to 2021 2021-01-01 20:19:21 +01:00
plugin_config_dialog.cpp Core: Move DirAccess and FileAccess to core/io 2021-06-11 14:52:39 +02:00
plugin_config_dialog.h Fix enabling of created plugin 2021-03-06 15:33:52 +02:00
pot_generator.cpp Remove uses of auto for better readability and online code reviews 2021-04-26 14:59:28 +02:00
pot_generator.h Core: Move DirAccess and FileAccess to core/io 2021-06-11 14:52:39 +02:00
progress_dialog.cpp Update copyright statements to 2021 2021-01-01 20:19:21 +01:00
progress_dialog.h Update copyright statements to 2021 2021-01-01 20:19:21 +01:00
project_export.cpp Consistently prefix bound virtual methods with _ 2021-06-12 00:55:52 +02:00
project_export.h Core: Move DirAccess and FileAccess to core/io 2021-06-11 14:52:39 +02:00
project_manager.cpp Merge pull request #48597 from Calinou/editor-scale-auto-portrait 2021-06-15 18:27:48 +02:00
project_manager.h Make it possible to copy the Godot version identifier by clicking it 2021-04-28 17:35:57 +02:00
project_settings_editor.cpp Improve Project Settings Editor 2021-05-14 13:58:43 +03:00
project_settings_editor.h Improve Project Settings Editor 2021-05-14 13:58:43 +03:00
property_editor.cpp Fix property editor to make changes if popup closed (remake) 2021-06-05 19:31:54 +03:00
property_editor.h Rename Reference to RefCounted 2021-06-11 18:48:42 +02:00
property_selector.cpp Adding some more missing renames for Transform3D and Quaternion 2021-06-15 16:01:50 +02:00
property_selector.h Update copyright statements to 2021 2021-01-01 20:19:21 +01:00
quick_open.cpp Improve TreeItem API and allow to move nodes 2021-05-17 22:06:46 +02:00
quick_open.h Update copyright statements to 2021 2021-01-01 20:19:21 +01:00
register_exporters.h Update copyright statements to 2021 2021-01-01 20:19:21 +01:00
rename_dialog.cpp Rename LineEdit caret_* properties getters and setters to match property 2021-04-17 12:41:23 +01:00
rename_dialog.h Update copyright statements to 2021 2021-01-01 20:19:21 +01:00
reparent_dialog.cpp Update copyright statements to 2021 2021-01-01 20:19:21 +01:00
reparent_dialog.h Update copyright statements to 2021 2021-01-01 20:19:21 +01:00
scene_tree_dock.cpp Revert "Fix SceneTreeDock::_selection_changed to handle to single selection from Multiple Selection" 2021-06-16 02:12:01 +02:00
scene_tree_dock.h Implement Particle Trails 2021-04-30 17:38:02 -03:00
scene_tree_editor.cpp Consistently prefix bound virtual methods with _ 2021-06-12 00:55:52 +02:00
scene_tree_editor.h Implement Particle Trails 2021-04-30 17:38:02 -03:00
script_create_dialog.cpp Core: Move DirAccess and FileAccess to core/io 2021-06-11 14:52:39 +02:00
script_create_dialog.h Warn when creating a script with the same name as the parent class 2021-04-06 22:43:00 -04:00
SCsub SCons: Refactor running commands through builders 2020-07-28 00:09:21 +03:00
settings_config_dialog.cpp EditorSettings: Look for binding while filtering too 2021-06-04 01:31:55 +02:00
settings_config_dialog.h Added Built-in Action editor to Editor Settings dialog. 2021-02-19 19:36:42 +10:00
shader_globals_editor.cpp Rename Variant TRANSFORM to TRANSFORM3D 2021-06-03 07:30:01 -04:00
shader_globals_editor.h Update copyright statements to 2021 2021-01-01 20:19:21 +01:00