godot/core
Joel Croteau f44d6a235f Fix reload of GDExtension libraries in framework package on macos
`GDExtension::open_library` has a check in it to see if the library was loaded
from a temp file, and if it was to restore the original name as that is the one
we actually care about. This check is breaking extension reloading on Mac when
the library path is to a framework folder, as the file inside the framework
will not generally be the same name as the folder.

This check also shouldn't be necessary even on Windows, which is the only
platform that uses `generate_temp_files`, since disposal of the created temp
file is handled within `OS_Windows::open_dynamic_library`, and
`GDExtension::open_library` (which is the only function to call
`open_dynamic_library` with a `p_data` argument) only cares about the original
library file path and has to do extra work to remove the name of the temp file.
Instead, I have removed that check and set `OS_Windows::open_dynamic_library`
to return the name of the original file and not the name of the copy.

This fixes GDExtension reloading on macOS. I do not have a Windows machine
available to test that it still works properly on Windows, so someone should
check that before merging this.
2024-08-08 08:31:49 -06:00
..
config Replace .NET detection code with ClassDB::class_exists("CSharpScript"). 2024-07-23 23:46:14 +03:00
crypto [Crypto] Expose TLSOptions getters 2024-06-14 22:33:10 +02:00
debugger Fix Game window stops responding when debugger pauses 2024-07-10 13:38:57 -07:00
error Fix GLTF exporting invalid meshes and attempting to export gizmo meshes 2024-02-04 02:58:29 -06:00
extension Fix reload of GDExtension libraries in framework package on macos 2024-08-08 08:31:49 -06:00
input Merge pull request #94413 from rburing/fix_action_press_tick 2024-07-17 11:44:31 +02:00
io [ResourceLoader] Add check to prevent double free crashes. 2024-08-06 08:31:03 +03:00
math Add a check to prevent user to call AStarGrid2D::update when its not needed 2024-07-06 14:59:38 +03:00
object Fix global class cache file not present when no class name 2024-07-31 16:57:25 -04:00
os Fix Game window stops responding when debugger pauses 2024-07-10 13:38:57 -07:00
string Remove editor pseudolocalization debug feature 2024-06-24 17:08:26 +02:00
templates Fixup recent changes to threading concerns 2024-07-16 11:03:02 +02:00
variant [Core] Fix Variant::construct of Object 2024-07-25 12:25:29 +02:00
core_bind.cpp [Crypto] Expose OS.get_entropy 2024-06-17 12:02:37 +02:00
core_bind.h [Crypto] Expose OS.get_entropy 2024-06-17 12:02:37 +02:00
core_builders.py Update pre-commit hooks configuration to use ruff instead of black 2024-05-21 18:02:29 -05:00
core_constants.cpp Add PackedVector4Array Variant type 2024-05-03 00:58:27 +02:00
core_constants.h Add const lvalue ref to container parameters 2024-01-05 14:49:57 -03:00
core_globals.cpp One Copyright Update to rule them all 2023-01-05 13:25:55 +01:00
core_globals.h One Copyright Update to rule them all 2023-01-05 13:25:55 +01:00
core_string_names.cpp Cleanup unused/underused singleton StringNames 2024-05-14 18:18:29 +02:00
core_string_names.h Cleanup unused/underused singleton StringNames 2024-05-14 18:18:29 +02:00
doc_data.cpp Reduce and prevent unnecessary random-access to List 2024-05-04 16:08:55 +02:00
doc_data.h Documentation: Add support for deprecated/experimental messages 2024-02-15 15:59:50 +03:00
register_core_types.cpp fixed cleanup order in unregister_core_types() 2024-06-18 00:44:01 -07:00
register_core_types.h One Copyright Update to rule them all 2023-01-05 13:25:55 +01:00
SCsub SCons: Fix mono dependency 2024-06-01 16:37:54 -05:00
typedefs.h Core: Replace _NO_DISCARD_ macro with attribute 2024-04-12 16:40:01 -05:00
version.h Display the build date in the editor and when starting the engine 2024-02-27 20:39:17 +01:00