Markus Sauermann
79727d4833
Prohibit execution of delayed input events by different means
...
In some cases it can happen, that the order of input events and
window events is not followed, when input buffering or input accumulation
is active.
The display server order `InputEvent` => window-event gets changed to
window-event => `InputEvent` which becomes problematic in certain
situations.
This PR makes sure, that the order is adhered to by flushing input events
before a window event is sent.
Previously this problem was mitigated by discarding these delayed events.
But this solution was problematic in the setting of android input events.
(cherry picked from commit 945babc619
)
2024-04-29 10:23:25 +02:00
Fabio Alessandrelli
5958c8fa22
[MP] Fix dead code doing unnecessary allocation
...
Probably a leftover from some old refactor.
(cherry picked from commit e64aa4d25f
)
2024-04-08 15:48:31 +02:00
风青山
261129496c
Fix duplicating sub-scene may get two copies of internal node
...
Previously, internal node might be mistaken for `hidden_root` and be duplicated again.
Exclude those internal nodes to avoid this case, unless the owner is set intentionally.
(cherry picked from commit f19c419126
)
2024-03-11 22:34:53 +01:00
Markus Sauermann
17e50c629c
Fix owner when importing meshes
...
Handle the case correctly, that a child of a replaced node has
as owner an ancestor of the replaced node.
(cherry picked from commit c58607c32f
)
2024-03-11 15:00:43 +01:00
kobewi
3d4c2fa7da
Fix inefficient list iteration in Node
...
(cherry picked from commit 75ba837612
)
2024-03-11 15:00:43 +01:00
Markus Sauermann
b254088b7a
Fix global position for `InputEventMouse` in `viewport::push_input`
...
Global position doesn't get adjusted within `InputEventMouse::xformed_by()`.
(cherry picked from commit 8de39911c8
)
2024-03-11 15:00:43 +01:00
A Thousand Ships
c17688fa6c
Fix running tests in template builds
...
Also fixes some errors with 3D disabled
2024-02-27 16:03:18 +01:00
Micky
a92a2015f0
Fix missing autocompletion for inheriting classes
...
(cherry picked from commit ca2f340384
)
2024-01-25 18:45:01 +01:00
Markus Sauermann
6f6a1dc5e9
Fix D&D viewport position calculation
...
It is necessary to transform screen position to viewport position.
(cherry picked from commit 4b6516c843
)
2024-01-25 18:08:46 +01:00
Gilles Roudière
032d96042d
Fixes global transform being wrong on entering tree
...
(cherry picked from commit 0a726d692a
)
2024-01-25 17:19:42 +01:00
Markus Sauermann
ba23081eb7
Fix crash caused by stale owner
...
Adjust `NOTIFICATION_PREDELETE` in `Node` to clean up owned nodes.
Also print a warning, when the owner becomes invalid.
(cherry picked from commit d3d00c7039
)
2024-01-25 17:03:57 +01:00
kit
29811357a3
fix crash on hiding grandparent on mouse exit
...
(cherry picked from commit 78e1702adb
)
2024-01-25 17:03:56 +01:00
bruvzg
d29aaedd78
Limit window size updates on title translation change.
...
(cherry picked from commit f9c42d9fff
)
2023-12-07 10:27:09 +01:00
Yuri Sizov
511b4f822a
Make sure `Window`'s title is respected before we compute the size
...
Also removes some suspicious and outdated code that forced this particular
dialog to change size when the warning message changed.
(cherry picked from commit d9677be0ca
)
2023-12-07 10:27:08 +01:00
bruvzg
1fcf635383
Limit window size updates on title change.
...
(cherry picked from commit 5dd11e8eee
)
2023-12-07 10:27:05 +01:00
Markus Sauermann
ab7b662353
Fix SubViewport physics picking for 4.2
...
Apply the logic of `handle_input_locally` for physics picking.
2023-12-03 23:35:17 +01:00
bruvzg
bf19ced15d
Fix crash on late mouse enter/exit event arrival.
2023-11-27 08:47:43 +02:00
Markus Sauermann
3de9afc4a9
Fix crash when hiding a Control during mouse-entering
...
gui.mouse_over can be set to `nullptr` in the `NOTIFICATION_MOUSE_ENTER`-
user-callback a few lines above. This case was previously not handled.
2023-11-23 23:25:00 +01:00
Pedro J. Estébanez
8bebabda18
Let scene replacemnent benefit from certain late pieces of frame logic
2023-11-21 18:32:49 +01:00
Mikael Hermansson
a98b94758b
Revert "Fix transform notification not getting sent out for RigidBody2D"
2023-11-14 22:17:26 +01:00
Mikael Hermansson
9fb0b52608
Fix transform notification not getting sent out for RigidBody2D
2023-11-13 15:44:32 +01:00
Rémi Verschelde
15b8185c68
Don't use TTR/RTR for ERR/WARN prints
...
We don't translate those, only editor strings are translated.
2023-11-12 12:00:55 +01:00
kit
d24d73ba31
Make mouse-enter/exit notifications match mouse event propagation
...
`NOTIFICATION_MOUSE_ENTER` and `NOTIFICATION_MOUSE_EXIT` now includes
the areas of children control nodes if the mouse filters allow it.
In order to check if a Control node itself was entered/exited, the newly
introduced `NOTIFICATION_MOUSE_ENTER_SELF` and
`NOTIFICATION_MOUSE_EXIT_SELF` can be used.
Co-authored-by: Markus Sauermann <6299227+Sauermann@users.noreply.github.com>
2023-11-09 09:11:59 -05:00
Yuri Sizov
623b905d2e
Remove unused `NOTIFICATION_NODE_RECACHE_REQUESTED` notification
2023-11-06 12:16:32 +01:00
clayjohn
f672198f5e
Revert "Add a Disable 2D property to Viewport"
...
This reverts commit f6cc2603a1
.
2023-10-27 14:45:59 +02:00
Gilles Roudière
73f72409f5
Allow normal maps on TileMaps that use texture padding
2023-10-18 14:55:44 +02:00
Rémi Verschelde
7c088f246e
Merge pull request #82846 from SaracenOne/network_authority_instance_placeholders
...
Copy network authority when instancing placeholders
2023-10-16 10:38:34 +02:00
Rémi Verschelde
9e02dcd44c
Merge pull request #82100 from bitsawer/fix_shader_globals_override
...
Fix ShaderGlobalsOverride property handling
2023-10-11 22:50:08 +02:00
Rémi Verschelde
a1d7c62df7
Merge pull request #83003 from AThousandShips/null_check_extra
...
Replace `ERR_FAIL_COND` with `ERR_FAIL_NULL` where applicable
2023-10-09 15:37:14 +02:00
Rémi Verschelde
336260b7b3
Merge pull request #83002 from AThousandShips/safety_check
...
Replace `sanity` with `safety` for checks
2023-10-09 15:36:49 +02:00
A Thousand Ships
f18aa00e85
Replace `ERR_FAIL_COND` with `ERR_FAIL_NULL` where applicable
2023-10-08 17:23:33 +02:00
A Thousand Ships
034c0f1624
Replace `sanity` with `safety` for checks
2023-10-08 16:22:24 +02:00
Hugo Locurcio
f6cc2603a1
Add a Disable 2D property to Viewport
...
This is the 2D counterpart to the existing Disable 3D property.
Its functionality is already internally implemented and used,
but it wasn't exposed.
2023-10-07 17:19:15 +02:00
Rémi Verschelde
3b70e30e9b
Merge pull request #77072 from vPumpking/get-tree-string
...
Add `Node.get_tree_string` and `Node.get_tree_string_pretty`
2023-10-05 16:32:12 +02:00
Saracen
e1803e27d0
Copy network authority when instancing placeholder nodes.
2023-10-05 12:58:17 +01:00
Rémi Verschelde
3a990e36e6
Merge pull request #80752 from bitsawer/fix_thread_guard
...
Fix CanvasItem notification thread guard
2023-10-03 17:13:08 +02:00
bruvzg
72e2e47059
[DisplayServer] Add method to estimate window title bar size.
2023-10-03 16:13:52 +03:00
bitsawer
12a2177967
Fix notification thread guards
2023-10-02 19:31:54 +03:00
Rémi Verschelde
1e819ae3aa
Merge pull request #82590 from YuriSizov/window-you-come-to-me-on-this-day-the-day-when-my-child-becomes-exclusive-with-a-transient-parent-to-ask-for-this
...
Add more context to some `Window` errors
2023-10-02 13:16:39 +02:00
Rémi Verschelde
e95b7e84a4
Merge pull request #80844 from dalexeev/fix-callable-expected-argc
...
Fix expected argument count for `Callable` call errors
2023-10-02 13:15:53 +02:00
Yuri Sizov
53172d9860
Add more context to some `Window` errors
2023-09-30 21:44:05 +02:00
bruvzg
c52db6190c
[FileDialog] Make set_visible compatible with native dialogs.
2023-09-30 00:40:49 +03:00
Danil Alexeev
aff767ef07
Fix expected argument count for `Callable` call errors
2023-09-29 20:00:10 +03:00
Michael Alexsander
9ee82ebe1d
Fix tooltips behaving incorrectly on `Tree` nodes
2023-09-28 11:18:15 -03:00
Hugo Locurcio
fcbf7011cc
Make 3D editor gizmos and debug shapes ignore fog
...
This makes them easier to see in their intended colors in scenes with fog.
2023-09-27 00:54:57 +02:00
Marcel Admiraal
3a7eda8f87
Check if input marked handled before processing additional CollisionObjects
2023-09-26 20:42:15 +02:00
Rémi Verschelde
008b08b5fb
Merge pull request #82358 from jsjtxietian/fix-can-not-set-process-priority-of-node-in-editor
...
Fix can not set process priority of node in certain cases
2023-09-26 13:45:36 +02:00
jsjtxietian
e36117f557
Fix can not set process priority of node if not any process is processing
2023-09-26 19:29:25 +08:00
Rémi Verschelde
79805262f1
Merge pull request #77829 from AThousandShips/mp_fix
...
Disallow nested custom multiplayers in `SceneTree`
2023-09-26 08:17:02 +02:00
Rémi Verschelde
e4cfd4e26a
Merge pull request #82195 from AThousandShips/radian_fix
...
Replace `radians` range hint with `radians_as_degrees`
2023-09-25 17:18:38 +02:00