Commit Graph

289 Commits

Author SHA1 Message Date
Arsh Panesar 26cc13705a
Fix `AnimationPlayer` crash when it's made the scene root
When an AnimationPlayer is made root of a scene,
the track links may become broken and clicking on
them will crash.

Current master branch also breaks node links when
AnimationPlayer is made scene root, and can also
crash the engine if another node was made scene
root prior to the AnimationPlayer.

This happens because when made root, the editor
loses track of AnimPlayer's root node. By keeping
a copy of the AnimPlayer's root_node, the track
links remain functional.

Fixes #91043.

(cherry picked from commit e905be8249)
2024-09-17 08:57:43 +02:00
A Thousand Ships 4fe0d0ee86
[Editor] Fix `AnimationTrackEditor::timeline_changed` signal
Signal was declared with two arguments, emitted with both two and three
2024-08-13 15:09:53 +02:00
Rémi Verschelde 29a0e51b87
Merge pull request #95400 from AThousandShips/anim_signal_fix
[Editor] Fix missing bind for animation editor callback
2024-08-12 22:42:08 +02:00
Silc Lizard (Tokage) Renew 81399ae9ba Prevent to seek doubly on AnimationPlayerEditor 2024-08-13 00:49:53 +09:00
A Thousand Ships 7eed651f38
[Editor] Fix missing bind for animation editor callback
`timeline_changed` signal was connected to a method with three arguments
but provides two.
2024-08-11 19:07:39 +02:00
Rémi Verschelde 307efbadf8
Merge pull request #94420 from TokageItLab/player-seek-internal
Handle internal seek on AnimationPlayer to process discrete correctly
2024-07-23 13:08:05 +02:00
Silc Lizard (Tokage) Renew 98dbd869c5 Handle internal seek on AnimationPlayer to process discrete correctly 2024-07-16 14:49:25 +09:00
Silc Lizard (Tokage) Renew b326a35747 Reset position to 0 after animation selected on AnimationPlayerEditor 2024-07-13 14:27:01 +09:00
Silc Lizard (Tokage) Renew fae712d968 Fix broken sync between animation TrackEditor and PlayerEditor 2024-07-06 04:45:15 +09:00
A Thousand Ships fbb879debd
[Scene] Add `SceneStringNames::text/value_changed` 2024-06-19 09:44:38 +02:00
A Thousand Ships ca18a06ecb
[Scene] Add `SceneStringNames::confirmed` 2024-06-19 09:40:54 +02:00
A Thousand Ships d9e2fc74c7
[Scene] Add `SceneStringNames::item_selected` 2024-06-19 09:39:05 +02:00
Silc Lizard (Tokage) Renew bea47d877b Fix seeking Animation immediate after playback for Discrete track 2024-06-08 22:09:37 +09:00
Rémi Verschelde 9c87e8c7b4
Merge pull request #91953 from AThousandShips/use_normal_sname
Use `CoreStringNames::normal` in more places
2024-05-31 14:16:05 +02:00
A Thousand Ships cade5b88d9
Use `CoreStringNames::normal` in more places 2024-05-30 22:57:54 +02:00
A Thousand Ships 926afccbd8
[Scene] Add `SceneStringNames::panel` 2024-05-30 22:54:50 +02:00
A Thousand Ships 755a0efbb6
[Scene] Add `SceneStringNames::id_pressed` 2024-05-30 22:54:04 +02:00
Rémi Verschelde a8cc65f54f
Merge pull request #92495 from matheusmdx/fix-animation-player-error
Fix error after create a new animation in an empty AnimationPlayer
2024-05-29 22:14:03 +02:00
Rémi Verschelde 6c7ca019d7
Merge pull request #92473 from passivestar/animation-disabled-controls
Fix animation player controls being enabled when no player is selected
2024-05-29 11:20:08 +02:00
passivestar 2eaeee59d4 Fix animation player controls being enabled when no player is selected 2024-05-29 13:02:31 +04:00
matheusmdx 18cdb3c0d7 Fix error after create a new animation in an empty AnimationPlayer 2024-05-28 19:14:00 -03:00
A Thousand Ships 4ed62665a2
Replace `.bind(...).call_deferred()` with `.call_deferred(...)` 2024-05-27 13:29:57 +02:00
A Thousand Ships ee79386f7b
[Scene] Add SceneStringNames::pressed 2024-05-14 15:51:28 +02:00
kobewi 413c11357d Use Core/Scene stringnames consistently 2024-05-13 23:41:07 +02:00
kobewi a262d2d881 Add shorthand for using singleton string names 2024-05-11 18:53:08 +02:00
A Thousand Ships 955d5affa8
Reduce and prevent unnecessary random-access to `List`
Random-access access to `List` when iterating is `O(n^2)` (`O(n)` when
accessing a single element)

* Removed subscript operator, in favor of a more explicit `get`
* Added conversion from `Iterator` to `ConstIterator`
* Remade existing operations into other solutions when applicable
2024-05-04 16:08:55 +02:00
Lyuma bb9674c1b1 Set animation step from importers. Increase default step from 10 to 30 FPS. 2024-04-19 03:02:20 -07:00
Rémi Verschelde 2a0fcc4c7b
Merge pull request #88926 from samsface/fix_animation_player_error_dialog
Fix animation player error dialog focus
2024-04-13 11:30:18 +02:00
sam 943aeb4573 fix animation error player error focus 2024-04-12 22:36:30 +01:00
Rémi Verschelde 05372773e1
Merge pull request #89599 from timothyqiu/vegetate
Fix unexpected auto translation of editor `Tree` content
2024-03-23 21:15:39 -07:00
azuloo 5c6ca5fc09 Fix AnimationPlayer pin behavior 2024-03-21 08:42:33 +02:00
Haoyu Qiu 8cd1ebbd6d Fix unexpected auto translation of Tree content 2024-03-18 09:31:00 +08:00
Hugo Locurcio 8221e7546b
Add editor shortcuts to toggle bottom panel visibility
Default shortcuts use the first or second letter of each word.

This also adds a new shortcut to toggle the last opened bottom panel.
On editor startup, this defaults to the first panel in the list
(which is the Output panel).
2024-03-05 15:53:15 +01:00
Rémi Verschelde 4582ee1a0f
Merge pull request #87760 from kitbdev/extract-bottom-dock
Extract BottomPanel from EditorNode
2024-02-23 22:18:50 +01:00
Saracen 98d9c9c573
Make AnimationPlayerEditor read-only edit rules more permissive. 2024-02-21 15:17:56 +01:00
kit eb6ca91ba6 Extract BottomPanel from EditorNode 2024-02-20 15:09:07 -05:00
Rémi Verschelde 9e9dcdbba4
Merge pull request #86378 from RobProductions/update-hover-styling
Add hover highlight to main editor buttons
2024-02-20 19:34:40 +01:00
kobewi a031911c82 Use check_changed_settings_in_group() everywhere 2024-02-19 21:34:45 +01:00
Silc Lizard (Tokage) Renew 772a753960 Fix some animation state corruptions on activate and reset on save 2024-02-19 13:04:22 +09:00
A Thousand Ships dde5368dee
[Editor] Add missing ellipses to menu options that open dialogs 2024-02-17 17:09:17 +01:00
Matt Enad 5b5de0e167 Add hover highlight to main editor buttons
Updates styling of the editor run bar, plugin, bottom panel, icon buttons, and main menu buttons for accessibility.
2024-02-16 14:49:44 -05:00
Michael Alexsander 7b42c24550
Make auto translation inheritable 2024-02-15 16:51:19 -03:00
Yuri Sizov 95b27fe8c7 Reorganize code related to editor theming
This change introduces a new EditorThemeManager class
to abstract theme generatio and its subroutines.

Logic related to EditorTheme, EditorColorMap, and editor
icons has been extracted into their respective files with
includes cleaned up.

All related files have been moved to a separate folder to
better scope them in the project. This includes relevant
generated files as well.
2024-01-16 11:57:45 +01:00
kobewi 0e8f90f4c8 Update deferred calls to use Callables 2024-01-09 16:11:47 +01:00
Silc Lizard (Tokage) Renew 21833f3dfd Fix seeking bug in AnimationPlayerEditor 2023-11-22 06:43:26 +09:00
Rémi Verschelde 3e23755d24
Merge pull request #83430 from RandomShaper/fix_onion_audio
Fix onion skinning internals activating audio/method/animation tracks
2023-11-12 16:56:30 +01:00
Yuri Sizov 60355889f8 Avoid popping up dialogs excessively in the Animation editor 2023-10-31 11:54:02 +01:00
Saracen d9950e2370 Fix AnimationTimeline time not updating when dragged. 2023-10-30 01:59:54 +00:00
Pedro J. Estébanez 5671e47d20 Fix onion skinning internals activating audio/method/animation tracks 2023-10-16 11:47:14 +02:00
Michael Alexsander 2102d09812
Disable "Edit Transitions..." item if no animations are present 2023-10-15 12:28:04 -03:00