clang-format does not play well with tab-aligned multiline statements...
Some more research will be needed if we want to set a column limit.
(cherry picked from commit e2a3f06f3d)
clang-format does not handle that well *at all*.
For the reference, found the relevant pieces of code with:
`ag "=[ "$'\t'"]?"$'\n'"[ "$'\t'"]?{" --ignore=thirdparty`
(cherry picked from commit 40323407df)
During runtime godot calls chdir() several times. This doesn't really
matter normally but when using tools such as gprof the location of the
profiling data is kind of hard to intuit.
With this PR we simply store the current working directory at start and
restore it once we're almost done exiting.
This doesn't use the OS abstractions as when we need to get the current
workdir we haven't yet initialized it (by necessity). This would break
if we tried to build X11 for windows, but since the X11 target is
hardcoded to use the UNIX abstractions I don't think it matters.
(cherry picked from commit d0c2015fe1)
In preload() parsing this code will lookup the identifier in the local
constant database. If the identifier corresponds to a string constant
it is used as the path for preload().
Currently this does not work for global constants, only constants
declared in the same class as the preload is happening. We can implement
a full fix too. Maybe we can use this PR to discuss the possibilities.
This (partially) fixes#6798
(cherry picked from commit 3e5743ca36)
The code would get a pointer to the beginning of the call_args by using
operator[] at the stack Vector. This does bound checking. When there are
no call_args this bound check fails and the error mentioned in #7796
gets triggered.
This bound check is actually not necessary as call_args just gets set to
NULL and never dereferenced. This new code will just unconditionally set
the pointer to the place where the call_args are if there are any. There
is no NULL check for call_args anywhere so this is safe.
Fixes#7796
(cherry picked from commit e8611966de)
Add initialization for OS_OSX.mouse_mode in OS_OSX::OS_OSX(). mouse_mode now defaults to OS::MOUSE_MODE_VISIBLE.
(cherry picked from commit 6921e11805)
Now the selection jumps to the correct action after a new event has been added.
Also sets the default device id for Joypad button events to 0.
(cherry picked from commit 92ac7067e6)
debug_release doesn't turn off optimizations for release target now. Ensure that sanitizer options apply to both C and C++ files.
Built-in optimization/debug flags are prepended such that user-specified flags can override them.
Based on and around the discussion in PR #5194.
(cherry picked from commit 7a85d25218)
Rémi Verschelde
Ramesh Mani Maran
volzhs
Shlomi Fish
Andreas Haas
Bojidar Marinov
Ignacio Etcheverry
Hein-Pieter van Braam
Vincent
Brett-Mitchell
Saracen
m4nu3lf
kbake
marcelofg55
Chris Bradfield
Ferenc Arn
Ray Koopa
Geequlim
Fabio Alessandrelli
Jerome67000
Jesper Bækdahl
Pedro J. Estébanez