Commit Graph

4447 Commits

Author SHA1 Message Date
Rémi Verschelde
315c64282b
Fix misc formatting issues
Somehow I missed the failing CI report from trailing whitespace.

Fixed a couple typos found by codespell while at it, and misc
trailing semicolons in one of the files.
2022-11-14 19:00:48 +01:00
Rémi Verschelde
7dafe06e27
Merge pull request #68624 from AleCamara/bug-67235-gradient-slider
Fix clicking in gradient editor
2022-11-14 18:29:52 +01:00
Fabio Alessandrelli
d568b25e36 [Editor] Better expose EditorDebuggerPlugin.
Now splitted into two classes:
- EditorDebuggerPlugin (RefCounted).
- EditorDebuggerSession (abstract).

This allows the EditorPlugin to be in control of the debugger plugin
lifecycle, be notified when sessions are created, and customize each of
them independently.

We should slowly transition the various profilers and captures in
ScriptEditorDebugger to their own plugins, and decouple
ScriptEditorDebugger from it's UI part (making it the "real"
EditorDebuggerSession potentially dropping the wrappers).
2022-11-14 14:55:22 +01:00
Ale Camara
aebf3d9401 Fix clicking in gradient editor
- When double-clicking on the gradient we should open the colour picker and create a colour key.
- Instead, we were also evaluating the click further down producing the colour key to move around.
2022-11-14 13:29:21 +00:00
trollodel
ba9e619b51 Use forward-declarations in EditorPlugin where possible 2022-11-11 20:25:51 +01:00
Rémi Verschelde
b61fda9d2a
Merge pull request #68271 from paddy-exe/gdextension-library-loading-error
GDExtension: Improve error message for invalid library feature flags
2022-11-07 17:44:43 +01:00
Rémi Verschelde
2c8498c8a6
Merge pull request #68351 from Sauermann/fix-code-simplifications
Code simplifications
2022-11-07 10:01:37 +01:00
Rémi Verschelde
19d8e36c8e
Merge pull request #68331 from MewPurPur/gradient2d-better-preview
Fix GradientTexture2D's preview
2022-11-07 08:46:25 +01:00
Markus Sauermann
18978881fe Code simplifications
CanvasItemEditor:
- p_result == ADD_MOVE is always true in this switch-clause

- both parts of the if-else-clause do the same thing and simplified an affine_inverse call

ControlEditorToolbar:
- private function ControlEditorToolbar::_anchor_to_position is used nowhere. Looks like
copy and paste from CanvasItemEditor::_anchor_to_position

ScrollContainer:
- screen_is_touchscreen is always true, because otherwise the function already returned

TextLine:
- both parts of the if-else-clause do the same thing and simplified return statement
2022-11-07 01:21:25 +01:00
VolTer
3de53c8312 Fix jankiness when drawing GradientTexture2D 2022-11-06 22:14:54 +01:00
Rémi Verschelde
12b4a263ee
Merge pull request #67730 from KoBeWi/late_to_the_call
Add call_deferred() method to Callable
2022-11-06 15:55:43 +01:00
Rémi Verschelde
5dfa56474a
Merge pull request #68247 from akien-mga/emscripten-warnings-unuset-but-set
Fix -Wunused-but-set-variable warnings from Emscripten 3.1.20
2022-11-06 15:53:46 +01:00
Patrick
f9458f9228 Improve error message for invalid library feature flags
Fixes https://github.com/godotengine/godot/issues/63227

My version for the error message is:
`No suitable library found. The libraries' tags referred to an invalid feature flag. Possible feature flags for your platform: %s`
2022-11-04 21:45:40 +01:00
clayjohn
3c1e5003ab Fix pathological corner case in drawing tileset editor
Interleaving draw_rect calls with and without a texture forces every rect to
have its own draw call. In this case it meant that there is a draw call for every single
tile in the atlas. This change makes it so the renderer can batch draw calls
which reduced the draw call count by a factor of 512
2022-11-04 13:04:20 -07:00
kobewi
1778301cd0 Add call_deferred() method to Callable 2022-11-04 17:24:34 +01:00
Rémi Verschelde
f475c91081
Fix -Wunused-but-set-variable warnings from Emscripten 3.1.20 2022-11-04 11:36:13 +01:00
Ninni Pipping
4b29f71685 Fix incorrect drawing of alternative tiles 2022-11-03 16:17:36 +01:00
Zae
b68b26b27e Fix reload scripts error after saving in external editor. 2022-11-03 17:06:51 +08:00
Rémi Verschelde
9ec7aadc06
Merge pull request #66017 from Mickeon/rename-image-copy-rect
Rename Image's `get_rect` to `get_region`
2022-11-02 22:36:57 +01:00
Rémi Verschelde
f7c611ab71
Style: Misc docs and comment style and language fixes
- Removed empty paragraphs in XML.
- Consistently use bold style for "Example:", on a new line.
- Fix usage of `[code]` when hyperlinks could be used (`[member]`, `[constant]`).
- Fix invalid usage of backticks for inline code in BBCode.
- Fix some American/British English spelling inconsistencies.
- Other minor fixes spotted along the way, including typo fixes with codespell.
- Don't specify `@GlobalScope` for `enum` and `constant`.
2022-11-02 19:01:18 +01:00
kobewi
15831e381b Unify usage of undo_redo in editor 2022-11-02 17:51:58 +01:00
Rémi Verschelde
910cf9a9b3
Merge pull request #67810 from MrBlockers/reged-fixes
Fix multiple issues with region editor
2022-11-02 14:18:12 +01:00
Rémi Verschelde
a8850434c2
Merge pull request #68147 from anvilfolk/fix-curve-multiline
Fix error in curve editor multiline string draw
2022-11-02 14:17:18 +01:00
Rémi Verschelde
50f742e1ca
Merge pull request #68107 from alfredbaudisch/drag-lower-case
Cast dragged file name extension to lowercase
2022-11-02 14:16:00 +01:00
Rémi Verschelde
df26d11b5d
Merge pull request #68020 from timothyqiu/3d-drag-instance
Improve dragging scene into 3D viewport
2022-11-02 14:15:54 +01:00
ocean (they/them)
8871226e5c Fix error in curve editor multiline string draw 2022-11-01 22:28:03 -04:00
Micky
ebf86c96e9 Rename Image's get_rect to get_region
Also renames its parameter to from "rect" to "region".
2022-11-01 23:35:48 +01:00
Alfred Reinold Baudisch
07e367cb0b Cast dragged file extension name to lowercase, closes #68104 2022-11-01 09:48:09 +01:00
Haoyu Qiu
2b8bcbe487 Fix error when adding 3D gizmo handles with IDs 2022-11-01 16:25:13 +08:00
Rémi Verschelde
e22a1d8031
Merge pull request #68060 from dpalais/no-pointer-animationnode-blendtree-rename
Remove the usage of pointers in signal call, to fix #67941
2022-10-31 15:54:45 +01:00
Rémi Verschelde
e47aa546cd
Merge pull request #68008 from timothyqiu/hide-axis
Hide axis gizmo after translating 3D nodes
2022-10-31 14:19:11 +01:00
Rémi Verschelde
2af7a2367a
Merge pull request #68005 from timothyqiu/type-mismatch
Fix type mismatch error when deselecting a 3D gizmo
2022-10-31 14:19:06 +01:00
Rémi Verschelde
6a9317c9fc
Merge pull request #42659 from kingoftheconnors/anim-tree-load-fail-alert
Add alert in anim trees if resource load fails
2022-10-31 13:18:10 +01:00
Rémi Verschelde
5947f22be9
Merge pull request #67578 from KoBeWi/GEDITOR
Unify usage of GLOBAL/EDITOR_GET
2022-10-31 13:15:58 +01:00
Rémi Verschelde
4b92533efa
Merge pull request #68073 from timothyqiu/marker-3d-extents
Make Marker3D gizmo resizable
2022-10-31 12:17:13 +01:00
Rémi Verschelde
be126d42d4
Merge pull request #67588 from KoBeWi/if(!GDVIRTUAL_CALL)don't
Simplify GDVIRTUAL_CALL calls
2022-10-31 11:55:56 +01:00
Rémi Verschelde
33c7c8020a
Merge pull request #67489 from timothyqiu/auto-select-all
Allow selecting SpinBox & LineEdit text when focus enters
2022-10-31 11:55:06 +01:00
Rémi Verschelde
49c53027a9
Merge pull request #67786 from EricEzaM/67743-script-editor-shortcuts
Set the shortcut context for the edit/search/goto menus to the ScriptEditor so that shortcuts continue to work when FindReplaceBar is focused.
2022-10-31 11:07:48 +01:00
Rémi Verschelde
869c2bd6de
Merge pull request #68064 from kleonc/sprite-frames-editor-fix-frame-index-calculation
`SpriteFramesEditor` Fix calculating frame index from mouse position
2022-10-31 11:00:19 +01:00
Rémi Verschelde
4845feb95d
Merge pull request #68003 from timothyqiu/camera-gizmo-select
Make Camera3D gizmo clickable
2022-10-31 10:56:39 +01:00
Rémi Verschelde
420eb1aa34
Merge pull request #67445 from Zylann/rename_queue_delete
Rename queue_delete => queue_free
2022-10-31 10:51:18 +01:00
Rémi Verschelde
d0fbeec66a
Merge pull request #67580 from KoBeWi/little_things
Minor code improvements
2022-10-31 10:34:57 +01:00
Haoyu Qiu
3ded27c62d Make Marker3D gizmo resizable 2022-10-31 15:19:48 +08:00
kleonc
d135957987 SpriteFramesEditor Fix calculating frame index from mouse position 2022-10-30 21:26:58 +01:00
Dave Palais
3d0a9b2bec Remove the usage of pointers in signal call, to fix #67941
The signal was emitted right as the node was being disposed of. Since
the connection was deferred, the receiving method received an already
freed pointer. Instead, we listen to the text_changed signal and keep
record of the edited text which we then use to update node name when
the LineEdit goes out of focus.
2022-10-30 12:50:27 -05:00
Haoyu Qiu
877cb1cbc0 Improve dragging scene into 3D viewport
* When there's nothing to collide with:
    * Place the new scene on XZ plane when possible.
    * When the camera does not point toward the XZ plane or the
      intersection is too far away, place the new scene on a plane that
      is in front of the camera and parallel to the frame.
* Fixes positioning when in orthogonal view.
    * Place on physical collision point or the XZ plane when possible.
    * Otherwise, place it on the plane in front of the camera as if the
      camera was perspective.
* Makes use of snap settings when placing the new scene.
2022-10-29 23:34:39 +08:00
Haoyu Qiu
03bbacfdca Hide axis gizmo after translating 3D nodes 2022-10-29 16:17:28 +08:00
Haoyu Qiu
eb5bfe158e Fix type mismatch error when deselecting a 3D gizmo 2022-10-29 15:15:28 +08:00
Haoyu Qiu
ca9063fe4e Make Camera3D gizmo clickable 2022-10-29 12:38:21 +08:00
Haoyu Qiu
3aed3edc06 Allow selecting SpinBox & LineEdit text when focus enters 2022-10-29 09:58:42 +08:00