49f4860ce3
Style: Mark clang-format 16 as supported for pre-commit hook
...
It only introduced a difference in a .glsl file, which I've worked
around by removing an empty line. This keeps formatting consistent
between clang-format 15 and 16.
Also added a change in the 3-to-4 project converter to fix bogus
formatting in clang-format < 17.
2023-12-06 13:26:53 +01:00
51dcb38840
GLES3: Skip batches with zero instance count while rendering
2023-12-05 18:49:59 +09:00
749f60ee36
OpenGL: Implement rendering of lightmaps
2023-12-04 18:34:06 -06:00
caddce14dd
Add 3D MSAA and scaling support to GLES3
2023-12-05 10:01:00 +11:00
74e49b7271
Merge pull request #85092 from clayjohn/GL-vertex-input-mask
...
Use vertex input mask for creating vertex arrays
2023-12-04 23:10:26 +01:00
a9ba8695d4
Merge pull request #84852 from Alex2782/fix_vulkan_buffer_android
...
Vulkan: Fix incorrect access to the buffers on Android
2023-12-04 23:06:04 +01:00
6f16e3f257
Merge pull request #84416 from jsjtxietian/shadow_disabled
...
Add `shadows_disabled` macro in Compatibility renderer
2023-12-04 23:03:10 +01:00
6f4da7a976
Merge pull request #83736 from darksylinc/matias-broken_buffer_update
...
Fix buffer updates going to the wrong cmd buffer if barriers were 0
2023-12-04 22:58:24 +01:00
1749ea8d00
Merge pull request #82804 from BlueCube3310/compat_correct_normals
...
Automatically ensure correct normals in Compatibility renderer
2023-12-04 22:57:59 +01:00
bae6f86257
Add wireframe for compatibility mode
2023-12-02 13:09:56 -05:00
72bf8dfecf
Remove superfluous locking in RID owners in Vulkan RD
2023-12-01 16:12:21 +01:00
4964d9a083
Remove redundant explicit clears in the Vulkan RD
2023-12-01 16:11:59 +01:00
bd74d92ef7
Merge pull request #84957 from BastiaanOlij/fix_msaa2d_when_no_2d
...
Ensure 2D MSAA resolve is performed when 3D content but no 2D content in scene
2023-11-22 21:56:23 +01:00
c0c1efc5da
Use vertex input mask for creating vertex arrays
...
Also fix bug in creation of vertex input mask
2023-11-19 16:32:55 +01:00
47983e30c5
Ensure 2D MSAA resolve is performed when 3D content but no 2D content in scene
2023-11-16 13:34:34 +11:00
0198eedb06
Remove incorrect system_fbo overwrite
2023-11-16 01:56:20 +01:00
04a142cf71
Vulkan: Fix incorrect access to the buffers on Android
2023-11-15 14:46:25 +01:00
ead36fdcc4
Store ArrayMesh path in RenderingServer for use in error messages
2023-11-14 16:27:10 +01:00
787e98e955
Merge pull request #84752 from akien-mga/gles3-shaderdata-initialize
...
GLES3: Ensure all ShaderData is properly initialized in `set_code`
2023-11-13 12:20:33 +01:00
ef2cc1cc2b
Merge pull request #84741 from lawnjelly/bogus_shader_log
...
[GLES3] Protect against bogus `glGetShaderInfoLog` return values.
2023-11-12 12:15:31 +01:00
ba713c80df
Fix various typos with codespell
...
Using 2.2.7.dev51+geb4a58fe.
2023-11-11 23:01:24 +01:00
0e04203293
GLES3: Ensure all ShaderData is properly initialized in set_code
...
Fixes #84418 .
2023-11-11 15:13:23 +01:00
593cdf00ff
[GLES3] Protect against bogus `glGetShaderInfoLog` return values.
...
On some buggy drivers `GL_INFO_LOG_LENGTH` returns incorrect values, which may lead to incorrectly filling in the log string. This could lead to uninitialized data being attempted to be printed and a crash.
This PR zeros the array to ensure uninitialized data is not used.
2023-11-11 06:56:46 +00:00
e69968b794
Only copy the relevant portion of the screen when copying to backbuffer in Compatibility backend
2023-11-11 00:17:26 +01:00
9c5adac342
Properly rename INSTANCE_ID and VERTEX_ID in canvas item shaders in the compatibility backend
2023-11-07 17:55:51 +01:00
716fd3edfc
Add shadows_disabled macro in Compatibility renderer
2023-11-07 18:55:26 +08:00
52da1e9b6b
Fix NetBSD Executable Path
2023-11-06 06:33:36 -08:00
95b8a75aaf
Merge pull request #84288 from bruvzg/angle_detect_2
...
[macOS] Improve ANGLE support detection.
2023-11-02 09:11:55 +01:00
44a54f4500
Merge pull request #84252 from clayjohn/ensure_tangents
...
Enhance checks and user experience around tangent arrays in meshes.
2023-11-02 09:11:32 +01:00
d1043a5f93
Enhance checks and user experience around tangents.
...
Ensure `ensure_tangents` option actually creates tangent array. Even if it is just a dummy array.
Allow mesh to generate its own tangents when using compression. This allows users to compress meshes without tangents.
Warn users if they are trying to read from tangents without providing tangents.
2023-11-01 22:40:42 +01:00
4c74c7d11a
[macOS] Improve ANGLE support detection.
...
Try opening EGL display when checking if ANGLE is supported.
2023-11-01 08:34:35 +02:00
67d8102f95
Fix WebXR on desktop emulator by reseting active texture unit
2023-10-31 16:18:38 -05:00
a039d0b61a
Linux: Disable RTLD_DEEPBIND mode for dlopen() in sanitizer builds
2023-10-30 16:16:08 -05:00
dcbee437f7
Merge pull request #84197 from bruvzg/opengl_utf8
...
Parse OpenGL and Vulkan strings as UTF-8.
2023-10-30 17:47:51 +01:00
25dc729dd4
Parse OpenGL and Vulkan strings as UTF-8.
2023-10-30 17:24:31 +02:00
acbc341a58
OpenGL: Fix uninitialized memory usage for GPUPartciles `interp_to_end`
...
Fixes #84072 .
2023-10-30 15:08:24 +01:00
6ed1731746
Use platform-specific methods for FileAccess reading and writing
2023-10-29 17:34:18 +01:00
c5c90fd7b7
Merge pull request #83998 from chybby/83380-soft-shadows
...
Fix reading shadow filter quality from project settings in compatibility
2023-10-26 16:02:08 +02:00
2dafd06114
Merge pull request #83906 from clayjohn/GL-vertex-padding
...
Add padding to normal attribute in Compatibility renderer to match the RD renderers
2023-10-26 16:00:56 +02:00
253711ec98
Merge pull request #82430 from RandomShaper/fix_gles3_tex_free
...
[GLES3] Avoid freeing proxy textures clearing onwer's data
2023-10-26 15:58:55 +02:00
b9446dde7e
Fix reading shadow filter quality from project settings in compatibility
...
Fixes #83380 .
2023-10-26 23:57:42 +11:00
46cb7f94f7
Merge pull request #83988 from bruvzg/egl_static
...
Fix macOS and Windows build with statically linked ANGLE/EGL.
2023-10-26 12:10:56 +02:00
815b24d280
Merge pull request #83491 from jsjtxietian/pass-screen-size-when-render-shadow
...
Pass viewport size to shadow pass instead of using Vector2i(1,1)
2023-10-26 12:09:21 +02:00
2d0cd5f2cd
Fix macOS and Windows build with statically linked ANGLE/EGL.
2023-10-26 12:15:59 +03:00
26d32554bd
Pass viewport size to shadow pass instead of using vector2i(1,1)
2023-10-26 15:25:22 +08:00
1b3e00dc29
Merge pull request #83930 from underdoeg/feature-support-egl-1-4
...
Add support for EGL 1.4
2023-10-26 08:58:46 +02:00
249aed43bf
add support for EGL 1.4
2023-10-25 12:08:48 +02:00
f021d33940
Merge pull request #81167 from bitsawer/fix_sdfgi_editor_change
...
Reset SDFGI when changing editor scene tabs
2023-10-25 10:27:03 +02:00
a88e519f18
Add padding to normal attribute in Compatibility renderer to match the RD renderers
2023-10-24 22:32:34 +02:00
261fe7ce6a
Merge pull request #83704 from clayjohn/misc-mesh-fixes
...
Some more fixes for compressed meshes
2023-10-24 10:54:23 +02:00
64f80295e5
Merge pull request #83199 from Repiteo/texture-storage-default-scale
...
Fix `TextureStorage` not assigning default scale
2023-10-24 10:53:56 +02:00
8f9cd4e1e3
Some more fixes for compressed meshes
...
This cleans up a few more cases of uint32_t->uint64_t
Importantly this fixes an edge case in the axis-angle compression by
using the pre-existing Basis methods instead
2023-10-24 09:38:12 +02:00
50d17f6b8c
Merge pull request #83613 from clayjohn/surface_upgrade_tool
...
Add an editor tool to automatically upgrade and re-save meshes
2023-10-24 00:10:37 +02:00
318ef8461f
Implementation of tool to automatically upgrade and re-save meshes
2023-10-23 22:39:48 +02:00
814de86494
Merge pull request #83493 from clayjohn/light-pair-bug
...
Ensure that only visible paired lights are used
2023-10-23 12:40:07 +02:00
f31371c04e
Automatically ensure correct normals in Compatibility renderer
2023-10-22 15:00:11 +02:00
58775a6c67
Fix `GPUParticles3D` on the Meta Quest 2 with OpenGL renderer
2023-10-21 16:49:24 -05:00
c9ec1f7727
Fix buffer updates going to the wrong cmd buffer if barriers were 0
...
From what I could see only SSAO & SSIL were affected when they both
call:
int zero[1] = { 0 };
RD::get_singleton()->buffer_update(ssao.importance_map_load_counter, 0,
sizeof(uint32_t), &zero, 0);
int zero[1] = { 0 };
RD::get_singleton()->buffer_update(ssil.importance_map_load_counter, 0,
sizeof(uint32_t), &zero, 0);
Also documented what setup_command_buffer & draw_command_buffer are for.
2023-10-21 13:14:38 -03:00
7e598642d2
Bump version of Vulkan RD binary shader format
2023-10-18 17:45:10 +02:00
623a050269
Ensure that only visible paired lights are used
...
This is a longstanding issue in both the Mobile and GL Compatibility renderer.
Meshes pair with all lights that touch them, and then at draw time, we send all paired lights indices to the shader (even if that light isn't visible). The problem is that non-visible lights aren't uploaded to the GPU and don't have an index. So we end up using a bogus index
2023-10-17 13:02:46 +02:00
348c1ff96b
Merge pull request #83266 from bruvzg/linux_case_check
...
[Linux] Implement DirAccess.is_case_sensitive for EXT4 and F2FS.
2023-10-13 22:19:24 +02:00
a19f05604e
Merge pull request #83252 from mrjustaguy/opengl-fade-fix
...
Fix OpenGL Directional Shadow Last Split Fading
2023-10-13 22:18:13 +02:00
54eae6221a
[Linux] Implement DirAccess.is_case_sensitive for EXT4 and F2FS.
2023-10-13 15:48:03 +03:00
51f81e1c88
Merge pull request #82957 from bruvzg/fs_case_check
...
Add method to check if filesystem is case sensitive.
2023-10-13 12:55:35 +02:00
09a2a7c54e
Remove PSSM Fade
2023-10-13 12:01:23 +02:00
9ee41c707e
Fix texture storage not assigning default scale
...
• Print errors if an invalid value is passed
2023-10-12 12:02:24 -05:00
b1371806ad
Merge pull request #82431 from bitsawer/fix_gpuparticles_free
...
Fix errors when freeing GPUParticles
2023-10-12 00:22:33 +02:00
775ab4e983
Merge pull request #83141 from BastiaanOlij/fix_shadow_size
...
Fix compatibility shadow size not being initialised
2023-10-11 18:30:55 +02:00
59cd86f89d
Fix compatibility shadow size not being initialised
2023-10-11 22:02:38 +11:00
4b7cc99bc1
Merge pull request #79169 from reduz/debug-canvas-item-redraw
...
Debug CanvasItem redraw
2023-10-11 08:40:05 +02:00
55282ddc10
Merge pull request #79527 from QbieShay/qbe/particles-rework
...
Particle internal refactor and additions for more artistic control
2023-10-10 22:48:50 +02:00
c228fe1a0d
Particle internal refactor and additions for more artistic control
...
Co-authored-by: Hugo Locurcio <hugo.locurcio@hugo.pro>
Co-authored-by: A Thousand Ships <96648715+AThousandShips@users.noreply.github.com>
Co-authored-by: Raul Santos <raulsntos@gmail.com>
Co-authored-by: Mew Pur Pur <85438892+MewPurPur@users.noreply.github.com>
Co-authored-by: Clay John <claynjohn@gmail.com>
2023-10-10 20:03:35 +02:00
49495293c7
Merge pull request #82973 from dsnopek/gdextension-linux-favor-local-symbols
...
On Linux, favor local symbols when loading a shared library
2023-10-10 12:33:06 +02:00
a28dab7e82
Merge pull request #79711 from adamscott/web-non-blocking-main-thread
...
Add `proxy_to_pthread` option to `platform=web`
2023-10-09 23:22:22 +02:00
78c2a08fae
Add `proxy_to_pthread` option to `platform=web`
...
Co-authored-by: Fabio Alessandrelli <fabio.alessandrelli@gmail.com>
2023-10-09 11:50:01 -04:00
a1d7c62df7
Merge pull request #83003 from AThousandShips/null_check_extra
...
Replace `ERR_FAIL_COND` with `ERR_FAIL_NULL` where applicable
2023-10-09 15:37:14 +02:00
97bcd8a631
Add method to check if filesystem is case sensitive.
2023-10-09 11:00:15 +03:00
f18aa00e85
Replace `ERR_FAIL_COND` with `ERR_FAIL_NULL` where applicable
2023-10-08 17:23:33 +02:00
034c0f1624
Replace `sanity` with `safety` for checks
2023-10-08 16:22:24 +02:00
7f4e700bf7
On Linux, favor local symbols when loading a shared library
2023-10-07 11:06:56 -05:00
c05f521e16
Merge pull request #82892 from clayjohn/tangent-binormal-transform
...
Only perform modelview transform on tangent and binormal when vertex shader is in local space
2023-10-06 12:53:05 +02:00
af1d81d95a
Only perform modelview transform on tangent and binormal when vertex shader is in local space
2023-10-05 22:08:36 -06:00
04846c1d6d
Avoid default fallback material when using world_vertex_coords
...
This avoids z-fighting between the opaque shader and the depth prepass shader
2023-10-05 19:11:48 -06:00
68926d5919
Merge pull request #81827 from darksylinc/matias-vkfeatures-opt-in
...
Opt-in to Vulkan features we actually use.
2023-10-05 22:49:21 +02:00
51ed3aef63
Vertex and attribute compression to reduce the size of the vertex format.
...
This allows Godot to automatically compress meshes to save a lot of bandwidth.
In general, this requires no interaction from the user and should result in
no noticable quality loss.
This scheme is not backwards compatible, so we have provided an upgrade
mechanism, and a mesh versioning mechanism.
Existing meshes can still be used as a result, but users can get a
performance boost by reimporting assets.
2023-10-05 12:02:23 -06:00
b42aa5ad9d
Merge pull request #81575 from bitsawer/fix_gles_instancing
...
Fix GLES3 instanced rendering color and custom data defaults
2023-10-05 10:06:39 +02:00
146d87c230
Merge pull request #82679 from lyuma/workaround_xr_off_crash
...
Workaround crash due to null shader when running XR project with `--xr-mode` off
2023-10-04 15:36:22 +02:00
1d34033143
Workaround crash due to null shader when running XR project with --xr-mode off
2023-10-02 06:12:01 -07:00
e9b2af91cf
check_c_headers from tuple array to dictionary
2023-10-01 14:09:39 -05:00
6f88ed73be
Fix GLES3 instanced rendering color and custom data defaults
2023-09-29 11:44:37 +03:00
7ae0fa1083
Merge pull request #77496 from clayjohn/GLES3-shadows
...
Implement 3D shadows in the GL Compatibility renderer
2023-09-28 20:03:53 +02:00
cb7200b028
Implement 3D shadows in the GL Compatibility renderer
2023-09-28 09:39:26 +02:00
d468582ef8
Fix build on MSVC 2017
2023-09-27 19:49:59 +03:00
898d1a2d5f
Fix errors when freeing GPUParticles
2023-09-27 11:46:31 +03:00
a67559931b
[GLES3] Avoid freeing proxy textures clearing onwer's data
2023-09-27 10:44:56 +02:00
517e9f8aef
[Modules] Replace `ERR_FAIL_COND` with `ERR_FAIL_NULL` where applicable
2023-09-26 16:44:52 +02:00
36945dad07
Merge pull request #82359 from bitsawer/add_gles3_device_cache_key
...
Add device info to GLES3 shader cache key hash
2023-09-26 16:36:57 +02:00
a4bca12336
Merge pull request #82304 from akien-mga/windows-remove-redundant-MSVC-define
...
Windows: Remove `MSVC` define redundant with `_MSC_VER`
2023-09-26 13:45:26 +02:00
48bee5c8ef
Merge pull request #82221 from Riteo/linux-ogl-no-vsync-override
...
Linux/OpenGL: Don't force vsync in the editor
2023-09-26 13:45:12 +02:00
f1062f25eb
Add device info to GLES3 shader cache key hash
2023-09-26 13:01:31 +03:00
814ab59c37
Windows: Remove `MSVC` define redundant with `_MSC_VER`
...
Cleanup unused MSVC code in FileAccessUnix.
2023-09-26 11:11:45 +02:00
057367bf4f
Add FidelityFX Super Resolution 2.2 (FSR 2.2.1) support.
...
Introduces support for FSR2 as a new upscaler option available from the project settings. Also introduces an specific render list for surfaces that require motion and the ability to derive motion vectors from depth buffer and camera motion.
2023-09-25 10:37:47 -03:00
d5f913ce1d
Opt-in to Vulkan features we actually use.
2023-09-24 21:05:48 -03:00
4fd6777cf4
Linux/OpenGL: don't force vsync in the editor
...
I couldn't tell whether this has an actual purpose and it feels more
like a debug remnant.
We also need to be able to disable vsync in the editor for the WIP
Wayland backend (in the EGL driver) as it does manual frame throttling.
2023-09-24 04:36:58 +02:00
b12ed82c04
Expose texture_create_from_extension to GDExtension
2023-09-23 16:57:12 -04:00
1887a9df19
[macOS/Windows] Add optional ANGLE backed OpenGL renderer support. Add EGL_ANDROID_blob_cache caching.
...
Co-authored-by: Riteo <riteo@posteo.net>
2023-09-21 14:21:00 +03:00
bda6fc5d2f
Polish a few things in Vulkan RD
2023-09-19 18:10:46 +02:00
9a1b4f338b
Merge pull request #81160 from paddy-exe/canvas-uv-world-space
...
Add render mode to use world coordinates in canvas item shader
2023-09-19 09:03:18 +02:00
cfeccc2146
Fix validation error when using pipeline cache control
...
PR #80296 introduced a regression because it checks if the
VK_EXT_pipeline_creation_cache_control extension has been enabled before
using it, but turns out the process is a bit more convoluted than that
(a Vulkan driver may support the extension but then say the feature is
not supported)
2023-09-16 18:59:04 -03:00
48e1c19dea
Merge pull request #81583 from AThousandShips/null_check_drivers_platform
...
[Drivers,Platform] Replace `ERR_FAIL_COND` with `ERR_FAIL_NULL` where applicable
2023-09-15 19:48:18 +02:00
af7b870e2a
Improve GLES3 scene renderer compatibility with older devices
2023-09-14 16:34:29 +03:00
3565d1bf7e
[Drivers,Platform] Replace `ERR_FAIL_COND` with `ERR_FAIL_NULL` where applicable
2023-09-12 20:13:32 +02:00
3815b2f98e
Merge pull request #81315 from conorlawton/z-billboard-y-velocity-no-scale
...
Fix z-billboard + y to velocity transform alignment to correctly respect non-uniform scale
2023-09-08 23:14:27 +02:00
9ecafcc491
Fixed z-billboard-y-velocity to correctly respect non-uniform scale instead of averaging scale
2023-09-08 20:01:57 +01:00
cfd292939c
Haiku: Remove remnants of past WIP platform port
...
The Haiku platform port was never finalized, and moved to a separate repo in
Godot 3.2 days: https://github.com/godotengine/godot-platform-haiku
Sadly it didn't garner more interest there and is bitrotting. It was never
ported to Godot 4 so the bits of Haiku support left in Mono aren't useful.
2023-09-07 16:37:51 +02:00
8de6405288
UWP: Remove platform port, needs to be redone from scratch for 4.x
...
The UWP platform port was never ported to the Godot 4.0+ API,
and it's now accumulating bitrot as it doesn't compile, and thus
we no longer propagate platform changes in it.
So we finally remove to acknowledge this state. There's still some
interest in reviving the UWP port eventually, especially as support
for Direct3D 12 will soon be merged, but when that happens it will
be easiest to redo it from scratch.
2023-09-07 15:01:59 +02:00
8f3042ed46
Merge pull request #81395 from jsjtxietian/fix-clear-color-alpha-value-affect-2d-editor-in-compatibility
...
Fix clear color's alpha value will affects 2D editor in Compatibility mode
2023-09-07 13:54:10 +02:00
e21a485dbc
Fix clear color's alpha value will affects 2D editor in Compatibility mode
...
When the rt's transparency is false, force the alpha of the clear color to one
2023-09-07 12:56:34 +08:00
45a33cc749
Implement render mode fog_disabled and BaseMaterial3D setting Disable Fog
2023-09-05 18:15:02 +02:00
497ca8c433
Merge pull request #80296 from RandomShaper/overhaul_vk_pso_cache
...
Enhance Vulkan PSO caching
2023-09-03 00:20:40 +02:00
836705d7a9
Reset SDFGI when changing editor scene tabs
2023-08-30 19:50:05 +03:00
c98ab5aba3
Add option to use world coordinates in canvas item shader
...
By using the render mode `world_vertex_coords` you can automatically use the vertex coordinates in world space
2023-08-30 15:32:18 +02:00
56b13b6865
Merge pull request #81001 from RandomShaper/win_safe_save
...
Make Windows' safe save more resilient
2023-08-30 12:16:06 +02:00
bcf33cfbd1
Enhance Vulkan PSO caching
2023-08-30 12:00:54 +02:00
9be010cde4
Merge pull request #81059 from darksylinc/matias-vk-barrier-early_fragment_depth
...
Fix missing `EARLY_FRAGMENT_TESTS_BIT` barrier flags
2023-08-29 12:45:56 +02:00
fd7b27a473
Merge pull request #80909 from adamscott/web-fix-max-uniform-buffer-size-overflow
...
Fix integer value for `GL_MAX_UNIFORM_BLOCK_SIZE` overflowing
2023-08-28 15:03:50 +02:00
407b16ab00
Debug CanvasItem redraw
...
I wanted to add this tool for years and always forget. This command line option:
```
$ godot.exe -e --debug-canvas-item-redraw
```
Allows to see when a canvas item is redrawn. This helps find out if something
in the UI is refreshing in a way it should not. Examples as such:
* Signals causing more of the UI to redraw.
* Container resizing causes more UI elements to redraw.
* Something using a timer is redrawing all time time, which can go unnoticed.
To my surprise, the editor UI is redrawing very efficiently. There is some
weird stuff with the scene tabs, redrawing when the inspector changes but most
things for the most part are fine.
2023-08-28 12:53:56 +02:00
677d2d6fb0
Fix missing EARLY_FRAGMENT_TESTS_BIT barrier flags
2023-08-27 19:38:34 -03:00
d48b95a305
fix glMapBufferRange return null when r_index + last_item_index > max_instances
2023-08-27 18:00:35 +08:00
49177b6eeb
Make Windows' safe save more resilient
2023-08-25 18:28:35 +02:00
9c7db7397f
Fix integer value for GL_MAX_UNIFORM_BLOCK_SIZE overflowing
2023-08-25 10:19:25 -04:00
fef62a6860
Merge pull request #80781 from bitsawer/fix_vulkan_texture_upload
...
Fix Vulkan texture update
2023-08-21 19:32:12 +02:00
6cb28e481f
Fix memory access error for `MultiMesh` with GLES3
...
Buffer was incorrectly assigned when invalid data was provided
2023-08-19 16:01:21 +02:00
3daa19dd95
Fix Vulkan texture update
2023-08-19 12:18:54 +03:00
1537452aa9
Merge pull request #78013 from Calinou/cli-add-audio-output-latency-argument
...
Add a `--audio-output-latency` command-line argument
2023-08-17 15:43:14 +02:00
ce57c2379c
Abort on startup with a visible alert if required Vulkan features are missing
2023-08-17 14:48:36 +02:00
6f1152bdbe
Add a `--audio-output-latency` command-line argument
...
This allows optimizing the audio output latency on higher-end CPUs,
especially in projects that do not expose a way to override this setting.
2023-08-17 14:45:17 +02:00
c1dbc3dd04
Merge pull request #80288 from pkpro/memcpy_into_nullptr
...
Vulkan: Fix sanitizers error with empty shader name
2023-08-17 12:29:29 +02:00
5541567c1a
Merge pull request #80151 from WhalesState/Dev1
...
Fix GLES3 changing 2D shadow atlas size is broken
2023-08-17 11:23:24 +02:00
2987dd0c71
fix GLES3 changing 2d shadow atlas size is broken
2023-08-16 15:58:23 +00:00
9d9043a9c8
Merge pull request #80654 from bitsawer/fix_global_uniform_texture_set
...
Fix global shader uniform texture loading
2023-08-16 09:17:25 +02:00
d1b8e9abd6
Merge pull request #80571 from darksylinc/matias-resize-window-fix
...
Fix validation error when resizing window
2023-08-16 09:13:53 +02:00
04c2bc5a37
Merge pull request #80424 from DarioSamo/rd-buffer-copy-vulkan
...
Add `buffer_copy` method to RenderingDevice
2023-08-16 09:13:06 +02:00
0b09fdd96c
Fix validation error when resizing window
...
Sometimes when resizing the window we may get the following validation
error:
ERROR: VALIDATION - Message Id Number: -370888023 | Message Id Name:
VUID-vkAcquireNextImageKHR-semaphore-01286
Validation Error: [ VUID-vkAcquireNextImageKHR-semaphore-01286 ]
Object 0: handle = 0xdcc8fd0000000012, type = VK_OBJECT_TYPE_SEMAPHORE;
| MessageID = 0xe9e4b2a9 | vkAcquireNextImageKHR: Semaphore must not be
currently signaled or in a wait state. The Vulkan spec states: If
semaphore is not VK_NULL_HANDLE it must be unsignaled
(https://vulkan.lunarg.com/doc/view/1.2.198.1/linux/1.2-extensions/vkspec.html#VUID-vkAcquireNextImageKHR-semaphore-01286 )
In VulkanContext::prepare_buffers the problem was that
vkAcquireNextImageKHR returned VK_SUBOPTIMAL_KHR but it already signaled
the semaphore (because it is possible to continue normally with a
VK_SUBOPTIMAL_KHR result).
Then we recreate the swapchain and reuse the
w->image_acquired_semaphores[frame_index] which is in an inconsistent
state.
Fixed by recreating the semamphores along the swapchain.
Fix #80570
2023-08-15 20:57:49 -03:00
41def3740a
Fix global shader uniform texture loading
2023-08-15 14:18:26 +03:00
80a36ff985
Add support for GLSL source-level debugging with RenderDoc (`--generate-spirv-debug-info`)
2023-08-12 14:56:49 +02:00
0d7deca4e2
Add buffer_copy method to RenderingDevice interface and an implementation for the Vulkan driver.
...
Direct buffer copies are required to perform certain operations more efficiently, as the only current alternative is to download the buffer to the CPU and upload it again. As the first use case, the new function is used when enabling motion vectors on multimeshes.
2023-08-12 09:38:39 -03:00
77b02359c9
Vulkan: Fix sanitizers error with empty shader name
...
Co-authored-by: Rémi Verschelde <rverschelde@gmail.com>
2023-08-09 12:12:56 +02:00
8aa6f29b56
[FileAccess] Add methods to get/set "hidden" and "read-only" attributes on macOS/BSD and Windows.
2023-08-08 21:51:32 +03:00
1163dac9e3
Merge pull request #80215 from clayjohn/HDR-2D
...
Add option to enable HDR rendering in 2D
2023-08-08 16:57:33 +02:00
048a164083
Merge pull request #79693 from bruvzg/com_ath
...
[Windows] Initialize COM as apartment-threaded.
2023-08-07 14:48:40 +02:00
57eb762bae
Add option to enable HDR rendering in 2D
...
This is needed to allow 2D to fully make use of 3D effects (e.g. glow), and can be used to substantially improve quality of 2D rendering at the cost of performance
Additionally, the 2D rendering pipeline is done in linear space (we skip linear_to_srgb conversion in 3D tonemapping) so the entire Viewport can be kept linear.
This is necessary for proper HDR screen support in the future.
2023-08-07 11:24:03 +02:00
cc6a60913a
Merge pull request #78325 from akien-mga/libpng-moar-intrinsics
...
libpng: Enable intrinsics on x86/SSE2, ppc64/VSX, and all arm/NEON
2023-08-04 17:04:07 +02:00
2c9b7fc7a8
libpng: Enable intrinsics on x86/SSE2, ppc64/VSX, and all arm/NEON
2023-08-04 14:57:21 +02:00
9e844cc0c8
PulseAudio: Remove get_latency() caching
2023-08-04 15:35:13 +09:30
558f4b7559
Initialize shader placeholders up front
...
Then use the placeholder to create the shader instead of swapping RIDs
This fixes a false positive that reported leaked shaders
2023-08-03 16:13:33 +02:00
eda04c5658
Merge pull request #80071 from darksylinc/matias-fixes2
...
Fix validation layer warnings
2023-08-01 17:26:04 +02:00
bffbc5dd3e
Merge pull request #80070 from clayjohn/GLES3-depth-prepass
...
Enable depth writes during shadow pass and depth pass. Disable during color pass
2023-08-01 17:26:00 +02:00
1c40263665
Merge pull request #79606 from clayjohn/ShaderRD-compilation-groups
...
Shader rd compilation groups
2023-08-01 17:25:16 +02:00
8b12849fef
Merge pull request #79876 from LRFLEW/mobalpha
...
Fix transparent viewport backgrounds with custom clear color
2023-07-31 21:01:32 +02:00
4ce41495b1
Fix validation layer warnings
...
1. Validation layers on Windows were complaining w/
VUID-VkSwapchainCreateInfoKHR-surface-01270 that we were not calling
vkGetPhysicalDeviceSurfaceSupportKHR before vkCreateSwapchainKHR.
2. Godot was only calling vkGetPhysicalDeviceSurfaceSupportKHR at
startup, but it should be doing this for every window w/ a new surface
it wants to create, not just the first one.
- In practice this will likely not make a difference. If
vkGetPhysicalDeviceSurfaceSupportKHR returns false after initialization,
there's nothing we can do about it and it is likely because something
else went terribly wrong, which is why the error message is worded like
that.
- This is mostly to shut up validation layers. Though technically,
the layers are right.
3. Do not call vkGetPhysicalDeviceSurfaceSupportKHR on queues we don't
even plan on ever using. We don't know how drivers will react to that
(e.g. they may preemptetively allocate resources to support presentation
on exotic queues, instead of just saying no). Just behave like every
other Vulkan app out there.
2023-07-30 17:07:27 -03:00
b986afed46
Enable depth writes during shadow pass and depth pass. Disable during color pass
...
This fixes an unreported performance bug. Basically, without this change, the depth prepass did nothing
2023-07-30 21:59:28 +02:00
6effd3cde7
Fix transparent viewport backgrounds with custom clear color
2023-07-30 06:19:47 -05:00
472226422e
Fix uninitialized variable ending up sent to Vulkan
...
The first time a shader is compiled Godot performs the following:
```cpp
for (uint32_t i = 0; i < SHADER_STAGE_MAX; i++) {
if
(spirv_data.push_constant_stages_mask.has_flag((ShaderStage)(1 << i))) {
binary_data.push_constant_vk_stages_mask |=
shader_stage_masks[i];
}
}
```
However binary_data.push_constant_vk_stages_mask is never initialized to
0 and thus contains garbage data or'ed with the good data.
This value is used by push constants (and many other things) thus it can
be a big deal.
Fortunately because the relevant flags are always guaranteed to be set
(but not guaranteed to be unset), the damage is restricted to:
1. Performance (unnecessary flushing & over-excessive barriers)
2. Overwriting push descriptors already set (this would be serious,
doesn't seem to be an issue)
3. Driver implementations going crazy when they see bits set they don't
expect (unknown if this is an issue)
This uninitialized value is later saved into the binary cache.
Valgrind is able to detect this bug on the first run, but not on the
subsequent ones because they data comes from a file.
cache_file_version has been bumped to force rebuild of all cached
shaders. Because the ones generated so far are compromised.
2023-07-29 18:28:33 -03:00
1fe49e7271
Merge pull request #79142 from BastiaanOlij/register_render_buffers
...
Expose RenderSceneBuffers(RD) through ClassDB
2023-07-27 15:22:27 +02:00
d894a2ff57
Merge pull request #79883 from clayjohn/GLES3-shader-cache-dir
...
Check if shader cache directory is available before using cache
2023-07-26 18:40:35 +02:00
4874b96033
Expose RenderingSceneBuffers through ClassDB
2023-07-26 23:48:30 +10:00
63d6e9c557
Add custom texture create function
2023-07-26 20:46:34 +10:00
202e4b2c1e
Merge pull request #79884 from Dragoncraft89/master
...
Vulkan: Fix dangling pointers in `_clean_up_swap_chain`
2023-07-25 21:51:38 +02:00
7bb732cc38
Merge pull request #79866 from adamscott/fix-file-permissions-web
...
Fix file permissions for the web platform (affects every Unix-like platform)
2023-07-25 21:26:30 +02:00
3f2e901633
Merge pull request #79865 from clayjohn/discard-shader
...
Fix use of discard in shaders
2023-07-25 21:26:27 +02:00
08cffc128f
Merge pull request #79812 from ParsleighScumble/parsleigh/init-sky-scene-state
...
Use defaults to initialize sky data in case of no sky
2023-07-25 21:26:23 +02:00
7f7a2b2557
Fix dangling pointers in _clean_up_swap_chain
2023-07-25 14:41:57 +02:00
52fb5bf986
Check if shader cache directory is available before using cache
2023-07-25 14:33:37 +02:00
b6faccccd5
Fix file permissions for the web platform
2023-07-25 08:29:24 -04:00
7c812cd7e9
Fix use of discard in shaders
...
discard was being included in all shaders set to depth pass opaque, which is the majority of shaders
Instead it should only be used with alpha prepass materials
2023-07-24 23:21:04 +02:00
67c13fe4eb
Use defaults to initialize sky data in case of no sky
2023-07-24 10:41:13 -07:00
21524e26e0
Merge pull request #79849 from bitsawer/fix_particles_and_compute_threading
...
Fix Vulkan multithreaded compute list and GPU particle processing
2023-07-24 19:33:52 +02:00
b1f4e58bbf
Merge pull request #79772 from Malcolmnixon/gles-skeletons
...
Unbind the framebuffer when updating meshes
2023-07-24 19:33:27 +02:00
4ba24f6492
Merge pull request #79685 from LRFLEW/glinval
...
GLES3: Don't call `glTexParameter*` for invalid filter and repeat modes
2023-07-24 19:33:12 +02:00
3e9fadc1dd
Merge pull request #79660 from bitsawer/fix_opengl_multimesh
...
Fix GLES3 multimesh rendering when using colors or custom data
2023-07-24 19:33:05 +02:00
5d18e2ee00
Fix Vulkan multithreaded compute list and GPU particle processing
2023-07-24 12:56:55 +03:00
3e9173f11a
GLES3: Don't call glTexParameter* for invalid filter and repeat modes
2023-07-21 19:26:57 -05:00
679f5bf410
Unbind the framebuffer when updating meshes.
...
While the vertex shaders used to update the meshes aren't actually rendering to the framebuffer, they may still refuse to run with some framebuffers bound - such as XR with multiple views.
2023-07-21 19:34:12 -04:00
f932c1aba1
Merge pull request #79526 from Zylann/fix_rd_thread_safe
...
Fix missing `_THREAD_SAFE_METHOD_` missing from `RenderingDeviceVulkan` `submit` and `sync`
2023-07-21 17:54:39 +02:00
4acb8c66a1
Merge pull request #79568 from LRFLEW/glaniso
...
GLES3: Reset anisotropic filtering when changing texture filtering mode
2023-07-21 17:15:39 +02:00
e970f5249c
Add Shader compile groups to RD Shader system
...
This allows us to specify a subset of variants to compile at load time and conditionally other variants later.
This works seamlessly with shader caching.
Needed to ensure that users only pay the cost for variants they use
2023-07-21 16:42:30 +02:00
4bfb820d32
[Windows] Initialize COM as apartment-threaded.
2023-07-20 12:14:16 +03:00
9897f1cfb9
Fix GLES3 multimesh rendering when using colors or custom data
2023-07-20 11:54:34 +03:00
28001b9ef6
[Net] Explicitly handle buffer errors in send/recv
2023-07-19 10:08:25 +02:00
8722cbc0a0
Add missing thread-safe method macros to RD Vulkan submit and sync
2023-07-18 20:04:51 +01:00
90f0e97eb9
GLES3: reset anisotropic filtering when changing texture filtering mode
2023-07-17 00:18:39 -05:00
a22f495a3c
Split raster barrier into vertex and fragment barrier
2023-07-15 12:30:32 +10:00
7e21eb7e00
Extract and reorganize texture resource classes
2023-07-14 20:04:21 +02:00
bb15241e06
Merge pull request #77740 from ChibiDenDen/simplify_vulkan
...
Replace sampler arrays with constant sampler elements, simplify and reuse code for all shaders
2023-07-12 17:16:12 +02:00
a33b548092
Merge pull request #78168 from clayjohn/GLES3-gaussian-rt
...
Use Gaussian approximation for backbuffer mipmaps in GL Compatibility renderer
2023-07-12 15:08:57 +02:00
3cd865dbe8
Fix formatting of dlopen error message on Windows
...
And harmonize the format for all platforms.
Co-authored-by: Rémi Verschelde <rverschelde@gmail.com>
2023-07-09 23:39:45 +02:00
1453dc9d5d
Merge pull request #79143 from clayjohn/wayland-menu
...
Avoid freeze when interacting with menus on Wayland by re-aquiring next swapchain image after updating swapchain
2023-07-09 12:24:07 +02:00
43c0fa7f4b
Merge pull request #78797 from Calinou/remove-redundant-vformat
...
Remove uses of `vformat()` with no placeholders
2023-07-08 18:18:35 +02:00
98358b2822
Merge pull request #78794 from joemarshall/patch-1
...
Fix threading bug in Vulkan rendering device
2023-07-08 18:17:46 +02:00
df021b5063
Avoid freeze when interacting with menus on Wayland by re-aquiring next swapchain image after updating swapchain
2023-07-07 10:19:28 +02:00
c566b03f26
Merge pull request #78852 from clayjohn/Particles-glitch
...
Initialize particles instance buffer in case it is used before being updated
2023-07-07 08:28:28 +02:00
35ed7c770b
Initialize particles instance buffer in case it is used before being updated
2023-06-29 13:24:40 -07:00
dcc92c174e
Remove uses of `vformat()` with no placeholders
...
This is identical to passing the string directly.
2023-06-28 16:27:55 +02:00
c52fadbe75
fix threading bug in vulkan rendering device
2023-06-28 13:50:25 +01:00
7c37a32897
Use a filter with mipmaps when initializing textures with mipmaps in GL Compatibility renderer
...
This works around a driver bug in some older devices and should be harmless on any spec-compliant device
2023-06-26 10:45:24 -07:00
cc89321c9c
Reset filter/repeat state of textures in GL Compatibility renderer when render target is cleared
2023-06-23 10:57:56 -07:00
55fc56bfd4
Moved variables closer to usage to fix unused variable warning
2023-06-22 23:01:09 +02:00
cb73a6e9f9
Merge pull request #78490 from clayjohn/GLES3-particles-subemit
...
Add warnings and fallbacks for particles sub emitters when using the GL Compatibility rendering backend
2023-06-22 21:02:38 +02:00
df740f6865
free color and depth texture after check framebuffer complete failed
2023-06-22 09:13:24 +08:00
35715e510f
replace sampler arrays with constant sampler elements
2023-06-22 01:11:57 +03:00
8a5af8183a
Add warnings and fallbacks for particles sub emitters when using the GL Compatibility rendering backend
...
Co-authored-by: Hugo Locurcio <hugo.locurcio@hugo.pro>
2023-06-21 12:56:52 -07:00
dab0871d41
Fix invalid RID errors when freeing a mesh with blend shapes
2023-06-19 11:07:15 +03:00
131e49bf13
[Unix] Fix temporary file permissions.
2023-06-16 23:34:27 +03:00
c8e3f00e5d
GLES3: Remove unimplemented texture_create() declaration
2023-06-16 18:58:23 +08:00
7dddd8a22c
Merge pull request #78302 from clayjohn/GLES3-screen-warning
...
Remove outdated warning when using screen texture in GL Compatibility renderer
2023-06-16 10:23:27 +02:00
9e81aeda33
Merge pull request #78287 from clayjohn/GLES3-texture-replace
...
Copy texture filter/repeat modes when replacing a texture in the GL Compatibility backend
2023-06-16 10:23:03 +02:00
1710a7d303
Merge pull request #78285 from clayjohn/GLES3-viewport-filter
...
Ensure filter/repeat is cached by Viewport texture in GL Compatibility renderer
2023-06-16 10:22:33 +02:00
36a005fafc
Add RENDERING_INFO parameters to GL Compatibility renderer
...
This also fixes RENDERING_INFO_TOTAL_PRIMITIVES_IN_FRAME for the RD renderers as it was incorrectly reporting vertex/index count at times
This also adds memory tracking to textures and buffers to catch memory leaks.
This also cleans up some memory leaks that the new system caught.
2023-06-16 09:10:00 +02:00
8a7f02addb
Remove outdated warning when using screen texture in GL Compatibility renderer
2023-06-15 18:48:50 -07:00
96b2743782
Ensure filter/repeat is cached by Viewport texture in GL Compatibility renderer
2023-06-15 13:08:55 -07:00
3e211b7f74
Copy texture filter/repeat modes when replacing a texture in the GL Compatibility backend
2023-06-15 13:06:42 -07:00
bd786ce0d9
Fix for Win+M crashing the editor
...
Fixes #77790
Adds missing 'break' statement to 'VulkanContext::prepare_buffers' function.
It was mistakenly removed in #72859
2023-06-14 14:34:09 -03:00
e0651ed4b5
Merge pull request #78199 from clayjohn/detect_3d
...
Ensure that "detect 3D" is only called when using 3D shaders
2023-06-14 09:26:47 +02:00
6dd47e232b
Expose RD::texture_native_handle
2023-06-14 09:58:08 +10:00
0b7e2dfdfc
Ensure that "detect 3D" is only called when using 3D shaders
2023-06-13 13:20:11 -07:00
9721a27427
Use Gaussian approximation for backbuffer mipmaps in GL Compatibility renderer
2023-06-12 21:51:23 -07:00
9ce42d176d
Merge pull request #76977 from manueldun/light-shader-builtins
...
Enable the use of all supported builtins on the light shader
2023-06-09 11:04:46 +02:00
166643df32
Merge pull request #74937 from bitsawer/fix_uniform_storage
...
Fix shader uniform storage conversions and crash
2023-06-09 11:04:16 +02:00
e2321c21db
Enable the use of all builtins on the light shader
...
When using the light process in spatial shader,
the built-ins work as spected, now they work in forward+,
mobile and compatibility renderer.
2023-06-08 14:14:14 -04:00
9e4315bb50
Style: Harmonize header includes in platform ports
...
This applies our existing style guide, and adds a new rule to that style
guide for modular components such as platform ports and modules:
Includes from the platform port or module should be included with relative
paths (relative to the root folder of the modular component, e.g.
`platform/linuxbsd/`), in their own section before Godot's "core" includes.
The `api` and `export` subfolders also need to be handled as self-contained
(and thus use relative paths for their "local" includes) as they are all
compiled for each editor platform, without necessarily having the api/export
matching platform folder in the include path.
E.g. the Linux editor build will compile `platform/android/{api,export}/*.cpp`
and those need to use relative includes for it to work.
2023-06-08 15:19:19 +02:00
05142b6228
Properly update array textures when using the OpenGL backend to avoid crash
2023-06-07 15:44:11 -07:00
e75285f69f
Merge pull request #77946 from bruvzg/opengl_blend_cache
...
[OpenGL] Fix LCD blend mode color caching.
2023-06-07 11:02:30 +02:00
a2abea8b98
[OpenGL] Fix LCD blend mode color caching.
2023-06-07 10:55:38 +03:00
2c5e2196bd
Replace get_rendering_device() call to prevent crashes on OpenGL.
...
And make OpenGL video adapter info align with Vulkan.
2023-06-06 23:29:36 +02:00
3dd0307f3f
Merge pull request #76348 from warriormaster12/pipeline-cache
...
Implement Vulkan pipeline caching
2023-06-01 00:40:33 +02:00
dded713dc0
Implement Vulkan pipeline caching
2023-05-31 22:24:18 +03:00
23c375d6b4
Fix shader uniform storage conversions and crash
2023-05-29 15:17:13 +03:00
f2e91eae63
Merge pull request #77224 from patrickdown/implement_texture_2d_layered_initialize
...
Implemented texture_2D_layered_initialize
2023-05-29 10:29:08 +02:00
391a1bf60e
Implemented texture_2D_layered_initialize
2023-05-27 12:53:59 -05:00
f6dcd7f51a
Merge pull request #75181 from dalexeev/fix-light-only-mode
...
Fix "Light Only" mode of `CanvasItemMaterial`
2023-05-27 17:28:29 +02:00
6d3634e29f
fix gles texture uniform array binding
2023-05-26 23:11:02 +03:00
2ab0f17f3b
Merge pull request #77409 from allenwp/OpenGL3-Blend-Issue76334
...
Fixed issues with blend modes in OpenGL 3 renderer
2023-05-24 18:36:06 +02:00
51f0e36509
Fixed issues with blend modes in OpenGL 3 renderer
...
Added uses_blend_alpha = true for ADD, SUBTRACT, and MULTIPLY blend modes to match the other renderers
Fixes #76334
2023-05-24 10:35:23 -04:00
8b0530be64
Merge pull request #77022 from sakrel/fix_buffer_get_data
...
RenderingDeviceVulkan::buffer_get_data: Use draw command buffer instead of setup command buffer
2023-05-24 08:47:19 +02:00
852740a627
Merge pull request #76053 from MightiestGoat/fix-sky-auto-exposure
...
Fix the grainy sky while using debanding.
2023-05-24 08:46:28 +02:00
b917f748b5
Merge pull request #75945 from Calinou/renderingdevice-finalaction-fix-typo
...
Fix typo in FinalAction `switch` statement in RenderingDevice
2023-05-24 08:46:01 +02:00
05ddc822fb
Merge pull request #77265 from lyuma/aabb_bone_lod_inside
...
Fix calculation of skinned AABB for unused bones.
2023-05-22 13:49:19 +02:00
791d8001db
Fix AABB for unused bones
...
Fixes bug where bounding box of 1 unit was used in some skinned models and had wrong LODs.
(this could become very large if the mesh is scaled, such as FBX conversions)
Also fixes a mistake in calcualting bone index.
2023-05-19 19:47:52 -07:00
8a3e829930
(Re-)Implemented Light3D's property "shadow_reverse_cull_face"
...
The parameter shadow_reverse_cull_face is now passed to the shadow pass so that the mesh back-faces are used for shadow map calculation.
2023-05-19 19:22:10 +02:00
Rémi Verschelde
HolySkyMin
David Snopek
Bastiaan Olij
Dominic
Pedro J. Estébanez
clayjohn
Gabor Koncz
Alexander Hartmann
lawnjelly
jsjtxietian
Samuel Venable
bruvzg
BlueCube3310
Adam Chyb
Philip Whitfield
Rémi Verschelde
Matias N. Goldberg
mrjustaguy
Thaddeus Crews
QbieShay
Adam Scott
A Thousand Ships
Lyuma
bitsawer
Yuri Sizov
SlugFiller
Dario
Riteo
Shawn Wallace
Conor Lawton
Milan Gruner
Patrick
Juan Linietsky
Hugo Locurcio
Mounir Tohami
sakrel
Pavel Kraynyukhov
Luke Hubmayer-Werner
LRFLEW
Florian Kothmeier
Parsleigh Scumble
Malcolm Nixon
Fabio Alessandrelli
Marc Gilleron
Hendrik Brucker
Kamil Brzoskowski
Joe Marshall
Brecht Kuppens
Qiqi Wu
ChibiDenDen
jpcerrone
Manuel Dun
MJacred
warriormaster12
patrickdown
Yuri Sizov
Allen Pestaluky
Markus Grafen