godotengine/godot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
ea85ff0dc2
godot/modules
History
Ignacio Etcheverry ea85ff0dc2 Fix properties being lost when reloading placeholder GDScript instance 
During reloading in `GDScriptLanguage::reload_all_scripts` a placeholder instance that must remain so is replaced with a new placeholder instance. The state is then restored by calling `ScriptInstance::set` for each property. This does not work if the script is missing the properties due to build/parse failing.
The fix for such cases is to call `placeholder_set_fallback` instead of `set` on the script instance.

I took this chance to move the `build_failed` flag from `PlaceHolderScriptInstance` to `Script`. That improves the code a lot. I also renamed it to `placeholder_fallback_enabled` which is a much better name (`build_failed` could lead to misunderstandings).
2019-01-10 01:58:50 +01:00
..
bmp Fix warnings on release builds (not DEBUG_ENABLED) 2018-10-03 17:34:55 +02:00
bullet Merge pull request #23994 from AndreaCatania/prec 2018-11-28 10:30:47 +01:00
csg Fix csgshape collider without object id 2018-12-03 16:06:30 -02:00
cvtt SCons: Build thirdparty code in own env, disable warnings 2018-09-28 14:07:39 +02:00
dds Fixed DDS loader according to issue #22530 2018-10-03 17:11:14 +02:00
enet doc: Use HTTPS for docs.godotengine.org and point to latest branch 2018-11-05 08:46:27 +01:00
etc Fix warning about functions defined but not used [-Wunused-function] 2018-09-29 22:26:12 +02:00
freetype Fix UWP build. 2018-11-03 17:19:44 +01:00
gdnative Allow signal connecting even if script is invalid (only when compiled with tools), fixes #17070 2018-11-27 19:55:37 -03:00
gdscript Fix properties being lost when reloading placeholder GDScript instance 2019-01-10 01:58:50 +01:00
gridmap Get rid of gridmap error due to not yet valid cursor instance, fixes #17546 2018-11-16 09:10:44 -03:00
hdr Make core/ includes absolute, remove subfolders from include path 2018-09-12 09:52:22 +02:00
jpg load JPG images as rbg instead of rgba, fixes #21867 2018-10-04 00:12:00 +02:00
mbedtls SCons: Build thirdparty code in own env, disable warnings 2018-09-28 14:07:39 +02:00
mobile_vr Fix warnings in Android platform 2018-10-03 15:17:00 +02:00
mono Fix properties being lost when reloading placeholder GDScript instance 2019-01-10 01:58:50 +01:00
ogg SCons: Build thirdparty code in own env, disable warnings 2018-09-28 14:07:39 +02:00
opensimplex doc: Sync with current source 2018-10-25 15:14:47 +02:00
opus SCons: Build thirdparty code in own env, disable warnings 2018-09-28 14:07:39 +02:00
pvr SCons: Build thirdparty code in own env, disable warnings 2018-09-28 14:07:39 +02:00
recast Fix inconsistences in some buttons in the Canvas/Spatial editor menubar 2018-10-25 12:15:39 -03:00
regex Assign pointer null in RegEx::clear to avoid double free on destruction. 2018-11-15 13:36:40 +00:00
squish Build squish decompression in runtime 2018-11-28 11:11:58 +01:00
stb_vorbis Fix warning about functions defined but not used [-Wunused-function] 2018-09-29 22:26:12 +02:00
svg SCons: Remove avoidable defines from main env's CPPPATH 2018-10-01 11:59:22 +02:00
tga Make core/ includes absolute, remove subfolders from include path 2018-09-12 09:52:22 +02:00
thekla_unwrap Fixes to baker, restored xatlas and fixed bake options. 2018-10-05 19:00:32 -03:00
theora Don't delete FileAccess when it is null 2018-10-05 20:24:28 +01:00
tinyexr SCons: Build thirdparty code in own env, disable warnings 2018-09-28 14:07:39 +02:00
upnp SCons: Build thirdparty code in own env, disable warnings 2018-09-28 14:07:39 +02:00
visual_script Allow signal connecting even if script is invalid (only when compiled with tools), fixes #17070 2018-11-27 19:55:37 -03:00
vorbis SCons: Build thirdparty code in own env, disable warnings 2018-09-28 14:07:39 +02:00
webm Don't delete FileAccess when it is null 2018-10-05 20:24:28 +01:00
webp SCons: Build thirdparty code in own env, disable warnings 2018-09-28 14:07:39 +02:00
websocket Websocket LWS keep servicing till no CB are left 2018-11-25 17:25:03 +01:00
xatlas_unwrap Fixes to baker, restored xatlas and fixed bake options. 2018-10-05 19:00:32 -03:00
register_module_types.h Add missing copyright headers and fix formatting 2018-01-05 01:22:23 +01:00
SCsub SCons: Build thirdparty code in own env, disable warnings 2018-09-28 14:07:39 +02:00