Commit Graph

2561 Commits

Author SHA1 Message Date
Paulb23 3df68b4fa6 Fixed LineEdit alignment when removing text or undo / redo 2019-12-01 13:54:09 +00:00
Rémi Verschelde 966c68badd Range: Remove min/max check added in #33908
This wasn't a very good idea as it puts too strict requirements on how
to set `min` and `max` values. For example, since the default min and
max are 0 and 100, this triggers an error:

```
set_min(256)
set_max(16384)
```

Since `min` will be higher than `max` temporarily. It can be worked
around by setting max first, but it's not really intuitive. I'll relax
the requirement as it's only a problem in `get_as_ratio`, which already
has a check.

Fix another min == max occurrence.
2019-11-26 12:11:21 +01:00
Rémi Verschelde bfd5e09879 Range: Fix cases where max was set to or below min value
It will now raise an error whenever this happens so that we can fix
these situations. `max == min` is not allowed as it could lead to
divisions by zero in ratios, and `max < min` doesn't make much sense.

Fixes #33907.
2019-11-26 10:25:41 +01:00
Rémi Verschelde 5ddce7a9df
Merge pull request #33869 from jbuck3/dialog-resize-bug
Fix WindowDialog moving when resized from the left/top edge
2019-11-25 14:38:33 +01:00
James Buck 5f451e0fb2 Fix WindowDialog moving when resized from the left/top edge
get_combined_minimum_size() must be used in order to consider the min size
specified by the user when determining how far the left/top edge is allowed
to move. Otherwise the dialog may think it can shrink further than it
should, causing the right/bottom edge to move when the rect size is fixed in
set_size().
2019-11-24 23:39:55 -06:00
PouleyKetchoupp 8830e53fe1 Fixed index out of size error in TextEdit when opening scripts 2019-11-24 10:48:04 +01:00
Rémi Verschelde 083d088de3
Merge pull request #33583 from qarmin/fix_overflows_unitialized
Fix some overflows and unitialized variables
2019-11-20 21:31:12 +01:00
Rafał Mikrut 99d8626f4a Fix some overflows and unitialized variables 2019-11-20 16:22:16 +01:00
lupoDharkael 268fe9dda5 GradientEdit: Fix index crashes 2019-11-19 22:05:37 +01:00
Hugo Locurcio 72b31aafc4
Make holding Ctrl toggle snapping in GraphEdit
This affects the visual script and visual shader editors as well.
2019-11-15 19:34:44 +01:00
PouleyKetchoupp 47a4ca0022 Fixed crash when pressing down key on empty Tree
Fixes #33554
2019-11-12 08:15:29 +01:00
Rémi Verschelde 2143f46df2
Merge pull request #33516 from qarmin/small_fixes
Memory leaks and crash fixes
2019-11-10 10:17:19 +01:00
Rafał Mikrut 7dda9309f9 Memory leak and crash fixes 2019-11-10 09:49:13 +01:00
PouleyKetchoupp 0fc0f0fc98 Fixed crash when using icon override in button
Missing change for PR #33495
2019-11-09 23:06:46 +01:00
PouleyKetchoupp 0c79bbeea3 Fixed crash when using icon override in button
Fixes #33457
2019-11-09 20:14:52 +01:00
Paulb23 25cba699f0 Fixed not being able to scroll ending wrapped line 2019-11-09 16:45:44 +00:00
Rémi Verschelde 31f327a4a9
Merge pull request #33052 from KoBeWi/naughty_sliders
Fix analog input in sliders
2019-11-08 09:55:11 +01:00
Tomasz Chabora a7b202ef18 Fix analog input in sliders 2019-11-07 16:39:14 +01:00
codecustard 71e79af1f1 Fixes ItemList max column update
When setting the max column of an ItemList, the layout does not update until it is resized.
2019-11-06 12:26:51 -08:00
PouleyKetchoupp 13c88878c4 Fixed cases where labels with autowrap can overflow the editor ui
Fixes #33155
2019-11-04 10:12:36 +01:00
Rémi Verschelde e684df08fc
Merge pull request #33286 from groud/fix_tree_edit_rect
Fixes the edit rect in TreeItems
2019-11-03 17:35:01 +01:00
Gilles Roudiere 8eb2eeae0f Fixes the edit rect in TreeItems 2019-11-03 16:08:07 +01:00
Michael Alexsander 6348dfa948 Make the editor dimming even more smarter 2019-11-02 20:25:26 -03:00
Paulb23 362d38ea67 Update connection info on script validation rather then saved copy 2019-11-02 14:41:59 +00:00
Rémi Verschelde 5160d4f5ba
Merge pull request #33233 from hilfazer/dollar-quoted-autocomplete
$ autocompletion keeps quotation
2019-11-01 16:52:13 +01:00
hilfazer c394ef7410 $ autocompletion keeps quotation 2019-11-01 14:52:13 +01:00
Rémi Verschelde a49c8d4a2b
Merge pull request #33202 from nekomatata/text-edit-search-usability
Improved TextEdit search usability & documentation
2019-11-01 14:10:00 +01:00
Michael Alexsander 36c4fd8935 Make the editor dimming smarter 2019-10-31 16:58:53 -03:00
PouleyKetchoupp d29c8ab81b Improved TextEdit search usability & documentation 2019-10-31 12:35:23 +01:00
Rémi Verschelde 948a2a03d2
Merge pull request #33091 from MCrafterzz/fix10567
Improved project creation UX
2019-10-29 13:27:41 +01:00
MCrafterzz 336e61b36a Improved UX of selecting directories in (Editor)FileDialog by hiding unused gui elements and moving the drive selection 2019-10-29 11:36:09 +01:00
Rémi Verschelde aaa9751de3
Merge pull request #33120 from YeldhamDev/popup_dialog_panel_style
Add "panel" style to PopupDialog
2019-10-28 12:54:03 +01:00
Rémi Verschelde 0cae264d79
Merge pull request #33119 from creikey/fix-quote-malfunction
Remove duplicate quote in displayed quote type
2019-10-28 08:08:38 +01:00
Michael Alexsander d92123ed97 Add "panel" style to PopupDialog 2019-10-27 19:45:03 -03:00
Cameron Reikes 67ab03e245 Remove duplicate quote in displayed quote type
- fixes #32688
 - fixes #32593
2019-10-27 15:21:25 -07:00
Rémi Verschelde 2751cea0d4
Merge pull request #33066 from Tabas32/fix_indentation
Fixed indenting issue with comment at end of line
2019-10-27 13:42:53 +01:00
Paulb23 2e2a049d3c Improve performance of connection info in the script editor 2019-10-27 11:07:19 +00:00
Rémi Verschelde 9e572b5bac
Merge pull request #33032 from Calinou/filedialog-scroll-to-top
Scroll back to the top after opening a directory in FileDialog
2019-10-27 10:06:34 +01:00
Paulb23 df0c8386a9 Fix text minimap crash when last line is folded 2019-10-26 13:37:25 +01:00
Rémi Verschelde c39238c7d2
Merge pull request #32870 from bergmannf/27850_rtl_bold_italic
Add push_* methods for fonts in rich_text_label
2019-10-25 23:17:59 +02:00
Marian 3322d19cb3 Just initialization, needed by compiler 2019-10-25 16:14:24 +02:00
Marian 616f02e905 Fixed indenting issue with comment at end of line 2019-10-25 15:01:43 +02:00
Zatherz 72d2248276 Don't terminate search if begin_key doesn't fit
Previously this code would continue onto the next iteration of the loop if the line was smaller in size than begin_key, meaning that a situation where begin_key.length() > end_key.length() would cause weird behavior with newlines. Now both the checks for begin_key and end_key are in their own condition and do not skip the entire iteration if they can't be found.
2019-10-24 21:59:02 +02:00
volzhs 63e6b1ecce Fix rendering tooltip 2019-10-24 22:48:20 +09:00
Hugo Locurcio c3b9319d78
Scroll back to the top after opening a directory in FileDialog
This also changes the behavior in EditorFileDialog.

This closes #26041.
2019-10-24 15:40:47 +02:00
SeleckyErik 61bda112bd Refactor VideoPlayer and VideoStream
VideoStream:
- Fix const correctenss

VideoPlayer:
- Remove unused member variable last_frame
- Move _mix_audios function definition to source file
- Fix function parameter naming to match p_ convention
- Fix const correctness
- Add null checking
2019-10-24 01:35:47 +01:00
Rémi Verschelde b1c6ba9b24
Merge pull request #32972 from codecustard/fix_spinbox_not_releasingfocus
Fixes spinbox not releasing focus on value change
2019-10-23 07:43:47 +02:00
Eoin O'Neill 601b216605 Shadows Now Properly Translate by RichTextEffect offset.
Bugfix 32981.
2019-10-22 22:15:36 -07:00
Rémi Verschelde 78848bbfea
Merge pull request #32796 from Paulb23/set_text_caret
Changed `set_text` to place caret at start of the text.
2019-10-22 22:44:12 +02:00
Rémi Verschelde 9f28803927
Merge pull request #32940 from nekomatata/text-edit-clear-colors
TextEdit syntax highlighting fixes
2019-10-22 20:40:20 +02:00
Rémi Verschelde b365dc3441
Merge pull request #32965 from volzhs/richtextlabel-scroll-active
Fix scrolling RichTextLabel with scroll_active=false
2019-10-22 20:39:12 +02:00
PouleyKetchoupp e3d4b96ba7 Fixed crashes when renaming a state in AnimationNodeStateMachineEditor
Recursive calls to Control::_modal_stack_remove could cause a crash because of the list element not being invalidated while being erased from the list.

It happens in the state machine case by hiding a line edit control when it loses focus.

Fixes #23808
2019-10-22 16:28:11 +02:00
Rémi Verschelde 97a4fe79fb
Merge pull request #32902 from nekomatata/auto-indent-bracket-fix
Auto-indent after opening bracket and parenthesis in the script editor
2019-10-22 14:30:16 +02:00
Rémi Verschelde b67537b14b
Merge pull request #32864 from nekomatata/rich-text-image-size
Support for resized images in RichTextLabel
2019-10-22 13:46:11 +02:00
Rémi Verschelde 1e0fb0dc14
Merge pull request #32833 from nekomatata/label-autowrap-fix
Allow Label autowrap to cut words when they exceed line width
2019-10-22 12:29:49 +02:00
Emmanuel Barroga 53d6d37fcf Fixes spinbox not releasing focus on value change
Trying to release focus of the spinbox's lineedit would not work when done in the "value_changed" callback. The reason is because the "value_change" signal is called first, then the "get_focus" method is called next. This causes the spinbox to get_focus after you try to release focus within the "value_changed" callback.

To resolve this, spinbox should get focus first and then emit "value_changed".
2019-10-21 16:42:17 -07:00
volzhs 3e738b1798 Fix scrolling RichTextLabel with scroll_active=false 2019-10-22 06:05:10 +09:00
Georg Wacker dfb7d46a2a Fix control node transform animation jitter with pivot offset
The workaround for moving the pivot is not needed anymore, in fact it causes all transforms applied to control nodes to jitter while animating (if a pivot offset is set).

This can be observed via AnimationPlayer and Tween.

The fix is to remove the obsolete workaround that causes this bug.

Fixes #28804
2019-10-21 16:52:45 +02:00
PouleyKetchoupp 4247c21cb0 TextEdit syntax highlighting fixes
- Fixed visual update when using add_keyword_color(), add_color_region(), clear_colors() in scripts
- More accurate description for clear_colors() in TextEdit documentation
2019-10-20 17:40:09 +02:00
Paulb23 ee94081b4a Fixed -1 minimap index when smooth scrolling is enabled 2019-10-20 13:27:53 +01:00
PouleyKetchoupp 74d7cbf920 Auto-indent after opening bracket and parenthesis in the script editor
This change makes auto-indent work the same way as for curly brackets, so '[', '(', '{' all act the same.

Fixes #32897
2019-10-18 11:02:05 +02:00
Florian Bergmann 47000f8860 Add push_* methods for fonts in rich_text_label
Provides method to push different font styles.

If no fonts are set nothing will happen, when the methods are used.

Fixes #27850
2019-10-16 15:22:56 +02:00
PouleyKetchoupp 9f8ffd4146 Support for resized images in RichTextLabel
BBCode Tag:
[img=<width>x<height>]{path}[/img]
2019-10-16 12:00:15 +02:00
PouleyKetchoupp 8df330bacd Allow Label autowrap to cut words when they exceed line width
Fixes #30832
2019-10-16 09:57:44 +02:00
Rémi Verschelde 44293db446
Merge pull request #32820 from qarmin/small_fixes_static_analyzer
Small fixes to redundand code, copy paste bugs
2019-10-15 09:54:58 +02:00
Yuri Roubinsky 0a0c3f7fe0 Fix color of FileDialog icons 2019-10-14 16:23:56 +03:00
qarmin 616ab4fac2 Small fixes to redundand code, copy paste bugs 2019-10-14 11:40:55 +02:00
Paulb23 d579d2bf1d Fix undo / redo scrollbar calulations 2019-10-13 15:34:28 +01:00
Paulb23 aea0761b25 Place caret at 0,0 when setting text not at the end 2019-10-13 15:29:20 +01:00
Rémi Verschelde be0da31f7a
Merge pull request #32628 from Paulb23/issue_32609_set_text_scrollbar
Fixed inserting text at caret not updating scrollbar size
2019-10-11 08:24:13 +02:00
Marcel Admiraal a8836ba28d Remove dependency on the editor directory being in the build's include path.
- Add or remove the necessary subdirectorires to the includes to remove
dependency on the editor directory being in the build's include path.
- Ensure includes in modified files conform to style guideline.
- Remove editor from the build include path.
2019-10-10 08:57:00 +02:00
Rémi Verschelde f46bf8e721
Merge pull request #32411 from YeldhamDev/fix_grid_overflow
Fix GridContainer's children overflowing it when not all slots of a row are occupied
2019-10-08 17:05:32 +02:00
Rémi Verschelde 45577e4233
Merge pull request #32571 from DavidSichma/rect_flip
Correctly flip texture src region
2019-10-08 16:15:45 +02:00
Rémi Verschelde 58dd5d0c78 PopupMenu: Fix missing text/xl_text when using add_shortcut
Use macros to ensure that `text`, `xl_text` and `id` are always set
using the same logic.

Fixes #25519.

Also fixes up #26914 when `p_id == -1` handling was only added for a
couple methods instead of all of them.
2019-10-08 09:33:26 +02:00
Rémi Verschelde 63a19df5e6 PopupMenu: Reorder add_* methods in more natural order
Also adds `add_icon_radio_check_shortcut` matching `add_icon_radio_check_item`,
binds them for scripting languages, and binds `add_multistate_item`.
2019-10-08 09:32:01 +02:00
Paulb23 e5b18cea63 Fixed inserting text at caret not updating scrollbar size 2019-10-07 19:17:32 +01:00
Paulb23 6025a76c78 Fixed drawing the caret at eol when at eol is not visible 2019-10-07 17:24:58 +01:00
Rémi Verschelde f84bf7e8a8
Merge pull request #32351 from nekomatata/texture-rect-size-update
Update TextureRect when its Texture is modified directly
2019-10-07 08:57:17 +02:00
dankan1890 b469ff17e2 Added missing bind_method to TreeItem::get_custom_color().
Fix #32595
2019-10-06 22:07:50 +02:00
Rémi Verschelde c8f6661459
Merge pull request #32569 from qarmin/fix_control_crash
Fix crash in Control functions
2019-10-06 20:50:18 +02:00
qarmin 17344337a9 Fix crash in Control functions 2019-10-05 19:17:07 +02:00
PouleyKetchoupp c7834ee566 Update TextureRect and Sprite when their Texture is modified directly.
Modified Sprite to use "changed" signal instead of _changed_callback to make it work when tool is disabled (change receptors are editor only).

Fixes #32349
2019-10-05 17:32:46 +02:00
David Sichma f73e1fae37 Correctly flip texture src region 2019-10-05 16:51:06 +02:00
Rémi Verschelde ee611d149b
Merge pull request #22834 from lupoDharkael/recursive-item
Add call_recursive method to TreeItem
2019-10-04 15:32:14 +02:00
MrCdK 03d6291aaf Handle scrolling correctly in Tree controls inside ScrollContainers 2019-10-02 12:34:04 +02:00
ternvein 848eeafe29 FIX: GridContainer children visibility check for min size evaluation 2019-10-01 16:13:06 +04:00
Rémi Verschelde e695ac6e7b
Merge pull request #32364 from Relintai/resizeable-texture-progress
TextureProgress: nine_patch_stretch property -> enable stretching for radial fills.
2019-10-01 10:34:21 +02:00
Rémi Verschelde d735ce80b9
Merge pull request #32440 from Ternvein/control-translation-fix
Fix for WindowDialog and Tabs controls translation
2019-10-01 10:27:10 +02:00
Relintai 108068ab41 Make TextureProgress's nine_patch_stretch property to enable stretching for radial fills. 2019-09-30 20:58:29 +02:00
Soumya Lahiri a1b2364dba Altered rotation_degrees range 2019-09-30 20:43:57 +05:30
ternvein 118940e7c5 FIX: Tabs text translation 2019-09-30 13:56:20 +04:00
ternvein efc8314516 FIX: WindowDialog title translation 2019-09-30 13:07:47 +04:00
Rémi Verschelde d4ff03c0e8
Merge pull request #32390 from lupoDharkael/timer-tree
TextEdit: Fix timer inside tree warning
2019-09-30 07:37:59 +02:00
Michael Alexsander Silva Dias 24ed6b58e1 Make empty columns automatically expand in GridContainer 2019-09-28 09:49:58 -03:00
Michael Alexsander Silva Dias 07f3a129c6 Fix GridContainer's children overflowing it when not all slots of a row are occupied 2019-09-28 02:57:11 -03:00
Rémi Verschelde d0e45e78a4 doc: Sync classref with current source
And various fixes to bindings, hyperlinks and an uninitialized variable.
2019-09-27 22:16:42 +02:00
Rémi Verschelde 5966c6b646
Merge pull request #32379 from Calinou/colorpicker-add-overbright-indicator
Draw an indicator to denote overbright colors in ColorPicker
2019-09-27 22:03:22 +02:00
Rémi Verschelde 5cb926a001
Merge pull request #29681 from swarnimarun/vs-graph-unification
Visual Script Graph Unification
2019-09-27 15:54:37 +02:00
Hugo Locurcio 70c4e96623
Draw an indicator to denote overbright colors in ColorPicker
This makes it faster to distinguish overbright colors from
"standard" colors.
2019-09-27 15:28:42 +02:00
lupoDharkael cb22a875aa TextEdit: Fix timer inside tree warning 2019-09-27 13:57:20 +02:00
Rémi Verschelde fd0ad20122
Merge pull request #32369 from ndarilek/get_button_tooltip
Implement `TreeItem.get_button_tooltip(column, idx)`.
2019-09-27 08:16:36 +02:00
Nolan Darilek 5629a006d9 #14011: Implement `TreeItem.get_button_tooltip(column, idx)`.
When added to `TreeItem`, buttons are given tooltips. When returned via `get_button(...)`, however, the button is a `Texture` and the tooltip information isn't included.

For accessibility purposes, it is useful to have access to the tooltip text. As such, we can retrieve a button's tooltip to use as a button label.
2019-09-26 10:41:02 -05:00
Relintai 25704e81fa Implement #32347 - RichTextLabel's Item and Item* structs should not inherit Object, it's too expensive 2019-09-26 01:26:02 +02:00
Swarnim Arun 59738e3fa3
Visualscript editor graph unification & refactoring
Removes the need to have separate graphs per function for the VisualScript Nodes, and refactoring UI and other improvements such as fuzzy search, right click search boxes and in-graph editable nodes
2019-09-26 01:53:58 +05:30
Rémi Verschelde dec10dd776
Merge pull request #32051 from qarmin/some_error_explanation
Added some obvious errors explanations
2019-09-25 11:51:54 +02:00
qarmin 17732fe698 Added some obvious errors explanations 2019-09-25 10:28:50 +02:00
Michael Alexsander Silva Dias d24513911d Make LineEdit's minimal size adapt to its icons 2019-09-25 00:46:29 -03:00
Rémi Verschelde 2f52d73c21
Merge pull request #31925 from bojidar-bg/31855-overriden-properties-docs
Add overriden properties to the documentation
2019-09-24 11:53:43 +02:00
Rémi Verschelde cefa56ef1f
Merge pull request #31935 from aole/Change-minimum-size-when-theme-changed
Change minimum size when theme changed
2019-09-24 11:13:44 +02:00
Rémi Verschelde a7b95d1934
Merge pull request #32267 from YeldhamDev/fix_tab_icons
Fix various problems with tab-related icons
2019-09-24 10:45:40 +02:00
Rémi Verschelde 329c54453e
Merge pull request #32202 from Relintai/fix-crash-in-rich-text-label
Fix crash on some platforms in RichTextLabel.
2019-09-24 09:30:14 +02:00
Rémi Verschelde fc47569be9
Merge pull request #32232 from Paulb23/issue_32070_goto_doc_when_selecting
Fixed going to doc reference while selecting text
2019-09-23 15:00:41 +02:00
Rémi Verschelde 393a0152ea
Merge pull request #32055 from qarmin/some_code_fixes
Changed some code found by Clang Tidy and Coverity
2019-09-23 10:00:31 +02:00
Rémi Verschelde 791da4cb83
Merge pull request #32048 from YeldhamDev/lineedit_right_icon_fix
Expose LineEdit's 'right_icon' and fix icon size
2019-09-23 09:51:45 +02:00
Rémi Verschelde 0782082433
Merge pull request #32003 from codecustard/fix_optionbutton_not_selecting
Fixes OptionButton Not Updating Current Selection
2019-09-23 08:46:09 +02:00
Michael Alexsander Silva Dias 94ad89a5fb Fix various problems with tab-related icons 2019-09-22 23:08:14 -03:00
Rémi Verschelde 0928e82027
Merge pull request #29895 from ptrojahn/menukey
Support menu key in TextEdit and LineEdit controls
2019-09-22 21:21:13 +02:00
qarmin 50be65bf43 Changed some code found by Clang Tidy and Coverity 2019-09-22 18:45:08 +02:00
Paul Trojahn ba24bc1e04 Support menu key in TextEdit and LineEdit controls
Related to #15542
2019-09-22 12:06:24 +02:00
Michael Alexsander Silva Dias 5d03aa12c9 Expose LineEdit's 'right_icon' and fix icon size 2019-09-21 21:14:14 -03:00
Paulb23 ef3455f236 Fixed going to doc reference while selecting text 2019-09-21 13:45:20 +01:00
Rémi Verschelde f7cd50e900
Merge pull request #32206 from Calinou/remove-unused-tree-constants
Remove an unused icon and constant in Tree
2019-09-20 23:14:50 +02:00
Hugo Locurcio 40a5de97e6
Remove an unused icon and constant in Tree 2019-09-20 17:50:13 +02:00
Rémi Verschelde 48db920f4a
Merge pull request #32190 from KoBeWi/undo_redo_stuff
Fix autocompletion undo
2019-09-20 17:22:11 +02:00
Rémi Verschelde c74b54f229
Merge pull request #32197 from YeldhamDev/fix_multiple_modals_dim
Fix editor dimming being disabled when a dialog is closed even when others are open
2019-09-20 17:13:44 +02:00
Rémi Verschelde fdc2463a1b
Merge pull request #32150 from luzpaz/typos
Fix misc. source comment typos
2019-09-20 17:09:05 +02:00
Tomasz Chabora a28d18f554 Load overrides if getting style from current class 2019-09-20 13:48:24 +02:00
luz.paz 91ecd7b6a6 Fix misc. source comment typos
Found using `codespell -q 3 -S ./thirdparty,*.po -L ang,ba,cas,dof,doubleclick,fave,hist,leapyear,lod,nd,numer,ois,paket,seeked,sinc,switchs,te,uint -D ~/Projects/codespell/codespell_lib/data/dictionary.txt `
2019-09-19 14:36:52 -04:00
Rémi Verschelde fae14153f7
Merge pull request #31188 from codecustard/LineEdit_disable_shortcuts
Add Ability to Enable/Disable Shortcuts and Selection for LineEdit/TextEdit
2019-09-19 19:56:59 +02:00
Relintai 838e474e66 Fix crash on some platforms in RichTextLabel. 2019-09-19 19:25:11 +02:00
Michael Alexsander Silva Dias 53c9eaf933 Fix editor dimming being disabled when a dialog is closed even when others are open 2019-09-19 00:46:10 -03:00
Tomasz Chabora d630472b98 Fix autocompletion undo 2019-09-18 16:26:33 +02:00
Eoin O'Neill ebc6fb9869 Fix Sanitization Bug
From issue #32089 -- I messed up the property hints by putting them
in the wrong location. Should be working as intended now.
2019-09-11 16:39:24 -07:00
Emmanuel Barroga b678d68224 Add Ability to Enable/Disable Shortcuts for LineEdit/TextEdit
This PR adds the ability to enable/disable shortcut keys and selection for LineEdit/TextEdit. It also updates the context menu when you disable/enable the shortcut keys or selection.
2019-09-07 06:06:36 -07:00
Emmanuel Barroga c2b902af4b Fixes OptionButton Not Updating if Current Selection Already Selected
When the option button's current selection is updated to a different text/icon, the selected option does not update until you unselect the option and then select it again.
2019-09-05 22:17:48 -07:00
Eoin O'Neill b85b2da988 Bug Fix 31973 Type Hint Error
Fixed a bug introduced in my previous PR involving CharFXTransform not
allowing the use of type hinting. Should now work properly. This should
also help with Godot Mono issues...
2019-09-04 16:42:51 -07:00
Rémi Verschelde 3d76eb8938
Merge pull request #23658 from Eoin-ONeill-Yokai/rich-text-plus
RichTextLabel - New Real Time Text Effects and Custom BBCode Extensions
2019-09-04 14:49:55 +02:00
Bojidar Marinov 6c4407bae4
Add overriden properties to the documentation
Fixes #31855
2019-09-04 15:21:40 +03:00
PouleyKetchoupp 5fdea32622 TextEdit & LineEdit caret blink timers run only when focused (fixes #31936) 2019-09-04 13:06:15 +02:00
lupoDharkael 306e64a9f5 Add call_recursive method to TreeItem 2019-09-04 12:42:08 +02:00
Eoin O'Neill feedd6c615 Update RichTextLabel to support real time effects and custom BBCodes.
Added a new ItemFX type to RichTextLabel which supports dynamic text
effects.

RichTextEffect Resource Type was added which can be extended for more
real time text effects.
2019-09-03 15:36:19 -07:00
Bhupendra Aole 7a27abae49 Change minimum size when theme changed
Need to call minimum_size_changed on controls whenever the theme is changed.

Fixes godotengine#29816
2019-09-03 14:56:56 -04:00
Rémi Verschelde 750f8d4926
Merge pull request #31844 from 2shady4u/TweenInSceneTree
Timer and Tween check if they are in SceneTree when starting
2019-09-03 18:35:20 +02:00
shaderbeast 5e337b31eb Added is_inside_tree() check in both Timer and Tween
Tween now throws error and doesnt even execute.
2019-09-03 13:26:41 +02:00
Rémi Verschelde 331bb5a8c6
Merge pull request #31295 from fstiewitz/focus-rect-issue
Fix get_meta error and visual bug when editing scene with keyboard
2019-09-03 13:11:41 +02:00
Rémi Verschelde ad9f39108f
Merge pull request #31507 from YeldhamDev/button_icon_expand
Add feature to Button to make its icon expand/shrink with the button's size
2019-09-03 12:51:22 +02:00
Rémi Verschelde dd7c4c62ab
Merge pull request #31782 from aole/persist-ColorPicker-color-mode
Persist ColorPicker color mode
2019-09-03 12:36:04 +02:00
Rémi Verschelde 413db5d8ff
Merge pull request #31889 from Calinou/gradient-editor-add-snapping
Implement snapping in the Gradient editor
2019-09-02 22:12:04 +02:00
amakarenko 544c39d1e7 Fix editor infinit loop in search_prev
Fixes godotengine#31328
2019-09-02 15:15:55 +03:00
Hugo Locurcio 98a0c2b20f
Implement snapping in the Gradient editor
Holding Ctrl will snap the selected point's position
by increments of 0.1. Holding Ctrl + Shift will snap by increments
of 0.025 instead.

The previous behavior is preserved when holding just Shift (snapping
to other gradient points).
2019-09-02 13:37:27 +02:00
Michael Alexsander Silva Dias 5f28a2f978 Fix multiline texts not updating its contents correctly in the inspector 2019-09-02 01:17:11 -03:00
Tomasz Chabora aa444453b8 Ignore size of hidden scrollbars in ScrollContainer 2019-09-01 18:31:32 +02:00
Chaosus89 8fd8589547 Fix resizer icon visiblity on light theme in GraphNode 2019-09-01 09:12:26 +03:00
Rémi Verschelde 00aabec8bb
Merge pull request #31828 from Paulb23/minimap_drag_less_then_control
Fix minimap drag when height is less then control size
2019-08-31 22:09:53 +02:00
Rémi Verschelde b17b51d970
Merge pull request #31825 from fstiewitz/viewport-container-input
Fix object picking inside ViewportContainers
2019-08-31 17:25:11 +02:00
Paulb23 b1aaeb07ea Fix minimap drag when height is less then control size 2019-08-31 15:43:19 +01:00
Fabian Stiewitz 21b6be28ea process unhandled input in ViewportContainer 2019-08-31 14:51:16 +02:00
Bhupendra Aole 1de3ec911f Default ColorPicker color mode setting
There is a new setting for Default ColorPicker color mode in Editor Settings->Interface->Inspector. Initially this setting will be RGB. Editor ColorPicker will always start with mode defined in this settiing.
Fixes #30755 and #30754
2019-08-31 00:34:33 -04:00
Rémi Verschelde 9fc359411f
Merge pull request #31803 from KoBeWi/minicursor
Don't change cursor when minimap is disabled
2019-08-30 20:08:21 +02:00
Rémi Verschelde bbaf35c4f5
Merge pull request #31797 from KoBeWi/release_the_lookup
Perform symbol lookup on button release
2019-08-30 20:07:53 +02:00
Tomasz Chabora b0805a1b53 Don't change cursor when minimap is disabled 2019-08-30 19:13:53 +02:00
Rémi Verschelde ba854bbc7b
Merge pull request #31796 from Chaosus/fix_icons
Fixed GraphEdit header icons to make them update when theme is changed
2019-08-30 16:38:38 +02:00
Tomasz Chabora b55b3d71a8 Perform symbol lookup on button release 2019-08-30 16:19:25 +02:00
Rémi Verschelde efbd2bbf18
Merge pull request #31792 from Calinou/spinbox-expression-ignore-prefix-suffix
Ignore the prefix and suffix in the SpinBox expression
2019-08-30 16:09:06 +02:00
Chaosus89 fde0579ed1 Fixed GraphEdit header icons to make them update when theme is changed 2019-08-30 17:00:25 +03:00
Rémi Verschelde 58e7cbccc0
Merge pull request #30927 from mahubu/console-multi-selection-cursor
Change cursor to multi-selection cursor when selecting text in RichTextLabel
2019-08-30 15:05:54 +02:00
Hugo Locurcio 68f0d21cc4
Ignore the prefix and suffix in the SpinBox expression
This fixes a regression caused by
86a31e9e38.
2019-08-30 14:28:32 +02:00
Rémi Verschelde ca652bbc47
Merge pull request #25353 from azagaya/master
Use also invisible tabs to calculate minimum size of tab container
2019-08-30 13:58:37 +02:00
azagaya fa6f86b886 Make tab containers in editor, project settings, and export dialog, to use hidden tabs for min size computation. 2019-08-30 08:33:32 -03:00
Hugo Locurcio 86a31e9e38
Calculate the SpinBox value using the Expression class
This closes #31780.
2019-08-29 23:50:56 +02:00
Michael Alexsander Silva Dias 9b09daa8c5 Add feature to Button to make its icon expand/shrink with the button's size 2019-08-29 11:25:00 -03:00
Michael Alexsander Silva Dias da5195fc92 Fix wrong offset in Button when alignment is set to left 2019-08-28 23:12:22 -03:00
Rémi Verschelde 185072015f
Merge pull request #31606 from toasteater/fix/nativescript-new-json-return-type
Fix the return type of NativeScript::new in API json
2019-08-28 09:15:40 +02:00
Michael Alexsander Silva Dias 9c36d893e3 Fix Multiline texts not updating correcly inside arrays 2019-08-26 13:47:33 -03:00
toasteater a919f5e614 Fix return type of Control::get_drag_data in API json
Control::get_drag_data is a virtual method that returns Variant, but have the
Object type in its MethodInfo.

This changes the MethodInfo of Control::get_drag_data
2019-08-26 16:38:16 +00:00
Rémi Verschelde 0985d5fa99
Merge pull request #31496 from nekomatata/fix-text-edit-insert-selection
Update TextEdit selection when inserting line
2019-08-25 22:33:23 +02:00
Rémi Verschelde 41b5c62952
Merge pull request #31654 from Paulb23/minimap_fixes
Viewport highlight, colour cache and minimap scrolling fixes.
2019-08-25 22:32:05 +02:00
Paulb23 32d5427f55 Refactor TextEdit control height calculations 2019-08-25 14:49:13 +01:00
PouleyKetchoupp bc839ed3f3 Update TextEdit selection & cursor when inserting line
Fixes #31458
2019-08-25 15:43:45 +02:00
Paulb23 c5b5c6b49b Minimap scroll now acts similar to scrollbar 2019-08-25 14:43:11 +01:00
Rémi Verschelde 0d37f198f5
Merge pull request #31628 from merumelu/treeitem-icon-modulate
Tree: fix and expose icon modulation
2019-08-25 10:49:26 +02:00
Yuri Roubinski 4efa1b6906 Disallow undo/redo in readonly TextEdit's 2019-08-25 09:57:59 +03:00
merumelu eac0af5892 Tree: fix and expose icon modulation 2019-08-24 17:37:22 +02:00
Paulb23 ec4d2b26ec Fixed syntax highlighting cache not clearing final line 2019-08-24 15:21:45 +01:00
Paulb23 b75c2b6d76 Adjust viewport colour based on background colour 2019-08-24 14:33:55 +01:00
Rémi Verschelde 98ccdc0889
Merge pull request #30398 from tomasantunes/master2
Increase color preset slots
2019-08-23 09:19:11 +02:00
Rémi Verschelde d5675c3996
Merge pull request #31575 from creikey/increase-anchor-precision
Increase control node's anchor precision
2019-08-23 08:22:33 +02:00
Paulb23 a5c1830a43 Fix minimap mouse click resolving to -1 2019-08-22 20:07:16 +01:00
Cameron Reikes 5deb83e041 Increase control node's anchor precision 2019-08-22 11:04:24 -07:00
Paulb23 0cea72273f Add minimap to text_edit 2019-08-21 23:48:46 +01:00
Paulb23 895a15b321 Add syntax highlighting cache 2019-08-21 23:36:49 +01:00
Hugo Locurcio e1b9004b0f
Rename FileDialog's folder icon custom color to `folder_icon_modulate`
The custom color introduced in be8d569744
had the same name as the "folder" icon, which could cause conflicts
in the generated documentation.

The new name is also more self-explanatory.
2019-08-21 18:43:01 +02:00
geequlim 545b46ac2f Fix filter quotes wraped insert completion options 2019-08-21 22:11:36 +08:00
Hugo Locurcio be8d569744
Use a different color for folder icons in file dialogs
This makes them easier to distinguish from files for quick
visual grepping.

This can also be used in projects by setting the FileDialog "folder"
color. The default value (`Color(1, 1, 1)`) has no visual impact,
for compatibility with existing projects.
2019-08-20 00:10:27 +02:00
Michael Alexsander Silva Dias 2fa32d69a5 Keep syntax highlighting on TextEdit in readonly mode 2019-08-18 14:00:12 -03:00
Hugo Locurcio 108f9646f5
Add an outline to box selection rectangles for better visibility
This also refactors selection box color definitions
to avoid repetition.
2019-08-15 22:27:32 +02:00
Michael Alexsander Silva Dias f8a986c094 Fix autocompletion widget having its text leak outside 2019-08-15 14:52:37 -03:00
Rémi Verschelde 6c607c3564
Merge pull request #31266 from IAmActuallyCthulhu/pr/remove-redundant-author-comments
Remove redundant author doc comments
2019-08-14 13:45:54 +02:00
Rémi Verschelde 1dae4c9e7f
Merge pull request #31267 from sparkart/fix_optionbutton_offset
Fix Offset with OptionButton Popup
2019-08-14 11:43:42 +02:00
Fabian 97167209cb Exposed set_as_minsize to gdscript 2019-08-14 16:09:55 +09:30
Rémi Verschelde f8574da2c2
Merge pull request #31338 from Calinou/reorganize-menus
Reorganize various menus for consistency and conciseness
2019-08-13 16:52:42 +02:00
Hugo Locurcio 9e1c23a353
Reorganize various menus for consistency and conciseness
- Clean up the recent scripts dialog to match the recent scenes dialog
- Add "..." at the end of shortcuts that cause a modal dialog to appear

This closes #31148.
2019-08-13 11:52:10 +02:00
Emmanuel Barroga 26c5bac428 Fix Right-Click Menu Deselecting Edits Content
Right-clicking a property to open the context menu deselects the text field. This causes the context menu to be useless because it doesn't have anything to edit.
2019-08-12 03:39:27 -07:00
IAmActuallyCthulhu 82b9557803
Remove redundant author doc comments 2019-08-12 04:26:38 -05:00
Emmanuel Barroga b97e198bdd Fix Offset with OptionButton Popup
Fixes the offset issue with the OptionButton's popup.
2019-08-12 00:13:02 -07:00
Fabian Stiewitz dcf65433f1 fix(Tree): get_meta condition
If an item in a Tree has never been selected, its metadata "__focus_rect"
is not set. If an unselected item is then edited (Tree::edit_selected()),
an error is thrown in console.
2019-08-11 16:55:01 +02:00
Rémi Verschelde 7bb2215ed0
Merge pull request #31213 from KoBeWi/explain_scenes
Replace ERR_EXPLAIN in scene/* code
2019-08-09 14:25:31 +02:00
Tomasz Chabora af5e0fff66 Remove ERR_EXPLAIN from scene/* code 2019-08-09 13:54:52 +02:00
Emmanuel Barroga 2e1b58c793 Fix Exponential Range Graphical Error
Fixes the Exponential Range Slider having a graphical error with less than 1 values.
2019-08-09 01:47:20 -07:00
Rémi Verschelde ba541bceca
Merge pull request #31077 from qarmin/coverity_bugs
Change some code proposed by Coverity and Cppcheck
2019-08-07 13:49:33 +02:00
qarmin e0b5b21863 Add some code changes/fixes proposed by Coverity and Clang Tidy 2019-08-07 12:54:30 +02:00
Ken Paulson deec700497 Implemented check_vadjust in CheckBox & CheckButton. It was exposed to the editor, but wasn't used. 2019-08-06 13:27:07 -04:00
Michael Alexsander Silva Dias 06a890f7a3 Update WindowDialog title when translation changes 2019-08-05 10:20:52 -03:00
Rémi Verschelde 2b983f9c74
Merge pull request #31075 from KoBeWi/right_for_acceptance
Accept also right-click event in LineEdit
2019-08-05 09:02:04 +02:00
Tomasz Chabora b65f6f7944 Accept also right-click event in LineEdit 2019-08-04 15:35:50 +02:00
Cameron Reikes c123a8c4f5 Same method when redrawing as when theme changed 2019-08-01 19:50:14 -07:00
Rémi Verschelde d66461e85a
Merge pull request #30972 from Chaosus/vs_copy_paste
Implement copy/paste in visual shaders
2019-07-31 11:56:01 +02:00
Chaosus f704506807 Implement copy/paste in visual shaders 2019-07-31 12:43:29 +03:00
Emmanuel Barroga 7db96e22dd Fix ProgressBar Wrong Value with Border
Closes: #30969

The FG rectangle of the progressbar is incorrect when dealing with a non-zero border. This issue stems from wrong order of operations when drawing the rectangle: int p = r * get_size().width - mp;
2019-07-30 21:47:11 -07:00
Tomás Antunes 606b56b5fb Increase color preset slots 2019-07-30 12:03:00 +01:00
Rémi Verschelde 961b9b30e3
Merge pull request #30932 from Dragoncraft89/master
Translate TabContainer titles, when inherited from node name
2019-07-29 22:41:07 +02:00
Florian Kothmeier 65101c9a20
Translate TabContainer titles, when inherited from node name 2019-07-29 19:07:56 +02:00
NilsIrl abceb74b49 Remove useless variable and line in OptionButton 2019-07-29 17:41:28 +02:00
NilsIrl dfecd62235 Change if to switch in OptionButton 2019-07-29 16:47:47 +02:00
Teto b1dbd114c4 Change cursor to multi-selection cursor when selecting text in RichTextLabel.
Fix for #27545 : returns 'CURSOR_IBEAM' shape when selection is clicked.
2019-07-29 16:22:54 +02:00
Rémi Verschelde f494d5f10b
Revert "Update Control margins when size is overridden by change to minsize" 2019-07-27 12:55:03 +02:00
Michael Alexsander Silva Dias e8fc875619 Small adjustments to tooltips in '(Editor)FileDialog' 2019-07-26 11:11:09 -03:00
Rémi Verschelde 4c74f50d1a
Merge pull request #30351 from bojidar-bg/30288-override-global-theme
Keep track of default theme and project custom default theme seperatelly
2019-07-25 14:54:27 +02:00
Rémi Verschelde 43238bb59a DirAccess: Drop compat get_next(bool *is_dir) which was hidden
Fixes this warning:
```
./core/os/dir_access.h:74:17: warning: 'virtual String DirAccess::get_next(bool*)' was hidden [-Woverloaded-virtual]
```

Part of #30790.
2019-07-25 11:09:57 +02:00
Rémi Verschelde d844e30614 Inspector: Make default float step configurable
Also allow lifting the decimal step formatting with a hint range step
of 0. A new `range_step_decimals()` is added for this to avoid breaking
compatibility on the general purpose `step_decimals()` (which still
returns 0 for an input step of 0).

Supersedes #25470.
Partial fix for #18251.
2019-07-23 17:31:38 +02:00
Rémi Verschelde d15cf7b672
Merge pull request #30576 from qarmin/lgtm_coverage
Changed some code reported by LGTM and Coverity
2019-07-20 12:00:13 +02:00
qarmin 6cbaf7662f Changed some code showed in LGTM and Coverage 2019-07-20 08:09:57 +02:00
Michael Alexsander Silva Dias d91346f720 Fix incorrect caret position when clicking a 'LineEdit' with a non-left alignment 2019-07-15 19:32:41 -03:00
Emmanuel Barroga 381faf83c3 Fix GraphNode immediately losing focus
Closes: #30243

GraphNode immediately loses focus, and gives focus to its parent.

This fix changes implementation so that it does not transfer focus to its parent after receiving focus. Instead, it will transfer focus when the "close button" is pressed.
2019-07-13 17:25:20 -07:00
Rémi Verschelde 34d7484039
Merge pull request #30455 from qarmin/const_reference
Pass by reference to const
2019-07-10 15:43:15 +02:00
qarmin 01cc7a996b Use reference to constant in functions 2019-07-10 11:54:12 +02:00
Shiqing 94d542042e Fix incorrect X position of line length guideline 2019-07-10 17:29:43 +08:00
Rémi Verschelde 9580c2b13e TreeItem: Rename new button disable method to set_button_disabled
Follow-up to #30408.

Also sync classref with current source.
2019-07-09 09:17:42 +02:00
Rémi Verschelde 2633efd55b
Merge pull request #28190 from griant/test
fix improper uncommenting behavior in TextEditor
2019-07-09 08:56:27 +02:00
Rémi Verschelde 24c462b974
Merge pull request #30443 from Calinou/improve-node-configuration-warnings
Improve the node configuration warning display
2019-07-09 08:31:20 +02:00
Hugo Locurcio ff7184c5cb
Improve the node configuration warning display
- Refer to properties explicitly when possible
- When multiple warnings are returned, always separate them by one
  blank line to make them easier to distinguish
- Improve grammar and formatting
2019-07-09 00:18:00 +02:00
Hugo Locurcio 28d3a6051c
Use base `Color()` constructors instead of `Color::html()`
This results in slightly smaller binaries (-17 KB for an editor binary)
as no strings need to be allocated.
2019-07-08 21:17:10 +02:00
Rémi Verschelde 3bfffcc568
Merge pull request #30408 from Meriipu/tree_buttondisable
TreeItem: Added a setter for the disabled-property of buttons
2019-07-08 08:35:04 +02:00
Rémi Verschelde af80182016
Merge pull request #30407 from qarmin/small_fixess
Fixes minor issues found by static analyzer
2019-07-08 08:16:50 +02:00
qarmin 9a77d748c0 Fixes minor issues found by static analyzer 2019-07-07 23:08:51 +02:00
Meriipu fe9ec58028 TreeItem: Added a setter for the disabled-property of buttons 2019-07-07 16:18:36 +02:00
Rémi Verschelde da1d5d89fd
Merge pull request #30371 from creikey/fix-30366
Give up finding item if started at beginning
2019-07-06 20:33:08 +02:00
Bojidar Marinov e222615e97
Fix editor remaining dimmed after certain actions
Fixes #30368
2019-07-06 17:37:40 +03:00
Cameron Reikes 597e6e1bd9 Give up finding item if started at beginning
When the current item is -1, then the loop will infinitely repeat,
constantly setting i to zero and never exiting.
2019-07-05 22:14:49 -07:00
geequlim 4afb31cd52 Fix light area position in the selected completion 2019-07-06 12:15:32 +08:00