525384d8cc
Merge pull request #20337 from aaronfranke/mono-pascal-gd
...
[Mono] Improvements to GD.cs: PascalCasing and real_t
2018-07-22 03:49:58 +02:00
7478649b2f
Merge pull request #20229 from aaronfranke/mono-warning-text
...
[Mono] Update about/warning text
2018-07-22 00:40:15 +02:00
174cf31d00
[Mono] Improvements to GD.cs: PascalCasing and real_t
...
[Mono] Improvements to GD.cs: PascalCasing and real_t
2018-07-21 16:40:46 -05:00
69530ef614
[Mono] Update about/warning text
...
I've removed the section about being unable to export games using C# - as you are now able to do this, as long as the export templates are installed. Also, I've made a few minor grammar tweaks.
2018-07-21 15:26:41 -05:00
03746da73f
Add editor highlight for type-safe lines
...
The line number is hightlighted to indicate that the line contains only
type-safe code.
2018-07-20 21:55:18 -03:00
a8c97eb094
Makes Mono bindings partial & adds GetNode<T>.
2018-07-20 13:55:13 +02:00
ee3c476c9a
Add Array and Dictionary wrapper classes to C#
2018-07-20 01:44:30 +02:00
7a4d593198
Fix bug with Basis.Transposed()
...
Fix bug where Basis.Transposed() incorrectly updated local basis, and
returned an unmodified copy. This also fixes Transform.Inverse().
2018-07-19 00:17:45 +01:00
a731bd5864
Merge pull request #20253 from neikeq/nobranchnameideasfeelsbadman
...
Make C# bindings generator ignore disabled classes
2018-07-18 21:20:34 +02:00
92c7fe422b
Make C# bindings generator ignore disabled classes
2018-07-18 21:15:41 +02:00
7c9f7452f4
Style: Format code with clang-format 6.0.1
2018-07-18 16:27:03 +02:00
39aabba0a9
Added path for Mono installed through Homebrew
...
On macOS, it is common to install packages like Mono through the third-party
package-manager Homebrew. This commit simply adds an additional path to
where Homebrew installs the Mono framework.
2018-07-10 00:29:05 +02:00
d4f860c768
Merge pull request #19231 from aaronfranke/mono-fposmod-to-mod
...
[Mono] Rename Fposmod to PosMod, fix output
2018-07-05 01:05:44 +02:00
02372bfdf7
Merge pull request #19872 from exts/export_signals
...
Mono: Fixes annotated signal loading in exported binaries
2018-07-04 21:30:49 +02:00
769f172602
Merge pull request #19756 from NathanWarden/mono_lerp_fixes
...
[C#] Lerp now consistent with Godot API. InverseLerp fixed.
2018-07-04 21:23:50 +02:00
33fd0f762d
Mono: Fix build script not decoding process utf-8 output
2018-07-04 16:07:52 +02:00
489c9adf03
Mono: Fixes annotated signal loading in exported binaries
2018-07-03 22:12:27 -05:00
ac9e736b06
Merge pull request #16987 from neikeq/pending-exceptions
...
Mono: Pending exceptions and cleanup
2018-07-04 03:45:10 +02:00
4739cb8c00
Mono: Pending exceptions and cleanup
2018-07-04 03:08:29 +02:00
88b89c2084
Changes to default C# script template ( #19940 )
2018-07-04 03:00:07 +02:00
0705eb904a
Merge pull request #19251 from YeldhamDev/script_templates_changes
...
Small changes to the comments in the script templates
2018-07-03 16:48:03 +02:00
753230c275
convert unicode mono root path to ascii string
2018-06-30 08:58:41 +08:00
5b2b23c9a9
[Mono] Rename Fposmod to PosMod
...
[Mono] Rename Fposmod to PosMod
2018-06-27 00:58:24 -05:00
c2315e3291
Lerp now consistent with Godot API. InverseLerp fixed.
2018-06-24 17:52:17 -05:00
25275de50e
Merge pull request #19016 from neikeq/w
...
Mono: Module build improvements
2018-06-22 19:18:15 +02:00
ec6416d2b6
Mono: Module build improvements
...
- Add (Csc/Vbc/Fsc)ToolExe environment variables when running Mono's MSBuild.
- Fix directory for the 'mono_assemblies_output_dir' argument being created with the '#' top level directory token as part of its name.
- Allow to build with 'mono_static=yes' on Unix without specifying a mono prefix. The build script will try to find the mono prefix using the output from pkg-config.
2018-06-22 19:14:58 +02:00
fd17b960e9
Small changes to the comments in the script templates.
2018-06-11 02:04:51 -03:00
17516822f9
allow undefined GODOT_DEBUG_MSBUILD environment variable
2018-06-06 22:31:54 +08:00
b4f66e04e8
Merge pull request #19387 from neikeq/y
...
Mono fixes and improvements
2018-06-05 22:28:46 +02:00
4a021fa7a2
Mono: Add 'View log' button to open the MSBuild log of a build
2018-06-05 22:21:52 +02:00
25f10b3c40
Mono: Fix passing wrong logger assembly path to MSBuild
...
- Add option to print MSBuild's stdout and stderr instead of redirecting it. This can be enabled by setting the environment variable: Godot_DEBUG_MSBUILD=1
2018-06-05 22:18:43 +02:00
7933a6cc9f
Mono: Null checks when marshaling from MonoArray* and managed Dictionary
2018-06-05 22:14:32 +02:00
6e32a2886f
Merge pull request #18792 from PJB3005/18-05-11-objectdb-verbose-mono
...
Fixes ObjectDB leak printout with mono.
2018-06-05 10:03:11 +02:00
f2d669f5d3
Fix Mono static linking on Mingw
2018-06-01 21:46:46 +02:00
3334209a73
SCons: Pass env to modules can_build method
...
This allows to disable modules based on the environment,
in particular `env[tools]` which tells us if we are
building the editor or not.
2018-05-30 19:11:36 +02:00
8e35d937a9
New sync keywords in GDScript, NativeScript, Mono
2018-05-29 20:26:41 +02:00
1400f6fdc4
Refactor RPCMode enum and checks
2018-05-29 20:26:41 +02:00
4c69a495c9
Revert "RPCMode refactor, more sync modes"
2018-05-29 11:47:52 +02:00
d0b62ce155
Merge pull request #19021 from Faless/rpc_sync_fix
...
RPCMode refactor, more sync modes
2018-05-29 09:44:03 +02:00
97fb999976
Mono: Fix MonoImage filename being set to an invalid path
2018-05-27 17:15:41 +02:00
a5e8a3be5e
New sync keywords in GDScript, NativeScript, Mono
2018-05-26 10:49:33 +02:00
9de4ffde61
Refactor RPCMode enum and checks
2018-05-26 10:43:43 +02:00
a830e633a2
Merge pull request #19074 from cart/optimize-mono-pool-marshal
...
Reduce allocations when converting mono arrays to pool arrays
2018-05-25 11:04:16 +02:00
17faf11119
Merge pull request #19063 from KellyThomas/c-sharp-feature-parity-vectors
...
mono: Add Slerp method to vector classes, expose Cross method for Vector2
2018-05-25 09:44:03 +02:00
64c903580e
Merge pull request #19149 from neikeq/x
...
Mono: Improve 'script class not found' error
2018-05-24 20:38:18 +02:00
c8945fe7d8
Mono: Improve 'script class not found' error
...
No longer printed when using using placeholder script instances (for non-tool scripts in the editor).
Print different error if the project assembly is not loaded
2018-05-24 20:16:23 +02:00
4e257293d9
Capitalized comments of methods created by the Connect Signal dialog.
2018-05-23 18:11:00 -03:00
b335274bcd
mono: add Slerp method to vector classes, expose Cross method for Vector2, and fix unnecessary casts in Basis
2018-05-22 08:27:49 +08:00
c7e98eef67
Fix index out of range error in string.Extension()
2018-05-21 18:48:53 +08:00
56262ceafe
Reduce allocations when converting mono arrays to pool arrays
2018-05-20 18:18:06 -07:00
228b09bafb
Merge pull request #18974 from KellyThomas/c-sharp-feature-parity-basis
...
Mono: Basis constructor for euler parameter
2018-05-18 21:09:57 +02:00
fc90f41f53
Merge pull request #18975 from KellyThomas/c-sharp-feature-parity-color
...
mono: New Color methods: Darkened, Lightened and ToRgba32
2018-05-18 20:09:01 +02:00
16e1b4bacf
mono: Plane, expose Normal, and D
2018-05-17 23:04:20 +08:00
88bd33f451
mono: New Color methods: Darkened, Lightened and ToRgba32
2018-05-17 21:41:19 +08:00
c26d30986a
Mono: Basis constructor for euler parameter
2018-05-17 21:31:14 +08:00
6c74f3de6d
fixes build error on Linux after its introduction in #18949
...
The function expects now a return value. Returning NULL seems to work in
this case.
2018-05-17 11:34:05 +02:00
c3510cd981
Merge pull request #18949 from neikeq/alo
...
Mono: Project building fixes
2018-05-17 08:33:54 +02:00
01397a10d9
Mono: Project building fixes
...
- Set (Csc/Vbc/Fsc)ToolExe environment variables to point to the batch files in Mono's bin directory when building with Mono's MSBuild.
- Set Mono's MSBuild as the default build tool on Windows.
- Generate projects with portable DebugType instead of full.
2018-05-17 01:26:23 +02:00
41f79a6f14
Merge pull request #18889 from madadam/async-await-fix
...
Set current SynchronizationContext before the game loop starts
2018-05-16 23:44:55 +02:00
35024d4e7b
Add missing copyright headers
2018-05-16 14:50:44 -03:00
d315b0fb8a
added get_creation_time function for gdscript
2018-05-16 00:50:57 +02:00
005b69cf6e
-New inspector.
...
-Changed UI resizing code, gained huge amount of speed.
-Reorganized timer sync to clean up behavior (sorry forgot commit this before)
-
2018-05-15 17:14:31 -03:00
f25240cfe6
Set current SynchronizationContext before the game loop starts
...
This fixes the problem that `SynchronizationContext.Current` would be null
during the call to `_EnterTree`, `_Ready` and the first call to `_Process` thus
the task continuations would be scheduled outside the main thread, which is unexpected and might lead to crashes.
With this change, task continuations are scheduled always on the main thread and so async/await can be used without any explicit synchronization, which is what is expected.
Fixes #18849
2018-05-15 15:09:40 +02:00
27d70924a0
Fixes ObjectDB leak printout with mono.
...
Fixes #18767
2018-05-11 13:50:56 +02:00
a6bd2c6e72
round / ceil methods for c sharp vectors
2018-05-04 20:17:10 +08:00
ffb6f8f1ca
Merge pull request #18406 from YeldhamDev/script_templates_period
...
Changed periods in the script templates
2018-05-04 11:20:16 +02:00
a02fec47a0
Merge pull request #18562 from neikeq/issue-18526
...
Fix MSVC check when building with mono
2018-05-02 18:24:57 +02:00
093b069bf6
Changed periods in the script templates.
2018-05-02 11:42:09 -03:00
a1aa98e05a
Fix MSVC check when building with mono
2018-05-02 15:19:02 +02:00
c0192e405d
Merge pull request #18561 from neikeq/fix-find-msbuild-2
...
Fix editor detecting msbuild with a msvc 'tools only' install
2018-05-02 15:13:44 +02:00
93d13bee8b
Fix editor detecting msbuild with a msvc 'tools only' install
2018-05-02 15:06:25 +02:00
0ec912a79e
Fix msbuild with a msvc 'tools only' install
...
Taken from https://github.com/Microsoft/vswhere/wiki/Find-MSBuild
without '-products *' vswhere does not locate msbuild when installing a
tools-only (no IDE) version of the microsoft compilers.
2018-04-30 12:52:18 +02:00
ce4451b45f
assembly_load_hook fallback for registering GDMonoAssemblies.
...
Fixes #18029 .
There are ways to load assemblies that the search hook has no way of intercepting,
and handling itself. Such as loading from a byte[] in C# code.
We now handle these cases with a fallback assembly_load_hook,
to avoid crashes when this is indeed done.
2018-04-29 16:32:30 +02:00
fbc808012f
Mono: BindingsGenerator enum fixes
...
- Make enums have an unique signature name of int. This means that when generating internal methods, there is no difference between different enums types nor between enums and int. This way enums can re-use internal methods.
- Make type resolver fallback to int if a type is not found and it's an enum.
2018-04-28 22:25:25 +02:00
b5e6e142ef
Add option to link mono statically on Windows
2018-04-25 21:15:35 +02:00
6faa96fb89
Merge pull request #18399 from neikeq/u
...
Mono fixes
2018-04-24 20:58:25 +02:00
ff7fe9e771
Mono: Fix '!t' error messages when generating bindings
...
This error wasn't affecting the bindings generation process.
2018-04-24 20:47:06 +02:00
f8ce412560
Mono: Do not spam script class not found error
...
Print this error only when trying to instantiate the script. This way we prevent errors being printed for source files which are not meant to be used as scripts.
2018-04-24 20:46:57 +02:00
89e84185e8
Mono: Fix crash on script load if the scripts domain isn't loaded
2018-04-24 20:46:53 +02:00
6b611e6431
#18051 : Fix indentation issues introduced during clean up
2018-04-17 07:53:27 +09:00
e59fad3924
#18051 : Do not use `var` in a for-loop, or where type is not obvious
2018-04-17 07:39:37 +09:00
94edd92248
#18051 : Use common name for Color type argument
2018-04-17 07:39:37 +09:00
f0bf5532fa
#18051 : Remove redundant verbatim prefixes
2018-04-17 07:39:37 +09:00
85787776a5
#18051 : Use default parameter value
2018-04-17 07:39:37 +09:00
b765c051cb
#18051 : Use array initializer when applicable
2018-04-17 07:39:37 +09:00
9097c71255
#18051 : Remove redundant parenthesis
2018-04-17 07:39:37 +09:00
93dd59d763
#18051 : Remove unnecessary variable assignments
2018-04-17 07:39:37 +09:00
fdfc478c88
#18051 : Use 'var' when applicable
2018-04-17 07:39:37 +09:00
0ef3e0577b
#18051 : Remove redundant casts and 'using', 'else', 'this' statements
2018-04-17 07:39:37 +09:00
9e2e6bb1e2
Remove duplicated declaration of RoundToInt() from Mathf
2018-04-17 07:39:37 +09:00
e3590a2522
Merge pull request #18038 from Chaosus/mathf
...
[Mono] Improvements for Mathf
2018-04-13 22:22:28 +02:00
655a4e6540
[Mono] Improve Mathf
2018-04-13 20:15:49 +03:00
ea0e73f3c8
Merge pull request #17864 from NikodemL/fix_mono_bottom_panel_issue_activated
...
Fixed mono bottom panel to select the correct file when messages are filtered
2018-04-09 09:15:43 +02:00
95b499644e
Merge pull request #17834 from Rubonnek/move-to-initializer-list
...
Move GodotSharp and MonoBuildTab member variables to initializer list
2018-04-03 21:01:58 +02:00
5677aed175
[mono] Fixes #17936 as GodotSharp (Core\Basic.cs) requires C#7 now, but we most probably should keep C#6 yet
2018-04-03 09:48:03 +03:00
4fdee1d9f1
Fixed _issue_activated to take the correct issue id from the list
2018-03-30 16:32:14 +02:00
3f86fefb64
Move GodotSharp and MonoBuildTab member variables to initializer list
2018-03-27 21:14:52 -04:00
d52722c6da
Added wrap functions to C#
2018-03-26 14:33:09 +03:00
91f271fa9e
Fix mono basis GetEuler bug and marshalling/unmarshalling
2018-03-24 13:45:11 -07:00
a8d8c06753
Merge pull request #17134 from aaronfranke/master
...
[Mono] Replace float with real_t, other misc C# improvements
2018-03-24 21:10:41 +01:00
ff97c97c93
Replace float with real_t, default Vectors, other misc C# improvements
...
Replace float with real_t in most files, defined at the top of each file via using. Objects such as Vector3 now accept doubles as inputs, and convert to real_t internally. I've added default Vectors such as Vector3.Zero. Other misc C# improvements such as Mathf.RoundToInt(). Color continues to use float only because high precision is not needed for 8-bit color math and to keep things simple. Everything seems to compile and work fine, but testing is requested, as this is the first time I've ever contributed to Godot.
2018-03-22 21:53:21 -05:00
6a7f552c6f
Fix mono build properly!
...
Fixes the mistake I made in #17603 to make it require Python > 3.6.
2018-03-19 16:36:03 +01:00
4f97d5a7e2
Merge pull request #17603 from PJB3005/18-03-18-fix-mono-build-python3
...
Fix Mono builds with Python 3.
2018-03-19 09:53:23 +01:00
883afd1b4d
Merge pull request #17619 from neikeq/mono-runtime-main-args
...
Mono: Runtime main args and assembly search fixes
2018-03-18 23:16:44 +01:00
fa1d656af4
Mono: Runtime main args and assembly search fixes
...
- Setup runtime main args during initialization. This must be done manually by embedders who do not call mono_runtime_run_main. Fixes NullReferenceException in System.Environment.
- Continue to search the assembly in the rest of the search locations if loading it from one of them failed.
2018-03-18 23:07:04 +01:00
998f1977a8
Fix Mono builds with Python 3.
...
A subprocess call wasn't specifying an encoding,
so this gave a TypeError in Python 3.
2018-03-18 10:51:35 +01:00
389ad72399
Merge pull request #17179 from paulloz/mono-assemblies-preload-facades
...
[mono] add the 'Facades' subfolder to the searched directories
2018-03-16 21:40:42 +01:00
99c1323a08
Merge pull request #17388 from Hinsbart/mono_class_name
...
Mono: Avoid invalid class names.
2018-03-15 19:47:39 +01:00
700d07cf7c
Mono: Avoid invalid class names.
...
Disallow reserved keywords as class names and prefix base class with the Godot
namespace if it's the same as the class name.
Fixes #12483
2018-03-15 19:25:06 +01:00
ef5672d3f9
[mono] write classes with no constructor as abstract
2018-03-04 15:37:39 +01:00
d7020aef8d
[mono] rename functions to conform to PascalCase
...
in:
* StringExtensions.cs
* Transform.cs
2018-03-04 15:37:29 +01:00
22606a7bec
[mono] add the 'Facades' subfolder to the searched directories in _preload_hook
2018-03-02 13:38:29 +01:00
c094e90b25
More reliably find mscorlib.dll on Linux
2018-02-27 21:52:24 +01:00
3fa77b3172
doc: Remove status from hardcoded version string
...
It has no practical use case and just generates noise for each alpha, beta, etc.
2018-02-27 13:40:49 +01:00
a6d4438fab
Merge pull request #17075 from paulloz/fix-build-mono-debug-notools
...
[mono] fix build error when compiling with mono, tools=no, target=debug
2018-02-27 11:24:54 +01:00
75c7e66c5e
Merge pull request #15641 from neikeq/mono-is-picky-regarding-corlib-so-we-must-make-sure-to-ship-the-right-version-otherwise-something-bad-may-happen
...
Mono: Buildsystem improvements
2018-02-27 11:08:17 +01:00
90a705d671
fix build error when compiling with mono, tools=no, target=release
...
change TTR to RTR in `print_unhandled_exception`
2018-02-27 10:36:58 +01:00
1bd0fd90cc
Merge pull request #17046 from NathanWarden/fixed_mono_marshalling
...
[Mono] The marshalling *in* of Transform was also incorrect.
2018-02-26 22:42:31 +01:00
60daa9d718
The marshalling in was also incorrect.
2018-02-26 10:01:21 -05:00
f37090ccf4
Mono: Better versioning and gracefully unloading of Godot API assemblies
2018-02-25 20:56:27 +01:00
08584b7e22
Merge pull request #16804 from Valentactive/fix_mono_template_compiling
...
fix template builds with mono
2018-02-25 10:11:10 +01:00
3647ebc834
Merge pull request #16981 from paulloz/mono-nested-exceptions
...
[mono] show whole trace of nested exceptions
2018-02-24 21:44:33 +01:00
89af6c2cd7
[mono] get stacktraces for all inner exceptions
2018-02-24 21:18:06 +01:00
71602c7491
Merge pull request #16986 from neikeq/issue-16983
...
Mono: Fix bindings for parameters in vararg methods
2018-02-24 20:06:41 +01:00
0c82858121
Mono: Fix bindings for parameters in vararg methods
2018-02-24 20:03:16 +01:00
3c7d9001bc
fix release builds with mono
...
"_signals" and "signals_invalidated" were moved out of the
"TOOLS_ENABLED" directive. Updated also the two "update_signals" and
"_update_signals" methods so it makes sense.
2018-02-22 21:23:47 +01:00
9fd606c549
Mono: Add project export plugin
2018-02-22 13:39:41 +01:00
24cf4fe062
Update warning about C# support
2018-02-21 22:47:44 +01:00
7a72395412
[mono] fix signals parameter retrieval
2018-02-21 12:50:05 +01:00
72fe70272d
[Mono] Fixed "expression did not evaluate to a constant" compiler error for visual studio.
2018-02-20 00:24:52 -05:00
3c7a39b40c
doc: Update version string in header
2018-02-19 10:46:33 +01:00
6e200b1fe0
Merge pull request #16326 from NathanWarden/fix_basis_mono
...
[Mono] Basis values now marshalled in the correct order.
2018-02-18 19:54:53 +01:00
dad47d8876
Merge pull request #16749 from PJB3005/18-02-16-project-manager-mono-debug-fix
...
Makes project manager never initialize mono debug.
2018-02-18 19:53:46 +01:00
e380a98109
Merge pull request #16746 from PJB3005/18-02-16-fix-nodepath-pascalcase
...
Makes NodePath and RID follow PascalCase in C#.
2018-02-18 19:51:33 +01:00
f4dcfa38f7
Merge pull request #16747 from PJB3005/18-02-16-nodepath-tostring
...
Give C# NodePath a ToString().
2018-02-18 19:50:45 +01:00
2d0c07bd5a
Merge pull request #16770 from paulloz/csharp-signal-attribute
...
C# Signal attribute
2018-02-17 20:14:39 +01:00
cfbd7fd21e
implement signal related methods in csharp_script so signals can be used with emit
2018-02-17 19:37:02 +01:00
efd52cd172
add a [Signal] attribute to CSharpScripts
2018-02-17 19:29:26 +01:00
8bd05f0c71
Mono: Fix build status icons
2018-02-17 18:12:00 +01:00
1099838079
Makes project manager never initialize mono debug.
...
The heuristic whether we're in the project manager inside GDMono
didn't work if the project manager was launched by not having any path
to run.
This is fixed now by making a Main::is_project_manager().
2018-02-16 16:15:35 +01:00
b1a81374d4
Makes NodePath and RID follow PascalCase in C#.
...
Fixes #15685
2018-02-16 14:09:20 +01:00
3c1f8efd9e
Give C# NodePath a ToString().
...
It already had an implicit cast operator to string,
but this doesn't get used in say string formatting.
So now something like $"path: {GetPath()}" works.
2018-02-16 14:07:19 +01:00
2eb7a321ba
Merge pull request #15574 from paulloz/mono-build-project-button
...
Change 'Build Project' button style in Mono panel
2018-02-14 16:41:25 +01:00
3493c5a337
Merge pull request #16331 from Benjamin-Dobell/pull/fix-pkgconfig-mono
...
Fixed Mono builds on macOS (pkgconfig detection of mono)
2018-02-14 15:41:55 +01:00
70d281b946
Add and use mono build variables with cloned environment.
2018-02-10 20:48:46 -07:00
0cc4de1f24
[Mono] Basis values now marshalled in the correct order.
2018-02-02 16:45:30 -05:00
5920bc6f72
Fix pkgconfig detection of mono
2018-02-03 05:17:53 +11:00
08d4bfacaf
Fix inconsistencies and typos in argument names
2018-02-01 16:47:20 +01:00
2459eebc1d
Merge pull request #16258 from NathanWarden/fix_mono_decimals_method
...
[Mono] Fix an infinite recursion in the Mathf.Decimals method when using floats.
2018-02-01 15:39:51 +01:00
c460e38bf3
Merge pull request #16205 from neikeq/issue-15053
...
Mono: Remove automatic script multilevel calls
2018-02-01 14:51:12 +01:00
Ignacio Etcheverry
Rémi Verschelde
Aaron Franke
George Marques
Pieter-Jan Briers
Ignacio Etcheverry
oisincar
Mads Ynddal
=
Kelly Thomas
Max Hilbrunner
Nathan Warden
Michael Alexsander Silva Dias
Hein-Pieter van Braam
Fabio Alessandrelli
Carter Anderson
Michele Valente
Guilherme Felipe
Daniele Giuliani
Juan Linietsky
Adam Cigánek
Xavier Cho
Chaosus
Alexander Alekseev
Nikodem Lokatelj
Wilson E. Alvarez
Andreas Haas
Paul Joannon
Jonathan Tinkham
Benjamin Dobell
Paolo Perkovic