Commit Graph

12337 Commits

Author SHA1 Message Date
Rémi Verschelde
0f72c77cd4
Merge pull request #70788 from ZangEldor/empty_frame_name_fix
Fixed SpriteFrame allowed entering an empty name
2023-02-17 15:30:44 +01:00
Eldor Zang
62976659b8
Set default name if SpriteFrames name is empty 2023-02-17 15:29:07 +01:00
Rémi Verschelde
7c7ba88d19
Merge pull request #66121 from Zylann/plugin_handles_edit_object_argument
Change `_can_handle` and `_edit` virtual methods to take `Object*`
2023-02-17 15:19:12 +01:00
Yuri Sizov
37cd20b38d
Merge pull request #73220 from Mickeon/renames-more-like-retype
Tweak comments in `renames_map_3_to_4` & reorder
2023-02-17 16:41:12 +03:00
Yuri Sizov
47e030251f
Merge pull request #73381 from KoBeWi/works_better_than_expected_huh
Fold resources when non-main inspector exits tree
2023-02-17 16:25:18 +03:00
Marc Gilleron
d2b4e30058
Change _can_handle and _edit virtual methods to take Object* 2023-02-17 14:10:38 +01:00
Rémi Verschelde
f0c9ed4b55
Merge pull request #71475 from Maran23/4-x-theme-outline-affects-editor
Fix custom theme outline settings affects the editor theme as well
2023-02-17 14:07:22 +01:00
Rémi Verschelde
b2584629c8
Merge pull request #73195 from timothyqiu/weblate-comments
Improvements and fixes based on Weblate comments
2023-02-17 09:55:39 +01:00
Rémi Verschelde
3a7cb4a1e0
Merge pull request #68083 from atngames/master
Added a signal connection to update buses editor on "bus_layout_changed"
2023-02-17 09:50:01 +01:00
Rémi Verschelde
2824774d29
Merge pull request #69801 from nongvantinh/fix-invalid-scene-name
Fixed scene name can be saved as extension only
2023-02-17 00:35:00 +01:00
Rémi Verschelde
2aaa6f6728
Merge pull request #69810 from trollodel/scene_importer_material_crash_fix
Ensure that generated import IDs are unique
2023-02-17 00:34:14 +01:00
Nong Van Tinh
010ddfbc16
Prevent saving files with no name and only an extension.
Fixes #69768.

Co-authored-by: Rémi Verschelde <rverschelde@gmail.com>
2023-02-17 00:23:15 +01:00
rsjtdrjgfuzkfg
331dd33009 Theme Editor: fix leading styleboxes / main styles
Recent changes in Godot cause the theme editor to become hidden when
editing a child resource. This causes a crash when editing style box
resources marked as "main styles" (= leading styleboxes in the code), as
they try to reference the currently edited theme.

This commit works around the issue by permitting the Theme Editor to
keep a reference to the most recently edited Theme. Furthermore, it adds
an assertion to avoid a similar crash in the future.

Long-term, the workaround should probably be removed when the theme editor
is fixed to remain visible while editing child resources, but I'd keep
the assertion.
2023-02-16 20:41:51 +01:00
Rémi Verschelde
d768be4199
Merge pull request #73447 from KoBeWi/3early5me
Fix wrong font in Event Configuration
2023-02-16 18:34:55 +01:00
Rémi Verschelde
57419dcd88
Merge pull request #73440 from aXu-AP/code-editor-toggle-comment-fix
Fix toggle comment not moving caret
2023-02-16 18:34:51 +01:00
kobewi
be03c79001 Fix wrong font in Event Configuration 2023-02-16 18:19:28 +01:00
aXu-AP
d188068caa Fix toggle comment not moving caret
Fix regression if caret is at the beginning of the line and comment is toggled.
2023-02-16 16:17:24 +02:00
Rémi Verschelde
9f07643c8c
Merge pull request #73361 from akien-mga/your-ints-aint-gonna-increment-themselves
EditorProperty: Fix missing increment buttons for integers
2023-02-16 11:01:52 +01:00
Rémi Verschelde
373cbbe7b2
Merge pull request #73375 from KoBeWi/save_us_all_from_crash
Fix Save All trying to save empty scene paths
2023-02-16 11:01:48 +01:00
Rémi Verschelde
e178042866
Merge pull request #73370 from timothyqiu/tiles-i18n
Add missing i18n in tiles editor
2023-02-16 11:01:43 +01:00
Rémi Verschelde
02ca6689c4
Merge pull request #73369 from SaracenOne/animation_length_read_only
Make animation length control respect read-only rules.
2023-02-16 11:01:38 +01:00
Rémi Verschelde
366b4094ec
Merge pull request #73350 from SaracenOne/node_pointer_revert_fix
Fixes revert button on exported node properties on inherited nodes
2023-02-16 11:00:24 +01:00
kobewi
7aa3651e2b Fold resources when non-main inspector exits tree 2023-02-15 18:20:55 +01:00
kobewi
f579c0a79f Fix Save All trying to save empty scene paths 2023-02-15 17:29:52 +01:00
SaracenOne
919df3ac0e Make animation length control respect read-only rules. 2023-02-15 15:13:50 +00:00
Haoyu Qiu
ccc3bdebb3 Add missing i18n in tiles editor 2023-02-15 23:08:03 +08:00
Rémi Verschelde
840675ee07
EditorProperty: Fix missing increment buttons for integers
Fixes #73192.
2023-02-15 15:26:46 +01:00
SaracenOne
6696a0790c Fixes revert button on exported node properties on inherited nodes. 2023-02-15 11:40:00 +00:00
Rémi Verschelde
088d227812
Merge pull request #73340 from TokageItLab/diamond-audio
Fix display for no-length audio stream keys
2023-02-15 09:51:58 +01:00
Silc Renew
d5e662af73 Fix display for no-length audio stream keys 2023-02-15 17:00:31 +09:00
Haoyu Qiu
0edd46e3fc Fix editor language dropdown incomplete in some locales 2023-02-15 08:59:11 +08:00
RedworkDE
1fb2b662e1 Fix texture_format/bptc export option 2023-02-14 13:51:42 +01:00
Rémi Verschelde
56d78c32f7
Merge pull request #68558 from dzil123/remove_duplicate_wireframe
Node3DEditorViewport - Remove duplicate wireframe check and cleanup
2023-02-14 13:36:52 +01:00
Rémi Verschelde
a1986729a5
Merge pull request #73277 from RandomShaper/fix_pck_errors
Reword misleading error messages in PCK export
2023-02-14 13:35:27 +01:00
Pedro J. Estébanez
cc9c43a631 Reword misleading error messages in PCK export 2023-02-14 12:04:31 +01:00
Rémi Verschelde
76876a7337
Merge pull request #73259 from KoBeWi/spaghetti_map
Fix some TileMap errors and crashes
2023-02-14 11:06:39 +01:00
Rémi Verschelde
bed1ebd527
Merge pull request #72259 from Paulb23/json-editing
Support editing JSON in ScriptEditor
2023-02-14 11:04:17 +01:00
Rémi Verschelde
bfe43f69b8
Merge pull request #67707 from Cykyrios/hide-private-prop-description-in-classdoc
Fix private properties appearing in custom class doc Property Descriptions
2023-02-14 11:03:50 +01:00
kobewi
be6d5bbba6 Fix some TileMap errors and crashes 2023-02-14 00:39:41 +01:00
Rémi Verschelde
853c36ca0b
Merge pull request #61411 from snailrhymer/tilemap-editor-scattering
Fix random placement behaviour in new TileMap Editor
2023-02-13 21:14:40 +01:00
Rémi Verschelde
49fd62c315
Merge pull request #67523 from zaevi/fix_ProjectManager_sorting
Fix sorting issue in Project Manager.
2023-02-13 21:07:58 +01:00
kobewi
0c71c443ef Fix corrupt undo after making sub-resources unique 2023-02-13 19:18:03 +01:00
Micky
e20b2f6c80 Tweak comments in renames_map_3_to_4 & reorder
Generally moves comments and some entries around, as well as fixing typos and miscellaneous inconsistencies.

To go more in detail on a few things:
- In comments, separate between class names and notes with "--";
- In comments, replace all "broke" with "-- Breaks"
- Moves `@GlobalScope` constants to its own group in `enum_renames`
- Move `{ "remove", "remove_at" },` underneath the Builtin Types methods.
- Move C#'s `AddNode3dGizmoPlugin` to where it should be, in alphabetical order.
- Give more details to some class renames.
- Comments out `remove` -> `remove_at`
2023-02-13 14:00:30 +01:00
Juan Linietsky
6cd587c8f4 Prevent recursive importing (hack)
Prevents recursion when importing files due to the ill nature of EditorProgress.
The progress dialog will have to be entirely rewritten after 4.0 is out due to it being a constant source of bugs.
In the meantime, this fixes the problem.

Fixes #53871. Supersedes #73159.
2023-02-13 11:54:32 +01:00
Haoyu Qiu
84aee17901 Improvements and fixes based on Weblate comments
* Description of `ui_text_submit` action should be "Submit Text" instead of "Text Submitted".
* Spell out "Animation" instead of using "Anim.".
* Treat "Max" as regular word instead of writing "Max.".
* Use generic "Set %s" for action name instead of a dedicated "Set target_position".
* Add translator comment for:
    * "Inclusive" and "Self" in the profiler.
    * Places where it needs the context about being an editor progress label.
    * "Duplicated Animation Name" since it's refering to the new name of a duplicated animation.
    * Disambiguation of "View Plane Transform", "Paste Selects" and "Display Normal".
* Fix wrong undo action name for renaming an input action.
* Fix missing end quote in a shader error message.
* In class reference:
    * Fix duplicated "if" in the description of `signf()`.
    * Fix mismatched example output in `String.operator %()`.
    * Fix typo in the description of `Decal.texture_emission`.
    * Unify description of `String.match()` and `StringName.match()`.
2023-02-13 15:22:18 +08:00
aXu-AP
bdfb10fb98 Rework code editor multiline operations
Fix bugs if 2 selections were on same line.
Fix bugs when selection ended at new line.
Make carets stay in place after operation and on undo.

Affects: delete lines, move lines, toggle comments, bookmarks and breakpoints.
2023-02-12 20:53:49 +02:00
MmAaXx500
aa9d2149e7 Round 2: Fix mesh library remove selected item menu option
Previous pr: #46435
Fixes: #45969
2023-02-12 11:39:55 +01:00
Haoyu Qiu
4e36fc9777 Add more property capitalizations
* glTF
* LODs (plural form of LOD)
* Skeleton modification algorithms: CCDIK and FABRIK
2023-02-12 15:25:39 +08:00
Rémi Verschelde
cb2e73d578
Merge pull request #73033 from akien-mga/gdscript-fix-gd4-renames-build
Clean up ProjectConverter3To4 architecture, move renames map to separate file
2023-02-11 22:05:38 +01:00
Rémi Verschelde
9f7744ee0e
Merge pull request #46435 from Hassan-A/MeshLibrary-RemoveItem-Fix
Fix mesh library remove selected item menu option
2023-02-11 22:04:25 +01:00
Rémi Verschelde
5ba53d0b36
Merge pull request #71740 from Jummit/dict-array-missing-types
Support signals and callables in exposed dictionaries
2023-02-11 22:04:02 +01:00
Rémi Verschelde
b601f7959b
Merge pull request #73106 from YuriSizov/editor-help-theming-2000
Improve EditorHelp theming and make font size settings work
2023-02-11 22:01:20 +01:00
Haz
189acbee60
Fix mesh library remove selected item menu option
Fixes #45969.
2023-02-11 21:40:50 +01:00
Ruthger Dijt
e2a87ec28b fix nullptr dereference in AnimationTimelineEdit 2023-02-11 20:30:11 +01:00
Yuri Sizov
dd6ac955c3 Increase default font sizes for EditorHelp 2023-02-11 20:09:57 +01:00
Yuri Sizov
0eb3b49c39 Make EditorHelp respect font size settings 2023-02-11 20:09:57 +01:00
Yuri Sizov
bbbcd77217 Make use of a theme cache in EditorHelp and ensure it's updated
- Migrates the existing cache to the standard theme cache struct
- Moves some parts of the codebase to use cache instead of ad-hoc fetching
- Adds hooks to editor settings previously missing from theme regeneration
2023-02-11 20:09:35 +01:00
Rémi Verschelde
44b41ded82
Merge pull request #73098 from YuriSizov/editor-dont-hide-plugins
Avoid cleaning up editor plugins when property list changes
2023-02-11 15:35:56 +01:00
Rémi Verschelde
ec55278415
Merge pull request #73092 from TokageItLab/ray-is-what
Remove WARNING "ray: index" for debug from SkeletonEditor
2023-02-11 14:38:42 +01:00
Rémi Verschelde
0e81e2a30f
Merge pull request #73091 from TokageItLab/fix-bezier-edit-button-update
Fix weird bezier edit button update timing in AnimationTrackEditor
2023-02-11 14:38:18 +01:00
Yuri Sizov
18d6c91e8e Avoid cleaning up editor plugins when property list changes
Also removes a usability hack from the Theme editor, as it doesn't work anymore,
and it confuses the Inspector.
2023-02-11 14:38:07 +01:00
Rémi Verschelde
7bcd9a1049
Merge pull request #73082 from aaronfranke/check-canvas-item
Check for CanvasItem instead of Control and Node2D
2023-02-11 14:35:54 +01:00
Silc Renew
46645a34e3 Remove WARNING "ray: index" for debug from SkeletonEditor 2023-02-11 20:53:01 +09:00
Silc Renew
4c5bd4cb0a Fix weird bezier edit button update timing in AnimationTrackEditor 2023-02-11 20:48:18 +09:00
Aaron Franke
be916233f9
Check for CanvasItem instead of Control and Node2D 2023-02-11 02:18:10 -06:00
heppocogne
78ea4b2f0c Fix code editor's ColorPicker issue
ColorPicker now supports color constants.
Modify code comments.
2023-02-11 00:14:14 +01:00
SnailRhymer
db8d308830
Fix random placement behaviour in new TileMap Editor
Fix a bug where scattering could be set to e.g. 0.9 but a tile would still always be placed, as the check rand > 0.9 would be run on every mouse movement until it was successful.
2023-02-10 19:08:03 +01:00
Rémi Verschelde
766bb88159
Merge pull request #71691 from hcoura/res-importer-gen-physics-mesh-only-when-needed
Fix SceneImportSettings perf issues
2023-02-10 18:46:00 +01:00
Rémi Verschelde
73c53cca81
Merge pull request #71054 from MarioLiebisch/fix-animationplayer-calltrack-strings
Properly stringify args for Call Method Tracks
2023-02-10 18:44:29 +01:00
Rémi Verschelde
e52a2e3864
Merge pull request #73042 from akien-mga/create-project-gl_compatibility-mobile
ProjectManager: Also set `gl_compatibility` for mobile override
2023-02-10 18:44:13 +01:00
Yuri Sizov
cd015d9ac9
Merge pull request #43111 from junkajii/master
New icons for ParallaxBackground & ParallaxLayer
2023-02-10 19:13:53 +03:00
Rémi Verschelde
ab56e79a6a
ProjectManager: Also set gl_compatibility for mobile override
It's a bit hacky as the choice mainly impacts the main setting, but there are
pre-existing overrides which supersede it. We should treat this checkbox as
the highest allowed rendering method, and replace the ones which would be
higher end (here replace `mobile` with the chosen `gl_compatibility`).
2023-02-10 15:45:52 +01:00
Rémi Verschelde
493e932c86
i18n: Sync translations with Weblate 2023-02-10 15:32:10 +01:00
Rémi Verschelde
fd55321da9
Merge pull request #73001 from SaracenOne/update_on_advanced_reimport
Emit reimport signal in reimport_file_with_custom_parameters method
2023-02-10 15:07:07 +01:00
Rémi Verschelde
44d5d4e3cd
Merge pull request #73007 from KoBeWi/typos_be_like
Fix error spam when deselecting TileMap
2023-02-10 15:06:40 +01:00
Rémi Verschelde
bd09fcc3ca
Merge pull request #73034 from groud/fix_tilemap_pattern
Fix TileMap patterns creation
2023-02-10 15:06:35 +01:00
Rémi Verschelde
e19e6b09b9
Clean up ProjectConverter3To4 architecture, move renames map to separate file
This allows properly limiting what features depend on the RegEx module
(doing the actual conversion) and what features only require the renames
data (GDScript suggestions).

Also better excludes the conversion command line options when actually
disabling deprecated code.

Fixes #73029.
2023-02-10 14:35:22 +01:00
Gilles Roudière
89ccdc7d34 Fix TileMap patterns creation 2023-02-10 10:46:19 +01:00
Haoyu Qiu
26581ca574 Add some missing translatable editor strings 2023-02-10 16:55:50 +08:00
kobewi
f92392ce23 Fix error spam when deselecting TileMap 2023-02-10 01:07:48 +01:00
SaracenOne
27f8da7493 Emit reimport signal in reimport_file_with_custom_parameters
method to fix resources not updating when reimported from the
advanced import menu.
2023-02-09 22:26:52 +00:00
Rémi Verschelde
b12bf7ff02
Merge pull request #69550 from Rindbee/fix-script-editor-not-reload-via-lsp
Fix internal editor not updating when using external editor via LSP
2023-02-09 14:01:33 +01:00
Haoyu Qiu
a40ccc2d7e Improve some editor strings for localization 2023-02-09 19:32:02 +08:00
bruvzg
504ca3940c
[Bitmap Font] Fix character count check. 2023-02-08 13:51:19 +02:00
Rémi Verschelde
0e97806c1d
Merge pull request #72860 from RedworkDE/editor-export-plugin-bind
Bind `EditorExportPlugin::_get_export_features`
2023-02-08 09:37:40 +01:00
RedworkDE
2e167ca943 Bind EditorExportPlugin::_get_export_features 2023-02-07 23:14:20 +01:00
Rémi Verschelde
a05670c617
Merge pull request #70623 from timothyqiu/property-i18n
Separate property translation from editor translation, move sources to separate godot-editor-l10n repo
2023-02-07 19:38:29 +01:00
Rémi Verschelde
743e26d4f9
Merge pull request #72829 from Sauermann/fix-code-simplifications
Some code simplifications
2023-02-07 16:30:22 +01:00
Rémi Verschelde
097cf5431b
Keep only production ready translations, move the WIP ones to godot-editor-l10n
- Remove WIP translation templates, moved to godot-editor-l10n which
  will be the source and target for Weblate contributions.
  * https://github.com/godotengine/godot-editor-l10n
- Re-add translations with a high completion ratio, stripped of the
  untranslated and fuzzy strings, and of the location and translator
  comments, to keep the size lower.
  * Threshold editor interface: 20% complete.
  * Threshold properties: 20% complete.
  * Threshold classes: 10% complete.
2023-02-07 15:35:12 +01:00
Markus Sauermann
826e54fa73 Some code simplifications
1. `number_width` isn't used later
2. `return_type` is used only once
3. AudioServer::get_singleton()->get_channel_count() always returns a channel_count of 1 or larger
4. negative `aa->backward` conditional
5. `current_canvas` == `find_world_2d()->get_canvas()`
6. identical if `render_shadows`
2023-02-07 14:30:16 +01:00
Haoyu Qiu
5d7e003b29
Prepare for moving editor and classref translations to godot-editor-l10n repo
- Separate editor interface and property translations.
- Add property translation in TranslationServer.
- The split and merge of the POT/PO/Makefiles and extract scripts is done
  directly in godot-editor-l10n, the files will be removed in the next commit.
- Remove the hardcoded "to_include" lists from the SCsub, we'll only commit the
  files which are ready to inclue.
2023-02-07 14:20:40 +01:00
Rémi Verschelde
1cd66a76fc
Merge pull request #72827 from RandomShaper/fix_slow_step
Pace debugger draw requests
2023-02-07 14:08:15 +01:00
Pedro J. Estébanez
31a4a0002e Pace debugger draw requests 2023-02-07 12:10:28 +01:00
Rémi Verschelde
6a58f4e305
Merge pull request #72812 from salianifo/master
Fix AnimationEditor ignoring region of Sprite2D
2023-02-06 23:36:15 +01:00
Rémi Verschelde
f39eb330e9
Merge pull request #72741 from KoBeWi/connect!_but_where
Improve Connect Dialog navigation
2023-02-06 23:35:45 +01:00
kobewi
4b1d577b5c Improve Connect Dialog navigation 2023-02-06 22:56:41 +01:00
Salia Nifo
3154872177 Fix AnimationEditor ignoring region of Sprite2D 2023-02-06 16:56:11 -05:00
Rémi Verschelde
09b2c5fd05
Merge pull request #72552 from m4gr3d/cleanup_custom_build_main
Rename Godot's 'custom build' to 'gradle build' to better reflect the underlying build process
2023-02-06 22:50:22 +01:00
Rémi Verschelde
4fcb8bc472
Merge pull request #72805 from TokageItLab/fix-ap
Fix AnimationTrackEditor doesn't open when selecting AnimationPlayer node while another Editor is open
2023-02-06 22:49:58 +01:00
Yuri Sizov
de4369ca4b
Merge pull request #72708 from KoBeWi/PackedMultilineStringArray
Fix @export_multiline for PackedStringArray
2023-02-06 23:01:16 +03:00