Commit Graph

4741 Commits

Author SHA1 Message Date
Adam Scott ea33001b95 Add safety-checks before some servers `free()` 2022-12-29 16:23:38 -05:00
Markus Sauermann b736efa9c8 Use get_cursor_shape for identifying the cursor shape in TileSetAtlasSourceEditor
get_cursor_shape() is used in cases where a Control displays different cursors in different areas.
There is no need to set the default cursor shape on every mouse move event.

Was part of the reason for #58960.
2022-12-29 02:07:39 +01:00
mara 5380e685d8 Keep terrain choice when changing layer in tilemap editor
Make `TileMapEditorTerrainsPlugin::edit` logic analogous to
`TileMapEditorTilesPlugin::edit`, in that the selection is only
cleared when switching to another tilemap.

Closes #70033.
2022-12-26 21:45:06 +01:00
Yuri Rubinsky 952015df13 Add missing CUSTOM inputs for the spatial/vertex mode of visual shader 2022-12-26 14:09:07 +03:00
Haoyu Qiu 5c498f714d Fix error when dropping script into script editor 2022-12-26 14:34:37 +08:00
MrPhnix 272b8d9d17 CanvasItemEditor Fix snapping grid misalignment
Resolves: #70186
See: #65101
2022-12-24 12:02:48 +01:00
stmSi 350eda02cb Fix Editor Shortcut keys are inserting in Script Editor 2022-12-24 07:22:19 +06:30
Rémi Verschelde 8eec9f7d3c
Merge pull request #69797 from TokageItLab/time-edit-inspector-plugin
Animation: Add inspector plugin for key time edit & Change `track_find_key()` argument to find key with approximate
2022-12-23 09:07:15 +01:00
Rémi Verschelde 9b4888b7c9
Merge pull request #65312 from SaracenOne/auto_advance_behaviour
Make auto-advance flag a requirement for conditional/expression evaluation
2022-12-23 09:05:49 +01:00
Twarit Waikar 7ef09ea88f VCS: Fix split diff's overlapping fields
Also adjusts the spacing nearby the diff contents.
2022-12-23 02:20:01 +05:30
Silc Renew 060fb2d093 Add inspector plugin for key time edit & Change find key argument 2022-12-22 10:03:06 +09:00
Rémi Verschelde ff2bd057a5
Merge pull request #70353 from twaritwaikar/remove-vsc-project-path
VCS: Remove `project_path` VCS property, let plugins decide
2022-12-21 18:24:59 +01:00
Rémi Verschelde 4f3ec4121a
Merge pull request #70350 from Chaosus/stringname_operator
Add missing != operator to `StringName`
2022-12-21 09:21:32 +01:00
Rémi Verschelde 473656ef01
Merge pull request #70374 from twaritwaikar/add-confirm-dialog-discard-changes
VCS: Add a stern confirmation dialog before discarding all changes
2022-12-21 09:19:49 +01:00
Rémi Verschelde 7e7be45947
Merge pull request #67922 from MrBlockers/asr-addstream-fixes
Add optional stream argument to AudioStreamRandomizer.add_stream
2022-12-21 09:19:39 +01:00
Rémi Verschelde f04f53201d
Merge pull request #70317 from HolonProduction/svg_assets
Add support for svg images in the asset lib.
2022-12-21 09:19:14 +01:00
Twarit Waikar c940616b04 VCS: Remove method binds that are not being used in VersionControlEditorPlugin 2022-12-21 11:50:29 +05:30
MrBlockers 569ead5762 Add optional arguments to AudioStreamRandomizer
Adds stream and weight parameters to add_stream. By default, weight is
1.0f.
2022-12-20 18:48:02 -05:00
Twarit Waikar d18ed2c18a VCS: Add a stern confirmation dialog before discarding all changes 2022-12-21 03:21:33 +05:30
Twarit Waikar edef267d68 VCS: Remove `project_path` VCS property, let plugins decide 2022-12-20 21:01:24 +05:30
HolonProduction 66fa776667 Add support for svg images in the asset lib.
Pixel based image formats are identified by magic numbers. This is not possible with svg therefore svg parsing is tried and if it succeeded the result is used.

WebP and bmp support is added as well. But I could not test it as I am not able to run a local instance of the asset lib and there is no asset using those formats.
2022-12-20 15:41:17 +01:00
Yuri Rubinsky 522d4243bf Add missing != operator to `StringName` 2022-12-20 17:25:54 +03:00
Rémi Verschelde 281f548dc2
Merge pull request #70170 from TokageItLab/fix-anim-keying-crash
Make keys deselected when keying property for animation to avoid crash
2022-12-20 10:31:59 +01:00
Rémi Verschelde 44f0d455a7
Merge pull request #70100 from Chaosus/fix_missing_editor_plugin_gdclasses
Fix missing GDCLASS headers in the editor preview plugins
2022-12-19 17:11:34 +01:00
Rémi Verschelde fe1bb58e8f
Merge pull request #70238 from kleonc/tile-set-simplify-isometric-tile-polygon
`TileSet` Simplify isometric tile shape polygon to 4 vertices
2022-12-19 16:27:17 +01:00
Rémi Verschelde 5784c9801e
Merge pull request #70264 from KoBeWi/layedulate
Use layer's modulate for tile previews
2022-12-19 16:26:50 +01:00
kobewi 32b0770a73 Add a method to get global modulate 2022-12-19 11:51:37 +01:00
kleonc 3a34acdf55 TileSet Simplify tile shape polygons 2022-12-19 11:42:40 +01:00
kobewi 99a9401a2c Use layer's modulate for tile previews 2022-12-18 17:31:29 +01:00
Yuri Rubinsky 0fcf6a1c0c Prevent showing AudioStream preview for non-WAV types 2022-12-18 11:31:28 +03:00
smix8 34e7628f5f Fix Navigation API abbreviations inconsistency
Schema for navigation to name user facing API with  "navigation" without abbreviation and e.g. NavigationServer internals with abbr "nav".
2022-12-17 22:06:22 +01:00
Rémi Verschelde 70a0201e6a
Merge pull request #70074 from Chaosus/restore_audio_stream_editor
Restore `AudioStreamEditor` class to fix playable sound previews
2022-12-17 20:56:35 +01:00
Hugo Locurcio a3eac5fc7c
Move transparent background project setting to a subsection
This prevents the project setting from being located directly within
a root category, which is confusing from an UX perspective in the
project settings editor.
2022-12-17 18:45:21 +01:00
Silc 'Tokage' Renew aa133b60a1 Make keys deselected when keying property for animation to avoid crash 2022-12-17 06:48:22 +09:00
SaracenOne 092dbe52a9 Change auto_advance flag to advance_mode enum and unify with disabled flag.
Expressions and conditions now require auto mode to be set to auto.
Adds a toggle button to the state machine editor for whether new transitions
advance settings should default to auto mode or not.
2022-12-16 07:42:59 +00:00
Rémi Verschelde cda7df0255
Merge pull request #67024 from alessandrofama/fix-gdvirtual-call-node3dgizmo
EditorNode3DGizmoPlugin: Add GDVIRTUAL_CALL for get_gizmo_name and get_priority
2022-12-15 12:16:42 +01:00
Yuri Rubinsky b6ed3390ec Fix missing GDCLASS headers in the editor preview plugins 2022-12-15 13:11:23 +03:00
Yuri Rubinsky 1891f6e62c Restore `AudioStreamEditor` class 2022-12-15 10:59:44 +03:00
Rémi Verschelde 6b381d1d2d
Merge pull request #70040 from m4gr3d/update_navigation_controls_toggle_main
Update the visibility logic for the spatial editor navigation controls
2022-12-14 11:26:01 +01:00
Fredia Huya-Kouadio 3083455002 Update the visibility logic for the spatial editor navigation controls 2022-12-13 17:46:12 -08:00
Yaohua Xiong adeef12b12 Handle corner cases for curve baking
When control point and point have equal position,
the derivative is 0 vector, which cause error message in Basis::look_at().
This commit handles this case.
2022-12-14 08:52:14 +08:00
Rémi Verschelde ad7b31fe61
Merge pull request #69938 from timothyqiu/open-packed-scene
Add open scene button in Inspector for PackedScene resource
2022-12-14 00:16:54 +01:00
Rémi Verschelde 05aba48354
Merge pull request #70006 from timothyqiu/atlas-source-paint-scroll
Add scroll container for tile data editors
2022-12-13 10:12:53 +01:00
Rémi Verschelde a720a8c136
Merge pull request #69893 from henrlin24/hide-scattering
Hide Scattering label and controls within TileMap editor window when "Place Random Tile" option is disabled
2022-12-13 10:10:28 +01:00
Haoyu Qiu 4fcbfcc665 Add scroll container for tile data editors 2022-12-13 15:14:01 +08:00
Silc Renew b0eb3b6ebd Add null checks to AnimationTreeEditors and _clear_editors() 2022-12-13 03:06:51 +09:00
Rémi Verschelde e2a37295f5
Merge pull request #69291 from nongvantinh/fix-suggest-message
Fix Sprite drag and drop hint mentions invalid option with root node selected
2022-12-12 12:19:37 +01:00
Rémi Verschelde f1edd03d4c
Merge pull request #69718 from groud/finally_rename_gdnative_to_gdextension
Rename all gdnative occurences to gdextension
2022-12-12 11:43:59 +01:00
Rémi Verschelde f5d14f874a
Merge pull request #69300 from timothyqiu/tile-set-atlas-source
Improve TileSetAtlasSourceEditor UI
2022-12-12 11:41:59 +01:00
Gilles Roudière be1c9d677d Rename all gdnative occurences to gdextension
Non-exhaustive list of case-sensitive renames:

GDExtension -> GDNative
GDNATIVE -> GDEXTENSION
gdextension -> gdnative
ExtensionExtension ->Extension (for where there was GDNativeExtension)
EXTENSION_EXTENSION ->EXTENSION (for where there was GDNATIVE_EXTENSION)
gdnlib -> gdextension
gdn_interface -> gde_interface
gdni -> gde_interface
2022-12-12 11:04:57 +01:00
Markus Sauermann 9a8d53d54b Use _request_gizmo from SceneStringNames 2022-12-12 10:12:40 +01:00
Haoyu Qiu 9af9af525c Add open scene button in Inspector for PackedScene resource 2022-12-12 16:09:10 +08:00
henrlin24 afa38bd030 Hide Scattering label and controls within TileMap editor window when "Place Random Tile" is disabled 2022-12-11 13:16:36 -05:00
Haoyu Qiu f6ae2f2fd5 Use ObjectID as argument when referred-calling _request_gizmo
Fixes crash on project launch.
2022-12-10 18:52:10 +08:00
Haoyu Qiu 8a22d4cd44 Fix !tile_set.is_valid() error on startup 2022-12-10 13:09:20 +08:00
Haoyu Qiu d8f5dcbf56 Improve TileSetAtlasSourceEditor UI
* Updates the overall layout, moving mode buttons to the top.
* Uses inspector category instead of a Label to show what's being edited. This also allows better scrolling behavior.
2022-12-10 12:27:48 +08:00
Rémi Verschelde 9a26ffa233
Merge pull request #67283 from KoBeWi/one_way_ticket
Add one-way indicator to tile collision editor
2022-12-09 18:05:55 +01:00
Rémi Verschelde 43bef98450
Merge pull request #60892 from KoBeWi/fat_selection
Improve tile editor selection appearance
2022-12-09 18:05:38 +01:00
Rémi Verschelde 9ee47b3c45
Merge pull request #69747 from timothyqiu/tile-source-icons
Update tile source icons when editor theme changes
2022-12-09 18:05:23 +01:00
kobewi 871278cdf0 Improve tile editor selection appearance 2022-12-09 14:46:17 +01:00
Yuri Rubinsky a7027b9927 Fix changing of visual shader mode 2022-12-09 11:02:07 +03:00
Yuri Rubinsky 12ab5731ab
Merge pull request #69738 from Chaosus/vs_custom_nodes 2022-12-08 14:13:05 +03:00
Yuri Rubinsky ab17f197f0 Make custom visual shader nodes automatically updates from script 2022-12-08 12:55:23 +03:00
Haoyu Qiu af3ef844d9 Update tile source icons when editor theme changes 2022-12-08 17:21:37 +08:00
Rémi Verschelde 204715ae95
Merge pull request #69617 from MewPurPur/this-darn-pixel
Fix fringe issues with shortcuts not behaving as expected for multi-carets
2022-12-08 09:52:13 +01:00
VolTer 94416e41c5 Fix various fringe issues with multi-carets and selections 2022-12-07 20:54:48 +01:00
Rémi Verschelde 829d49b011
Merge pull request #69719 from groud/fix_gdextension_bad_vformat_error
Fix a wrong error formatting in gdextension export plugin
2022-12-07 13:28:02 +01:00
Rémi Verschelde f9bd2ace0b
Merge pull request #68682 from timothyqiu/camera-gizmo-size
Make Camera3D gizmo the same aspect ratio as its viewport
2022-12-07 13:25:35 +01:00
Rémi Verschelde de2d0f156e
Merge pull request #69713 from groud/rename_get_surrounding_tiles
Rename get_surrounding_tiles to get_surrounding_cells
2022-12-07 13:24:57 +01:00
Rémi Verschelde eb1734c95d
Merge pull request #67554 from Sauermann/fix-determining-window-in-scroll-container
Remove Screen-parameter for determining Touchscreen capability
2022-12-07 13:24:06 +01:00
Rémi Verschelde 04cd36612a
Merge pull request #69695 from timothyqiu/id-capitalization
Make ID capitalization in tiles editor consistent
2022-12-07 13:23:49 +01:00
Gilles Roudière 2b11fe1d63 Fix a wrong error formatting in gdextension export plugin 2022-12-07 13:22:49 +01:00
Gilles Roudière 3ea54bb3a1 Rename get_surrounding_tiles to get_surrounding_cells 2022-12-07 11:09:10 +01:00
Markus Sauermann e18107a57c Fix Determining Window for Touchscreen
DisplayServer::screen_is_touchscreen will likely never utilize its
parameter p_screen.
This PR replaces this function by DisplayServer::is_touchscreen_available()
with the same functionality.
This solves the problem, that a SubViewport was used for determining
the screen, which resulted in error messages.
2022-12-07 09:54:29 +01:00
Haoyu Qiu 740d6f9447 Fix crash when deleting an alternative-level tile proxy 2022-12-07 14:26:54 +08:00
Haoyu Qiu 9893b04fda Make ID capitalization in tiles editor consistent 2022-12-07 10:07:10 +08:00
Rémi Verschelde 74b245f2b5
Merge pull request #69643 from Chaosus/vcs_rendering_fix
Fix incorrect rendering of vcs dialogs
2022-12-06 12:25:01 +01:00
Rémi Verschelde 83b426bca5
Merge pull request #67906 from groud/simpler_gdextension_config
Remove unnecessary checks when exporting gdextension binaries and allow using a prefix to auto-detect files
2022-12-06 11:01:09 +01:00
Rémi Verschelde 75f8f22637
Merge pull request #69631 from timothyqiu/tile-proxy-rmb
Fix error when right clicking proxy list in TileProxiesManagerDialog
2022-12-06 11:00:42 +01:00
Yuri Rubinsky 4aee97e821 Fix incorrect rendering of vcs dialogs 2022-12-06 12:54:38 +03:00
Rémi Verschelde 53f2c8b206
Merge pull request #69608 from RumblingTurtle/blend-tree-new-node-fix
AnimationNodeBlendTreeEditor: Fix popup locations when creating nodes with dragging
2022-12-06 10:48:12 +01:00
Rémi Verschelde 14861c45b5
Merge pull request #68860 from xiongyaohua/path3d_fishbones
Draw fish bones for Path3D and Path2D in the Editor
2022-12-06 10:46:54 +01:00
Haoyu Qiu 7034992ace Fix error when right clicking proxy list in TileProxiesManagerDialog 2022-12-06 09:37:07 +08:00
Eduard Zalyaev ed53e96f43 AnimationNodeBlendTreeEditor: Fix popup locations when creating nodes with dragging
Fixes  #69413.
2022-12-05 21:03:38 +03:00
Rémi Verschelde 1db23e472b
Merge pull request #69525 from m4gr3d/polish_navigation_controls_opacity_main
Minor tweaks/polish to the navigation controls to prevent interference
2022-12-05 11:32:43 +01:00
Yaohua Xiong 9bdc0cb16f draw fish bones for Path2D and Path3D
These fish bones are add to indicate the direction and local transforms alone the path.
2022-12-05 15:39:14 +08:00
Silc Renew 8c540b1d71 Fix animation play backward doesn't process current key&animtrack seek 2022-12-05 15:59:08 +09:00
Rémi Verschelde 408bd0aa92
Merge pull request #68770 from TokageItLab/add-track-validator
Add track validator to AnimationPlayerEditor to detect tracks which have error
2022-12-05 00:06:06 +01:00
Rémi Verschelde 5efa254964
Merge pull request #67387 from NumbuhFour/cam_vis_layers_shader_var
Implement CAMERA_VISIBLE_LAYERS as built-in shader variable
2022-12-05 00:05:39 +01:00
Haoyu Qiu 480d9d10ed Fix heap-use-after-free when exiting editor after editing TileSet 2022-12-04 16:52:26 +08:00
NumbuhFour 1b09fd5410 Implement CAMERA_VISIBLE_LAYERS as built-in shader variable 2022-12-03 22:41:27 -08:00
Fredia Huya-Kouadio eacb29c007 Minor tweaks/polish to the navigation controls to prevent interference:
- Reduce controls size
- Enable opacity on hover to increase visibility
2022-12-02 23:17:38 -08:00
Fredia Huya-Kouadio 18b924def7 Enable the navigation controls for touchscreen by default 2022-12-02 20:47:32 -08:00
Gilles Roudière fa4143cdeb Allow specifying a prefix to automatically detect library files for gdextension exports 2022-12-01 18:20:40 +01:00
Rémi Verschelde 1e3919c409
Merge pull request #69364 from m4gr3d/add_navigation_controls_main
Add navigation control to the node3d editor viewport
2022-12-01 18:11:14 +01:00
Gilles Roudière 36bcb82565 Remove uncessecary checks when exporting gdextension binaries 2022-12-01 17:28:24 +01:00
Rémi Verschelde cd491c6e47
Merge pull request #69376 from zaevi/adjust_dropping_texture
Adjust position and size for dropping texture in canvas editor.
2022-11-30 10:49:15 +01:00
Zae a1419f3902 Adjust position and size for dropping texture. 2022-11-30 16:28:49 +08:00
Haoyu Qiu 6c5c773a27 Fix heap-use-after-free when changing alternative tile ID 2022-11-30 10:32:35 +08:00
Fredia Huya-Kouadio 1566f3d49f Add navigation control to the node3d editor viewport 2022-11-29 17:43:16 -08:00
Rémi Verschelde 3d2c3aae4e
Merge pull request #69062 from trollodel/lightweight_editor_mass
Use forward-declarations in big editor classes
2022-11-29 10:27:21 +01:00
trollodel c90d0bd84f Use forward-declarations in big editor classes 2022-11-29 09:59:43 +01:00
Haoyu Qiu 4a50f44cd2 Fix heap-use-after-free when removing a tile in TileSet editor 2022-11-29 09:22:35 +08:00
Silc Renew a4162dad23 Add track validator to AnimationPlayerEditor 2022-11-28 23:33:55 +09:00
Nong Van Tinh 6bec9759eb Fix incorrect hint when drag-and-drop asset into scene 2022-11-28 21:03:00 +07:00
Rémi Verschelde 2975fc9460
Merge pull request #69249 from timothyqiu/tile-data-redraw
Update TileSet preview when paint custom data changes
2022-11-28 11:02:57 +01:00
Rémi Verschelde 794adbe996
Merge pull request #69178 from aaronfranke/mesh-shape
Use a more specific type for Mesh create_(convex|trimesh)_shape
2022-11-28 08:05:50 +01:00
Haoyu Qiu 7bc0d0c177 Update TileSet preview when paint custom data changes 2022-11-27 18:35:47 +08:00
Rémi Verschelde 6e693368e1
Merge pull request #69124 from zaevi/tilemap_fix_alternative_tile
[TileMap] Fix alternative tile issues.
2022-11-25 19:27:37 +01:00
Aaron Franke 93ab82536d
Use a more specific type for Mesh create_(convex|trimesh)_shape 2022-11-25 11:43:11 -06:00
Fabio Alessandrelli aa80cfac97 [Editor] Add button to keep the debug server open.
The setting is stored in the project editor metadata, and the server is
automatically started/stopped when the option change (only stopped if no
session is currently active).

The CLI option `--debug-server` now also forces the server to stay open
(without saving the state, unlike the menu option).

This commit also removes the "Keep debugger open" option in the script
editor "debug" menu. That option was really confusing, it used to hide
the bottom panel if and only if the debugger pane was selected, so if
you had your output log open instead (default when pressing play) it
would effectively do nothing. Having an option to save a click in such
a very specific case seems very overkill.
2022-11-25 11:02:55 +01:00
Rémi Verschelde a16d3625c3
Merge pull request #69128 from Chaosus/vs_fix_custom_nodes
Fix custom visual shader nodes not being loaded at startup
2022-11-24 19:04:21 +01:00
Yuri Rubinsky a973ddd28d Fix custom visual shader nodes not being loaded at startup 2022-11-24 20:58:16 +03:00
kobewi 8a3d2f4e0c Cleanup remaining EditorUndoRedoManager usages 2022-11-24 18:56:22 +01:00
Zae f6424e68ea [TileMap] Fix alternative tile issues. 2022-11-25 00:44:02 +08:00
K. S. Ernest (iFire) Lee e0b296ae82 Avoid the Skeleton3DGizmoPlugin crash when clicking in the editor. 2022-11-23 07:09:49 -08:00
Rémi Verschelde 4b4e701e06
Merge pull request #68964 from MewPurPur/tweak-gradient-editor
Fixes and improvements to Gradient preview
2022-11-22 08:31:44 +01:00
VolTer 3c54d8752c Fix Gradient preview issues 2022-11-21 23:32:38 +01:00
Markus Sauermann 28af870750 Code simplifications found by cppcheck
They are based on:
- Boolean arithmetic simplifications
- setting variables that are not accessed
- constant variables
2022-11-21 08:43:36 +01:00
Marc Gilleron e0d2b7835d Allow selecting text in shader compilation logs 2022-11-20 19:15:39 +00:00
Rémi Verschelde 98da707df5
Merge pull request #68922 from TokageItLab/fix-animtree-crash
Fix `AnimationTreeEditor` crash & rename `AnimationTreeEditor::get_tree()` to `get_animation_tree()`
2022-11-20 17:49:23 +01:00
Silc Renew d595b27467 Fix AnimationTree crash & rename get_tree() to get_animation_tree() 2022-11-21 00:28:10 +09:00
Rémi Verschelde 855402dfee
Merge pull request #68904 from aaronfranke/texture-methods
Rename TextureButton set_*_texture methods to set_texture_*
2022-11-20 15:37:37 +01:00
Micky e791f4fce2 Double precision of `String.split_floats` 2022-11-20 12:29:50 +01:00
Rémi Verschelde 5b235e2e5e
Merge pull request #68859 from souplamp/capitalize-skeleton3d-editor-plugin
Capitalize Skeleton3D's editor plugin dropdown options
2022-11-20 11:35:38 +01:00
Aaron Franke f6714858bf
Rename TextureButton set_*_texture methods to set_texture_* 2022-11-19 17:33:40 -06:00
souplamp a3917039d1 capitalize skeleton3d plugin dropdown 2022-11-18 15:47:58 -06:00
Silc Renew 7f00fd4ff7 change root motion track candidating method 2022-11-18 17:49:34 +09:00
Rémi Verschelde 0b27173919
Fixup TileSet build after #66557
Last rebase was too old, didn't include this API rename.
2022-11-17 13:54:15 +01:00
Rémi Verschelde 2ca972ad01
Merge pull request #66557 from MisterMX/fix/tileset-custom-data-type-reload-editor
fix(tileset): Recreate custom data editor if type has changed
2022-11-17 13:49:02 +01:00
Rémi Verschelde 4829911df2
Merge pull request #64368 from YeldhamDev/tile_editor_label_center
Properly center labels in the TileMap/Set editors
2022-11-17 13:48:53 +01:00
Yuri Rubinsky 359d13cddc Fix the bounds of varying popup in visual shader editor 2022-11-16 22:05:09 +03:00
Rémi Verschelde 6d2a7cb46d
Merge pull request #68709 from MewPurPur/instance-begone-part3
Remove more instances of 'instance' being used as a verb
2022-11-16 14:41:42 +01:00
VolTer 3b4f5f8a04 Remove more instances of 'instance' being used as a verb 2022-11-16 14:01:53 +01:00
Haoyu Qiu 6c5dc78f59 Make Camera3D gizmo the same aspect ratio as its viewport 2022-11-15 17:31:53 +08:00
Rémi Verschelde 80dbcfd995
Merge pull request #68657 from Sauermann/fix-redundant-initialization
Remove redundant non-trivial Variant types initializations
2022-11-14 23:23:54 +01:00
Markus Sauermann 3b14f0334c Remove redundant Variant-types initializations 2022-11-14 19:35:19 +01:00
Rémi Verschelde 315c64282b
Fix misc formatting issues
Somehow I missed the failing CI report from trailing whitespace.

Fixed a couple typos found by codespell while at it, and misc
trailing semicolons in one of the files.
2022-11-14 19:00:48 +01:00
Rémi Verschelde 7dafe06e27
Merge pull request #68624 from AleCamara/bug-67235-gradient-slider
Fix clicking in gradient editor
2022-11-14 18:29:52 +01:00
Fabio Alessandrelli d568b25e36 [Editor] Better expose EditorDebuggerPlugin.
Now splitted into two classes:
- EditorDebuggerPlugin (RefCounted).
- EditorDebuggerSession (abstract).

This allows the EditorPlugin to be in control of the debugger plugin
lifecycle, be notified when sessions are created, and customize each of
them independently.

We should slowly transition the various profilers and captures in
ScriptEditorDebugger to their own plugins, and decouple
ScriptEditorDebugger from it's UI part (making it the "real"
EditorDebuggerSession potentially dropping the wrappers).
2022-11-14 14:55:22 +01:00
Ale Camara aebf3d9401 Fix clicking in gradient editor
- When double-clicking on the gradient we should open the colour picker and create a colour key.
- Instead, we were also evaluating the click further down producing the colour key to move around.
2022-11-14 13:29:21 +00:00
Michael Alexsander 02390693ce Properly center labels in the TileMap/Set editors 2022-11-12 21:35:07 -03:00
trollodel ba9e619b51 Use forward-declarations in EditorPlugin where possible 2022-11-11 20:25:51 +01:00
Rémi Verschelde b61fda9d2a
Merge pull request #68271 from paddy-exe/gdextension-library-loading-error
GDExtension: Improve error message for invalid library feature flags
2022-11-07 17:44:43 +01:00
Rémi Verschelde 2c8498c8a6
Merge pull request #68351 from Sauermann/fix-code-simplifications
Code simplifications
2022-11-07 10:01:37 +01:00
Rémi Verschelde 19d8e36c8e
Merge pull request #68331 from MewPurPur/gradient2d-better-preview
Fix GradientTexture2D's preview
2022-11-07 08:46:25 +01:00
Markus Sauermann 18978881fe Code simplifications
CanvasItemEditor:
- p_result == ADD_MOVE is always true in this switch-clause

- both parts of the if-else-clause do the same thing and simplified an affine_inverse call

ControlEditorToolbar:
- private function ControlEditorToolbar::_anchor_to_position is used nowhere. Looks like
copy and paste from CanvasItemEditor::_anchor_to_position

ScrollContainer:
- screen_is_touchscreen is always true, because otherwise the function already returned

TextLine:
- both parts of the if-else-clause do the same thing and simplified return statement
2022-11-07 01:21:25 +01:00
VolTer 3de53c8312 Fix jankiness when drawing GradientTexture2D 2022-11-06 22:14:54 +01:00
Rémi Verschelde 12b4a263ee
Merge pull request #67730 from KoBeWi/late_to_the_call
Add call_deferred() method to Callable
2022-11-06 15:55:43 +01:00
Rémi Verschelde 5dfa56474a
Merge pull request #68247 from akien-mga/emscripten-warnings-unuset-but-set
Fix -Wunused-but-set-variable warnings from Emscripten 3.1.20
2022-11-06 15:53:46 +01:00
Patrick f9458f9228 Improve error message for invalid library feature flags
Fixes https://github.com/godotengine/godot/issues/63227

My version for the error message is:
`No suitable library found. The libraries' tags referred to an invalid feature flag. Possible feature flags for your platform: %s`
2022-11-04 21:45:40 +01:00
clayjohn 3c1e5003ab Fix pathological corner case in drawing tileset editor
Interleaving draw_rect calls with and without a texture forces every rect to
have its own draw call. In this case it meant that there is a draw call for every single
tile in the atlas. This change makes it so the renderer can batch draw calls
which reduced the draw call count by a factor of 512
2022-11-04 13:04:20 -07:00
kobewi 1778301cd0 Add call_deferred() method to Callable 2022-11-04 17:24:34 +01:00
Rémi Verschelde f475c91081
Fix -Wunused-but-set-variable warnings from Emscripten 3.1.20 2022-11-04 11:36:13 +01:00
Markus Sauermann 69fca9286f Use get_cursor_shape for identifying the cursor shape in CanvasItemEditor
get_cursor_shape() is used in cases where a Control displays different cursors in different areas.
There is no need to set the default cursor shape on every mouse move event.
2022-11-03 19:34:43 +01:00
Ninni Pipping 4b29f71685 Fix incorrect drawing of alternative tiles 2022-11-03 16:17:36 +01:00
Zae b68b26b27e Fix reload scripts error after saving in external editor. 2022-11-03 17:06:51 +08:00
Rémi Verschelde 9ec7aadc06
Merge pull request #66017 from Mickeon/rename-image-copy-rect
Rename Image's `get_rect` to `get_region`
2022-11-02 22:36:57 +01:00
Rémi Verschelde f7c611ab71
Style: Misc docs and comment style and language fixes
- Removed empty paragraphs in XML.
- Consistently use bold style for "Example:", on a new line.
- Fix usage of `[code]` when hyperlinks could be used (`[member]`, `[constant]`).
- Fix invalid usage of backticks for inline code in BBCode.
- Fix some American/British English spelling inconsistencies.
- Other minor fixes spotted along the way, including typo fixes with codespell.
- Don't specify `@GlobalScope` for `enum` and `constant`.
2022-11-02 19:01:18 +01:00
kobewi 15831e381b Unify usage of undo_redo in editor 2022-11-02 17:51:58 +01:00
Rémi Verschelde 910cf9a9b3
Merge pull request #67810 from MrBlockers/reged-fixes
Fix multiple issues with region editor
2022-11-02 14:18:12 +01:00
Rémi Verschelde a8850434c2
Merge pull request #68147 from anvilfolk/fix-curve-multiline
Fix error in curve editor multiline string draw
2022-11-02 14:17:18 +01:00
Rémi Verschelde 50f742e1ca
Merge pull request #68107 from alfredbaudisch/drag-lower-case
Cast dragged file name extension to lowercase
2022-11-02 14:16:00 +01:00
Rémi Verschelde df26d11b5d
Merge pull request #68020 from timothyqiu/3d-drag-instance
Improve dragging scene into 3D viewport
2022-11-02 14:15:54 +01:00
ocean (they/them) 8871226e5c Fix error in curve editor multiline string draw 2022-11-01 22:28:03 -04:00
Micky ebf86c96e9 Rename Image's `get_rect` to `get_region`
Also renames its parameter to from "rect" to "region".
2022-11-01 23:35:48 +01:00
Alfred Reinold Baudisch 07e367cb0b Cast dragged file extension name to lowercase, closes #68104 2022-11-01 09:48:09 +01:00
Haoyu Qiu 2b8bcbe487 Fix error when adding 3D gizmo handles with IDs 2022-11-01 16:25:13 +08:00
Rémi Verschelde e22a1d8031
Merge pull request #68060 from dpalais/no-pointer-animationnode-blendtree-rename
Remove the usage of pointers in signal call, to fix #67941
2022-10-31 15:54:45 +01:00
Rémi Verschelde e47aa546cd
Merge pull request #68008 from timothyqiu/hide-axis
Hide axis gizmo after translating 3D nodes
2022-10-31 14:19:11 +01:00
Rémi Verschelde 2af7a2367a
Merge pull request #68005 from timothyqiu/type-mismatch
Fix type mismatch error when deselecting a 3D gizmo
2022-10-31 14:19:06 +01:00
Rémi Verschelde 6a9317c9fc
Merge pull request #42659 from kingoftheconnors/anim-tree-load-fail-alert
Add alert in anim trees if resource load fails
2022-10-31 13:18:10 +01:00
Rémi Verschelde 5947f22be9
Merge pull request #67578 from KoBeWi/GEDITOR
Unify usage of GLOBAL/EDITOR_GET
2022-10-31 13:15:58 +01:00
Rémi Verschelde 4b92533efa
Merge pull request #68073 from timothyqiu/marker-3d-extents
Make Marker3D gizmo resizable
2022-10-31 12:17:13 +01:00
Rémi Verschelde be126d42d4
Merge pull request #67588 from KoBeWi/if(!GDVIRTUAL_CALL)don't
Simplify GDVIRTUAL_CALL calls
2022-10-31 11:55:56 +01:00
Rémi Verschelde 33c7c8020a
Merge pull request #67489 from timothyqiu/auto-select-all
Allow selecting SpinBox & LineEdit text when focus enters
2022-10-31 11:55:06 +01:00
Rémi Verschelde 49c53027a9
Merge pull request #67786 from EricEzaM/67743-script-editor-shortcuts
Set the shortcut context for the edit/search/goto menus to the ScriptEditor so that shortcuts continue to work when FindReplaceBar is focused.
2022-10-31 11:07:48 +01:00
Rémi Verschelde 869c2bd6de
Merge pull request #68064 from kleonc/sprite-frames-editor-fix-frame-index-calculation
`SpriteFramesEditor` Fix calculating frame index from mouse position
2022-10-31 11:00:19 +01:00
Rémi Verschelde 4845feb95d
Merge pull request #68003 from timothyqiu/camera-gizmo-select
Make Camera3D gizmo clickable
2022-10-31 10:56:39 +01:00
Rémi Verschelde 420eb1aa34
Merge pull request #67445 from Zylann/rename_queue_delete
Rename queue_delete => queue_free
2022-10-31 10:51:18 +01:00
Rémi Verschelde d0fbeec66a
Merge pull request #67580 from KoBeWi/little_things
Minor code improvements
2022-10-31 10:34:57 +01:00
Haoyu Qiu 3ded27c62d Make Marker3D gizmo resizable 2022-10-31 15:19:48 +08:00
kleonc d135957987 `SpriteFramesEditor` Fix calculating frame index from mouse position 2022-10-30 21:26:58 +01:00
Dave Palais 3d0a9b2bec Remove the usage of pointers in signal call, to fix #67941
The signal was emitted right as the node was being disposed of. Since
the connection was deferred, the receiving method received an already
freed pointer. Instead, we listen to the text_changed signal and keep
record of the edited text which we then use to update node name when
the LineEdit goes out of focus.
2022-10-30 12:50:27 -05:00
Haoyu Qiu 877cb1cbc0 Improve dragging scene into 3D viewport
* When there's nothing to collide with:
    * Place the new scene on XZ plane when possible.
    * When the camera does not point toward the XZ plane or the
      intersection is too far away, place the new scene on a plane that
      is in front of the camera and parallel to the frame.
* Fixes positioning when in orthogonal view.
    * Place on physical collision point or the XZ plane when possible.
    * Otherwise, place it on the plane in front of the camera as if the
      camera was perspective.
* Makes use of snap settings when placing the new scene.
2022-10-29 23:34:39 +08:00
Haoyu Qiu 03bbacfdca Hide axis gizmo after translating 3D nodes 2022-10-29 16:17:28 +08:00
Haoyu Qiu eb5bfe158e Fix type mismatch error when deselecting a 3D gizmo 2022-10-29 15:15:28 +08:00
Haoyu Qiu ca9063fe4e Make Camera3D gizmo clickable 2022-10-29 12:38:21 +08:00
Haoyu Qiu 3aed3edc06 Allow selecting SpinBox & LineEdit text when focus enters 2022-10-29 09:58:42 +08:00
Clay John d1cc93af89
Merge pull request #67832 from Sauermann/fix-remove-unnecessary-casts
Remove unnecessary casts
2022-10-27 09:47:34 -07:00
Clay John 682156e1f0
Merge pull request #66383 from aaronfranke/basis-from-euler
Clean up Basis from Euler code
2022-10-27 09:44:21 -07:00
Alfred Reinold Baudisch 46f2a1674d Add math operators to Visual Shader node names
This change makes it easy, in the "Create Shader Node" dialog, to search for VS nodes by just typing the operator. For example, instead of typing "multiply", you can just type "*" and multiply nodes will be listed.

This feature is inspired by Unreal Engine node graph editor's UX.

Implements and closes https://github.com/godotengine/godot-proposals/issues/5663
2022-10-26 17:36:19 +02:00
MrBlockers 92ebbf2c0a Fix multiple issues with region editor
Make the filter mode of the texture preview match the node/resource
being edited where applicable, and nearest neighbor with mipmaps as a
fallback.

Make the Edit Region button for Sprite3D only appear when region is
enabled, to match behavior of Sprite2D.

Fix the editor not correctly clearing reference to previously edited
resources, resulting in a visual bug displaying the incorrect texture.
2022-10-25 18:23:23 -04:00
Eric M d499071e5b Set the shortcut context for the edit/search/goto menus to the ScriptEditor so that shortcuts continue to work when FindReplaceBar is focused. 2022-10-25 19:52:42 +10:00
Marc Gilleron 7543a5e014 Rename queue_delete => queue_free
# Conflicts:
#	editor/plugins/tiles/tiles_editor_plugin.cpp
2022-10-24 22:07:02 +01:00
Markus Sauermann 5ee449efec Remove unnecessary casts
button_add_item and button_add are both Button

p_parent is a Node3D

CanvasItem can never be cast to Viewport
2022-10-24 15:59:18 +02:00
kobewi 1e14502f84 Add one-way indicator to tile collision editor 2022-10-24 12:03:39 +02:00
Clay John 040f49ed6e
Merge pull request #67390 from groud/more_conservative_terrain_painting
Make terrain painting not change neighbors centers bits
2022-10-23 17:11:06 -07:00
Clay John dd8702f13d
Merge pull request #67426 from MrBlockers/blurry-texture-preview
Make texture preview filter setting content aware
2022-10-21 17:25:38 -07:00
Aaron Franke 7f9a8c99c9
Clean up Basis from Euler code 2022-10-21 17:54:49 -05:00