c1acddfeb4
Fix the `generate_apk` logic when `dev_build` or `debug_symbols` are enabled
...
Co-authored-by: Rémi Verschelde <rverschelde@gmail.com>
2024-07-29 06:48:49 -07:00
61c4ce272c
[Web] Gracefully handle non-finite audio volumes
2024-07-29 15:48:06 +02:00
9a8f18b9bf
Merge pull request #94796 from kus04e4ek/backfall
...
Windows: Fall back to D3D12 if Vulkan is not supported and vice versa
2024-07-29 15:17:26 +02:00
65e046159b
Merge pull request #94836 from bruvzg/win7_angle
...
[Windows] Remove libSynchronization
2024-07-28 17:46:59 +02:00
8239eac5d9
Merge pull request #94809 from ChrisBase/fix_keytool_for_android_export_not_found
...
Fix Android export failing with custom keystores and no JDK setup in the OS environment
2024-07-28 17:46:42 +02:00
1d8373a300
Merge pull request #92859 from Summersay415/do-not-strip
...
Android: Change the way `doNotStrip` is set
2024-07-28 17:46:31 +02:00
5d5d51937f
[Windows] Remove libSynchronization
2024-07-27 17:12:27 +03:00
d30c1e6a8f
Fall back to D3D12 if Vulkan is not supported and vice versa
2024-07-27 16:17:20 +08:00
7afefe6469
Fixed Android export failing when no JDK is setup in the OS environment and custom keystores have been set in the export dialog.
2024-07-27 01:33:59 +02:00
607b230ffe
Merge pull request #94789 from Faless/web/fix_thread_cc_with_workaround
...
[Web] Fix closure compiler builds, enable it in CI.
2024-07-26 13:44:25 +02:00
44342c385c
Merge pull request #94735 from aitorciki/nvdrs-memset-initialization
...
[Windows] Use default aggregate initialization for NVAPI settings
2024-07-26 13:44:13 +02:00
13c6c0cdb7
Merge pull request #94706 from alvinhochun/window-set-transient-parent-on-create
...
Pass window exclusive and transient properties for subwindow creation
2024-07-26 13:44:03 +02:00
96feb924e8
[Web] Enable the closure compiler in CI
...
Also fixes some JSDoc annotations in GodotAudio
2024-07-26 13:27:52 +02:00
26f17c33a5
[Web] Add workaround for missing export in threaded builds
...
The offending symbol gets stripped away by wasm-dce but it's used on the
JavaScript side and causes and undefined symbol which also causes the
closure compiler to throw an error.
2024-07-26 12:28:36 +02:00
21f3e69a24
[Windows] Use default aggregate initialization for NVAPI settings
...
Using the member initialization encouraged in NVAPI documentation for
NVDRS_SETTING results in builds enabling `dev_mode` breaking. Default
aggregate initialization results in a clean build though.
2024-07-25 14:41:46 +02:00
24e02d56cb
Remove unneeded call in DisplayServerX11
...
X11 does not need setting exclusive flag (it is not implemented).
Co-authored-by: bruvzg <7645683+bruvzg@users.noreply.github.com>
2024-07-25 17:11:15 +08:00
4d0da74014
Fix the cleanup logic for the Android render thread
...
On Android the exit logic goes through `Godot#onDestroy()` who attempts to cleanup the engine using the following code:
```
runOnRenderThread {
GodotLib.ondestroy()
forceQuit()
}
```
The issue however is that by the time we ran this code, the render thread has already been paused (but not yet destroyed), and thus `GodotLib.ondestroy()` and `forceQuit()` which are scheduled on the render thread are not executed.
To address this, we instead explicitly request the render thread to exit and block until it does. As part of it exit logic, the render thread has been updated to properly destroy and clean the native instance of the Godot engine, resolving the issue.
2024-07-24 10:17:46 -07:00
97aa278edb
Pass window exclusive and transient properties for subwindow creation
...
On Windows this allows to avoid having to change the owner of the window
after it has been created, which in rare circumstances may cause the
window to bug out.
2024-07-25 00:27:27 +08:00
25e5efaf9e
Merge pull request #94680 from bruvzg/fix_net_detection
...
Replace .NET detection code with `ClassDB::class_exists("CSharpScript")`.
2024-07-24 09:59:42 +02:00
25f78a5eb6
Replace .NET detection code with `ClassDB::class_exists("CSharpScript")`.
2024-07-23 23:46:14 +03:00
c34192eb9c
[macOS export] Do not stop export on signing errors.
2024-07-23 22:38:05 +03:00
52a2836861
Disable FP contraction.
2024-07-23 14:33:51 +03:00
a50fe87b89
Merge pull request #94078 from Repiteo/scons/msvc-flag-fix
...
SCons: Don't override cl flags on msvc
2024-07-22 14:12:45 +02:00
e307fd60d8
Wayland: Fix error spam when interacting with decorations
...
Also tried to make tablet handling a bit tidier (less whitespace).
That said I'll uniform tablet handling better once we're back in the dev
cycle.
2024-07-20 03:46:35 +02:00
0e519118d2
[Windows] Fix release export template build for ARM64 Windows.
2024-07-19 14:33:40 +03:00
cf9e485696
Merge pull request #94518 from bruvzg/mac_net_non_sandboxed_sign
...
[macOS] Fix codesigning of .NET helper executables when sandboxing is disabled.
2024-07-19 11:10:55 +02:00
18da250ffb
Merge pull request #93737 from aitorciki/disable-windowed-gsync
...
[Windows] Disable G-SYNC in windowed mode
2024-07-19 11:10:31 +02:00
975ee76e2b
[macOS] Fix codesigning of .NET helper executables when sandboxing is disabled.
2024-07-18 23:40:49 +03:00
2b2fd56ca5
Merge pull request #94473 from nvlled/fix-screen-image-memory-leak
...
Linux/X11: Fix memory leak from created screen images
2024-07-18 10:45:43 +02:00
287521c2c2
Merge pull request #94466 from bruvzg/angle_update_lib
...
[Windows] Add `libSynchronization` to link flags.
2024-07-18 10:45:40 +02:00
3636d9dafc
Linux/X11: Fix memory leak from created screen images
...
Allocated XImages are improperly free'd with XFree.
The X11 documentation says that XImage should use
XDestroyImage to free both the image structure and
the data pointed to by the image structure.
Also fix a potential use-after-free bug.
2024-07-18 09:45:44 +02:00
2f5f84b470
Fix audio samples not being able to be "finished"
2024-07-17 10:45:38 -04:00
ea018a8131
Merge pull request #94120 from bruvzg/fix_kbd_names
...
[Windows] Fix reading keyboard layout names.
2024-07-17 15:44:50 +02:00
1ca4ce284e
Merge pull request #94063 from bruvzg/tablet_drag
...
[Winink] Check pointer button states.
2024-07-17 15:44:47 +02:00
64a11d08cc
Merge pull request #94411 from Riteo/suspending-the-right-way
...
Wayland: Check for suspended flag when unsuspending
2024-07-17 12:52:50 +02:00
d191bee0ae
Merge pull request #94402 from Riteo/committed-to-the-cause
...
Wayland: Commit surface on window creation
2024-07-17 12:52:44 +02:00
a4312eebaa
Merge pull request #94468 from m4gr3d/restart_editor_when_updating_touchscreen_settings
...
[Android Editor] Resolve issues with the editor touchscreen settings
2024-07-17 12:24:14 +02:00
7b12dbd74d
Merge pull request #94425 from m4gr3d/fix_remote_android_button_not_enabling
...
Fix issue preventing enabling the remote button for Android/iOS
2024-07-17 11:44:34 +02:00
38a537c011
Merge pull request #94398 from alvinhochun/windows-rendering-driver-initial-size-fix
...
Windows: Fix wrong initial size passed to rendering driver
2024-07-17 11:44:19 +02:00
53a752f2d6
Disable long press for mouse events
...
Long press is used to simulate right-click events for finger touch and stylus. The previous logic also caused it to trigger for mouse input, which is not needed since the user can instead use the mouse right click button.
This update disables long press as right click events for mouse input.
2024-07-17 02:44:17 -07:00
496fd12b17
Merge pull request #94052 from m4gr3d/clean_input_dispatch_settings
...
Cleanup Android input on render thread settings
2024-07-17 11:42:52 +02:00
9f714bfde5
[Windows] Add `libSynchronization` to link flags.
2024-07-17 10:58:03 +03:00
a1a0acff7c
Windows: Update ANGLE surface size when window is resized
...
ANGLE needs to be told to resize the DXGI swap chain using
`eglWaitNative`. Otherwise the resize will only happen in
`eglSwapBuffers`, which causes some janky stretching during window
resize.
2024-07-16 17:01:42 +08:00
d7f023ab73
Windows: Do not attempt to resize surface before it is created
...
`WM_WINDOWPOSCHANGED` may be received before `CreateWindowExW` has even
returned, when the window's rendering context or OpenGL context hasn't
been created yet.
2024-07-16 17:01:42 +08:00
5b327aee96
Fix issue preventing enabling the remote button for Android
...
https://github.com/godotengine/godot/pull/92032 updated the logic to enable / disable the remote debug button, and in doing so added a `can_export` check.
However, no events / notifications are dispatched when the value of the `can_export` check changes, which in turn prevents the logic used to enable / disable the remote debug button from running again.
The fix consists then in removing the `can_export` check, so that the remote debug button shows as `enabled` when a preset is present and is runnable.
2024-07-16 00:25:16 -07:00
84f26a629d
Wayland: check for suspended flag when unsuspending
...
Before, we would only check for the frame flag, which is unreliable on
newer suspension-aware compositors.
2024-07-16 00:11:22 +02:00
a852e76196
Wayland: commit surface on window creation
...
This is needed for initializing xdg_surfaces when not using libdecor.
Now the pure xdg_shell code path should work again.
2024-07-15 22:11:24 +02:00
1d542257e5
Windows: Fix wrong initial size passed to rendering driver
2024-07-16 03:30:44 +08:00
3afe1e7481
[Winink] Check pointer button states, fix drag and double-click.
2024-07-15 12:23:07 +03:00
97b8ad1af0
Merge pull request #94232 from bruvzg/macos_dnd
...
[macOS] Fix drag-and-drop feedback.
2024-07-11 23:17:06 +02:00
1aa1a1879d
Merge pull request #94203 from RandomShaper/bye_bye_dxil_dll
...
D3D12: Get rid of `DXIL.dll`!
2024-07-11 23:16:59 +02:00
6c2699cbf6
Merge pull request #94187 from akien-mga/windows-remove-unused-is_wow64
...
Remove unused `is_wow64` method in `OS_Windows`
2024-07-11 23:16:54 +02:00
c349f0d6a7
Remove unused `is_wow64` method in `OS_Windows`
...
It was added in b4d369c886bf02c016
2024-07-11 23:16:12 +02:00
c8447724e5
[macOS] Fix drag-and-drop feedback.
2024-07-11 23:13:38 +03:00
ee2c1584e4
D3D12: Get rid of DXIL.dll!
2024-07-11 17:56:45 +02:00
1b49d6393d
Merge pull request #93733 from alvinhochun/windows-restore-sizing
...
Windows: Restore to windowed mode using `SW_NORMAL`
2024-07-11 09:40:58 +02:00
5e59819727
Cleanup Android input on render thread settings
...
Follow up to https://github.com/godotengine/godot/pull/93933
Clean up the set of settings use to control whether Android input should be dispatched on the render thread.
Addresses comments in https://github.com/godotengine/godot/pull/93933#issuecomment-2210437977
2024-07-09 09:15:18 -07:00
1b0430dc3a
Merge pull request #94114 from bruvzg/ios_text_change
...
[iOS/Text Input] Avoid deleting and reentering unchanged part of text.
2024-07-09 16:47:23 +02:00
49a6171319
Merge pull request #93352 from Calinou/linuxbsd-controller-no-trackpad-graphics-tablet
...
Fix trackpads and graphics tablets being recognized as controllers on Linux/*BSD
2024-07-09 16:47:04 +02:00
fea8ab0999
[Windows] Fix reading keyboard layout names.
2024-07-09 11:46:06 +03:00
c632b47b48
[iOS/Text Input] Avoid deleting and reentering unchanged part of text.
2024-07-09 08:32:27 +03:00
8897c77d50
SCons: Default `optimize` to `auto`, fixing `target`/`dev_build` inference for Web
...
Fixes #94087 .
2024-07-09 00:21:29 +02:00
3220b6fb11
Merge pull request #93976 from Hilderin/fix-caret-disappear-from-script-editor
...
Fix caret can disappear from script editor
2024-07-08 19:13:31 +02:00
0f691efb1b
SCons: Don't override cl flags on msvc
2024-07-08 09:48:18 -05:00
ebd1ab646c
Fix caret can disappear from script editor
2024-07-08 07:11:17 -04:00
ec02d406ca
Merge pull request #94067 from RandomShaper/fix_build
...
Windows: Fix build error due to missing definition of Texture2D
2024-07-08 11:48:36 +02:00
50bf2e5b37
Windows: Fix build error due to missing definition of Texture2D
2024-07-08 10:40:17 +02:00
eddc9cea11
[NativeMenu] Do not auto toggle check/multi-state items. Add `is_native_menu` method.
2024-07-08 11:20:28 +03:00
42e5b3ac2d
Merge pull request #94044 from adamscott/fix-web-sample-playback-finished-signal
...
Fix Web samples finished missing signal
2024-07-07 21:59:00 +02:00
39d9ff21b8
Merge pull request #94024 from anniryynanen/ime-block
...
Fix IME blocking controls
2024-07-07 21:58:43 +02:00
a38f30fbd5
Fix Web samples finished missing signal
2024-07-07 14:47:54 -04:00
d926223c64
Fix IME blocking controls
2024-07-07 13:06:18 +03:00
3e0632cbd2
Wayland: scale relative pointer motion
...
Oops, forgot to do that. Motion-dependent stuff should now work properly
when using scaled displays.
2024-07-07 08:39:53 +02:00
724cdffc8c
Fix trackpads and graphics tablets being recognized as controllers on Linux/*BSD
2024-07-06 00:26:39 +02:00
ce16818dd5
Fix missing include in Web main after #93906
...
My bad, I introduced the bug when amending it.
2024-07-05 14:40:44 +02:00
20ba2f00bd
Merge pull request #93950 from bruvzg/mvk_scaling
...
[MoltenVK] Fix downscaled hiDPI window pixelation.
2024-07-04 23:27:23 +02:00
8455b3343e
Merge pull request #93933 from m4gr3d/anr_and_crash_bug_fixes
...
Fix crashes and ANRs reported by the Google Play Console
2024-07-04 23:27:20 +02:00
db97d88214
Fix preloading a zip in the web editor
2024-07-04 22:13:05 +02:00
ab4213f043
[MoltenVK] Fix downscaled hiDPI window pixelation.
2024-07-04 21:03:32 +03:00
6b6428d779
Fix ANRs reported by the Google Play Console
...
- Add support for dispatching input on the render thread (UI thread is the current default) when `input_buffering` and `accumulated_input` are disabled. At the expense of latency, this helps prevent 'heavy' applications / games from blocking the UI thread (the default behavior) which may cause the application to ANR.
- Remove GLSurfaceView logic causing the UI thread to wait on the GL thread during lifecycle events. The removed logic would cause the UI thread to ANR when the GL thread is blocked.
2024-07-04 05:18:50 -07:00
c6a23a7a7d
Fix crashes reported by the Google Play Console
2024-07-04 02:46:11 -07:00
e6448ca0aa
Merge pull request #93891 from m4gr3d/fix_logo_not_showing_for_gles3
...
[Android] Fix the issue causing the logo to not show when using the `compatibility` renderer
2024-07-04 11:32:13 +02:00
01c24ff862
Merge pull request #93750 from adamscott/add-bigint-support-on-js-value-conversion
...
Add `bigint` support on JS value conversion
2024-07-04 11:31:58 +02:00
637f4a10ed
Fix the issue causing the logo to not show when using the `compatibility` renderer
2024-07-03 11:16:45 -07:00
ee2759013b
Add `bigint` support on JS value conversion
2024-07-03 07:44:32 -04:00
f0d15bbfdf
Merge pull request #93853 from Faless/web/no_force_stdlib
...
[Web] Remove unnecessary `EMCC_FORCE_STDLIBS` in dlink builds
2024-07-02 17:27:35 +02:00
abfce31ba7
Merge pull request #93152 from RandomShaper/prebuilt_asan
...
Enable usage of asan-enabled versions of prebuilt libraries
2024-07-02 17:27:31 +02:00
67c06866de
[Web] Remove unnecessary EMCC_FORCE_STDLIBS in dlink builds
...
As discussed with upstream, the C/C++ standard library is always fully
included when building with MAIN_MODULE=1, so using EMCC_FORCE_STDLIBS
is not necessary in our case.
2024-07-02 16:47:00 +02:00
586db3aae7
Fix assignations to non-existing keys and clean-up
2024-06-29 14:30:57 -04:00
25de53e147
X11: Fix creating RenderingDevice after #93706
...
The line was removed by mistake.
2024-06-29 14:03:29 +02:00
b8edc64379
[Windows] Disable G-SYNC in windowed mode
...
G-SYNC (NVIDIA's VRR) is known to be buggy on windowed mode in Windows.
While the driver only enables G-SYNC for full screen mode by default,
users can toggle it on for windowed mode too, resulting in unstable
refresh rates during Editor usage.
This patch extends Godot's NVIDIA profile to force the default full
screen mode only G-SYNC with Godot.
2024-06-29 13:40:15 +02:00
c54477b7e6
Windows: Restore to windowed mode using SW_NORMAL
...
If window was maximized before minimizing, restoring the window
afterwards using SW_RESTORE seems to cause the window to forget its
original size and position before being maximized, causing the window to
fill the screen instead.
2024-06-29 18:24:45 +08:00
32d9c93af3
Improve handling of rendering startup errors
2024-06-28 19:31:50 +02:00
3cefe898b1
Merge pull request #93589 from mhilbrunner/fix-windows-vs-arch-detection
...
Windows: Fix arch detection via `VCTOOLSINSTALLDIR` if not first in `PATH`
2024-06-28 14:42:54 +02:00
ac9181c666
Merge pull request #93682 from dsnopek/fix-text-editor-find-in-files-focus-bug
...
Fix text editor stealing focus from "Find in Files" dialog on X11
2024-06-28 12:37:52 +02:00
f27471fbd8
Wayland: minimize surface commits and limit them to the main thread
...
Before of this patch, as explained in the usual
commented-wall-of-text-longer-than-the-actual-patch-itself™, due to the
multithreaded nature of the Wayland thread, it was possible to commit a
surface while the renderer was doing stuff, which was _very_ wrong.
Initially the consequences of such a sin weren't obvious but, now that
explicit synchronization is becoming more and more common, we can't
commit a buffer randomly without basically guaranteeing a nasty, nasty
crash (and we should have avoided commits altogether in the first place
to ensure atomic surface updates).
We now only trigger a commit _in the main thread_ when low processor usage
mode is on _and_ if we know that we won't be rendering anything as, due to
its intermittent nature, it makes "legacy" (pre xdg_wm_base v6) frame
callback based suspension quite annoying.
2024-06-28 01:47:25 +02:00
1289298b5e
Fix text editor stealing focus from "Find in Files" dialog on X11
2024-06-27 17:27:21 -05:00
1e8e9f4b09
Fix web export state for remote debug
2024-06-26 08:37:56 -04:00
63911b994c
Windows: Fix arch detection via VCTOOLSINSTALLDIR
2024-06-25 13:31:46 +02:00
f59c1f08d7
[Web] Add "threads"/"nothreads" feature tags to export presets
...
Following the "variant/thread_support" preset option.
2024-06-25 11:42:41 +02:00
Fredia Huya-Kouadio
A Thousand Ships
Rémi Verschelde
bruvzg
Kusok
Chris
Fabio Alessandrelli
Aitor Guevara
alvinhochun
Fredia Huya-Kouadio
Alvin Wong
Riteo
Ronald Casili
Adam Scott
Pedro J. Estébanez
Thaddeus Crews
Hilderin
Anni Ryynänen
Hugo Locurcio
Paul Sinnett
Rémi Verschelde
David Snopek
Max Hilbrunner