godotengine/godot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
62,439 Commits 15 Branches 59 Tags 2.2 GiB
4dec783017
Commit Graph

2210 Commits

Author SHA1 Message Date
Rémi Verschelde
9f48330c3f
Merge pull request #88469 from paulloz/dotnet/cleaner-diagnostic-rules 
[.NET] Clean diagnostic rules
 2024-02-19 00:08:30 +01:00
Rémi Verschelde
033821c595
Merge pull request #88245 from shana/simplify-mono-support-detection 
C#: Let platforms signal if they support the mono module or not
 2024-02-19 00:08:07 +01:00
Paul Joannon
5981886fb7
Clean diagnostic rules 
Move the following diagnostics into static readonly fields: GD0101, GD0102, GD0103, GD0104, GD0105, GD0106, GD0107, GD0201, GD0202, GD0203, GD0301, GD0302, GD0303, GD0401, GD0402.

To be more consistent, the titles for the following diagnostics were modified: GD0101, GD0105, GD0106, GD0302, GD0303, GD0401, GD0402. A subsequent update of the documentation repo is needed.

Tests for the following diagnostics were created: GD0201, GD0202, GD0203.
 2024-02-18 16:47:20 +01:00
Raul Santos
dcb411daee
C#: Fix building OpenVisualStudio executable 
Since moving the TFM to .NET Core we need to add some configuration to cross-compile a Windows executable from Linux.
 2024-02-18 05:40:06 +01:00
Thaddeus Crews
48428bd087
C#: Match Core implementation of BinToInt & HexToInt 2024-02-17 11:59:14 -06:00
Rémi Verschelde
ccd9cefa8e
Merge pull request #87137 from /dotnet/nullable-godot-tools 2024-02-17 18:31:37 +01:00
Matt Enad
5b5de0e167 Add hover highlight to main editor buttons 
Updates styling of the editor run bar, plugin, bottom panel, icon buttons, and main menu buttons for accessibility.
 2024-02-16 14:49:44 -05:00
Rémi Verschelde
09df8f4a56
Merge pull request #87952 from paulloz/dotnet/byebye-signal-callback-generation 
Disable signal callback generation in C#
 2024-02-15 15:44:55 +01:00
Rémi Verschelde
1efc3625fa
Merge pull request #87342 from raulsntos/dotnet/warnings/RS1024 
C#: Use SymbolEqualityComparer
 2024-02-15 15:44:47 +01:00
Raul Santos
7b348708e8
C#: Use SymbolEqualityComparer 
Use `SymbolEqualityComparer` to compare symbols and fix `RS1024` warning.
 2024-02-14 17:33:06 +01:00
Muller-Castro
a8bc9f3e78 Add const lvalue ref to core/* container parameters 2024-02-14 11:20:36 -03:00
Paul Joannon
9fa2355cef
Disable signal callback generation in C# 2024-02-14 13:26:45 +01:00
Andreia Gaita
21e524a798 C#: Let platforms signal if they support it or not 
Instead of hardcoding platform names that support C#, let platforms
set a flag indicating if they support it. All public platforms
except web already support it, and it's a pain to maintain a patch
for this list just to add additional names of proprietary console
platforms.

This makes adding new platforms or variants or existing platforms
much easier, as the platform can signal what it supports/doesn't
support directly, and we can avoid harcoding platform names.
 2024-02-13 22:48:43 +01:00
Thaddeus Crews
3314f8cc65
C#: Enable nullable environment for GodotTools 2024-02-13 12:24:53 -06:00
Rémi Verschelde
dfe226b933
Merge pull request #88270 from TokageItLab/avoid-near-far 
Avoid unqualified-id "near" and "far" in Node3DEditor/Viewport
 2024-02-13 11:25:24 +01:00
Silc Lizard (Tokage) Renew
67e38709fd Avoid unqualified-id "near" and "far" in Node3DEditor/Viewport 2024-02-13 18:53:21 +09:00
Zae
8245157682 C#: Fix missing CowData 64-bit promotion for PackedInt32Array. 2024-02-13 12:19:48 +08:00
Rémi Verschelde
7d89f557f3
Merge pull request #88238 from shana/cs-export-fix-output-files 
C#: Fix processing exclusions during export
 2024-02-12 23:29:47 +01:00
Andreia Gaita
2f10f7bed4 Fix processing exclusions during export 2024-02-12 11:51:05 +01:00
Raul Santos
5815d1c8c8
Improve handling of generic C# types 
- Create CSharpScript for generic C# types.
  - `ScriptPathAttributeGenerator` registers the path for the generic type definition.
  - `ScriptManagerBridge` lookup uses the generic type definition that was registered by the generator.
  - Constructed generic types use a virtual `csharp://` path so they can be registered in the map and loaded as if there was a different file for each constructed type, even though they all share the same real path.
  - This allows getting the base type for a C# type that derives from a generic type.
- Shows base scripts in the _Add Node_ and _Create Resource_ dialogs even when they are generic types.
  - `get_global_class_name` implementation was moved to C# and now always returns the base type even if the script is not a global class (this behavior matches GDScript).
- Create `CSharpScript::TypeInfo` struct to hold all the type information about the C# type that corresponds to the `CSharpScript`, and use it as the parameter in `UpdateScriptClassInfo` to avoid adding more parameters.
 2024-02-08 18:31:13 +01:00
Paul Joannon
9d283063a0
Fix C# "out of sync" notice with external editors 
Change what triggers our re-evaluation of the last valid build datetime stored internally.
Move that datetime in `BuildManager`.
 2024-02-07 21:26:32 +01:00
Raul Santos
8ce4a0cf15
C#: Fix crash when reloading scripts 
The crash cond was accidentally moved to the `reload_scripts` method when it was only meant to be in the `reload_tool_script` method. Same about restarting the HotReloadAssemblyWatcher timer.

Also removed the loop that checks if the script array contains a C# script because if we're in CSharpLanguage we can assume that at least one of them is.
 2024-02-07 06:33:51 +01:00
Rémi Verschelde
acde2a81ff
Merge pull request #84640 from aaronfranke/gravity-get 
Expose a method to get gravity for any physics body
 2024-02-05 14:48:31 +01:00
Rémi Verschelde
d0f8b76ffd
Merge pull request #87838 from paulloz/dotnet/fix-duplicate-key-on-reload 
C#: Fix duplicate key issue on reload
 2024-02-02 12:05:14 +01:00
Rémi Verschelde
8a47d6eb50
Merge pull request #87790 from nongvantinh/fix-87643 
Fix incorrect condition for error filtering
 2024-02-02 12:03:59 +01:00
Rémi Verschelde
24a2560d30
Merge pull request #87682 from zaevi/fix_csharp_stringname_ref 
C#: Fix issues for StringName reference in `CSharpInstanceBridge.Get`.
 2024-02-02 12:02:44 +01:00
Paul Joannon
999180d5b5
Delay fs update when populating path bimap 2024-02-01 22:06:40 +01:00
Nông Văn Tình
d81c9c32c5 Fix incorrect condition for error filtering 
Fixes: #87643

The original condition stopped immediately after checking for 'searchText' in the 'Message' field, resulting in premature termination of subsequent checks. This fix ensures that all relevant conditions are appropriately evaluated before determining the filtering outcome.

Additionally, accompanying changes include improved code readability for better comprehension. This adjustment enhances the maintainability of the error filtering mechanism, contributing to a more robust codebase overall.
 2024-01-31 23:01:37 +07:00
Aaron Franke
aed5ea9460
Expose a method to get gravity for any physics body 2024-01-30 23:57:38 -06:00
Rémi Verschelde
736696b533
Merge pull request #87679 from raulsntos/dotnet/remove-unused 
C#: Remove unused code
 2024-01-30 17:48:07 +01:00
Michael Wörner
9d50a486bf Fixed ~CSharpScript() holding on to a mutex longer than necessary, creating potential for a deadlock. 2024-01-28 21:28:14 +01:00
Zae
1e14503715 C#: Fix issues for StringName reference in CSharpInstanceBridge.Get. 2024-01-29 02:04:02 +08:00
Raul Santos
82380ec700
C#: Remove unused code 
- Remove `AotBuilder` that was used for MonoAOT in 3.x.
- Remove `PlaySettings` that was used for IDE support in 3.x.
- Remove `ApiAssembliesInfo` that was used for Project generation in 3.x.
- Remove pieces of the old iOS support from 3.x.
 2024-01-28 16:09:59 +01:00
Rémi Verschelde
99ac3d332a
Merge pull request #87597 from zaevi/fix_csharp_aot_initialization 
C#: Fix not assigning `runtime_initialized` when initializing with AOT.
 2024-01-26 11:49:53 +01:00
Rémi Verschelde
3bbf4abfaa
Merge pull request #87550 from zaevi/fix_csharp_generic_reloading 
C#: Fix sorting for generic types when reloading assemblies.
 2024-01-26 11:48:18 +01:00
Rémi Verschelde
563e385810
Merge pull request #87526 from zaevi/fix_csharp_gc 
C#: Fix incorrect GC handle for non-instantiable types.
 2024-01-26 11:47:25 +01:00
Rémi Verschelde
85b2c947b2
Merge pull request #87518 from paulloz/dotnet/fix-warnings 
Clean a number of C# warnings
 2024-01-26 11:46:37 +01:00
Rémi Verschelde
849b69828b
Merge pull request #85908 from avilches/fix-must-be-variant-analyzer-fail-with-generic-typed-attributes 
Allow using `[MustBeVariant]` in generic typed attributes
 2024-01-26 11:42:34 +01:00
Rémi Verschelde
d36f5cf2ba
Merge pull request #85504 from nongvantinh/fix-csharp-loader 
Fix C# script loader does not work reliably
 2024-01-26 11:42:01 +01:00
Zae
18599c0935 C#: Fix sorting for generic types when reloading assemblies. 2024-01-26 18:00:46 +08:00
Paul Joannon
46b3096570
Clean a bunch of C# warnings 
- `[Obsolete]` tag generated in the middle of documentation comments
- Potential `null` values in generators
- Obsolete call to `GetEditorInterface()`
- We don't want `Godot.Collections.Array` to end with `Collection`
- A few culture specifications and use of `AsSpan` instead of `SubString` in `StringExtensions`
- Disable CA1716 in GodotSharp
 2024-01-26 09:38:33 +01:00
Zae
e868a9f577 C#: Fix not assigning runtime_initialized when initializing with AOT. 2024-01-26 05:44:40 +08:00
Zae
201e946741 C#: Fix incorrect GC handle for non-instantiable types. 2024-01-25 02:40:08 +08:00
Alberto Vilches
692412562d C#: Fix to allow usage of [MustBeVariant] in generic typed attributes 2024-01-21 22:29:29 +01:00
Nông Văn Tình
7676e389a7 Fixes C# script loader does not work reliably 2024-01-22 04:20:27 +07:00
Rémi Verschelde
0bcc0e92b3
Merge pull request #86730 from reduz/64-bit-cowdata 
Promote CowData to 64 bits
 2024-01-19 18:46:11 +01:00
Juan Linietsky
24fe0715b5 Promote CowData to 64 bits 
Fixes a lot of bugs, please help me fill the list.
 2024-01-19 17:41:10 +01:00
Yuri Sizov
b6a2c78033 Merge pull request #87286 from akien-mga/fix-preprocessor-if-ENABLED-checks 
Fix `#if *_ENABLED` inconsistencies, should check if defined
 2024-01-17 18:53:33 +01:00
Yuri Sizov
66736398cd Merge pull request #87264 from AThousandShips/aabb_fix_cs 
[C#] Fix `Encloses` failing on shared upper bound for `AABB` and `Rect2(I)`
 2024-01-17 18:53:22 +01:00
Yuri Sizov
c027aecc2e Merge pull request #86676 from rune-scape/sparse-script-reload 
GDScript: Hot-reload changed scripts only
 2024-01-17 18:52:54 +01:00
Yuri Sizov
7351b5704a Merge pull request #86528 from avilches/must-be-variant-tests 
Add unit tests for C# diagnostic analyzers
 2024-01-17 18:52:45 +01:00
Rémi Verschelde
0a7579b161
Fix #if *_ENABLED inconsistencies, should check if defined 
Co-authored-by: Caroline Joy Bell <halotroop2288@proton.me>
 2024-01-17 10:30:15 +01:00
A Thousand Ships
227a165ce4
[C#] Fix Encloses failing on shared upper bound for AABB and 
`Rect2(I)`
 2024-01-16 20:20:53 +01:00
Yuri Sizov
95b27fe8c7 Reorganize code related to editor theming 
This change introduces a new EditorThemeManager class
to abstract theme generatio and its subroutines.

Logic related to EditorTheme, EditorColorMap, and editor
icons has been extracted into their respective files with
includes cleaned up.

All related files have been moved to a separate folder to
better scope them in the project. This includes relevant
generated files as well.
 2024-01-16 11:57:45 +01:00
Alberto Vilches
7a90c56c00 C# Add test suite for Diagnostic Analyzers: GlobalClass and MustBeVariant 2024-01-15 11:31:12 +01:00
Rémi Verschelde
3dcf9059ae
Merge pull request #86454 from Repiteo/c#-upgrade-TFMs 
C#: Upgrade TFM for `net472` and some `netstandard2.0` projects
 2024-01-11 17:37:19 +01:00
Rémi Verschelde
ba96dbb49a
Merge pull request #85460 from van800/master 
Bump the `JetBrains.Rider.PathLocator` PackageReference to 1.0.8
 2024-01-11 17:36:04 +01:00
Rémi Verschelde
cea56336b2
Merge pull request #86972 from zaevi/fix_csharp_method_return_type 
C#: Fix return type hint for methods.
 2024-01-10 12:03:33 +01:00
Rémi Verschelde
8a6debd71e
Merge pull request #86592 from emklasson/fix_gd0103_link 
Fix typo in GD0103 error link
 2024-01-10 12:03:29 +01:00
Zae
51c54b03d1 C#: Fix return type hint for methods. 2024-01-09 04:28:17 +08:00
Thaddeus Crews
7a06390552
C#: Upgrade TFM for net472 and some netstandard2.0 projects 2024-01-06 09:14:33 -06:00
Muller-Castro
96a95cb974 Add const lvalue ref to container parameters 2024-01-05 14:49:57 -03:00
Rémi Verschelde
11d1844e66
Merge pull request #85869 from paulloz/dotnet-warning-out-of-date-properties 
.NET: Add a warning in the inspector when properties might be out of sync
 2024-01-03 15:43:41 +01:00
Rémi Verschelde
22e880ad20
Merge pull request #83163 from Chubercik/vectorXi_dist_methods 
Implement `Vector2i/3i/4i` methods: `distance_to` and `distance_squared_to`
 2024-01-03 09:58:36 +01:00
rune-scape
cde478bda6 Hot-reload only changed scripts 2024-01-02 17:56:52 -08:00
Mikael Klasson
a2b183067c fix: use correct number in GD0103 link 2023-12-27 20:30:59 +09:00
Paul Joannon
0818d015db
Inspector ⚠️ when C# props might be out of date 2023-12-22 23:27:13 +01:00
Raul Santos
abd7927325
C#: Use string literal instead of nameof 
Using `nameof` expressions with method parameters requires C# 11 and we're currently on C# 10.
 2023-12-21 03:11:47 +01:00
Yuri Sizov
ef79e5d9dd Merge pull request #82983 from Repiteo/c#-godotsharp-nullable-classes 
[C#] Enable nullability for variant classes
 2023-12-19 20:32:30 +01:00
Yuri Sizov
c8d0325a93 Merge pull request #82955 from paulloz/testing-source-generators 
Add unit tests for C# source generators
 2023-12-19 20:32:26 +01:00
msreis
f1cc14d525 Fix missing time for some script functions in profiler 
Fixes the issue by adding a mechanism by which the functions that were
previously disappearing can be profiled too. This is optional with
an editor setting, since collecting more information naturally slows the engine
further while profiling.

Fixes #23715, #40251, #29049
 2023-12-19 19:42:21 +01:00
Paul Joannon
b352bdc8cb
Add tests for source generators 
- Bootstrap xUnit project to test source generators
- Implement source generator tests
- Better tests structure (put test data in cs files)
- Enable `ScriptSerializationGeneratorTests`
- Enable `ScriptPathAttributeGeneratorTests`
- Fix `NesterClass` -> `NestedClass`
- Use `Path.Combine` when dealing with paths
- Copy test data to the output directory
 2023-12-19 18:26:52 +01:00
Yuri Sizov
f478a599fc Merge pull request #85975 from Repiteo/c#-null-ptr-exception 
C#: Implement function to throw on null pointers
 2023-12-19 13:02:24 +01:00
Thaddeus Crews
a0db88335a
Implement function to throw on null pointers 
• Specifically: checks if ptr == IntPtr.Zero
 2023-12-17 08:52:20 -06:00
Thaddeus Crews
08e44123cb
[C#] Enable nullability for variant classes 2023-12-09 12:42:10 -06:00
Thaddeus Crews
db7a643e1c
[C#] Enable nullability for variant structs 2023-12-09 12:41:53 -06:00
Rémi Verschelde
d76c1d0e51
Bump version to 4.3-dev 
The essential doesn't change.

-- Samuel Beckett, Waiting for Godot
 2023-11-29 23:00:27 +01:00
Ivan Shakhov
7f63f4a6bf bump the PackageReference "JetBrains.Rider.PathLocator" to 1.0.8 2023-11-28 11:13:30 +01:00
bruvzg
a92511fec3
[iOS] Fix dotnet export. 2023-11-16 15:05:44 +02:00
Raul Santos
3936871077
C#: Fail callp silently if script is not valid 2023-11-14 16:56:16 +01:00
Rémi Verschelde
313bffc205
Merge pull request #83357 from raulsntos/dotnet/ConvertCallableToNative(default) 
C#: Fix converting default Callables to native
 2023-11-10 21:55:22 +01:00
A Thousand Ships
668761fa8e Rename Vector2/3/4I.Min/Max to MinValue/MaxValue 
More consistent with the `Mathf` constants they reference
 2023-11-09 14:16:53 +01:00
Rémi Verschelde
26f1c503ec
Merge pull request #84617 from YuriSizov/editor-this-one-is-for-all-my-subs 
Fix node names of submenu items across the editor
 2023-11-09 11:47:24 +01:00
Rémi Verschelde
ce53362f98
Merge pull request #83670 from raulsntos/notification-predelete-cleanup 
Add `NOTIFICATION_PREDELETE_CLEANUP` notification to fix C# `Dispose()`
 2023-11-09 11:45:49 +01:00
Yuri Sizov
b04b546092 Fix node names of submenu items across the editor 
Also removes some programmer remarks and fixes some docs.
 2023-11-08 14:42:42 +01:00
Rémi Verschelde
6afd320984
Merge pull request #78157 from RedworkDE/net-shutting-down-abruptly 
C#: Fix crash with `DisposablesTracker_OnGodotShuttingDown`
 2023-10-31 20:52:27 +01:00
Rémi Verschelde
67941551ca
Merge pull request #83809 from raulsntos/dotnet/free-dialogs 
C#: Free dialogs when exiting the editor
 2023-10-30 16:26:15 +01:00
Rémi Verschelde
bf41c6bd34
Merge pull request #82918 from raulsntos/dotnet/only-node-can-export-node 
C#: Report diagnostic for Node exports in a type that doesn't derive from Node
 2023-10-27 11:36:33 +02:00
Rémi Verschelde
398b254f27
Merge pull request #83325 from raulsntos/dotnet/find-latest-sdk 
C#: Fallback to the latest SDK
 2023-10-24 10:54:04 +02:00
Theraot
8777c05817 Expanded documentation for vector slide and project 2023-10-23 06:16:07 -05:00
Raul Santos
48edcc3b34
C#: Free dialogs when exiting the editor 2023-10-23 02:10:06 +02:00
Raul Santos
9750e49c57
Add NOTIFICATION_PREDELETE_CLEANUP notification 
New notification sent after `NOTIFICATION_PREDELETE` to let Objects cleanup at the very end, it should be the last notification sent.
 2023-10-20 13:43:42 +02:00
Rémi Verschelde
49f492d54b
Merge pull request #83532 from raulsntos/dotnet/nested-class-generation 
C#: Fix generated nested class order
 2023-10-18 16:54:58 +02:00
Raul Santos
fe078219fc
C#: Fix generated nested class order 2023-10-18 03:37:57 +02:00
Raul Santos
e6ebde8408
Fix C# docs to use the proper XML 
Replaces some BBCode that was accidentally left in the C# documentation
with the proper XML syntax.
 2023-10-18 01:56:25 +02:00
Rémi Verschelde
dce1aab174
Merge pull request #83514 from kleonc/docs-multiplication-operators-doing-xform_inv-csharp 
Clarify C# docs for operators performing `xform_inv`
 2023-10-18 00:06:02 +02:00
Rémi Verschelde
ca09afd530
Merge pull request #80489 from raulsntos/dotnet/diagnostics 
C#: Improve diagnostic messages and add help link
 2023-10-17 23:59:17 +02:00
kleonc
408de3b091 Clarify C# docs for operators performing xform_inv 2023-10-17 19:49:42 +02:00
Raul Santos
aa4dba5b56
C#: Improve diagnostic messages and add help link 
- Reword diagnostic messages.
- Add help link to diagnostics.
 2023-10-17 19:45:09 +02:00
Thaddeus Crews
0935a99bf9
C# - bindings generator langword check 2023-10-17 08:51:24 -05:00