407b16ab00
Debug CanvasItem redraw
...
I wanted to add this tool for years and always forget. This command line option:
```
$ godot.exe -e --debug-canvas-item-redraw
```
Allows to see when a canvas item is redrawn. This helps find out if something
in the UI is refreshing in a way it should not. Examples as such:
* Signals causing more of the UI to redraw.
* Container resizing causes more UI elements to redraw.
* Something using a timer is redrawing all time time, which can go unnoticed.
To my surprise, the editor UI is redrawing very efficiently. There is some
weird stuff with the scene tabs, redrawing when the inspector changes but most
things for the most part are fine.
2023-08-28 12:53:56 +02:00
677d2d6fb0
Fix missing EARLY_FRAGMENT_TESTS_BIT barrier flags
2023-08-27 19:38:34 -03:00
d48b95a305
fix glMapBufferRange return null when r_index + last_item_index > max_instances
2023-08-27 18:00:35 +08:00
49177b6eeb
Make Windows' safe save more resilient
2023-08-25 18:28:35 +02:00
9c7db7397f
Fix integer value for GL_MAX_UNIFORM_BLOCK_SIZE overflowing
2023-08-25 10:19:25 -04:00
fef62a6860
Merge pull request #80781 from bitsawer/fix_vulkan_texture_upload
...
Fix Vulkan texture update
2023-08-21 19:32:12 +02:00
6cb28e481f
Fix memory access error for `MultiMesh` with GLES3
...
Buffer was incorrectly assigned when invalid data was provided
2023-08-19 16:01:21 +02:00
3daa19dd95
Fix Vulkan texture update
2023-08-19 12:18:54 +03:00
1537452aa9
Merge pull request #78013 from Calinou/cli-add-audio-output-latency-argument
...
Add a `--audio-output-latency` command-line argument
2023-08-17 15:43:14 +02:00
ce57c2379c
Abort on startup with a visible alert if required Vulkan features are missing
2023-08-17 14:48:36 +02:00
6f1152bdbe
Add a `--audio-output-latency` command-line argument
...
This allows optimizing the audio output latency on higher-end CPUs,
especially in projects that do not expose a way to override this setting.
2023-08-17 14:45:17 +02:00
c1dbc3dd04
Merge pull request #80288 from pkpro/memcpy_into_nullptr
...
Vulkan: Fix sanitizers error with empty shader name
2023-08-17 12:29:29 +02:00
5541567c1a
Merge pull request #80151 from WhalesState/Dev1
...
Fix GLES3 changing 2D shadow atlas size is broken
2023-08-17 11:23:24 +02:00
2987dd0c71
fix GLES3 changing 2d shadow atlas size is broken
2023-08-16 15:58:23 +00:00
9d9043a9c8
Merge pull request #80654 from bitsawer/fix_global_uniform_texture_set
...
Fix global shader uniform texture loading
2023-08-16 09:17:25 +02:00
d1b8e9abd6
Merge pull request #80571 from darksylinc/matias-resize-window-fix
...
Fix validation error when resizing window
2023-08-16 09:13:53 +02:00
04c2bc5a37
Merge pull request #80424 from DarioSamo/rd-buffer-copy-vulkan
...
Add `buffer_copy` method to RenderingDevice
2023-08-16 09:13:06 +02:00
0b09fdd96c
Fix validation error when resizing window
...
Sometimes when resizing the window we may get the following validation
error:
ERROR: VALIDATION - Message Id Number: -370888023 | Message Id Name:
VUID-vkAcquireNextImageKHR-semaphore-01286
Validation Error: [ VUID-vkAcquireNextImageKHR-semaphore-01286 ]
Object 0: handle = 0xdcc8fd0000000012, type = VK_OBJECT_TYPE_SEMAPHORE;
| MessageID = 0xe9e4b2a9 | vkAcquireNextImageKHR: Semaphore must not be
currently signaled or in a wait state. The Vulkan spec states: If
semaphore is not VK_NULL_HANDLE it must be unsignaled
(https://vulkan.lunarg.com/doc/view/1.2.198.1/linux/1.2-extensions/vkspec.html#VUID-vkAcquireNextImageKHR-semaphore-01286 )
In VulkanContext::prepare_buffers the problem was that
vkAcquireNextImageKHR returned VK_SUBOPTIMAL_KHR but it already signaled
the semaphore (because it is possible to continue normally with a
VK_SUBOPTIMAL_KHR result).
Then we recreate the swapchain and reuse the
w->image_acquired_semaphores[frame_index] which is in an inconsistent
state.
Fixed by recreating the semamphores along the swapchain.
Fix #80570
2023-08-15 20:57:49 -03:00
41def3740a
Fix global shader uniform texture loading
2023-08-15 14:18:26 +03:00
80a36ff985
Add support for GLSL source-level debugging with RenderDoc (`--generate-spirv-debug-info`)
2023-08-12 14:56:49 +02:00
0d7deca4e2
Add buffer_copy method to RenderingDevice interface and an implementation for the Vulkan driver.
...
Direct buffer copies are required to perform certain operations more efficiently, as the only current alternative is to download the buffer to the CPU and upload it again. As the first use case, the new function is used when enabling motion vectors on multimeshes.
2023-08-12 09:38:39 -03:00
77b02359c9
Vulkan: Fix sanitizers error with empty shader name
...
Co-authored-by: Rémi Verschelde <rverschelde@gmail.com>
2023-08-09 12:12:56 +02:00
8aa6f29b56
[FileAccess] Add methods to get/set "hidden" and "read-only" attributes on macOS/BSD and Windows.
2023-08-08 21:51:32 +03:00
1163dac9e3
Merge pull request #80215 from clayjohn/HDR-2D
...
Add option to enable HDR rendering in 2D
2023-08-08 16:57:33 +02:00
048a164083
Merge pull request #79693 from bruvzg/com_ath
...
[Windows] Initialize COM as apartment-threaded.
2023-08-07 14:48:40 +02:00
57eb762bae
Add option to enable HDR rendering in 2D
...
This is needed to allow 2D to fully make use of 3D effects (e.g. glow), and can be used to substantially improve quality of 2D rendering at the cost of performance
Additionally, the 2D rendering pipeline is done in linear space (we skip linear_to_srgb conversion in 3D tonemapping) so the entire Viewport can be kept linear.
This is necessary for proper HDR screen support in the future.
2023-08-07 11:24:03 +02:00
cc6a60913a
Merge pull request #78325 from akien-mga/libpng-moar-intrinsics
...
libpng: Enable intrinsics on x86/SSE2, ppc64/VSX, and all arm/NEON
2023-08-04 17:04:07 +02:00
2c9b7fc7a8
libpng: Enable intrinsics on x86/SSE2, ppc64/VSX, and all arm/NEON
2023-08-04 14:57:21 +02:00
9e844cc0c8
PulseAudio: Remove get_latency() caching
2023-08-04 15:35:13 +09:30
558f4b7559
Initialize shader placeholders up front
...
Then use the placeholder to create the shader instead of swapping RIDs
This fixes a false positive that reported leaked shaders
2023-08-03 16:13:33 +02:00
eda04c5658
Merge pull request #80071 from darksylinc/matias-fixes2
...
Fix validation layer warnings
2023-08-01 17:26:04 +02:00
bffbc5dd3e
Merge pull request #80070 from clayjohn/GLES3-depth-prepass
...
Enable depth writes during shadow pass and depth pass. Disable during color pass
2023-08-01 17:26:00 +02:00
1c40263665
Merge pull request #79606 from clayjohn/ShaderRD-compilation-groups
...
Shader rd compilation groups
2023-08-01 17:25:16 +02:00
8b12849fef
Merge pull request #79876 from LRFLEW/mobalpha
...
Fix transparent viewport backgrounds with custom clear color
2023-07-31 21:01:32 +02:00
4ce41495b1
Fix validation layer warnings
...
1. Validation layers on Windows were complaining w/
VUID-VkSwapchainCreateInfoKHR-surface-01270 that we were not calling
vkGetPhysicalDeviceSurfaceSupportKHR before vkCreateSwapchainKHR.
2. Godot was only calling vkGetPhysicalDeviceSurfaceSupportKHR at
startup, but it should be doing this for every window w/ a new surface
it wants to create, not just the first one.
- In practice this will likely not make a difference. If
vkGetPhysicalDeviceSurfaceSupportKHR returns false after initialization,
there's nothing we can do about it and it is likely because something
else went terribly wrong, which is why the error message is worded like
that.
- This is mostly to shut up validation layers. Though technically,
the layers are right.
3. Do not call vkGetPhysicalDeviceSurfaceSupportKHR on queues we don't
even plan on ever using. We don't know how drivers will react to that
(e.g. they may preemptetively allocate resources to support presentation
on exotic queues, instead of just saying no). Just behave like every
other Vulkan app out there.
2023-07-30 17:07:27 -03:00
b986afed46
Enable depth writes during shadow pass and depth pass. Disable during color pass
...
This fixes an unreported performance bug. Basically, without this change, the depth prepass did nothing
2023-07-30 21:59:28 +02:00
6effd3cde7
Fix transparent viewport backgrounds with custom clear color
2023-07-30 06:19:47 -05:00
472226422e
Fix uninitialized variable ending up sent to Vulkan
...
The first time a shader is compiled Godot performs the following:
```cpp
for (uint32_t i = 0; i < SHADER_STAGE_MAX; i++) {
if
(spirv_data.push_constant_stages_mask.has_flag((ShaderStage)(1 << i))) {
binary_data.push_constant_vk_stages_mask |=
shader_stage_masks[i];
}
}
```
However binary_data.push_constant_vk_stages_mask is never initialized to
0 and thus contains garbage data or'ed with the good data.
This value is used by push constants (and many other things) thus it can
be a big deal.
Fortunately because the relevant flags are always guaranteed to be set
(but not guaranteed to be unset), the damage is restricted to:
1. Performance (unnecessary flushing & over-excessive barriers)
2. Overwriting push descriptors already set (this would be serious,
doesn't seem to be an issue)
3. Driver implementations going crazy when they see bits set they don't
expect (unknown if this is an issue)
This uninitialized value is later saved into the binary cache.
Valgrind is able to detect this bug on the first run, but not on the
subsequent ones because they data comes from a file.
cache_file_version has been bumped to force rebuild of all cached
shaders. Because the ones generated so far are compromised.
2023-07-29 18:28:33 -03:00
1fe49e7271
Merge pull request #79142 from BastiaanOlij/register_render_buffers
...
Expose RenderSceneBuffers(RD) through ClassDB
2023-07-27 15:22:27 +02:00
d894a2ff57
Merge pull request #79883 from clayjohn/GLES3-shader-cache-dir
...
Check if shader cache directory is available before using cache
2023-07-26 18:40:35 +02:00
4874b96033
Expose RenderingSceneBuffers through ClassDB
2023-07-26 23:48:30 +10:00
63d6e9c557
Add custom texture create function
2023-07-26 20:46:34 +10:00
202e4b2c1e
Merge pull request #79884 from Dragoncraft89/master
...
Vulkan: Fix dangling pointers in `_clean_up_swap_chain`
2023-07-25 21:51:38 +02:00
7bb732cc38
Merge pull request #79866 from adamscott/fix-file-permissions-web
...
Fix file permissions for the web platform (affects every Unix-like platform)
2023-07-25 21:26:30 +02:00
3f2e901633
Merge pull request #79865 from clayjohn/discard-shader
...
Fix use of discard in shaders
2023-07-25 21:26:27 +02:00
08cffc128f
Merge pull request #79812 from ParsleighScumble/parsleigh/init-sky-scene-state
...
Use defaults to initialize sky data in case of no sky
2023-07-25 21:26:23 +02:00
7f7a2b2557
Fix dangling pointers in _clean_up_swap_chain
2023-07-25 14:41:57 +02:00
52fb5bf986
Check if shader cache directory is available before using cache
2023-07-25 14:33:37 +02:00
b6faccccd5
Fix file permissions for the web platform
2023-07-25 08:29:24 -04:00
7c812cd7e9
Fix use of discard in shaders
...
discard was being included in all shaders set to depth pass opaque, which is the majority of shaders
Instead it should only be used with alpha prepass materials
2023-07-24 23:21:04 +02:00
67c13fe4eb
Use defaults to initialize sky data in case of no sky
2023-07-24 10:41:13 -07:00
21524e26e0
Merge pull request #79849 from bitsawer/fix_particles_and_compute_threading
...
Fix Vulkan multithreaded compute list and GPU particle processing
2023-07-24 19:33:52 +02:00
b1f4e58bbf
Merge pull request #79772 from Malcolmnixon/gles-skeletons
...
Unbind the framebuffer when updating meshes
2023-07-24 19:33:27 +02:00
4ba24f6492
Merge pull request #79685 from LRFLEW/glinval
...
GLES3: Don't call `glTexParameter*` for invalid filter and repeat modes
2023-07-24 19:33:12 +02:00
3e9fadc1dd
Merge pull request #79660 from bitsawer/fix_opengl_multimesh
...
Fix GLES3 multimesh rendering when using colors or custom data
2023-07-24 19:33:05 +02:00
5d18e2ee00
Fix Vulkan multithreaded compute list and GPU particle processing
2023-07-24 12:56:55 +03:00
3e9173f11a
GLES3: Don't call glTexParameter* for invalid filter and repeat modes
2023-07-21 19:26:57 -05:00
679f5bf410
Unbind the framebuffer when updating meshes.
...
While the vertex shaders used to update the meshes aren't actually rendering to the framebuffer, they may still refuse to run with some framebuffers bound - such as XR with multiple views.
2023-07-21 19:34:12 -04:00
f932c1aba1
Merge pull request #79526 from Zylann/fix_rd_thread_safe
...
Fix missing `_THREAD_SAFE_METHOD_` missing from `RenderingDeviceVulkan` `submit` and `sync`
2023-07-21 17:54:39 +02:00
4acb8c66a1
Merge pull request #79568 from LRFLEW/glaniso
...
GLES3: Reset anisotropic filtering when changing texture filtering mode
2023-07-21 17:15:39 +02:00
e970f5249c
Add Shader compile groups to RD Shader system
...
This allows us to specify a subset of variants to compile at load time and conditionally other variants later.
This works seamlessly with shader caching.
Needed to ensure that users only pay the cost for variants they use
2023-07-21 16:42:30 +02:00
4bfb820d32
[Windows] Initialize COM as apartment-threaded.
2023-07-20 12:14:16 +03:00
9897f1cfb9
Fix GLES3 multimesh rendering when using colors or custom data
2023-07-20 11:54:34 +03:00
28001b9ef6
[Net] Explicitly handle buffer errors in send/recv
2023-07-19 10:08:25 +02:00
8722cbc0a0
Add missing thread-safe method macros to RD Vulkan submit and sync
2023-07-18 20:04:51 +01:00
90f0e97eb9
GLES3: reset anisotropic filtering when changing texture filtering mode
2023-07-17 00:18:39 -05:00
a22f495a3c
Split raster barrier into vertex and fragment barrier
2023-07-15 12:30:32 +10:00
7e21eb7e00
Extract and reorganize texture resource classes
2023-07-14 20:04:21 +02:00
bb15241e06
Merge pull request #77740 from ChibiDenDen/simplify_vulkan
...
Replace sampler arrays with constant sampler elements, simplify and reuse code for all shaders
2023-07-12 17:16:12 +02:00
a33b548092
Merge pull request #78168 from clayjohn/GLES3-gaussian-rt
...
Use Gaussian approximation for backbuffer mipmaps in GL Compatibility renderer
2023-07-12 15:08:57 +02:00
3cd865dbe8
Fix formatting of dlopen error message on Windows
...
And harmonize the format for all platforms.
Co-authored-by: Rémi Verschelde <rverschelde@gmail.com>
2023-07-09 23:39:45 +02:00
1453dc9d5d
Merge pull request #79143 from clayjohn/wayland-menu
...
Avoid freeze when interacting with menus on Wayland by re-aquiring next swapchain image after updating swapchain
2023-07-09 12:24:07 +02:00
43c0fa7f4b
Merge pull request #78797 from Calinou/remove-redundant-vformat
...
Remove uses of `vformat()` with no placeholders
2023-07-08 18:18:35 +02:00
98358b2822
Merge pull request #78794 from joemarshall/patch-1
...
Fix threading bug in Vulkan rendering device
2023-07-08 18:17:46 +02:00
df021b5063
Avoid freeze when interacting with menus on Wayland by re-aquiring next swapchain image after updating swapchain
2023-07-07 10:19:28 +02:00
c566b03f26
Merge pull request #78852 from clayjohn/Particles-glitch
...
Initialize particles instance buffer in case it is used before being updated
2023-07-07 08:28:28 +02:00
35ed7c770b
Initialize particles instance buffer in case it is used before being updated
2023-06-29 13:24:40 -07:00
dcc92c174e
Remove uses of `vformat()` with no placeholders
...
This is identical to passing the string directly.
2023-06-28 16:27:55 +02:00
c52fadbe75
fix threading bug in vulkan rendering device
2023-06-28 13:50:25 +01:00
7c37a32897
Use a filter with mipmaps when initializing textures with mipmaps in GL Compatibility renderer
...
This works around a driver bug in some older devices and should be harmless on any spec-compliant device
2023-06-26 10:45:24 -07:00
cc89321c9c
Reset filter/repeat state of textures in GL Compatibility renderer when render target is cleared
2023-06-23 10:57:56 -07:00
55fc56bfd4
Moved variables closer to usage to fix unused variable warning
2023-06-22 23:01:09 +02:00
cb73a6e9f9
Merge pull request #78490 from clayjohn/GLES3-particles-subemit
...
Add warnings and fallbacks for particles sub emitters when using the GL Compatibility rendering backend
2023-06-22 21:02:38 +02:00
df740f6865
free color and depth texture after check framebuffer complete failed
2023-06-22 09:13:24 +08:00
35715e510f
replace sampler arrays with constant sampler elements
2023-06-22 01:11:57 +03:00
8a5af8183a
Add warnings and fallbacks for particles sub emitters when using the GL Compatibility rendering backend
...
Co-authored-by: Hugo Locurcio <hugo.locurcio@hugo.pro>
2023-06-21 12:56:52 -07:00
dab0871d41
Fix invalid RID errors when freeing a mesh with blend shapes
2023-06-19 11:07:15 +03:00
131e49bf13
[Unix] Fix temporary file permissions.
2023-06-16 23:34:27 +03:00
c8e3f00e5d
GLES3: Remove unimplemented texture_create() declaration
2023-06-16 18:58:23 +08:00
7dddd8a22c
Merge pull request #78302 from clayjohn/GLES3-screen-warning
...
Remove outdated warning when using screen texture in GL Compatibility renderer
2023-06-16 10:23:27 +02:00
9e81aeda33
Merge pull request #78287 from clayjohn/GLES3-texture-replace
...
Copy texture filter/repeat modes when replacing a texture in the GL Compatibility backend
2023-06-16 10:23:03 +02:00
1710a7d303
Merge pull request #78285 from clayjohn/GLES3-viewport-filter
...
Ensure filter/repeat is cached by Viewport texture in GL Compatibility renderer
2023-06-16 10:22:33 +02:00
36a005fafc
Add RENDERING_INFO parameters to GL Compatibility renderer
...
This also fixes RENDERING_INFO_TOTAL_PRIMITIVES_IN_FRAME for the RD renderers as it was incorrectly reporting vertex/index count at times
This also adds memory tracking to textures and buffers to catch memory leaks.
This also cleans up some memory leaks that the new system caught.
2023-06-16 09:10:00 +02:00
8a7f02addb
Remove outdated warning when using screen texture in GL Compatibility renderer
2023-06-15 18:48:50 -07:00
96b2743782
Ensure filter/repeat is cached by Viewport texture in GL Compatibility renderer
2023-06-15 13:08:55 -07:00
3e211b7f74
Copy texture filter/repeat modes when replacing a texture in the GL Compatibility backend
2023-06-15 13:06:42 -07:00
bd786ce0d9
Fix for Win+M crashing the editor
...
Fixes #77790
Adds missing 'break' statement to 'VulkanContext::prepare_buffers' function.
It was mistakenly removed in #72859
2023-06-14 14:34:09 -03:00
e0651ed4b5
Merge pull request #78199 from clayjohn/detect_3d
...
Ensure that "detect 3D" is only called when using 3D shaders
2023-06-14 09:26:47 +02:00
6dd47e232b
Expose RD::texture_native_handle
2023-06-14 09:58:08 +10:00
0b7e2dfdfc
Ensure that "detect 3D" is only called when using 3D shaders
2023-06-13 13:20:11 -07:00
9721a27427
Use Gaussian approximation for backbuffer mipmaps in GL Compatibility renderer
2023-06-12 21:51:23 -07:00
9ce42d176d
Merge pull request #76977 from manueldun/light-shader-builtins
...
Enable the use of all supported builtins on the light shader
2023-06-09 11:04:46 +02:00
166643df32
Merge pull request #74937 from bitsawer/fix_uniform_storage
...
Fix shader uniform storage conversions and crash
2023-06-09 11:04:16 +02:00
e2321c21db
Enable the use of all builtins on the light shader
...
When using the light process in spatial shader,
the built-ins work as spected, now they work in forward+,
mobile and compatibility renderer.
2023-06-08 14:14:14 -04:00
9e4315bb50
Style: Harmonize header includes in platform ports
...
This applies our existing style guide, and adds a new rule to that style
guide for modular components such as platform ports and modules:
Includes from the platform port or module should be included with relative
paths (relative to the root folder of the modular component, e.g.
`platform/linuxbsd/`), in their own section before Godot's "core" includes.
The `api` and `export` subfolders also need to be handled as self-contained
(and thus use relative paths for their "local" includes) as they are all
compiled for each editor platform, without necessarily having the api/export
matching platform folder in the include path.
E.g. the Linux editor build will compile `platform/android/{api,export}/*.cpp`
and those need to use relative includes for it to work.
2023-06-08 15:19:19 +02:00
05142b6228
Properly update array textures when using the OpenGL backend to avoid crash
2023-06-07 15:44:11 -07:00
e75285f69f
Merge pull request #77946 from bruvzg/opengl_blend_cache
...
[OpenGL] Fix LCD blend mode color caching.
2023-06-07 11:02:30 +02:00
a2abea8b98
[OpenGL] Fix LCD blend mode color caching.
2023-06-07 10:55:38 +03:00
2c5e2196bd
Replace get_rendering_device() call to prevent crashes on OpenGL.
...
And make OpenGL video adapter info align with Vulkan.
2023-06-06 23:29:36 +02:00
3dd0307f3f
Merge pull request #76348 from warriormaster12/pipeline-cache
...
Implement Vulkan pipeline caching
2023-06-01 00:40:33 +02:00
dded713dc0
Implement Vulkan pipeline caching
2023-05-31 22:24:18 +03:00
23c375d6b4
Fix shader uniform storage conversions and crash
2023-05-29 15:17:13 +03:00
f2e91eae63
Merge pull request #77224 from patrickdown/implement_texture_2d_layered_initialize
...
Implemented texture_2D_layered_initialize
2023-05-29 10:29:08 +02:00
391a1bf60e
Implemented texture_2D_layered_initialize
2023-05-27 12:53:59 -05:00
f6dcd7f51a
Merge pull request #75181 from dalexeev/fix-light-only-mode
...
Fix "Light Only" mode of `CanvasItemMaterial`
2023-05-27 17:28:29 +02:00
6d3634e29f
fix gles texture uniform array binding
2023-05-26 23:11:02 +03:00
2ab0f17f3b
Merge pull request #77409 from allenwp/OpenGL3-Blend-Issue76334
...
Fixed issues with blend modes in OpenGL 3 renderer
2023-05-24 18:36:06 +02:00
51f0e36509
Fixed issues with blend modes in OpenGL 3 renderer
...
Added uses_blend_alpha = true for ADD, SUBTRACT, and MULTIPLY blend modes to match the other renderers
Fixes #76334
2023-05-24 10:35:23 -04:00
8b0530be64
Merge pull request #77022 from sakrel/fix_buffer_get_data
...
RenderingDeviceVulkan::buffer_get_data: Use draw command buffer instead of setup command buffer
2023-05-24 08:47:19 +02:00
852740a627
Merge pull request #76053 from MightiestGoat/fix-sky-auto-exposure
...
Fix the grainy sky while using debanding.
2023-05-24 08:46:28 +02:00
b917f748b5
Merge pull request #75945 from Calinou/renderingdevice-finalaction-fix-typo
...
Fix typo in FinalAction `switch` statement in RenderingDevice
2023-05-24 08:46:01 +02:00
05ddc822fb
Merge pull request #77265 from lyuma/aabb_bone_lod_inside
...
Fix calculation of skinned AABB for unused bones.
2023-05-22 13:49:19 +02:00
791d8001db
Fix AABB for unused bones
...
Fixes bug where bounding box of 1 unit was used in some skinned models and had wrong LODs.
(this could become very large if the mesh is scaled, such as FBX conversions)
Also fixes a mistake in calcualting bone index.
2023-05-19 19:47:52 -07:00
8a3e829930
(Re-)Implemented Light3D's property "shadow_reverse_cull_face"
...
The parameter shadow_reverse_cull_face is now passed to the shadow pass so that the mesh back-faces are used for shadow map calculation.
2023-05-19 19:22:10 +02:00
14e9a61ebc
Verify gles3 cached shader load successful
2023-05-17 19:36:30 +03:00
43b0702a02
Fix "Light Only" mode of `CanvasItemMaterial`
2023-05-13 09:06:09 +03:00
f52c151fcf
RenderingDeviceVulkan::buffer_get_data: Use draw command buffer instead of setup command buffer
2023-05-12 23:25:20 +02:00
373f2a8f8b
Merge pull request #76541 from KoBeWi/WAZZUP
...
Add mono audio support to WASAPI
2023-05-12 14:09:10 +02:00
d0305e5c62
Merge pull request #76959 from stolk/initlight
...
Initialize light intensity parameter before use.
2023-05-12 10:04:57 +02:00
cc48827e4a
Merge pull request #76946 from AThousandShips/shadow_warning
...
Enable shadow warnings and fix raised errors
2023-05-12 10:04:09 +02:00
14494e08d1
Initialize light intensity parameter before use.
...
Unlike renderer_rd, the gles3 light storage fails to initialize
the intensity of the light.
To avoid using garbage memory, possibly NaN, we use the same
default value that renderer_rd uses.
Fixes #76956
2023-05-11 09:46:46 -07:00
10797d58dd
fixed a query pool validation error
2023-05-11 17:17:23 +03:00
71ee65dc57
Enable shadow warnings and fix raised errors
2023-05-11 16:00:59 +02:00
564d1b34e0
Merge pull request #74711 from BastiaanOlij/add_texture_native_handle
...
Provide access to internal graphics handles for textures
2023-05-09 19:28:26 +02:00
668cf3c66f
Merge pull request #76832 from RandomShaper/cluster_render_prevail
...
Save cluster render shader from being optimized out entirely
2023-05-09 10:46:23 +02:00
1c7a62d2c0
Merge pull request #76092 from ChibiDenDen/shader_cache_gles3
...
Add shader cache to gles3
2023-05-09 10:45:10 +02:00
c328676d96
For GDExternal use, provides access to internal graphics handles for textures
2023-05-09 13:47:22 +10:00
6465432570
Save cluster render shader from being optimized out entirely
2023-05-08 18:39:49 +02:00
392fdd106d
Merge pull request #75937 from RandomShaper/threaded_render_load
...
Allow creation of rendering buffers at any time
2023-05-08 13:52:33 +02:00
e370b3538b
Merge pull request #74945 from ChibiDenDen/patch-3
...
Fix gles3 rendering on android studio emulator
2023-05-08 13:52:28 +02:00
5056c427d3
Improve RenderingServer, RenderingDevice, ShaderGlobalsOverride documentation
...
This brings the overall class reference completion percentage from 87% to 92%.
2023-05-06 22:40:32 +02:00
6441210177
Add ARB_get_program_binary to glad to support shader cache over desktop GL
2023-05-06 00:20:37 +03:00
39d85308fd
Merge pull request #76109 from paddy-exe/fix-node-position-view
2023-05-05 14:35:41 +02:00
5e9b7c3452
Merge pull request #75055 from JohanAR/light_specular
2023-05-05 13:53:02 +02:00
59f04e16b8
Support long path in file access on windows
...
Changed windows file access file to check for path length and use the \\?\ long format when needed
2023-05-05 10:04:39 +02:00
8452e6cdb3
Add SPECULAR_AMOUNT spatial light shader built-in
...
Light3D has a light_specular property which is used to set the
intensity of specular contributed by this light source, but it was
previously only used by the default material light shader, and not
possible to use in a custom light() shader.
2023-05-04 09:15:12 +02:00
e35bbd76a3
Fix Rotation Issue with NODE_POSITION_VIEW Visual Shader Node
2023-05-03 19:59:43 +02:00
5956aa1a6a
Fix gles3 rendering on android studio emulator
...
Use a temporary framebuffer for screen copy from rendertarget to screen.
This solves GLES3 rendering in android studio emulator (before this change there is just a black screen)
Based on discussion in:
https://github.com/godotengine/godot/issues/74828
2023-04-29 16:21:54 +03:00
8d010b44c1
Add mono audio support to WASAPI
2023-04-28 13:29:43 +02:00
4aaa2e6477
Fix wait for thread not started
2023-04-27 20:28:22 +02:00
359b494cbe
Merge pull request #76437 from RandomShaper/fix_vol_fog_voxel_gi
...
Fix voxel GI issues
2023-04-27 08:19:06 +02:00
09aa1bbdb3
Fix unsupported sampler filter used for voxel GI
2023-04-26 20:54:06 +02:00
b58873b98a
Merge pull request #69833 from Eoin-ONeill-Yokai/audio_invalid_mixrate
...
Fix crash caused by invalid mix_rate assignment due to bogus project settings.
2023-04-26 11:35:37 +02:00
5a08091168
Fix crash caused by invalid mix_rate assignment due to bogus
...
project settings.
We'll default to a sensible value in the case that a user has
somehow managed to modify the configuration file incorrectly.
Closes 69819
2023-04-25 23:52:50 -07:00
367ad3545d
Merge pull request #76315 from RandomShaper/vk_fix_barriers
...
Fix issues with Vulkan layout transitions
2023-04-25 09:59:55 +02:00
628f3b2f79
[OS] Implement and expose to scripting APIs `get_memory_info` method instead of old `get_free_static_memory`.
2023-04-24 14:08:55 +03:00
882b869220
Fix issues with Vulkan layout transitions
2023-04-24 12:24:24 +02:00
14a8124ffe
Add LIGHT_IS_DIRECTIONAL built-in for spatial shaders
2023-04-20 14:33:30 +02:00
27253f3eb2
Merge pull request #76240 from clayjohn/Light2D-artifacts
...
Clamp normal when calculating 2D lighting to avoid artifacts
2023-04-19 10:13:56 +02:00
ab603e347f
Clamp normal when calculating 2D lighting to avoid artifacts
2023-04-18 17:26:17 -07:00
c2edf14faf
Merge pull request #75881 from bruvzg/win_coinit
...
[Windows] Cleanup COM library initialization/uninitialization.
2023-04-18 23:40:06 +02:00
63d17df83e
Merge pull request #74978 from bruvzg/linux_version_check
...
[Linux/BSD] Add dynamically loaded library version checks.
2023-04-18 23:38:51 +02:00
4adbfcfbb2
Add shader cache to gles3
2023-04-15 18:41:10 +03:00
69f634ac78
Fix the grainy sky while using debanding
2023-04-15 10:43:46 +05:30
e6e52f9154
Merge pull request #75162 from ecmjohnson/gpuparticles_inf_translate
...
GPUParticles3D: Translate inactive particles to -INF
2023-04-13 09:53:04 +02:00
6229c2a1f9
Translate inactive particles to -INF
2023-04-12 19:32:39 -04:00
9be0a73294
Add EXPOSURE built in to spatial shaders
...
This allows users to restore light values to pre-pre-exposure amounts
2023-04-12 10:35:13 -07:00
5e34a28bd7
Merge pull request #73313 from clayjohn/particles-split
...
Properly calculate lifetime_split for particles
2023-04-12 17:01:17 +02:00
6e0c7d6a98
Merge pull request #75968 from clayjohn/GL-depth-write
...
Ensure that depth write state is updated before transparent pass in OpenGL3 renderer
2023-04-12 09:08:30 +02:00
ecbb196728
Merge pull request #75954 from clayjohn/GL-multimesh-one
...
Check for instancing without relying on instance_count when drawing 2D meshes
2023-04-12 09:08:06 +02:00
6a6e36ec6a
Merge pull request #75795 from cody82/fix-html-particle-shader
...
Fix "error X3708: continue cannot be used in a switch" in HTML export
2023-04-12 09:06:57 +02:00
ed0c378bda
Ensure that depth write state is updated before transparent pass in OpenGL3 renderer
2023-04-11 21:17:24 -07:00
579ca03e88
Check for instancing without relying on instance_count when drawing 2D meshes
...
This ensures that Particles and MultiMeshes still draw when instance_count is 1
2023-04-11 16:58:42 -07:00
347a8e20ae
Merge pull request #69324 from RedMser/advanced-settings-errors
...
Make it easier to solve warnings/errors referring to project settings
2023-04-11 19:39:53 +02:00
dd53037f74
Fix typo in FinalAction `switch` statement in RenderingDevice
2023-04-11 18:44:12 +02:00
d4c46f15ae
Allow creation of rendering buffers at any time
2023-04-11 16:33:47 +02:00
83dc545ea2
[Windows] Cleanup COM library initialization/uninitialization.
2023-04-10 10:38:25 +03:00
5062df41a5
Fix "error X3708: continue cannot be used in a switch" in HTML export
2023-04-07 23:16:10 +02:00
154a29d33a
Merge pull request #74808 from bradc6/feature/AllowCustomOutputShaderGenFilepaths
...
Allow for shaders to be generated outside of the source tree
2023-04-03 16:01:32 +02:00
253b4875f3
Merge pull request #72859 from clayjohn/VK-suboptimal
...
Recreate swap chain when suboptimal to avoid error spam
2023-04-03 15:57:43 +02:00
fe0949e950
Merge pull request #72361 from the-brickster/master
...
Incorporating the availability of screen and depth textures for the GLES3 backend
2023-03-27 16:24:01 +02:00
ed960453b7
Make solving project setting errors easier
...
Show full project setting path in error messages.
Force filtering for advanced settings if filter is not empty.
2023-03-27 08:10:35 +02:00
09465f3fe6
Remove (or make verbose only) various debug prints.
2023-03-20 08:14:18 +02:00
bed46f723c
[Linux/BSD] Add dynamically loaded library version checks.
2023-03-20 08:10:56 +02:00
2302c7102f
Allow for external python scripts to call the build python headers via external scripts
...
Change GLES3 to not use a relative path
Make the parameters more explicit and ensure the shaders generated are not using relative paths
2023-03-19 21:18:52 -07:00
ca58a5d56f
Fix Unix temp file creations when using is_backup_save_enabled.
2023-03-18 20:28:30 +02:00
ded38c5d75
Merge pull request #73839 from clayjohn/OUTPUT_IS_SRGB
...
Clean up OUTPUT_IS_SRGB redefinitions
2023-03-16 13:03:37 +01:00
ea31842b72
Merge pull request #73156 from gw2cc/safe_save
...
Create a safe temporary file with is_backup_save_enabled
2023-03-16 12:05:48 +01:00
345f5757e5
Create a safe temporary file with is_backup_save_enabled
2023-03-15 19:36:07 +01:00
70dca9ff55
Merge duplicate rd_texture functions
2023-03-10 21:37:01 +11:00
d150bb84a6
Merge pull request #74566 from clayjohn/GL-canvas-texture
...
Avoid copying CanvasTexture when updating proxy
2023-03-08 08:59:04 +01:00
23bbf6b37c
Merge pull request #74533 from SlugFiller/fix-clip-no-children
...
Fixes a canvas item set to clip children being drawn as black if no children are visible
2023-03-08 08:57:00 +01:00
a0ff87f48d
Merge pull request #74416 from SlugFiller/fix-skeleton2d-aabb
...
Fix AABB calculation for meshes using Skeleton2D
2023-03-08 08:56:12 +01:00
84482ef90b
Avoid copying CanvasTexture when updating proxy
2023-03-07 12:48:32 -08:00
f25508befb
Fixes a canvas item set to clip children being drawn as black if no children are visible
2023-03-07 09:53:26 +02:00
06042a23b6
Avoid overflow when calculating ptr address for 3D textures in RenderingDevice texture update
2023-03-06 15:46:40 -08:00
06a1fe0364
Fix AABB calculation for meshes using Skeleton2D
2023-03-05 08:21:08 +02:00
46b416f3b1
Add proper default texture filter and repeat modes for Canvas shaders in the OpenGL3 renderer
2023-03-03 10:58:57 -08:00
ec6e072836
Merge pull request #73966 from the-brickster/GLES3_GL_POINT_FIX
...
Solution for resolving the issue of point size not functioning correctly in GLES3
2023-03-02 11:23:48 +01:00
c69b14e96e
Add warnings for unsupported features in mobile and gl_compatibility backends
2023-02-26 12:28:02 -08:00
f23f0a27c1
Commit Fix for GLES3 point size not working
2023-02-25 23:39:43 -08:00
316cf04059
Clean up OUTPUT_IS_SRGB redefinitions
2023-02-23 12:56:42 -08:00
ae21832823
Merge pull request #73622 from ChibiDenDen/patch-2
...
Fix use-after-free for VkAttachmentReference
2023-02-21 21:15:43 +01:00
5e57205365
Merge pull request #73478 from NewDefectus/master
...
Use the original canvas to calculate light positioning
2023-02-21 21:14:51 +01:00
2d7db30f0d
Use the original canvas to calculate light positioning
2023-02-21 11:57:16 +02:00
94831c7209
Forbid passing multiview sampler to the custom function in shaders
2023-02-21 11:23:17 +03:00
d68cfb43ef
Merge pull request #73662 from BastiaanOlij/fix_opengl_wobbly_sky
...
Fix wobbly sky in stereoscopic OpenGL
2023-02-21 07:16:21 +01:00
c71fea4467
Merge pull request #73659 from BastiaanOlij/fix_opengl_clearscreen
...
Fix issue with clearing screen after part has been drawn
2023-02-21 07:16:00 +01:00
2852c9c319
Fix wobbly sky in stereoscopic OpenGL
2023-02-21 16:11:57 +11:00
67cb660532
Fix issue with clearing screen after part has been drawn
2023-02-21 14:18:23 +11:00
d104d8447b
Fix use-after-free for VkAttachmentReference
...
In the flow where VK_KHR_CREATE_RENDERPASS_2_EXTENSION_NAME does not exist
VkAttachmentReference are created inside a loop and their backing buffer is referenced in the subpass object.
the VkAttachmentReference vectors are freed once the loop exists, causing the subpass to point to freed data.
Add all the VkAttachmentReference to a vector in the scope of the entire function, to ensure they are not freed until vkCreateRenderPass is called
2023-02-20 11:54:52 +02:00
aeab31b13a
Fix bufSize parameter for glGetSynciv
...
According to the docs:
https://registry.khronos.org/OpenGL-Refpages/es3.0/html/glGetSynciv.xhtml
Bufsize is in integers, not bytes.
The current code overflows data unto other stack variables.
2023-02-20 11:35:28 +02:00
37589edf17
Merge pull request #73524 from clayjohn/GL-occluder
...
Avoid unnecessary binding of occlusion polygon vertex array
2023-02-18 16:19:44 +01:00
5bbf5b8e72
Avoid unecessary binding of occlusion polygon vertex array
...
By binding this and unbinding it, the state was getting modified in other parts of the pipeline
2023-02-17 13:11:25 -08:00
98697b05d8
Incorporating the availability of screen and depth textures for the GLES3 backend
2023-02-16 21:18:58 -08:00
7f8fa79e94
OpenGL: fix culling without depth prepass
...
This commit ensures a known backface culling state when rendering, even
if no depth prepass is used. This fixes backside culling not being
applied properly in some situations, most notably in scenes that only
use backside culling on mobile platforms.
2023-02-17 00:01:36 +01:00
29f670b7ab
Merge pull request #73359 from bruvzg/so_wrap_opt
...
[Linux] Make SO wrapper usage optional.
2023-02-16 18:35:04 +01:00
dd068794c3
[Linux] Make SO wrapper usage optional.
2023-02-16 16:38:47 +02:00
bc95b0b171
Restore FileAccess.close method.
2023-02-16 15:34:20 +02:00
aa6ec76317
Merge pull request #73332 from clayjohn/GL-h2f-branch
...
Avoid branch in half2float in gl_compatibility renderer
2023-02-15 22:46:47 +01:00
58bad55d42
Avoid branch in half2float in gl_compatibility renderer
2023-02-14 20:31:36 -08:00
f35ca4a9c7
Properly calculate lifetime_split for particles
2023-02-14 14:37:47 -08:00
081b31d200
Clear Window before blitting Viewport in gl_compatibility renderer
2023-02-14 10:30:02 -08:00
1a206d0e22
Merge pull request #73263 from clayjohn/render_priority
...
Notify mesh surface when render_priority changes
2023-02-14 11:05:28 +01:00
1f18e16a32
Merge pull request #73255 from clayjohn/GLES3-batch-blend
...
Store blend mode between CanvasItems to preserve batching
2023-02-14 11:01:44 +01:00
d3b3419aff
Notify mesh surface when render_priority changes
...
This ensures that the mesh properly takes render_priority into account when changed
2023-02-13 18:09:33 -08:00
ab4e79cd03
Store blend mode between CanvasItems to preserve batching
2023-02-13 14:46:26 -08:00
0668e0f5a9
Merge pull request #69001 from dzil123/fix_rendering_checks
...
Fix various missing rendering parameter checks
2023-02-13 21:07:05 +01:00
b66f3846b4
Make present mode info message print only on change
...
Styling fix
2023-02-12 16:08:11 +03:00
089dbecef4
Make draw command labels thread safe
2023-02-10 21:27:31 +01:00
ed85a2c8ce
Merge pull request #70663 from EpEpDragon/feature_buffer_get_data_size_option
...
Add optional size parameter to the RenderDevice buffer_get_data method.
2023-02-10 18:49:28 +01:00
f6d22df072
Properly reset blend mode when resetting canvas in compatibility renderer
2023-02-09 15:50:17 -08:00
c36460060e
Further refactoring to AudioDriver implementations after #69120 .
...
- Rename all instances of `capture_start()` and `capture_end()` to their new
names. Fixes #72892 .
- More internal renames to match what was started in #69120 .
- Use `override` consistently so that such refactoring bugs can be caught.
- Harmonize the order of definition of the overridden virtual methods in each
audio driver.
- Harmonize prototype for `set_output_device` and `set_input_device`.
Co-authored-by: Rémi Verschelde <rverschelde@gmail.com>
2023-02-09 11:02:00 +01:00
a7f3b4459a
Handle 0 exponent in float/half conversion for OpenGl
2023-02-08 20:41:44 +01:00
1258de0d70
Merge pull request #72858 from clayjohn/VK-swap-buffers-err
...
Add more debug information to swapchain errors in Vulkan context
2023-02-08 09:34:13 +01:00
22291d7ae2
Add more debug information to swapchain errors in Vulkan context
2023-02-07 13:52:36 -08:00
c9d2bc91aa
Recreate swap chain when suboptimal to avoid error spam
2023-02-07 13:43:14 -08:00
76caf3fbae
Set instancing flags when using GPUParticles in OpenGL renderer
2023-02-07 10:45:34 -08:00
56450fb179
Implement cull_mask for decals and lights in mobile and compatibility backends
2023-02-06 12:12:47 -08:00
2bd5302704
Merge pull request #72695 from clayjohn/CanvasGroup-shading
...
Avoid shading CanvasGroup nodes twice
2023-02-04 21:38:25 +03:00
dfbf439081
Avoid shading CanvasGroup nodes twice
2023-02-03 15:40:42 -08:00
0b1d516f67
Merge pull request #72684 from clayjohn/mm-update
...
Fix MultiMesh visible_instance_count being ignored after the first frame
2023-02-04 00:40:36 +01:00
a268dcc7e3
Merge pull request #72690 from Calinou/opengl-trim-gpu-name
...
Trim "/PCIe/SSE2" from GPU names when starting the OpenGL renderer
2023-02-04 00:37:28 +01:00
1253547837
Merge pull request #72681 from clayjohn/GL-multimesh-color
...
Ignore instance color and instance custom_data when not used in the OpenGL renderer
2023-02-04 00:24:39 +01:00
da81c3f9b5
Trim "/PCIe/SSE2" from GPU names when starting the OpenGL renderer
...
This makes the command line print consistent with the Vulkan renderer.
2023-02-03 23:28:41 +01:00
497f5576c1
Fix MultiMesh visible_instance_count being ignored after the first frame
...
Co-authored-by: Clay John <claynjohn@gmail.com>
2023-02-03 11:40:39 -08:00
bf0cc8f52a
Ignore instance color and instance custom_data when not used in the OpenGL renderer
2023-02-03 10:34:30 -08:00
f3e8300b50
Print name of Vulkan rendering method on startup
...
This helps troubleshooting as the CLI logs now distinguish between
Forward+ and Forward Mobile.
2023-02-03 13:01:48 +01:00
ddca070bea
Merge pull request #72631 from rburing/custom_aabb_update_dependency
...
Notify dependencies when setting custom mesh AABB
2023-02-03 06:24:51 +01:00
ec3adb93f7
Merge pull request #72589 from BastiaanOlij/add_layer_slice_support
...
Add layer slice support to render device and render buffers
2023-02-03 06:24:43 +01:00
Juan Linietsky
Matias N. Goldberg
jsjtxietian
Pedro J. Estébanez
Adam Scott
Rémi Verschelde
A Thousand Ships
bitsawer
Hugo Locurcio
Mounir Tohami
sakrel
Dario
Pavel Kraynyukhov
bruvzg
clayjohn
Rémi Verschelde
Luke Hubmayer-Werner
Yuri Sizov
LRFLEW
Bastiaan Olij
Florian Kothmeier
Parsleigh Scumble
Malcolm Nixon
Fabio Alessandrelli
Marc Gilleron
Hendrik Brucker
Kamil Brzoskowski
Joe Marshall
Brecht Kuppens
Qiqi Wu
ChibiDenDen
jpcerrone
Manuel Dun
MJacred
warriormaster12
patrickdown
Yuri Sizov
Allen Pestaluky
Lyuma
Markus Grafen
Danil Alexeev
Bram Stolk
Ninni Pipping
Max Hilbrunner
Samuele Panzeri
Johan Aires Rastén
Patrick
kobewi
Eoin O'Neill
mightygoat
Erik Johnson
cody
RedMser
Bradley Clemetson
ACB
SlugFiller
LandoUWB
Alon Ran
Yuri Rubinsky
rsjtdrjgfuzkfg
Wiktor Kocielski
Emmanouil Papadeas
JoJoX
Ricardo Buring